)]}'
{"horizon/tables/base.py":[{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"87aee2526177c84bdecbdeb568a287f879286aea","unresolved":false,"context_lines":[{"line_number":973,"context_line":"        self.pagination_param \u003d getattr(options, \u0027pagination_param\u0027, \u0027marker\u0027)"},{"line_number":974,"context_line":"        self.browser_table \u003d getattr(options, \u0027browser_table\u0027, None)"},{"line_number":975,"context_line":"        self.footer \u003d getattr(options, \u0027footer\u0027, True)"},{"line_number":976,"context_line":"        self.hidden_title \u003d getattr(options, \u0027hidden_title\u0027, True)"},{"line_number":977,"context_line":"        self.no_data_message \u003d getattr(options,"},{"line_number":978,"context_line":"                                       \"no_data_message\","},{"line_number":979,"context_line":"                                       _(\"No items to display.\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_838cfb80","line":976,"updated":"2014-11-13 15:13:57.000000000","message":"It seems the bug is described as hiding the table title if it matches the page title, which is mostly applicable to single table views. Otherwise - if there is a multi table view - keeping titles is ok.\nAlso, for single table views - if the table name is different from the page title - then maybe it is better to hide the table title and update the page title with the proper name? \n\nAnd going further in this direction - instead of adding a new flag to the Table class, maybe there is an easier and cleaner approach - to hide the title through \n\n    tables.MultiTableView\n\nclass - in the case when we have multiple tables - then show the title of each table, otherwise - hide it.","commit_id":"09bb55859269e1cc9d0fa63d73d9be4debcc48de"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"7ab120d5a45257532dc9c57f2ac44cf4206a285c","unresolved":false,"context_lines":[{"line_number":973,"context_line":"        self.pagination_param \u003d getattr(options, \u0027pagination_param\u0027, \u0027marker\u0027)"},{"line_number":974,"context_line":"        self.browser_table \u003d getattr(options, \u0027browser_table\u0027, None)"},{"line_number":975,"context_line":"        self.footer \u003d getattr(options, \u0027footer\u0027, True)"},{"line_number":976,"context_line":"        self.hidden_title \u003d getattr(options, \u0027hidden_title\u0027, True)"},{"line_number":977,"context_line":"        self.no_data_message \u003d getattr(options,"},{"line_number":978,"context_line":"                                       \"no_data_message\","},{"line_number":979,"context_line":"                                       _(\"No items to display.\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_1614cb42","line":976,"in_reply_to":"5a890539_838cfb80","updated":"2014-11-13 15:31:56.000000000","message":"I found that the level of nested classes and render calls that happen when one of the panels is rendered out meant that if I set up a context in one class e.g. tables.DataTableView, I was unable to access it when I finally reached the template for rendering the table, and there didn\u0027t appear to be a way to pass that information down the chain so it was available to toggle the title.\n\nI did started off with the intention of automating the decision but short of running a regex or something similar over the completely rendered html just before it is returned to the browser, I feel that putting a flag on the table and leaving it down to the developers discretion was the neatest solution.","commit_id":"09bb55859269e1cc9d0fa63d73d9be4debcc48de"}],"horizon/templates/horizon/common/_data_table.html":[{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"5be4edde8759d983193d13753e7459395024e205","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  {% block table_caption %}"},{"line_number":10,"context_line":"      \u003ctr class\u003d\u0027table_caption\u0027\u003e"},{"line_number":11,"context_line":"        \u003cth class\u003d\u0027table_header\u0027 colspan\u003d\u0027{{ columns|length }}\u0027\u003e"},{"line_number":12,"context_line":"          {% if not hidden_table %}"},{"line_number":13,"context_line":"            \u003ch3 class\u003d\u0027table_title\u0027\u003e{{ table }}\u003c/h3\u003e"},{"line_number":14,"context_line":"          {% endif %}"},{"line_number":15,"context_line":"          {{ table.render_table_actions }}"}],"source_content_type":"text/html","patch_set":1,"id":"5a890539_6c91c198","line":12,"updated":"2014-11-13 14:33:14.000000000","message":"Are you sure that here should be \u0027hidden_table\u0027 and not \u0027hidden_title\u0027?","commit_id":"6a5e6325401077ee52a353940941fc69414ed42a"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"1fef0bc3356e88e5876cde82094b4490100631c3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  {% block table_caption %}"},{"line_number":10,"context_line":"      \u003ctr class\u003d\u0027table_caption\u0027\u003e"},{"line_number":11,"context_line":"        \u003cth class\u003d\u0027table_header\u0027 colspan\u003d\u0027{{ columns|length }}\u0027\u003e"},{"line_number":12,"context_line":"          {% if not hidden_table %}"},{"line_number":13,"context_line":"            \u003ch3 class\u003d\u0027table_title\u0027\u003e{{ table }}\u003c/h3\u003e"},{"line_number":14,"context_line":"          {% endif %}"},{"line_number":15,"context_line":"          {{ table.render_table_actions }}"}],"source_content_type":"text/html","patch_set":1,"id":"5a890539_aca2c9ab","line":12,"in_reply_to":"5a890539_6c91c198","updated":"2014-11-13 14:38:15.000000000","message":"Yep, this should be \u0027hidden_title\u0027.","commit_id":"6a5e6325401077ee52a353940941fc69414ed42a"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"1ee9c58c96b4424bf3d37ac4f19eda223af80b37","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  {% block table_caption %}"},{"line_number":10,"context_line":"      \u003ctr class\u003d\u0027table_caption\u0027\u003e"},{"line_number":11,"context_line":"        \u003cth class\u003d\u0027table_header\u0027 colspan\u003d\u0027{{ columns|length }}\u0027\u003e"},{"line_number":12,"context_line":"          {% if not hidden_table %}"},{"line_number":13,"context_line":"            \u003ch3 class\u003d\u0027table_title\u0027\u003e{{ table }}\u003c/h3\u003e"},{"line_number":14,"context_line":"          {% endif %}"},{"line_number":15,"context_line":"          {{ table.render_table_actions }}"}],"source_content_type":"text/html","patch_set":1,"id":"5a890539_0c3afd35","line":12,"in_reply_to":"5a890539_aca2c9ab","updated":"2014-11-13 14:40:50.000000000","message":"Good catch, thank you, that was my own error transferring the changes off my test server.","commit_id":"6a5e6325401077ee52a353940941fc69414ed42a"}]}
