)]}'
{"openstack_dashboard/api/nova.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"9a464de807c1968cfd1627c47a60890bd003c22f","unresolved":false,"context_lines":[{"line_number":797,"context_line":""},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"def service_disable(request, host, binary, reason\u003dNone):"},{"line_number":800,"context_line":"    if not reason:"},{"line_number":801,"context_line":"        return novaclient(request).services.disable(host, binary)"},{"line_number":802,"context_line":"    else:"},{"line_number":803,"context_line":"        return novaclient(request).services.disable_log_reason(host,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_1abb6573","line":800,"updated":"2014-11-19 14:08:31.000000000","message":"would be easier to read if using positive check:\n\nif reason:\n    call disable_log_reason\nelse:\n    call disable","commit_id":"39bea6b8c9e2044f4040d5bd39def02c9a0a920e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"d0c42d877d95fb3b16454da559bc48288b639043","unresolved":false,"context_lines":[{"line_number":797,"context_line":""},{"line_number":798,"context_line":""},{"line_number":799,"context_line":"def service_disable(request, host, binary, reason\u003dNone):"},{"line_number":800,"context_line":"    if not reason:"},{"line_number":801,"context_line":"        return novaclient(request).services.disable(host, binary)"},{"line_number":802,"context_line":"    else:"},{"line_number":803,"context_line":"        return novaclient(request).services.disable_log_reason(host,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_be730e14","line":800,"in_reply_to":"5a890539_1abb6573","updated":"2014-11-20 00:44:43.000000000","message":"Done","commit_id":"39bea6b8c9e2044f4040d5bd39def02c9a0a920e"}],"openstack_dashboard/dashboards/admin/hypervisors/compute/forms.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"9a464de807c1968cfd1627c47a60890bd003c22f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            redirect \u003d reverse(\"horizon:admin:hypervisors:index\")"},{"line_number":91,"context_line":"            msg \u003d _(\"Failed to disable compute service for host: %s.\") % \\"},{"line_number":92,"context_line":"                data[\"host\"]"},{"line_number":93,"context_line":"            exceptions.handle(request, message\u003dmsg, redirect\u003dredirect)"},{"line_number":94,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_25b562cd","line":93,"updated":"2014-11-19 14:08:31.000000000","message":"don\u0027t think redirect is necessary here. If you returned False here, it will keep the modal opened.","commit_id":"39bea6b8c9e2044f4040d5bd39def02c9a0a920e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"d0c42d877d95fb3b16454da559bc48288b639043","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            redirect \u003d reverse(\"horizon:admin:hypervisors:index\")"},{"line_number":91,"context_line":"            msg \u003d _(\"Failed to disable compute service for host: %s.\") % \\"},{"line_number":92,"context_line":"                data[\"host\"]"},{"line_number":93,"context_line":"            exceptions.handle(request, message\u003dmsg, redirect\u003dredirect)"},{"line_number":94,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_dec61a16","line":93,"in_reply_to":"5a890539_25b562cd","updated":"2014-11-20 00:44:43.000000000","message":"Done","commit_id":"39bea6b8c9e2044f4040d5bd39def02c9a0a920e"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"a930085fe549a8d7e13d9c53abe7715e555ba89c","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            msg \u003d _(\"Failed to disable compute service for host: %s.\") % \\"},{"line_number":91,"context_line":"                data[\"host\"]"},{"line_number":92,"context_line":"            exceptions.handle(request, message\u003dmsg)"},{"line_number":93,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_05e5aaa7","line":93,"updated":"2014-11-20 06:22:16.000000000","message":"Hi Yingjun, seems it\u0027s better to add redirect to the exceptions handle method above than return False. I don\u0027t think we need to keep the modal opened when there\u0027s an exception occured here.","commit_id":"7f94b45a13813dee72c9fe00eb4b19708ff437b0"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"9f21ab7abd3dccf4cd56dd9938d95051e9618333","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            msg \u003d _(\"Failed to disable compute service for host: %s.\") % \\"},{"line_number":91,"context_line":"                data[\"host\"]"},{"line_number":92,"context_line":"            exceptions.handle(request, message\u003dmsg)"},{"line_number":93,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_289a7b6e","line":93,"in_reply_to":"5a890539_05e5aaa7","updated":"2014-11-20 06:52:28.000000000","message":"Seems reasonable to me, updated, thanks.","commit_id":"7f94b45a13813dee72c9fe00eb4b19708ff437b0"}],"openstack_dashboard/dashboards/admin/hypervisors/compute/tables.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"9a464de807c1968cfd1627c47a60890bd003c22f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        return self.datum.state \u003d\u003d \"down\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class DisableService(tables.LinkAction):"},{"line_number":59,"context_line":"    name \u003d \"disable\""},{"line_number":60,"context_line":"    verbose_name \u003d _(\"Disable Service\")"},{"line_number":61,"context_line":"    url \u003d \"horizon:admin:hypervisors:compute:disable_service\""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_050f86e2","line":58,"updated":"2014-11-19 14:08:31.000000000","message":"Missing policy.PolicyTargetMixin","commit_id":"39bea6b8c9e2044f4040d5bd39def02c9a0a920e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"d0c42d877d95fb3b16454da559bc48288b639043","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        return self.datum.state \u003d\u003d \"down\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class DisableService(tables.LinkAction):"},{"line_number":59,"context_line":"    name \u003d \"disable\""},{"line_number":60,"context_line":"    verbose_name \u003d _(\"Disable Service\")"},{"line_number":61,"context_line":"    url \u003d \"horizon:admin:hypervisors:compute:disable_service\""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_9ee492ad","line":58,"in_reply_to":"5a890539_050f86e2","updated":"2014-11-20 00:44:43.000000000","message":"Done","commit_id":"39bea6b8c9e2044f4040d5bd39def02c9a0a920e"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"9a464de807c1968cfd1627c47a60890bd003c22f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    name \u003d \"disable\""},{"line_number":60,"context_line":"    verbose_name \u003d _(\"Disable Service\")"},{"line_number":61,"context_line":"    url \u003d \"horizon:admin:hypervisors:compute:disable_service\""},{"line_number":62,"context_line":"    classes \u003d (\"ajax-modal\", \"btn-danger\")"},{"line_number":63,"context_line":"    policy_rules \u003d ((\"compute\", \"compute_extension:services\"),)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_c5d2de33","line":62,"updated":"2014-11-19 14:08:31.000000000","message":"Not sure if this needs to prompted for danger, as this will not executed right away. So the user will have an opportunity to change his mind when the Disable Service form pops up.","commit_id":"39bea6b8c9e2044f4040d5bd39def02c9a0a920e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"d0c42d877d95fb3b16454da559bc48288b639043","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    name \u003d \"disable\""},{"line_number":60,"context_line":"    verbose_name \u003d _(\"Disable Service\")"},{"line_number":61,"context_line":"    url \u003d \"horizon:admin:hypervisors:compute:disable_service\""},{"line_number":62,"context_line":"    classes \u003d (\"ajax-modal\", \"btn-danger\")"},{"line_number":63,"context_line":"    policy_rules \u003d ((\"compute\", \"compute_extension:services\"),)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_3eed5e8c","line":62,"in_reply_to":"5a890539_c5d2de33","updated":"2014-11-20 00:44:43.000000000","message":"Done","commit_id":"39bea6b8c9e2044f4040d5bd39def02c9a0a920e"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"9a464de807c1968cfd1627c47a60890bd003c22f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    policy_rules \u003d ((\"compute\", \"compute_extension:services\"),)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @staticmethod"},{"line_number":66,"context_line":"    def action_present(count):"},{"line_number":67,"context_line":"        return ungettext_lazy("},{"line_number":68,"context_line":"            u\"Disable Service\","},{"line_number":69,"context_line":"            u\"Disable Services\","}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_65476a1e","line":66,"updated":"2014-11-19 14:08:31.000000000","message":"This structure of defining the action_present and action_past are only applicable for BatchAction and not Link Action. It is not needed here.","commit_id":"39bea6b8c9e2044f4040d5bd39def02c9a0a920e"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"d0c42d877d95fb3b16454da559bc48288b639043","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    policy_rules \u003d ((\"compute\", \"compute_extension:services\"),)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    @staticmethod"},{"line_number":66,"context_line":"    def action_present(count):"},{"line_number":67,"context_line":"        return ungettext_lazy("},{"line_number":68,"context_line":"            u\"Disable Service\","},{"line_number":69,"context_line":"            u\"Disable Services\","}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_5e76aad9","line":66,"in_reply_to":"5a890539_65476a1e","updated":"2014-11-20 00:44:43.000000000","message":"Done","commit_id":"39bea6b8c9e2044f4040d5bd39def02c9a0a920e"}]}
