)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"e4ed040fdfffc50a922af958139ece2995200341","unresolved":false,"context_lines":[{"line_number":15,"context_line":"For example if the logged-in admin leaves an unattended computer,"},{"line_number":16,"context_line":"someone can change the password of the logged in user successfully."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Also, fix unused keystone test case."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Co-Authored-By: Steve Martinelli \u003cstevemar@ca.ibm.com\u003e"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3a961159_581f405b","line":18,"updated":"2014-12-11 13:01:37.000000000","message":"where is the unused keystone test case ,fix the commit msg.","commit_id":"098537d4064334bce554e9bd7d871459d8b7856f"}],"doc/source/topics/settings.rst":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"4e823998971e2308ebf3a5664d2b4f7e2b720aae","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":"Default: ``True``"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"This setting will display an \u0027Admin Password\u0027 field on the Edit User form to "},{"line_number":343,"context_line":"verify that it is indeed the admin logged in who wants to change the password."},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"``IMAGES_LIST_FILTER_TENANTS``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_a9b7cd38","line":342,"updated":"2014-11-25 08:09:53.000000000","message":"trailing space","commit_id":"54238f5b1c0beafba37556442d03fbccd0ad1164"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"40e624e94bcdd2754809d1a478f36c8bfb4574c4","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":"Default: ``True``"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"This setting will display an \u0027Admin Password\u0027 field on the Edit User form to "},{"line_number":343,"context_line":"verify that it is indeed the admin logged in who wants to change the password."},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"``IMAGES_LIST_FILTER_TENANTS``"}],"source_content_type":"text/x-rst","patch_set":2,"id":"5a890539_51519960","line":342,"in_reply_to":"5a890539_a9b7cd38","updated":"2014-11-25 19:14:52.000000000","message":"Done","commit_id":"54238f5b1c0beafba37556442d03fbccd0ad1164"}],"openstack_dashboard/api/keystone.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"4e823998971e2308ebf3a5664d2b4f7e2b720aae","unresolved":false,"context_lines":[{"line_number":389,"context_line":"            data.pop(\u0027password\u0027)"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"        enforce_admin_password \u003d getattr(settings, \u0027ENFORCE_PASSWORD_CHECK\u0027,"},{"line_number":392,"context_line":"                                         False)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        if enforce_admin_password:"},{"line_number":395,"context_line":"            admin_password \u003d data.pop(\u0027admin_password\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_c9989977","line":392,"updated":"2014-11-25 08:09:53.000000000","message":"seems you should only do this when data[\u0027password\u0027] is not empty.","commit_id":"54238f5b1c0beafba37556442d03fbccd0ad1164"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"40e624e94bcdd2754809d1a478f36c8bfb4574c4","unresolved":false,"context_lines":[{"line_number":389,"context_line":"            data.pop(\u0027password\u0027)"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"        enforce_admin_password \u003d getattr(settings, \u0027ENFORCE_PASSWORD_CHECK\u0027,"},{"line_number":392,"context_line":"                                         False)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        if enforce_admin_password:"},{"line_number":395,"context_line":"            admin_password \u003d data.pop(\u0027admin_password\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_914781a2","line":392,"in_reply_to":"5a890539_c9989977","updated":"2014-11-25 19:14:52.000000000","message":"Done","commit_id":"54238f5b1c0beafba37556442d03fbccd0ad1164"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9b1a48e90af86cac8e5cf1246755a5df05a2212a","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        if password:"},{"line_number":360,"context_line":"            enforce_admin_password \u003d getattr(settings,"},{"line_number":361,"context_line":"                                             \u0027ENFORCE_PASSWORD_CHECK\u0027, False)"},{"line_number":362,"context_line":"            if enforce_admin_password:"},{"line_number":363,"context_line":"                admin_password \u003d data.pop(\u0027admin_password\u0027)"},{"line_number":364,"context_line":"                try:"},{"line_number":365,"context_line":"                    # attempt to create new client instance with admin password"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_a2798894","line":362,"updated":"2014-11-25 20:57:18.000000000","message":"how about:\n\n  if getattr(settings, \u0027ENFORCE_PASSWORD_CHECK\u0027, False)","commit_id":"256cc18a73eda8177807a543cf676f8eedb5fffc"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9b1a48e90af86cac8e5cf1246755a5df05a2212a","unresolved":false,"context_lines":[{"line_number":365,"context_line":"                    # attempt to create new client instance with admin password"},{"line_number":366,"context_line":"                    # if successful, admin password is correct"},{"line_number":367,"context_line":"                    from keystoneclient.v2_0 import client"},{"line_number":368,"context_line":"                    client.Client(username\u003drequest.user.username,"},{"line_number":369,"context_line":"                                  password\u003dadmin_password,"},{"line_number":370,"context_line":"                                  tenant_name\u003drequest.user.tenant_name,"},{"line_number":371,"context_line":"                                  auth_url\u003dgetattr(settings,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_4232a4f2","line":368,"updated":"2014-11-25 20:57:18.000000000","message":"i think you can just use keystone_client_v2.Client here and remove the line above, fixing a pep8 issue too.","commit_id":"256cc18a73eda8177807a543cf676f8eedb5fffc"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"1f0b2a42c1ae2d2fc59c4bba3f35746afb6047a2","unresolved":false,"context_lines":[{"line_number":365,"context_line":"                    # attempt to create new client instance with admin password"},{"line_number":366,"context_line":"                    # if successful, admin password is correct"},{"line_number":367,"context_line":"                    from keystoneclient.v2_0 import client"},{"line_number":368,"context_line":"                    client.Client(username\u003drequest.user.username,"},{"line_number":369,"context_line":"                                  password\u003dadmin_password,"},{"line_number":370,"context_line":"                                  tenant_name\u003drequest.user.tenant_name,"},{"line_number":371,"context_line":"                                  auth_url\u003dgetattr(settings,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_7bc106e3","line":368,"in_reply_to":"5a890539_4232a4f2","updated":"2014-11-26 04:17:11.000000000","message":"agree with steve +1","commit_id":"256cc18a73eda8177807a543cf676f8eedb5fffc"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9b1a48e90af86cac8e5cf1246755a5df05a2212a","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                                  tenant_name\u003drequest.user.tenant_name,"},{"line_number":371,"context_line":"                                  auth_url\u003dgetattr(settings,"},{"line_number":372,"context_line":"                                                   \u0027OPENSTACK_KEYSTONE_URL\u0027))"},{"line_number":373,"context_line":"                except Exception:"},{"line_number":374,"context_line":"                    error \u003d exceptions.handle(request, ignore\u003dTrue)"},{"line_number":375,"context_line":"            try:"},{"line_number":376,"context_line":"                user_update_password(request, user, password)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_c26cd4d2","line":373,"updated":"2014-11-25 20:57:18.000000000","message":"A note about why we are catching a generic Exception here would be good.","commit_id":"256cc18a73eda8177807a543cf676f8eedb5fffc"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9b1a48e90af86cac8e5cf1246755a5df05a2212a","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        if password:"},{"line_number":395,"context_line":"            enforce_admin_password \u003d getattr(settings,"},{"line_number":396,"context_line":"                                             \u0027ENFORCE_PASSWORD_CHECK\u0027, False)"},{"line_number":397,"context_line":"            if enforce_admin_password:"},{"line_number":398,"context_line":"                admin_password \u003d data.pop(\u0027admin_password\u0027)"},{"line_number":399,"context_line":"                try:"},{"line_number":400,"context_line":"                    from keystoneclient.v3 import client"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_02433c42","line":397,"updated":"2014-11-25 20:57:18.000000000","message":"how about just:\n\n  if getattr(settings, \u0027ENFORCE_PASSWORD_CHECK\u0027, False)","commit_id":"256cc18a73eda8177807a543cf676f8eedb5fffc"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9b1a48e90af86cac8e5cf1246755a5df05a2212a","unresolved":false,"context_lines":[{"line_number":398,"context_line":"                admin_password \u003d data.pop(\u0027admin_password\u0027)"},{"line_number":399,"context_line":"                try:"},{"line_number":400,"context_line":"                    from keystoneclient.v3 import client"},{"line_number":401,"context_line":"                    client.Client("},{"line_number":402,"context_line":"                        username\u003drequest.user.username,"},{"line_number":403,"context_line":"                        password\u003dadmin_password,"},{"line_number":404,"context_line":"                        project_id\u003drequest.user.project_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_824f2c6a","line":401,"updated":"2014-11-25 20:57:18.000000000","message":"I think you can use keystone_client_v3.Client here and remove the line above, fixing a pep8 issue too.","commit_id":"256cc18a73eda8177807a543cf676f8eedb5fffc"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9b1a48e90af86cac8e5cf1246755a5df05a2212a","unresolved":false,"context_lines":[{"line_number":401,"context_line":"                    client.Client("},{"line_number":402,"context_line":"                        username\u003drequest.user.username,"},{"line_number":403,"context_line":"                        password\u003dadmin_password,"},{"line_number":404,"context_line":"                        project_id\u003drequest.user.project_id,"},{"line_number":405,"context_line":"                        auth_url\u003dgetattr(settings, \u0027OPENSTACK_KEYSTONE_URL\u0027))"},{"line_number":406,"context_line":"                except Exception:"},{"line_number":407,"context_line":"                    error \u003d exceptions.handle(request, ignore\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_4260e4ce","line":404,"updated":"2014-11-25 20:57:18.000000000","message":"are you missing arguments here?\n\nlike user_domain_id /name and domain_id / name ? refer to PS2","commit_id":"256cc18a73eda8177807a543cf676f8eedb5fffc"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1bb85ee8e78ed9e60293505d60d145618d646b6e","unresolved":false,"context_lines":[{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    # v3 API is so much simpler..."},{"line_number":374,"context_line":"    else:"},{"line_number":375,"context_line":"        if not data[\u0027password\u0027]:"},{"line_number":376,"context_line":"            data.pop(\u0027password\u0027)"},{"line_number":377,"context_line":"        try:"},{"line_number":378,"context_line":"            user \u003d manager.update(user, **data)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_5b2a6530","side":"PARENT","line":375,"updated":"2014-11-27 02:21:45.000000000","message":"are there any negative consequences to not performing this check any longer?","commit_id":"ec012c694391bdb77d9fac03fe3a12f70f2123cd"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"44705d749c9ce743a1329650fb131023f5a4f3f7","unresolved":false,"context_lines":[{"line_number":363,"context_line":"                    keystone_client_v2.Client("},{"line_number":364,"context_line":"                        username\u003drequest.user.username,"},{"line_number":365,"context_line":"                        password\u003dadmin_password,"},{"line_number":366,"context_line":"                        tenant_name\u003drequest.user.tenant_name,"},{"line_number":367,"context_line":"                        auth_url\u003dgetattr(settings, \u0027OPENSTACK_KEYSTONE_URL\u0027))"},{"line_number":368,"context_line":"                except Exception:"},{"line_number":369,"context_line":"                    # attempt to create new client instance with admin"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_c8696a8d","line":366,"updated":"2014-12-03 23:17:55.000000000","message":"we don\u0027t really need to get a project scoped token here, the tenant_name can be removed from the argument","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"ed7545214e491103ef8f07d9c42cf85f0e761e77","unresolved":false,"context_lines":[{"line_number":363,"context_line":"                    keystone_client_v2.Client("},{"line_number":364,"context_line":"                        username\u003drequest.user.username,"},{"line_number":365,"context_line":"                        password\u003dadmin_password,"},{"line_number":366,"context_line":"                        tenant_name\u003drequest.user.tenant_name,"},{"line_number":367,"context_line":"                        auth_url\u003dgetattr(settings, \u0027OPENSTACK_KEYSTONE_URL\u0027))"},{"line_number":368,"context_line":"                except Exception:"},{"line_number":369,"context_line":"                    # attempt to create new client instance with admin"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_4c14a443","line":366,"in_reply_to":"5a890539_c8696a8d","updated":"2014-12-04 03:59:54.000000000","message":"Done","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"44705d749c9ce743a1329650fb131023f5a4f3f7","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                        username\u003drequest.user.username,"},{"line_number":365,"context_line":"                        password\u003dadmin_password,"},{"line_number":366,"context_line":"                        tenant_name\u003drequest.user.tenant_name,"},{"line_number":367,"context_line":"                        auth_url\u003dgetattr(settings, \u0027OPENSTACK_KEYSTONE_URL\u0027))"},{"line_number":368,"context_line":"                except Exception:"},{"line_number":369,"context_line":"                    # attempt to create new client instance with admin"},{"line_number":370,"context_line":"                    # password failed."}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_28302e55","line":367,"updated":"2014-12-03 23:17:55.000000000","message":"getattr(settings, \u0027OPENSTACK_KEYSTONE_URL\u0027)) \u003c\u003d this will not work if there are multi KS endpoint setup.  Use the _get_endpoint_url() to get the identity endpoint instead.\n\n\nYou also need to pass the cacert and insecure argument too, See line 168","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"ed7545214e491103ef8f07d9c42cf85f0e761e77","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                        username\u003drequest.user.username,"},{"line_number":365,"context_line":"                        password\u003dadmin_password,"},{"line_number":366,"context_line":"                        tenant_name\u003drequest.user.tenant_name,"},{"line_number":367,"context_line":"                        auth_url\u003dgetattr(settings, \u0027OPENSTACK_KEYSTONE_URL\u0027))"},{"line_number":368,"context_line":"                except Exception:"},{"line_number":369,"context_line":"                    # attempt to create new client instance with admin"},{"line_number":370,"context_line":"                    # password failed."}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_8c1a0c6d","line":367,"in_reply_to":"5a890539_28302e55","updated":"2014-12-04 03:59:54.000000000","message":"Done","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"44705d749c9ce743a1329650fb131023f5a4f3f7","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                except Exception:"},{"line_number":369,"context_line":"                    # attempt to create new client instance with admin"},{"line_number":370,"context_line":"                    # password failed."},{"line_number":371,"context_line":"                    error \u003d exceptions.handle(request, ignore\u003dTrue)"},{"line_number":372,"context_line":"            try:"},{"line_number":373,"context_line":"                user_update_password(request, user, password)"},{"line_number":374,"context_line":"                if user.id \u003d\u003d request.user.id:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_28f3ce73","line":371,"updated":"2014-12-03 23:17:55.000000000","message":"Should just raise an error here, otherwise the user record will still be updated","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"ed7545214e491103ef8f07d9c42cf85f0e761e77","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                except Exception:"},{"line_number":369,"context_line":"                    # attempt to create new client instance with admin"},{"line_number":370,"context_line":"                    # password failed."},{"line_number":371,"context_line":"                    error \u003d exceptions.handle(request, ignore\u003dTrue)"},{"line_number":372,"context_line":"            try:"},{"line_number":373,"context_line":"                user_update_password(request, user, password)"},{"line_number":374,"context_line":"                if user.id \u003d\u003d request.user.id:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_cc27b4b4","line":371,"in_reply_to":"5a890539_28f3ce73","updated":"2014-12-04 03:59:54.000000000","message":"Done","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"44705d749c9ce743a1329650fb131023f5a4f3f7","unresolved":false,"context_lines":[{"line_number":395,"context_line":"                        username\u003drequest.user.username,"},{"line_number":396,"context_line":"                        password\u003dadmin_password,"},{"line_number":397,"context_line":"                        domain_id\u003drequest.user.domain_id,"},{"line_number":398,"context_line":"                        domain_name\u003drequest.user.domain_name,"},{"line_number":399,"context_line":"                        project_id\u003drequest.user.project_id,"},{"line_number":400,"context_line":"                        project_name\u003drequest.user.project_name,"},{"line_number":401,"context_line":"                        user_domain_id\u003drequest.user.user_domain_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_68b5d6eb","line":398,"updated":"2014-12-03 23:17:55.000000000","message":"these two arguments are for domain scoped token, it is unnecessary.","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"ed7545214e491103ef8f07d9c42cf85f0e761e77","unresolved":false,"context_lines":[{"line_number":395,"context_line":"                        username\u003drequest.user.username,"},{"line_number":396,"context_line":"                        password\u003dadmin_password,"},{"line_number":397,"context_line":"                        domain_id\u003drequest.user.domain_id,"},{"line_number":398,"context_line":"                        domain_name\u003drequest.user.domain_name,"},{"line_number":399,"context_line":"                        project_id\u003drequest.user.project_id,"},{"line_number":400,"context_line":"                        project_name\u003drequest.user.project_name,"},{"line_number":401,"context_line":"                        user_domain_id\u003drequest.user.user_domain_id,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_ec2ab07c","line":398,"in_reply_to":"5a890539_68b5d6eb","updated":"2014-12-04 03:59:54.000000000","message":"Done","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"44705d749c9ce743a1329650fb131023f5a4f3f7","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                        domain_id\u003drequest.user.domain_id,"},{"line_number":398,"context_line":"                        domain_name\u003drequest.user.domain_name,"},{"line_number":399,"context_line":"                        project_id\u003drequest.user.project_id,"},{"line_number":400,"context_line":"                        project_name\u003drequest.user.project_name,"},{"line_number":401,"context_line":"                        user_domain_id\u003drequest.user.user_domain_id,"},{"line_number":402,"context_line":"                        user_domain_name\u003drequest.user.user_domain_name,"},{"line_number":403,"context_line":"                        auth_url\u003dgetattr(settings, \u0027OPENSTACK_KEYSTONE_URL\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_08b8d2c6","line":400,"updated":"2014-12-03 23:17:55.000000000","message":"same comment, don\u0027t need a project scoped token. don\u0027t need the two arguments","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"ed7545214e491103ef8f07d9c42cf85f0e761e77","unresolved":false,"context_lines":[{"line_number":397,"context_line":"                        domain_id\u003drequest.user.domain_id,"},{"line_number":398,"context_line":"                        domain_name\u003drequest.user.domain_name,"},{"line_number":399,"context_line":"                        project_id\u003drequest.user.project_id,"},{"line_number":400,"context_line":"                        project_name\u003drequest.user.project_name,"},{"line_number":401,"context_line":"                        user_domain_id\u003drequest.user.user_domain_id,"},{"line_number":402,"context_line":"                        user_domain_name\u003drequest.user.user_domain_name,"},{"line_number":403,"context_line":"                        auth_url\u003dgetattr(settings, \u0027OPENSTACK_KEYSTONE_URL\u0027))"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_2c21189e","line":400,"in_reply_to":"5a890539_08b8d2c6","updated":"2014-12-04 03:59:54.000000000","message":"Done","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"44705d749c9ce743a1329650fb131023f5a4f3f7","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                        project_id\u003drequest.user.project_id,"},{"line_number":400,"context_line":"                        project_name\u003drequest.user.project_name,"},{"line_number":401,"context_line":"                        user_domain_id\u003drequest.user.user_domain_id,"},{"line_number":402,"context_line":"                        user_domain_name\u003drequest.user.user_domain_name,"},{"line_number":403,"context_line":"                        auth_url\u003dgetattr(settings, \u0027OPENSTACK_KEYSTONE_URL\u0027))"},{"line_number":404,"context_line":"                except Exception:"},{"line_number":405,"context_line":"                    error \u003d exceptions.handle(request, ignore\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_28090e95","line":402,"updated":"2014-12-03 23:17:55.000000000","message":"we only need either the user_domain_id or user_domain_name","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"ed7545214e491103ef8f07d9c42cf85f0e761e77","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                        project_id\u003drequest.user.project_id,"},{"line_number":400,"context_line":"                        project_name\u003drequest.user.project_name,"},{"line_number":401,"context_line":"                        user_domain_id\u003drequest.user.user_domain_id,"},{"line_number":402,"context_line":"                        user_domain_name\u003drequest.user.user_domain_name,"},{"line_number":403,"context_line":"                        auth_url\u003dgetattr(settings, \u0027OPENSTACK_KEYSTONE_URL\u0027))"},{"line_number":404,"context_line":"                except Exception:"},{"line_number":405,"context_line":"                    error \u003d exceptions.handle(request, ignore\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_4c3bc4d0","line":402,"in_reply_to":"5a890539_28090e95","updated":"2014-12-04 03:59:54.000000000","message":"Done","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"44705d749c9ce743a1329650fb131023f5a4f3f7","unresolved":false,"context_lines":[{"line_number":400,"context_line":"                        project_name\u003drequest.user.project_name,"},{"line_number":401,"context_line":"                        user_domain_id\u003drequest.user.user_domain_id,"},{"line_number":402,"context_line":"                        user_domain_name\u003drequest.user.user_domain_name,"},{"line_number":403,"context_line":"                        auth_url\u003dgetattr(settings, \u0027OPENSTACK_KEYSTONE_URL\u0027))"},{"line_number":404,"context_line":"                except Exception:"},{"line_number":405,"context_line":"                    error \u003d exceptions.handle(request, ignore\u003dTrue)"},{"line_number":406,"context_line":"            if error is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_6836b652","line":403,"updated":"2014-12-03 23:17:55.000000000","message":"getattr(settings, \u0027OPENSTACK_KEYSTONE_URL\u0027)) \u003c\u003d this will not work if there are multi KS endpoint setup.  Use the _get_endpoint_url() to get the identity endpoint instead.\n\n\nYou also need to pass the cacert and insecure argument too, See line 168","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"ed7545214e491103ef8f07d9c42cf85f0e761e77","unresolved":false,"context_lines":[{"line_number":400,"context_line":"                        project_name\u003drequest.user.project_name,"},{"line_number":401,"context_line":"                        user_domain_id\u003drequest.user.user_domain_id,"},{"line_number":402,"context_line":"                        user_domain_name\u003drequest.user.user_domain_name,"},{"line_number":403,"context_line":"                        auth_url\u003dgetattr(settings, \u0027OPENSTACK_KEYSTONE_URL\u0027))"},{"line_number":404,"context_line":"                except Exception:"},{"line_number":405,"context_line":"                    error \u003d exceptions.handle(request, ignore\u003dTrue)"},{"line_number":406,"context_line":"            if error is not None:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_6c36c0e8","line":403,"in_reply_to":"5a890539_6836b652","updated":"2014-12-04 03:59:54.000000000","message":"Done","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"44705d749c9ce743a1329650fb131023f5a4f3f7","unresolved":false,"context_lines":[{"line_number":402,"context_line":"                        user_domain_name\u003drequest.user.user_domain_name,"},{"line_number":403,"context_line":"                        auth_url\u003dgetattr(settings, \u0027OPENSTACK_KEYSTONE_URL\u0027))"},{"line_number":404,"context_line":"                except Exception:"},{"line_number":405,"context_line":"                    error \u003d exceptions.handle(request, ignore\u003dTrue)"},{"line_number":406,"context_line":"            if error is not None:"},{"line_number":407,"context_line":"                raise error"},{"line_number":408,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_48e65ab1","line":405,"updated":"2014-12-03 23:17:55.000000000","message":"Should just raise an error here, otherwise the user record will still be updated","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"ed7545214e491103ef8f07d9c42cf85f0e761e77","unresolved":false,"context_lines":[{"line_number":402,"context_line":"                        user_domain_name\u003drequest.user.user_domain_name,"},{"line_number":403,"context_line":"                        auth_url\u003dgetattr(settings, \u0027OPENSTACK_KEYSTONE_URL\u0027))"},{"line_number":404,"context_line":"                except Exception:"},{"line_number":405,"context_line":"                    error \u003d exceptions.handle(request, ignore\u003dTrue)"},{"line_number":406,"context_line":"            if error is not None:"},{"line_number":407,"context_line":"                raise error"},{"line_number":408,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_ac2c2894","line":405,"in_reply_to":"5a890539_48e65ab1","updated":"2014-12-04 03:59:54.000000000","message":"Done","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"01fefbadd6ed3f9295296c1935fe441ea7aa2ac7","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            if getattr(settings, \u0027ENFORCE_PASSWORD_CHECK\u0027, False):"},{"line_number":361,"context_line":"                admin_password \u003d data.pop(\u0027admin_password\u0027)"},{"line_number":362,"context_line":"                try:"},{"line_number":363,"context_line":"                    endpoint \u003d _get_endpoint_url(request, \u0027adminURL\u0027)"},{"line_number":364,"context_line":"                    insecure \u003d getattr(settings, \u0027OPENSTACK_SSL_NO_VERIFY\u0027,"},{"line_number":365,"context_line":"                                       False)"},{"line_number":366,"context_line":"                    cacert \u003d getattr(settings, \u0027OPENSTACK_SSL_CACERT\u0027, None)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_8c74ccfe","line":363,"updated":"2014-12-04 04:36:43.000000000","message":"nit: might as well default to internalURL too","commit_id":"a36ba158320ab4be055a84a1d006e0a5a7a99442"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"52667822ee25f92a8ede23cd72bd2cb25506fcef","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            if getattr(settings, \u0027ENFORCE_PASSWORD_CHECK\u0027, False):"},{"line_number":361,"context_line":"                admin_password \u003d data.pop(\u0027admin_password\u0027)"},{"line_number":362,"context_line":"                try:"},{"line_number":363,"context_line":"                    endpoint \u003d _get_endpoint_url(request, \u0027adminURL\u0027)"},{"line_number":364,"context_line":"                    insecure \u003d getattr(settings, \u0027OPENSTACK_SSL_NO_VERIFY\u0027,"},{"line_number":365,"context_line":"                                       False)"},{"line_number":366,"context_line":"                    cacert \u003d getattr(settings, \u0027OPENSTACK_SSL_CACERT\u0027, None)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_7be57da2","line":363,"in_reply_to":"5a890539_8c74ccfe","updated":"2014-12-04 19:53:43.000000000","message":"Done","commit_id":"a36ba158320ab4be055a84a1d006e0a5a7a99442"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"168ea3a8f5e1b2fbfb715751d5396a3db8e43a81","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                except Exception:"},{"line_number":374,"context_line":"                    # attempt to create new client instance with admin"},{"line_number":375,"context_line":"                    # password failed."},{"line_number":376,"context_line":"                    error \u003d exceptions.handle(request, ignore\u003dTrue)"},{"line_number":377,"context_line":"                    raise error"},{"line_number":378,"context_line":"            try:"},{"line_number":379,"context_line":"                user_update_password(request, user, password)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_8c73ec4c","line":376,"updated":"2014-12-04 04:17:45.000000000","message":"nit: you could just put this onto one line","commit_id":"a36ba158320ab4be055a84a1d006e0a5a7a99442"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"52667822ee25f92a8ede23cd72bd2cb25506fcef","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                except Exception:"},{"line_number":374,"context_line":"                    # attempt to create new client instance with admin"},{"line_number":375,"context_line":"                    # password failed."},{"line_number":376,"context_line":"                    error \u003d exceptions.handle(request, ignore\u003dTrue)"},{"line_number":377,"context_line":"                    raise error"},{"line_number":378,"context_line":"            try:"},{"line_number":379,"context_line":"                user_update_password(request, user, password)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_bb02853b","line":376,"in_reply_to":"5a890539_8c73ec4c","updated":"2014-12-04 19:53:43.000000000","message":"Done","commit_id":"a36ba158320ab4be055a84a1d006e0a5a7a99442"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"01fefbadd6ed3f9295296c1935fe441ea7aa2ac7","unresolved":false,"context_lines":[{"line_number":405,"context_line":"                        username\u003drequest.user.username,"},{"line_number":406,"context_line":"                        password\u003dadmin_password,"},{"line_number":407,"context_line":"                        user_domain_id\u003drequest.user.user_domain_id,"},{"line_number":408,"context_line":"                        auth_url\u003dendpoint)"},{"line_number":409,"context_line":"                except Exception:"},{"line_number":410,"context_line":"                    error \u003d exceptions.handle(request, ignore\u003dTrue)"},{"line_number":411,"context_line":"                    raise error"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_ec64704a","line":408,"updated":"2014-12-04 04:36:43.000000000","message":"insecure and cacert are not passed to the client","commit_id":"a36ba158320ab4be055a84a1d006e0a5a7a99442"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"52667822ee25f92a8ede23cd72bd2cb25506fcef","unresolved":false,"context_lines":[{"line_number":405,"context_line":"                        username\u003drequest.user.username,"},{"line_number":406,"context_line":"                        password\u003dadmin_password,"},{"line_number":407,"context_line":"                        user_domain_id\u003drequest.user.user_domain_id,"},{"line_number":408,"context_line":"                        auth_url\u003dendpoint)"},{"line_number":409,"context_line":"                except Exception:"},{"line_number":410,"context_line":"                    error \u003d exceptions.handle(request, ignore\u003dTrue)"},{"line_number":411,"context_line":"                    raise error"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_fbf88d4b","line":408,"in_reply_to":"5a890539_ec64704a","updated":"2014-12-04 19:53:43.000000000","message":"Done","commit_id":"a36ba158320ab4be055a84a1d006e0a5a7a99442"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"01fefbadd6ed3f9295296c1935fe441ea7aa2ac7","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                        auth_url\u003dendpoint)"},{"line_number":409,"context_line":"                except Exception:"},{"line_number":410,"context_line":"                    error \u003d exceptions.handle(request, ignore\u003dTrue)"},{"line_number":411,"context_line":"                    raise error"},{"line_number":412,"context_line":"        try:"},{"line_number":413,"context_line":"            user \u003d manager.update(user, **data)"},{"line_number":414,"context_line":"        except keystone_exceptions.Conflict:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_0c58dc88","line":411,"updated":"2014-12-04 04:36:43.000000000","message":"same nit as Steve mentioned above","commit_id":"a36ba158320ab4be055a84a1d006e0a5a7a99442"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"52667822ee25f92a8ede23cd72bd2cb25506fcef","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                        auth_url\u003dendpoint)"},{"line_number":409,"context_line":"                except Exception:"},{"line_number":410,"context_line":"                    error \u003d exceptions.handle(request, ignore\u003dTrue)"},{"line_number":411,"context_line":"                    raise error"},{"line_number":412,"context_line":"        try:"},{"line_number":413,"context_line":"            user \u003d manager.update(user, **data)"},{"line_number":414,"context_line":"        except keystone_exceptions.Conflict:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_1bf47953","line":411,"in_reply_to":"5a890539_0c58dc88","updated":"2014-12-04 19:53:43.000000000","message":"Done","commit_id":"a36ba158320ab4be055a84a1d006e0a5a7a99442"},{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"9a35ae52932dc333b43b9318d78976a5e56d8045","unresolved":false,"context_lines":[{"line_number":355,"context_line":"                             % data.get(\u0027name\u0027, None))"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        # If present, update password"},{"line_number":358,"context_line":"        # FIXME(gabriel): password change should be its own form + view"},{"line_number":359,"context_line":"        if password:"},{"line_number":360,"context_line":"            if getattr(settings, \u0027ENFORCE_PASSWORD_CHECK\u0027, False):"},{"line_number":361,"context_line":"                admin_password \u003d data.pop(\u0027admin_password\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_8a9aaa12","line":358,"updated":"2014-12-08 15:40:31.000000000","message":"We might consider fixing what is suggested here - to make a standalone form+view for changing user login+password, which will then require admin password.","commit_id":"098537d4064334bce554e9bd7d871459d8b7856f"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b8cc2ff15256aac292aa5e1af99cb39568508810","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            data.pop(\u0027password\u0027)"},{"line_number":394,"context_line":"        # password exists"},{"line_number":395,"context_line":"        else:"},{"line_number":396,"context_line":"            if getattr(settings, \u0027ENFORCE_PASSWORD_CHECK\u0027, False):"},{"line_number":397,"context_line":"                admin_password \u003d data.pop(\u0027admin_password\u0027)"},{"line_number":398,"context_line":"                try:"},{"line_number":399,"context_line":"                    endpoint \u003d _get_endpoint_url(request, \u0027internalURL\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_aef058fe","line":396,"updated":"2014-12-05 18:35:59.000000000","message":"This and the above chunks are almost the same except name of the module. Two code fragments could be abstracted to one function with `client_cls` argument.","commit_id":"098537d4064334bce554e9bd7d871459d8b7856f"},{"author":{"_account_id":14064,"name":"Kahou Lei","email":"kahou82@gmail.com","username":"kahou82"},"change_message_id":"297b23dd8b185c95df539d3905ff9ab5b762a9c5","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        )"},{"line_number":407,"context_line":"        return True"},{"line_number":408,"context_line":"    except Exception:"},{"line_number":409,"context_line":"        return False"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"def user_update_own_password(request, origpassword, password):"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba7be1f8_c91331ff","line":409,"updated":"2015-03-03 22:31:53.000000000","message":"Do you want to log the exception?","commit_id":"9bd2142a4c110359976c681b252e1996c51d1030"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"5955ce1f720db3984ee21547df7f8b570ecd9931","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        )"},{"line_number":407,"context_line":"        return True"},{"line_number":408,"context_line":"    except Exception:"},{"line_number":409,"context_line":"        return False"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":""},{"line_number":412,"context_line":"def user_update_own_password(request, origpassword, password):"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a80dd14_a905bdc3","line":409,"in_reply_to":"ba7be1f8_c91331ff","updated":"2015-03-04 19:42:05.000000000","message":"Done","commit_id":"9bd2142a4c110359976c681b252e1996c51d1030"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"342d0f53735c308b2cb75ffa087264d73014aca5","unresolved":false,"context_lines":[{"line_number":390,"context_line":""},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"def user_verify_admin_password(request, admin_password):"},{"line_number":393,"context_line":"    # attempt to create a new client instance with admin password to"},{"line_number":394,"context_line":"    # verify if it\u0027s correct."},{"line_number":395,"context_line":"    client \u003d keystone_client_v2 if VERSIONS.active \u003c 3 else keystone_client_v3"},{"line_number":396,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a80dd14_1c068086","line":393,"updated":"2015-03-07 03:33:00.000000000","message":"Very cool way to do this verification!","commit_id":"2946006929ba6d685455da43de727bbff09e316d"},{"author":{"_account_id":14064,"name":"Kahou Lei","email":"kahou82@gmail.com","username":"kahou82"},"change_message_id":"061b29956d98b872225736f784d3763d5b105a82","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            \"domain\": domain,"},{"line_number":275,"context_line":"            \"user\": user"},{"line_number":276,"context_line":"        }"},{"line_number":277,"context_line":"        if filters is not None:"},{"line_number":278,"context_line":"            kwargs.update(filters)"},{"line_number":279,"context_line":"        tenants \u003d manager.list(**kwargs)"},{"line_number":280,"context_line":"    return (tenants, has_more_data)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_af0b3dd4","line":277,"updated":"2015-03-10 01:19:55.000000000","message":"I am somewhere in Horizon is using this:\n\nif not filters:\n\nJust curious which one is the convention? (if not filters vs if filters is not None)","commit_id":"4198cbf87d364227f6f033ef7105dc0302951be1"},{"author":{"_account_id":14064,"name":"Kahou Lei","email":"kahou82@gmail.com","username":"kahou82"},"change_message_id":"0543b183d6fe66488d31b6f9d6410f20c91a9a87","unresolved":false,"context_lines":[{"line_number":274,"context_line":"            \"domain\": domain,"},{"line_number":275,"context_line":"            \"user\": user"},{"line_number":276,"context_line":"        }"},{"line_number":277,"context_line":"        if filters is not None:"},{"line_number":278,"context_line":"            kwargs.update(filters)"},{"line_number":279,"context_line":"        tenants \u003d manager.list(**kwargs)"},{"line_number":280,"context_line":"    return (tenants, has_more_data)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_1ac3a038","line":277,"in_reply_to":"9a80dd14_af0b3dd4","updated":"2015-03-10 05:33:40.000000000","message":"Nvm, I misread as \"if filters is None\". Sorry about that.","commit_id":"4198cbf87d364227f6f033ef7105dc0302951be1"},{"author":{"_account_id":14064,"name":"Kahou Lei","email":"kahou82@gmail.com","username":"kahou82"},"change_message_id":"061b29956d98b872225736f784d3763d5b105a82","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            \"domain\": domain,"},{"line_number":300,"context_line":"            \"group\": group"},{"line_number":301,"context_line":"        }"},{"line_number":302,"context_line":"        if filters is not None:"},{"line_number":303,"context_line":"            kwargs.update(filters)"},{"line_number":304,"context_line":"    users \u003d keystoneclient(request, admin\u003dTrue).users.list(**kwargs)"},{"line_number":305,"context_line":"    return [VERSIONS.upgrade_v2_user(user) for user in users]"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_cf0eb1e4","line":302,"updated":"2015-03-10 01:19:55.000000000","message":"Same as above","commit_id":"4198cbf87d364227f6f033ef7105dc0302951be1"},{"author":{"_account_id":14064,"name":"Kahou Lei","email":"kahou82@gmail.com","username":"kahou82"},"change_message_id":"0543b183d6fe66488d31b6f9d6410f20c91a9a87","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            \"domain\": domain,"},{"line_number":300,"context_line":"            \"group\": group"},{"line_number":301,"context_line":"        }"},{"line_number":302,"context_line":"        if filters is not None:"},{"line_number":303,"context_line":"            kwargs.update(filters)"},{"line_number":304,"context_line":"    users \u003d keystoneclient(request, admin\u003dTrue).users.list(**kwargs)"},{"line_number":305,"context_line":"    return [VERSIONS.upgrade_v2_user(user) for user in users]"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a80dd14_3abea4ae","line":302,"in_reply_to":"9a80dd14_cf0eb1e4","updated":"2015-03-10 05:33:40.000000000","message":"Nvm, I misread as \"if filters is None\". Sorry about that.","commit_id":"4198cbf87d364227f6f033ef7105dc0302951be1"}],"openstack_dashboard/dashboards/identity/users/forms.py":[{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"b948c17dba3b88a2423384424e2356d570547df0","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    admin_password \u003d forms.RegexField("},{"line_number":167,"context_line":"        label\u003d_(\"Admin Password\"),"},{"line_number":168,"context_line":"        widget\u003dforms.HiddenInput(),"},{"line_number":169,"context_line":"        regex\u003dvalidators.password_validator(),"},{"line_number":170,"context_line":"        required\u003dFalse,"},{"line_number":171,"context_line":"        error_messages\u003d{\u0027invalid\u0027: validators.password_validator_msg()})"},{"line_number":172,"context_line":"    password \u003d forms.RegexField("}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_198657b9","line":169,"updated":"2014-11-25 19:51:25.000000000","message":"does a regex validator make sense when we are asking for an existing password?","commit_id":"b2c5d6a46eb09e788010ab2931b6fe9cb8a7f063"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"c721d05e5f29e8e22e5443eadb309e208de17894","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    admin_password \u003d forms.RegexField("},{"line_number":167,"context_line":"        label\u003d_(\"Admin Password\"),"},{"line_number":168,"context_line":"        widget\u003dforms.HiddenInput(),"},{"line_number":169,"context_line":"        regex\u003dvalidators.password_validator(),"},{"line_number":170,"context_line":"        required\u003dFalse,"},{"line_number":171,"context_line":"        error_messages\u003d{\u0027invalid\u0027: validators.password_validator_msg()})"},{"line_number":172,"context_line":"    password \u003d forms.RegexField("}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_3f7f73ac","line":169,"in_reply_to":"5a890539_198657b9","updated":"2014-11-25 20:46:46.000000000","message":"Done. Thanks Doug!","commit_id":"b2c5d6a46eb09e788010ab2931b6fe9cb8a7f063"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"1f0b2a42c1ae2d2fc59c4bba3f35746afb6047a2","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        if api.keystone.keystone_can_edit_user() is False:"},{"line_number":188,"context_line":"            for field in (\u0027name\u0027, \u0027email\u0027, \u0027password\u0027, \u0027confirm_password\u0027):"},{"line_number":189,"context_line":"                self.fields.pop(field)"},{"line_number":190,"context_line":"        # For keystone V3, display the two fields in read-only"},{"line_number":191,"context_line":"        if api.keystone.VERSIONS.active \u003e\u003d 3:"},{"line_number":192,"context_line":"            readonlyInput \u003d forms.TextInput(attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027})"},{"line_number":193,"context_line":"            self.fields[\"domain_id\"].widget \u003d readonlyInput"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_b65545fb","line":190,"updated":"2014-11-26 04:17:11.000000000","message":"hi  steve, i think we should remove these indent","commit_id":"256cc18a73eda8177807a543cf676f8eedb5fffc"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9b1a48e90af86cac8e5cf1246755a5df05a2212a","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        if api.keystone.keystone_can_edit_user() is False:"},{"line_number":188,"context_line":"            for field in (\u0027name\u0027, \u0027email\u0027, \u0027password\u0027, \u0027confirm_password\u0027):"},{"line_number":189,"context_line":"                self.fields.pop(field)"},{"line_number":190,"context_line":"        # For keystone V3, display the two fields in read-only"},{"line_number":191,"context_line":"        if api.keystone.VERSIONS.active \u003e\u003d 3:"},{"line_number":192,"context_line":"            readonlyInput \u003d forms.TextInput(attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027})"},{"line_number":193,"context_line":"            self.fields[\"domain_id\"].widget \u003d readonlyInput"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_a287c85f","line":190,"updated":"2014-11-25 20:57:18.000000000","message":"nit: undo this change?","commit_id":"256cc18a73eda8177807a543cf676f8eedb5fffc"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"9b1a48e90af86cac8e5cf1246755a5df05a2212a","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"        check_admin_password \u003d getattr(settings,"},{"line_number":197,"context_line":"                                       \u0027ENFORCE_PASSWORD_CHECK\u0027, False)"},{"line_number":198,"context_line":"        if check_admin_password:"},{"line_number":199,"context_line":"            admin_input \u003d forms.PasswordInput(render_value\u003dFalse)"},{"line_number":200,"context_line":"            self.fields[\"admin_password\"].widget \u003d admin_input"},{"line_number":201,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_6289606e","line":198,"updated":"2014-11-25 20:57:18.000000000","message":"you could put this all on one line and eliminate the local variable","commit_id":"256cc18a73eda8177807a543cf676f8eedb5fffc"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"44705d749c9ce743a1329650fb131023f5a4f3f7","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            self.fields[\"domain_name\"].widget \u003d readonlyInput"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        if getattr(settings, \u0027ENFORCE_PASSWORD_CHECK\u0027, False):"},{"line_number":198,"context_line":"            self.fields[\"admin_password\"].widget \u003d forms.PasswordInput()"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    # We have to protect the entire \"data\" dict because it contains the"},{"line_number":201,"context_line":"    # password and confirm_password strings."}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_087612a4","line":198,"updated":"2014-12-03 23:17:55.000000000","message":"Should this become required too?","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"ed7545214e491103ef8f07d9c42cf85f0e761e77","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            self.fields[\"domain_name\"].widget \u003d readonlyInput"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        if getattr(settings, \u0027ENFORCE_PASSWORD_CHECK\u0027, False):"},{"line_number":198,"context_line":"            self.fields[\"admin_password\"].widget \u003d forms.PasswordInput()"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    # We have to protect the entire \"data\" dict because it contains the"},{"line_number":201,"context_line":"    # password and confirm_password strings."}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_cc9c14c3","line":198,"in_reply_to":"5a890539_087612a4","updated":"2014-12-04 03:59:54.000000000","message":"If user decides *not* to change password and only edit email... then that would be problematic.  It would have to auto-detect that user entered password then add \u0027*\u0027 accordingly. :)","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"ed4aed544151c103721fe670c09a54c18f5a808d","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            self.fields[\"domain_name\"].widget \u003d readonlyInput"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        if getattr(settings, \u0027ENFORCE_PASSWORD_CHECK\u0027, False):"},{"line_number":198,"context_line":"            self.fields[\"admin_password\"].widget \u003d forms.PasswordInput()"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    # We have to protect the entire \"data\" dict because it contains the"},{"line_number":201,"context_line":"    # password and confirm_password strings."}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_8ce20c9e","line":198,"in_reply_to":"5a890539_4cdca4e4","updated":"2014-12-04 04:35:16.000000000","message":"The validation should probably happen in the form too","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"7965a1c53f5f3ededfcba8bebf7f4cca38cd1e85","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            self.fields[\"domain_name\"].widget \u003d readonlyInput"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        if getattr(settings, \u0027ENFORCE_PASSWORD_CHECK\u0027, False):"},{"line_number":198,"context_line":"            self.fields[\"admin_password\"].widget \u003d forms.PasswordInput()"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    # We have to protect the entire \"data\" dict because it contains the"},{"line_number":201,"context_line":"    # password and confirm_password strings."}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_4cdca4e4","line":198,"in_reply_to":"5a890539_cc9c14c3","updated":"2014-12-04 04:33:48.000000000","message":"Do you mean the admin password is only required if the User password has been updated?\n\nIf yes, I don\u0027t see that code  in the api.keystone :P","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"2d2cc45b029b89e1db5ff7bf23bebe022dd7f4f5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    # admin_password may be applicable on the Change Password form"},{"line_number":42,"context_line":"    admin_password \u003d forms.CharField("},{"line_number":43,"context_line":"        label\u003d_(\"Admin Password\"),"},{"line_number":44,"context_line":"        widget\u003dforms.HiddenInput())"},{"line_number":45,"context_line":"    password \u003d forms.RegexField("},{"line_number":46,"context_line":"        label\u003d_(\"Password\"),"},{"line_number":47,"context_line":"        widget\u003dforms.PasswordInput(render_value\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a80dd14_0b2ff8f7","line":44,"updated":"2015-03-09 13:38:21.000000000","message":"Would it makes sense to add the required flag to this field? Maybe only add it below if the ENFORCE_PASSWORD_CHECK is true?","commit_id":"2946006929ba6d685455da43de727bbff09e316d"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"b2feca894525028246e727f9cb557c49818f18f5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    # admin_password may be applicable on the Change Password form"},{"line_number":42,"context_line":"    admin_password \u003d forms.CharField("},{"line_number":43,"context_line":"        label\u003d_(\"Admin Password\"),"},{"line_number":44,"context_line":"        widget\u003dforms.HiddenInput())"},{"line_number":45,"context_line":"    password \u003d forms.RegexField("},{"line_number":46,"context_line":"        label\u003d_(\"Password\"),"},{"line_number":47,"context_line":"        widget\u003dforms.PasswordInput(render_value\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a80dd14_4419c820","line":44,"in_reply_to":"9a80dd14_067fe266","updated":"2015-03-10 00:43:40.000000000","message":"Done","commit_id":"2946006929ba6d685455da43de727bbff09e316d"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"34719213e35cba9bd69138db93cf4d4246f6d17e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    # admin_password may be applicable on the Change Password form"},{"line_number":42,"context_line":"    admin_password \u003d forms.CharField("},{"line_number":43,"context_line":"        label\u003d_(\"Admin Password\"),"},{"line_number":44,"context_line":"        widget\u003dforms.HiddenInput())"},{"line_number":45,"context_line":"    password \u003d forms.RegexField("},{"line_number":46,"context_line":"        label\u003d_(\"Password\"),"},{"line_number":47,"context_line":"        widget\u003dforms.PasswordInput(render_value\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a80dd14_a02fde3d","line":44,"in_reply_to":"9a80dd14_0b2ff8f7","updated":"2015-03-09 18:18:31.000000000","message":"Hey Sam, this \"required\" field is hidden by default.","commit_id":"2946006929ba6d685455da43de727bbff09e316d"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"907c0bc972416dba82c0ae837e8f301041ba0a31","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    # admin_password may be applicable on the Change Password form"},{"line_number":42,"context_line":"    admin_password \u003d forms.CharField("},{"line_number":43,"context_line":"        label\u003d_(\"Admin Password\"),"},{"line_number":44,"context_line":"        widget\u003dforms.HiddenInput())"},{"line_number":45,"context_line":"    password \u003d forms.RegexField("},{"line_number":46,"context_line":"        label\u003d_(\"Password\"),"},{"line_number":47,"context_line":"        widget\u003dforms.PasswordInput(render_value\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a80dd14_067fe266","line":44,"in_reply_to":"9a80dd14_a02fde3d","updated":"2015-03-09 19:08:51.000000000","message":"It is, could it be added to the \n\nif getattr(settings, \u0027ENFORCE_PASSWORD_CHECK\u0027, False):\n...\n\nblock below in the __init__? I\u0027m just curious more that anything to know if the form validation that required\u003dTrue provides would be of any consequence in this situation?","commit_id":"2946006929ba6d685455da43de727bbff09e316d"},{"author":{"_account_id":6460,"name":"Brad Topol","email":"btopol@us.ibm.com","username":"btopol"},"change_message_id":"342d0f53735c308b2cb75ffa087264d73014aca5","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        data.pop(\u0027confirm_password\u0027, None)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        # Verify admin password before changing user password"},{"line_number":248,"context_line":"        if getattr(settings, \u0027ENFORCE_PASSWORD_CHECK\u0027, False):"},{"line_number":249,"context_line":"            admin_password \u003d data.pop(\u0027admin_password\u0027)"},{"line_number":250,"context_line":"            if not api.keystone.user_verify_admin_password(request,"},{"line_number":251,"context_line":"                                                           admin_password):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a80dd14_dcef88af","line":248,"updated":"2015-03-07 03:33:00.000000000","message":"Nice!","commit_id":"2946006929ba6d685455da43de727bbff09e316d"}],"openstack_dashboard/dashboards/identity/users/tests.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1bb85ee8e78ed9e60293505d60d145618d646b6e","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                                       \u0027user_update_password\u0027,"},{"line_number":281,"context_line":"                                       \u0027user_update\u0027,"},{"line_number":282,"context_line":"                                       \u0027roles_for_user\u0027, )})"},{"line_number":283,"context_line":"    def _update(self, user):"},{"line_number":284,"context_line":"        user \u003d self.users.get(id\u003d\"1\")"},{"line_number":285,"context_line":"        domain_id \u003d user.domain_id"},{"line_number":286,"context_line":"        domain \u003d self.domains.get(id\u003ddomain_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_3becb9f3","side":"PARENT","line":283,"updated":"2014-11-27 02:21:45.000000000","message":"i\u0027m not sure how/when this was called, i can\u0027t find any instance of it in the code, and test runners won\u0027t perform tests on a function not starting with test*","commit_id":"ec012c694391bdb77d9fac03fe3a12f70f2123cd"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"1bb85ee8e78ed9e60293505d60d145618d646b6e","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                                       \u0027user_update_password\u0027,"},{"line_number":281,"context_line":"                                       \u0027user_update\u0027,"},{"line_number":282,"context_line":"                                       \u0027roles_for_user\u0027, )})"},{"line_number":283,"context_line":"    def test_update(self):"},{"line_number":284,"context_line":"        user \u003d self.users.get(id\u003d\"1\")"},{"line_number":285,"context_line":"        domain_id \u003d user.domain_id"},{"line_number":286,"context_line":"        domain \u003d self.domains.get(id\u003ddomain_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a890539_5bb8a5e8","line":283,"updated":"2014-11-27 02:21:45.000000000","message":"so this looks fine, but now we are always passing in the admin password, we should have a test where it\u0027s not passed in at all. since it\u0027s a configurable option and all.","commit_id":"cbba28925d6459c11b8b24ee58bbe94b5d01b6b0"}],"openstack_dashboard/local/local_settings.py.example":[{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"8aab3230b3b2b13c0443ade2deb1dfe46cb5e2b6","unresolved":false,"context_lines":[{"line_number":269,"context_line":"# }"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"# This setting will display an \u0027Admin Password\u0027 field on the Edit User form to"},{"line_number":272,"context_line":"# verify that it is indeed the admin logged in who wants to change the "},{"line_number":273,"context_line":"# password."},{"line_number":274,"context_line":"# ENFORCE_PASSWORD_CHECK \u003d True"},{"line_number":275,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"5a890539_875c67f2","line":272,"updated":"2014-11-27 10:04:18.000000000","message":"Looks like there is redundant whitespace.","commit_id":"cbba28925d6459c11b8b24ee58bbe94b5d01b6b0"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"44705d749c9ce743a1329650fb131023f5a4f3f7","unresolved":false,"context_lines":[{"line_number":271,"context_line":"# This setting will display an \u0027Admin Password\u0027 field on the Edit User form to"},{"line_number":272,"context_line":"# verify that it is indeed the admin logged in who wants to change the"},{"line_number":273,"context_line":"# password."},{"line_number":274,"context_line":"# ENFORCE_PASSWORD_CHECK \u003d True"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"# The Horizon Policy Enforcement engine uses these values to load per service"},{"line_number":277,"context_line":"# policy rule files. The content of these files should match the files the"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"5a890539_c8e40a3e","line":274,"updated":"2014-12-03 23:17:55.000000000","message":"Default to False?","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"ed7545214e491103ef8f07d9c42cf85f0e761e77","unresolved":false,"context_lines":[{"line_number":271,"context_line":"# This setting will display an \u0027Admin Password\u0027 field on the Edit User form to"},{"line_number":272,"context_line":"# verify that it is indeed the admin logged in who wants to change the"},{"line_number":273,"context_line":"# password."},{"line_number":274,"context_line":"# ENFORCE_PASSWORD_CHECK \u003d True"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"# The Horizon Policy Enforcement engine uses these values to load per service"},{"line_number":277,"context_line":"# policy rule files. The content of these files should match the files the"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"5a890539_4cb02443","line":274,"in_reply_to":"5a890539_c8e40a3e","updated":"2014-12-04 03:59:54.000000000","message":"Done","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"01fefbadd6ed3f9295296c1935fe441ea7aa2ac7","unresolved":false,"context_lines":[{"line_number":271,"context_line":"# Set this to True to display the \u0027Admin Password\u0027 field on the Edit User"},{"line_number":272,"context_line":"# form in order to verify that it is indeed the admin logged in who wants to"},{"line_number":273,"context_line":"# change the password."},{"line_number":274,"context_line":"# ENFORCE_PASSWORD_CHECK \u003d False"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"# The Horizon Policy Enforcement engine uses these values to load per service"},{"line_number":277,"context_line":"# policy rule files. The content of these files should match the files the"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"5a890539_4c03c441","line":274,"updated":"2014-12-04 04:36:43.000000000","message":"Can you clarify if the admin password is only required if updating user password or updating any user info.  \n\nPlease clarify it too in the docs. :)","commit_id":"a36ba158320ab4be055a84a1d006e0a5a7a99442"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"52667822ee25f92a8ede23cd72bd2cb25506fcef","unresolved":false,"context_lines":[{"line_number":271,"context_line":"# Set this to True to display the \u0027Admin Password\u0027 field on the Edit User"},{"line_number":272,"context_line":"# form in order to verify that it is indeed the admin logged in who wants to"},{"line_number":273,"context_line":"# change the password."},{"line_number":274,"context_line":"# ENFORCE_PASSWORD_CHECK \u003d False"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"# The Horizon Policy Enforcement engine uses these values to load per service"},{"line_number":277,"context_line":"# policy rule files. The content of these files should match the files the"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"5a890539_5b99a11d","line":274,"in_reply_to":"5a890539_4c03c441","updated":"2014-12-04 19:53:43.000000000","message":"Done","commit_id":"a36ba158320ab4be055a84a1d006e0a5a7a99442"}],"openstack_dashboard/test/test_data/keystone_data.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"44705d749c9ce743a1329650fb131023f5a4f3f7","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                 \u0027name\u0027: \u0027user_five\u0027,"},{"line_number":212,"context_line":"                 \u0027email\u0027: None,"},{"line_number":213,"context_line":"                 \u0027password\u0027: \u0027password\u0027,"},{"line_number":214,"context_line":"                 \u0027admin_password\u0027: \u0027admin_password\u0027,"},{"line_number":215,"context_line":"                 \u0027token\u0027: \u0027test_token\u0027,"},{"line_number":216,"context_line":"                 \u0027project_id\u0027: \u00272\u0027,"},{"line_number":217,"context_line":"                 \u0027enabled\u0027: True,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_e8f46656","line":214,"updated":"2014-12-03 23:17:55.000000000","message":"This is not part of the user data, why are we adding it here?","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"ed7545214e491103ef8f07d9c42cf85f0e761e77","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                 \u0027name\u0027: \u0027user_five\u0027,"},{"line_number":212,"context_line":"                 \u0027email\u0027: None,"},{"line_number":213,"context_line":"                 \u0027password\u0027: \u0027password\u0027,"},{"line_number":214,"context_line":"                 \u0027admin_password\u0027: \u0027admin_password\u0027,"},{"line_number":215,"context_line":"                 \u0027token\u0027: \u0027test_token\u0027,"},{"line_number":216,"context_line":"                 \u0027project_id\u0027: \u00272\u0027,"},{"line_number":217,"context_line":"                 \u0027enabled\u0027: True,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_6cab20d6","line":214,"in_reply_to":"5a890539_e8f46656","updated":"2014-12-04 03:59:54.000000000","message":"Done","commit_id":"5ff32986fa70abf1729eb6ab1dc78b57807f8522"}]}
