)]}'
{"horizon/static/angular/modal/modal.js":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"6974cada1b99553dec25e2707be351a343e967f2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  angular.module(\u0027hz.widget.modal\u0027, [\u0027ui.bootstrap\u0027])"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    .controller(\u0027modalCtrl\u0027, [ \u0027$scope\u0027, \u0027$modalInstance\u0027, \u0027context\u0027,"},{"line_number":14,"context_line":"      function($scope, $mInstance, context) {"},{"line_number":15,"context_line":"        $scope.context \u003d context;"},{"line_number":16,"context_line":"        $scope.submit \u003d function(){ $mInstance.close(); };"},{"line_number":17,"context_line":"        $scope.cancel \u003d function(){ $mInstance.dismiss(\u0027cancel\u0027); };"}],"source_content_type":"text/javascript","patch_set":16,"id":"da86d52c_25549253","line":14,"updated":"2015-02-02 05:12:02.000000000","message":"Why rename the parameter? There is no benefit, and would only introduce potential for errors.","commit_id":"7ffbb0834cffc1b043152ff1335f5544ad08f66f"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"d1edbd6e9e6f6518015f182f20de19b3ad258bbc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  angular.module(\u0027hz.widget.modal\u0027, [\u0027ui.bootstrap\u0027])"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    .controller(\u0027modalCtrl\u0027, [ \u0027$scope\u0027, \u0027$modalInstance\u0027, \u0027context\u0027,"},{"line_number":14,"context_line":"      function($scope, $mInstance, context) {"},{"line_number":15,"context_line":"        $scope.context \u003d context;"},{"line_number":16,"context_line":"        $scope.submit \u003d function(){ $mInstance.close(); };"},{"line_number":17,"context_line":"        $scope.cancel \u003d function(){ $mInstance.dismiss(\u0027cancel\u0027); };"}],"source_content_type":"text/javascript","patch_set":16,"id":"da86d52c_29575759","line":14,"in_reply_to":"da86d52c_25549253","updated":"2015-02-05 17:45:23.000000000","message":"Personal preference really, but you have a point, I will change it back.","commit_id":"7ffbb0834cffc1b043152ff1335f5544ad08f66f"},{"author":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"change_message_id":"bb2cffd0be52257a5894cb4f22ca90617fa11f98","unresolved":false,"context_lines":[{"line_number":7,"context_line":"   *   title - the title of the modal"},{"line_number":8,"context_line":"   *   body - the body of the modal"},{"line_number":9,"context_line":"   *   submit - the submit label"},{"line_number":10,"context_line":"   */"},{"line_number":11,"context_line":"  angular.module(\u0027hz.widget.modal\u0027, [])"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    .controller(\u0027modalCtrl\u0027, [ \u0027$scope\u0027, \u0027$modalInstance\u0027, \u0027context\u0027,"}],"source_content_type":"text/javascript","patch_set":19,"id":"da86d52c_698bfc1e","line":10,"updated":"2015-02-06 04:33:57.000000000","message":"Glad to see you\u0027ve got documentation! Could we get an example usage? What do you think of ngdoc[1] formatting? \n\n[1] https://github.com/angular/angular.js/wiki/Writing-AngularJS-Documentation","commit_id":"9074f50d2b5fc78f2866cd8fdd4277496d652e53"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"dfaef9b60c101ca13ec3cbd187b2062a1f7f0f08","unresolved":false,"context_lines":[{"line_number":7,"context_line":"   *   title - the title of the modal"},{"line_number":8,"context_line":"   *   body - the body of the modal"},{"line_number":9,"context_line":"   *   submit - the submit label"},{"line_number":10,"context_line":"   */"},{"line_number":11,"context_line":"  angular.module(\u0027hz.widget.modal\u0027, [])"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    .controller(\u0027modalCtrl\u0027, [ \u0027$scope\u0027, \u0027$modalInstance\u0027, \u0027context\u0027,"}],"source_content_type":"text/javascript","patch_set":19,"id":"da86d52c_fe014507","line":10,"in_reply_to":"da86d52c_698bfc1e","updated":"2015-02-06 20:44:07.000000000","message":"yup, will need to update the docs.","commit_id":"9074f50d2b5fc78f2866cd8fdd4277496d652e53"},{"author":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"change_message_id":"bb2cffd0be52257a5894cb4f22ca90617fa11f98","unresolved":false,"context_lines":[{"line_number":8,"context_line":"   *   body - the body of the modal"},{"line_number":9,"context_line":"   *   submit - the submit label"},{"line_number":10,"context_line":"   */"},{"line_number":11,"context_line":"  angular.module(\u0027hz.widget.modal\u0027, [])"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    .controller(\u0027modalCtrl\u0027, [ \u0027$scope\u0027, \u0027$modalInstance\u0027, \u0027context\u0027,"},{"line_number":14,"context_line":"      function($scope, $modalInstance, context) {"}],"source_content_type":"text/javascript","patch_set":19,"id":"da86d52c_494398ae","line":11,"updated":"2015-02-06 04:33:57.000000000","message":"Should specify the ui.bootstrap.modal module as a dependency?","commit_id":"9074f50d2b5fc78f2866cd8fdd4277496d652e53"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"dfaef9b60c101ca13ec3cbd187b2062a1f7f0f08","unresolved":false,"context_lines":[{"line_number":8,"context_line":"   *   body - the body of the modal"},{"line_number":9,"context_line":"   *   submit - the submit label"},{"line_number":10,"context_line":"   */"},{"line_number":11,"context_line":"  angular.module(\u0027hz.widget.modal\u0027, [])"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    .controller(\u0027modalCtrl\u0027, [ \u0027$scope\u0027, \u0027$modalInstance\u0027, \u0027context\u0027,"},{"line_number":14,"context_line":"      function($scope, $modalInstance, context) {"}],"source_content_type":"text/javascript","patch_set":19,"id":"da86d52c_9e0a0926","line":11,"in_reply_to":"da86d52c_494398ae","updated":"2015-02-06 20:44:07.000000000","message":"yeah, was playing around with the integration test. as soon as i include it, it breaks. but when its not there, it works fine. \u003d/ still trying to demystify the whole thing....","commit_id":"9074f50d2b5fc78f2866cd8fdd4277496d652e53"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f1031ff8f4a297a75e9f5f99110148a4634a3569","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      } // end of function"},{"line_number":19,"context_line":"    ]) // end of controller"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    .factory(\u0027modalServico\u0027, [\u0027$modal\u0027, \u0027basePath\u0027,"},{"line_number":22,"context_line":"      function($modal, path) {"},{"line_number":23,"context_line":"        return function(params) {"},{"line_number":24,"context_line":"          var options \u003d {"}],"source_content_type":"text/javascript","patch_set":19,"id":"da86d52c_ec853fcf","line":21,"updated":"2015-02-06 01:20:41.000000000","message":"Also, $modal comes from ui.bootstrap, so that really must be listed as a dependency of this module.","commit_id":"9074f50d2b5fc78f2866cd8fdd4277496d652e53"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"3c2f6ce648fb364c844a8a8596e442c99338a934","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      } // end of function"},{"line_number":19,"context_line":"    ]) // end of controller"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    .factory(\u0027modalServico\u0027, [\u0027$modal\u0027, \u0027basePath\u0027,"},{"line_number":22,"context_line":"      function($modal, path) {"},{"line_number":23,"context_line":"        return function(params) {"},{"line_number":24,"context_line":"          var options \u003d {"}],"source_content_type":"text/javascript","patch_set":19,"id":"da86d52c_0cd453ea","line":21,"updated":"2015-02-06 01:16:59.000000000","message":"Typo here. I think a basic test just to ensure the service is usable, and that it formats the modal HTML as expected, would be a good idea.","commit_id":"9074f50d2b5fc78f2866cd8fdd4277496d652e53"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"dfaef9b60c101ca13ec3cbd187b2062a1f7f0f08","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      } // end of function"},{"line_number":19,"context_line":"    ]) // end of controller"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    .factory(\u0027modalServico\u0027, [\u0027$modal\u0027, \u0027basePath\u0027,"},{"line_number":22,"context_line":"      function($modal, path) {"},{"line_number":23,"context_line":"        return function(params) {"},{"line_number":24,"context_line":"          var options \u003d {"}],"source_content_type":"text/javascript","patch_set":19,"id":"da86d52c_5203250d","line":21,"in_reply_to":"da86d52c_0cd453ea","updated":"2015-02-06 20:44:07.000000000","message":"sure, basic test can be included.","commit_id":"9074f50d2b5fc78f2866cd8fdd4277496d652e53"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"dfaef9b60c101ca13ec3cbd187b2062a1f7f0f08","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      } // end of function"},{"line_number":19,"context_line":"    ]) // end of controller"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    .factory(\u0027modalServico\u0027, [\u0027$modal\u0027, \u0027basePath\u0027,"},{"line_number":22,"context_line":"      function($modal, path) {"},{"line_number":23,"context_line":"        return function(params) {"},{"line_number":24,"context_line":"          var options \u003d {"}],"source_content_type":"text/javascript","patch_set":19,"id":"da86d52c_3225d1ae","line":21,"in_reply_to":"da86d52c_ec853fcf","updated":"2015-02-06 20:44:07.000000000","message":"see above comment.","commit_id":"9074f50d2b5fc78f2866cd8fdd4277496d652e53"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"68b22193acdf7b5865ab8d33b210fc0aca203a10","unresolved":false,"context_lines":[{"line_number":7,"context_line":"   *"},{"line_number":8,"context_line":"   * # hz.widget.modal"},{"line_number":9,"context_line":"   *"},{"line_number":10,"context_line":"   * The `hz.widget.modal` provides modal services."},{"line_number":11,"context_line":"   *"},{"line_number":12,"context_line":"   * Requires {@link http://angular-ui.github.io/bootstrap/ `Angular-bootstrap`}"},{"line_number":13,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":20,"id":"da86d52c_64673fb8","line":10,"updated":"2015-02-09 22:29:35.000000000","message":"Nit: \"provides services for creating simple confirmation modal dialogs\".","commit_id":"bd73e31aef45cf820b7e518c53aabe91cdfb0882"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"a1dd65ff1a00814f51e2f610363f9902dc0a8f89","unresolved":false,"context_lines":[{"line_number":7,"context_line":"   *"},{"line_number":8,"context_line":"   * # hz.widget.modal"},{"line_number":9,"context_line":"   *"},{"line_number":10,"context_line":"   * The `hz.widget.modal` provides modal services."},{"line_number":11,"context_line":"   *"},{"line_number":12,"context_line":"   * Requires {@link http://angular-ui.github.io/bootstrap/ `Angular-bootstrap`}"},{"line_number":13,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":20,"id":"da86d52c_a2ec8fbc","line":10,"in_reply_to":"da86d52c_64673fb8","updated":"2015-02-11 00:10:39.000000000","message":"I expect that there might be more complicated modals down the road. They will fit in this module nicely. So the description is accurate. I\u0027ll add your description to the modalService below instead.","commit_id":"bd73e31aef45cf820b7e518c53aabe91cdfb0882"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"2596eb078a0281d046f0ec468c98494f93997e31","unresolved":false,"context_lines":[{"line_number":31,"context_line":"     * Horizon\u0027s controller for confirmation dialog."},{"line_number":32,"context_line":"     * Passes context along to the template."},{"line_number":33,"context_line":"     * If user presses cancel button or closes dialog, modal gets dismissed."},{"line_number":34,"context_line":"     * If user presses submit button, modal gets closed."},{"line_number":35,"context_line":"     * This controller is automatically included in modalService."},{"line_number":36,"context_line":"     */"},{"line_number":37,"context_line":"    .controller(\u0027modalCtrl\u0027, [ \u0027$scope\u0027, \u0027$modalInstance\u0027, \u0027context\u0027,"}],"source_content_type":"text/javascript","patch_set":20,"id":"da86d52c_eee4b3e1","line":34,"updated":"2015-02-10 23:54:53.000000000","message":"also mention, some action may be taken?","commit_id":"bd73e31aef45cf820b7e518c53aabe91cdfb0882"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"dbea75958ae51adf5c857949c95a6904561e6f13","unresolved":false,"context_lines":[{"line_number":31,"context_line":"     * Horizon\u0027s controller for confirmation dialog."},{"line_number":32,"context_line":"     * Passes context along to the template."},{"line_number":33,"context_line":"     * If user presses cancel button or closes dialog, modal gets dismissed."},{"line_number":34,"context_line":"     * If user presses submit button, modal gets closed."},{"line_number":35,"context_line":"     * This controller is automatically included in modalService."},{"line_number":36,"context_line":"     */"},{"line_number":37,"context_line":"    .controller(\u0027modalCtrl\u0027, [ \u0027$scope\u0027, \u0027$modalInstance\u0027, \u0027context\u0027,"}],"source_content_type":"text/javascript","patch_set":20,"id":"da86d52c_82522bdc","line":34,"in_reply_to":"da86d52c_62c29786","updated":"2015-02-11 00:03:11.000000000","message":"gotcha","commit_id":"bd73e31aef45cf820b7e518c53aabe91cdfb0882"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"0e143ed60b183bfba42113288ef7ab593afb5f4a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"     * Horizon\u0027s controller for confirmation dialog."},{"line_number":32,"context_line":"     * Passes context along to the template."},{"line_number":33,"context_line":"     * If user presses cancel button or closes dialog, modal gets dismissed."},{"line_number":34,"context_line":"     * If user presses submit button, modal gets closed."},{"line_number":35,"context_line":"     * This controller is automatically included in modalService."},{"line_number":36,"context_line":"     */"},{"line_number":37,"context_line":"    .controller(\u0027modalCtrl\u0027, [ \u0027$scope\u0027, \u0027$modalInstance\u0027, \u0027context\u0027,"}],"source_content_type":"text/javascript","patch_set":20,"id":"da86d52c_62c29786","line":34,"in_reply_to":"da86d52c_eee4b3e1","updated":"2015-02-10 23:59:24.000000000","message":"Not sure I understand. The job of the modalCtrl is to let the caller know whether the user submitted or canceled the modal. So it is the caller\u0027s responsibility to do something base on this knowledge (such as taking some action). The example is a outdated, but here is how you would use it: https://review.openstack.org/#/c/133767/34/horizon/static/horizon/js/angular/dashboards/hz.identity.users.js Line 41\n\nHope that helps.","commit_id":"bd73e31aef45cf820b7e518c53aabe91cdfb0882"}],"horizon/static/angular/modal/simple-modal.spec.js":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"203f32314af4fe217196b5b9685b62f68005b07a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u0027use strict\u0027;"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe(\u0027hz.widget.modal module\u0027, function(){"},{"line_number":4,"context_line":"  it(\u0027should have been defined\u0027, function(){"}],"source_content_type":"text/javascript","patch_set":23,"id":"da86d52c_ce278510","line":1,"updated":"2015-02-12 23:30:52.000000000","message":"General question: do you know why test resides in the same directory as the angular code?","commit_id":"e6a425fdae393242118ed614ffdd4b86c1dc98da"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"d4b2c858147e9ca272d1bfdbd5328739b74a5321","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u0027use strict\u0027;"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe(\u0027hz.widget.modal module\u0027, function(){"},{"line_number":4,"context_line":"  it(\u0027should have been defined\u0027, function(){"}],"source_content_type":"text/javascript","patch_set":23,"id":"da86d52c_9629ff8b","line":1,"in_reply_to":"da86d52c_ce278510","updated":"2015-02-13 18:33:20.000000000","message":"The idea behind the new file structure is to group files based on functionality. Instead of looking into 5 different places (one for the js, one for the html, one for the test, one for the css, etc....), its all localize to 1.","commit_id":"e6a425fdae393242118ed614ffdd4b86c1dc98da"}],"horizon/static/horizon/js/angular/horizon.js":[{"author":{"_account_id":11881,"name":"Aaron Sahlin","email":"asahlin@us.ibm.com","username":"asahlin"},"change_message_id":"afebaabc10492141437587db08ac608af28810b2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  angular.module(\u0027hz\u0027, dependencies)"},{"line_number":8,"context_line":"    .config([\u0027$interpolateProvider\u0027, \u0027$httpProvider\u0027,"},{"line_number":9,"context_line":"      function ($interpolateProvider, $httpProvider) {"},{"line_number":10,"context_line":"        $interpolateProvider.startSymbol(\u0027{$\u0027);"},{"line_number":11,"context_line":"        $interpolateProvider.endSymbol(\u0027$}\u0027);"},{"line_number":12,"context_line":"        $httpProvider.defaults.xsrfHeaderName \u003d \u0027X-CSRFToken\u0027;"},{"line_number":13,"context_line":"        $httpProvider.defaults.xsrfCookieName \u003d \u0027csrftoken\u0027;"}],"source_content_type":"text/javascript","patch_set":3,"id":"3a961159_cc8ea432","line":10,"updated":"2015-01-09 20:42:19.000000000","message":"Might be nice to add an explanation here regarding what / why you are overriding the default {{ }} symbols of AngularJS.","commit_id":"5f4221ec9b938dde9cf28caf0b3d011d9fde23f0"},{"author":{"_account_id":13276,"name":"Paul Karikh","username":"pkarikh","inactive":true},"change_message_id":"15ad380348cc9be79e05f227441aacb528caddc0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  angular.module(\u0027hz\u0027, dependencies)"},{"line_number":8,"context_line":"    .config([\u0027$interpolateProvider\u0027, \u0027$httpProvider\u0027,"},{"line_number":9,"context_line":"      function ($interpolateProvider, $httpProvider) {"},{"line_number":10,"context_line":"        $interpolateProvider.startSymbol(\u0027{$\u0027);"},{"line_number":11,"context_line":"        $interpolateProvider.endSymbol(\u0027$}\u0027);"},{"line_number":12,"context_line":"        $httpProvider.defaults.xsrfHeaderName \u003d \u0027X-CSRFToken\u0027;"},{"line_number":13,"context_line":"        $httpProvider.defaults.xsrfCookieName \u003d \u0027csrftoken\u0027;"}],"source_content_type":"text/javascript","patch_set":3,"id":"3a961159_bf0a1877","line":10,"in_reply_to":"3a961159_cc8ea432","updated":"2015-01-13 09:03:12.000000000","message":"Do we need it here? As far as I understand, we have already set it in horizon.js: https://github.com/openstack/horizon/blob/master/horizon/static/horizon/js/angular/horizon.js#L10","commit_id":"5f4221ec9b938dde9cf28caf0b3d011d9fde23f0"}],"horizon/static/horizon/js/angular/modal/modal.html":[{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"a14e31c33dcedf24c066c9525b6eb51eff1a9a0c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\"modal-header\"\u003e"},{"line_number":2,"context_line":"  \u003ch3 class\u003d\"modal-title\"\u003e"},{"line_number":3,"context_line":"    {$ context.title $}"},{"line_number":4,"context_line":"  \u003c/h3\u003e"},{"line_number":5,"context_line":"\u003c/div\u003e"},{"line_number":6,"context_line":"\u003cdiv class\u003d\"modal-body clearfix\"\u003e"}],"source_content_type":"text/html","patch_set":14,"id":"fa81d914_15edfac3","line":3,"updated":"2015-01-28 12:47:51.000000000","message":"I think it is better to use ng-bind instead of brackets. Same for the other ones below...","commit_id":"e45da674604d3058e6098e3d02a5182079c98908"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"d341f251ec96a49d56ea554537e6dc57cedcd880","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\"modal-header\"\u003e"},{"line_number":2,"context_line":"  \u003ch3 class\u003d\"modal-title\"\u003e"},{"line_number":3,"context_line":"    {$ context.title $}"},{"line_number":4,"context_line":"  \u003c/h3\u003e"},{"line_number":5,"context_line":"\u003c/div\u003e"},{"line_number":6,"context_line":"\u003cdiv class\u003d\"modal-body clearfix\"\u003e"}],"source_content_type":"text/html","patch_set":14,"id":"fa81d914_51413138","line":3,"in_reply_to":"fa81d914_15edfac3","updated":"2015-01-28 19:08:46.000000000","message":"Good point, they should all be ng-bind.","commit_id":"e45da674604d3058e6098e3d02a5182079c98908"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"c08bfa8a46a394c8a388c2c16083bfe1e51676f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\"modal-header\"\u003e"},{"line_number":2,"context_line":"  \u003ch3 class\u003d\"modal-title\"\u003e"},{"line_number":3,"context_line":"    {$ context.title $}"},{"line_number":4,"context_line":"  \u003c/h3\u003e"},{"line_number":5,"context_line":"\u003c/div\u003e"},{"line_number":6,"context_line":"\u003cdiv class\u003d\"modal-body clearfix\"\u003e"}],"source_content_type":"text/html","patch_set":14,"id":"fa81d914_f187855f","line":3,"in_reply_to":"fa81d914_51413138","updated":"2015-01-28 19:11:03.000000000","message":"Looks like in angular 1.3.1, you can bind once using ::variable. Looks like a good place to insert.","commit_id":"e45da674604d3058e6098e3d02a5182079c98908"}],"horizon/static/horizon/js/angular/modal/modal.js":[{"author":{"_account_id":7509,"name":"Jiri Tomasek","email":"jtomasek@redhat.com","username":"jtomasek"},"change_message_id":"96976fdebaa07cd0f8898082864c596c1a0e648a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      $modalInstance.dismiss(\u0027cancel\u0027);"},{"line_number":19,"context_line":"    };"},{"line_number":20,"context_line":"  });"},{"line_number":21,"context_line":"  app.factory(\u0027hzModal\u0027, function($modal) {"},{"line_number":22,"context_line":"    return function(params) {"},{"line_number":23,"context_line":"      var options \u003d {"},{"line_number":24,"context_line":"        controller: \u0027hzModalCtrl\u0027,"}],"source_content_type":"text/javascript","patch_set":14,"id":"fa81d914_973727b0","line":21,"updated":"2015-01-28 15:32:59.000000000","message":"hzModalFactory might be better name here","commit_id":"e45da674604d3058e6098e3d02a5182079c98908"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"d341f251ec96a49d56ea554537e6dc57cedcd880","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      $modalInstance.dismiss(\u0027cancel\u0027);"},{"line_number":19,"context_line":"    };"},{"line_number":20,"context_line":"  });"},{"line_number":21,"context_line":"  app.factory(\u0027hzModal\u0027, function($modal) {"},{"line_number":22,"context_line":"    return function(params) {"},{"line_number":23,"context_line":"      var options \u003d {"},{"line_number":24,"context_line":"        controller: \u0027hzModalCtrl\u0027,"}],"source_content_type":"text/javascript","patch_set":14,"id":"fa81d914_7ead2431","line":21,"in_reply_to":"fa81d914_973727b0","updated":"2015-01-28 19:08:46.000000000","message":"I\u0027ll have to wait until one of the other angular patch merges first. We\u0027re going to include all the widgets into one module.","commit_id":"e45da674604d3058e6098e3d02a5182079c98908"}],"openstack_dashboard/templates/_header.html":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"203f32314af4fe217196b5b9685b62f68005b07a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003cdiv class\u003d\"switcher_bar\"\u003e"},{"line_number":8,"context_line":"  \u003cdiv class\u003d\"dropdown context-selection\"\u003e"},{"line_number":9,"context_line":"    \u003cbutton class\u003d\"btn btn-default btn-topnav dropdown-toggle\" data-toggle\u003d\"dropdown\"\u003e"},{"line_number":10,"context_line":"        {% show_overview %}"},{"line_number":11,"context_line":"    \u003c/button\u003e"},{"line_number":12,"context_line":"    \u003cdiv class\u003d\"dropdown-menu topbar-dropdown-menu\"\u003e"}],"source_content_type":"text/html","patch_set":23,"id":"da86d52c_8e566dcc","side":"PARENT","line":9,"updated":"2015-02-12 23:30:52.000000000","message":"Umm What is this change for?","commit_id":"094cb67846169c6588b75ea8d1153810e6a87695"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"d4b2c858147e9ca272d1bfdbd5328739b74a5321","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"\u003cdiv class\u003d\"switcher_bar\"\u003e"},{"line_number":8,"context_line":"  \u003cdiv class\u003d\"dropdown context-selection\"\u003e"},{"line_number":9,"context_line":"    \u003cbutton class\u003d\"btn btn-default btn-topnav dropdown-toggle\" data-toggle\u003d\"dropdown\"\u003e"},{"line_number":10,"context_line":"        {% show_overview %}"},{"line_number":11,"context_line":"    \u003c/button\u003e"},{"line_number":12,"context_line":"    \u003cdiv class\u003d\"dropdown-menu topbar-dropdown-menu\"\u003e"}],"source_content_type":"text/html","patch_set":23,"id":"da86d52c_6353eb39","side":"PARENT","line":9,"in_reply_to":"da86d52c_8e566dcc","updated":"2015-02-13 18:33:20.000000000","message":"Basically, we are using both angular-bootstrap and bootstrapjs. Bootstrap is picking up the widget via the data-toggle attribute while angular-bootstrap is picking up the dropdown-toggle class. So you end up with a button that has dual functionality. In this case, instead of one click to open, it takes 2, causing integration tests to fail. For more info, read previous comments.","commit_id":"094cb67846169c6588b75ea8d1153810e6a87695"}]}
