)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"121594e4db32dcbc886e060d1a104763c9076eba","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix replacement of exception category list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Make config of ADD_EXCEPTIONS plugin append to the"},{"line_number":10,"context_line":"exception category list and not replase to it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib52012bc93311ac019312b0f92b5fcb8842de53d"},{"line_number":13,"context_line":"Co-Authored-By: Eric Peterson \u003ceric.peterson1@twcable.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_ec48c05e","line":10,"updated":"2014-12-25 14:34:39.000000000","message":"nit: I think this was supposed to be \u0027not replace it\u0027?","commit_id":"65a662954decb1c99411aa66cce5cd4f65538f7f"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"38e38a01c0924695c1b497b185655f0774e0bc36","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix replacement of exception category list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Make config of ADD_EXCEPTIONS plugin append to the"},{"line_number":10,"context_line":"exception category list and not replase to it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib52012bc93311ac019312b0f92b5fcb8842de53d"},{"line_number":13,"context_line":"Co-Authored-By: Eric Peterson \u003ceric.peterson1@twcable.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_241ef10d","line":10,"in_reply_to":"3a961159_ec48c05e","updated":"2015-01-14 14:40:29.000000000","message":"Done","commit_id":"65a662954decb1c99411aa66cce5cd4f65538f7f"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"1bb50f6d38b6b5a5fcf8cc08b8e9c4400333012f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix replacement of exception category list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Make config of ADD_EXCEPTIONS plugin append to the"},{"line_number":10,"context_line":"exception category list and not replace to it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib52012bc93311ac019312b0f92b5fcb8842de53d"},{"line_number":13,"context_line":"Co-Authored-By: Eric Peterson \u003ceric.peterson1@twcable.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa81d914_82bfa0fa","line":10,"updated":"2015-01-29 17:30:26.000000000","message":"Nit: replace to it -\u003e replace it.","commit_id":"12f50c6115d656e9fb2a414c79d1abc17179b750"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"ba21a23096e7b43f9c51d1950c1db85e8323af82","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix replacement of exception category list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Make config of ADD_EXCEPTIONS plugin append to the"},{"line_number":10,"context_line":"exception category list and not replace to it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib52012bc93311ac019312b0f92b5fcb8842de53d"},{"line_number":13,"context_line":"Co-Authored-By: Eric Peterson \u003ceric.peterson1@twcable.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da86d52c_360e4535","line":10,"in_reply_to":"fa81d914_82bfa0fa","updated":"2015-02-03 13:33:59.000000000","message":"Done","commit_id":"12f50c6115d656e9fb2a414c79d1abc17179b750"}],"openstack_dashboard/utils/settings.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"4bd68bd385e46ca6d5198454c0a09781428390e4","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            continue"},{"line_number":112,"context_line":"        apps.extend(config.get(\u0027ADD_INSTALLED_APPS\u0027, []))"},{"line_number":113,"context_line":"        for category, exc_list in config.get(\u0027ADD_EXCEPTIONS\u0027, {}).iteritems():"},{"line_number":114,"context_line":"            exceptions[category] \u003d exceptions.get(category, ()) + exc_list"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        angular_modules.extend(config.get(\u0027ADD_ANGULAR_MODULES\u0027, []))"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_56f2289c","line":114,"updated":"2015-01-12 09:10:45.000000000","message":"Can we also remove duplicates?","commit_id":"65a662954decb1c99411aa66cce5cd4f65538f7f"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"38e38a01c0924695c1b497b185655f0774e0bc36","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            continue"},{"line_number":112,"context_line":"        apps.extend(config.get(\u0027ADD_INSTALLED_APPS\u0027, []))"},{"line_number":113,"context_line":"        for category, exc_list in config.get(\u0027ADD_EXCEPTIONS\u0027, {}).iteritems():"},{"line_number":114,"context_line":"            exceptions[category] \u003d exceptions.get(category, ()) + exc_list"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        angular_modules.extend(config.get(\u0027ADD_ANGULAR_MODULES\u0027, []))"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_64ef19ea","line":114,"in_reply_to":"3a961159_1aca5a46","updated":"2015-01-14 14:40:29.000000000","message":"Looks like your advice works, thank you.","commit_id":"65a662954decb1c99411aa66cce5cd4f65538f7f"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"9251b4de0fb6765f90bcfebdac4fe2accff6a8f2","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            continue"},{"line_number":112,"context_line":"        apps.extend(config.get(\u0027ADD_INSTALLED_APPS\u0027, []))"},{"line_number":113,"context_line":"        for category, exc_list in config.get(\u0027ADD_EXCEPTIONS\u0027, {}).iteritems():"},{"line_number":114,"context_line":"            exceptions[category] \u003d exceptions.get(category, ()) + exc_list"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        angular_modules.extend(config.get(\u0027ADD_ANGULAR_MODULES\u0027, []))"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_1ad41aba","line":114,"in_reply_to":"3a961159_1aca5a46","updated":"2015-01-13 09:39:08.000000000","message":"Yep, first I wanted to do it with set, but I thought that this style is not so common in Horizon.\nI think I\u0027ve got your idea.","commit_id":"65a662954decb1c99411aa66cce5cd4f65538f7f"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"a945b2efb360cccfaecad4c6550f441e99bc43f9","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            continue"},{"line_number":112,"context_line":"        apps.extend(config.get(\u0027ADD_INSTALLED_APPS\u0027, []))"},{"line_number":113,"context_line":"        for category, exc_list in config.get(\u0027ADD_EXCEPTIONS\u0027, {}).iteritems():"},{"line_number":114,"context_line":"            exceptions[category] \u003d exceptions.get(category, ()) + exc_list"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        angular_modules.extend(config.get(\u0027ADD_ANGULAR_MODULES\u0027, []))"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_1aca5a46","line":114,"in_reply_to":"3a961159_24c29f34","updated":"2015-01-13 09:33:07.000000000","message":"No, I meant something more like:\n\nexceptions[category] \u003d tuple(set(exceptions.get(category, ()) + exc_list))\n\n(not sure if it works like this, but you get the idea)","commit_id":"65a662954decb1c99411aa66cce5cd4f65538f7f"},{"author":{"_account_id":13276,"name":"Paul Karikh","username":"pkarikh","inactive":true},"change_message_id":"d0ec6de140a372ab966894bffffe32d6b281e94e","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            continue"},{"line_number":112,"context_line":"        apps.extend(config.get(\u0027ADD_INSTALLED_APPS\u0027, []))"},{"line_number":113,"context_line":"        for category, exc_list in config.get(\u0027ADD_EXCEPTIONS\u0027, {}).iteritems():"},{"line_number":114,"context_line":"            exceptions[category] \u003d exceptions.get(category, ()) + exc_list"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        angular_modules.extend(config.get(\u0027ADD_ANGULAR_MODULES\u0027, []))"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_24c29f34","line":114,"in_reply_to":"3a961159_56f2289c","updated":"2015-01-13 08:23:39.000000000","message":"Do you mean something like this:\nif category not in exceptions:\n  exceptions[category] \u003d exceptions.get(category, ()) + exc_list\n?","commit_id":"65a662954decb1c99411aa66cce5cd4f65538f7f"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"0cc463e9f5c45157fe0c882bf883ab11baf54c83","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            exceptions[category] \u003d exceptions.get(category, ()) + exc_list"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        angular_modules.extend(config.get(\u0027ADD_ANGULAR_MODULES\u0027, []))"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        js_files.update(config.get(\u0027ADD_JS_FILES\u0027, []))"},{"line_number":119,"context_line":"        update_horizon_config.update("},{"line_number":120,"context_line":"            config.get(\u0027UPDATE_HORIZON_CONFIG\u0027, {}))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_cc34e4e1","line":117,"updated":"2014-12-25 14:33:37.000000000","message":"nit: Why the whitespace change? Seems kinda strange/inconsistent.","commit_id":"65a662954decb1c99411aa66cce5cd4f65538f7f"},{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"38e38a01c0924695c1b497b185655f0774e0bc36","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            exceptions[category] \u003d exceptions.get(category, ()) + exc_list"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        angular_modules.extend(config.get(\u0027ADD_ANGULAR_MODULES\u0027, []))"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        js_files.update(config.get(\u0027ADD_JS_FILES\u0027, []))"},{"line_number":119,"context_line":"        update_horizon_config.update("},{"line_number":120,"context_line":"            config.get(\u0027UPDATE_HORIZON_CONFIG\u0027, {}))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_6418f91e","line":117,"in_reply_to":"3a961159_cc34e4e1","updated":"2015-01-14 14:40:29.000000000","message":"Done","commit_id":"65a662954decb1c99411aa66cce5cd4f65538f7f"}]}
