)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"9d1723ccf52cd3aadf8951f33f2de0e0c8a86a8e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"workflow step is denied for the user (e.g. user is not permitted to"},{"line_number":15,"context_line":"create subnets), yet he sees the corresponding steps in Horizon,"},{"line_number":16,"context_line":"provides and submits the data which leads to an error from Neutron"},{"line_number":17,"context_line":"side. More appropriate behavior here for Horizon would be to not show"},{"line_number":18,"context_line":"to the user the workflow steps he is not able to complete - and if"},{"line_number":19,"context_line":"these steps are required for successfully completing the workflow,"},{"line_number":20,"context_line":"make him unable to start the workflow itself."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"dae33548_1eb1e547","line":17,"range":{"start_line":17,"start_character":23,"end_line":17,"end_character":31},"updated":"2016-02-16 15:41:54.000000000","message":"\"behavior\"-\u003e\"behaviour\"","commit_id":"fc08237c648d5322890ab44c10b0fe0e618862be"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"e92168eefb694dad8a8988f8d97ec7be5e1f3b9f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"workflow step is denied for the user (e.g. user is not permitted to"},{"line_number":15,"context_line":"create subnets), yet he sees the corresponding steps in Horizon,"},{"line_number":16,"context_line":"provides and submits the data which leads to an error from Neutron"},{"line_number":17,"context_line":"side. More appropriate behavior here for Horizon would be to not show"},{"line_number":18,"context_line":"to the user the workflow steps he is not able to complete - and if"},{"line_number":19,"context_line":"these steps are required for successfully completing the workflow,"},{"line_number":20,"context_line":"make him unable to start the workflow itself."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"dae33548_441d5cbc","line":17,"range":{"start_line":17,"start_character":23,"end_line":17,"end_character":31},"in_reply_to":"dae33548_1eb1e547","updated":"2016-02-16 15:52:42.000000000","message":"We all speak American English here, not UK English.","commit_id":"fc08237c648d5322890ab44c10b0fe0e618862be"}],"horizon/workflows/base.py":[{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"d3310f85ad468d151a7b88adc53c83efdbc88d22","unresolved":false,"context_lines":[{"line_number":684,"context_line":"                return step"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def _gather_steps(self):"},{"line_number":687,"context_line":"        from openstack_dashboard import policy"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        ordered_step_classes \u003d self._order_steps()"},{"line_number":690,"context_line":"        for default_step in self.default_steps:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_5c405b07","line":687,"updated":"2014-12-31 14:24:25.000000000","message":"All import statements should be at the beginning of file and I don\u0027t think you can import anything from openstack_dashboard module in horizon module.","commit_id":"027dd3ddc2ad0679d77dc146e9e1b5549a28375e"},{"author":{"_account_id":13086,"name":"Yash Bathia","email":"ybathia@yahoo-inc.com","username":"ybathia"},"change_message_id":"d468e8c038651b792a461953f1de88740a68f2f8","unresolved":false,"context_lines":[{"line_number":684,"context_line":"                return step"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def _gather_steps(self):"},{"line_number":687,"context_line":"        from openstack_dashboard import policy"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        ordered_step_classes \u003d self._order_steps()"},{"line_number":690,"context_line":"        for default_step in self.default_steps:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_25c9b225","line":687,"updated":"2014-12-31 21:42:35.000000000","message":"I agree about the import statement. Can you shift the import statement to the beginning?","commit_id":"027dd3ddc2ad0679d77dc146e9e1b5549a28375e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"844f4b9024a3a331a01f743c5f9b749ac7fcebf6","unresolved":false,"context_lines":[{"line_number":684,"context_line":"                return step"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def _gather_steps(self):"},{"line_number":687,"context_line":"        from openstack_dashboard import policy"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        ordered_step_classes \u003d self._order_steps()"},{"line_number":690,"context_line":"        for default_step in self.default_steps:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a80dd14_567fa7df","line":687,"in_reply_to":"3a961159_25c9b225","updated":"2015-03-10 14:46:40.000000000","message":"Done","commit_id":"027dd3ddc2ad0679d77dc146e9e1b5549a28375e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"caa6f2bd2585123c7a77a8ae527b6c0f72589300","unresolved":false,"context_lines":[{"line_number":684,"context_line":"                return step"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def _gather_steps(self):"},{"line_number":687,"context_line":"        from openstack_dashboard import policy"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        ordered_step_classes \u003d self._order_steps()"},{"line_number":690,"context_line":"        for default_step in self.default_steps:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_5fe68de9","line":687,"in_reply_to":"3a961159_5c405b07","updated":"2014-12-31 16:08:18.000000000","message":"Planned to do so, please read the commit message :). I\u0027m waiting for all the 3 commits in https://blueprints.launchpad.net/horizon/+spec/move-policy-engine to land.","commit_id":"027dd3ddc2ad0679d77dc146e9e1b5549a28375e"},{"author":{"_account_id":12825,"name":"Szymon Wróblewski","email":"szymon.wroblewski@ovhcloud.com","username":"bluex"},"change_message_id":"25a202e55562b32353b70330da634498b192e301","unresolved":false,"context_lines":[{"line_number":684,"context_line":"                return step"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def _gather_steps(self):"},{"line_number":687,"context_line":"        from openstack_dashboard import policy"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        ordered_step_classes \u003d self._order_steps()"},{"line_number":690,"context_line":"        for default_step in self.default_steps:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_6980d78b","line":687,"in_reply_to":"3a961159_5fe68de9","updated":"2015-01-05 11:49:31.000000000","message":"@Timur: Sorry, I didn\u0027t notice it. BTW You could mark your changeset with workflow -1 when it is work in progress.","commit_id":"027dd3ddc2ad0679d77dc146e9e1b5549a28375e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"9cf3de2f7e8716035ef51fc3f8708ae16fcae2ac","unresolved":false,"context_lines":[{"line_number":684,"context_line":"                return step"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def _gather_steps(self):"},{"line_number":687,"context_line":"        from openstack_dashboard import policy"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        ordered_step_classes \u003d self._order_steps()"},{"line_number":690,"context_line":"        for default_step in self.default_steps:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_fd6273ab","line":687,"in_reply_to":"3a961159_6980d78b","updated":"2015-01-07 15:39:44.000000000","message":"Agree, should made that from the beginning. Done","commit_id":"027dd3ddc2ad0679d77dc146e9e1b5549a28375e"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"f7deb4ac47190f20e39986625f81ba2eb68a7124","unresolved":false,"context_lines":[{"line_number":857,"context_line":"        provided_keys \u003d self.contributions | set(self.context_seed.keys())"},{"line_number":858,"context_line":"        if len(self.depends_on - provided_keys):"},{"line_number":859,"context_line":"            raise exceptions.NotAvailable("},{"line_number":860,"context_line":"                _(\"The workflow cannot be rendered because some required step \""},{"line_number":861,"context_line":"                  \"is denied for the current user by the policy rules.\"))"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"    def render(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_b5ae032e","line":860,"updated":"2015-03-10 22:25:00.000000000","message":"The current user has insufficient permission to complete the requested task.","commit_id":"e8d0b89aa14ddb6572a23fa29cd2c0008ecff5f1"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"11be21c554a5dbe7cea5a8319cf6552244aac4bf","unresolved":false,"context_lines":[{"line_number":857,"context_line":"        provided_keys \u003d self.contributions | set(self.context_seed.keys())"},{"line_number":858,"context_line":"        if len(self.depends_on - provided_keys):"},{"line_number":859,"context_line":"            raise exceptions.NotAvailable("},{"line_number":860,"context_line":"                _(\"The workflow cannot be rendered because some required step \""},{"line_number":861,"context_line":"                  \"is denied for the current user by the policy rules.\"))"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"    def render(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_af949de2","line":860,"in_reply_to":"9a80dd14_b5ae032e","updated":"2015-03-24 17:35:56.000000000","message":"Done","commit_id":"e8d0b89aa14ddb6572a23fa29cd2c0008ecff5f1"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"5a391714b0fda1d5a3dac225045997325ddd837c","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            for a policy that requires multiple rule checks:"},{"line_number":130,"context_line":"                rules should look like"},{"line_number":131,"context_line":"                    \"((\"identity\", \"identity:list_users\"),"},{"line_number":132,"context_line":"                      (\"identity\", \"identity:list_roles\"))\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    .. attribute:: help_text"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a710552_36737017","line":132,"updated":"2015-12-15 22:17:27.000000000","message":"what does this do? Is it doing an OR or AND? Please make it clear in the doc","commit_id":"15f1dce06c3ed924cace6972854d31152f41ea6a"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"68ca5ad169d192dd054b1ae50be8913167f1de93","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            for a policy that requires multiple rule checks:"},{"line_number":130,"context_line":"                rules should look like"},{"line_number":131,"context_line":"                    \"((\"identity\", \"identity:list_users\"),"},{"line_number":132,"context_line":"                      (\"identity\", \"identity:list_roles\"))\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    .. attribute:: help_text"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a7b0d38_d4ceedb3","line":132,"in_reply_to":"5a710552_36737017","updated":"2015-12-22 17:29:10.000000000","message":"That\u0027s a copy-paste from https://github.com/openstack/horizon/blob/master/horizon/tables/actions.py#L235\n\nFixed docstring here.","commit_id":"15f1dce06c3ed924cace6972854d31152f41ea6a"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"5a391714b0fda1d5a3dac225045997325ddd837c","unresolved":false,"context_lines":[{"line_number":859,"context_line":"    def verify_integrity(self):"},{"line_number":860,"context_line":"        provided_keys \u003d self.contributions | set(self.context_seed.keys())"},{"line_number":861,"context_line":"        if len(self.depends_on - provided_keys):"},{"line_number":862,"context_line":"            raise exceptions.NotAvailable("},{"line_number":863,"context_line":"                _(\"The current user has insufficient permission to complete \""},{"line_number":864,"context_line":"                  \"the requested task.\"))"},{"line_number":865,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5a710552_76fed839","line":862,"updated":"2015-12-15 22:17:27.000000000","message":"this exception seems odd, why raise a NotAvailable exception? Should be a NotAuthorized error?","commit_id":"15f1dce06c3ed924cace6972854d31152f41ea6a"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"68ca5ad169d192dd054b1ae50be8913167f1de93","unresolved":false,"context_lines":[{"line_number":859,"context_line":"    def verify_integrity(self):"},{"line_number":860,"context_line":"        provided_keys \u003d self.contributions | set(self.context_seed.keys())"},{"line_number":861,"context_line":"        if len(self.depends_on - provided_keys):"},{"line_number":862,"context_line":"            raise exceptions.NotAvailable("},{"line_number":863,"context_line":"                _(\"The current user has insufficient permission to complete \""},{"line_number":864,"context_line":"                  \"the requested task.\"))"},{"line_number":865,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a7b0d38_b459e190","line":862,"in_reply_to":"5a710552_76fed839","updated":"2015-12-22 17:29:10.000000000","message":"I\u0027d prefer not to raise NotAuthorized since now it usually causes user to be logged out (since token is deleted after catching that). Do we have something less powerful than that?","commit_id":"15f1dce06c3ed924cace6972854d31152f41ea6a"}]}
