)]}'
{"openstack_dashboard/test/integration_tests/config.py":[{"author":{"_account_id":12954,"name":"Tomáš Nová?ik","email":"tnovacik@gmail.com","username":"chance"},"change_message_id":"70aa290f92cc6ad581f8d258e186239d3251a28d","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"AvailableServiceGroup \u003d ["},{"line_number":56,"context_line":"    cfg.BoolOpt(\u0027sahara\u0027,"},{"line_number":57,"context_line":"                default\u003dFalse),"},{"line_number":58,"context_line":"    cfg.BoolOpt(\u0027swift\u0027,"},{"line_number":59,"context_line":"                default\u003dFalse)"},{"line_number":60,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_29437b6d","line":57,"updated":"2015-03-17 15:26:18.000000000","message":"both options should be set to true","commit_id":"236f4fcb8313571f74b3833968850257b1770f78"},{"author":{"_account_id":6890,"name":"Martin Pavlásek","email":"mpavlase@redhat.com","username":"mpavlase"},"change_message_id":"6838baff93b125e5a1b3bd483e3738d5070541a0","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"AvailableServiceGroup \u003d ["},{"line_number":56,"context_line":"    cfg.BoolOpt(\u0027sahara\u0027,"},{"line_number":57,"context_line":"                default\u003dFalse),"},{"line_number":58,"context_line":"    cfg.BoolOpt(\u0027swift\u0027,"},{"line_number":59,"context_line":"                default\u003dFalse)"},{"line_number":60,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a80dd14_799ef808","line":57,"in_reply_to":"9a80dd14_29437b6d","updated":"2015-03-18 09:40:04.000000000","message":"For sahara, I do that in separate patch - https://review.openstack.org/#/c/165102/","commit_id":"236f4fcb8313571f74b3833968850257b1770f78"}],"openstack_dashboard/test/integration_tests/horizon.conf":[{"author":{"_account_id":12954,"name":"Tomáš Nová?ik","email":"tnovacik@gmail.com","username":"chance"},"change_message_id":"70aa290f92cc6ad581f8d258e186239d3251a28d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# Whether is Sahara expected to be available (boolean"},{"line_number":52,"context_line":"# value)"},{"line_number":53,"context_line":"sahara\u003dTrue"},{"line_number":54,"context_line":"swift\u003dFalse"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[scenario]"},{"line_number":57,"context_line":"# ssh username for image file (string value)"}],"source_content_type":"text/plain","patch_set":9,"id":"9a80dd14_293a9be7","line":54,"updated":"2015-03-17 15:26:18.000000000","message":"should be true as a result your test was skipped","commit_id":"236f4fcb8313571f74b3833968850257b1770f78"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"31e810eacf0febc40633b20335b230a0d3e2d6e6","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# Whether is Sahara expected to be available (boolean"},{"line_number":52,"context_line":"# value)"},{"line_number":53,"context_line":"sahara\u003dTrue"},{"line_number":54,"context_line":"swift\u003dTrue"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[scenario]"}],"source_content_type":"text/plain","patch_set":10,"id":"9aa53dc9_43a8288d","line":53,"updated":"2015-04-10 05:30:24.000000000","message":"add a space or comment here too for clarity","commit_id":"6ea9cb3a4fb5183debd2ff747de89e58191a42bf"}],"openstack_dashboard/test/integration_tests/pages/project/object_store/containerspage.py":[{"author":{"_account_id":12355,"name":"Vlad Okhrimenko","email":"vokhrimenko@mirantis.com","username":"vokhrimenko"},"change_message_id":"693b9298dd69286627a49c985b91d2624103dd39","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from openstack_dashboard.test.integration_tests.regions import tables"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class ContainersPage(basepage.BaseNavigationPage):"},{"line_number":21,"context_line":"    _containers_table_locator \u003d (by.By.ID, \u0027containers\u0027)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    CONTAINERS_TABLE_NAME_COLUMN_INDEX \u003d 0"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_863b0dd0","line":20,"updated":"2015-03-13 07:46:35.000000000","message":"(nit) sorry --- need blank line:\n class ContainersPage(basepage.BaseNavigationPage):\n \n     _containers_table_locator \u003d (by.By.ID, \u0027containers\u0027)","commit_id":"03b87f74b4b0db76595fb6d5a5edb92bb8b71538"},{"author":{"_account_id":12954,"name":"Tomáš Nová?ik","email":"tnovacik@gmail.com","username":"chance"},"change_message_id":"ef2367ddf308560164922ffa200ca2aad2c47990","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def delete_container(self, name):"},{"line_number":63,"context_line":"        row \u003d self._get_row_with_container_name(name)"},{"line_number":64,"context_line":"        second_act \u003d row.secondary_actions"},{"line_number":65,"context_line":"        second_act[1].click()"},{"line_number":66,"context_line":"        self.confirm_delete_container_form.submit.click()"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9a80dd14_58c1a04c","line":64,"updated":"2015-03-16 11:10:10.000000000","message":"btw row.secondary_actions.delete_container() does not work?","commit_id":"03b87f74b4b0db76595fb6d5a5edb92bb8b71538"}],"openstack_dashboard/test/integration_tests/regions/menus.py":[{"author":{"_account_id":12355,"name":"Vlad Okhrimenko","email":"vokhrimenko@mirantis.com","username":"vokhrimenko"},"change_message_id":"a45ccbe1df3174337b3062f4fadf0aee7339a721","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            self._get_element(*self._menu_first_child_locator).click()"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"class ActiveRowDropDownMenuRegion(DropDownMenuRegion):"},{"line_number":152,"context_line":"    \"\"\"Drop down menu in tables, where rows contains action buttons on the"},{"line_number":153,"context_line":"    rightmost column. Typically list in Project - Images, and many others."},{"line_number":154,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_826ece2d","line":151,"updated":"2015-01-29 13:33:26.000000000","message":"for the right dropdown menu -- is responsible  class DropDownMenuRegion . But need fix locator for it. Please try use my changes https://review.openstack.org/#/c/110919/43/openstack_dashboard/test/integration_tests/regions/menus.py","commit_id":"013188ce9dabac1a9e2aa5ef60073a7bacb1a1f5"},{"author":{"_account_id":12355,"name":"Vlad Okhrimenko","email":"vokhrimenko@mirantis.com","username":"vokhrimenko"},"change_message_id":"d732c96378a7ffb676b941ac54154a1776939e3e","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        self._get_elements(*self._tab_locator)[index].click()"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"class ProjectDropDownRegion(UserDropDownMenuRegion):"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def _project_by_name_locator(self, name):"},{"line_number":203,"context_line":"        return ("}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_4105bf78","line":200,"updated":"2015-02-03 08:46:29.000000000","message":"If you use  this class -- please watch for the patch https://review.openstack.org/#/c/151638/  (or if you don\u0027t use -- you should be remove this class)","commit_id":"c873324db6af8a52f4de4cda1ae98cb35ba7cd59"}],"openstack_dashboard/test/integration_tests/regions/tables.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"b5067b44fa106a1fd884deb258aeadf13eaab18c","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        src_elem \u003d self._get_element(*self._secondary_actions_dropdown_locator)"},{"line_number":96,"context_line":"        dropdown \u003d menus.DropDownMenuRegion(self.driver,"},{"line_number":97,"context_line":"                                            self.conf,"},{"line_number":98,"context_line":"                                            src_elem)"},{"line_number":99,"context_line":"        return dropdown.menu_items"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_9e81c091","line":98,"updated":"2015-03-12 15:35:17.000000000","message":"Minor nitpicking: any reason for this reformatting?","commit_id":"d94dae48015ada9e36ad63fd9df253213f58d079"},{"author":{"_account_id":6890,"name":"Martin Pavlásek","email":"mpavlase@redhat.com","username":"mpavlase"},"change_message_id":"a42d8b7718e78178939bf77edd879a94b3982eda","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        src_elem \u003d self._get_element(*self._secondary_actions_dropdown_locator)"},{"line_number":96,"context_line":"        dropdown \u003d menus.DropDownMenuRegion(self.driver,"},{"line_number":97,"context_line":"                                            self.conf,"},{"line_number":98,"context_line":"                                            src_elem)"},{"line_number":99,"context_line":"        return dropdown.menu_items"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_d207a47f","line":98,"in_reply_to":"9a80dd14_9e81c091","updated":"2015-03-12 15:48:41.000000000","message":"no at all... I will revert this lines.","commit_id":"d94dae48015ada9e36ad63fd9df253213f58d079"}],"openstack_dashboard/test/integration_tests/tests/test_objectstore.py":[{"author":{"_account_id":12355,"name":"Vlad Okhrimenko","email":"vokhrimenko@mirantis.com","username":"vokhrimenko"},"change_message_id":"a45ccbe1df3174337b3062f4fadf0aee7339a721","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        object_page \u003d self.home_pg.go_to_objectstore_containerspage()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        name \u003d str(uuid.uuid4())"},{"line_number":33,"context_line":"        object_page.create_container(name)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        self.assertTrue(object_page.is_container_present(name))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa81d914_bd1e9761","line":32,"updated":"2015-01-29 13:33:26.000000000","message":"example of use https://review.openstack.org/#/c/119501/5/openstack_dashboard/test/integration_tests/tests/test_volumes.py\n\nBut I think this should be something like this https://review.openstack.org/#/c/110919/43/openstack_dashboard/test/integration_tests/tests/test_projects.py  (from https://review.openstack.org/#/c/144206/7/openstack_dashboard/test/integration_tests/helpers.py)","commit_id":"013188ce9dabac1a9e2aa5ef60073a7bacb1a1f5"},{"author":{"_account_id":12355,"name":"Vlad Okhrimenko","email":"vokhrimenko@mirantis.com","username":"vokhrimenko"},"change_message_id":"d732c96378a7ffb676b941ac54154a1776939e3e","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        object_page \u003d self.home_pg.go_to_objectstore_containerspage()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        name \u003d str(uuid.uuid4())"},{"line_number":33,"context_line":"        object_page.create_container(name)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        self.assertTrue(object_page.is_container_present(name))"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_e1d6b3c2","line":32,"updated":"2015-02-03 08:46:29.000000000","message":"`name` should be global (please see comments in your first patch)","commit_id":"c873324db6af8a52f4de4cda1ae98cb35ba7cd59"},{"author":{"_account_id":6890,"name":"Martin Pavlásek","email":"mpavlase@redhat.com","username":"mpavlase"},"change_message_id":"3a1f387e010b07d3c4c1ee717bdb417a7b8a77b2","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"        object_page \u003d self.home_pg.go_to_objectstore_containerspage()"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        name \u003d str(uuid.uuid4())"},{"line_number":33,"context_line":"        object_page.create_container(name)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        self.assertTrue(object_page.is_container_present(name))"}],"source_content_type":"text/x-python","patch_set":4,"id":"da86d52c_b61b1a1a","line":32,"in_reply_to":"da86d52c_e1d6b3c2","updated":"2015-02-03 15:17:51.000000000","message":"I\u0027m sorry, I\u0027ve forgotten to fix this line before.","commit_id":"c873324db6af8a52f4de4cda1ae98cb35ba7cd59"},{"author":{"_account_id":12355,"name":"Vlad Okhrimenko","email":"vokhrimenko@mirantis.com","username":"vokhrimenko"},"change_message_id":"0316269a3b95277a03c6303a48200d468741ccfb","unresolved":false,"context_lines":[{"line_number":24,"context_line":"          - log in as regular user"},{"line_number":25,"context_line":"          - create new container"},{"line_number":26,"context_line":"          - check if was created (present in list)"},{"line_number":27,"context_line":"          - remove the container"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        object_page \u003d self.home_pg.go_to_objectstore_containerspage()"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_19adf29c","line":27,"updated":"2015-02-03 14:13:45.000000000","message":"maybe you missed   \"\"\"   ?","commit_id":"b8f5066c177380e95b87c65293424ddb06260174"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"b5067b44fa106a1fd884deb258aeadf13eaab18c","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        self.assertTrue(object_page.is_container_present(name))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        # TODO(mpavlase): remove whole content (objects inside) before"},{"line_number":37,"context_line":"        # container will be deleted (otherwise deteing will fail)"},{"line_number":38,"context_line":"        object_page.delete_container(name)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_b7c78211","line":36,"updated":"2015-03-12 15:35:17.000000000","message":"This is really not a TODO: or better, it\u0027s a TODO: write another test to cover the deletion of objects. I would just leave a note that this test works as it is because the container is empty.","commit_id":"d94dae48015ada9e36ad63fd9df253213f58d079"},{"author":{"_account_id":6890,"name":"Martin Pavlásek","email":"mpavlase@redhat.com","username":"mpavlase"},"change_message_id":"a42d8b7718e78178939bf77edd879a94b3982eda","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        self.assertTrue(object_page.is_container_present(name))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        # TODO(mpavlase): remove whole content (objects inside) before"},{"line_number":37,"context_line":"        # container will be deleted (otherwise deteing will fail)"},{"line_number":38,"context_line":"        object_page.delete_container(name)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a80dd14_12393c41","line":36,"in_reply_to":"9a80dd14_b7c78211","updated":"2015-03-12 15:48:41.000000000","message":"I agree, I will update it to NOTE from TODO","commit_id":"d94dae48015ada9e36ad63fd9df253213f58d079"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"31e810eacf0febc40633b20335b230a0d3e2d6e6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"@decorators.services_required(\"swift\")"},{"line_number":18,"context_line":"class TestObjectStore(helpers.TestCase):"},{"line_number":19,"context_line":"    \"\"\"Object store (swift service) integration tests"},{"line_number":20,"context_line":"    \"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def test_create_delete_container(self):"},{"line_number":23,"context_line":"        \"\"\"Scenario:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9aa53dc9_c3943844","line":20,"updated":"2015-04-10 05:30:24.000000000","message":"this should move up, there is enough space, the whole comment can be a single line","commit_id":"6ea9cb3a4fb5183debd2ff747de89e58191a42bf"}]}