)]}'
{"horizon/utils/functions.py":[{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"5500ddf7963ea634d31ab88baeebf402a0af19f9","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    return response"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def get_config_value(request, key, default, search_in_settings\u003dTrue):"},{"line_number":66,"context_line":"    \"\"\"Retrieves the value of `key` from configuration in the following order:"},{"line_number":67,"context_line":"    - from the session; if not found there then"},{"line_number":68,"context_line":"    - from cookies; if not found there then"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_703e8fb9","line":65,"updated":"2015-03-15 17:31:25.000000000","message":"how about `get_config_value_from_cookie`","commit_id":"cb20d6afd01c81be4d417e39a7c710ca2d79a7fb"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"5b291b4ce724393aa17917a87a26421b8b1fb0d1","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    return response"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def get_config_value(request, key, default, search_in_settings\u003dTrue):"},{"line_number":66,"context_line":"    \"\"\"Retrieves the value of `key` from configuration in the following order:"},{"line_number":67,"context_line":"    - from the session; if not found there then"},{"line_number":68,"context_line":"    - from cookies; if not found there then"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_f00a7fd0","line":65,"in_reply_to":"9a80dd14_703e8fb9","updated":"2015-03-15 18:02:46.000000000","message":"The function doesn\u0027t just get the value from cookie, it gets it from the session or cookie or the settings file. The docstring (hopefully) makes this clear.","commit_id":"cb20d6afd01c81be4d417e39a7c710ca2d79a7fb"},{"author":{"_account_id":7187,"name":"Janet Yu","email":"jwy@cs.stanford.edu","username":"jwy"},"change_message_id":"7ece12f264203f34a62b3f8d5df94d153ebf9f8a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    \"\"\""},{"line_number":73,"context_line":"    value \u003d request.session.get(key, request.COOKIES.get(key))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    if not value:"},{"line_number":76,"context_line":"        if search_in_settings:"},{"line_number":77,"context_line":"            value \u003d getattr(settings, key, default)"},{"line_number":78,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_b903c60c","line":75,"updated":"2015-08-05 07:05:13.000000000","message":"The empty string could be a valid value. \"value\" will be None if \"key\" is neither in request nor COOKIES. So, instead -\n\nif value is None:","commit_id":"cb20d6afd01c81be4d417e39a7c710ca2d79a7fb"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"f190fe82b3e76a8240e41e7dd7f427536e95de13","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    \"\"\""},{"line_number":73,"context_line":"    value \u003d request.session.get(key, request.COOKIES.get(key))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    if not value:"},{"line_number":76,"context_line":"        if search_in_settings:"},{"line_number":77,"context_line":"            value \u003d getattr(settings, key, default)"},{"line_number":78,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_1d517d62","line":75,"in_reply_to":"1a4dcd0f_b903c60c","updated":"2015-08-05 10:08:29.000000000","message":"Done","commit_id":"cb20d6afd01c81be4d417e39a7c710ca2d79a7fb"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"5500ddf7963ea634d31ab88baeebf402a0af19f9","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"def save_config_value(request, response, key, value):"},{"line_number":91,"context_line":"    \"\"\"Sets value of key `key` to `value` in both session and cookies."},{"line_number":92,"context_line":"    \"\"\""},{"line_number":93,"context_line":"    request.session[key] \u003d value"},{"line_number":94,"context_line":"    response.set_cookie(key, value, expires\u003done_year_from_now())"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_d04f3b69","line":91,"updated":"2015-03-15 17:31:25.000000000","message":"nit, tow `key`?","commit_id":"cb20d6afd01c81be4d417e39a7c710ca2d79a7fb"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"5b291b4ce724393aa17917a87a26421b8b1fb0d1","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"def save_config_value(request, response, key, value):"},{"line_number":91,"context_line":"    \"\"\"Sets value of key `key` to `value` in both session and cookies."},{"line_number":92,"context_line":"    \"\"\""},{"line_number":93,"context_line":"    request.session[key] \u003d value"},{"line_number":94,"context_line":"    response.set_cookie(key, value, expires\u003done_year_from_now())"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a80dd14_50fb4bc0","line":91,"in_reply_to":"9a80dd14_d04f3b69","updated":"2015-03-15 18:02:46.000000000","message":"The second `key` references the variable name.","commit_id":"cb20d6afd01c81be4d417e39a7c710ca2d79a7fb"},{"author":{"_account_id":7187,"name":"Janet Yu","email":"jwy@cs.stanford.edu","username":"jwy"},"change_message_id":"7ece12f264203f34a62b3f8d5df94d153ebf9f8a","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"def get_timezone(request):"},{"line_number":107,"context_line":"    return get_config_value(request, \u0027django_timezone\u0027, \u0027UTC\u0027, False)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def get_language(request):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_d6f221d2","line":107,"updated":"2015-08-05 07:05:13.000000000","message":"Safer to include the keyword arg name, search_in_settings\u003dFalse, in case someone changes the positions of the get_config_value() arguments in the future and misses updating it here.","commit_id":"cb20d6afd01c81be4d417e39a7c710ca2d79a7fb"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"f190fe82b3e76a8240e41e7dd7f427536e95de13","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"def get_timezone(request):"},{"line_number":107,"context_line":"    return get_config_value(request, \u0027django_timezone\u0027, \u0027UTC\u0027, False)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def get_language(request):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_7dc8c122","line":107,"in_reply_to":"1a4dcd0f_d6f221d2","updated":"2015-08-05 10:08:29.000000000","message":"Done","commit_id":"cb20d6afd01c81be4d417e39a7c710ca2d79a7fb"},{"author":{"_account_id":7187,"name":"Janet Yu","email":"jwy@cs.stanford.edu","username":"jwy"},"change_message_id":"7ece12f264203f34a62b3f8d5df94d153ebf9f8a","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def get_language(request):"},{"line_number":111,"context_line":"    return get_config_value(request, settings.LANGUAGE_COOKIE_NAME,"},{"line_number":112,"context_line":"                            request.LANGUAGE_CODE, False)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"def natural_sort(attr):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_16d0891e","line":112,"updated":"2015-08-05 07:05:13.000000000","message":"Same - search_in_settings\u003dFalse","commit_id":"cb20d6afd01c81be4d417e39a7c710ca2d79a7fb"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"f190fe82b3e76a8240e41e7dd7f427536e95de13","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def get_language(request):"},{"line_number":111,"context_line":"    return get_config_value(request, settings.LANGUAGE_COOKIE_NAME,"},{"line_number":112,"context_line":"                            request.LANGUAGE_CODE, False)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"def natural_sort(attr):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_9dcb4d1e","line":112,"in_reply_to":"1a4dcd0f_16d0891e","updated":"2015-08-05 10:08:29.000000000","message":"Done","commit_id":"cb20d6afd01c81be4d417e39a7c710ca2d79a7fb"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"315e0165507edc83f863245e49265d4f9d13d5a3","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    if isinstance(default, int):"},{"line_number":85,"context_line":"        try:"},{"line_number":86,"context_line":"            value \u003d int(value)"},{"line_number":87,"context_line":"        except ValueError:"},{"line_number":88,"context_line":"            value \u003d request.session[key] \u003d int(default)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dae33548_b0956188","line":86,"range":{"start_line":86,"start_character":12,"end_line":86,"end_character":30},"updated":"2016-02-17 07:53:10.000000000","message":"here value is int instance, will it raise ValueError exception?","commit_id":"a2d5c1e9557d50454a12b3e573756e9ad083c7c5"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"90120ca3fb307cddf78da48ab4ac8375f48a782c","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    if isinstance(default, int):"},{"line_number":85,"context_line":"        try:"},{"line_number":86,"context_line":"            value \u003d int(value)"},{"line_number":87,"context_line":"        except ValueError:"},{"line_number":88,"context_line":"            value \u003d request.session[key] \u003d int(default)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"dae33548_4861c1d2","line":86,"range":{"start_line":86,"start_character":12,"end_line":86,"end_character":30},"in_reply_to":"dae33548_b0956188","updated":"2016-02-17 10:30:23.000000000","message":"If value is already an int, it will not raise any exception:\n\n\n [akrivoka@thinkpad ~]$ python\n Python 2.7.10 (default, Sep 24 2015, 17:50:09) \n [GCC 5.1.1 20150618 (Red Hat 5.1.1-4)] on linux2\n Type \"help\", \"copyright\", \"credits\" or \"license\" for more  information. \n \u003e\u003e\u003e int(9)\n 9","commit_id":"a2d5c1e9557d50454a12b3e573756e9ad083c7c5"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"8fd1e3421f01f9724c6aad204e10cffddc4a0782","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        try:"},{"line_number":86,"context_line":"            value \u003d int(value)"},{"line_number":87,"context_line":"        except ValueError:"},{"line_number":88,"context_line":"            value \u003d request.session[key] \u003d int(default)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    return value"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a74a57a_aac4205f","line":88,"updated":"2016-11-24 14:40:52.000000000","message":"nit: default is already an int, you checked that three lines ago","commit_id":"00958cd40df2c90d3d6d1fc889c82e9dca651856"}],"openstack_dashboard/dashboards/settings/user/forms.py":[{"author":{"_account_id":7187,"name":"Janet Yu","email":"jwy@cs.stanford.edu","username":"jwy"},"change_message_id":"7ece12f264203f34a62b3f8d5df94d153ebf9f8a","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            response \u003d functions.save_config_value("},{"line_number":103,"context_line":"                request, response, settings.LANGUAGE_COOKIE_NAME, lang_code)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        functions.save_config_value("},{"line_number":106,"context_line":"            request, response, \u0027django_timezone\u0027,"},{"line_number":107,"context_line":"            pytz.timezone(data[\u0027timezone\u0027]).zone)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_76f78df5","line":105,"updated":"2015-08-05 07:05:13.000000000","message":"Missing a \"response \u003d\" here, but actually, are any of them really needed in this function?","commit_id":"cb20d6afd01c81be4d417e39a7c710ca2d79a7fb"},{"author":{"_account_id":9317,"name":"Ana Krivokapic","email":"akrivoka@redhat.com","username":"akrivoka"},"change_message_id":"f190fe82b3e76a8240e41e7dd7f427536e95de13","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            response \u003d functions.save_config_value("},{"line_number":103,"context_line":"                request, response, settings.LANGUAGE_COOKIE_NAME, lang_code)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        functions.save_config_value("},{"line_number":106,"context_line":"            request, response, \u0027django_timezone\u0027,"},{"line_number":107,"context_line":"            pytz.timezone(data[\u0027timezone\u0027]).zone)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_5dd5c5b6","line":105,"in_reply_to":"1a4dcd0f_76f78df5","updated":"2015-08-05 10:08:29.000000000","message":"Done","commit_id":"cb20d6afd01c81be4d417e39a7c710ca2d79a7fb"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"8fd1e3421f01f9724c6aad204e10cffddc4a0782","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        lang_code \u003d data[\u0027language\u0027]"},{"line_number":107,"context_line":"        if lang_code and translation.check_for_language(lang_code):"},{"line_number":108,"context_line":"            response \u003d functions.save_config_value("},{"line_number":109,"context_line":"                request, response, settings.LANGUAGE_COOKIE_NAME, lang_code)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        response \u003d functions.save_config_value("},{"line_number":112,"context_line":"            request, response, \u0027django_timezone\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"5a74a57a_4ad2ac01","line":109,"updated":"2016-11-24 14:40:52.000000000","message":"nit: it returns the same response object, so assignment not needed","commit_id":"00958cd40df2c90d3d6d1fc889c82e9dca651856"}]}
