)]}'
{"horizon/static/horizon/js/angular/services/hz.api.policy.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"303365c4e49b1bef2e81009014b38311e888c25a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"     * @description"},{"line_number":28,"context_line":"     * Check the passed in policy rule list to determine if the user has"},{"line_number":29,"context_line":"     * permission to perform the actions specified by the rules. The service"},{"line_number":30,"context_line":"     * APIs will ultimately reject actions that aren\u0027t permitted this is used"},{"line_number":31,"context_line":"     * for Role Based Access Control in the UI only. The required parameter"},{"line_number":32,"context_line":"     * should have the following structure:"},{"line_number":33,"context_line":"     *"}],"source_content_type":"text/javascript","patch_set":3,"id":"ba7be1f8_9a285ce3","line":30,"updated":"2015-02-26 19:07:05.000000000","message":"aren\u0027t -\u003e are not","commit_id":"9f7041cdfde23868e7361e138d64043d8ce0396e"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"85bcd447dbf83b1684a2165bbfd4a133df489ea4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"     * @description"},{"line_number":28,"context_line":"     * Check the passed in policy rule list to determine if the user has"},{"line_number":29,"context_line":"     * permission to perform the actions specified by the rules. The service"},{"line_number":30,"context_line":"     * APIs will ultimately reject actions that aren\u0027t permitted this is used"},{"line_number":31,"context_line":"     * for Role Based Access Control in the UI only. The required parameter"},{"line_number":32,"context_line":"     * should have the following structure:"},{"line_number":33,"context_line":"     *"}],"source_content_type":"text/javascript","patch_set":3,"id":"ba7be1f8_0ba0a1a4","line":30,"in_reply_to":"ba7be1f8_9a285ce3","updated":"2015-02-26 23:12:33.000000000","message":"Done","commit_id":"9f7041cdfde23868e7361e138d64043d8ce0396e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"303365c4e49b1bef2e81009014b38311e888c25a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"     * for Role Based Access Control in the UI only. The required parameter"},{"line_number":32,"context_line":"     * should have the following structure:"},{"line_number":33,"context_line":"     *"},{"line_number":34,"context_line":"     * {"},{"line_number":35,"context_line":"     *   \"rules\": ["},{"line_number":36,"context_line":"     *              [ \"compute\", \"compute:get_all\" ],"},{"line_number":37,"context_line":"     *            ],"}],"source_content_type":"text/javascript","patch_set":3,"id":"ba7be1f8_1a070c83","line":34,"updated":"2015-02-26 19:07:05.000000000","message":"strangely indented.","commit_id":"9f7041cdfde23868e7361e138d64043d8ce0396e"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"85bcd447dbf83b1684a2165bbfd4a133df489ea4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"     * for Role Based Access Control in the UI only. The required parameter"},{"line_number":32,"context_line":"     * should have the following structure:"},{"line_number":33,"context_line":"     *"},{"line_number":34,"context_line":"     * {"},{"line_number":35,"context_line":"     *   \"rules\": ["},{"line_number":36,"context_line":"     *              [ \"compute\", \"compute:get_all\" ],"},{"line_number":37,"context_line":"     *            ],"}],"source_content_type":"text/javascript","patch_set":3,"id":"ba7be1f8_710d8a37","line":34,"in_reply_to":"ba7be1f8_1a070c83","updated":"2015-02-26 23:12:33.000000000","message":"not much to go on, indented all by 2 more.","commit_id":"9f7041cdfde23868e7361e138d64043d8ce0396e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"303365c4e49b1bef2e81009014b38311e888c25a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"     *             }"},{"line_number":41,"context_line":"     * }"},{"line_number":42,"context_line":"     *"},{"line_number":43,"context_line":"     * where \"rules\" is a list of rules (0 or greater in length) policy rules"},{"line_number":44,"context_line":"     * which are composed of a"},{"line_number":45,"context_line":"     *    * service name -- maps the policy rule to a service"},{"line_number":46,"context_line":"     *    * rule -- the policy rule to check"}],"source_content_type":"text/javascript","patch_set":3,"id":"ba7be1f8_da7574fa","line":43,"updated":"2015-02-26 19:07:05.000000000","message":"what happens if rules is empty?","commit_id":"9f7041cdfde23868e7361e138d64043d8ce0396e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"303365c4e49b1bef2e81009014b38311e888c25a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"     *    * service name -- maps the policy rule to a service"},{"line_number":46,"context_line":"     *    * rule -- the policy rule to check"},{"line_number":47,"context_line":"     * and \"target\" key and value is optional. In some cases, policy rules"},{"line_number":48,"context_line":"     * require specific details about the object that will be the of the"},{"line_number":49,"context_line":"     * action. If added, it is merely a dictionary of keys and values."},{"line_number":50,"context_line":"     *"},{"line_number":51,"context_line":"     * @example"}],"source_content_type":"text/javascript","patch_set":3,"id":"ba7be1f8_fa4238a9","line":48,"updated":"2015-02-26 19:07:05.000000000","message":"typo: \"will be the of the\"","commit_id":"9f7041cdfde23868e7361e138d64043d8ce0396e"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"85bcd447dbf83b1684a2165bbfd4a133df489ea4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"     *    * service name -- maps the policy rule to a service"},{"line_number":46,"context_line":"     *    * rule -- the policy rule to check"},{"line_number":47,"context_line":"     * and \"target\" key and value is optional. In some cases, policy rules"},{"line_number":48,"context_line":"     * require specific details about the object that will be the of the"},{"line_number":49,"context_line":"     * action. If added, it is merely a dictionary of keys and values."},{"line_number":50,"context_line":"     *"},{"line_number":51,"context_line":"     * @example"}],"source_content_type":"text/javascript","patch_set":3,"id":"ba7be1f8_ce2db7aa","line":48,"in_reply_to":"ba7be1f8_fa4238a9","updated":"2015-02-26 23:12:33.000000000","message":"changed","commit_id":"9f7041cdfde23868e7361e138d64043d8ce0396e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"303365c4e49b1bef2e81009014b38311e888c25a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"     * The following is an example response:"},{"line_number":53,"context_line":"     * {"},{"line_number":54,"context_line":"     *   \"allowed\": true"},{"line_number":55,"context_line":"     * }"},{"line_number":56,"context_line":"     */"},{"line_number":57,"context_line":"    this.check \u003d function (policy_rules) {"},{"line_number":58,"context_line":"      return apiService.post(\u0027/api/policy/\u0027, policy_rules)"}],"source_content_type":"text/javascript","patch_set":3,"id":"ba7be1f8_7a8568cd","line":55,"updated":"2015-02-26 19:07:05.000000000","message":"what happens when/if policy is rejected?","commit_id":"9f7041cdfde23868e7361e138d64043d8ce0396e"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"85bcd447dbf83b1684a2165bbfd4a133df489ea4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"     * The following is an example response:"},{"line_number":53,"context_line":"     * {"},{"line_number":54,"context_line":"     *   \"allowed\": true"},{"line_number":55,"context_line":"     * }"},{"line_number":56,"context_line":"     */"},{"line_number":57,"context_line":"    this.check \u003d function (policy_rules) {"},{"line_number":58,"context_line":"      return apiService.post(\u0027/api/policy/\u0027, policy_rules)"}],"source_content_type":"text/javascript","patch_set":3,"id":"ba7be1f8_3103120f","line":55,"in_reply_to":"ba7be1f8_7a8568cd","updated":"2015-02-26 23:12:33.000000000","message":"updated text.","commit_id":"9f7041cdfde23868e7361e138d64043d8ce0396e"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"9e2ba10eab8bf2eebd9ed67da94dbe52d1e5d234","unresolved":false,"context_lines":[{"line_number":27,"context_line":"     * @description"},{"line_number":28,"context_line":"     * Check the passed in policy rule list to determine if the user has"},{"line_number":29,"context_line":"     * permission to perform the actions specified by the rules. The service"},{"line_number":30,"context_line":"     * APIs will ultimately reject actions that are not permitted this is used"},{"line_number":31,"context_line":"     * for Role Based Access Control in the UI only. The required parameter"},{"line_number":32,"context_line":"     * should have the following structure:"},{"line_number":33,"context_line":"     *"}],"source_content_type":"text/javascript","patch_set":4,"id":"ba7be1f8_2e8c817f","line":30,"updated":"2015-02-27 05:55:23.000000000","message":"uber-nit: Actually would read easier if there was a new sentence stopping at permitted and starting at this.\n\n..are not permitted. This...","commit_id":"b4d8cdda8d77b3813e5504098e8ba906562c2234"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"65868fc724c8ae8abe65565120fb8c3ab007fb3b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"     * @description"},{"line_number":28,"context_line":"     * Check the passed in policy rule list to determine if the user has"},{"line_number":29,"context_line":"     * permission to perform the actions specified by the rules. The service"},{"line_number":30,"context_line":"     * APIs will ultimately reject actions that are not permitted this is used"},{"line_number":31,"context_line":"     * for Role Based Access Control in the UI only. The required parameter"},{"line_number":32,"context_line":"     * should have the following structure:"},{"line_number":33,"context_line":"     *"}],"source_content_type":"text/javascript","patch_set":4,"id":"ba7be1f8_4c019638","line":30,"in_reply_to":"ba7be1f8_2e8c817f","updated":"2015-02-27 21:49:40.000000000","message":"Done","commit_id":"b4d8cdda8d77b3813e5504098e8ba906562c2234"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"9e2ba10eab8bf2eebd9ed67da94dbe52d1e5d234","unresolved":false,"context_lines":[{"line_number":63,"context_line":"      return apiService.post(\u0027/api/policy/\u0027, policy_rules)"},{"line_number":64,"context_line":"        .error(function() {"},{"line_number":65,"context_line":"          horizon.alert(\u0027warning\u0027, gettext(\u0027Policy check failed.\u0027));"},{"line_number":66,"context_line":"        });"},{"line_number":67,"context_line":"    };"},{"line_number":68,"context_line":"  }"},{"line_number":69,"context_line":""}],"source_content_type":"text/javascript","patch_set":4,"id":"ba7be1f8_eeaa69d1","line":66,"updated":"2015-02-27 05:55:23.000000000","message":"Maybe a noob policy question, but does it make sense to always post a warning that a policy check failed? I guess the only difference between this and most Horizon warning is that in this case \"failed\" sounds very similar to \"No you aren\u0027t allowed\".  Not necessarily that there was an error.","commit_id":"b4d8cdda8d77b3813e5504098e8ba906562c2234"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"65868fc724c8ae8abe65565120fb8c3ab007fb3b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"      return apiService.post(\u0027/api/policy/\u0027, policy_rules)"},{"line_number":64,"context_line":"        .error(function() {"},{"line_number":65,"context_line":"          horizon.alert(\u0027warning\u0027, gettext(\u0027Policy check failed.\u0027));"},{"line_number":66,"context_line":"        });"},{"line_number":67,"context_line":"    };"},{"line_number":68,"context_line":"  }"},{"line_number":69,"context_line":""}],"source_content_type":"text/javascript","patch_set":4,"id":"ba7be1f8_0ec3288b","line":66,"in_reply_to":"ba7be1f8_eeaa69d1","updated":"2015-02-27 21:49:40.000000000","message":"I was on the fence here. I left the warning as a way to indicate that you\u0027ve made the policy call incorrectly or you have connectivity issues. It\u0027s of no use to the end user, other than to say you may have connectivity issues.  \n\nMy biggest fear is that developers won\u0027t get an error when coding.","commit_id":"b4d8cdda8d77b3813e5504098e8ba906562c2234"}],"openstack_dashboard/api/rest/policy.py":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"303365c4e49b1bef2e81009014b38311e888c25a","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        policy_target \u003d request.DATA.get(\u0027target\u0027) or {}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if rules:"},{"line_number":46,"context_line":"            result \u003d policy.check(rules, request, policy_target)"},{"line_number":47,"context_line":"        else:"},{"line_number":48,"context_line":"            # no check being made, so success"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_4857ffca","line":45,"updated":"2015-02-26 19:07:05.000000000","message":"should we still check rules if target is empty?","commit_id":"9f7041cdfde23868e7361e138d64043d8ce0396e"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"85bcd447dbf83b1684a2165bbfd4a133df489ea4","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        policy_target \u003d request.DATA.get(\u0027target\u0027) or {}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if rules:"},{"line_number":46,"context_line":"            result \u003d policy.check(rules, request, policy_target)"},{"line_number":47,"context_line":"        else:"},{"line_number":48,"context_line":"            # no check being made, so success"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_ab6dd59b","line":45,"in_reply_to":"ba7be1f8_4857ffca","updated":"2015-02-26 23:12:33.000000000","message":"yes, the target is empty most of the time. Usually just a role check, some rules do require a target though.","commit_id":"9f7041cdfde23868e7361e138d64043d8ce0396e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"303365c4e49b1bef2e81009014b38311e888c25a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        policy_target \u003d request.DATA.get(\u0027target\u0027) or {}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if rules:"},{"line_number":46,"context_line":"            result \u003d policy.check(rules, request, policy_target)"},{"line_number":47,"context_line":"        else:"},{"line_number":48,"context_line":"            # no check being made, so success"},{"line_number":49,"context_line":"            result \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_c8e5af39","line":46,"updated":"2015-02-26 19:07:05.000000000","message":"Is there a chance that some error will happen while checking? Should this be enclose in try/catch?","commit_id":"9f7041cdfde23868e7361e138d64043d8ce0396e"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"85bcd447dbf83b1684a2165bbfd4a133df489ea4","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        policy_target \u003d request.DATA.get(\u0027target\u0027) or {}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        if rules:"},{"line_number":46,"context_line":"            result \u003d policy.check(rules, request, policy_target)"},{"line_number":47,"context_line":"        else:"},{"line_number":48,"context_line":"            # no check being made, so success"},{"line_number":49,"context_line":"            result \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_eb50add6","line":46,"in_reply_to":"ba7be1f8_c8e5af39","updated":"2015-02-26 23:12:33.000000000","message":"no error will result, in actuality we could just pass through to policy.check, will return True anyway.\n\nremoving the extra logic","commit_id":"9f7041cdfde23868e7361e138d64043d8ce0396e"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"303365c4e49b1bef2e81009014b38311e888c25a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if rules:"},{"line_number":46,"context_line":"            result \u003d policy.check(rules, request, policy_target)"},{"line_number":47,"context_line":"        else:"},{"line_number":48,"context_line":"            # no check being made, so success"},{"line_number":49,"context_line":"            result \u003d True"},{"line_number":50,"context_line":"        return rest_utils.JSONResponse({\"allowed\": result})"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_48f29f07","line":48,"updated":"2015-02-26 19:07:05.000000000","message":"If I\u0027m not checking for a policy, I normally wouldn\u0027t call the policy engine. So following that logic, for safety reasons, should this be False by default?","commit_id":"9f7041cdfde23868e7361e138d64043d8ce0396e"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"85bcd447dbf83b1684a2165bbfd4a133df489ea4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if rules:"},{"line_number":46,"context_line":"            result \u003d policy.check(rules, request, policy_target)"},{"line_number":47,"context_line":"        else:"},{"line_number":48,"context_line":"            # no check being made, so success"},{"line_number":49,"context_line":"            result \u003d True"},{"line_number":50,"context_line":"        return rest_utils.JSONResponse({\"allowed\": result})"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7be1f8_0be8a115","line":48,"in_reply_to":"ba7be1f8_48f29f07","updated":"2015-02-26 23:12:33.000000000","message":"with policy I always default to true, because in reality the API will make the final decision, so I prefer to err on the side of permissibility.","commit_id":"9f7041cdfde23868e7361e138d64043d8ce0396e"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"9e2ba10eab8bf2eebd9ed67da94dbe52d1e5d234","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        application/json object. The policy target, if specified will also be"},{"line_number":34,"context_line":"        passed in to the policy check method as well."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        The action returns the an object with one key: allowed and the value"},{"line_number":37,"context_line":"        is the result of the policy check, True or False."},{"line_number":38,"context_line":"        \u0027\u0027\u0027"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_0ebdfd02","line":36,"updated":"2015-02-27 05:55:23.000000000","message":"nit: \"the an\"  \n\nDrop \"the\"","commit_id":"b4d8cdda8d77b3813e5504098e8ba906562c2234"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"65868fc724c8ae8abe65565120fb8c3ab007fb3b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        application/json object. The policy target, if specified will also be"},{"line_number":34,"context_line":"        passed in to the policy check method as well."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        The action returns the an object with one key: allowed and the value"},{"line_number":37,"context_line":"        is the result of the policy check, True or False."},{"line_number":38,"context_line":"        \u0027\u0027\u0027"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_ac8f72cb","line":36,"in_reply_to":"ba7be1f8_0ebdfd02","updated":"2015-02-27 21:49:40.000000000","message":"Done","commit_id":"b4d8cdda8d77b3813e5504098e8ba906562c2234"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"9e2ba10eab8bf2eebd9ed67da94dbe52d1e5d234","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        policy_target \u003d request.DATA.get(\u0027target\u0027) or {}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        result \u003d policy.check(rules, request, policy_target)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        return rest_utils.JSONResponse({\"allowed\": result})"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_0e1fbdb8","line":45,"updated":"2015-02-27 05:55:23.000000000","message":"Even if I send in \n\n{\n  \"foo\": \"bar\"\n}\n\nI get allowed true.  I saw your comments on defaulting to permissive, but maybe this should respond with a bad request if there isn\u0027t even a rules element in the request object.  Just seems kind of easy to mess up the format and always get true response.  Thoughts?","commit_id":"b4d8cdda8d77b3813e5504098e8ba906562c2234"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"65868fc724c8ae8abe65565120fb8c3ab007fb3b","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        policy_target \u003d request.DATA.get(\u0027target\u0027) or {}"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        result \u003d policy.check(rules, request, policy_target)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        return rest_utils.JSONResponse({\"allowed\": result})"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_6cac9a36","line":45,"in_reply_to":"ba7be1f8_0e1fbdb8","updated":"2015-02-27 21:49:40.000000000","message":"you\u0027re right, added some input validation","commit_id":"b4d8cdda8d77b3813e5504098e8ba906562c2234"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"9e2ba10eab8bf2eebd9ed67da94dbe52d1e5d234","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        result \u003d policy.check(rules, request, policy_target)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        return rest_utils.JSONResponse({\"allowed\": result})"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_2e7d61b2","line":47,"updated":"2015-02-27 05:55:23.000000000","message":"You don\u0027t need to wrap in JSONResponse.  The decorator handles that for you.  I tried:\n\nreturn {\"allowed\": result}\n\nAnd it worked.","commit_id":"b4d8cdda8d77b3813e5504098e8ba906562c2234"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"65868fc724c8ae8abe65565120fb8c3ab007fb3b","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        result \u003d policy.check(rules, request, policy_target)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        return rest_utils.JSONResponse({\"allowed\": result})"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba7be1f8_8ca9ce26","line":47,"in_reply_to":"ba7be1f8_2e7d61b2","updated":"2015-02-27 21:49:40.000000000","message":"Done","commit_id":"b4d8cdda8d77b3813e5504098e8ba906562c2234"}]}
