)]}'
{"horizon/static/angular/action-button/action-button.html":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"8a0175b9dd50e1ec574a31a2ca4948ac11190468","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\"action-button\" ng-if\u003d\"::actions\""},{"line_number":2,"context_line":"  ng-class\u003d\"::{ \u0027btn-group\u0027: model.multiAction }\"\u003e"},{"line_number":3,"context_line":"  \u003c!-- Primary button --\u003e"},{"line_number":4,"context_line":"  \u003ca role\u003d\"button\" tabindex\u003d\"0\" class\u003d\"btn btn-sm btn-default\""}],"source_content_type":"text/html","patch_set":10,"id":"9a80dd14_76c5555a","line":1,"updated":"2015-03-05 00:26:07.000000000","message":"Right now, the split button is getting pick up by bootstrap.js. But since we\u0027re starting to use Angular-bootstrap, it might make sense for us to take full advantage of the framework. In addition, sticking with one framework ensures that we don\u0027t run into problems with bootstrap and angular-bootstrap conflicting down the road. http://angular-ui.github.io/bootstrap/#/dropdown","commit_id":"d081b145f219ee255dcabb9d9a0c9ac2af859a9a"},{"author":{"_account_id":13785,"name":"Kelly Domico","email":"kelly.domico@hp.com","username":"kdomico"},"change_message_id":"4a8eaa0a0fae61200af78e6d42f9309cb3344777","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\"action-button\" ng-if\u003d\"::actions\""},{"line_number":2,"context_line":"  ng-class\u003d\"::{ \u0027btn-group\u0027: model.multiAction }\"\u003e"},{"line_number":3,"context_line":"  \u003c!-- Primary button --\u003e"},{"line_number":4,"context_line":"  \u003ca role\u003d\"button\" tabindex\u003d\"0\" class\u003d\"btn btn-sm btn-default\""}],"source_content_type":"text/html","patch_set":10,"id":"9a80dd14_dbbb850c","line":1,"in_reply_to":"9a80dd14_76c5555a","updated":"2015-03-05 02:29:53.000000000","message":"Dang. There seems to be a bug and conflict with the usage of the \u0027dropdown-toggle\u0027 class in the split button. The fix was done in version 0.12 though (https://github.com/angular-ui/bootstrap/issues/2914).","commit_id":"d081b145f219ee255dcabb9d9a0c9ac2af859a9a"},{"author":{"_account_id":13785,"name":"Kelly Domico","email":"kelly.domico@hp.com","username":"kdomico"},"change_message_id":"9f12d678f1755be0dff48691e5b76ed7f4751c0b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\"action-button\" ng-if\u003d\"::actions\""},{"line_number":2,"context_line":"  ng-class\u003d\"::{ \u0027btn-group\u0027: model.multiAction }\"\u003e"},{"line_number":3,"context_line":"  \u003c!-- Primary button --\u003e"},{"line_number":4,"context_line":"  \u003ca role\u003d\"button\" tabindex\u003d\"0\" class\u003d\"btn btn-sm btn-default\""}],"source_content_type":"text/html","patch_set":10,"id":"9a80dd14_d120cb9d","line":1,"in_reply_to":"9a80dd14_76c5555a","updated":"2015-03-05 00:38:12.000000000","message":"Will look into it. I will also add the batch action buttons next to the search input in the header for basic table.","commit_id":"d081b145f219ee255dcabb9d9a0c9ac2af859a9a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7631efe42e6f3d2be4a820550b7ade8351436580","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\"action-button\" ng-if\u003d\"::actions\""},{"line_number":2,"context_line":"  ng-class\u003d\"::{ \u0027btn-group\u0027: model.multiAction }\"\u003e"},{"line_number":3,"context_line":"  \u003c!-- Primary button --\u003e"},{"line_number":4,"context_line":"  \u003ca role\u003d\"button\" tabindex\u003d\"0\" class\u003d\"btn btn-sm btn-default\""}],"source_content_type":"text/html","patch_set":12,"id":"9a80dd14_cd05547b","line":1,"updated":"2015-03-05 22:45:15.000000000","message":"I think we should not one-time-bind here as some tables (eg. nova instances) will very likely have rows with actions that change while the table is displayed (instances being started up, shut down, etc.)","commit_id":"446e07db4052c193c3d6dfde6644f2d6b9608c9f"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"ce4c1c077c86da345f0d17a18d03963ca2dcfa6c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\"action-button\" ng-if\u003d\"actions\""},{"line_number":2,"context_line":"  ng-class\u003d\"{ \u0027btn-group\u0027: model.multiAction }\"\u003e"},{"line_number":3,"context_line":"  \u003c!-- Primary button --\u003e"},{"line_number":4,"context_line":"  \u003ca role\u003d\"button\" tabindex\u003d\"0\" class\u003d\"btn btn-sm btn-default\""}],"source_content_type":"text/html","patch_set":15,"id":"9a80dd14_72e177fd","line":1,"updated":"2015-03-06 18:41:23.000000000","message":"Kelly, I\u0027d still like to see us use angular-bootstrap for this. There is a workaround for the bug. The simple solution is to not include data-toggle\u003d\"dropdown\" attribute. Removing this attribute will prevent bootstrap.js from picking it up, while angular-bootstrap will continue to see it as a directive (remember that directives can be detected via classes as well).\n\nOne other comment I had was to avoid using \u003ca\u003e but instead \u003cbutton\u003e. \u003ca\u003e is intended for hyperlinks.","commit_id":"ed8138d577398d93932636d0868dc0ac92e46552"},{"author":{"_account_id":13785,"name":"Kelly Domico","email":"kelly.domico@hp.com","username":"kdomico"},"change_message_id":"6de3357e7b08bc89d89fec7522ce53723c34c866","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\"action-button\" ng-if\u003d\"actions\""},{"line_number":2,"context_line":"  ng-class\u003d\"{ \u0027btn-group\u0027: model.multiAction }\"\u003e"},{"line_number":3,"context_line":"  \u003c!-- Primary button --\u003e"},{"line_number":4,"context_line":"  \u003ca role\u003d\"button\" tabindex\u003d\"0\" class\u003d\"btn btn-sm btn-default\""}],"source_content_type":"text/html","patch_set":15,"id":"9a80dd14_9c019a3a","line":1,"in_reply_to":"9a80dd14_72e177fd","updated":"2015-03-06 20:55:50.000000000","message":"Just a note here: \u003ca\u003e is used so that tooltip disappears on next click and for consistent cross-browser experience.","commit_id":"ed8138d577398d93932636d0868dc0ac92e46552"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"ce4c1c077c86da345f0d17a18d03963ca2dcfa6c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  ng-class\u003d\"{ \u0027btn-group\u0027: model.multiAction }\"\u003e"},{"line_number":3,"context_line":"  \u003c!-- Primary button --\u003e"},{"line_number":4,"context_line":"  \u003ca role\u003d\"button\" tabindex\u003d\"0\" class\u003d\"btn btn-sm btn-default\""},{"line_number":5,"context_line":"    ng-class\u003d\"{ \u0027btn-disabled\u0027: actionItem.disabled }\""},{"line_number":6,"context_line":"    ng-click\u003d\"actionItem.disabled || actions[0].func(actionItem)\""},{"line_number":7,"context_line":"    warning-tooltip\u003d\"model.tooltipModel\""},{"line_number":8,"context_line":"    warning-disabled\u003d\"model.multiAction || !actionItem.disabled\"\u003e"}],"source_content_type":"text/html","patch_set":15,"id":"9a80dd14_92fb4bc0","line":5,"updated":"2015-03-06 18:41:23.000000000","message":"btnClasses is an optional field and can be applied to any action. Shouldn\u0027t it be included here as well?","commit_id":"ed8138d577398d93932636d0868dc0ac92e46552"}],"horizon/static/angular/action-button/action-button.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"8a0175b9dd50e1ec574a31a2ca4948ac11190468","unresolved":false,"context_lines":[{"line_number":49,"context_line":"   * ```"},{"line_number":50,"context_line":"   *"},{"line_number":51,"context_line":"   * @restrict E"},{"line_number":52,"context_line":"   * @scope"},{"line_number":53,"context_line":"   *"},{"line_number":54,"context_line":"   * @example"},{"line_number":55,"context_line":"   * ```"}],"source_content_type":"text/javascript","patch_set":10,"id":"9a80dd14_3b5bc655","line":52,"updated":"2015-03-05 00:26:07.000000000","message":"what are actionItem and btnConfig use for?","commit_id":"d081b145f219ee255dcabb9d9a0c9ac2af859a9a"},{"author":{"_account_id":13785,"name":"Kelly Domico","email":"kelly.domico@hp.com","username":"kdomico"},"change_message_id":"9f12d678f1755be0dff48691e5b76ed7f4751c0b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"   * ```"},{"line_number":50,"context_line":"   *"},{"line_number":51,"context_line":"   * @restrict E"},{"line_number":52,"context_line":"   * @scope"},{"line_number":53,"context_line":"   *"},{"line_number":54,"context_line":"   * @example"},{"line_number":55,"context_line":"   * ```"}],"source_content_type":"text/javascript","patch_set":10,"id":"9a80dd14_912653b9","line":52,"in_reply_to":"9a80dd14_3b5bc655","updated":"2015-03-05 00:38:12.000000000","message":"actionItem is the object passed to the function. So, in a table, it would be the row data.\n\nButton config right now just has the warning icon class. Nothing otherwise.","commit_id":"d081b145f219ee255dcabb9d9a0c9ac2af859a9a"},{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"484b2aadf13b79d40c3e8c12ca9cf06f90ae3431","unresolved":false,"context_lines":[{"line_number":8,"context_line":"   *"},{"line_number":9,"context_line":"   * # hz.widget.action-button"},{"line_number":10,"context_line":"   *"},{"line_number":11,"context_line":"   * The `hz.widget.action` provides support for action buttons."},{"line_number":12,"context_line":"   * For a multiple actions, a button dropdown will be rendered."},{"line_number":13,"context_line":"   * Bootstrap\u0027s buttons and button dropdown styling is used."},{"line_number":14,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":14,"id":"9a80dd14_96d416be","line":11,"updated":"2015-03-07 05:31:35.000000000","message":"`hz.widget.action-button`","commit_id":"c7252ee9c6a3b19da0efe96c0aa55bcecd386630"},{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"484b2aadf13b79d40c3e8c12ca9cf06f90ae3431","unresolved":false,"context_lines":[{"line_number":48,"context_line":"   *"},{"line_number":49,"context_line":"   * Data model and custom tooltip model:"},{"line_number":50,"context_line":"   * ```"},{"line_number":51,"context_line":"   * var tableActions \u003d ["},{"line_number":52,"context_line":"   *   { label: \u0027Edit\u0027, func: myEditFunc, iconClass: \u0027fa-pencil\u0027 },"},{"line_number":53,"context_line":"   *   { label: \u0027Delete\u0027, func: myDeleteFunc, iconClass: \u0027fa-times\u0027 }"},{"line_number":54,"context_line":"   * ];"}],"source_content_type":"text/javascript","patch_set":14,"id":"9a80dd14_5338f0ee","line":51,"updated":"2015-03-07 05:31:35.000000000","message":"Is it $scope.tableActions \u003d [...]; ?","commit_id":"c7252ee9c6a3b19da0efe96c0aa55bcecd386630"},{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"484b2aadf13b79d40c3e8c12ca9cf06f90ae3431","unresolved":false,"context_lines":[{"line_number":57,"context_line":"   *   - iconClass: if provided, will be shown on the left of button"},{"line_number":58,"context_line":"   *   - btnClasses: if provided, will be added to button class list"},{"line_number":59,"context_line":"   *"},{"line_number":60,"context_line":"   * var tooltipModel \u003d {"},{"line_number":61,"context_line":"   *   data: {"},{"line_number":62,"context_line":"   *     message: \u0027My custom message\u0027,"},{"line_number":63,"context_line":"   *     anotherMessage: \u0027Another message\u0027,"}],"source_content_type":"text/javascript","patch_set":14,"id":"9a80dd14_9315084b","line":60,"updated":"2015-03-07 05:31:35.000000000","message":"And $scope.tooltipModel \u003d {...}; ?","commit_id":"c7252ee9c6a3b19da0efe96c0aa55bcecd386630"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"ce4c1c077c86da345f0d17a18d03963ca2dcfa6c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"   * @name hz.widget.action-button"},{"line_number":7,"context_line":"   * @description"},{"line_number":8,"context_line":"   *"},{"line_number":9,"context_line":"   * # hz.widget.action-button"},{"line_number":10,"context_line":"   *"},{"line_number":11,"context_line":"   * The `hz.widget.action` provides support for action buttons."},{"line_number":12,"context_line":"   * For a multiple actions, a button dropdown will be rendered."}],"source_content_type":"text/javascript","patch_set":15,"id":"9a80dd14_dec94f27","line":9,"updated":"2015-03-06 18:41:23.000000000","message":"action-button indicates a widget that does something to a single button. what this widget really provides is the ability to list actions in the form of a button or dropdown depending on length. would action-list or something else be more descriptive?","commit_id":"ed8138d577398d93932636d0868dc0ac92e46552"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"ce4c1c077c86da345f0d17a18d03963ca2dcfa6c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"   * @description"},{"line_number":40,"context_line":"   * The `actionButton` directive provides action buttons with"},{"line_number":41,"context_line":"   * configurable button icons and function called when clicked."},{"line_number":42,"context_line":"   * For each button, provide a label and function. A tooltip"},{"line_number":43,"context_line":"   * configuration can also be specified to show warning tooltips"},{"line_number":44,"context_line":"   * when button is clicked. By default, the \u0027warningMessage\u0027"},{"line_number":45,"context_line":"   * value of the actionItem is shown in the tooltip. If a template"}],"source_content_type":"text/javascript","patch_set":15,"id":"9a80dd14_fec373ea","line":42,"updated":"2015-03-06 18:41:23.000000000","message":"A tooltip... should start on new paragraph for readability.","commit_id":"ed8138d577398d93932636d0868dc0ac92e46552"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"ce4c1c077c86da345f0d17a18d03963ca2dcfa6c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"   * Data model and custom tooltip model:"},{"line_number":50,"context_line":"   * ```"},{"line_number":51,"context_line":"   * var tableActions \u003d ["},{"line_number":52,"context_line":"   *   { label: \u0027Edit\u0027, func: myEditFunc, iconClass: \u0027fa-pencil\u0027 },"},{"line_number":53,"context_line":"   *   { label: \u0027Delete\u0027, func: myDeleteFunc, iconClass: \u0027fa-times\u0027 }"},{"line_number":54,"context_line":"   * ];"},{"line_number":55,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":15,"id":"9a80dd14_5e047f49","line":52,"updated":"2015-03-06 18:41:23.000000000","message":"instead of func, would callback be more descriptive? can we also add btnClasses attribute for completeness?","commit_id":"ed8138d577398d93932636d0868dc0ac92e46552"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"ce4c1c077c86da345f0d17a18d03963ca2dcfa6c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"   *"},{"line_number":56,"context_line":"   * Optional attributes:"},{"line_number":57,"context_line":"   *   - iconClass: if provided, will be shown on the left of button"},{"line_number":58,"context_line":"   *   - btnClasses: if provided, will be added to button class list"},{"line_number":59,"context_line":"   *"},{"line_number":60,"context_line":"   * var tooltipModel \u003d {"},{"line_number":61,"context_line":"   *   data: {"}],"source_content_type":"text/javascript","patch_set":15,"id":"9a80dd14_755b212e","line":58,"updated":"2015-03-06 18:41:23.000000000","message":"Your clever use of transclude in transfer table for bind-scope has lead me to think of something. Because we have wrapped this as a directive, there is no easy way to customize each item unless we pass in classes and styles via object attributes. A more descriptive way to do this would be something like the following:\n\n\u003caction-list\u003e\n  \u003caction callback\u003d\"somefunction\" class\u003d\u0027\u0027\"\u003e\n    \u003cspan class\u003d\"fa-pencil\"\u003e\u003c/span\u003eEdit\n  \u003c/action\u003e\n  \u003caction\u003e....\u003c/action\u003e\n  \u003caction\u003e....\u003c/action\u003e\n  \u003caction\u003e....\u003c/action\u003e\n\u003c/action-list\u003e\n\nTo me, the action-button directive is really a smart directive that display your action items in a button or a dropdown depending on length. With that in mind, let me try to convince you why this might be better:\n\nThe action item can be customize to your heart\u0027s content. It is not restrictive to what you define in action-button.html. Any number of new attributes or classes can be added without adding additional logic into the directive. \n\nExample: \u003caction my-custom-attr\u003d\"awesome\"\u003e\u003c/action\u003e\nThere is no easy way to do that if we use the current approach. We would have to add additional logic into the template and controller if we want to embed custom attrs.\n\nThis architecture is more reminiscent of how smart-table works. Smart-table doesn\u0027t dictate your HTML, it only modifies it. The current architecture reminds me a bit o Django classes. It simplifies certain things, but becomes restrictive in other aspect.\n\nI understand this is a bit of change but I don\u0027t think the code change will be as significant as you may think.","commit_id":"ed8138d577398d93932636d0868dc0ac92e46552"}],"horizon/static/angular/action-button/action-button.scss":[{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"484b2aadf13b79d40c3e8c12ca9cf06f90ae3431","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      }"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"      \u0026.dropdown-toggle {"},{"line_number":26,"context_line":"        pointer-events: none;"},{"line_number":27,"context_line":"      }"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"      .invalid {"}],"source_content_type":"text/x-scss","patch_set":14,"id":"9a80dd14_f64632bf","line":26,"updated":"2015-03-07 05:31:35.000000000","message":"pointer-events: none; -- this is CSS4, do we really need it?\n\n(Not sure IE10- supports it).","commit_id":"c7252ee9c6a3b19da0efe96c0aa55bcecd386630"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"b74ff4a82e47dc19c73c5f3cc946ace751de1d0a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      }"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"      \u0026.dropdown-toggle {"},{"line_number":26,"context_line":"        pointer-events: none;"},{"line_number":27,"context_line":"      }"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"      .invalid {"}],"source_content_type":"text/x-scss","patch_set":14,"id":"9a80dd14_1d9108f1","line":26,"in_reply_to":"9a80dd14_f64632bf","updated":"2015-03-10 05:47:41.000000000","message":"Doesn\u0027t look like it is supported.\nhttp://caniuse.com/#feat\u003dpointer-events","commit_id":"c7252ee9c6a3b19da0efe96c0aa55bcecd386630"}],"horizon/static/angular/action-button/warning-tooltip.js":[{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"484b2aadf13b79d40c3e8c12ca9cf06f90ae3431","unresolved":false,"context_lines":[{"line_number":10,"context_line":"   * @param {string} defaultMessage Default warning tooltip message"},{"line_number":11,"context_line":"   */"},{"line_number":12,"context_line":"  .constant(\u0027tooltipConfig\u0027, {"},{"line_number":13,"context_line":"    defaultTemplate: \u0027\u003cdiv\u003e{$ message $}\u003c/div\u003e\u0027,"},{"line_number":14,"context_line":"    defaultMessage: {"},{"line_number":15,"context_line":"      message: gettext(\u0027The action cannot be performed. The contents \u0027 +"},{"line_number":16,"context_line":"        \u0027of this row have errors or are missing information.\u0027)"}],"source_content_type":"text/javascript","patch_set":14,"id":"9a80dd14_36f0ca66","line":13,"updated":"2015-03-07 05:31:35.000000000","message":"is it possible to use one time binding here?","commit_id":"c7252ee9c6a3b19da0efe96c0aa55bcecd386630"},{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"484b2aadf13b79d40c3e8c12ca9cf06f90ae3431","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  .constant(\u0027tooltipConfig\u0027, {"},{"line_number":13,"context_line":"    defaultTemplate: \u0027\u003cdiv\u003e{$ message $}\u003c/div\u003e\u0027,"},{"line_number":14,"context_line":"    defaultMessage: {"},{"line_number":15,"context_line":"      message: gettext(\u0027The action cannot be performed. The contents \u0027 +"},{"line_number":16,"context_line":"        \u0027of this row have errors or are missing information.\u0027)"},{"line_number":17,"context_line":"    }"},{"line_number":18,"context_line":"  })"}],"source_content_type":"text/javascript","patch_set":14,"id":"9a80dd14_96a25649","line":15,"updated":"2015-03-07 05:31:35.000000000","message":"Sadly, we can not use \u0027+\u0027 here. :-(","commit_id":"c7252ee9c6a3b19da0efe96c0aa55bcecd386630"},{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"484b2aadf13b79d40c3e8c12ca9cf06f90ae3431","unresolved":false,"context_lines":[{"line_number":31,"context_line":"   *"},{"line_number":32,"context_line":"   * Data Model:"},{"line_number":33,"context_line":"   * ```"},{"line_number":34,"context_line":"   * var tooltipModel \u003d {"},{"line_number":35,"context_line":"   *   data: {"},{"line_number":36,"context_line":"   *     message: \u0027My custom message\u0027,"},{"line_number":37,"context_line":"   *     anotherMessage: \u0027Another message\u0027,"}],"source_content_type":"text/javascript","patch_set":14,"id":"9a80dd14_9615f64a","line":34,"updated":"2015-03-07 05:31:35.000000000","message":"Is it $scope.tooltipModel \u003d { ... }; ?","commit_id":"c7252ee9c6a3b19da0efe96c0aa55bcecd386630"}],"horizon/static/angular/action-list/button-tooltip.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"e294c67c78d2f4b24e1d6310504968b02e217f28","unresolved":false,"context_lines":[{"line_number":40,"context_line":"   *       alert(\u0027You clicked me\u0027);"},{"line_number":41,"context_line":"   *     }"},{"line_number":42,"context_line":"   *   },"},{"line_number":43,"context_line":"   *   template: \u0027\u003cdiv\u003e{$ message $}, {$ anotherMessage $}\u0027 +"},{"line_number":44,"context_line":"   *     \u0027\u003ca ng-click\u003d\"clickMe()\"\u003eClick Me!\u003c/a\u003e\u003c/div\u003e\u0027"},{"line_number":45,"context_line":"   * }"},{"line_number":46,"context_line":"   * ```"}],"source_content_type":"text/javascript","patch_set":20,"id":"9a80dd14_24db901c","line":43,"updated":"2015-03-11 19:45:28.000000000","message":"Does it make sense for us to embed HTML templates into a data model? I suppose you can argue that it does - since tooltips are small enough in scope and the HTML is usually minimal. But I\u0027m willing to overlook since argument makes sense.","commit_id":"7101d9466de5d9136d7f20189a82e09bfd9ec235"},{"author":{"_account_id":13785,"name":"Kelly Domico","email":"kelly.domico@hp.com","username":"kdomico"},"change_message_id":"925bec6e35e570651ccf7fd2e853cc6d41e69bea","unresolved":false,"context_lines":[{"line_number":40,"context_line":"   *       alert(\u0027You clicked me\u0027);"},{"line_number":41,"context_line":"   *     }"},{"line_number":42,"context_line":"   *   },"},{"line_number":43,"context_line":"   *   template: \u0027\u003cdiv\u003e{$ message $}, {$ anotherMessage $}\u0027 +"},{"line_number":44,"context_line":"   *     \u0027\u003ca ng-click\u003d\"clickMe()\"\u003eClick Me!\u003c/a\u003e\u003c/div\u003e\u0027"},{"line_number":45,"context_line":"   * }"},{"line_number":46,"context_line":"   * ```"}],"source_content_type":"text/javascript","patch_set":20,"id":"9a80dd14_e72335a5","line":43,"in_reply_to":"9a80dd14_24db901c","updated":"2015-03-11 20:45:49.000000000","message":"Done. A template URL can be passed in instead.","commit_id":"7101d9466de5d9136d7f20189a82e09bfd9ec235"}],"horizon/static/angular/table/basic-table.html":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"4a00587da27d09582042e7abeb3fe704d20fffe6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      \u003c!-- Actions --\u003e"},{"line_number":65,"context_line":"      \u003ctd class\u003d\"action-col\"\u003e"},{"line_number":66,"context_line":"        \u003caction-button actions\u003d\"::tableActions\" action-item\u003d\"row\""},{"line_number":67,"context_line":"          button-data\u003d\"::config.icons\" tooltip-model\u003d\"config.tooltipModel\"\u003e\u003c/action-button\u003e"},{"line_number":68,"context_line":"      \u003c/td\u003e"},{"line_number":69,"context_line":"    \u003c/tr\u003e"},{"line_number":70,"context_line":"  \u003c/tbody\u003e"}],"source_content_type":"text/html","patch_set":13,"id":"9a80dd14_48d6b2c6","line":67,"updated":"2015-03-05 23:06:55.000000000","message":":: shortcut issue here.","commit_id":"539c2270fec7d10dacfe11ea012c97dd4ff41406"}],"horizon/static/angular/table/basic-table.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"e294c67c78d2f4b24e1d6310504968b02e217f28","unresolved":false,"context_lines":[{"line_number":43,"context_line":"              element.find(\u0027[st-search]\u0027).attr(\u0027ng-class\u0027, attrs.inputClasses);"},{"line_number":44,"context_line":"            }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"            $compile(element.contents())(scope);"},{"line_number":47,"context_line":"          }"},{"line_number":48,"context_line":"        };"},{"line_number":49,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":20,"id":"9a80dd14_9802dc07","line":46,"updated":"2015-03-11 19:45:28.000000000","message":"question: do we need to manually compile here? since search-bar style wouldn\u0027t normally change dynamically, I don\u0027t see the need for ng-class. And if that is the case, we don\u0027t need to manually compile. Can simply use element.addClass instead.","commit_id":"7101d9466de5d9136d7f20189a82e09bfd9ec235"},{"author":{"_account_id":13785,"name":"Kelly Domico","email":"kelly.domico@hp.com","username":"kdomico"},"change_message_id":"925bec6e35e570651ccf7fd2e853cc6d41e69bea","unresolved":false,"context_lines":[{"line_number":43,"context_line":"              element.find(\u0027[st-search]\u0027).attr(\u0027ng-class\u0027, attrs.inputClasses);"},{"line_number":44,"context_line":"            }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"            $compile(element.contents())(scope);"},{"line_number":47,"context_line":"          }"},{"line_number":48,"context_line":"        };"},{"line_number":49,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":20,"id":"9a80dd14_0c0cee41","line":46,"in_reply_to":"9a80dd14_9802dc07","updated":"2015-03-11 20:45:49.000000000","message":"Done.","commit_id":"7101d9466de5d9136d7f20189a82e09bfd9ec235"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"1da2f8393727b8c3c25feed63b635d9e14d350e6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"     * \u003c/search-bar\u003e"},{"line_number":28,"context_line":"     * ```"},{"line_number":29,"context_line":"     */"},{"line_number":30,"context_line":"    .directive(\u0027searchBar\u0027, [ \u0027basePath\u0027, \u0027$compile\u0027,"},{"line_number":31,"context_line":"      function(path, $compile) {"},{"line_number":32,"context_line":"        return {"},{"line_number":33,"context_line":"          restrict: \u0027E\u0027,"}],"source_content_type":"text/javascript","patch_set":21,"id":"9a80dd14_e705f014","line":30,"updated":"2015-03-11 22:57:00.000000000","message":"can remove $compile from the DI.","commit_id":"1558527d262a95c1e3e4671f923462d495d5ae1a"}],"horizon/static/angular/table/basic-table.spec.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"e294c67c78d2f4b24e1d6310504968b02e217f28","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"        $scope.rows \u003d [];"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"        var markup \u003d \u0027\u003ctable st-table\u003d\"rows\"\u003e\u003cthead\u003e\u003ctr\u003e\u003cth\u003e\u0027 +"},{"line_number":23,"context_line":"          \u0027\u003csearch-bar group-classes\u003d\"\\\u0027input-group-sm\\\u0027\" \u0027 +"},{"line_number":24,"context_line":"          \u0027  icon-classes\u003d\"\\\u0027fa-search\\\u0027\"\u003e\u0027 +"},{"line_number":25,"context_line":"          \u0027\u003c/search-bar\u003e\u0027 +"}],"source_content_type":"text/javascript","patch_set":20,"id":"9a80dd14_389f3061","line":22,"updated":"2015-03-11 19:45:28.000000000","message":"lets format the markup a bit for readability.","commit_id":"7101d9466de5d9136d7f20189a82e09bfd9ec235"},{"author":{"_account_id":13785,"name":"Kelly Domico","email":"kelly.domico@hp.com","username":"kdomico"},"change_message_id":"925bec6e35e570651ccf7fd2e853cc6d41e69bea","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"        $scope.rows \u003d [];"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"        var markup \u003d \u0027\u003ctable st-table\u003d\"rows\"\u003e\u003cthead\u003e\u003ctr\u003e\u003cth\u003e\u0027 +"},{"line_number":23,"context_line":"          \u0027\u003csearch-bar group-classes\u003d\"\\\u0027input-group-sm\\\u0027\" \u0027 +"},{"line_number":24,"context_line":"          \u0027  icon-classes\u003d\"\\\u0027fa-search\\\u0027\"\u003e\u0027 +"},{"line_number":25,"context_line":"          \u0027\u003c/search-bar\u003e\u0027 +"}],"source_content_type":"text/javascript","patch_set":20,"id":"9a80dd14_6c2aca91","line":22,"in_reply_to":"9a80dd14_389f3061","updated":"2015-03-11 20:45:49.000000000","message":"Done","commit_id":"7101d9466de5d9136d7f20189a82e09bfd9ec235"}],"horizon/static/angular/table/detail-table.html":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"91428730bf22d46652a7fcced5bc3f7eabbfdae2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \u003caction-button actions\u003d\"::tableActions\" action-item\u003d\"row\""},{"line_number":73,"context_line":"          button-data\u003d\"::config.icons\" tooltip-model\u003d\"config.tooltipModel\"\u003e\u003c/action-button\u003e"},{"line_number":74,"context_line":"      \u003c/td\u003e"},{"line_number":75,"context_line":"    \u003c/tr\u003e"},{"line_number":76,"context_line":"    \u003c!-- Detail row --\u003e"},{"line_number":77,"context_line":"    \u003ctr ng-repeat-end class\u003d\"detail-row\" ng-if\u003d\"!row[config.hideRowKey]\" bind-scope\u003e"},{"line_number":78,"context_line":"      \u003c!-- Checkbox --\u003e"}],"source_content_type":"text/html","patch_set":12,"id":"9a80dd14_25f36e74","line":75,"updated":"2015-03-05 21:21:22.000000000","message":"It is a pity that the entire table code needs to be duplicated just to have a table with a details area. This will make it difficult over time for the normal and details tables to stay consistent.\n\nTry to merge the two table versions together.","commit_id":"446e07db4052c193c3d6dfde6644f2d6b9608c9f"},{"author":{"_account_id":13785,"name":"Kelly Domico","email":"kelly.domico@hp.com","username":"kdomico"},"change_message_id":"b02bc6eac84cde5b29943d789ed0e6e42b5ac226","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \u003caction-button actions\u003d\"::tableActions\" action-item\u003d\"row\""},{"line_number":73,"context_line":"          button-data\u003d\"::config.icons\" tooltip-model\u003d\"config.tooltipModel\"\u003e\u003c/action-button\u003e"},{"line_number":74,"context_line":"      \u003c/td\u003e"},{"line_number":75,"context_line":"    \u003c/tr\u003e"},{"line_number":76,"context_line":"    \u003c!-- Detail row --\u003e"},{"line_number":77,"context_line":"    \u003ctr ng-repeat-end class\u003d\"detail-row\" ng-if\u003d\"!row[config.hideRowKey]\" bind-scope\u003e"},{"line_number":78,"context_line":"      \u003c!-- Checkbox --\u003e"}],"source_content_type":"text/html","patch_set":12,"id":"9a80dd14_14f5b9ed","line":75,"in_reply_to":"9a80dd14_25f36e74","updated":"2015-03-05 21:37:09.000000000","message":"With the details row, I\u0027m using ng-repeat-start and ng-repeat-end. The drag and drop ordering is based off the ng-repeat directive. So, it knows to drag the summary row AND detail row. Combining the basic and detail table into one template would require adding from ng-repeat onwards and adding an ng-if. Separating the two tables seemed less messy. I\u0027d be happy to hear any ideas on combining them.","commit_id":"446e07db4052c193c3d6dfde6644f2d6b9608c9f"}],"horizon/static/angular/table/toolbar.html":[{"author":{"_account_id":11098,"name":"Brian Tully","email":"brian.tully@hpe.com","username":"btully"},"change_message_id":"3740533f938ba8c5fa541a4fb7206231bb0393aa","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \u003cinput type\u003d\"text\" class\u003d\"form-control\" st-search ng-model\u003d\"searchTerm\"\u003e"},{"line_number":8,"context_line":"    \u003cspan ng-repeat\u003d\"otherAction in otherActions\" class\u003d\"btn-addon\"\u003e"},{"line_number":9,"context_line":"      \u003ca role\u003d\"button\" class\u003d\"btn btn-sm btn-default\""},{"line_number":10,"context_line":"        ng-click\u003d\"::otherAction.func()\""},{"line_number":11,"context_line":"        ng-class\u003d\"{ \u0027btn-disabled\u0027: otherAction.disabled }\"\u003e"},{"line_number":12,"context_line":"        {$ ::otherAction.label $}"},{"line_number":13,"context_line":"      \u003c/a\u003e"}],"source_content_type":"text/html","patch_set":13,"id":"9a80dd14_88218ab6","line":10,"updated":"2015-03-05 23:10:56.000000000","message":"maybe we need to remove the one-time binding in here as well?","commit_id":"539c2270fec7d10dacfe11ea012c97dd4ff41406"}],"horizon/static/angular/transfer-table/available.html.example":[{"author":{"_account_id":11098,"name":"Brian Tully","email":"brian.tully@hpe.com","username":"btully"},"change_message_id":"0f327366437a5b23653f889c7a52bda92e85307b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  \u003cthead\u003e"},{"line_number":4,"context_line":"    \u003ctr\u003e"},{"line_number":5,"context_line":"      \u003cth class\u003d\"search-header\" colspan\u003d\"10\"\u003e"},{"line_number":6,"context_line":"        \u003csearch-bar group-classes\u003d\"\u0027input-group-sm\u0027\" icon-classes\u003d\"\u0027fa-search\u0027\"\u003e"},{"line_number":7,"context_line":"        \u003c/search-bar\u003e"},{"line_number":8,"context_line":"      \u003c/th\u003e"},{"line_number":9,"context_line":"    \u003c/tr\u003e"}],"source_content_type":"application/octet-stream","patch_set":25,"id":"9a80dd14_2547c578","line":6,"updated":"2015-03-13 01:00:02.000000000","message":"the single quotes around the group-classes and icon-classes attribute values are preventing the proper CSS and icon from displaying. it works if you remove them, e.g., \ngroup-classes\u003d\"input-group-sm\" icon-classes\u003d\"fa-search\"","commit_id":"cec1309afa05b344c97dd664bb26a4310976b5ea"}],"horizon/static/angular/transfer-table/transfer-table.html":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"6992928d62120d86bcf117c22d4328734d2130f3","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    \u003c/div\u003e"},{"line_number":77,"context_line":"  \u003c/div\u003e"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  \u003c!-- Available --\u003e"},{"line_number":80,"context_line":"  \u003cdiv class\u003d\"transfer-section\"\u003e"},{"line_number":81,"context_line":"    \u003c!-- Available section heading --\u003e"},{"line_number":82,"context_line":"    \u003ch5 class\u003d\"transfer-heading\"\u003e"}],"source_content_type":"text/html","patch_set":9,"id":"ba7be1f8_a08e1277","line":79,"updated":"2015-03-03 21:32:05.000000000","message":"This 2nd table is effectively just a repeat of the first duplicating a lot of code. Consider refactoring each table into its own directive, then using 2 instances of that directive, each driven by different data from the model.","commit_id":"f7a71b46a7eaf2e6ba0304bd0145c1fcfe0a12fb"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"91428730bf22d46652a7fcced5bc3f7eabbfdae2","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      {$ ::model.helpText.allocHiddenText $}"},{"line_number":17,"context_line":"    \u003c/div\u003e"},{"line_number":18,"context_line":"    \u003cdiv class\u003d\"transfer-allocated\" ng-show\u003d\"model.views.allocated\"\u003e"},{"line_number":19,"context_line":"      \u003c!-- Allocated table transcluded here --\u003e"},{"line_number":20,"context_line":"    \u003c/div\u003e"},{"line_number":21,"context_line":"  \u003c/div\u003e"},{"line_number":22,"context_line":""}],"source_content_type":"text/html","patch_set":12,"id":"9a80dd14_a01cac14","line":19,"updated":"2015-03-05 21:21:22.000000000","message":"Why transclude the tables now that you have a stand alone \u003cbasic-table\u003e element?\n\nI expected to simply see a \u003cbasic-table\u003e tag here (declarative) that had bindings to the data in needs from the transfer-table.js.","commit_id":"446e07db4052c193c3d6dfde6644f2d6b9608c9f"},{"author":{"_account_id":13785,"name":"Kelly Domico","email":"kelly.domico@hp.com","username":"kdomico"},"change_message_id":"b02bc6eac84cde5b29943d789ed0e6e42b5ac226","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      {$ ::model.helpText.allocHiddenText $}"},{"line_number":17,"context_line":"    \u003c/div\u003e"},{"line_number":18,"context_line":"    \u003cdiv class\u003d\"transfer-allocated\" ng-show\u003d\"model.views.allocated\"\u003e"},{"line_number":19,"context_line":"      \u003c!-- Allocated table transcluded here --\u003e"},{"line_number":20,"context_line":"    \u003c/div\u003e"},{"line_number":21,"context_line":"  \u003c/div\u003e"},{"line_number":22,"context_line":""}],"source_content_type":"text/html","patch_set":12,"id":"9a80dd14_f4a585b5","line":19,"in_reply_to":"9a80dd14_a01cac14","updated":"2015-03-05 21:37:09.000000000","message":"Yeah, I was hoping it was easy as that... but, the table row (ng-repeat) scope wasn\u0027t getting compiled with the transcluded content.","commit_id":"446e07db4052c193c3d6dfde6644f2d6b9608c9f"}],"horizon/static/angular/transfer-table/transfer-table.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"d544ab1aded9af981f4d4f0d090a9afa87784a5a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"      sectionToggleText: gettext(\u0027Click to show or hide\u0027),"},{"line_number":47,"context_line":"      moreDetailsText: gettext(\u0027Click to see more details\u0027),"},{"line_number":48,"context_line":"      orderText: gettext(\u0027Re-order items using drag and drop\u0027),"},{"line_number":49,"context_line":"      orderHeader: gettext(\u0027Order\u0027),"},{"line_number":50,"context_line":"      warningIcon: \u0027fa-exclamation-circle\u0027"},{"line_number":51,"context_line":"    })"},{"line_number":52,"context_line":""}],"source_content_type":"text/javascript","patch_set":8,"id":"ba7be1f8_3c771e04","line":49,"updated":"2015-02-28 21:47:54.000000000","message":"+1 Glad to see this customizable.","commit_id":"e1fa3c941bb3675e1c9b93508dccb733a70739f2"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"946aa9fcc235561bcb62d8066af65bbb8516aa52","unresolved":false,"context_lines":[{"line_number":250,"context_line":"            $scope.availConfig \u003d availConfig;"},{"line_number":251,"context_line":"            $scope.model \u003d model;"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"            var unwatch \u003d $scope.$watch(\u0027trModel.available\u0027, function(newRows) {"},{"line_number":254,"context_line":"              model.numAvailable \u003d newRows.length;"},{"line_number":255,"context_line":"            });"},{"line_number":256,"context_line":"            $scope.$on(\u0027$destroy\u0027, unwatch);"}],"source_content_type":"text/javascript","patch_set":15,"id":"9a80dd14_b0e39ad7","line":253,"updated":"2015-03-10 03:22:23.000000000","message":"I believe this should be a $watchCollection or it won\u0027t pick up some changes to the array.","commit_id":"ed8138d577398d93932636d0868dc0ac92e46552"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"e294c67c78d2f4b24e1d6310504968b02e217f28","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        var tooltipTemplate \u003d \u0027\u003cp\u003e{$ message $}\u003c/p\u003e\u0027 +"},{"line_number":164,"context_line":"          \u0027\u003cdiv\u003e\u0027 +"},{"line_number":165,"context_line":"          \u0027 \u003ca ng-click\u003d\"expandDetail()\"\u003e{$ clickMessage $}\u003c/a\u003e\u0027 +"},{"line_number":166,"context_line":"          \u0027\u003c/div\u003e\u0027;"},{"line_number":167,"context_line":"        model.tooltipModel \u003d {"},{"line_number":168,"context_line":"          template: tooltipTemplate,"},{"line_number":169,"context_line":"          data: {"}],"source_content_type":"text/javascript","patch_set":20,"id":"9a80dd14_6e4ac284","line":166,"updated":"2015-03-11 19:45:28.000000000","message":"can we store this somewhere else? I really hate embedding HTML into code, it makes it difficult to find and modify.","commit_id":"7101d9466de5d9136d7f20189a82e09bfd9ec235"},{"author":{"_account_id":13785,"name":"Kelly Domico","email":"kelly.domico@hp.com","username":"kdomico"},"change_message_id":"925bec6e35e570651ccf7fd2e853cc6d41e69bea","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        var tooltipTemplate \u003d \u0027\u003cp\u003e{$ message $}\u003c/p\u003e\u0027 +"},{"line_number":164,"context_line":"          \u0027\u003cdiv\u003e\u0027 +"},{"line_number":165,"context_line":"          \u0027 \u003ca ng-click\u003d\"expandDetail()\"\u003e{$ clickMessage $}\u003c/a\u003e\u0027 +"},{"line_number":166,"context_line":"          \u0027\u003c/div\u003e\u0027;"},{"line_number":167,"context_line":"        model.tooltipModel \u003d {"},{"line_number":168,"context_line":"          template: tooltipTemplate,"},{"line_number":169,"context_line":"          data: {"}],"source_content_type":"text/javascript","patch_set":20,"id":"9a80dd14_2c20d2af","line":166,"in_reply_to":"9a80dd14_6e4ac284","updated":"2015-03-11 20:45:49.000000000","message":"Done","commit_id":"7101d9466de5d9136d7f20189a82e09bfd9ec235"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"e294c67c78d2f4b24e1d6310504968b02e217f28","unresolved":false,"context_lines":[{"line_number":292,"context_line":"     * ```"},{"line_number":293,"context_line":"     * \u003ctransfer-table tr-model\u003d\"tableData\" help-text\u003d\"helpText\" limits\u003d\"limits\"\u003e"},{"line_number":294,"context_line":"     *   \u003callocated\u003e"},{"line_number":295,"context_line":"     *     \u003ctable st-table\u003d\"tableData.displayedAllocated\""},{"line_number":296,"context_line":"     *       st-safe-src\u003d\"tableData.allocated\" hz-table\u003e"},{"line_number":297,"context_line":"     *       \u003cthead\u003e... header definition ...\u003c/thead\u003e"},{"line_number":298,"context_line":"     *       \u003ctbody\u003e"}],"source_content_type":"text/javascript","patch_set":20,"id":"9a80dd14_ae3bdae9","line":295,"updated":"2015-03-11 19:45:28.000000000","message":"I know you\u0027re not a big fan of ng-include, but for crazy long HTML files, it might make sense to break it into smaller clunks. The performance hit will be minimal, since it only needs to fetch and load the template once.","commit_id":"7101d9466de5d9136d7f20189a82e09bfd9ec235"},{"author":{"_account_id":13785,"name":"Kelly Domico","email":"kelly.domico@hp.com","username":"kdomico"},"change_message_id":"925bec6e35e570651ccf7fd2e853cc6d41e69bea","unresolved":false,"context_lines":[{"line_number":292,"context_line":"     * ```"},{"line_number":293,"context_line":"     * \u003ctransfer-table tr-model\u003d\"tableData\" help-text\u003d\"helpText\" limits\u003d\"limits\"\u003e"},{"line_number":294,"context_line":"     *   \u003callocated\u003e"},{"line_number":295,"context_line":"     *     \u003ctable st-table\u003d\"tableData.displayedAllocated\""},{"line_number":296,"context_line":"     *       st-safe-src\u003d\"tableData.allocated\" hz-table\u003e"},{"line_number":297,"context_line":"     *       \u003cthead\u003e... header definition ...\u003c/thead\u003e"},{"line_number":298,"context_line":"     *       \u003ctbody\u003e"}],"source_content_type":"text/javascript","patch_set":20,"id":"9a80dd14_f17693d7","line":295,"in_reply_to":"9a80dd14_ae3bdae9","updated":"2015-03-11 20:45:49.000000000","message":"Using ng-include here would be great, but it\u0027s up to the dev using the transfer tables. The example files can be used as the \u0027src\u0027 for ng-include.","commit_id":"7101d9466de5d9136d7f20189a82e09bfd9ec235"}],"horizon/static/angular/transfer-table/transfer-table.scss":[{"author":{"_account_id":8512,"name":"Matt Farina","email":"matt@mattfarina.com","username":"mattfarina"},"change_message_id":"3319830fd6f9c07ce7f43e88905c4a328c214da0","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            border-color: #666666;"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"            \u0026.btn-disabled {"},{"line_number":79,"context_line":"              border-color: #cecece;"},{"line_number":80,"context_line":"              color: #dddddd;"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"              \u0026:hover, \u0026:focus {"}],"source_content_type":"text/x-scss","patch_set":4,"id":"ba7be1f8_76c0e77c","line":79,"updated":"2015-02-27 20:24:56.000000000","message":"Should the colors used here be variables?","commit_id":"2a7b9f496e8d7bbd3a91a10f2ded72b22aefe1d7"},{"author":{"_account_id":13785,"name":"Kelly Domico","email":"kelly.domico@hp.com","username":"kdomico"},"change_message_id":"72e6b785196f04ac6fe2f9a55d2a66c96a7a8801","unresolved":false,"context_lines":[{"line_number":76,"context_line":"            border-color: #666666;"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"            \u0026.btn-disabled {"},{"line_number":79,"context_line":"              border-color: #cecece;"},{"line_number":80,"context_line":"              color: #dddddd;"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"              \u0026:hover, \u0026:focus {"}],"source_content_type":"text/x-scss","patch_set":4,"id":"ba7be1f8_22ed498c","line":79,"in_reply_to":"ba7be1f8_76c0e77c","updated":"2015-02-27 22:33:45.000000000","message":"Yup. Done.","commit_id":"2a7b9f496e8d7bbd3a91a10f2ded72b22aefe1d7"}],"horizon/static/angular/transfer-table/warning-tooltip.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"93db36417e8eed84ef6435f40851484a9cb22d1e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            var message \u003d scope.message || tooltipDefaults.defaultMessage;"},{"line_number":46,"context_line":"            var content \u003d \u0027\u003cp\u003e\u0027 + message + \u0027\u003c/p\u003e\u0027 +"},{"line_number":47,"context_line":"                          \u0027\u003ca href\u003d\"#\" ng-click\u003d\"tModel.expandDetail()\"\u003e\u0027 +"},{"line_number":48,"context_line":"                          \u0027 Show or hide details\u0027 +"},{"line_number":49,"context_line":"                          \u0027\u003c/a\u003e\u0027;"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            var options \u003d {"}],"source_content_type":"text/javascript","patch_set":6,"id":"ba7be1f8_649bcac9","line":48,"updated":"2015-02-28 01:54:11.000000000","message":"make translatable","commit_id":"6989eff372ecb675c6a4bac9ef8fbe80899f4694"},{"author":{"_account_id":13785,"name":"Kelly Domico","email":"kelly.domico@hp.com","username":"kdomico"},"change_message_id":"8e60c983ac21768af49db4d84f5d00f840f18171","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            var message \u003d scope.message || tooltipDefaults.defaultMessage;"},{"line_number":46,"context_line":"            var content \u003d \u0027\u003cp\u003e\u0027 + message + \u0027\u003c/p\u003e\u0027 +"},{"line_number":47,"context_line":"                          \u0027\u003ca href\u003d\"#\" ng-click\u003d\"tModel.expandDetail()\"\u003e\u0027 +"},{"line_number":48,"context_line":"                          \u0027 Show or hide details\u0027 +"},{"line_number":49,"context_line":"                          \u0027\u003c/a\u003e\u0027;"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"            var options \u003d {"}],"source_content_type":"text/javascript","patch_set":6,"id":"ba7be1f8_84e0becd","line":48,"in_reply_to":"ba7be1f8_649bcac9","updated":"2015-02-28 02:16:50.000000000","message":"Done. Ack, I keep forgetting about translation. Thanks for reviewing!","commit_id":"6989eff372ecb675c6a4bac9ef8fbe80899f4694"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"6992928d62120d86bcf117c22d4328734d2130f3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        link: function (scope, element, attrs) {"},{"line_number":45,"context_line":"          if (!scope.warningDisabled) {"},{"line_number":46,"context_line":"            var message \u003d scope.message || tooltipDefaults.defaultMessage;"},{"line_number":47,"context_line":"            var content \u003d \u0027\u003cp\u003e\u0027 + message + \u0027\u003c/p\u003e\u0027 +"},{"line_number":48,"context_line":"                          \u0027\u003ca href\u003d\"#\" ng-click\u003d\"tModel.expandDetail()\"\u003e\u0027 +"},{"line_number":49,"context_line":"                          tooltipDefaults.showHideMessage +"},{"line_number":50,"context_line":"                          \u0027\u003c/a\u003e\u0027;"}],"source_content_type":"text/javascript","patch_set":9,"id":"ba7be1f8_2025c25b","line":47,"updated":"2015-03-03 21:32:05.000000000","message":"A good start, but this will be hard to re-use as people apply this tooltip to other areas. Consider allowing a templateURL for the tooltip source.","commit_id":"f7a71b46a7eaf2e6ba0304bd0145c1fcfe0a12fb"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"6992928d62120d86bcf117c22d4328734d2130f3","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                $compile(popoverElt.contents())(scope);"},{"line_number":66,"context_line":"              }"},{"line_number":67,"context_line":"            });"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"            element.on(\u0027blur\u0027, function() {"},{"line_number":70,"context_line":"              element.popover(\u0027hide\u0027);"},{"line_number":71,"context_line":"            });"}],"source_content_type":"text/javascript","patch_set":9,"id":"ba7be1f8_20b3020b","line":68,"updated":"2015-03-03 21:32:05.000000000","message":"It is a little annoying to need to move the mouse elsewhere, then click, to dismiss this tooltip. Consider toggling show on click, so that second click in the same element will hide the tooltip.","commit_id":"f7a71b46a7eaf2e6ba0304bd0145c1fcfe0a12fb"}],"horizon/templates/horizon/jasmine/jasmine.html":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"6992928d62120d86bcf117c22d4328734d2130f3","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  \u003cscript src\u003d\"{{ STATIC_URL }}horizon/lib/angular/angular-cookies.js\"\u003e\u003c/script\u003e"},{"line_number":16,"context_line":"  \u003cscript src\u003d\"{{ STATIC_URL }}horizon/lib/angular/angular-bootstrap.js\"\u003e\u003c/script\u003e"},{"line_number":17,"context_line":"  \u003cscript src\u003d\"{{ STATIC_URL }}horizon/lib/angular/smart-table.js\"\u003e\u003c/script\u003e"},{"line_number":18,"context_line":"  \u003cscript src\u003d\"{{ STATIC_URL }}horizon/lib/angular/irdragndrop.js\"\u003e\u003c/script\u003e"},{"line_number":19,"context_line":"  \u003cscript src\u003d\"{{ STATIC_URL }}horizon/lib/d3.js\"\u003e\u003c/script\u003e"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  \u003cscript type\u003d\"text/javascript\"\u003e"}],"source_content_type":"text/html","patch_set":9,"id":"ba7be1f8_a0c61266","line":18,"updated":"2015-03-03 21:32:05.000000000","message":"This library doesn\u0027t allow drag and drop of an element to the last position in the list.","commit_id":"f7a71b46a7eaf2e6ba0304bd0145c1fcfe0a12fb"}]}
