)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"3b5552a1abcb0b1a882f301355fa4af57e97235c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  /horizon/lib/magic_search/magic_search.scss"},{"line_number":16,"context_line":"- Adds fa-server icon and lighter gray color  for server/api filter"},{"line_number":17,"context_line":"- Adds fa-desktop icon for client side filter"},{"line_number":18,"context_line":"- Optional: tooltip added to icons to help indicate visual difference."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Partially Implements: blueprint filtered-client-side-table"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"dac4157f_e4b9d6cc","line":18,"updated":"2015-04-21 16:21:23.000000000","message":"And improvement for dynamic facets.","commit_id":"6a63a38c7a4ab7380fd2f36882a66c39a1e57310"}],"horizon/static/angular/magic-search/magic-search.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"ae2058d7acd535ad7a081a626867083a4decf66f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"   * @ngdoc directive"},{"line_number":6,"context_line":"   * @name MagicSearch:magicOverrides"},{"line_number":7,"context_line":"   * @description"},{"line_number":8,"context_line":"   * A directive to modify / extend Magic Search functionality"},{"line_number":9,"context_line":"   *"},{"line_number":10,"context_line":"   * @restrict A"},{"line_number":11,"context_line":"   * @scope"}],"source_content_type":"text/javascript","patch_set":14,"id":"dac4157f_088ac6bf","line":8,"updated":"2015-04-20 19:36:08.000000000","message":"what exactly are we modifying/extending?","commit_id":"7afbfb882ae20d07ca54efa80279e207b54fe155"},{"author":{"_account_id":11881,"name":"Aaron Sahlin","email":"asahlin@us.ibm.com","username":"asahlin"},"change_message_id":"da1170689afe40b036cb1bc85bd80be1b0f6b40c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"   * @ngdoc directive"},{"line_number":6,"context_line":"   * @name MagicSearch:magicOverrides"},{"line_number":7,"context_line":"   * @description"},{"line_number":8,"context_line":"   * A directive to modify / extend Magic Search functionality"},{"line_number":9,"context_line":"   *"},{"line_number":10,"context_line":"   * @restrict A"},{"line_number":11,"context_line":"   * @scope"}],"source_content_type":"text/javascript","patch_set":14,"id":"dac4157f_26913a9a","line":8,"in_reply_to":"dac4157f_088ac6bf","updated":"2015-04-20 20:38:34.000000000","message":"Added comments indicating what we are modifying from base.","commit_id":"7afbfb882ae20d07ca54efa80279e207b54fe155"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"ae2058d7acd535ad7a081a626867083a4decf66f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"   * A directive to modify / extend Magic Search functionality"},{"line_number":9,"context_line":"   *"},{"line_number":10,"context_line":"   * @restrict A"},{"line_number":11,"context_line":"   * @scope"},{"line_number":12,"context_line":"   *"},{"line_number":13,"context_line":"   */"},{"line_number":14,"context_line":"  .directive(\u0027magicOverrides\u0027, function() {"}],"source_content_type":"text/javascript","patch_set":14,"id":"dac4157f_28722ae6","line":11,"updated":"2015-04-20 19:36:08.000000000","message":"example of usage?","commit_id":"7afbfb882ae20d07ca54efa80279e207b54fe155"},{"author":{"_account_id":11881,"name":"Aaron Sahlin","email":"asahlin@us.ibm.com","username":"asahlin"},"change_message_id":"da1170689afe40b036cb1bc85bd80be1b0f6b40c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"   * A directive to modify / extend Magic Search functionality"},{"line_number":9,"context_line":"   *"},{"line_number":10,"context_line":"   * @restrict A"},{"line_number":11,"context_line":"   * @scope"},{"line_number":12,"context_line":"   *"},{"line_number":13,"context_line":"   */"},{"line_number":14,"context_line":"  .directive(\u0027magicOverrides\u0027, function() {"}],"source_content_type":"text/javascript","patch_set":14,"id":"dac4157f_83f8f8e6","line":11,"in_reply_to":"dac4157f_28722ae6","updated":"2015-04-20 20:38:34.000000000","message":"Done","commit_id":"7afbfb882ae20d07ca54efa80279e207b54fe155"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"ae2058d7acd535ad7a081a626867083a4decf66f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        function($scope, $timeout) {"},{"line_number":19,"context_line":"          // showMenu and hideMenu depend on foundation\u0027s dropdown. They need"},{"line_number":20,"context_line":"          // to be modified to work with another dropdown implementation."},{"line_number":21,"context_line":"          // For bootstrap, they are not needed at all."},{"line_number":22,"context_line":"          $scope.showMenu \u003d function() {"},{"line_number":23,"context_line":"            $timeout(function() {"},{"line_number":24,"context_line":"              $scope.isMenuOpen \u003d true;"}],"source_content_type":"text/javascript","patch_set":14,"id":"dac4157f_235c8d24","line":21,"updated":"2015-04-20 19:36:08.000000000","message":"We\u0027re using scope as the model here. I\u0027m wondering if it is better to attach to some service instead?","commit_id":"7afbfb882ae20d07ca54efa80279e207b54fe155"},{"author":{"_account_id":11881,"name":"Aaron Sahlin","email":"asahlin@us.ibm.com","username":"asahlin"},"change_message_id":"da1170689afe40b036cb1bc85bd80be1b0f6b40c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        function($scope, $timeout) {"},{"line_number":19,"context_line":"          // showMenu and hideMenu depend on foundation\u0027s dropdown. They need"},{"line_number":20,"context_line":"          // to be modified to work with another dropdown implementation."},{"line_number":21,"context_line":"          // For bootstrap, they are not needed at all."},{"line_number":22,"context_line":"          $scope.showMenu \u003d function() {"},{"line_number":23,"context_line":"            $timeout(function() {"},{"line_number":24,"context_line":"              $scope.isMenuOpen \u003d true;"}],"source_content_type":"text/javascript","patch_set":14,"id":"dac4157f_2656dad2","line":21,"in_reply_to":"dac4157f_235c8d24","updated":"2015-04-20 20:38:34.000000000","message":"We are overriding methods that are defined by base magic_search, so I believe our hands are tied here.","commit_id":"7afbfb882ae20d07ca54efa80279e207b54fe155"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"3b5552a1abcb0b1a882f301355fa4af57e97235c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"(function() {"},{"line_number":2,"context_line":"  \u0027use strict\u0027;"},{"line_number":3,"context_line":"  angular.module(\u0027MagicSearch\u0027, [\u0027ui.bootstrap\u0027])"},{"line_number":4,"context_line":"  /**"},{"line_number":5,"context_line":"   * @ngdoc directive"},{"line_number":6,"context_line":"   * @name MagicSearch:magicOverrides"}],"source_content_type":"text/javascript","patch_set":16,"id":"dac4157f_84de9a6b","line":3,"updated":"2015-04-21 16:21:23.000000000","message":"We are working towards new best practices that modules should be declared in their own file even if there is only a single component (e.g. directive). This hasn\u0027t been widely followed, yet and I\u0027m hoping to have this done in a subsequent patch across horizon.","commit_id":"6a63a38c7a4ab7380fd2f36882a66c39a1e57310"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"70ee31a89936355622c2b3c5e20f293dd1eb2103","unresolved":false,"context_lines":[{"line_number":8,"context_line":"   * A directive to modify / extend Magic Search functionality for use in"},{"line_number":9,"context_line":"   * Horizon."},{"line_number":10,"context_line":"   * 1. The base magic search uses Foundation, and in showMenu and"},{"line_number":11,"context_line":"   * hide menu makes a Foundation call, therefore we need to override."},{"line_number":12,"context_line":"   *"},{"line_number":13,"context_line":"   * 2.  Added \u0027facetsChanged\u0027 listener so we can notify base magic search"},{"line_number":14,"context_line":"   * widget that new facets are available so they will be picked up.  (Use"}],"source_content_type":"text/javascript","patch_set":16,"id":"dac4157f_9df3b10a","line":11,"updated":"2015-04-21 23:49:35.000000000","message":"give brief mention of what Foundation is","commit_id":"6a63a38c7a4ab7380fd2f36882a66c39a1e57310"},{"author":{"_account_id":11098,"name":"Brian Tully","email":"brian.tully@hpe.com","username":"btully"},"change_message_id":"50003e3024833619bd357f6ab862da90b5da524c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"   * 3.  To support the distinguishment between server \u0026 client side facets"},{"line_number":18,"context_line":"   * overrode methods removeFacet \u0026 initfacets to emit \u0027checkFacets\u0027 event"},{"line_number":19,"context_line":"   * so implementors can add propterty isServer to facets.  (what keys the"},{"line_number":20,"context_line":"   * facet icon and color difference)"},{"line_number":21,"context_line":"   *"},{"line_number":22,"context_line":"   * 4.  Overrode initfacets to fix refresh / bookmark issue where facets"},{"line_number":23,"context_line":"   * menu wasn\u0027t removing facets that were already on url."}],"source_content_type":"text/javascript","patch_set":16,"id":"7ad32947_78492bd0","line":20,"updated":"2015-04-27 22:10:05.000000000","message":"Can you give more details here on why distinction would be helpful to users, and more importantly, where does this \u0027isServer\u0027 property live? Is this something that needs to be configured on the server side when returning facets or is this something that is handled with supporting javascript that utilizes this patch?","commit_id":"6a63a38c7a4ab7380fd2f36882a66c39a1e57310"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"3b5552a1abcb0b1a882f301355fa4af57e97235c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   */"},{"line_number":33,"context_line":"  .directive(\u0027magicOverrides\u0027, function() {"},{"line_number":34,"context_line":"    return {"},{"line_number":35,"context_line":"      restrict: \u0027A\u0027,"},{"line_number":36,"context_line":"      controller: [\u0027$scope\u0027, \u0027$timeout\u0027,"},{"line_number":37,"context_line":"        function($scope, $timeout) {"},{"line_number":38,"context_line":"          // showMenu and hideMenu depend on foundation\u0027s dropdown. They need"}],"source_content_type":"text/javascript","patch_set":16,"id":"dac4157f_643b8639","line":35,"updated":"2015-04-21 16:21:23.000000000","message":"Can this use controllerAs?","commit_id":"6a63a38c7a4ab7380fd2f36882a66c39a1e57310"},{"author":{"_account_id":11098,"name":"Brian Tully","email":"brian.tully@hpe.com","username":"btully"},"change_message_id":"50003e3024833619bd357f6ab862da90b5da524c","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            $scope.initFacets();"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"            // broadcast to check facets for serverside"},{"line_number":142,"context_line":"            $scope.$emit(\u0027checkFacets\u0027, $scope.currentSearch);"},{"line_number":143,"context_line":"          };"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":16,"id":"7ad32947_18091796","line":142,"updated":"2015-04-27 22:10:05.000000000","message":"Can you give an example on where this might be used?","commit_id":"6a63a38c7a4ab7380fd2f36882a66c39a1e57310"}],"horizon/static/angular/magic-search/magic-search.scss":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"83c14f7e7cdced1407048e2997700205b11557b0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  }"},{"line_number":15,"context_line":"  .item-list {"},{"line_number":16,"context_line":"    .item {"},{"line_number":17,"context_line":"      background-color: #EEEEEE;"},{"line_number":18,"context_line":"      a {"},{"line_number":19,"context_line":"        color: #d9534f;"},{"line_number":20,"context_line":"      }"}],"source_content_type":"text/x-scss","patch_set":6,"id":"9aa53dc9_dc9ddc5a","line":17,"updated":"2015-04-06 17:00:50.000000000","message":"Change looks really nice, but I wondering if we should move this into variables or use bootstrap\u0027s standard color variables? Thoughts?","commit_id":"acaf9f635b2f10db6d3775465d47a8decf6dbca2"},{"author":{"_account_id":11881,"name":"Aaron Sahlin","email":"asahlin@us.ibm.com","username":"asahlin"},"change_message_id":"52744f62eb92a89c63f408477e0878e1ee092e22","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  }"},{"line_number":15,"context_line":"  .item-list {"},{"line_number":16,"context_line":"    .item {"},{"line_number":17,"context_line":"      background-color: #EEEEEE;"},{"line_number":18,"context_line":"      a {"},{"line_number":19,"context_line":"        color: #d9534f;"},{"line_number":20,"context_line":"      }"}],"source_content_type":"text/x-scss","patch_set":6,"id":"9aa53dc9_5a12e7b5","line":17,"in_reply_to":"9aa53dc9_dc9ddc5a","updated":"2015-04-06 20:42:01.000000000","message":"I switched to use bootstraps grey-light \u0026\u0026 grey-lighter respectively.","commit_id":"acaf9f635b2f10db6d3775465d47a8decf6dbca2"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"ae2058d7acd535ad7a081a626867083a4decf66f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    font-size: 100%;"},{"line_number":36,"context_line":"    font-weight: normal;"},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  min-width: 500px;"},{"line_number":40,"context_line":"  border-color: #ccc;"},{"line_number":41,"context_line":"  border-radius: 3px;"}],"source_content_type":"text/x-scss","patch_set":14,"id":"dac4157f_68d82254","line":38,"updated":"2015-04-20 19:36:08.000000000","message":"can we move this to the top? easier to read since it applies to search-bar.","commit_id":"7afbfb882ae20d07ca54efa80279e207b54fe155"},{"author":{"_account_id":11881,"name":"Aaron Sahlin","email":"asahlin@us.ibm.com","username":"asahlin"},"change_message_id":"da1170689afe40b036cb1bc85bd80be1b0f6b40c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    font-size: 100%;"},{"line_number":36,"context_line":"    font-weight: normal;"},{"line_number":37,"context_line":"  }"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  min-width: 500px;"},{"line_number":40,"context_line":"  border-color: #ccc;"},{"line_number":41,"context_line":"  border-radius: 3px;"}],"source_content_type":"text/x-scss","patch_set":14,"id":"dac4157f_03f98980","line":38,"in_reply_to":"dac4157f_68d82254","updated":"2015-04-20 20:38:34.000000000","message":"Done","commit_id":"7afbfb882ae20d07ca54efa80279e207b54fe155"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"3b5552a1abcb0b1a882f301355fa4af57e97235c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"// Augments magic_search.scss with styles for bootstrap/Horizon."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":".search-bar {"},{"line_number":4,"context_line":"  min-width: 500px;"},{"line_number":5,"context_line":"  border-color: #ccc;"},{"line_number":6,"context_line":"  border-radius: 3px;"},{"line_number":7,"context_line":"  margin-bottom: 0;"}],"source_content_type":"text/x-scss","patch_set":16,"id":"dac4157f_e461d6a9","line":4,"updated":"2015-04-21 16:21:23.000000000","message":"Any reason why these aren\u0027t variables?","commit_id":"6a63a38c7a4ab7380fd2f36882a66c39a1e57310"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"cdc7d982e69a37193b9a8d8434023da8c3f99a01","unresolved":false,"context_lines":[{"line_number":1,"context_line":"// Augments magic_search.scss with styles for bootstrap/Horizon."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":".search-bar {"},{"line_number":4,"context_line":"  min-width: 500px;"},{"line_number":5,"context_line":"  border-color: #ccc;"},{"line_number":6,"context_line":"  border-radius: 3px;"},{"line_number":7,"context_line":"  margin-bottom: 0;"}],"source_content_type":"text/x-scss","patch_set":16,"id":"dac4157f_5b4500b1","line":4,"in_reply_to":"dac4157f_e461d6a9","updated":"2015-04-21 16:52:00.000000000","message":"+1, could be a follow on patch to remedy","commit_id":"6a63a38c7a4ab7380fd2f36882a66c39a1e57310"}]}