)]}'
{"openstack_dashboard/dashboards/project/instances/tests.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"a0c58b9aac4508a2e127cdf69d0f21fb8190a4bc","unresolved":false,"context_lines":[{"line_number":3253,"context_line":""},{"line_number":3254,"context_line":"    def test_launch_form_instance_volume_exceed_quota(self):"},{"line_number":3255,"context_line":"        image \u003d self.images.get(name\u003d\u0027protected_images\u0027)"},{"line_number":3256,"context_line":"        msg \u003d \"Requested volume exceed quota: Available: 0, Requested: 1\""},{"line_number":3257,"context_line":"        self._test_launch_form_instance_volume_size(image, image.min_disk,"},{"line_number":3258,"context_line":"                                                    msg, False, 0)"},{"line_number":3259,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aaa499b_4b61cd38","line":3256,"updated":"2015-04-14 06:28:55.000000000","message":"yingjun, please update this as well.","commit_id":"b1cb1696e0d8084fdb4e35d2b554aa6f2753bc39"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"fa823b03e0d2a14d6b4589049278e20e9ff47894","unresolved":false,"context_lines":[{"line_number":3253,"context_line":""},{"line_number":3254,"context_line":"    def test_launch_form_instance_volume_exceed_quota(self):"},{"line_number":3255,"context_line":"        image \u003d self.images.get(name\u003d\u0027protected_images\u0027)"},{"line_number":3256,"context_line":"        msg \u003d \"Requested volume exceed quota: Available: 0, Requested: 1\""},{"line_number":3257,"context_line":"        self._test_launch_form_instance_volume_size(image, image.min_disk,"},{"line_number":3258,"context_line":"                                                    msg, False, 0)"},{"line_number":3259,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aaa499b_bd3658e5","line":3256,"in_reply_to":"7aaa499b_4b61cd38","updated":"2015-04-14 06:44:53.000000000","message":"Done","commit_id":"b1cb1696e0d8084fdb4e35d2b554aa6f2753bc39"}],"openstack_dashboard/dashboards/project/instances/workflows/create_instance.py":[{"author":{"_account_id":13161,"name":"Kamil Rykowski","email":"kamil.rykowski@gmail.com","username":"krykowski"},"change_message_id":"5a804018f161653d09bbf10c3180e126469f8177","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        available_volume \u003d usages[\u0027volumes\u0027][\u0027available\u0027]"},{"line_number":242,"context_line":"        source_type \u003d cleaned_data.get(\u0027source_type\u0027)"},{"line_number":243,"context_line":"        if (source_type \u003d\u003d \"volume_image_id\" or"},{"line_number":244,"context_line":"                source_type \u003d\u003d \"volume_snapshot_id\"):"},{"line_number":245,"context_line":"            if available_volume \u003c count:"},{"line_number":246,"context_line":"                msg \u003d (_(\u0027The requested instance cannot be launched. \u0027"},{"line_number":247,"context_line":"                         \u0027Requested volume exceed quota: Available: \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_41179251","line":244,"updated":"2015-04-07 07:49:30.000000000","message":"if source_type in (\u0027volume_image_id\u0027, \u0027volume_snapshot_id\u0027) could be used here for simplification.","commit_id":"414f4057eaa4f6c6bf6d5e46dd24b7db028b2168"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"5a929b0043862f4865360cd37a93d72aa52a3a17","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        available_volume \u003d usages[\u0027volumes\u0027][\u0027available\u0027]"},{"line_number":242,"context_line":"        source_type \u003d cleaned_data.get(\u0027source_type\u0027)"},{"line_number":243,"context_line":"        if (source_type \u003d\u003d \"volume_image_id\" or"},{"line_number":244,"context_line":"                source_type \u003d\u003d \"volume_snapshot_id\"):"},{"line_number":245,"context_line":"            if available_volume \u003c count:"},{"line_number":246,"context_line":"                msg \u003d (_(\u0027The requested instance cannot be launched. \u0027"},{"line_number":247,"context_line":"                         \u0027Requested volume exceed quota: Available: \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa53dc9_84792896","line":244,"in_reply_to":"9aa53dc9_41179251","updated":"2015-04-07 07:53:50.000000000","message":"Done","commit_id":"414f4057eaa4f6c6bf6d5e46dd24b7db028b2168"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"1e580d94f93f3c2a723af4a1d8ad675f79589dc6","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        if source_type in (\u0027volume_image_id\u0027, \u0027volume_snapshot_id\u0027):"},{"line_number":244,"context_line":"            if available_volume \u003c count:"},{"line_number":245,"context_line":"                msg \u003d (_(\u0027The requested instance cannot be launched. \u0027"},{"line_number":246,"context_line":"                         \u0027Requested volume exceed quota: Available: \u0027"},{"line_number":247,"context_line":"                         \u0027%(avail)s, Requested: %(req)s.\u0027)"},{"line_number":248,"context_line":"                       % {\u0027avail\u0027: available_volume, \u0027req\u0027: count})"},{"line_number":249,"context_line":"                raise forms.ValidationError(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aaa499b_b657ae01","line":246,"updated":"2015-04-13 16:05:32.000000000","message":"exceed should be exceeds","commit_id":"52013d05de4a6aeae911e6ede6dcbf37aa614f17"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"fa569ac5cbc096dfe338c943563645ca3b45f5a2","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        if source_type in (\u0027volume_image_id\u0027, \u0027volume_snapshot_id\u0027):"},{"line_number":244,"context_line":"            if available_volume \u003c count:"},{"line_number":245,"context_line":"                msg \u003d (_(\u0027The requested instance cannot be launched. \u0027"},{"line_number":246,"context_line":"                         \u0027Requested volume exceed quota: Available: \u0027"},{"line_number":247,"context_line":"                         \u0027%(avail)s, Requested: %(req)s.\u0027)"},{"line_number":248,"context_line":"                       % {\u0027avail\u0027: available_volume, \u0027req\u0027: count})"},{"line_number":249,"context_line":"                raise forms.ValidationError(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aaa499b_6a47e74b","line":246,"in_reply_to":"7aaa499b_b657ae01","updated":"2015-04-14 03:10:07.000000000","message":"Done","commit_id":"52013d05de4a6aeae911e6ede6dcbf37aa614f17"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"5d2ce84b14642dce9a82c9c917d52c73e1c7979d","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                               % {\u0027avail\u0027: available_ram,"},{"line_number":239,"context_line":"                                  \u0027req\u0027: count * flavor.ram})"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        available_volume \u003d usages[\u0027volumes\u0027][\u0027available\u0027]"},{"line_number":242,"context_line":"        source_type \u003d cleaned_data.get(\u0027source_type\u0027)"},{"line_number":243,"context_line":"        if source_type in (\u0027volume_image_id\u0027, \u0027volume_snapshot_id\u0027):"},{"line_number":244,"context_line":"            if available_volume \u003c count:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aa745d1_9725fcc3","line":241,"updated":"2015-04-15 22:07:21.000000000","message":"this variable could move under  \"if source_type..\" since it is only needed if it satisfies the condition.","commit_id":"f5dd2ebbd03e32d5848e0d4404905171728db768"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"31e662a03a7e9c0d5b7aad77c9076d3ffc97e779","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                               % {\u0027avail\u0027: available_ram,"},{"line_number":239,"context_line":"                                  \u0027req\u0027: count * flavor.ram})"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        available_volume \u003d usages[\u0027volumes\u0027][\u0027available\u0027]"},{"line_number":242,"context_line":"        source_type \u003d cleaned_data.get(\u0027source_type\u0027)"},{"line_number":243,"context_line":"        if source_type in (\u0027volume_image_id\u0027, \u0027volume_snapshot_id\u0027):"},{"line_number":244,"context_line":"            if available_volume \u003c count:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aa745d1_bceb38b0","line":241,"in_reply_to":"5aa745d1_9725fcc3","updated":"2015-04-16 01:09:30.000000000","message":"+1","commit_id":"f5dd2ebbd03e32d5848e0d4404905171728db768"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"638b6cba38c547b9659ee3e892e0477b6ca55ffd","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                               % {\u0027avail\u0027: available_ram,"},{"line_number":239,"context_line":"                                  \u0027req\u0027: count * flavor.ram})"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        available_volume \u003d usages[\u0027volumes\u0027][\u0027available\u0027]"},{"line_number":242,"context_line":"        source_type \u003d cleaned_data.get(\u0027source_type\u0027)"},{"line_number":243,"context_line":"        if source_type in (\u0027volume_image_id\u0027, \u0027volume_snapshot_id\u0027):"},{"line_number":244,"context_line":"            if available_volume \u003c count:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aa745d1_3fa71a51","line":241,"in_reply_to":"5aa745d1_9725fcc3","updated":"2015-04-16 02:02:56.000000000","message":"Done","commit_id":"f5dd2ebbd03e32d5848e0d4404905171728db768"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"5d2ce84b14642dce9a82c9c917d52c73e1c7979d","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        source_type \u003d cleaned_data.get(\u0027source_type\u0027)"},{"line_number":243,"context_line":"        if source_type in (\u0027volume_image_id\u0027, \u0027volume_snapshot_id\u0027):"},{"line_number":244,"context_line":"            if available_volume \u003c count:"},{"line_number":245,"context_line":"                msg \u003d (_(\u0027The requested instance cannot be launched. \u0027"},{"line_number":246,"context_line":"                         \u0027Requested volume exceeds quota: Available: \u0027"},{"line_number":247,"context_line":"                         \u0027%(avail)s, Requested: %(req)s.\u0027)"},{"line_number":248,"context_line":"                       % {\u0027avail\u0027: available_volume, \u0027req\u0027: count})"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aa745d1_9213ca5c","line":245,"updated":"2015-04-15 22:07:21.000000000","message":"why not just follow the same pattern for other quota validation?  The seems better since we can display all quota error at once.","commit_id":"f5dd2ebbd03e32d5848e0d4404905171728db768"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"638b6cba38c547b9659ee3e892e0477b6ca55ffd","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        source_type \u003d cleaned_data.get(\u0027source_type\u0027)"},{"line_number":243,"context_line":"        if source_type in (\u0027volume_image_id\u0027, \u0027volume_snapshot_id\u0027):"},{"line_number":244,"context_line":"            if available_volume \u003c count:"},{"line_number":245,"context_line":"                msg \u003d (_(\u0027The requested instance cannot be launched. \u0027"},{"line_number":246,"context_line":"                         \u0027Requested volume exceeds quota: Available: \u0027"},{"line_number":247,"context_line":"                         \u0027%(avail)s, Requested: %(req)s.\u0027)"},{"line_number":248,"context_line":"                       % {\u0027avail\u0027: available_volume, \u0027req\u0027: count})"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aa745d1_3f7efaae","line":245,"in_reply_to":"5aa745d1_1cdd8c14","updated":"2015-04-16 02:02:56.000000000","message":"Done","commit_id":"f5dd2ebbd03e32d5848e0d4404905171728db768"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"31e662a03a7e9c0d5b7aad77c9076d3ffc97e779","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        source_type \u003d cleaned_data.get(\u0027source_type\u0027)"},{"line_number":243,"context_line":"        if source_type in (\u0027volume_image_id\u0027, \u0027volume_snapshot_id\u0027):"},{"line_number":244,"context_line":"            if available_volume \u003c count:"},{"line_number":245,"context_line":"                msg \u003d (_(\u0027The requested instance cannot be launched. \u0027"},{"line_number":246,"context_line":"                         \u0027Requested volume exceeds quota: Available: \u0027"},{"line_number":247,"context_line":"                         \u0027%(avail)s, Requested: %(req)s.\u0027)"},{"line_number":248,"context_line":"                       % {\u0027avail\u0027: available_volume, \u0027req\u0027: count})"}],"source_content_type":"text/x-python","patch_set":7,"id":"5aa745d1_1cdd8c14","line":245,"in_reply_to":"5aa745d1_9213ca5c","updated":"2015-04-16 01:09:30.000000000","message":"or maybe it\u0027s better to move this before cores and ram quota check, then raise ValidationError just like instance count check. if count  exceeds quota, there\u0027s no need to do other checks.","commit_id":"f5dd2ebbd03e32d5848e0d4404905171728db768"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"210645d8c10279c18b9b9f021a33f5128350b225","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            if available_volume \u003c count:"},{"line_number":226,"context_line":"                msg \u003d (_(\u0027The requested instance cannot be launched. \u0027"},{"line_number":227,"context_line":"                         \u0027Requested volume exceeds quota: Available: \u0027"},{"line_number":228,"context_line":"                         \u0027%(avail)s, Requested: %(req)s.\u0027)"},{"line_number":229,"context_line":"                       % {\u0027avail\u0027: available_volume, \u0027req\u0027: count})"},{"line_number":230,"context_line":"                raise forms.ValidationError(msg)"},{"line_number":231,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5aa745d1_9a22bcb8","line":228,"updated":"2015-04-16 03:39:15.000000000","message":"Should this be  %(..)i  like above?","commit_id":"491a93ea0c0130d6bd029338150dfd3ef46aa7d1"}]}
