)]}'
{"openstack_dashboard/api/lbaas.py":[{"author":{"_account_id":6638,"name":"Bradley Jones","email":"jones.bradley@me.com","username":"bradjones"},"change_message_id":"cf8ccc0cb528e9bd9845c9a3f7bd52e13bb0af24","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def __init__(self, apiresource):"},{"line_number":49,"context_line":"        apiresource[\u0027admin_state\u0027] \u003d \\"},{"line_number":50,"context_line":"            \u0027UP\u0027 if apiresource[u\u0027admin_state_up\u0027] else \u0027DOWN\u0027"},{"line_number":51,"context_line":"        super(Member, self).__init__(apiresource)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_a55e8874","line":50,"updated":"2015-03-26 13:51:28.000000000","message":"Why is this marked as a unicode string?","commit_id":"4afaae58447bec34fc2c7c7183a5283b2f398525"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"37a1adfd3e65b0daf7cb3071a6e44fa356b59d2d","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def __init__(self, apiresource):"},{"line_number":49,"context_line":"        apiresource[\u0027admin_state\u0027] \u003d \\"},{"line_number":50,"context_line":"            \u0027UP\u0027 if apiresource[u\u0027admin_state_up\u0027] else \u0027DOWN\u0027"},{"line_number":51,"context_line":"        super(Member, self).__init__(apiresource)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_9cad048b","line":50,"in_reply_to":"fa963961_a55e8874","updated":"2015-03-27 06:00:20.000000000","message":"good catch. suppose to be removed after some experiments.","commit_id":"4afaae58447bec34fc2c7c7183a5283b2f398525"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"9f0a4c2b9f530f1328a0e2ca9f2caa0877a217e1","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"def member_update(request, member_id, **kwargs):"},{"line_number":350,"context_line":"    member \u003d neutronclient(request).update_member(member_id, kwargs)"},{"line_number":351,"context_line":"    return Member(member[\u0027member\u0027])"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"def member_delete(request, mem_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_c840830a","line":351,"updated":"2015-03-26 14:05:11.000000000","message":"Slightly confused about this change? Couldn\u0027t see anything in the commit message about it.","commit_id":"4afaae58447bec34fc2c7c7183a5283b2f398525"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"20469ba8755a21ffad2f747e72af1e6c789c7ac3","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"def member_update(request, member_id, **kwargs):"},{"line_number":350,"context_line":"    member \u003d neutronclient(request).update_member(member_id, kwargs)"},{"line_number":351,"context_line":"    return Member(member[\u0027member\u0027])"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"def member_delete(request, mem_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_ed1d7567","line":351,"in_reply_to":"fa963961_9cf2a499","updated":"2015-03-27 09:31:26.000000000","message":"Understood, but this part of the bug fix isn\u0027t in the bug report or commit message...","commit_id":"4afaae58447bec34fc2c7c7183a5283b2f398525"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"37a1adfd3e65b0daf7cb3071a6e44fa356b59d2d","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"def member_update(request, member_id, **kwargs):"},{"line_number":350,"context_line":"    member \u003d neutronclient(request).update_member(member_id, kwargs)"},{"line_number":351,"context_line":"    return Member(member[\u0027member\u0027])"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"def member_delete(request, mem_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa963961_9cf2a499","line":351,"in_reply_to":"fa963961_c840830a","updated":"2015-03-27 06:00:20.000000000","message":"while constructing the Member instance, the list of values sent as dict from member list and create methods but from the update method the values are sent as dict of dict, which is causing the key error while updating the member. so this change will sends the values dict to avoid the keyerror.","commit_id":"4afaae58447bec34fc2c7c7183a5283b2f398525"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"3bede151f2fdfe5f79445a6c55f777a5a6a6c4cc","unresolved":false,"context_lines":[{"line_number":293,"context_line":""},{"line_number":294,"context_line":"def pool_health_monitor_update(request, monitor_id, **kwargs):"},{"line_number":295,"context_line":"    monitor \u003d neutronclient(request).update_health_monitor(monitor_id, kwargs)"},{"line_number":296,"context_line":"    return PoolMonitor(monitor[\u0027health_monitor\u0027])"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"def pool_health_monitor_delete(request, mon_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa963961_52176051","line":296,"updated":"2015-03-27 09:31:39.000000000","message":"This change still doesn\u0027t appear to have any reference in either the bug report or commit message. Looks like a separate bug to me.","commit_id":"78509ce8c90af7d8d3443d80c8e1484e6c309ce9"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"3bede151f2fdfe5f79445a6c55f777a5a6a6c4cc","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"def member_update(request, member_id, **kwargs):"},{"line_number":350,"context_line":"    member \u003d neutronclient(request).update_member(member_id, kwargs)"},{"line_number":351,"context_line":"    return Member(member[\u0027member\u0027])"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"def member_delete(request, mem_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa963961_120af826","line":351,"updated":"2015-03-27 09:31:39.000000000","message":"Ditto","commit_id":"78509ce8c90af7d8d3443d80c8e1484e6c309ce9"},{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"f3b1d08fd6d790ab03ebd4d31fafdcb4a15e37c4","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        if \u0027provider\u0027 not in apiresource:"},{"line_number":39,"context_line":"            apiresource[\u0027provider\u0027] \u003d None"},{"line_number":40,"context_line":"        apiresource[\u0027admin_state\u0027] \u003d \\"},{"line_number":41,"context_line":"            \u0027UP\u0027 if apiresource[\u0027admin_state_up\u0027] else \u0027DOWN\u0027"},{"line_number":42,"context_line":"        super(Pool, self).__init__(apiresource)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_dfb93b30","line":41,"updated":"2015-04-02 07:47:00.000000000","message":"The code looks fine. Just to clarify something, I am not aware of the full Neutron API, but is \u0027admin_state_up\u0027 present in all supported versions of Neutron API? This is in the context of backward compatibility. Just asking. Not a bug or so. If however admin_state_up is been introduced in some later versions, `apiresource[\u0027admin_state_up\u0027]` will throw KeyError.","commit_id":"d1eb4772d76413d1ef7229f1441ded7700ebc106"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"3c279dbac6e4aaba7414941f9721576923cd04cb","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        if \u0027provider\u0027 not in apiresource:"},{"line_number":39,"context_line":"            apiresource[\u0027provider\u0027] \u003d None"},{"line_number":40,"context_line":"        apiresource[\u0027admin_state\u0027] \u003d \\"},{"line_number":41,"context_line":"            \u0027UP\u0027 if apiresource[\u0027admin_state_up\u0027] else \u0027DOWN\u0027"},{"line_number":42,"context_line":"        super(Pool, self).__init__(apiresource)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa53dc9_415209df","line":41,"in_reply_to":"baa041b7_dfb93b30","updated":"2015-04-06 16:33:52.000000000","message":"looks like duplicated code, should we move this to a mixin?","commit_id":"d1eb4772d76413d1ef7229f1441ded7700ebc106"}],"openstack_dashboard/dashboards/project/loadbalancers/tables.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"d2544d5d4844d86bdd0b462628146adc848634c1","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"ADMIN_STATE_DISPLAY_CHOICES \u003d ("},{"line_number":315,"context_line":"    (\"UP\", pgettext_lazy(\"Admin state of a Firewall\", u\"UP\")),"},{"line_number":316,"context_line":"    (\"DOWN\", pgettext_lazy(\"Admin state of a Firewall\", u\"DOWN\")),"},{"line_number":317,"context_line":")"},{"line_number":318,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_a5776139","line":315,"updated":"2015-03-31 07:34:45.000000000","message":"Firewall?","commit_id":"78509ce8c90af7d8d3443d80c8e1484e6c309ce9"}]}
