)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"38fd38eb57327cbbe29a4a0890dee9b0b647060b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"It needs page reload to update the row."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"In this patch, the added Update row class"},{"line_number":18,"context_line":"will reload a row after the status change."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I45e3e52e72ac3cadbdcf58ea540281ba126d9b49"},{"line_number":21,"context_line":"Closes-Bug: #1438088"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da9b358b_6c5a8785","line":18,"updated":"2015-03-30 13:23:22.000000000","message":"nit: You don\u0027t need to wrap the lines of the commit body so aggressively, makes it more difficult to read. Only the title has the 50 line restriction.","commit_id":"747ee75b6670862bb1dfe55037a5d614662ed787"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"0aa9b5b4e52bf9ebe0f0c309216ad847af9cb617","unresolved":false,"context_lines":[{"line_number":15,"context_line":"It needs page reload to update the row."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"In this patch, the added Update row class"},{"line_number":18,"context_line":"will reload a row after the status change."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I45e3e52e72ac3cadbdcf58ea540281ba126d9b49"},{"line_number":21,"context_line":"Closes-Bug: #1438088"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da9b358b_fb4038a7","line":18,"in_reply_to":"da9b358b_6c5a8785","updated":"2015-04-01 09:31:56.000000000","message":"Done","commit_id":"747ee75b6670862bb1dfe55037a5d614662ed787"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"55eb41274d105d3d5e9cc53e9051326b6f55e41c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In vpn table, after creating a vpn the row should be updated"},{"line_number":10,"context_line":"whenever the status of the vpn changes. but it is not and it get"},{"line_number":11,"context_line":"struck in the pending_create status."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"It needs page reload to update the row."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a1a9d01_309fd051","line":11,"updated":"2015-10-05 13:29:52.000000000","message":"typo: \"struck\" --\u003e \"stuck\"","commit_id":"c42c2fcb1c919c7331326708ac9ef04390e93083"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"d01a4791acd530c3ac35295af7864cfbf1782395","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"It needs page reload to update the row."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"In this patch, the added Update row class will reload a row after the status change."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I45e3e52e72ac3cadbdcf58ea540281ba126d9b49"},{"line_number":18,"context_line":"Closes-Bug: #1438088"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a740942_9fe2152e","line":15,"updated":"2015-12-08 08:16:30.000000000","message":"a line is over 72 letters.","commit_id":"33b619b60196e04a5d4473071ba7a7c596ea8d55"}],"openstack_dashboard/dashboards/project/vpn/tables.py":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"38fd38eb57327cbbe29a4a0890dee9b0b647060b","unresolved":false,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"STATUS_DISPLAY_CHOICES \u003d ("},{"line_number":232,"context_line":"    (\"Active\", pgettext_lazy(\"Current status of a VPN Service\","},{"line_number":233,"context_line":"                             u\"Active\")),"},{"line_number":234,"context_line":"    (\"Down\", pgettext_lazy(\"Current status of a VPN Service\","},{"line_number":235,"context_line":"                           u\"Down\")),"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_cc2cf3ad","line":232,"updated":"2015-03-30 13:23:22.000000000","message":"I suppose the aim here was to reuse the STATUS_DISPLAY_CHOICES, but this seems to be incorrect. Should be \u0027... of an IPSec Site Connection\u0027","commit_id":"747ee75b6670862bb1dfe55037a5d614662ed787"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"0aa9b5b4e52bf9ebe0f0c309216ad847af9cb617","unresolved":false,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"STATUS_DISPLAY_CHOICES \u003d ("},{"line_number":232,"context_line":"    (\"Active\", pgettext_lazy(\"Current status of a VPN Service\","},{"line_number":233,"context_line":"                             u\"Active\")),"},{"line_number":234,"context_line":"    (\"Down\", pgettext_lazy(\"Current status of a VPN Service\","},{"line_number":235,"context_line":"                           u\"Down\")),"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_5b8cc434","line":232,"in_reply_to":"da9b358b_cc2cf3ad","updated":"2015-04-01 09:31:56.000000000","message":"Done","commit_id":"747ee75b6670862bb1dfe55037a5d614662ed787"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"38fd38eb57327cbbe29a4a0890dee9b0b647060b","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                            u\"Error\")),"},{"line_number":238,"context_line":"    (\"Created\", pgettext_lazy(\"Current status of a VPN Service\","},{"line_number":239,"context_line":"                              u\"Created\")),"},{"line_number":240,"context_line":"    (\"Pending_Create\", pgettext_lazy(\"Current status of a VPN Service\","},{"line_number":241,"context_line":"                                     u\"Pending Create\")),"},{"line_number":242,"context_line":"    (\"Pending_Update\", pgettext_lazy(\"Current status of a VPN Service\","},{"line_number":243,"context_line":"                                     u\"Pending Update\")),"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_97d5d844","line":240,"updated":"2015-03-30 13:23:22.000000000","message":"Is this case sensitive? From looking at the APIs, it is always listed as \"PENDING_CREATE\" etc.","commit_id":"747ee75b6670862bb1dfe55037a5d614662ed787"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"0aa9b5b4e52bf9ebe0f0c309216ad847af9cb617","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                            u\"Error\")),"},{"line_number":238,"context_line":"    (\"Created\", pgettext_lazy(\"Current status of a VPN Service\","},{"line_number":239,"context_line":"                              u\"Created\")),"},{"line_number":240,"context_line":"    (\"Pending_Create\", pgettext_lazy(\"Current status of a VPN Service\","},{"line_number":241,"context_line":"                                     u\"Pending Create\")),"},{"line_number":242,"context_line":"    (\"Pending_Update\", pgettext_lazy(\"Current status of a VPN Service\","},{"line_number":243,"context_line":"                                     u\"Pending Update\")),"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9b358b_3b36a052","line":240,"in_reply_to":"da9b358b_97d5d844","updated":"2015-04-01 09:31:56.000000000","message":"no. from vpn service they are setting in caps as  \"PENDING_CREATE\" etc.","commit_id":"747ee75b6670862bb1dfe55037a5d614662ed787"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"55eb41274d105d3d5e9cc53e9051326b6f55e41c","unresolved":false,"context_lines":[{"line_number":259,"context_line":"    (\"Created\", True),"},{"line_number":260,"context_line":"    (\"Error\", False),"},{"line_number":261,"context_line":"    (\"Inactive\", False),"},{"line_number":262,"context_line":")"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"STATUS_DISPLAY_CHOICES \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_b050c00b","line":262,"updated":"2015-10-05 13:29:52.000000000","message":"These status choices do not need to be capitalized.  When these values are being compared later on, lower() is being used to compare them.  It has been decided that these statuses should all be lowercase, thus eliminating the need for the extra call to the lower() method later on.  In fact, I have a patch that looks to refactor some of these code blocks here: https://review.openstack.org/#/c/226579/4\n\nExample of all lowercase here: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/images/images/tables.py#L277","commit_id":"c42c2fcb1c919c7331326708ac9ef04390e93083"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"55eb41274d105d3d5e9cc53e9051326b6f55e41c","unresolved":false,"context_lines":[{"line_number":287,"context_line":"    (\"Inactive\", pgettext_lazy(\"Current status of an IPSec Site Connection \\"},{"line_number":288,"context_line":"                               and VPN Service\","},{"line_number":289,"context_line":"                               u\"Inactive\")),"},{"line_number":290,"context_line":")"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"class UpdateIPSecSiteConnectionRow(tables.Row):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a1a9d01_f0b95816","line":290,"updated":"2015-10-05 13:29:52.000000000","message":"The same idea applies to all of the display statuses here.  However, only the first value of each tuple should be lower-cased.  The actual value to be displayed should stay uppercase because that is what we want to see. ;)","commit_id":"c42c2fcb1c919c7331326708ac9ef04390e93083"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"d01a4791acd530c3ac35295af7864cfbf1782395","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"STATUS_DISPLAY_CHOICES \u003d ("},{"line_number":266,"context_line":"    (\"active\", pgettext_lazy(\"Current status of an IPSec Site Connection \\"},{"line_number":267,"context_line":"                             and VPN Service\","},{"line_number":268,"context_line":"                             u\"Active\")),"},{"line_number":269,"context_line":"    (\"down\", pgettext_lazy(\"Current status of an IPSec Site Connection \\"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_1f7f0567","line":266,"updated":"2015-12-08 08:16:30.000000000","message":"In OpenStack, the usage of backslashes is discouraged.\nCan you use below ?\n\n(\"active\", pgettext_lazy(\"Current status of an IPSec Site Connection\"\n                         \" and VPN Service\",\n                         u\"Active\")),","commit_id":"33b619b60196e04a5d4473071ba7a7c596ea8d55"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"0192fa454dfde7589e929002c5e348394aa0bec5","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            conn.ikepolicy_name \u003d conn[\u0027ikepolicy\u0027][\u0027name\u0027]"},{"line_number":295,"context_line":"            conn.ipsecpolicy_name \u003d conn[\u0027ipsecpolicy\u0027][\u0027name\u0027]"},{"line_number":296,"context_line":"            conn.vpnservice_name \u003d conn[\u0027vpnservice\u0027][\u0027name\u0027]"},{"line_number":297,"context_line":"        except Exception:"},{"line_number":298,"context_line":"            conn.ikepolicy_name \u003d conn[\u0027ikepolicy_id\u0027]"},{"line_number":299,"context_line":"            conn.ipsecpolicy_name \u003d conn[\u0027ipsecpolicy_id\u0027]"},{"line_number":300,"context_line":"            conn.vpnservice_name \u003d conn[\u0027vpnservice_id\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_aa3254a5","line":297,"updated":"2015-12-11 15:12:53.000000000","message":"could we log something here?","commit_id":"182e2bef9e2df64ad799454709f810b8d08a0bda"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"9c31d767755d7320c45731f8d6dba8b34243a967","unresolved":false,"context_lines":[{"line_number":294,"context_line":"            conn.ikepolicy_name \u003d conn[\u0027ikepolicy\u0027][\u0027name\u0027]"},{"line_number":295,"context_line":"            conn.ipsecpolicy_name \u003d conn[\u0027ipsecpolicy\u0027][\u0027name\u0027]"},{"line_number":296,"context_line":"            conn.vpnservice_name \u003d conn[\u0027vpnservice\u0027][\u0027name\u0027]"},{"line_number":297,"context_line":"        except Exception:"},{"line_number":298,"context_line":"            conn.ikepolicy_name \u003d conn[\u0027ikepolicy_id\u0027]"},{"line_number":299,"context_line":"            conn.ipsecpolicy_name \u003d conn[\u0027ipsecpolicy_id\u0027]"},{"line_number":300,"context_line":"            conn.vpnservice_name \u003d conn[\u0027vpnservice_id\u0027]"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_4ceab0dc","line":297,"in_reply_to":"7a740942_aa3254a5","updated":"2015-12-14 08:14:40.000000000","message":"In other tables also, it is not displaying any log message for partial failures.","commit_id":"182e2bef9e2df64ad799454709f810b8d08a0bda"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"0192fa454dfde7589e929002c5e348394aa0bec5","unresolved":false,"context_lines":[{"line_number":345,"context_line":"        try:"},{"line_number":346,"context_line":"            vpn.router_name \u003d vpn[\u0027router\u0027][\u0027name\u0027]"},{"line_number":347,"context_line":"            vpn.subnet_name \u003d vpn[\u0027subnet\u0027][\u0027cidr\u0027]"},{"line_number":348,"context_line":"        except Exception:"},{"line_number":349,"context_line":"            vpn.router_name \u003d vpn[\u0027router_id\u0027]"},{"line_number":350,"context_line":"            vpn.subnet_name \u003d vpn[\u0027subnet_id\u0027]"},{"line_number":351,"context_line":"        return vpn"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_ca0000ae","line":348,"updated":"2015-12-11 15:12:53.000000000","message":"could we log something here","commit_id":"182e2bef9e2df64ad799454709f810b8d08a0bda"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"320fb5e270f6529a4eed1d554f488b3726421609","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            conn.ikepolicy_name \u003d conn[\u0027ikepolicy\u0027][\u0027name\u0027]"},{"line_number":300,"context_line":"            conn.ipsecpolicy_name \u003d conn[\u0027ipsecpolicy\u0027][\u0027name\u0027]"},{"line_number":301,"context_line":"            conn.vpnservice_name \u003d conn[\u0027vpnservice\u0027][\u0027name\u0027]"},{"line_number":302,"context_line":"        except Exception:"},{"line_number":303,"context_line":"            LOG.info(\"Not able to get the name of the vpn service\")"},{"line_number":304,"context_line":"            conn.ikepolicy_name \u003d conn[\u0027ikepolicy_id\u0027]"},{"line_number":305,"context_line":"            conn.ipsecpolicy_name \u003d conn[\u0027ipsecpolicy_id\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a061dce_38f3730c","line":302,"updated":"2016-04-04 14:07:50.000000000","message":"Why a try/except? Seems like it would be better to just use a get with the default as the id value. In this instance for example, if ikepolicy is missing a name, wouldnt all three names be set to the ID? Also the logs would get very busy very quickly due to polling, which may not be desirable.","commit_id":"78d3ae2fc07c01ff6b897055327bfa623a5a6fd7"},{"author":{"_account_id":14151,"name":"ziyu032","email":"chen.qiaomin@99cloud.net","username":"ziyu032"},"change_message_id":"ccb7a7c81fdd7efce57f138aee9afa07402cc5e8","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            conn.ikepolicy_name \u003d conn[\u0027ikepolicy\u0027][\u0027name\u0027]"},{"line_number":300,"context_line":"            conn.ipsecpolicy_name \u003d conn[\u0027ipsecpolicy\u0027][\u0027name\u0027]"},{"line_number":301,"context_line":"            conn.vpnservice_name \u003d conn[\u0027vpnservice\u0027][\u0027name\u0027]"},{"line_number":302,"context_line":"        except Exception:"},{"line_number":303,"context_line":"            LOG.info(\"Not able to get the name of the vpn service\")"},{"line_number":304,"context_line":"            conn.ikepolicy_name \u003d conn[\u0027ikepolicy_id\u0027]"},{"line_number":305,"context_line":"            conn.ipsecpolicy_name \u003d conn[\u0027ipsecpolicy_id\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a061dce_c549988d","line":302,"in_reply_to":"9a061dce_38f3730c","updated":"2016-04-04 23:55:47.000000000","message":"+1","commit_id":"78d3ae2fc07c01ff6b897055327bfa623a5a6fd7"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"f73f0698706424b26f067b0568c0bda652f4d286","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            conn.ikepolicy_name \u003d conn[\u0027ikepolicy\u0027][\u0027name\u0027]"},{"line_number":300,"context_line":"            conn.ipsecpolicy_name \u003d conn[\u0027ipsecpolicy\u0027][\u0027name\u0027]"},{"line_number":301,"context_line":"            conn.vpnservice_name \u003d conn[\u0027vpnservice\u0027][\u0027name\u0027]"},{"line_number":302,"context_line":"        except Exception:"},{"line_number":303,"context_line":"            LOG.info(\"Not able to get the name of the vpn service\")"},{"line_number":304,"context_line":"            conn.ikepolicy_name \u003d conn[\u0027ikepolicy_id\u0027]"},{"line_number":305,"context_line":"            conn.ipsecpolicy_name \u003d conn[\u0027ipsecpolicy_id\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"bab6814e_2b3da0bb","line":302,"in_reply_to":"9a061dce_38f3730c","updated":"2016-05-19 13:04:13.000000000","message":"Done","commit_id":"78d3ae2fc07c01ff6b897055327bfa623a5a6fd7"}]}
