)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"9bfe05ee2f540efe3c2e222219fa5703e14329d0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Image Detail Redesign (Angular/UX)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Image Detail UX redesign, implemented in AngularJS."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partially Implements: blueprint instance-details-redesign"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I9882970b40b52a402e5693f6993f1b50c0a819f6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"5aa745d1_6a65c243","line":10,"updated":"2015-04-16 16:12:38.000000000","message":"Can we also put a link to the mockups in the commit message for ease of reference?\n\nhttp://invis.io/962Q35HVQ","commit_id":"d25e52376176b60e597d6358795c541857acff80"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"00ca442b1c1ead755724a7281e140fc80e6c36c3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Image Detail Redesign (Angular/UX)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Image Detail UX redesign, implemented in AngularJS."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partially Implements: blueprint instance-details-redesign"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I9882970b40b52a402e5693f6993f1b50c0a819f6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"5aa745d1_ed79ec30","line":10,"in_reply_to":"5aa745d1_6a65c243","updated":"2015-04-16 16:28:45.000000000","message":"Also, we should be clear how much of the mock this patch implements and how much subsequent patches will implement. Because we don\u0027t want to have to implement everything in the first patch unless it is a regression in functionality.","commit_id":"d25e52376176b60e597d6358795c541857acff80"}],"horizon/static/angular/action-list/menu-item-batch.html":[{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"758d27408631c37539b336b6f101171f85040508","unresolved":false,"context_lines":[{"line_number":5,"context_line":" id\u003d\"{$ itemId $}\""},{"line_number":6,"context_line":" help_text\u003d\"{$ helpText $}\""},{"line_number":7,"context_line":" name\u003d\"action\" value\u003d\"{$ ariaValue $}\""},{"line_number":8,"context_line":" type\u003d\"submit\"\u003e???\u003c/button\u003e"},{"line_number":9,"context_line":"\u003c/li\u003e"},{"line_number":10,"context_line":"\u003c!--"},{"line_number":11,"context_line":"  \u003ca href\u003d\"#\" role\u003d\"menuitem\" dropdown-toggle"}],"source_content_type":"text/html","patch_set":22,"id":"3ab451fb_1a445872","line":8,"range":{"start_line":8,"start_character":16,"end_line":8,"end_character":20},"updated":"2015-04-17 14:30:07.000000000","message":"What does this mean?","commit_id":"d9e4bd1d3c9e3859d0c7a059c2d708209c9e9b12"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"758d27408631c37539b336b6f101171f85040508","unresolved":false,"context_lines":[{"line_number":7,"context_line":" name\u003d\"action\" value\u003d\"{$ ariaValue $}\""},{"line_number":8,"context_line":" type\u003d\"submit\"\u003e???\u003c/button\u003e"},{"line_number":9,"context_line":"\u003c/li\u003e"},{"line_number":10,"context_line":"\u003c!--"},{"line_number":11,"context_line":"  \u003ca href\u003d\"#\" role\u003d\"menuitem\" dropdown-toggle"},{"line_number":12,"context_line":"    data-batch-action\u003d\"true\""},{"line_number":13,"context_line":"    help_text\u003d\"{$ helpText $}\""}],"source_content_type":"text/html","patch_set":22,"id":"3ab451fb_ba2204b8","line":10,"updated":"2015-04-17 14:30:07.000000000","message":"Is the commented code really needed here?","commit_id":"d9e4bd1d3c9e3859d0c7a059c2d708209c9e9b12"}],"horizon/static/angular/action-list/split-button-aria.html":[{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"758d27408631c37539b336b6f101171f85040508","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  ng-disabled\u003d\"disabled\""},{"line_number":7,"context_line":"  aria-expanded\u003d\"false\"\u003e"},{"line_number":8,"context_line":"  \u003cspan class\u003d\"caret\"\u003e\u003c/span\u003e"},{"line_number":9,"context_line":"  \u003cspan class\u003d\"sr-only\"\u003eToggle Dropdown\u003c/span\u003e"},{"line_number":10,"context_line":"\u003c/button\u003e"}],"source_content_type":"text/html","patch_set":22,"id":"3ab451fb_e090de97","line":9,"updated":"2015-04-17 14:30:07.000000000","message":"All string literals should be wrapped with i18n.","commit_id":"d9e4bd1d3c9e3859d0c7a059c2d708209c9e9b12"}],"horizon/static/framework/widgets/action-list/menu-item-batch.html":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"00b78cb0f80cd9422c953a622fbe8f3c915f2c63","unresolved":false,"context_lines":[{"line_number":5,"context_line":" id\u003d\"{$ itemId $}\""},{"line_number":6,"context_line":" help_text\u003d\"{$ helpText $}\""},{"line_number":7,"context_line":" name\u003d\"action\" value\u003d\"{$ ariaValue $}\""},{"line_number":8,"context_line":" type\u003d\"submit\"\u003e???\u003c/button\u003e"},{"line_number":9,"context_line":"\u003c/li\u003e"},{"line_number":10,"context_line":"\u003c!--"},{"line_number":11,"context_line":"  \u003ca href\u003d\"#\" role\u003d\"menuitem\" dropdown-toggle"}],"source_content_type":"text/html","patch_set":30,"id":"fa32b979_95047618","line":8,"updated":"2015-06-16 21:37:40.000000000","message":"Should we use a better default value?","commit_id":"e5abe185c3e03593530927ddd349bcf601716fd9"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8556929c8289f2e6288f68bdc14ddcb56b47863e","unresolved":false,"context_lines":[{"line_number":5,"context_line":" id\u003d\"{$ itemId $}\""},{"line_number":6,"context_line":" help_text\u003d\"{$ helpText $}\""},{"line_number":7,"context_line":" name\u003d\"action\" value\u003d\"{$ ariaValue $}\""},{"line_number":8,"context_line":" type\u003d\"submit\"\u003e???\u003c/button\u003e"},{"line_number":9,"context_line":"\u003c/li\u003e"},{"line_number":10,"context_line":"\u003c!--"},{"line_number":11,"context_line":"  \u003ca href\u003d\"#\" role\u003d\"menuitem\" dropdown-toggle"}],"source_content_type":"text/html","patch_set":30,"id":"fa32b979_b46055a6","line":8,"in_reply_to":"fa32b979_95047618","updated":"2015-06-29 15:54:22.000000000","message":"This really should all be written and submitted as a different patch, in my view.","commit_id":"e5abe185c3e03593530927ddd349bcf601716fd9"}],"horizon/static/framework/widgets/action-list/split-button-aria.html":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"00b78cb0f80cd9422c953a622fbe8f3c915f2c63","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  ng-class\u003d\"actionClasses\""},{"line_number":6,"context_line":"  ng-disabled\u003d\"disabled\""},{"line_number":7,"context_line":"  aria-expanded\u003d\"false\"\u003e"},{"line_number":8,"context_line":"  \u003cspan class\u003d\"caret\"\u003e\u003c/span\u003e"},{"line_number":9,"context_line":"  \u003cspan class\u003d\"sr-only\"\u003eToggle Dropdown\u003c/span\u003e"},{"line_number":10,"context_line":"\u003c/button\u003e"}],"source_content_type":"text/html","patch_set":30,"id":"fa32b979_f83939d8","line":8,"updated":"2015-06-16 21:37:40.000000000","message":"Can we use \u003cspan class\u003d\"fa fa-caret-down\u0027\u003e\u003c/span\u003e here instead?  \"caret\" tends to not  be dynamic enough if the font-base value is changed.","commit_id":"e5abe185c3e03593530927ddd349bcf601716fd9"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8556929c8289f2e6288f68bdc14ddcb56b47863e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  ng-class\u003d\"actionClasses\""},{"line_number":6,"context_line":"  ng-disabled\u003d\"disabled\""},{"line_number":7,"context_line":"  aria-expanded\u003d\"false\"\u003e"},{"line_number":8,"context_line":"  \u003cspan class\u003d\"caret\"\u003e\u003c/span\u003e"},{"line_number":9,"context_line":"  \u003cspan class\u003d\"sr-only\"\u003eToggle Dropdown\u003c/span\u003e"},{"line_number":10,"context_line":"\u003c/button\u003e"}],"source_content_type":"text/html","patch_set":30,"id":"fa32b979_f46a5d80","line":8,"in_reply_to":"fa32b979_f83939d8","updated":"2015-06-29 15:54:22.000000000","message":"Sounds good!","commit_id":"e5abe185c3e03593530927ddd349bcf601716fd9"}],"horizon/static/framework/widgets/headers/hz-page-header.html":[{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"72f6309b49e1b5ebcbf46a8e23f930009d7626f9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\u0027page-header\u0027\u003e"},{"line_number":2,"context_line":"  \u003ch1\u003e{$ header $}\u003c/h1\u003e"},{"line_number":3,"context_line":"  \u003cp\u003e{$ description $}\u003c/p\u003e"},{"line_number":4,"context_line":"  \u003cng-transclude\u003e\u003c/ng-transclude\u003e"},{"line_number":5,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":106,"id":"3a29b11f_4d166856","line":2,"updated":"2015-10-20 20:26:19.000000000","message":"Please use one-time binding for both header and description, unless they are going to change dynamically.","commit_id":"8f4cebd7ab54c81b49269c8206b28c90a89984f0"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"964b4ad01d6e36d1f42408caff767b872293bf0f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\u0027page-header\u0027\u003e"},{"line_number":2,"context_line":"  \u003ch1\u003e{$ header $}\u003c/h1\u003e"},{"line_number":3,"context_line":"  \u003cp\u003e{$ description $}\u003c/p\u003e"},{"line_number":4,"context_line":"  \u003cng-transclude\u003e\u003c/ng-transclude\u003e"},{"line_number":5,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":106,"id":"3a29b11f_9e1b441b","line":2,"in_reply_to":"3a29b11f_4d166856","updated":"2015-10-20 21:23:57.000000000","message":"In this particular they are going to change.\n\nAlthough, while I was trying to test it I noticed some odd irregularities in the implementation.\nI\u0027ve removed using the hz-page-header directive as it\u0027s mostly semantic and doesn\u0027t seem to work well.\n\nI\u0027m adding the elements inline in the view.","commit_id":"8f4cebd7ab54c81b49269c8206b28c90a89984f0"}],"openstack_dashboard/dashboards/project/images/images/views.py":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"00b78cb0f80cd9422c953a622fbe8f3c915f2c63","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from horizon import exceptions"},{"line_number":27,"context_line":"from horizon import forms"},{"line_number":28,"context_line":"from horizon.utils import memoized"},{"line_number":29,"context_line":"from horizon import views"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from openstack_dashboard import api"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"fa32b979_387fa167","line":29,"updated":"2015-06-16 21:37:40.000000000","message":"Should we strive to keep the import order alphabetical?  If so, it should go above.","commit_id":"e5abe185c3e03593530927ddd349bcf601716fd9"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8556929c8289f2e6288f68bdc14ddcb56b47863e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from horizon import exceptions"},{"line_number":27,"context_line":"from horizon import forms"},{"line_number":28,"context_line":"from horizon.utils import memoized"},{"line_number":29,"context_line":"from horizon import views"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from openstack_dashboard import api"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"fa32b979_f401fdaf","line":29,"in_reply_to":"fa32b979_387fa167","updated":"2015-06-29 15:54:22.000000000","message":"Yeah...surprised pep8 didn\u0027t carp.  Maybe it did.","commit_id":"e5abe185c3e03593530927ddd349bcf601716fd9"}],"openstack_dashboard/dashboards/project/images/templates/images/images/detail.html":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"00b78cb0f80cd9422c953a622fbe8f3c915f2c63","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block main %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  \u003cng-include src\u003d\"\u0027/static/dashboard/image/image-detail.html\u0027\"\u003e\u003c/ng-include\u003e"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":30,"id":"fa32b979_b8e2d12d","line":6,"updated":"2015-06-16 21:37:40.000000000","message":"Should this be STATIC_URL because it lives within a Django template?","commit_id":"e5abe185c3e03593530927ddd349bcf601716fd9"}],"openstack_dashboard/dashboards/project/ngimages/templates/ngimages/index.html":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f7a85ec4f5ba433f732e714461cf83f081420002","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Images\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"{% endblock page_header %}"}],"source_content_type":"text/html","patch_set":56,"id":"3a50d1a3_90958f89","line":3,"updated":"2015-07-31 14:59:18.000000000","message":"This block can entirely go away.","commit_id":"2d7da9fcd5c651077aaeb8342f125f501b0aa66b"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"35c07fa3523e898dbbb8d0b984fc118cc26e843c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Images\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"{% endblock page_header %}"}],"source_content_type":"text/html","patch_set":56,"id":"1a4dcd0f_6c52b015","line":3,"in_reply_to":"3a50d1a3_90958f89","updated":"2015-08-03 23:09:20.000000000","message":"This removes the title for the page.","commit_id":"2d7da9fcd5c651077aaeb8342f125f501b0aa66b"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f7a85ec4f5ba433f732e714461cf83f081420002","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Images\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"{% endblock page_header %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block main %}"},{"line_number":9,"context_line":"  \u003cdiv ng-view\u003e\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":56,"id":"3a50d1a3_708a4366","line":6,"updated":"2015-07-31 14:59:18.000000000","message":"I suspect this block may be able to go away as well.","commit_id":"2d7da9fcd5c651077aaeb8342f125f501b0aa66b"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f8f1cecc93d9222382925307f66de83628513340","unresolved":false,"context_lines":[{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}\t\t"},{"line_number":6,"context_line":"  \u003chz-page-header header\u003d\"\u0027Image Details\u0027\"\u003e\u003c/hz-page-header\u003e\t\t"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""}],"source_content_type":"text/html","patch_set":71,"id":"1a4dcd0f_fa2dd3fd","line":5,"updated":"2015-08-10 20:54:58.000000000","message":"Remove trailing whitespace.","commit_id":"fc85d1cc4cf3132b9def6abc94fef8878a6164f3"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f8f1cecc93d9222382925307f66de83628513340","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}\t\t"},{"line_number":6,"context_line":"  \u003chz-page-header header\u003d\"\u0027Image Details\u0027\"\u003e\u003c/hz-page-header\u003e\t\t"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":71,"id":"1a4dcd0f_7a3a2336","line":6,"updated":"2015-08-10 20:54:58.000000000","message":"Remove trailing whitespace.","commit_id":"fc85d1cc4cf3132b9def6abc94fef8878a6164f3"},{"author":{"_account_id":17004,"name":"KBrown","email":"kbrown@thoughtworks.com","username":"kbrown"},"change_message_id":"cd4c92f656ce25e24852ca297ce4a0e6d5f986b2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Images\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  \u003chz-page-header header\u003d\"\u0027{% trans \"Images\" %}\u0027\"\u003e\u003c/hz-page-header\u003e"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":95,"id":"9a1a9d01_17d6cb27","line":6,"updated":"2015-09-30 21:55:09.000000000","message":"I don\u0027t think you need this anymore. It\u0027s now included in the hz-header header","commit_id":"3b4a255f3299e926045c2ccc00e680a59d93de04"},{"author":{"_account_id":17327,"name":"Kyle Olivo","email":"keolivo@thoughtworks.com","username":"kyleolivo"},"change_message_id":"811ddb2a5ae9ac58b5c44fcb959fccec900c1238","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Images\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  \u003chz-page-header header\u003d\"\u0027{% trans \"Images\" %}\u0027\"\u003e\u003c/hz-page-header\u003e"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":95,"id":"9a1a9d01_c87644d8","line":6,"in_reply_to":"9a1a9d01_17d6cb27","updated":"2015-10-01 21:53:25.000000000","message":"Done","commit_id":"3b4a255f3299e926045c2ccc00e680a59d93de04"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"ea37286f6918508a2784d184f12575fcdc30027a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Images\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"{% endblock page_header %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block ng_route_base %}"}],"source_content_type":"text/html","patch_set":110,"id":"3a29b11f_6acb5573","line":5,"updated":"2015-10-26 14:01:43.000000000","message":"nit: you can remove this block altogether","commit_id":"693ab09e1ccd25a82b37b8c9878f0274830d0725"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"0cac7af3c7e8010746c91f0cc28c52ae2045c618","unresolved":false,"context_lines":[{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Images\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"{% endblock page_header %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block ng_route_base %}"}],"source_content_type":"text/html","patch_set":110,"id":"3a29b11f_64c70446","line":5,"in_reply_to":"3a29b11f_6acb5573","updated":"2015-10-26 17:39:55.000000000","message":"Done","commit_id":"693ab09e1ccd25a82b37b8c9878f0274830d0725"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"03940a6d8a4b94fa377c5fbd27b5ada4a3744281","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Images\" %}{% endblock %}"},{"line_number":4,"context_line":"{% block page_header %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block ng_route_base %}"},{"line_number":7,"context_line":"  \u003cbase href\u003d\"/project/ngimages/\"\u003e\u003c/base\u003e"}],"source_content_type":"text/html","patch_set":121,"id":"ba8a016a_0e144af3","line":4,"updated":"2015-11-16 18:54:14.000000000","message":"So we are intentionally blanking page_header out so that it can be populated by the contents of ng-view (which now includes the header). Is this correct?","commit_id":"654bc8d40a5c9b98d244310f0cef31a53925b488"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"db0033092952b55a9ddf2a76d98f5982e6c2c053","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Images\" %}{% endblock %}"},{"line_number":4,"context_line":"{% block page_header %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block ng_route_base %}"},{"line_number":7,"context_line":"  \u003cbase href\u003d\"/project/ngimages/\"\u003e\u003c/base\u003e"}],"source_content_type":"text/html","patch_set":121,"id":"ba8a016a_0c16244c","line":4,"in_reply_to":"ba8a016a_0e144af3","updated":"2015-11-18 14:36:11.000000000","message":"Yeah, because in this case the header is dynamic based on Angular work, which is not possible here because it\u0027s out of angular scope (no controller).","commit_id":"654bc8d40a5c9b98d244310f0cef31a53925b488"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"03940a6d8a4b94fa377c5fbd27b5ada4a3744281","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% block page_header %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block ng_route_base %}"},{"line_number":7,"context_line":"  \u003cbase href\u003d\"/project/ngimages/\"\u003e\u003c/base\u003e"},{"line_number":8,"context_line":"{% endblock %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":121,"id":"ba8a016a_4e31f2a1","line":7,"updated":"2015-11-16 18:54:14.000000000","message":"Is base a directive or just an element? I don\u0027t see it getting use anywhere else. Also, do we need an additional template block? what was the rationale behind it?","commit_id":"654bc8d40a5c9b98d244310f0cef31a53925b488"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"db0033092952b55a9ddf2a76d98f5982e6c2c053","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% block page_header %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block ng_route_base %}"},{"line_number":7,"context_line":"  \u003cbase href\u003d\"/project/ngimages/\"\u003e\u003c/base\u003e"},{"line_number":8,"context_line":"{% endblock %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":121,"id":"ba8a016a_ec5de015","line":7,"in_reply_to":"ba8a016a_4e31f2a1","updated":"2015-11-18 14:36:11.000000000","message":"This is a standard HTML tag that is used to direct the browser (and angular) about how it makes relative references.  Dan S. probably wrote this, so I\u0027d have to check as to the exact reasoning, but it does work well (check out how the breadcrumbs work).","commit_id":"654bc8d40a5c9b98d244310f0cef31a53925b488"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"90bbbe1d5c2d0614759b99d0d74fb20f38fea046","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% block page_header %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block ng_route_base %}"},{"line_number":7,"context_line":"  \u003cbase href\u003d\"/project/ngimages/\"\u003e\u003c/base\u003e"},{"line_number":8,"context_line":"{% endblock %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":132,"id":"3a7e1126_ce02710b","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":15},"updated":"2015-12-18 09:22:07.000000000","message":"We need \"{{ WEBROOT }}\"\ncf. https://bugs.launchpad.net/magnum-ui/+bug/1524193","commit_id":"2b92e9f507afb8d13380f119f0d1b34539bc879a"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"fb673701fa006b8b2fae6661500843e3a894cb36","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% block page_header %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block ng_route_base %}"},{"line_number":7,"context_line":"  \u003cbase href\u003d\"/project/ngimages/\"\u003e\u003c/base\u003e"},{"line_number":8,"context_line":"{% endblock %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":132,"id":"3a7e1126_abaed095","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":15},"in_reply_to":"3a7e1126_ce02710b","updated":"2015-12-18 21:09:08.000000000","message":"Done","commit_id":"2b92e9f507afb8d13380f119f0d1b34539bc879a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"ea17c0d578d58072b648f32fd6f13949ef21a9f0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"{% block page_header %}{% endblock %}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"{% block ng_route_base %}"},{"line_number":7,"context_line":"  \u003cbase href\u003d\"{{ WEBROOT }}project/ngimages/\"\u003e\u003c/base\u003e"},{"line_number":8,"context_line":"{% endblock %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":133,"id":"3a7e1126_8c6af17f","line":7,"updated":"2015-12-21 02:42:22.000000000","message":"This is weirdly out of place, with no explanation why it\u0027s necessary. I honestly don\u0027t know why it\u0027s here (though I do recognise that it\u0027s related to the routing issue I\u0027ve flagged elsewhere.)\n\nIt\u0027s *probably* related to keeping the Django actions working, but it\u0027s not explained here, and we\u0027ll need another way to make it work if we\u0027re to have ngRoute usable in any other panel in the interface...","commit_id":"a7bc17be9a60a5b8522cc2ddab574b3822e503fe"}],"openstack_dashboard/dashboards/project/ngimages/urls.py":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"1fd51f0935324c84f0bffb4adea55cd361ec2366","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"urlpatterns \u003d patterns("},{"line_number":22,"context_line":"    \u0027openstack_dashboard.dashboards.project.ngimages.views\u0027,"},{"line_number":23,"context_line":"    url(r\u0027^details/.*$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":24,"context_line":"    url(r\u0027^$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":25,"context_line":")"}],"source_content_type":"text/x-python","patch_set":101,"id":"7a2fa921_c1503c61","line":23,"updated":"2015-10-06 18:53:21.000000000","message":"how is this used / needed?   usually django looks up urls by name, and you have two with the same name, pointing to the same url, differ by url only.","commit_id":"520f48f31823609209a0ec15c2687187dd8a82bf"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"4ac6b69ed0d77e75a778e25f61d52b45f1752f53","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"urlpatterns \u003d patterns("},{"line_number":22,"context_line":"    \u0027openstack_dashboard.dashboards.project.ngimages.views\u0027,"},{"line_number":23,"context_line":"    url(r\u0027^details/.*$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":24,"context_line":"    url(r\u0027^$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":25,"context_line":")"}],"source_content_type":"text/x-python","patch_set":101,"id":"7a2fa921_44a51ab3","line":23,"in_reply_to":"7a2fa921_2119f088","updated":"2015-10-06 19:07:22.000000000","message":"the mapping itself I get / is fine.  It\u0027s just not setup correctly.  Call it name\u003d\u0027detail\u0027 and then you won\u0027t have the problem I am speaking of.","commit_id":"520f48f31823609209a0ec15c2687187dd8a82bf"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"04dc750301a068ec513d4d6ebd535dcf1bc4daaa","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"urlpatterns \u003d patterns("},{"line_number":22,"context_line":"    \u0027openstack_dashboard.dashboards.project.ngimages.views\u0027,"},{"line_number":23,"context_line":"    url(r\u0027^details/.*$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":24,"context_line":"    url(r\u0027^$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":25,"context_line":")"}],"source_content_type":"text/x-python","patch_set":101,"id":"7a2fa921_0821709f","line":23,"in_reply_to":"7a2fa921_44a51ab3","updated":"2015-10-12 15:16:15.000000000","message":"Done","commit_id":"520f48f31823609209a0ec15c2687187dd8a82bf"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"21ebdbc2933e0ee588ac0b57f1353c47a3c40808","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"urlpatterns \u003d patterns("},{"line_number":22,"context_line":"    \u0027openstack_dashboard.dashboards.project.ngimages.views\u0027,"},{"line_number":23,"context_line":"    url(r\u0027^details/.*$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":24,"context_line":"    url(r\u0027^$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":25,"context_line":")"}],"source_content_type":"text/x-python","patch_set":101,"id":"7a2fa921_2119f088","line":23,"in_reply_to":"7a2fa921_c1503c61","updated":"2015-10-06 18:57:06.000000000","message":"Django doesn\u0027t handle the routing between the detail and table. Angular does by using ng-route to alternate views. Though when you refresh the page using the browser, the browser goes to Django to ask for the page and if we don\u0027t have the mapping here, it\u0027ll return 404. Angular does take care of rendering the correct view based of the route.","commit_id":"520f48f31823609209a0ec15c2687187dd8a82bf"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"03940a6d8a4b94fa377c5fbd27b5ada4a3744281","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"urlpatterns \u003d patterns("},{"line_number":22,"context_line":"    \u0027openstack_dashboard.dashboards.project.ngimages.views\u0027,"},{"line_number":23,"context_line":"    url(r\u0027^details/.*$\u0027, views.IndexView.as_view(), name\u003d\u0027detail\u0027),"},{"line_number":24,"context_line":"    url(r\u0027^$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":25,"context_line":")"}],"source_content_type":"text/x-python","patch_set":121,"id":"ba8a016a_cee4020f","line":23,"updated":"2015-11-16 18:54:14.000000000","message":"This is required because you don\u0027t want Django to redirect you to a blank page when details/ in present in the URL? Can you modifying the index URL below to incorporate this instead?","commit_id":"654bc8d40a5c9b98d244310f0cef31a53925b488"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"db0033092952b55a9ddf2a76d98f5982e6c2c053","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"urlpatterns \u003d patterns("},{"line_number":22,"context_line":"    \u0027openstack_dashboard.dashboards.project.ngimages.views\u0027,"},{"line_number":23,"context_line":"    url(r\u0027^details/.*$\u0027, views.IndexView.as_view(), name\u003d\u0027detail\u0027),"},{"line_number":24,"context_line":"    url(r\u0027^$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":25,"context_line":")"}],"source_content_type":"text/x-python","patch_set":121,"id":"ba8a016a_ec5080d6","line":23,"in_reply_to":"ba8a016a_cee4020f","updated":"2015-11-18 14:36:11.000000000","message":"But this is adding a direction to go to the details page and not the table, so it\u0027s different; but most likely I\u0027m misunderstanding. :)","commit_id":"654bc8d40a5c9b98d244310f0cef31a53925b488"},{"author":{"_account_id":9647,"name":"Justin Pomeroy","email":"jpomero@linux.vnet.ibm.com","username":"jpomero"},"change_message_id":"f41098146d2ad1e9b873653afa89fb21bbf296f3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"urlpatterns \u003d patterns("},{"line_number":22,"context_line":"    \u0027openstack_dashboard.dashboards.project.ngimages.views\u0027,"},{"line_number":23,"context_line":"    url(r\u0027^details/.*$\u0027, views.IndexView.as_view(), name\u003d\u0027detail\u0027),"},{"line_number":24,"context_line":"    url(r\u0027^$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":25,"context_line":")"}],"source_content_type":"text/x-python","patch_set":122,"id":"ba8a016a_93f42c5b","line":24,"updated":"2015-11-19 15:58:10.000000000","message":"Adding django URL routing for all the child panels isn\u0027t technically necessary is it?  Since all the child panels will be routed using angular I think all you need is to change this line so all /project/ngimages/ urls point to the index page where angular routing will take over.\n\nurl(\u0027\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),","commit_id":"7c6e2962301fc40fe7f2b9f7ba24f01d3f2166ae"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3c13bbf59ded75775237b54b5785d21b31112711","unresolved":false,"context_lines":[{"line_number":21,"context_line":"urlpatterns \u003d patterns("},{"line_number":22,"context_line":"    \u0027openstack_dashboard.dashboards.project.ngimages.views\u0027,"},{"line_number":23,"context_line":"    url(r\u0027^details/.*$\u0027, views.IndexView.as_view(), name\u003d\u0027detail\u0027),"},{"line_number":24,"context_line":"    url(r\u0027^$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":25,"context_line":")"}],"source_content_type":"text/x-python","patch_set":122,"id":"ba8a016a_f17b2dbc","line":24,"in_reply_to":"ba8a016a_93f42c5b","updated":"2015-11-19 16:47:13.000000000","message":"Ah, OK, I\u0027ll take a look.","commit_id":"7c6e2962301fc40fe7f2b9f7ba24f01d3f2166ae"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"30f327026569cd77c260ae84514ae370bf5aca1d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"urlpatterns \u003d patterns("},{"line_number":22,"context_line":"    \u0027openstack_dashboard.dashboards.project.ngimages.views\u0027,"},{"line_number":23,"context_line":"    url(r\u0027^details/.*$\u0027, views.IndexView.as_view(), name\u003d\u0027detail\u0027),"},{"line_number":24,"context_line":"    url(r\u0027^$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":25,"context_line":")"}],"source_content_type":"text/x-python","patch_set":122,"id":"ba8a016a_3d4dff99","line":24,"in_reply_to":"ba8a016a_f17b2dbc","updated":"2015-11-19 20:27:08.000000000","message":"Done","commit_id":"7c6e2962301fc40fe7f2b9f7ba24f01d3f2166ae"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"06f767c83d58b65523e1a6deb7f3c220d654c1d1","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"urlpatterns \u003d patterns("},{"line_number":22,"context_line":"    \u0027openstack_dashboard.dashboards.project.ngimages.views\u0027,"},{"line_number":23,"context_line":"    url(r\u0027^details/.*$\u0027, views.IndexView.as_view(), name\u003d\u0027detail\u0027),"},{"line_number":24,"context_line":"    url(r\u0027^$\u0027, views.IndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":25,"context_line":")"}],"source_content_type":"text/x-python","patch_set":124,"id":"ba8a016a_bcb46682","line":23,"updated":"2015-11-20 14:56:53.000000000","message":"Justin, re: your original comment...this *IS* necessary.  If you don\u0027t have this you cannot reference a detail page directly, e.g.: http://localhost:8000/project/ngimages/details/c9f2d3cd-3efc-40a3-ba51-61763af9a611\n\nWe want to reference detail pages directly so they can be bookmarked, etc.","commit_id":"1b42913c8cedf96297527074c1a6723acefdd4be"}],"openstack_dashboard/enabled/_10_project.py":[{"author":{"_account_id":17002,"name":"Coleman Beasley","email":"cbeasley@thoughtworks.com","username":"cbeasley"},"change_message_id":"644be51a5a6264dec7886ee8a0a91cbc614b7332","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# A list of applications to be added to INSTALLED_APPS."},{"line_number":22,"context_line":"ADD_INSTALLED_APPS \u003d [\u0027openstack_dashboard.dashboards.project\u0027]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ADD_ANGULAR_MODULES \u003d []"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"AUTO_DISCOVER_STATIC_FILES \u003d True"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ba3cc151_65974e48","line":24,"updated":"2015-07-09 19:04:48.000000000","message":"Is this line still needed if the array is empty?","commit_id":"6d4e0026140956f1c7282486a5f8f21f72a3bf26"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"a87791f12d61b19f8d23522ecf3359ef1c4668f2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# A list of applications to be added to INSTALLED_APPS."},{"line_number":22,"context_line":"ADD_INSTALLED_APPS \u003d [\u0027openstack_dashboard.dashboards.project\u0027]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"ADD_ANGULAR_MODULES \u003d []"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"AUTO_DISCOVER_STATIC_FILES \u003d True"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":40,"id":"ba3cc151_ddd4ee20","line":24,"in_reply_to":"ba3cc151_65974e48","updated":"2015-07-09 20:12:59.000000000","message":"Maybe so, maybe not.  Not really part of this patch\u0027s focus, though.  I just inherited what is in master.","commit_id":"6d4e0026140956f1c7282486a5f8f21f72a3bf26"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"78747d11c8122bb2a1a3abc995ff22577d378a9e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    LAUNCH_INST + \u0027network/network.spec.js\u0027,"},{"line_number":66,"context_line":"    LAUNCH_INST + \u0027security-groups/security-groups.spec.js\u0027,"},{"line_number":67,"context_line":"    LAUNCH_INST + \u0027keypair/keypair.spec.js\u0027,"},{"line_number":68,"context_line":"    LAUNCH_INST + \u0027configuration/configuration.spec.js\u0027"},{"line_number":69,"context_line":"]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"ADD_SCSS_FILES \u003d ["}],"source_content_type":"text/x-python","patch_set":52,"id":"3a50d1a3_516302b1","line":68,"updated":"2015-07-29 13:39:17.000000000","message":"I think this file can remain untouched.","commit_id":"ce7d2d5fdb55584c36a22ec15714c4ac9dcbd752"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f7a85ec4f5ba433f732e714461cf83f081420002","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    LAUNCH_INST + \u0027configuration/configuration.controller.js\u0027,"},{"line_number":50,"context_line":"    LAUNCH_INST + \u0027configuration/configuration-help.controller.js\u0027,"},{"line_number":51,"context_line":"    LAUNCH_INST + \u0027configuration/load-edit.directive.js\u0027,"},{"line_number":52,"context_line":"    \u0027dashboard/tech-debt/tech-debt.module.js\u0027,"},{"line_number":53,"context_line":"    \u0027dashboard/tech-debt/image-form-ctrl.js\u0027,"},{"line_number":54,"context_line":"]"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":56,"id":"3a50d1a3_90dcaf75","line":52,"updated":"2015-07-31 14:59:18.000000000","message":"Please return this to its original state (put that line back in) so it doesn\u0027t cause confusion.","commit_id":"2d7da9fcd5c651077aaeb8342f125f501b0aa66b"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"35c07fa3523e898dbbb8d0b984fc118cc26e843c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    LAUNCH_INST + \u0027configuration/configuration.controller.js\u0027,"},{"line_number":50,"context_line":"    LAUNCH_INST + \u0027configuration/configuration-help.controller.js\u0027,"},{"line_number":51,"context_line":"    LAUNCH_INST + \u0027configuration/load-edit.directive.js\u0027,"},{"line_number":52,"context_line":"    \u0027dashboard/tech-debt/tech-debt.module.js\u0027,"},{"line_number":53,"context_line":"    \u0027dashboard/tech-debt/image-form-ctrl.js\u0027,"},{"line_number":54,"context_line":"]"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":56,"id":"1a4dcd0f_6c795093","line":52,"in_reply_to":"3a50d1a3_90dcaf75","updated":"2015-08-03 23:09:20.000000000","message":"Done","commit_id":"2d7da9fcd5c651077aaeb8342f125f501b0aa66b"}],"openstack_dashboard/enabled/_203_project_images_panel.py":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"a685b8672b12c91c93fc3e9e00d5086671ab8d5a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"PANEL \u003d \u0027ngimages\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# If set to True, this settings file will not be added to the settings."},{"line_number":27,"context_line":"DISABLED \u003d False"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Python panel class of the PANEL to be added."},{"line_number":30,"context_line":"ADD_PANEL \u003d (\u0027openstack_dashboard.dashboards.project.ngimages.panel.NGImages\u0027)"}],"source_content_type":"text/x-python","patch_set":52,"id":"3a50d1a3_3184365c","line":27,"updated":"2015-07-29 13:31:44.000000000","message":"Reminder: this must be changed back to True when this ceases to be WIP.","commit_id":"ce7d2d5fdb55584c36a22ec15714c4ac9dcbd752"}],"openstack_dashboard/karma.conf.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"78747d11c8122bb2a1a3abc995ff22577d378a9e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      // from jasmine.html"},{"line_number":71,"context_line":"      xstaticPath + \u0027jquery/data/jquery.js\u0027,"},{"line_number":72,"context_line":"      xstaticPath + \u0027angular/data/angular.js\u0027,"},{"line_number":73,"context_line":"      xstaticPath + \u0027angular/data/angular-route.js\u0027,"},{"line_number":74,"context_line":"      xstaticPath + \u0027angular/data/angular-mocks.js\u0027,"},{"line_number":75,"context_line":"      xstaticPath + \u0027angular/data/angular-cookies.js\u0027,"},{"line_number":76,"context_line":"      xstaticPath + \u0027angular_bootstrap/data/angular-bootstrap.js\u0027,"}],"source_content_type":"text/javascript","patch_set":52,"id":"3a50d1a3_91fc2ab6","line":73,"updated":"2015-07-29 13:39:17.000000000","message":"I think this is a great first use of this, even if we can\u0027t use it everywhere.","commit_id":"ce7d2d5fdb55584c36a22ec15714c4ac9dcbd752"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"60c33da36d7061757c50fa97af9b71ad676a6e8d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      // from jasmine.html"},{"line_number":71,"context_line":"      xstaticPath + \u0027jquery/data/jquery.js\u0027,"},{"line_number":72,"context_line":"      xstaticPath + \u0027angular/data/angular.js\u0027,"},{"line_number":73,"context_line":"      xstaticPath + \u0027angular/data/angular-route.js\u0027,"},{"line_number":74,"context_line":"      xstaticPath + \u0027angular/data/angular-mocks.js\u0027,"},{"line_number":75,"context_line":"      xstaticPath + \u0027angular/data/angular-cookies.js\u0027,"},{"line_number":76,"context_line":"      xstaticPath + \u0027angular_bootstrap/data/angular-bootstrap.js\u0027,"}],"source_content_type":"text/javascript","patch_set":85,"id":"fa1b9901_1a7f19e1","line":73,"updated":"2015-08-26 04:59:43.000000000","message":"This is going to require a change in global requirements.  I don\u0027t already see it there.\n\nhttps://github.com/openstack/requirements/blob/master/global-requirements.txt#L209\n\nA patch similar to this will have to go up:\n\nhttps://review.openstack.org/#/c/142869/\n\nBut in addition there is some sort of xstatic tagging process that David might have to help facilitate (which I think we were discussing with Matt Wood?).  I\u0027d suggest putting this out in the IRC room ASAP if it hasn\u0027t already been done.\n\nI don\u0027t think the actions require routing, so I\u0027m thinking it might make more sense to do the following:\n\nFor now, on images table, we will have it go to current django details page.\nMake this details patch depend on ^\n\nFor now on images table, link to current django actions:\nMake the angular modal patches depend on ^\n\nI will put up a patch adding magic search off of Master.\n\nThen need the searchlight REST API patch to land.\nWill put a patch that uses searchlight with magic search.\n\nThoughts?","commit_id":"efd5f2746ad1bf0cfa9ccdcc9803b866035bd414"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"7b49b60bed943a875753a6ffbb8882ed581fb0e5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      // from jasmine.html"},{"line_number":71,"context_line":"      xstaticPath + \u0027jquery/data/jquery.js\u0027,"},{"line_number":72,"context_line":"      xstaticPath + \u0027angular/data/angular.js\u0027,"},{"line_number":73,"context_line":"      xstaticPath + \u0027angular/data/angular-route.js\u0027,"},{"line_number":74,"context_line":"      xstaticPath + \u0027angular/data/angular-mocks.js\u0027,"},{"line_number":75,"context_line":"      xstaticPath + \u0027angular/data/angular-cookies.js\u0027,"},{"line_number":76,"context_line":"      xstaticPath + \u0027angular_bootstrap/data/angular-bootstrap.js\u0027,"}],"source_content_type":"text/javascript","patch_set":85,"id":"fa1b9901_2d450242","line":73,"in_reply_to":"fa1b9901_1a7f19e1","updated":"2015-08-26 06:26:37.000000000","message":"angular-route.js is part of the angular xstatic package so it doesn\u0027t have to be included in a new one. The commit you referred to had the angular-route.hs added.\n\nThe change for karma is required as it doesn\u0027t include it. I\u0027m not so certain about the Apache WSGI bits but assuming it works in the UI without getting it via a xstatic, it should be fine. What do you think?\n\nWe can talk about the inclusion of angular route on IRC to get that discussion started. If there\u0027s de resistance then we could take the django route for the details.\n\nWould like to help on the searchlight patch to have an idea on how it\u0027s done.","commit_id":"efd5f2746ad1bf0cfa9ccdcc9803b866035bd414"}],"openstack_dashboard/static/app/core/images/detail/detail.scss":[{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"1ef6e6b7b611cab509dd59f42788ba407f51017e","unresolved":false,"context_lines":[{"line_number":14,"context_line":" * limitations under the License."},{"line_number":15,"context_line":" */"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":".detail-page {"},{"line_number":18,"context_line":"  position: relative;"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  h2 {"}],"source_content_type":"text/x-scss","patch_set":107,"id":"3a29b11f_3829e137","line":17,"updated":"2015-10-21 00:23:55.000000000","message":".detail-page\n\nthis css rule is not just for images details, we should either\n\n- make it as specific to image details and leave it here, or\n\n- move them to some where else.","commit_id":"1c36ac4cbe5cae59cfd9e47db8e68938059a6b4a"},{"author":{"_account_id":17002,"name":"Coleman Beasley","email":"cbeasley@thoughtworks.com","username":"cbeasley"},"change_message_id":"54e38b6d80174bde20853a870983584608ab62cc","unresolved":false,"context_lines":[{"line_number":14,"context_line":" * limitations under the License."},{"line_number":15,"context_line":" */"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":".detail-page {"},{"line_number":18,"context_line":"  position: relative;"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  h2 {"}],"source_content_type":"text/x-scss","patch_set":107,"id":"3a29b11f_cd10ca5b","line":17,"in_reply_to":"3a29b11f_3829e137","updated":"2015-10-23 00:30:48.000000000","message":"Done","commit_id":"1c36ac4cbe5cae59cfd9e47db8e68938059a6b4a"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"7d215de685522b771b46e64777ef0df5fc989720","unresolved":false,"context_lines":[{"line_number":12,"context_line":" * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":" * See the License for the specific language governing permissions and"},{"line_number":14,"context_line":" * limitations under the License."},{"line_number":15,"context_line":" */"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":".image-detail-page {"},{"line_number":18,"context_line":"  position: relative;"}],"source_content_type":"text/x-scss","patch_set":113,"id":"fa80f949_567044dc","line":15,"updated":"2015-11-06 01:38:34.000000000","message":"There are hardcoded styles here. All styles should inherit from theme variables to remain theme-able.\n\nSee the \u0027//\u003d\u003d Components\u0027 section of _variables.scss for various values that can be used.","commit_id":"080e7c477eab144c0d8b48fd9674268bc7c16767"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"c8fb3de95454d51aff5a4fd816d7c86e79e3fc02","unresolved":false,"context_lines":[{"line_number":12,"context_line":" * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":13,"context_line":" * See the License for the specific language governing permissions and"},{"line_number":14,"context_line":" * limitations under the License."},{"line_number":15,"context_line":" */"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":".image-detail-page {"},{"line_number":18,"context_line":"  position: relative;"}],"source_content_type":"text/x-scss","patch_set":113,"id":"da85f559_bfdfde38","line":15,"in_reply_to":"fa80f949_567044dc","updated":"2015-11-11 14:39:12.000000000","message":"Yeah, this was developed in a vacuum a long time ago.  Let\u0027s confer as I need to be schooled on how one properly achieves what we want.  This poor css was battered around for months with different opinions as to how to be executed.","commit_id":"080e7c477eab144c0d8b48fd9674268bc7c16767"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"7d215de685522b771b46e64777ef0df5fc989720","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":".image-detail-page {"},{"line_number":18,"context_line":"  position: relative;"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  h3 {"},{"line_number":21,"context_line":"    margin-top: 24px;"},{"line_number":22,"context_line":"    margin-bottom: 8px;"}],"source_content_type":"text/x-scss","patch_set":113,"id":"fa80f949_313fca88","line":19,"updated":"2015-11-06 01:38:34.000000000","message":"Does this h3 exist within the scope of an h1 and h2?  If not, it may have a negative affect on some accessibility devices.","commit_id":"080e7c477eab144c0d8b48fd9674268bc7c16767"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"7d215de685522b771b46e64777ef0df5fc989720","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  h3 {"},{"line_number":21,"context_line":"    margin-top: 24px;"},{"line_number":22,"context_line":"    margin-bottom: 8px;"},{"line_number":23,"context_line":"    border-bottom: 1px solid $detail-separator-color;"},{"line_number":24,"context_line":"    font-size: 1.2em;"},{"line_number":25,"context_line":"    color: $detail-group-color;"},{"line_number":26,"context_line":"  }"}],"source_content_type":"text/x-scss","patch_set":113,"id":"fa80f949_b1bc1a07","line":23,"updated":"2015-11-06 01:38:34.000000000","message":"If we need this to be bigger, why not just use h2 or h1?","commit_id":"080e7c477eab144c0d8b48fd9674268bc7c16767"}],"openstack_dashboard/static/app/core/images/detail/image-detail.controller.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"05f04e86232b4aa3a318b9eb219f16b571f37342","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  function ImageDetailController($modal, $window, glanceAPI, keystoneAPI, modalSpec, $routeParams) {"},{"line_number":32,"context_line":"    var ctrl \u003d this;"},{"line_number":33,"context_line":"    ctrl.label \u003d {"},{"line_number":34,"context_line":"      \"launch\": gettext(\"Launch\"),"},{"line_number":35,"context_line":"      \"create_volume\": gettext(\"Create Volume\"),"},{"line_number":36,"context_line":"      \"edit\": gettext(\"Edit\"),"},{"line_number":37,"context_line":"      \"delete_image\": gettext(\"Delete Image\"),"}],"source_content_type":"text/javascript","patch_set":55,"id":"3a50d1a3_8f9fe564","line":34,"updated":"2015-07-30 15:18:07.000000000","message":"Many of these translations may now be placed inline; see notes on the associated .html page.","commit_id":"751423deafd1f2f328c89c9c70f849f51463bdf2"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f7a85ec4f5ba433f732e714461cf83f081420002","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      openLaunchInstanceWizard({successUrl: \u0027/project/instances\u0027, imageId: imageId});"},{"line_number":67,"context_line":"    };"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    ctrl.createVolume \u003d function() {"},{"line_number":70,"context_line":"    };"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    ctrl.editImage \u003d function() {"}],"source_content_type":"text/javascript","patch_set":56,"id":"3a50d1a3_d00d57e9","line":69,"updated":"2015-07-31 14:59:18.000000000","message":"Just indicate // TODO or similar to indicate implementation in subsequent patch, similarly in each of the stubs below.","commit_id":"2d7da9fcd5c651077aaeb8342f125f501b0aa66b"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"35c07fa3523e898dbbb8d0b984fc118cc26e843c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      openLaunchInstanceWizard({successUrl: \u0027/project/instances\u0027, imageId: imageId});"},{"line_number":67,"context_line":"    };"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    ctrl.createVolume \u003d function() {"},{"line_number":70,"context_line":"    };"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    ctrl.editImage \u003d function() {"}],"source_content_type":"text/javascript","patch_set":56,"id":"1a4dcd0f_0c6e8cc9","line":69,"in_reply_to":"3a50d1a3_d00d57e9","updated":"2015-08-03 23:09:20.000000000","message":"Done","commit_id":"2d7da9fcd5c651077aaeb8342f125f501b0aa66b"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f7a85ec4f5ba433f732e714461cf83f081420002","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    ctrl.deleteImage \u003d function() {"},{"line_number":76,"context_line":"    };"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    function openLaunchInstanceWizard(launchContext) {"},{"line_number":79,"context_line":"      var localSpec \u003d {"},{"line_number":80,"context_line":"        resolve: {"},{"line_number":81,"context_line":"          launchContext: function () {"}],"source_content_type":"text/javascript","patch_set":56,"id":"3a50d1a3_10d2df34","line":78,"updated":"2015-07-31 14:59:18.000000000","message":"We should see if there\u0027s a better way to centralize this logic so we don\u0027t have to replicate it all over the place.","commit_id":"2d7da9fcd5c651077aaeb8342f125f501b0aa66b"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"35c07fa3523e898dbbb8d0b984fc118cc26e843c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    ctrl.deleteImage \u003d function() {"},{"line_number":76,"context_line":"    };"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    function openLaunchInstanceWizard(launchContext) {"},{"line_number":79,"context_line":"      var localSpec \u003d {"},{"line_number":80,"context_line":"        resolve: {"},{"line_number":81,"context_line":"          launchContext: function () {"}],"source_content_type":"text/javascript","patch_set":56,"id":"1a4dcd0f_4c9b34ca","line":78,"in_reply_to":"3a50d1a3_10d2df34","updated":"2015-08-03 23:09:20.000000000","message":"There\u0027s a patch in play to move the launch controller code to app/core. Maybe this refactoring can be a different patch?","commit_id":"2d7da9fcd5c651077aaeb8342f125f501b0aa66b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"11dce78d8d173ce31d7360cc0436d352fb34762e","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  function ImageDetailController($window, $modal, glanceAPI, keystoneAPI, modalSpec, $routeParams) {"},{"line_number":32,"context_line":"    var ctrl \u003d this;"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    ctrl.imageStatus \u003d {"},{"line_number":35,"context_line":"      \u0027active\u0027: gettext(\"Active\"),"},{"line_number":36,"context_line":"      \u0027saving\u0027: gettext(\"Saving\"),"}],"source_content_type":"text/javascript","patch_set":83,"id":"fa1b9901_cb9dea0b","line":33,"updated":"2015-08-21 21:42:57.000000000","message":"Guys, can this just use the filter?\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/filters/image-status.filter.js","commit_id":"91b330d98da0e2a963c42c6a37180c60ed0f8fa9"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"1ec902a60a85ba83fa35918a1507d259598851df","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  function ImageDetailController($window, $modal, glanceAPI, keystoneAPI, modalSpec, $routeParams) {"},{"line_number":32,"context_line":"    var ctrl \u003d this;"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    ctrl.imageStatus \u003d {"},{"line_number":35,"context_line":"      \u0027active\u0027: gettext(\"Active\"),"},{"line_number":36,"context_line":"      \u0027saving\u0027: gettext(\"Saving\"),"}],"source_content_type":"text/javascript","patch_set":83,"id":"fa1b9901_88729548","line":33,"in_reply_to":"fa1b9901_cb9dea0b","updated":"2015-08-21 22:26:37.000000000","message":"Done","commit_id":"91b330d98da0e2a963c42c6a37180c60ed0f8fa9"},{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"1ef6e6b7b611cab509dd59f42788ba407f51017e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    ctrl.deleteImage \u003d function() {"},{"line_number":67,"context_line":"      // Implemented in subsequent patch"},{"line_number":68,"context_line":"    };"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":107,"id":"3a29b11f_f8e60914","line":69,"updated":"2015-10-21 00:23:55.000000000","message":"Since this patch is not marked as WIP, we should remove empty functions.","commit_id":"1c36ac4cbe5cae59cfd9e47db8e68938059a6b4a"},{"author":{"_account_id":17002,"name":"Coleman Beasley","email":"cbeasley@thoughtworks.com","username":"cbeasley"},"change_message_id":"54e38b6d80174bde20853a870983584608ab62cc","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    ctrl.deleteImage \u003d function() {"},{"line_number":67,"context_line":"      // Implemented in subsequent patch"},{"line_number":68,"context_line":"    };"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  }"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":107,"id":"3a29b11f_6a0b9fd6","line":69,"in_reply_to":"3a29b11f_f8e60914","updated":"2015-10-23 00:30:48.000000000","message":"removed","commit_id":"1c36ac4cbe5cae59cfd9e47db8e68938059a6b4a"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"ea37286f6918508a2784d184f12575fcdc30027a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    var imageId \u003d $routeParams.imageId;"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    // Load the elements that are used in the overview."},{"line_number":37,"context_line":"    glanceAPI.getImage(imageId).success(function(image) {"},{"line_number":38,"context_line":"      ctrl.image \u003d image;"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"      ctrl.image.properties \u003d Object.keys(ctrl.image.properties).map(function(prop) {"}],"source_content_type":"text/javascript","patch_set":110,"id":"3a29b11f_2ac55d5a","line":37,"updated":"2015-10-26 14:01:43.000000000","message":"nit: anonymous function (and others bellow) ;-)","commit_id":"693ab09e1ccd25a82b37b8c9878f0274830d0725"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"0cac7af3c7e8010746c91f0cc28c52ae2045c618","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    var imageId \u003d $routeParams.imageId;"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    // Load the elements that are used in the overview."},{"line_number":37,"context_line":"    glanceAPI.getImage(imageId).success(function(image) {"},{"line_number":38,"context_line":"      ctrl.image \u003d image;"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"      ctrl.image.properties \u003d Object.keys(ctrl.image.properties).map(function(prop) {"}],"source_content_type":"text/javascript","patch_set":110,"id":"3a29b11f_a402fc6d","line":37,"in_reply_to":"3a29b11f_2ac55d5a","updated":"2015-10-26 17:39:55.000000000","message":"Done","commit_id":"693ab09e1ccd25a82b37b8c9878f0274830d0725"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"30b07e92106a06cfca271f3906ff2cd40b927702","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  ImageDetailController.$inject \u003d ["},{"line_number":23,"context_line":"    \u0027$window\u0027,"},{"line_number":24,"context_line":"    \u0027$modal\u0027,"},{"line_number":25,"context_line":"    \u0027horizon.app.core.openstack-service-api.glance\u0027,"},{"line_number":26,"context_line":"    \u0027horizon.app.core.openstack-service-api.keystone\u0027,"},{"line_number":27,"context_line":"    \u0027$routeParams\u0027"}],"source_content_type":"text/javascript","patch_set":113,"id":"fa80f949_fc490061","line":24,"updated":"2015-11-06 14:33:45.000000000","message":"do we need the module here?","commit_id":"080e7c477eab144c0d8b48fd9674268bc7c16767"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"40dfc73bc0c8f66f0395d86b6cfae15069f27433","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  ImageDetailController.$inject \u003d ["},{"line_number":23,"context_line":"    \u0027$window\u0027,"},{"line_number":24,"context_line":"    \u0027$modal\u0027,"},{"line_number":25,"context_line":"    \u0027horizon.app.core.openstack-service-api.glance\u0027,"},{"line_number":26,"context_line":"    \u0027horizon.app.core.openstack-service-api.keystone\u0027,"},{"line_number":27,"context_line":"    \u0027$routeParams\u0027"}],"source_content_type":"text/javascript","patch_set":113,"id":"da85f559_bf6fdefa","line":24,"in_reply_to":"fa80f949_fc490061","updated":"2015-11-11 14:47:56.000000000","message":"Nope, at least not at this point!  Removing in next patchset.","commit_id":"080e7c477eab144c0d8b48fd9674268bc7c16767"},{"author":{"_account_id":7132,"name":"Nikita Konovalov","email":"nkonovalov@mirantis.com","username":"nkonovalov"},"change_message_id":"cc1ca4ec4cb12ad2936af93e99875c54d4c39a9e","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    var imageId \u003d $routeParams.imageId;"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    init();"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    function init() {"},{"line_number":41,"context_line":"      // Load the elements that are used in the overview."}],"source_content_type":"text/javascript","patch_set":113,"id":"fa80f949_8d7a36f0","line":38,"updated":"2015-11-05 13:39:46.000000000","message":"Why a call before definition? Could you just inline the init body?","commit_id":"080e7c477eab144c0d8b48fd9674268bc7c16767"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"1e2ec84951dbe910dda0803ca8d1f5bb604f945a","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    var imageId \u003d $routeParams.imageId;"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    init();"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    function init() {"},{"line_number":41,"context_line":"      // Load the elements that are used in the overview."}],"source_content_type":"text/javascript","patch_set":113,"id":"fa80f949_c6df890b","line":38,"in_reply_to":"fa80f949_8d7a36f0","updated":"2015-11-06 14:22:27.000000000","message":"I guess this is just a style guide convention. Please, refer to https://github.com/johnpapa/angular-styleguide#style-y034","commit_id":"080e7c477eab144c0d8b48fd9674268bc7c16767"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"30b07e92106a06cfca271f3906ff2cd40b927702","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    var imageId \u003d $routeParams.imageId;"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    init();"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    function init() {"},{"line_number":41,"context_line":"      // Load the elements that are used in the overview."}],"source_content_type":"text/javascript","patch_set":113,"id":"fa80f949_1c196479","line":38,"in_reply_to":"fa80f949_8d7a36f0","updated":"2015-11-06 14:33:45.000000000","message":"Nikita, it\u0027s really a style guide convention:)","commit_id":"080e7c477eab144c0d8b48fd9674268bc7c16767"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"1e2ec84951dbe910dda0803ca8d1f5bb604f945a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    function onGetImage(image) {"},{"line_number":50,"context_line":"      ctrl.image \u003d image;"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"      ctrl.image.properties \u003d Object.keys(ctrl.image.properties).map(function(prop) {"},{"line_number":53,"context_line":"        return {name: prop, value: ctrl.image.properties[prop]};"},{"line_number":54,"context_line":"      });"},{"line_number":55,"context_line":""}],"source_content_type":"text/javascript","patch_set":113,"id":"fa80f949_a6ea85aa","line":52,"updated":"2015-11-06 14:22:27.000000000","message":"nit: anonymous function","commit_id":"080e7c477eab144c0d8b48fd9674268bc7c16767"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"40dfc73bc0c8f66f0395d86b6cfae15069f27433","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    function onGetImage(image) {"},{"line_number":50,"context_line":"      ctrl.image \u003d image;"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"      ctrl.image.properties \u003d Object.keys(ctrl.image.properties).map(function(prop) {"},{"line_number":53,"context_line":"        return {name: prop, value: ctrl.image.properties[prop]};"},{"line_number":54,"context_line":"      });"},{"line_number":55,"context_line":""}],"source_content_type":"text/javascript","patch_set":113,"id":"da85f559_7f7656d8","line":52,"in_reply_to":"fa80f949_a6ea85aa","updated":"2015-11-11 14:47:56.000000000","message":"Adding name to function in next patchset.","commit_id":"080e7c477eab144c0d8b48fd9674268bc7c16767"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"bafea72fe40e7071446d13b9a27642bed67169cd","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    ctrl.image \u003d {};"},{"line_number":33,"context_line":"    ctrl.hasCustomProperties \u003d false;"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    var imageId \u003d $routeParams.imageId;"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    init();"}],"source_content_type":"text/javascript","patch_set":129,"id":"9a8ffd7b_6a2ff6f6","line":34,"updated":"2015-12-01 05:52:58.000000000","message":"ctrl.project is not initialize.","commit_id":"b35072265f2034c94937b9935deda2c7230e712d"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"47d83f4051a385441ba5d242e9a15c3ab39e885d","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    ctrl.image \u003d {};"},{"line_number":33,"context_line":"    ctrl.hasCustomProperties \u003d false;"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    var imageId \u003d $routeParams.imageId;"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    init();"}],"source_content_type":"text/javascript","patch_set":129,"id":"9a8ffd7b_5c1ae118","line":34,"in_reply_to":"9a8ffd7b_6a2ff6f6","updated":"2015-12-01 14:30:10.000000000","message":"That\u0027s true, although it doesn\u0027t matter, it probably would be nice to have an empty object and knowledge of that property during init.","commit_id":"b35072265f2034c94937b9935deda2c7230e712d"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"42b412999c868d40c27feaa98f660829848e5239","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    \u0027$routeParams\u0027"},{"line_number":27,"context_line":"  ];"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  function ImageDetailController($window, glanceAPI, keystoneAPI, $routeParams) {"},{"line_number":30,"context_line":"    var ctrl \u003d this;"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    ctrl.image \u003d {};"}],"source_content_type":"text/javascript","patch_set":136,"id":"fa69d971_94172544","line":29,"range":{"start_line":29,"start_character":33,"end_line":29,"end_character":40},"updated":"2016-01-07 00:17:18.000000000","message":"-1: Because this injection isn\u0027t used by the controller itself, it is easy to overlook that it is used by the image-detail.html which causes refactoring and maintenance headaches.\n\nInstead, consider extracting the specific data needed by the view. Code maintenance is easier if all data needed by a view is directly from a controller attribute. This also helps avoid the view accidentally grabbing data from a parent scope.\n\nIn the controller:\nctrl.imagesUrl \u003d $window + \"project/ngimages\"\n\nIn the view:\n\u003ca href\u003d\"{$ ctrl.imagesUrl $}\"\u003e...\u003c/a\u003e","commit_id":"cb988e5881dd5914882571c038b05a9be6d7dc50"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"c1194fb9f41ce888959579af5744814bf43de31a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    .module(\u0027horizon.app.core.images\u0027)"},{"line_number":20,"context_line":"    .controller(\u0027ImageDetailController\u0027, ImageDetailController);"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  ImageDetailController.$inject \u003d ["},{"line_number":23,"context_line":"    \u0027horizon.app.core.openstack-service-api.glance\u0027,"},{"line_number":24,"context_line":"    \u0027horizon.app.core.openstack-service-api.keystone\u0027,"},{"line_number":25,"context_line":"    \u0027$routeParams\u0027"}],"source_content_type":"text/javascript","patch_set":138,"id":"fa69d971_6fcf05b4","line":22,"range":{"start_line":22,"start_character":34,"end_line":22,"end_character":35},"updated":"2016-01-07 23:26:56.000000000","message":"-1: You\u0027ve removed the injection of $window from this controller entirely. This is the opposite of what I had in mind :)  See the comment in the image-detail.html ...","commit_id":"97acbd9fc8bcffd8566d5df26248480f716285fb"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"137165d68182f547a75d655de9936cc567f8fc4e","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"      ctrl.image.properties \u003d Object.keys(ctrl.image.properties).map(function mapProps(prop) {"},{"line_number":54,"context_line":"        return {name: prop, value: ctrl.image.properties[prop]};"},{"line_number":55,"context_line":"      });"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"      keystoneAPI.getProject(ctrl.image.owner).success(onGetProject);"},{"line_number":58,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":152,"id":"5a5ae5dd_0ea9cf24","line":55,"updated":"2016-02-08 23:35:12.000000000","message":"The above doesn\u0027t account for the \"IMAGE_CUSTOM_PROPERTY_TITLES\" setting. Basically if a property has a custom property title defined, the current details page displays it instead of the raw property.\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/images/images/tabs.py#L26-L36\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/images/templates/images/images/_detail_overview.html#L63-L65\n\nIt appears that there is a bug open on this: https://bugs.launchpad.net/horizon/+bug/1487590\n\nSo, at minimum, I\u0027d like to see a comment here with a TODO referencing the bug saying it doesn\u0027t work.\n\nAlternatively, I\u0027d rather push people to the Glance metadata definitions catalog where you can set a lot more info about properties and can remap their names using it (deprecate the above). So, if we could put that in the TODO for a follow on patch and then use the data from there it would be better.  It should be as easy as including the following in another tab, but should potentially be lazy loaded. I also think we should put up a patch that caches the metadefs as they likely won\u0027t change very often.\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/source/source-details.html#L25-L28\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-model.service.js#L554\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/metadata/modal/modal-helper.controller.js#L44\n\nJust inject the service and call getNamesapace(\u0027Image\u0027)\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/metadata/metadata.service.js","commit_id":"a88bde2e0cca3533263dba1fbb5740bdc7e4f724"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"10b4ea93b97081c3d673c4c9f6be2ad39e0a739b","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"      ctrl.image.properties \u003d Object.keys(ctrl.image.properties).map(function mapProps(prop) {"},{"line_number":54,"context_line":"        return {name: prop, value: ctrl.image.properties[prop]};"},{"line_number":55,"context_line":"      });"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"      keystoneAPI.getProject(ctrl.image.owner).success(onGetProject);"},{"line_number":58,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":152,"id":"5a5ae5dd_2efb6649","line":55,"in_reply_to":"5a5ae5dd_0ea9cf24","updated":"2016-02-09 01:19:08.000000000","message":"I have put up a patch that uses metadata defs on the image table:  https://review.openstack.org/#/c/277645/","commit_id":"a88bde2e0cca3533263dba1fbb5740bdc7e4f724"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"137165d68182f547a75d655de9936cc567f8fc4e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        return {name: prop, value: ctrl.image.properties[prop]};"},{"line_number":55,"context_line":"      });"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"      keystoneAPI.getProject(ctrl.image.owner).success(onGetProject);"},{"line_number":58,"context_line":"    }"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    function onGetProject(project) {"}],"source_content_type":"text/javascript","patch_set":152,"id":"5a5ae5dd_651c2614","line":57,"updated":"2016-02-08 23:35:12.000000000","message":"This causes error if not admin:\n\nhttp://pasteboard.co/1pvvo1MH.png","commit_id":"a88bde2e0cca3533263dba1fbb5740bdc7e4f724"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"1c569290e56ff571e27ca7cd04dad1d84f27e706","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  angular"},{"line_number":19,"context_line":"    .module(\u0027horizon.app.core.images\u0027)"},{"line_number":20,"context_line":"    .controller(\u0027ImageDetailController\u0027, ImageDetailController);"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  ImageDetailController.$inject \u003d ["},{"line_number":23,"context_line":"    \u0027horizon.app.core.images.tableRoute\u0027,"}],"source_content_type":"text/javascript","patch_set":155,"id":"3a57f1b5_a1cd97b8","line":20,"updated":"2016-02-12 05:14:09.000000000","message":"These names are being fully-qualified these days.","commit_id":"1a17b8608fb28c827c737a72a68b7406e6390f7c"}],"openstack_dashboard/static/app/core/images/detail/image-detail.controller.spec.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f7a85ec4f5ba433f732e714461cf83f081420002","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      it(\u0027defines hasCustomProperties on the scope\u0027, function() {"},{"line_number":52,"context_line":"        expect(ctrl.hasCustomProperties).toBeDefined();"},{"line_number":53,"context_line":"      });"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    });"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  });"}],"source_content_type":"text/javascript","patch_set":56,"id":"3a50d1a3_308a7b1b","line":54,"updated":"2015-07-31 14:59:18.000000000","message":"I\u0027d start putting in tests, even if shallow ones, for launchImage, createVolume, etc.","commit_id":"2d7da9fcd5c651077aaeb8342f125f501b0aa66b"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"35c07fa3523e898dbbb8d0b984fc118cc26e843c","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      it(\u0027defines hasCustomProperties on the scope\u0027, function() {"},{"line_number":52,"context_line":"        expect(ctrl.hasCustomProperties).toBeDefined();"},{"line_number":53,"context_line":"      });"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    });"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  });"}],"source_content_type":"text/javascript","patch_set":56,"id":"1a4dcd0f_0ca52c03","line":54,"in_reply_to":"3a50d1a3_308a7b1b","updated":"2015-08-03 23:09:20.000000000","message":"Done","commit_id":"2d7da9fcd5c651077aaeb8342f125f501b0aa66b"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"ea37286f6918508a2784d184f12575fcdc30027a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  describe(\u0027horizon.app.core.images\u0027, function() {"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    beforeEach(module(\u0027ui.bootstrap\u0027));"},{"line_number":21,"context_line":"    beforeEach(module(\u0027horizon.app.core\u0027));"},{"line_number":22,"context_line":"    beforeEach(module(\u0027horizon.app.core.images\u0027));"},{"line_number":23,"context_line":"    beforeEach(module(\u0027horizon.app.core.openstack-service-api\u0027));"},{"line_number":24,"context_line":"    beforeEach(module(\u0027horizon.dashboard.project.workflow.launch-instance\u0027));"}],"source_content_type":"text/javascript","patch_set":110,"id":"3a29b11f_ca8e2927","line":21,"updated":"2015-10-26 14:01:43.000000000","message":"nit: could use just this import and remove the other two","commit_id":"693ab09e1ccd25a82b37b8c9878f0274830d0725"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"0cac7af3c7e8010746c91f0cc28c52ae2045c618","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  describe(\u0027horizon.app.core.images\u0027, function() {"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    beforeEach(module(\u0027ui.bootstrap\u0027));"},{"line_number":21,"context_line":"    beforeEach(module(\u0027horizon.app.core\u0027));"},{"line_number":22,"context_line":"    beforeEach(module(\u0027horizon.app.core.images\u0027));"},{"line_number":23,"context_line":"    beforeEach(module(\u0027horizon.app.core.openstack-service-api\u0027));"},{"line_number":24,"context_line":"    beforeEach(module(\u0027horizon.dashboard.project.workflow.launch-instance\u0027));"}],"source_content_type":"text/javascript","patch_set":110,"id":"3a29b11f_24efccb1","line":21,"in_reply_to":"3a29b11f_ca8e2927","updated":"2015-10-26 17:39:55.000000000","message":"Done","commit_id":"693ab09e1ccd25a82b37b8c9878f0274830d0725"}],"openstack_dashboard/static/app/core/images/detail/image-detail.html":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"78747d11c8122bb2a1a3abc995ff22577d378a9e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      \u003chz-property label\u003d\"::ctrl.label.owner\" value\u003d\"ctrl.project.name\"\u003e\u003c/hz-property\u003e"},{"line_number":7,"context_line":"      \u003chz-property label\u003d\"::ctrl.label.status\""},{"line_number":8,"context_line":"                value\u003d\"ctrl.image.status  | decode:ctrl.imageStatus\"\u003e\u003c/hz-property\u003e"},{"line_number":9,"context_line":"      \u003chz-property label\u003d\"::ctrl.label.base_os\" value\u003d\" \u0027--\u0027 \"\u003e\u003c/hz-property\u003e"},{"line_number":10,"context_line":"    \u003c/hz-property-group\u003e"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    \u003caction-list dropdown\u003e"}],"source_content_type":"text/html","patch_set":52,"id":"3a50d1a3_f196ce3c","line":9,"updated":"2015-07-29 13:39:17.000000000","message":"This should be removed unless we can identify its correct source.","commit_id":"ce7d2d5fdb55584c36a22ec15714c4ac9dcbd752"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"78747d11c8122bb2a1a3abc995ff22577d378a9e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        \u003caction button-type\u003d\"menu-item-batch\""},{"line_number":26,"context_line":"                item-id\u003d\"images__row_{$ ctrl.image.id $}__action_delete\""},{"line_number":27,"context_line":"                aria-value\u003d\"images__delete__{$ ctrl.image.id $}\""},{"line_number":28,"context_line":"                help-text\u003d\" \u0027CHANGEME\u0027 \""},{"line_number":29,"context_line":"                action-classes\u003d\" \u0027text-danger ajax-modal\u0027 \"\u003e{$ ::ctrl.label.delete_image $}\u003c/action\u003e"},{"line_number":30,"context_line":"      \u003c/menu\u003e"},{"line_number":31,"context_line":"    \u003c/action-list\u003e"}],"source_content_type":"text/html","patch_set":52,"id":"3a50d1a3_b197e646","line":28,"updated":"2015-07-29 13:39:17.000000000","message":"We should probably change this in an appropriate way; perhaps just leave blank.","commit_id":"ce7d2d5fdb55584c36a22ec15714c4ac9dcbd752"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"253675c7dbdadbecf9949ee40a66f3a6e4b96878","unresolved":false,"context_lines":[{"line_number":26,"context_line":"                item-id\u003d\"images__row_{$ ctrl.image.id $}__action_delete\""},{"line_number":27,"context_line":"                aria-value\u003d\"images__delete__{$ ctrl.image.id $}\""},{"line_number":28,"context_line":"                help-text\u003d\" \u0027CHANGEME\u0027 \""},{"line_number":29,"context_line":"                action-classes\u003d\" \u0027text-danger ajax-modal\u0027 \"\u003e{$ ::ctrl.label.delete_image $}\u003c/action\u003e"},{"line_number":30,"context_line":"      \u003c/menu\u003e"},{"line_number":31,"context_line":"    \u003c/action-list\u003e"},{"line_number":32,"context_line":""}],"source_content_type":"text/html","patch_set":52,"id":"3a50d1a3_f40f91dd","line":29,"updated":"2015-07-29 16:52:24.000000000","message":"This doesn\u0027t show up nicely...can we figure out how to fix that?  It should be only red lettering, not a red background.  This was something I broke a while ago.  :)","commit_id":"ce7d2d5fdb55584c36a22ec15714c4ac9dcbd752"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"05f04e86232b4aa3a318b9eb219f16b571f37342","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  \u003chz-page-header header\u003d\"ctrl.image.name\" description\u003d\"ctrl.image.properties.description\"\u003e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    \u003chz-property-group\u003e"},{"line_number":6,"context_line":"      \u003chz-property label\u003d\"::ctrl.label.owner\" value\u003d\"ctrl.project.name\"\u003e\u003c/hz-property\u003e"},{"line_number":7,"context_line":"      \u003chz-property label\u003d\"::ctrl.label.status\""},{"line_number":8,"context_line":"                value\u003d\"ctrl.image.status  | decode:ctrl.imageStatus\"\u003e\u003c/hz-property\u003e"},{"line_number":9,"context_line":"      \u003chz-property label\u003d\"::ctrl.label.base_os\" value\u003d\" \u0027--\u0027 \"\u003e\u003c/hz-property\u003e"}],"source_content_type":"text/html","patch_set":55,"id":"3a50d1a3_efec69f5","line":6,"updated":"2015-07-30 15:18:07.000000000","message":"All these labels can now use the appropriate \u003ctranslate\u003e or | translate method to define the English text inline, rather than specifying in the controller as before.","commit_id":"751423deafd1f2f328c89c9c70f849f51463bdf2"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f7a85ec4f5ba433f732e714461cf83f081420002","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      \u003chz-property label\u003d\"\u0027Owner\u0027 | translate\" value\u003d\"ctrl.project.name\"\u003e\u003c/hz-property\u003e"},{"line_number":7,"context_line":"      \u003chz-property label\u003d\"\u0027Status\u0027 | translate\""},{"line_number":8,"context_line":"                value\u003d\"ctrl.image.status  | decode:ctrl.imageStatus\"\u003e\u003c/hz-property\u003e"},{"line_number":9,"context_line":"      \u003chz-property label\u003d\"\u0027Base OS\u0027 | translate\" value\u003d\" \u0027--\u0027 \"\u003e\u003c/hz-property\u003e"},{"line_number":10,"context_line":"    \u003c/hz-property-group\u003e"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    \u003caction-list dropdown\u003e"}],"source_content_type":"text/html","patch_set":56,"id":"3a50d1a3_b0676b50","line":9,"updated":"2015-07-31 14:59:18.000000000","message":"I still would get rid of this.","commit_id":"2d7da9fcd5c651077aaeb8342f125f501b0aa66b"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"35c07fa3523e898dbbb8d0b984fc118cc26e843c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      \u003chz-property label\u003d\"\u0027Owner\u0027 | translate\" value\u003d\"ctrl.project.name\"\u003e\u003c/hz-property\u003e"},{"line_number":7,"context_line":"      \u003chz-property label\u003d\"\u0027Status\u0027 | translate\""},{"line_number":8,"context_line":"                value\u003d\"ctrl.image.status  | decode:ctrl.imageStatus\"\u003e\u003c/hz-property\u003e"},{"line_number":9,"context_line":"      \u003chz-property label\u003d\"\u0027Base OS\u0027 | translate\" value\u003d\" \u0027--\u0027 \"\u003e\u003c/hz-property\u003e"},{"line_number":10,"context_line":"    \u003c/hz-property-group\u003e"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    \u003caction-list dropdown\u003e"}],"source_content_type":"text/html","patch_set":56,"id":"1a4dcd0f_8c1dbc68","line":9,"in_reply_to":"3a50d1a3_b0676b50","updated":"2015-08-03 23:09:20.000000000","message":"Done","commit_id":"2d7da9fcd5c651077aaeb8342f125f501b0aa66b"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f7a85ec4f5ba433f732e714461cf83f081420002","unresolved":false,"context_lines":[{"line_number":19,"context_line":"      \u003c/action\u003e"},{"line_number":20,"context_line":"      \u003cmenu\u003e"},{"line_number":21,"context_line":"        \u003caction button-type\u003d\"menu-item\""},{"line_number":22,"context_line":"                action-classes\u003d\" \u0027\u0027 \""},{"line_number":23,"context_line":"                callback\u003d\"ctrl.createVolume\""},{"line_number":24,"context_line":"                item\u003d\"ctrl.image.id\"\u003e"},{"line_number":25,"context_line":"          {$ \u0027Create Volume\u0027 | translate $}"}],"source_content_type":"text/html","patch_set":56,"id":"3a50d1a3_6317df45","line":22,"updated":"2015-07-31 14:59:18.000000000","message":"I think you can just leave this out.","commit_id":"2d7da9fcd5c651077aaeb8342f125f501b0aa66b"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"35c07fa3523e898dbbb8d0b984fc118cc26e843c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"      \u003c/action\u003e"},{"line_number":20,"context_line":"      \u003cmenu\u003e"},{"line_number":21,"context_line":"        \u003caction button-type\u003d\"menu-item\""},{"line_number":22,"context_line":"                action-classes\u003d\" \u0027\u0027 \""},{"line_number":23,"context_line":"                callback\u003d\"ctrl.createVolume\""},{"line_number":24,"context_line":"                item\u003d\"ctrl.image.id\"\u003e"},{"line_number":25,"context_line":"          {$ \u0027Create Volume\u0027 | translate $}"}],"source_content_type":"text/html","patch_set":56,"id":"1a4dcd0f_4c26d4bb","line":22,"in_reply_to":"3a50d1a3_6317df45","updated":"2015-08-03 23:09:20.000000000","message":"Done","commit_id":"2d7da9fcd5c651077aaeb8342f125f501b0aa66b"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f7a85ec4f5ba433f732e714461cf83f081420002","unresolved":false,"context_lines":[{"line_number":25,"context_line":"          {$ \u0027Create Volume\u0027 | translate $}"},{"line_number":26,"context_line":"        \u003c/action\u003e"},{"line_number":27,"context_line":"        \u003caction button-type\u003d\"menu-item\""},{"line_number":28,"context_line":"                action-classes\u003d\" \u0027\u0027 \""},{"line_number":29,"context_line":"                callback\u003d\"ctrl.editImage\""},{"line_number":30,"context_line":"                item\u003d\"ctrl.image.id\"\u003e"},{"line_number":31,"context_line":"          {$ \u0027Edit\u0027 | translate $}"}],"source_content_type":"text/html","patch_set":56,"id":"3a50d1a3_a33407df","line":28,"updated":"2015-07-31 14:59:18.000000000","message":"I\u0027d leave this out.","commit_id":"2d7da9fcd5c651077aaeb8342f125f501b0aa66b"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"35c07fa3523e898dbbb8d0b984fc118cc26e843c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"          {$ \u0027Create Volume\u0027 | translate $}"},{"line_number":26,"context_line":"        \u003c/action\u003e"},{"line_number":27,"context_line":"        \u003caction button-type\u003d\"menu-item\""},{"line_number":28,"context_line":"                action-classes\u003d\" \u0027\u0027 \""},{"line_number":29,"context_line":"                callback\u003d\"ctrl.editImage\""},{"line_number":30,"context_line":"                item\u003d\"ctrl.image.id\"\u003e"},{"line_number":31,"context_line":"          {$ \u0027Edit\u0027 | translate $}"}],"source_content_type":"text/html","patch_set":56,"id":"1a4dcd0f_6c2b9083","line":28,"in_reply_to":"3a50d1a3_a33407df","updated":"2015-08-03 23:09:20.000000000","message":"Done","commit_id":"2d7da9fcd5c651077aaeb8342f125f501b0aa66b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"11dce78d8d173ce31d7360cc0436d352fb34762e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    \u003chz-property-group\u003e"},{"line_number":6,"context_line":"      \u003chz-property label\u003d\"\u0027Owner\u0027 | translate\" value\u003d\"ctrl.project.name\"\u003e\u003c/hz-property\u003e"},{"line_number":7,"context_line":"      \u003chz-property label\u003d\"\u0027Status\u0027 | translate\" value\u003d\"ctrl.image.status | decode:ctrl.imageStatus\"\u003e\u003c/hz-property\u003e"},{"line_number":8,"context_line":"      \u003chz-property label\u003d\"\u0027Filename\u0027 | translate\" value\u003d\"ctrl.image.properties.filename\" ng-if\u003d\"ctrl.image.properties.filename\"\u003e\u003c/hz-property\u003e"},{"line_number":9,"context_line":"    \u003c/hz-property-group\u003e"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    \u003caction-list dropdown\u003e"}],"source_content_type":"text/html","patch_set":83,"id":"fa1b9901_c6071f17","line":8,"updated":"2015-08-21 21:42:57.000000000","message":"Image type is a special kind of property telling whether it is an image or an instance snapshot.  This should be displayed and should use this filter:\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/filters/image-type.filter.js","commit_id":"91b330d98da0e2a963c42c6a37180c60ed0f8fa9"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"1ec902a60a85ba83fa35918a1507d259598851df","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    \u003chz-property-group\u003e"},{"line_number":6,"context_line":"      \u003chz-property label\u003d\"\u0027Owner\u0027 | translate\" value\u003d\"ctrl.project.name\"\u003e\u003c/hz-property\u003e"},{"line_number":7,"context_line":"      \u003chz-property label\u003d\"\u0027Status\u0027 | translate\" value\u003d\"ctrl.image.status | decode:ctrl.imageStatus\"\u003e\u003c/hz-property\u003e"},{"line_number":8,"context_line":"      \u003chz-property label\u003d\"\u0027Filename\u0027 | translate\" value\u003d\"ctrl.image.properties.filename\" ng-if\u003d\"ctrl.image.properties.filename\"\u003e\u003c/hz-property\u003e"},{"line_number":9,"context_line":"    \u003c/hz-property-group\u003e"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    \u003caction-list dropdown\u003e"}],"source_content_type":"text/html","patch_set":83,"id":"fa1b9901_08b8c5e4","line":8,"in_reply_to":"fa1b9901_c6071f17","updated":"2015-08-21 22:26:37.000000000","message":"Done","commit_id":"91b330d98da0e2a963c42c6a37180c60ed0f8fa9"},{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"1ef6e6b7b611cab509dd59f42788ba407f51017e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\"content\" ng-controller\u003d\"ImageDetailController as ctrl\"\u003e"},{"line_number":2,"context_line":"  \u003cdiv class\u003d\u0027page-header\u0027\u003e"},{"line_number":3,"context_line":"    \u003ch1\u003e{$ ctrl.image.name $}\u003c/h1\u003e"},{"line_number":4,"context_line":"    \u003cp\u003e{$ ctrl.image.properties.description $}\u003c/p\u003e"},{"line_number":5,"context_line":"  \u003c/div\u003e"},{"line_number":6,"context_line":"  \u003cdiv class\u003d\"detail-page\"\u003e"}],"source_content_type":"text/html","patch_set":107,"id":"3a29b11f_f894c943","line":3,"updated":"2015-10-21 00:23:55.000000000","message":"one-time binding.","commit_id":"1c36ac4cbe5cae59cfd9e47db8e68938059a6b4a"},{"author":{"_account_id":17002,"name":"Coleman Beasley","email":"cbeasley@thoughtworks.com","username":"cbeasley"},"change_message_id":"54e38b6d80174bde20853a870983584608ab62cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\"content\" ng-controller\u003d\"ImageDetailController as ctrl\"\u003e"},{"line_number":2,"context_line":"  \u003cdiv class\u003d\u0027page-header\u0027\u003e"},{"line_number":3,"context_line":"    \u003ch1\u003e{$ ctrl.image.name $}\u003c/h1\u003e"},{"line_number":4,"context_line":"    \u003cp\u003e{$ ctrl.image.properties.description $}\u003c/p\u003e"},{"line_number":5,"context_line":"  \u003c/div\u003e"},{"line_number":6,"context_line":"  \u003cdiv class\u003d\"detail-page\"\u003e"}],"source_content_type":"text/html","patch_set":107,"id":"3a29b11f_591ec370","line":3,"in_reply_to":"3a29b11f_f894c943","updated":"2015-10-23 00:30:48.000000000","message":"Done","commit_id":"1c36ac4cbe5cae59cfd9e47db8e68938059a6b4a"},{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"1ef6e6b7b611cab509dd59f42788ba407f51017e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\"content\" ng-controller\u003d\"ImageDetailController as ctrl\"\u003e"},{"line_number":2,"context_line":"  \u003cdiv class\u003d\u0027page-header\u0027\u003e"},{"line_number":3,"context_line":"    \u003ch1\u003e{$ ctrl.image.name $}\u003c/h1\u003e"},{"line_number":4,"context_line":"    \u003cp\u003e{$ ctrl.image.properties.description $}\u003c/p\u003e"},{"line_number":5,"context_line":"  \u003c/div\u003e"},{"line_number":6,"context_line":"  \u003cdiv class\u003d\"detail-page\"\u003e"},{"line_number":7,"context_line":"    \u003cdiv class\u003d\"detail-statuses\"\u003e"}],"source_content_type":"text/html","patch_set":107,"id":"3a29b11f_989d9568","line":4,"updated":"2015-10-21 00:23:55.000000000","message":"one-time binding.","commit_id":"1c36ac4cbe5cae59cfd9e47db8e68938059a6b4a"},{"author":{"_account_id":17002,"name":"Coleman Beasley","email":"cbeasley@thoughtworks.com","username":"cbeasley"},"change_message_id":"54e38b6d80174bde20853a870983584608ab62cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\"content\" ng-controller\u003d\"ImageDetailController as ctrl\"\u003e"},{"line_number":2,"context_line":"  \u003cdiv class\u003d\u0027page-header\u0027\u003e"},{"line_number":3,"context_line":"    \u003ch1\u003e{$ ctrl.image.name $}\u003c/h1\u003e"},{"line_number":4,"context_line":"    \u003cp\u003e{$ ctrl.image.properties.description $}\u003c/p\u003e"},{"line_number":5,"context_line":"  \u003c/div\u003e"},{"line_number":6,"context_line":"  \u003cdiv class\u003d\"detail-page\"\u003e"},{"line_number":7,"context_line":"    \u003cdiv class\u003d\"detail-statuses\"\u003e"}],"source_content_type":"text/html","patch_set":107,"id":"3a29b11f_f910ef5a","line":4,"in_reply_to":"3a29b11f_989d9568","updated":"2015-10-23 00:30:48.000000000","message":"Done","commit_id":"1c36ac4cbe5cae59cfd9e47db8e68938059a6b4a"},{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"1ef6e6b7b611cab509dd59f42788ba407f51017e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  \u003cdiv class\u003d\"detail-page\"\u003e"},{"line_number":7,"context_line":"    \u003cdiv class\u003d\"detail-statuses\"\u003e"},{"line_number":8,"context_line":"      \u003cdiv class\u003d\"{$ propertyClasses $}\"\u003e"},{"line_number":9,"context_line":"        \u003cb translate\u003eOwner\u003c/b\u003e"},{"line_number":10,"context_line":"        {$ ctrl.project.name $}"},{"line_number":11,"context_line":"      \u003c/div\u003e"},{"line_number":12,"context_line":"      \u003cdiv class\u003d\"{$ propertyClasses $}\"\u003e"}],"source_content_type":"text/html","patch_set":107,"id":"3a29b11f_d8a54da2","line":9,"updated":"2015-10-21 00:23:55.000000000","message":"can we avoid using \u003cb\u003e?","commit_id":"1c36ac4cbe5cae59cfd9e47db8e68938059a6b4a"},{"author":{"_account_id":17002,"name":"Coleman Beasley","email":"cbeasley@thoughtworks.com","username":"cbeasley"},"change_message_id":"54e38b6d80174bde20853a870983584608ab62cc","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  \u003cdiv class\u003d\"detail-page\"\u003e"},{"line_number":7,"context_line":"    \u003cdiv class\u003d\"detail-statuses\"\u003e"},{"line_number":8,"context_line":"      \u003cdiv class\u003d\"{$ propertyClasses $}\"\u003e"},{"line_number":9,"context_line":"        \u003cb translate\u003eOwner\u003c/b\u003e"},{"line_number":10,"context_line":"        {$ ctrl.project.name $}"},{"line_number":11,"context_line":"      \u003c/div\u003e"},{"line_number":12,"context_line":"      \u003cdiv class\u003d\"{$ propertyClasses $}\"\u003e"}],"source_content_type":"text/html","patch_set":107,"id":"3a29b11f_6a7abf89","line":9,"in_reply_to":"3a29b11f_d8a54da2","updated":"2015-10-23 00:30:48.000000000","message":"Done, converted to strong","commit_id":"1c36ac4cbe5cae59cfd9e47db8e68938059a6b4a"},{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"1ef6e6b7b611cab509dd59f42788ba407f51017e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \u003cdiv class\u003d\"detail-statuses\"\u003e"},{"line_number":8,"context_line":"      \u003cdiv class\u003d\"{$ propertyClasses $}\"\u003e"},{"line_number":9,"context_line":"        \u003cb translate\u003eOwner\u003c/b\u003e"},{"line_number":10,"context_line":"        {$ ctrl.project.name $}"},{"line_number":11,"context_line":"      \u003c/div\u003e"},{"line_number":12,"context_line":"      \u003cdiv class\u003d\"{$ propertyClasses $}\"\u003e"},{"line_number":13,"context_line":"        \u003cb translate\u003eStatus\u003c/b\u003e"}],"source_content_type":"text/html","patch_set":107,"id":"3a29b11f_b8717146","line":10,"updated":"2015-10-21 00:23:55.000000000","message":"one-time binding.","commit_id":"1c36ac4cbe5cae59cfd9e47db8e68938059a6b4a"},{"author":{"_account_id":17002,"name":"Coleman Beasley","email":"cbeasley@thoughtworks.com","username":"cbeasley"},"change_message_id":"54e38b6d80174bde20853a870983584608ab62cc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \u003cdiv class\u003d\"detail-statuses\"\u003e"},{"line_number":8,"context_line":"      \u003cdiv class\u003d\"{$ propertyClasses $}\"\u003e"},{"line_number":9,"context_line":"        \u003cb translate\u003eOwner\u003c/b\u003e"},{"line_number":10,"context_line":"        {$ ctrl.project.name $}"},{"line_number":11,"context_line":"      \u003c/div\u003e"},{"line_number":12,"context_line":"      \u003cdiv class\u003d\"{$ propertyClasses $}\"\u003e"},{"line_number":13,"context_line":"        \u003cb translate\u003eStatus\u003c/b\u003e"}],"source_content_type":"text/html","patch_set":107,"id":"3a29b11f_d90ad325","line":10,"in_reply_to":"3a29b11f_b8717146","updated":"2015-10-23 00:30:48.000000000","message":"Done","commit_id":"1c36ac4cbe5cae59cfd9e47db8e68938059a6b4a"},{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"1ef6e6b7b611cab509dd59f42788ba407f51017e","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    \u003caction-list dropdown\u003e"},{"line_number":27,"context_line":"      \u003caction button-type\u003d\"split-button\""},{"line_number":28,"context_line":"              action-classes\u003d\" \u0027btn btn-default\u0027 \""},{"line_number":29,"context_line":"              callback\u003d\"ctrl.launchImage\""},{"line_number":30,"context_line":"              item\u003d\"ctrl.image.id\"\u003e"},{"line_number":31,"context_line":"        {$ \u0027Launch\u0027 | translate $}"}],"source_content_type":"text/html","patch_set":107,"id":"3a29b11f_78a8b98d","line":28,"updated":"2015-10-21 00:23:55.000000000","message":"nit: please remove extra whitespaces in \" \u0027btn btn-default\u0027 \"","commit_id":"1c36ac4cbe5cae59cfd9e47db8e68938059a6b4a"},{"author":{"_account_id":17002,"name":"Coleman Beasley","email":"cbeasley@thoughtworks.com","username":"cbeasley"},"change_message_id":"54e38b6d80174bde20853a870983584608ab62cc","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    \u003caction-list dropdown\u003e"},{"line_number":27,"context_line":"      \u003caction button-type\u003d\"split-button\""},{"line_number":28,"context_line":"              action-classes\u003d\" \u0027btn btn-default\u0027 \""},{"line_number":29,"context_line":"              callback\u003d\"ctrl.launchImage\""},{"line_number":30,"context_line":"              item\u003d\"ctrl.image.id\"\u003e"},{"line_number":31,"context_line":"        {$ \u0027Launch\u0027 | translate $}"}],"source_content_type":"text/html","patch_set":107,"id":"3a29b11f_ca6bd3b5","line":28,"in_reply_to":"3a29b11f_78a8b98d","updated":"2015-10-23 00:30:48.000000000","message":"Done","commit_id":"1c36ac4cbe5cae59cfd9e47db8e68938059a6b4a"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"ea37286f6918508a2784d184f12575fcdc30027a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        {$ ::ctrl.project.name $}"},{"line_number":11,"context_line":"      \u003c/div\u003e"},{"line_number":12,"context_line":"      \u003cdiv class\u003d\"{$ propertyClasses $}\"\u003e"},{"line_number":13,"context_line":"        \u003cb translate\u003eStatus\u003c/b\u003e"},{"line_number":14,"context_line":"        {$ ::ctrl.image.status $}"},{"line_number":15,"context_line":"      \u003c/div\u003e"},{"line_number":16,"context_line":"      \u003cdiv class\u003d\"{$ propertyClasses $}\" ng-if\u003d\"ctrl.image.properties.filename\"\u003e"}],"source_content_type":"text/html","patch_set":110,"id":"3a29b11f_ea08c593","line":13,"updated":"2015-10-26 14:01:43.000000000","message":"shouldn\u0027t these be using \u003cstrong\u003e or \u003cem\u003e?","commit_id":"693ab09e1ccd25a82b37b8c9878f0274830d0725"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"0cac7af3c7e8010746c91f0cc28c52ae2045c618","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        {$ ::ctrl.project.name $}"},{"line_number":11,"context_line":"      \u003c/div\u003e"},{"line_number":12,"context_line":"      \u003cdiv class\u003d\"{$ propertyClasses $}\"\u003e"},{"line_number":13,"context_line":"        \u003cb translate\u003eStatus\u003c/b\u003e"},{"line_number":14,"context_line":"        {$ ::ctrl.image.status $}"},{"line_number":15,"context_line":"      \u003c/div\u003e"},{"line_number":16,"context_line":"      \u003cdiv class\u003d\"{$ propertyClasses $}\" ng-if\u003d\"ctrl.image.properties.filename\"\u003e"}],"source_content_type":"text/html","patch_set":110,"id":"3a29b11f_c45ff873","line":13,"in_reply_to":"3a29b11f_ea08c593","updated":"2015-10-26 17:39:55.000000000","message":"Done","commit_id":"693ab09e1ccd25a82b37b8c9878f0274830d0725"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"ea37286f6918508a2784d184f12575fcdc30027a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"              action-classes\u003d\"\u0027btn btn-default\u0027\""},{"line_number":29,"context_line":"              callback\u003d\"\""},{"line_number":30,"context_line":"              item\u003d\"ctrl.image.id\"\u003e"},{"line_number":31,"context_line":"        {$ \u0027Launch\u0027 | translate $}"},{"line_number":32,"context_line":"      \u003c/action\u003e"},{"line_number":33,"context_line":"      \u003cmenu\u003e"},{"line_number":34,"context_line":"        \u003caction button-type\u003d\"menu-item\""}],"source_content_type":"text/html","patch_set":110,"id":"3a29b11f_8aafd17c","line":31,"updated":"2015-10-26 14:01:43.000000000","message":"nit: I know they\u0027re equivalent, but I guess using the \u003ctranslate\u003e tag would be more appropriate/readable.","commit_id":"693ab09e1ccd25a82b37b8c9878f0274830d0725"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"0cac7af3c7e8010746c91f0cc28c52ae2045c618","unresolved":false,"context_lines":[{"line_number":28,"context_line":"              action-classes\u003d\"\u0027btn btn-default\u0027\""},{"line_number":29,"context_line":"              callback\u003d\"\""},{"line_number":30,"context_line":"              item\u003d\"ctrl.image.id\"\u003e"},{"line_number":31,"context_line":"        {$ \u0027Launch\u0027 | translate $}"},{"line_number":32,"context_line":"      \u003c/action\u003e"},{"line_number":33,"context_line":"      \u003cmenu\u003e"},{"line_number":34,"context_line":"        \u003caction button-type\u003d\"menu-item\""}],"source_content_type":"text/html","patch_set":110,"id":"3a29b11f_2474acfb","line":31,"in_reply_to":"3a29b11f_8aafd17c","updated":"2015-10-26 17:39:55.000000000","message":"Done","commit_id":"693ab09e1ccd25a82b37b8c9878f0274830d0725"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"503f31960313be3f8bba3962c09e2c68618ce0ab","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      \u003c/div\u003e"},{"line_number":24,"context_line":"    \u003c/div\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    \u003caction-list dropdown\u003e"},{"line_number":27,"context_line":"      \u003caction button-type\u003d\"split-button\""},{"line_number":28,"context_line":"              action-classes\u003d\"\u0027btn btn-default\u0027\""},{"line_number":29,"context_line":"              callback\u003d\"\""}],"source_content_type":"text/html","patch_set":112,"id":"fa80f949_27326511","line":26,"updated":"2015-11-04 20:12:23.000000000","message":"I haven\u0027t looked into it, but somewhere in the action-list block we get a transclusion error.  If this block is commented out, the error is not generated.","commit_id":"08380b8bc2a6d760910cc9e961e71698ee6f943a"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"201ea42dbe3f52569e7fe5414aa69fcce19f34bf","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            \u003c/dl\u003e"},{"line_number":94,"context_line":"          \u003c/div\u003e"},{"line_number":95,"context_line":"          \u003cdiv class\u003d\"col-md-6\"\u003e"},{"line_number":96,"context_line":"            \u003ch3\u003eCustom Properties\u003c/h3\u003e"},{"line_number":97,"context_line":"            \u003chr class\u003d\"header-rule\"\u003e"},{"line_number":98,"context_line":"            \u003cdl class\u003d\"dl-horizontal\"\u003e"},{"line_number":99,"context_line":"              \u003cdiv ng-repeat\u003d\"prop in ctrl.image.properties\"\u003e"}],"source_content_type":"text/html","patch_set":120,"id":"da85f559_a6b41735","line":96,"updated":"2015-11-14 16:00:44.000000000","message":"Translate?","commit_id":"0b0325b40e59a64f9902c9139e69db667577e025"},{"author":{"_account_id":17327,"name":"Kyle Olivo","email":"keolivo@thoughtworks.com","username":"kyleolivo"},"change_message_id":"f23bb71ac6676d42221493311f1ae19ca5bf7c47","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            \u003c/dl\u003e"},{"line_number":94,"context_line":"          \u003c/div\u003e"},{"line_number":95,"context_line":"          \u003cdiv class\u003d\"col-md-6\"\u003e"},{"line_number":96,"context_line":"            \u003ch3\u003eCustom Properties\u003c/h3\u003e"},{"line_number":97,"context_line":"            \u003chr class\u003d\"header-rule\"\u003e"},{"line_number":98,"context_line":"            \u003cdl class\u003d\"dl-horizontal\"\u003e"},{"line_number":99,"context_line":"              \u003cdiv ng-repeat\u003d\"prop in ctrl.image.properties\"\u003e"}],"source_content_type":"text/html","patch_set":120,"id":"ba8a016a_b3548554","line":96,"in_reply_to":"da85f559_a6b41735","updated":"2015-11-16 18:29:20.000000000","message":"Done","commit_id":"0b0325b40e59a64f9902c9139e69db667577e025"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"4d35134f4808ee1a454bcdc0eff17aff63d69aa5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      \u003cli class\u003d\"active\"\u003e{$ ::ctrl.image.name $}\u003c/li\u003e"},{"line_number":6,"context_line":"    \u003c/ol\u003e"},{"line_number":7,"context_line":"    \u003cp\u003e{$ ctrl.image.properties.description $}\u003c/p\u003e"},{"line_number":8,"context_line":"    \u003cul class\u003d\"list-inline\"\u003e"},{"line_number":9,"context_line":"      \u003cli\u003e"},{"line_number":10,"context_line":"        \u003cstrong translate\u003eOwner\u003c/strong\u003e"},{"line_number":11,"context_line":"        {$ ::ctrl.project.name $}"}],"source_content_type":"text/html","patch_set":122,"id":"ba8a016a_3946817b","line":8,"updated":"2015-11-19 16:08:20.000000000","message":"Is there any special reason you\u0027ve used ul/li here, but dl/dt/dd below? This seems like very similar kinds of content to me. If there is no compelling reason to make them different, I prefer the dl/dt/dd pattern - I\u0027d expect that will lead to easier accessibility since the relationship between the label and it\u0027s value is more explicit.","commit_id":"7c6e2962301fc40fe7f2b9f7ba24f01d3f2166ae"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3c13bbf59ded75775237b54b5785d21b31112711","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      \u003cli class\u003d\"active\"\u003e{$ ::ctrl.image.name $}\u003c/li\u003e"},{"line_number":6,"context_line":"    \u003c/ol\u003e"},{"line_number":7,"context_line":"    \u003cp\u003e{$ ctrl.image.properties.description $}\u003c/p\u003e"},{"line_number":8,"context_line":"    \u003cul class\u003d\"list-inline\"\u003e"},{"line_number":9,"context_line":"      \u003cli\u003e"},{"line_number":10,"context_line":"        \u003cstrong translate\u003eOwner\u003c/strong\u003e"},{"line_number":11,"context_line":"        {$ ::ctrl.project.name $}"}],"source_content_type":"text/html","patch_set":122,"id":"ba8a016a_51347948","line":8,"in_reply_to":"ba8a016a_3946817b","updated":"2015-11-19 16:47:13.000000000","message":"In using *standard* bootstrap, this is a reasonable way of presenting inline information.  I\u0027ll rely on Diana to help identify a different route, but I\u0027d rather not mess around with the css too much.","commit_id":"7c6e2962301fc40fe7f2b9f7ba24f01d3f2166ae"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"4d35134f4808ee1a454bcdc0eff17aff63d69aa5","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            \u003cdl class\u003d\"dl-horizontal\"\u003e"},{"line_number":99,"context_line":"              \u003cdiv ng-repeat\u003d\"prop in ctrl.image.properties\"\u003e"},{"line_number":100,"context_line":"                \u003cdiv class\u003d\"{$ propertyClasses $}\"\u003e"},{"line_number":101,"context_line":"                  \u003cdt translate\u003e{$ prop.name $}\u003c/dt\u003e"},{"line_number":102,"context_line":"                  \u003cdd\u003e{$ prop.value $}\u003c/dd\u003e"},{"line_number":103,"context_line":"                \u003c/div\u003e"},{"line_number":104,"context_line":"              \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":122,"id":"ba8a016a_1e6cc306","line":101,"updated":"2015-11-19 16:08:20.000000000","message":"I don\u0027t think the name should be translated here. This should be handled by IMAGE_CUSTOM_PROPERTY_TITLES. I\u0027m concerned just arbitrarily treating every property name as a potential translatable will result in unexpected/surprise translations.","commit_id":"7c6e2962301fc40fe7f2b9f7ba24f01d3f2166ae"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"30f327026569cd77c260ae84514ae370bf5aca1d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            \u003cdl class\u003d\"dl-horizontal\"\u003e"},{"line_number":99,"context_line":"              \u003cdiv ng-repeat\u003d\"prop in ctrl.image.properties\"\u003e"},{"line_number":100,"context_line":"                \u003cdiv class\u003d\"{$ propertyClasses $}\"\u003e"},{"line_number":101,"context_line":"                  \u003cdt translate\u003e{$ prop.name $}\u003c/dt\u003e"},{"line_number":102,"context_line":"                  \u003cdd\u003e{$ prop.value $}\u003c/dd\u003e"},{"line_number":103,"context_line":"                \u003c/div\u003e"},{"line_number":104,"context_line":"              \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":122,"id":"ba8a016a_7d80678b","line":101,"in_reply_to":"ba8a016a_112a71db","updated":"2015-11-19 20:27:08.000000000","message":"Done","commit_id":"7c6e2962301fc40fe7f2b9f7ba24f01d3f2166ae"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3c13bbf59ded75775237b54b5785d21b31112711","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            \u003cdl class\u003d\"dl-horizontal\"\u003e"},{"line_number":99,"context_line":"              \u003cdiv ng-repeat\u003d\"prop in ctrl.image.properties\"\u003e"},{"line_number":100,"context_line":"                \u003cdiv class\u003d\"{$ propertyClasses $}\"\u003e"},{"line_number":101,"context_line":"                  \u003cdt translate\u003e{$ prop.name $}\u003c/dt\u003e"},{"line_number":102,"context_line":"                  \u003cdd\u003e{$ prop.value $}\u003c/dd\u003e"},{"line_number":103,"context_line":"                \u003c/div\u003e"},{"line_number":104,"context_line":"              \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":122,"id":"ba8a016a_112a71db","line":101,"in_reply_to":"ba8a016a_1e6cc306","updated":"2015-11-19 16:47:13.000000000","message":"That is true, since it\u0027s dynamic there\u0027s nothing that can feed the message collection.  I\u0027ll just take the translate out.","commit_id":"7c6e2962301fc40fe7f2b9f7ba24f01d3f2166ae"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"bafea72fe40e7071446d13b9a27642bed67169cd","unresolved":false,"context_lines":[{"line_number":88,"context_line":"              \u003c/div\u003e"},{"line_number":89,"context_line":"              \u003cdiv class\u003d\"{$ propertyClasses $}\"\u003e"},{"line_number":90,"context_line":"                \u003cdt translate\u003eID\u003c/dt\u003e"},{"line_number":91,"context_line":"                \u003cdd\u003e{$ ctrl.image.id $}\u003c/dd\u003e"},{"line_number":92,"context_line":"              \u003c/div\u003e"},{"line_number":93,"context_line":"            \u003c/dl\u003e"},{"line_number":94,"context_line":"          \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":129,"id":"9a8ffd7b_ca25c20a","line":91,"updated":"2015-12-01 05:52:58.000000000","message":"Why is id here ? IMO, It\u0027s basic information. so it should display at the top section. If it already finished to discussion about it , please let my opinion ignore.","commit_id":"b35072265f2034c94937b9935deda2c7230e712d"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"47d83f4051a385441ba5d242e9a15c3ab39e885d","unresolved":false,"context_lines":[{"line_number":88,"context_line":"              \u003c/div\u003e"},{"line_number":89,"context_line":"              \u003cdiv class\u003d\"{$ propertyClasses $}\"\u003e"},{"line_number":90,"context_line":"                \u003cdt translate\u003eID\u003c/dt\u003e"},{"line_number":91,"context_line":"                \u003cdd\u003e{$ ctrl.image.id $}\u003c/dd\u003e"},{"line_number":92,"context_line":"              \u003c/div\u003e"},{"line_number":93,"context_line":"            \u003c/dl\u003e"},{"line_number":94,"context_line":"          \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":129,"id":"9a8ffd7b_9ca3699e","line":91,"in_reply_to":"9a8ffd7b_ca25c20a","updated":"2015-12-01 14:30:10.000000000","message":"Good question, although since this design has passed the UX review we should use that approval as our guide, so I will leave this here.","commit_id":"b35072265f2034c94937b9935deda2c7230e712d"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"42b412999c868d40c27feaa98f660829848e5239","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      \u003c/li\u003e"},{"line_number":21,"context_line":"      \u003cli class\u003d\"{$ propertyClasses $}\"\u003e"},{"line_number":22,"context_line":"        \u003cstrong translate\u003eType\u003c/strong\u003e"},{"line_number":23,"context_line":"        {$ ::ctrl.image | imageType $}"},{"line_number":24,"context_line":"      \u003c/li\u003e"},{"line_number":25,"context_line":"    \u003c/ul\u003e"},{"line_number":26,"context_line":"  \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":136,"id":"fa69d971_d43d9d2b","line":23,"range":{"start_line":23,"start_character":11,"end_line":23,"end_character":13},"updated":"2016-01-07 00:17:18.000000000","message":"-1: Because a filter is being used, and that filter ALWAYS returns \u0027Image\u0027 on null inputs, this one time binding will mis-categorize Snapshots as Images.\n\nIt turns out using filters with one time bindings is tricky because if the filter returns a \"stable\" value, the binding won\u0027t be re-evaulated once the actual image data is loaded.","commit_id":"cb988e5881dd5914882571c038b05a9be6d7dc50"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"42b412999c868d40c27feaa98f660829848e5239","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \u003c/div\u003e"},{"line_number":69,"context_line":"            \u003cdiv class\u003d\"{$ propertyClasses $}\"\u003e"},{"line_number":70,"context_line":"              \u003cdt translate\u003eChecksum\u003c/dt\u003e"},{"line_number":71,"context_line":"              \u003cdd\u003e{$ ctrl.image.checksum $}\u003c/dd\u003e"},{"line_number":72,"context_line":"            \u003c/div\u003e"},{"line_number":73,"context_line":"          \u003c/dl\u003e"},{"line_number":74,"context_line":"        \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":136,"id":"fa69d971_9443a5ae","line":71,"range":{"start_line":71,"start_character":21,"end_line":71,"end_character":25},"updated":"2016-01-07 00:17:18.000000000","message":"nit: one time binding can be used here","commit_id":"cb988e5881dd5914882571c038b05a9be6d7dc50"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"42b412999c868d40c27feaa98f660829848e5239","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            \u003c/div\u003e"},{"line_number":89,"context_line":"            \u003cdiv class\u003d\"{$ propertyClasses $}\"\u003e"},{"line_number":90,"context_line":"              \u003cdt translate\u003eID\u003c/dt\u003e"},{"line_number":91,"context_line":"              \u003cdd\u003e{$ ctrl.image.id $}\u003c/dd\u003e"},{"line_number":92,"context_line":"            \u003c/div\u003e"},{"line_number":93,"context_line":"          \u003c/dl\u003e"},{"line_number":94,"context_line":"        \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":136,"id":"fa69d971_5418cdd2","line":91,"range":{"start_line":91,"start_character":21,"end_line":91,"end_character":25},"updated":"2016-01-07 00:17:18.000000000","message":"nit: one time binding can be used here","commit_id":"cb988e5881dd5914882571c038b05a9be6d7dc50"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"c1194fb9f41ce888959579af5744814bf43de31a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\"content\" ng-controller\u003d\"ImageDetailController as ctrl\"\u003e"},{"line_number":2,"context_line":"  \u003cdiv class\u003d\"page-header\"\u003e"},{"line_number":3,"context_line":"    \u003col class\u003d\"breadcrumb\"\u003e"},{"line_number":4,"context_line":"      \u003cli\u003e\u003ca href\u003d\"{$ $window.WEBROOT $}project/ngimages/\"\u003e\u003ctranslate\u003eImages\u003c/translate\u003e\u003c/a\u003e\u003c/li\u003e"},{"line_number":5,"context_line":"      \u003cli class\u003d\"active\"\u003e{$ ::ctrl.image.name $}\u003c/li\u003e"},{"line_number":6,"context_line":"    \u003c/ol\u003e"},{"line_number":7,"context_line":"    \u003cp\u003e{$ ctrl.image.properties.description $}\u003c/p\u003e"}],"source_content_type":"text/html","patch_set":138,"id":"fa69d971_8f3039a0","line":4,"range":{"start_line":4,"start_character":22,"end_line":4,"end_character":57},"updated":"2016-01-07 23:26:56.000000000","message":"Now the view explicitly depends on some generous parent scope having a $window. That makes this view difficult to maintain. Instead, consider letting the controller figure out what the correct URL is supposed to be, save that in something like ctrl.imageURL and update the view to simply use that variable.","commit_id":"97acbd9fc8bcffd8566d5df26248480f716285fb"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"376cdba92af3e6f4a3943d3bdfe7dd0a4935d7ba","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\"content\" ng-controller\u003d\"ImageDetailController as ctrl\"\u003e"},{"line_number":2,"context_line":"  \u003cdiv class\u003d\"page-header\"\u003e"},{"line_number":3,"context_line":"    \u003col class\u003d\"breadcrumb\"\u003e"},{"line_number":4,"context_line":"      \u003cli\u003e\u003ca href\u003d\"{$ ctrl.baseUrl $}\"\u003e\u003ctranslate\u003eImages\u003c/translate\u003e\u003c/a\u003e\u003c/li\u003e"}],"source_content_type":"text/html","patch_set":143,"id":"fa69d971_5cbaa8e2","line":1,"range":{"start_line":1,"start_character":5,"end_line":1,"end_character":19},"updated":"2016-01-08 22:15:04.000000000","message":"nit: Can be removed.","commit_id":"3a106014e2b8e2cb797ec959eb33dd8a3a172c26"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"c306d6508d6021d801371ed9c9bb274ec0817878","unresolved":false,"context_lines":[{"line_number":59,"context_line":"          \u003chr\u003e"},{"line_number":60,"context_line":"          \u003cdl class\u003d\"dl-horizontal\"\u003e"},{"line_number":61,"context_line":"            \u003cdiv\u003e"},{"line_number":62,"context_line":"              \u003cdt translate\u003ePublic\u003c/dt\u003e"},{"line_number":63,"context_line":"              \u003cdd\u003e{$ ctrl.image.is_public | yesno $}\u003c/dd\u003e"},{"line_number":64,"context_line":"            \u003c/div\u003e"},{"line_number":65,"context_line":"            \u003cdiv\u003e"}],"source_content_type":"text/html","patch_set":147,"id":"ba63e191_f163a83f","line":62,"updated":"2016-01-19 22:55:29.000000000","message":"Shouldn\u0027t we change this to visibility so that this page supports the fact that it can be public, private, or shared? Right now I have visibility filter in the magic search patch, which actually doesn\u0027t make sense. I suppose I should pull it into its won patch so it could be used here or make it dependent on this patch and change the table at the same time.\n\nhttps://review.openstack.org/#/c/217437/8/openstack_dashboard/static/app/core/images/filters/image-visibility.filter.js\n\nhttps://review.openstack.org/#/c/217437/8/openstack_dashboard/static/app/core/images/table/images-table.html","commit_id":"d9aff56da58ed433cf24e7e7e94cb06fa6655125"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8ac5f1501ea83d5400e4d711f877d9b09d7e663e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"          \u003chr\u003e"},{"line_number":60,"context_line":"          \u003cdl class\u003d\"dl-horizontal\"\u003e"},{"line_number":61,"context_line":"            \u003cdiv\u003e"},{"line_number":62,"context_line":"              \u003cdt translate\u003ePublic\u003c/dt\u003e"},{"line_number":63,"context_line":"              \u003cdd\u003e{$ ctrl.image.is_public | yesno $}\u003c/dd\u003e"},{"line_number":64,"context_line":"            \u003c/div\u003e"},{"line_number":65,"context_line":"            \u003cdiv\u003e"}],"source_content_type":"text/html","patch_set":147,"id":"7a5de9d1_ca3147ee","line":62,"in_reply_to":"9a68dd71_762fe7a1","updated":"2016-01-27 18:58:49.000000000","message":"Done, and uses your imageVisibility filter.","commit_id":"d9aff56da58ed433cf24e7e7e94cb06fa6655125"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"2481f2fa335a4170c466bf6bfbf57e370aaf1f75","unresolved":false,"context_lines":[{"line_number":59,"context_line":"          \u003chr\u003e"},{"line_number":60,"context_line":"          \u003cdl class\u003d\"dl-horizontal\"\u003e"},{"line_number":61,"context_line":"            \u003cdiv\u003e"},{"line_number":62,"context_line":"              \u003cdt translate\u003ePublic\u003c/dt\u003e"},{"line_number":63,"context_line":"              \u003cdd\u003e{$ ctrl.image.is_public | yesno $}\u003c/dd\u003e"},{"line_number":64,"context_line":"            \u003c/div\u003e"},{"line_number":65,"context_line":"            \u003cdiv\u003e"}],"source_content_type":"text/html","patch_set":147,"id":"9a68dd71_762fe7a1","line":62,"in_reply_to":"ba63e191_6c9b5e73","updated":"2016-01-20 19:32:53.000000000","message":"FYI, I have now made the visibility filter independent of the magic search patch:\n\nhttps://review.openstack.org/#/c/270439/","commit_id":"d9aff56da58ed433cf24e7e7e94cb06fa6655125"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"3707dd4761a2a197bdc3d63487bc8ce34df20f9e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"          \u003chr\u003e"},{"line_number":60,"context_line":"          \u003cdl class\u003d\"dl-horizontal\"\u003e"},{"line_number":61,"context_line":"            \u003cdiv\u003e"},{"line_number":62,"context_line":"              \u003cdt translate\u003ePublic\u003c/dt\u003e"},{"line_number":63,"context_line":"              \u003cdd\u003e{$ ctrl.image.is_public | yesno $}\u003c/dd\u003e"},{"line_number":64,"context_line":"            \u003c/div\u003e"},{"line_number":65,"context_line":"            \u003cdiv\u003e"}],"source_content_type":"text/html","patch_set":147,"id":"ba63e191_6c9b5e73","line":62,"in_reply_to":"ba63e191_f163a83f","updated":"2016-01-20 00:27:52.000000000","message":"Good catch. Will do","commit_id":"d9aff56da58ed433cf24e7e7e94cb06fa6655125"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"06053ff8f6f50631fd30f450cac6f3c2af846a56","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \u003cdiv class\u003d\"col-md-6\"\u003e"},{"line_number":32,"context_line":"          \u003ch3 translate\u003eImage\u003c/h3\u003e"},{"line_number":33,"context_line":"          \u003chr\u003e"},{"line_number":34,"context_line":"          \u003cdl class\u003d\"dl-horizontal\"\u003e"},{"line_number":35,"context_line":"            \u003cdiv\u003e"},{"line_number":36,"context_line":"              \u003cdt translate\u003eSize\u003c/dt\u003e"},{"line_number":37,"context_line":"              \u003cdd\u003e{$ ctrl.image.size | bytes $}\u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":150,"id":"5a5ae5dd_7aede6b5","line":34,"updated":"2016-02-06 15:35:04.000000000","message":"So right alignment for labels is right.  It seems very odd to me. \n\nIn the screenshot below, for some reason the security one in particular stands out because it is juxtaposed against the custom properties.\n\nhttp://pasteboard.co/1m1jrdHc.png","commit_id":"e75e9f008f21ead0c1bffba52048a6206a4edddb"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"335f5a0470567ed85eb4a9711e67f9fd6c1bbdf7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \u003cdiv class\u003d\"col-md-6\"\u003e"},{"line_number":32,"context_line":"          \u003ch3 translate\u003eImage\u003c/h3\u003e"},{"line_number":33,"context_line":"          \u003chr\u003e"},{"line_number":34,"context_line":"          \u003cdl class\u003d\"dl-horizontal\"\u003e"},{"line_number":35,"context_line":"            \u003cdiv\u003e"},{"line_number":36,"context_line":"              \u003cdt translate\u003eSize\u003c/dt\u003e"},{"line_number":37,"context_line":"              \u003cdd\u003e{$ ctrl.image.size | bytes $}\u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":150,"id":"5a5ae5dd_8f4870b4","line":34,"in_reply_to":"5a5ae5dd_7aede6b5","updated":"2016-02-08 17:03:30.000000000","message":"Yeah, I didn\u0027t want to mess with the current styles.  I\u0027ll see if I can ensure we\u0027re using the same styles (if appropriate) as on the Django-served pages.","commit_id":"e75e9f008f21ead0c1bffba52048a6206a4edddb"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"06053ff8f6f50631fd30f450cac6f3c2af846a56","unresolved":false,"context_lines":[{"line_number":98,"context_line":"          \u003cdl class\u003d\"dl-horizontal\"\u003e"},{"line_number":99,"context_line":"            \u003cdiv ng-repeat\u003d\"prop in ctrl.image.properties\"\u003e"},{"line_number":100,"context_line":"              \u003cdiv\u003e"},{"line_number":101,"context_line":"                \u003cdt\u003e{$ prop.name $}\u003c/dt\u003e"},{"line_number":102,"context_line":"                \u003cdd\u003e{$ prop.value $}\u003c/dd\u003e"},{"line_number":103,"context_line":"              \u003c/div\u003e"},{"line_number":104,"context_line":"            \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":150,"id":"5a5ae5dd_1a2dd2fd","line":101,"updated":"2016-02-06 15:35:04.000000000","message":"Should we tooltip the full property name since it gets truncated?\n\nhttp://pasteboard.co/1m1jrdHc.png","commit_id":"e75e9f008f21ead0c1bffba52048a6206a4edddb"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"335f5a0470567ed85eb4a9711e67f9fd6c1bbdf7","unresolved":false,"context_lines":[{"line_number":98,"context_line":"          \u003cdl class\u003d\"dl-horizontal\"\u003e"},{"line_number":99,"context_line":"            \u003cdiv ng-repeat\u003d\"prop in ctrl.image.properties\"\u003e"},{"line_number":100,"context_line":"              \u003cdiv\u003e"},{"line_number":101,"context_line":"                \u003cdt\u003e{$ prop.name $}\u003c/dt\u003e"},{"line_number":102,"context_line":"                \u003cdd\u003e{$ prop.value $}\u003c/dd\u003e"},{"line_number":103,"context_line":"              \u003c/div\u003e"},{"line_number":104,"context_line":"            \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":150,"id":"5a5ae5dd_cf6bc81c","line":101,"in_reply_to":"5a5ae5dd_1a2dd2fd","updated":"2016-02-08 17:03:30.000000000","message":"I\u0027m adding a simple title for now; a better tooltip is available but I have to do some extra wonkiness to make it work, might be better as an add-on patch.","commit_id":"e75e9f008f21ead0c1bffba52048a6206a4edddb"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"137165d68182f547a75d655de9936cc567f8fc4e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    \u003cul class\u003d\"list-inline\"\u003e"},{"line_number":9,"context_line":"      \u003cli\u003e"},{"line_number":10,"context_line":"        \u003cstrong translate\u003eOwner\u003c/strong\u003e"},{"line_number":11,"context_line":"        {$ ::ctrl.project.name $}"},{"line_number":12,"context_line":"      \u003c/li\u003e"},{"line_number":13,"context_line":"      \u003cli\u003e"},{"line_number":14,"context_line":"        \u003cstrong translate\u003eStatus\u003c/strong\u003e"}],"source_content_type":"text/html","patch_set":152,"id":"5a5ae5dd_e866ab28","line":11,"updated":"2016-02-08 23:35:12.000000000","message":"Project info isn\u0027t available to all users.  This needs to have some graceful degradation, I think.","commit_id":"a88bde2e0cca3533263dba1fbb5740bdc7e4f724"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"1c569290e56ff571e27ca7cd04dad1d84f27e706","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  \u003c/div\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  \u003ctabset\u003e"},{"line_number":25,"context_line":"    \u003ctab heading\u003d\"{$ \u0027Overview\u0027 | translate $}\"\u003e"},{"line_number":26,"context_line":"      \u003cdiv class\u003d\"row\"\u003e"},{"line_number":27,"context_line":"        \u003cdiv class\u003d\"col-md-6 detail\"\u003e"},{"line_number":28,"context_line":"          \u003ch3 translate\u003eImage\u003c/h3\u003e"}],"source_content_type":"text/html","patch_set":155,"id":"3a57f1b5_2151a7d8","line":25,"updated":"2016-02-12 05:14:09.000000000","message":"Why is this in a tabset + tab? Seems unnecessary to me - there\u0027s only one tab...","commit_id":"1a17b8608fb28c827c737a72a68b7406e6390f7c"}],"openstack_dashboard/static/app/core/images/images.module.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"05f04e86232b4aa3a318b9eb219f16b571f37342","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    var path \u003d $windowProvider.$get().STATIC_URL + \u0027app/core/images/\u0027;"},{"line_number":44,"context_line":"    $provide.constant(\u0027horizon.app.core.images.basePath\u0027, path);"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    $routeProvider"},{"line_number":47,"context_line":"      .when(\u0027/\u0027, {"},{"line_number":48,"context_line":"        templateUrl: path + \u0027table/images-table.html\u0027"},{"line_number":49,"context_line":"      })"}],"source_content_type":"text/javascript","patch_set":55,"id":"3a50d1a3_6fea99ae","line":46,"updated":"2015-07-30 15:18:07.000000000","message":"Note: at least on Chome/Ubuntu I get a hang when I try to click on Project \u003e Compute \u003e Images (the new one).  \n\nPlease see if this can be fixed here, or what the problem is.","commit_id":"751423deafd1f2f328c89c9c70f849f51463bdf2"},{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"1ef6e6b7b611cab509dd59f42788ba407f51017e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      .html5Mode({"},{"line_number":46,"context_line":"        enabled: true"},{"line_number":47,"context_line":"      })"},{"line_number":48,"context_line":"      .hashPrefix(\u0027!\u0027);"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    var path \u003d $windowProvider.$get().STATIC_URL + \u0027app/core/images/\u0027;"},{"line_number":51,"context_line":"    $provide.constant(\u0027horizon.app.core.images.basePath\u0027, path);"}],"source_content_type":"text/javascript","patch_set":107,"id":"3a29b11f_d8fa2d75","line":48,"updated":"2015-10-21 00:23:55.000000000","message":"This looks like infrastructure stuff and shouldn\u0027t here. Otherwise the same code will be duplicated many places.","commit_id":"1c36ac4cbe5cae59cfd9e47db8e68938059a6b4a"},{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"1ef6e6b7b611cab509dd59f42788ba407f51017e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        templateUrl: path + \u0027detail/image-detail.html\u0027"},{"line_number":59,"context_line":"      })"},{"line_number":60,"context_line":"      .otherwise({"},{"line_number":61,"context_line":"        redirectTo: \u0027/\u0027"},{"line_number":62,"context_line":"      });"},{"line_number":63,"context_line":"  }"},{"line_number":64,"context_line":""}],"source_content_type":"text/javascript","patch_set":107,"id":"3a29b11f_98f03593","line":61,"updated":"2015-10-21 00:23:55.000000000","message":"path + \u0027/\u0027 ?","commit_id":"1c36ac4cbe5cae59cfd9e47db8e68938059a6b4a"},{"author":{"_account_id":17002,"name":"Coleman Beasley","email":"cbeasley@thoughtworks.com","username":"cbeasley"},"change_message_id":"54e38b6d80174bde20853a870983584608ab62cc","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        templateUrl: path + \u0027detail/image-detail.html\u0027"},{"line_number":59,"context_line":"      })"},{"line_number":60,"context_line":"      .otherwise({"},{"line_number":61,"context_line":"        redirectTo: \u0027/\u0027"},{"line_number":62,"context_line":"      });"},{"line_number":63,"context_line":"  }"},{"line_number":64,"context_line":""}],"source_content_type":"text/javascript","patch_set":107,"id":"3a29b11f_ad946e8a","line":61,"in_reply_to":"3a29b11f_98f03593","updated":"2015-10-23 00:30:48.000000000","message":"This is to redirect the URL to the root. Which will render the images table","commit_id":"1c36ac4cbe5cae59cfd9e47db8e68938059a6b4a"},{"author":{"_account_id":9647,"name":"Justin Pomeroy","email":"jpomero@linux.vnet.ibm.com","username":"jpomero"},"change_message_id":"f41098146d2ad1e9b873653afa89fb21bbf296f3","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    $provide.constant(\u0027horizon.app.core.images.basePath\u0027, path);"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    $routeProvider"},{"line_number":54,"context_line":"      .when(\u0027/\u0027, {"},{"line_number":55,"context_line":"        templateUrl: path + \u0027table/images-table.html\u0027"},{"line_number":56,"context_line":"      })"},{"line_number":57,"context_line":"      .when(\u0027/details/:imageId\u0027, {"}],"source_content_type":"text/javascript","patch_set":122,"id":"ba8a016a_99bd2d04","line":54,"updated":"2015-11-19 15:58:10.000000000","message":"I\u0027ve noticed that this routing doesn\u0027t seem to play well with other panels that also want to do angular routing using a similar base.  For example, if I have another page with the base set to \"/project/foo/\" I always get routed to the Images page instead of Foo.  Maybe I\u0027m doing something wrong but it could be the base needs to be at a higher level like \"/project/\" or even \"/\".  I\u0027ve made things work by setting my base to \"/project/\" and then using .when(\u0027/foo/\u0027, ...).","commit_id":"7c6e2962301fc40fe7f2b9f7ba24f01d3f2166ae"},{"author":{"_account_id":9647,"name":"Justin Pomeroy","email":"jpomero@linux.vnet.ibm.com","username":"jpomero"},"change_message_id":"850999dd98f43f3129b9d2f5dbb1332409f10081","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    $provide.constant(\u0027horizon.app.core.images.basePath\u0027, path);"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    $routeProvider"},{"line_number":54,"context_line":"      .when(\u0027/\u0027, {"},{"line_number":55,"context_line":"        templateUrl: path + \u0027table/images-table.html\u0027"},{"line_number":56,"context_line":"      })"},{"line_number":57,"context_line":"      .when(\u0027/details/:imageId\u0027, {"}],"source_content_type":"text/javascript","patch_set":122,"id":"ba8a016a_aae3eed7","line":54,"in_reply_to":"ba8a016a_1429ff9d","updated":"2015-11-19 17:38:17.000000000","message":"I tried with the latest patch that puts the \u003cbase\u003e tag under \u003chead\u003e.  The Images page uses \"/project/ngimages/\" as the base href.  My page uses \"/project/foo/\" as the base href.  What I\u0027m seeing is that angular routing for the path \"/\" is going to Foo even when I try to load the Images page.  This is different from before where I was always going to the Images page, but that might just depend on how the modules are loaded (last wins?), and in the end the problem is the same.","commit_id":"7c6e2962301fc40fe7f2b9f7ba24f01d3f2166ae"},{"author":{"_account_id":9647,"name":"Justin Pomeroy","email":"jpomero@linux.vnet.ibm.com","username":"jpomero"},"change_message_id":"edf66a6cd3b78f5bc5570dc833fd13f8ad9abc84","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    $provide.constant(\u0027horizon.app.core.images.basePath\u0027, path);"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    $routeProvider"},{"line_number":54,"context_line":"      .when(\u0027/\u0027, {"},{"line_number":55,"context_line":"        templateUrl: path + \u0027table/images-table.html\u0027"},{"line_number":56,"context_line":"      })"},{"line_number":57,"context_line":"      .when(\u0027/details/:imageId\u0027, {"}],"source_content_type":"text/javascript","patch_set":122,"id":"ba8a016a_1429ff9d","line":54,"in_reply_to":"ba8a016a_3188d5c4","updated":"2015-11-19 17:06:47.000000000","message":"I just noticed patch set 3.  I will try it with that one.  But $routeProvider is a service right?  Does that mean it\u0027s a single route handler for all angular panels?  That\u0027s how it seems to be acting anyway.","commit_id":"7c6e2962301fc40fe7f2b9f7ba24f01d3f2166ae"},{"author":{"_account_id":9647,"name":"Justin Pomeroy","email":"jpomero@linux.vnet.ibm.com","username":"jpomero"},"change_message_id":"946df27724127ab5bb830021d050b64d6d58bfa8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    $provide.constant(\u0027horizon.app.core.images.basePath\u0027, path);"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    $routeProvider"},{"line_number":54,"context_line":"      .when(\u0027/\u0027, {"},{"line_number":55,"context_line":"        templateUrl: path + \u0027table/images-table.html\u0027"},{"line_number":56,"context_line":"      })"},{"line_number":57,"context_line":"      .when(\u0027/details/:imageId\u0027, {"}],"source_content_type":"text/javascript","patch_set":122,"id":"ba8a016a_cf499232","line":54,"in_reply_to":"ba8a016a_4802830b","updated":"2015-11-19 23:56:31.000000000","message":"I wonder if we could just specify the \u003cbase\u003e href as \"/\" in the base template file, and not have the ng_route_base block.  That would force all angular modules to set up routes that would match the full path and therefore be unique.  Modules should still be able to specify their own routes though.  Also, as I mentioned below I think we would want to put the .otherwise() in some common location, maybe the app.core module since the entire app should only have one.","commit_id":"7c6e2962301fc40fe7f2b9f7ba24f01d3f2166ae"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3c13bbf59ded75775237b54b5785d21b31112711","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    $provide.constant(\u0027horizon.app.core.images.basePath\u0027, path);"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    $routeProvider"},{"line_number":54,"context_line":"      .when(\u0027/\u0027, {"},{"line_number":55,"context_line":"        templateUrl: path + \u0027table/images-table.html\u0027"},{"line_number":56,"context_line":"      })"},{"line_number":57,"context_line":"      .when(\u0027/details/:imageId\u0027, {"}],"source_content_type":"text/javascript","patch_set":122,"id":"ba8a016a_3188d5c4","line":54,"in_reply_to":"ba8a016a_99bd2d04","updated":"2015-11-19 16:47:13.000000000","message":"Hm, I\u0027ll have to research what is going on here; I thought these were only module-specific, but haven\u0027t tested anything.  I would like to start somewhere.","commit_id":"7c6e2962301fc40fe7f2b9f7ba24f01d3f2166ae"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"3e62a317ab88b7100350c5f1d31cde88c2e76120","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    $provide.constant(\u0027horizon.app.core.images.basePath\u0027, path);"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    $routeProvider"},{"line_number":54,"context_line":"      .when(\u0027/\u0027, {"},{"line_number":55,"context_line":"        templateUrl: path + \u0027table/images-table.html\u0027"},{"line_number":56,"context_line":"      })"},{"line_number":57,"context_line":"      .when(\u0027/details/:imageId\u0027, {"}],"source_content_type":"text/javascript","patch_set":122,"id":"ba8a016a_24989869","line":54,"in_reply_to":"ba8a016a_99bd2d04","updated":"2015-11-19 16:11:13.000000000","message":"Justin - have you tried this with the latest router patch with the \u003cbase\u003e tag in the \u003chead\u003e?","commit_id":"7c6e2962301fc40fe7f2b9f7ba24f01d3f2166ae"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"30f327026569cd77c260ae84514ae370bf5aca1d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    $provide.constant(\u0027horizon.app.core.images.basePath\u0027, path);"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    $routeProvider"},{"line_number":54,"context_line":"      .when(\u0027/\u0027, {"},{"line_number":55,"context_line":"        templateUrl: path + \u0027table/images-table.html\u0027"},{"line_number":56,"context_line":"      })"},{"line_number":57,"context_line":"      .when(\u0027/details/:imageId\u0027, {"}],"source_content_type":"text/javascript","patch_set":122,"id":"ba8a016a_4802830b","line":54,"in_reply_to":"ba8a016a_aae3eed7","updated":"2015-11-19 20:27:08.000000000","message":"Sounds like we need a global routing scheme.  Should I just use a base module to handle all routing, ad we add our routes in there?","commit_id":"7c6e2962301fc40fe7f2b9f7ba24f01d3f2166ae"},{"author":{"_account_id":9647,"name":"Justin Pomeroy","email":"jpomero@linux.vnet.ibm.com","username":"jpomero"},"change_message_id":"edf66a6cd3b78f5bc5570dc833fd13f8ad9abc84","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      .when(\u0027/details/:imageId\u0027, {"},{"line_number":58,"context_line":"        templateUrl: path + \u0027detail/image-detail.html\u0027"},{"line_number":59,"context_line":"      })"},{"line_number":60,"context_line":"      .otherwise({"},{"line_number":61,"context_line":"        redirectTo: \u0027/\u0027"},{"line_number":62,"context_line":"      });"},{"line_number":63,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":122,"id":"ba8a016a_743debdb","line":60,"updated":"2015-11-19 17:06:47.000000000","message":"This is also causing me some problems.  If you want to link to a page outside of the angular routing you will always get directed to the Images page.  I think for now there are probably going to be cases where we want to jump outside the angular routing, for example to link to a network detail page.  It might be safe to assume that if the path is not found by the routeProvider it means go to a page handled by the django URL routing.  This seems to work for me in that case:\n\n.otherwise({\n  // If path is outside of angular routing then force a page reload so django\n  // URL routing takes over.\n  template: function() {\n    $windowProvider.$get().location.reload();\n  }\n});\n\nThis is assuming there is a single $routeProvider with a single .otherwise().  If that is the case though maybe it should go in some other common location outside of ngimages.","commit_id":"7c6e2962301fc40fe7f2b9f7ba24f01d3f2166ae"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"bafea72fe40e7071446d13b9a27642bed67169cd","unresolved":false,"context_lines":[{"line_number":42,"context_line":"   */"},{"line_number":43,"context_line":"  function config($provide, $windowProvider, $routeProvider, $locationProvider) {"},{"line_number":44,"context_line":"    $locationProvider"},{"line_number":45,"context_line":"      .html5Mode({"},{"line_number":46,"context_line":"        enabled: true"},{"line_number":47,"context_line":"      })"},{"line_number":48,"context_line":"      .hashPrefix(\u0027!\u0027);"}],"source_content_type":"text/javascript","patch_set":129,"id":"9a8ffd7b_aa1cfec1","line":45,"updated":"2015-12-01 05:52:58.000000000","message":"\"html5Mode(true)\" is more simple.","commit_id":"b35072265f2034c94937b9935deda2c7230e712d"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"47d83f4051a385441ba5d242e9a15c3ab39e885d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"   */"},{"line_number":43,"context_line":"  function config($provide, $windowProvider, $routeProvider, $locationProvider) {"},{"line_number":44,"context_line":"    $locationProvider"},{"line_number":45,"context_line":"      .html5Mode({"},{"line_number":46,"context_line":"        enabled: true"},{"line_number":47,"context_line":"      })"},{"line_number":48,"context_line":"      .hashPrefix(\u0027!\u0027);"}],"source_content_type":"text/javascript","patch_set":129,"id":"9a8ffd7b_fca71509","line":45,"in_reply_to":"9a8ffd7b_aa1cfec1","updated":"2015-12-01 14:30:10.000000000","message":"Good point, thanks!","commit_id":"b35072265f2034c94937b9935deda2c7230e712d"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"ea17c0d578d58072b648f32fd6f13949ef21a9f0","unresolved":false,"context_lines":[{"line_number":41,"context_line":"   * @description Base path for the images code"},{"line_number":42,"context_line":"   */"},{"line_number":43,"context_line":"  function config($provide, $windowProvider, $routeProvider, $locationProvider) {"},{"line_number":44,"context_line":"    $locationProvider.html5Mode(true).hashPrefix(\u0027!\u0027);"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    var path \u003d $windowProvider.$get().STATIC_URL + \u0027app/core/images/\u0027;"},{"line_number":47,"context_line":"    $provide.constant(\u0027horizon.app.core.images.basePath\u0027, path);"}],"source_content_type":"text/javascript","patch_set":133,"id":"3a7e1126_2c12dd09","line":44,"updated":"2015-12-21 02:42:22.000000000","message":"This is a global setting, and should not be in this file. Also, I think it could use a comment explaining why it\u0027s being done.","commit_id":"a7bc17be9a60a5b8522cc2ddab574b3822e503fe"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"ea17c0d578d58072b648f32fd6f13949ef21a9f0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    $provide.constant(\u0027horizon.app.core.images.basePath\u0027, path);"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    $routeProvider"},{"line_number":50,"context_line":"      .when(\u0027/\u0027, {"},{"line_number":51,"context_line":"        templateUrl: path + \u0027table/images-table.html\u0027"},{"line_number":52,"context_line":"      })"},{"line_number":53,"context_line":"      .when(\u0027/details/:imageId\u0027, {"}],"source_content_type":"text/javascript","patch_set":133,"id":"3a7e1126_ac500dd5","line":50,"updated":"2015-12-21 02:42:22.000000000","message":"This confuses the heck outta me. This is declaring (to the global routing service) that the \u0027/\u0027 route should be handled by the images table. Surely a sub-path (like /project/ngimages/) should be routed to the images table? Otherwise how do we register other things with the router without colliding?","commit_id":"a7bc17be9a60a5b8522cc2ddab574b3822e503fe"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"ea17c0d578d58072b648f32fd6f13949ef21a9f0","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      })"},{"line_number":56,"context_line":"      .otherwise({"},{"line_number":57,"context_line":"        redirectTo: \u0027/\u0027"},{"line_number":58,"context_line":"      });"},{"line_number":59,"context_line":"  }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":133,"id":"3a7e1126_4cd5e919","line":58,"updated":"2015-12-21 02:42:22.000000000","message":".otherwise is also a global setting, and should not be in this file.","commit_id":"a7bc17be9a60a5b8522cc2ddab574b3822e503fe"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"895ade0517753eacd70e4ce0e008c517a0e589cd","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    $provide.constant(\u0027horizon.app.core.images.basePath\u0027, path);"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    $routeProvider"},{"line_number":47,"context_line":"      .when($windowProvider.$get().WEBROOT + \u0027project/ngimages/\u0027, {"},{"line_number":48,"context_line":"        templateUrl: path + \u0027table/images-table.html\u0027"},{"line_number":49,"context_line":"      })"},{"line_number":50,"context_line":"      .when($windowProvider.$get().WEBROOT + \u0027project/ngimages/details/:imageId\u0027, {"}],"source_content_type":"text/javascript","patch_set":134,"id":"1a7b0d38_ef443475","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":45},"updated":"2015-12-24 07:13:06.000000000","message":"WEBROOT is unnecessary. \u0027/project/ngimages/\u0027 is correct, maybe.\n\"when\" needs path from \"href\" attribute of \"base\" tag.","commit_id":"99451310daf54ab4b6043d353aafb86db6015e51"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"e35b63e29485cee4e9776dfcea1c5444e7731077","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    $provide.constant(\u0027horizon.app.core.images.basePath\u0027, path);"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    $routeProvider"},{"line_number":47,"context_line":"      .when($windowProvider.$get().WEBROOT + \u0027project/ngimages/\u0027, {"},{"line_number":48,"context_line":"        templateUrl: path + \u0027table/images-table.html\u0027"},{"line_number":49,"context_line":"      })"},{"line_number":50,"context_line":"      .when($windowProvider.$get().WEBROOT + \u0027project/ngimages/details/:imageId\u0027, {"}],"source_content_type":"text/javascript","patch_set":134,"id":"1a7b0d38_928583ae","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":45},"in_reply_to":"1a7b0d38_ef443475","updated":"2015-12-24 17:41:17.000000000","message":"Done","commit_id":"99451310daf54ab4b6043d353aafb86db6015e51"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"895ade0517753eacd70e4ce0e008c517a0e589cd","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      .when($windowProvider.$get().WEBROOT + \u0027project/ngimages/\u0027, {"},{"line_number":48,"context_line":"        templateUrl: path + \u0027table/images-table.html\u0027"},{"line_number":49,"context_line":"      })"},{"line_number":50,"context_line":"      .when($windowProvider.$get().WEBROOT + \u0027project/ngimages/details/:imageId\u0027, {"},{"line_number":51,"context_line":"        templateUrl: path + \u0027detail/image-detail.html\u0027"},{"line_number":52,"context_line":"      });"},{"line_number":53,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":134,"id":"1a7b0d38_af5f0c40","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":45},"updated":"2015-12-24 07:13:06.000000000","message":"ditto","commit_id":"99451310daf54ab4b6043d353aafb86db6015e51"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"e35b63e29485cee4e9776dfcea1c5444e7731077","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      .when($windowProvider.$get().WEBROOT + \u0027project/ngimages/\u0027, {"},{"line_number":48,"context_line":"        templateUrl: path + \u0027table/images-table.html\u0027"},{"line_number":49,"context_line":"      })"},{"line_number":50,"context_line":"      .when($windowProvider.$get().WEBROOT + \u0027project/ngimages/details/:imageId\u0027, {"},{"line_number":51,"context_line":"        templateUrl: path + \u0027detail/image-detail.html\u0027"},{"line_number":52,"context_line":"      });"},{"line_number":53,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":134,"id":"1a7b0d38_728a57c1","line":50,"range":{"start_line":50,"start_character":12,"end_line":50,"end_character":45},"in_reply_to":"1a7b0d38_af5f0c40","updated":"2015-12-24 17:41:17.000000000","message":"Done","commit_id":"99451310daf54ab4b6043d353aafb86db6015e51"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"bb3637c45a2b6ef28158efd2b14466ff7a58ef25","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  function config($provide, $windowProvider, $routeProvider) {"},{"line_number":43,"context_line":"    var path \u003d $windowProvider.$get().STATIC_URL + \u0027app/core/images/\u0027;"},{"line_number":44,"context_line":"    $provide.constant(\u0027horizon.app.core.images.basePath\u0027, path);"},{"line_number":45,"context_line":"    $provide.constant(\u0027horizon.app.core.images.baseUrl\u0027,"},{"line_number":46,"context_line":"                      $windowProvider.$get().WEBROOT + \u0027project/ngimages/\u0027);"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    $routeProvider"}],"source_content_type":"text/javascript","patch_set":140,"id":"fa69d971_b0818e91","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":56},"updated":"2016-01-08 19:24:18.000000000","message":"I like this a lot. Now when the panel becomes the default, there is just 1 place to change \"ngimage\" to \"image\"","commit_id":"4afdb62c0949f0f1a4893b93459adfe1763b570a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"376cdba92af3e6f4a3943d3bdfe7dd0a4935d7ba","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    $routeProvider"},{"line_number":61,"context_line":"      .when(\u0027/project/ngimages/\u0027, {"},{"line_number":62,"context_line":"        templateUrl: path + \u0027table/images-table.html\u0027"},{"line_number":63,"context_line":"      })"},{"line_number":64,"context_line":"      .when(\u0027/project/ngimages/details/:imageId\u0027, {"},{"line_number":65,"context_line":"        templateUrl: path + \u0027detail/image-detail.html\u0027"}],"source_content_type":"text/javascript","patch_set":143,"id":"fa69d971_fce27c00","line":62,"range":{"start_line":62,"start_character":29,"end_line":62,"end_character":34},"updated":"2016-01-08 22:15:04.000000000","message":"nit: here is where the routing rubber meets the road. Since this is the master of what routes will work, its a good place to create a constant for views within this module. Consider exposing these route path fragments as constants so that controllers don\u0027t care if the module needs to reshuffle the routes.","commit_id":"3a106014e2b8e2cb797ec959eb33dd8a3a172c26"},{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"3db3d81255162f174eea8fd2135498af96039c13","unresolved":false,"context_lines":[{"line_number":26,"context_line":"   * to support and display images related content."},{"line_number":27,"context_line":"   */"},{"line_number":28,"context_line":"  angular"},{"line_number":29,"context_line":"    .module(\u0027horizon.app.core.images\u0027, [\u0027ngRoute\u0027])"},{"line_number":30,"context_line":"    .constant(\u0027horizon.app.core.images.events\u0027, events())"},{"line_number":31,"context_line":"    .config(config);"},{"line_number":32,"context_line":""}],"source_content_type":"text/javascript","patch_set":147,"id":"ba63e191_3fb5b4cc","line":29,"range":{"start_line":29,"start_character":40,"end_line":29,"end_character":49},"updated":"2016-01-19 11:08:53.000000000","message":"You are inluding the ngRoute module here but, where are you adding the JS file (angular-route.js) for ngRoute module?, is it already inluded in Horizon?","commit_id":"d9aff56da58ed433cf24e7e7e94cb06fa6655125"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"3707dd4761a2a197bdc3d63487bc8ce34df20f9e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"   * to support and display images related content."},{"line_number":27,"context_line":"   */"},{"line_number":28,"context_line":"  angular"},{"line_number":29,"context_line":"    .module(\u0027horizon.app.core.images\u0027, [\u0027ngRoute\u0027])"},{"line_number":30,"context_line":"    .constant(\u0027horizon.app.core.images.events\u0027, events())"},{"line_number":31,"context_line":"    .config(config);"},{"line_number":32,"context_line":""}],"source_content_type":"text/javascript","patch_set":147,"id":"ba63e191_4ca0da9f","line":29,"range":{"start_line":29,"start_character":40,"end_line":29,"end_character":49},"in_reply_to":"ba63e191_31e1409b","updated":"2016-01-20 00:27:52.000000000","message":"If I remember correctly, I was getting a test failure. I\u0027ll debug a little more.","commit_id":"d9aff56da58ed433cf24e7e7e94cb06fa6655125"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"c306d6508d6021d801371ed9c9bb274ec0817878","unresolved":false,"context_lines":[{"line_number":26,"context_line":"   * to support and display images related content."},{"line_number":27,"context_line":"   */"},{"line_number":28,"context_line":"  angular"},{"line_number":29,"context_line":"    .module(\u0027horizon.app.core.images\u0027, [\u0027ngRoute\u0027])"},{"line_number":30,"context_line":"    .constant(\u0027horizon.app.core.images.events\u0027, events())"},{"line_number":31,"context_line":"    .config(config);"},{"line_number":32,"context_line":""}],"source_content_type":"text/javascript","patch_set":147,"id":"ba63e191_31e1409b","line":29,"range":{"start_line":29,"start_character":40,"end_line":29,"end_character":49},"in_reply_to":"ba63e191_3fb5b4cc","updated":"2016-01-19 22:55:29.000000000","message":"I don\u0027t think you need to declare this anymore, right?  it is declared on horizon.app.\n\nhttps://review.openstack.org/#/c/264946/6/openstack_dashboard/static/app/app.module.js","commit_id":"d9aff56da58ed433cf24e7e7e94cb06fa6655125"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8ac5f1501ea83d5400e4d711f877d9b09d7e663e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"   * to support and display images related content."},{"line_number":27,"context_line":"   */"},{"line_number":28,"context_line":"  angular"},{"line_number":29,"context_line":"    .module(\u0027horizon.app.core.images\u0027, [\u0027ngRoute\u0027])"},{"line_number":30,"context_line":"    .constant(\u0027horizon.app.core.images.events\u0027, events())"},{"line_number":31,"context_line":"    .config(config);"},{"line_number":32,"context_line":""}],"source_content_type":"text/javascript","patch_set":147,"id":"7a5de9d1_aa62cbd6","line":29,"range":{"start_line":29,"start_character":40,"end_line":29,"end_character":49},"in_reply_to":"ba63e191_4ca0da9f","updated":"2016-01-27 18:58:49.000000000","message":"This is in fact required.  It shows up in testing.","commit_id":"d9aff56da58ed433cf24e7e7e94cb06fa6655125"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"c306d6508d6021d801371ed9c9bb274ec0817878","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    var path \u003d $windowProvider.$get().STATIC_URL + \u0027app/core/images/\u0027;"},{"line_number":57,"context_line":"    var webroot \u003d $windowProvider.$get().WEBROOT;"},{"line_number":58,"context_line":"    var tableUrl \u003d path + \"table/\";"},{"line_number":59,"context_line":"    var tableRoute \u003d webroot + \u0027project/ngimages/\u0027;"},{"line_number":60,"context_line":"    var detailsUrl \u003d path + \"detail/\";"},{"line_number":61,"context_line":"    var detailsRoute \u003d webroot + \u0027project/ngimages/details/\u0027;"},{"line_number":62,"context_line":""}],"source_content_type":"text/javascript","patch_set":147,"id":"ba63e191_d1bc646e","line":59,"updated":"2016-01-19 22:55:29.000000000","message":"This has \"project\" hardcoded. How will this work with the admin table route when we reuse this in admin dashboard?\n\nhttps://review.openstack.org/#/c/230150/","commit_id":"d9aff56da58ed433cf24e7e7e94cb06fa6655125"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8ac5f1501ea83d5400e4d711f877d9b09d7e663e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    var path \u003d $windowProvider.$get().STATIC_URL + \u0027app/core/images/\u0027;"},{"line_number":57,"context_line":"    var webroot \u003d $windowProvider.$get().WEBROOT;"},{"line_number":58,"context_line":"    var tableUrl \u003d path + \"table/\";"},{"line_number":59,"context_line":"    var tableRoute \u003d webroot + \u0027project/ngimages/\u0027;"},{"line_number":60,"context_line":"    var detailsUrl \u003d path + \"detail/\";"},{"line_number":61,"context_line":"    var detailsRoute \u003d webroot + \u0027project/ngimages/details/\u0027;"},{"line_number":62,"context_line":""}],"source_content_type":"text/javascript","patch_set":147,"id":"7a5de9d1_8a87cf60","line":59,"in_reply_to":"9a68dd71_6363a61b","updated":"2016-01-27 18:58:49.000000000","message":"Tyr is right, but for now this is only showing up in the project area.  In the future we\u0027ll want to plan a better strategy overall.  I don\u0027t think this should hold up the patch as it only exists in the Project dashboard anyway.","commit_id":"d9aff56da58ed433cf24e7e7e94cb06fa6655125"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9a6a160f373692df77c78929e4e3c8914337774b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    var path \u003d $windowProvider.$get().STATIC_URL + \u0027app/core/images/\u0027;"},{"line_number":57,"context_line":"    var webroot \u003d $windowProvider.$get().WEBROOT;"},{"line_number":58,"context_line":"    var tableUrl \u003d path + \"table/\";"},{"line_number":59,"context_line":"    var tableRoute \u003d webroot + \u0027project/ngimages/\u0027;"},{"line_number":60,"context_line":"    var detailsUrl \u003d path + \"detail/\";"},{"line_number":61,"context_line":"    var detailsRoute \u003d webroot + \u0027project/ngimages/details/\u0027;"},{"line_number":62,"context_line":""}],"source_content_type":"text/javascript","patch_set":147,"id":"9a68dd71_6363a61b","line":59,"in_reply_to":"ba63e191_2ca566b4","updated":"2016-01-20 20:49:28.000000000","message":"@Rajat and @Travis. This seems like a consequence of the architectural choice of trying to use the same module in two different dashboards. That is forcing the module to have two simultaneous personalities.\n\nInstead, consider an admin.images module and a separate project.images module. Each can hardcode the route they require, and load the template they require (which can easily refer to a common directive).","commit_id":"d9aff56da58ed433cf24e7e7e94cb06fa6655125"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"3707dd4761a2a197bdc3d63487bc8ce34df20f9e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    var path \u003d $windowProvider.$get().STATIC_URL + \u0027app/core/images/\u0027;"},{"line_number":57,"context_line":"    var webroot \u003d $windowProvider.$get().WEBROOT;"},{"line_number":58,"context_line":"    var tableUrl \u003d path + \"table/\";"},{"line_number":59,"context_line":"    var tableRoute \u003d webroot + \u0027project/ngimages/\u0027;"},{"line_number":60,"context_line":"    var detailsUrl \u003d path + \"detail/\";"},{"line_number":61,"context_line":"    var detailsRoute \u003d webroot + \u0027project/ngimages/details/\u0027;"},{"line_number":62,"context_line":""}],"source_content_type":"text/javascript","patch_set":147,"id":"ba63e191_2ca566b4","line":59,"in_reply_to":"ba63e191_d1bc646e","updated":"2016-01-20 00:27:52.000000000","message":"Good point. Not certain right now.\n\nThere\u0027s the option of using ui-router vs ng-route which can support regexp routing which we can use in that patch without needing the new directives.\n\nWould that work better?","commit_id":"d9aff56da58ed433cf24e7e7e94cb06fa6655125"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"06053ff8f6f50631fd30f450cac6f3c2af846a56","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    var path \u003d $windowProvider.$get().STATIC_URL + \u0027app/core/images/\u0027;"},{"line_number":57,"context_line":"    var webroot \u003d $windowProvider.$get().WEBROOT;"},{"line_number":58,"context_line":"    var tableUrl \u003d path + \"table/\";"},{"line_number":59,"context_line":"    var tableRoute \u003d webroot + \u0027project/ngimages/\u0027;"},{"line_number":60,"context_line":"    var detailsUrl \u003d path + \"detail/\";"},{"line_number":61,"context_line":"    var detailsRoute \u003d webroot + \u0027project/ngimages/details/\u0027;"},{"line_number":62,"context_line":""}],"source_content_type":"text/javascript","patch_set":150,"id":"5a5ae5dd_1a14f29d","line":59,"updated":"2016-02-06 15:35:04.000000000","message":"var name probably should be projectTableRoute (we\u0027ll also probably have an admin route).","commit_id":"e75e9f008f21ead0c1bffba52048a6206a4edddb"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"335f5a0470567ed85eb4a9711e67f9fd6c1bbdf7","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    var path \u003d $windowProvider.$get().STATIC_URL + \u0027app/core/images/\u0027;"},{"line_number":57,"context_line":"    var webroot \u003d $windowProvider.$get().WEBROOT;"},{"line_number":58,"context_line":"    var tableUrl \u003d path + \"table/\";"},{"line_number":59,"context_line":"    var tableRoute \u003d webroot + \u0027project/ngimages/\u0027;"},{"line_number":60,"context_line":"    var detailsUrl \u003d path + \"detail/\";"},{"line_number":61,"context_line":"    var detailsRoute \u003d webroot + \u0027project/ngimages/details/\u0027;"},{"line_number":62,"context_line":""}],"source_content_type":"text/javascript","patch_set":150,"id":"5a5ae5dd_ef0a431f","line":59,"in_reply_to":"5a5ae5dd_1a14f29d","updated":"2016-02-08 17:03:30.000000000","message":"Done.","commit_id":"e75e9f008f21ead0c1bffba52048a6206a4edddb"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"06053ff8f6f50631fd30f450cac6f3c2af846a56","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    var tableUrl \u003d path + \"table/\";"},{"line_number":59,"context_line":"    var tableRoute \u003d webroot + \u0027project/ngimages/\u0027;"},{"line_number":60,"context_line":"    var detailsUrl \u003d path + \"detail/\";"},{"line_number":61,"context_line":"    var detailsRoute \u003d webroot + \u0027project/ngimages/details/\u0027;"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    // Share the routes as constants so that views within the images module"},{"line_number":64,"context_line":"    // can create links to each other."}],"source_content_type":"text/javascript","patch_set":150,"id":"5a5ae5dd_da097a85","line":61,"updated":"2016-02-06 15:35:04.000000000","message":"var name probably should be projectDetailsRoute (we\u0027ll also probably have an admin route).","commit_id":"e75e9f008f21ead0c1bffba52048a6206a4edddb"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"335f5a0470567ed85eb4a9711e67f9fd6c1bbdf7","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    var tableUrl \u003d path + \"table/\";"},{"line_number":59,"context_line":"    var tableRoute \u003d webroot + \u0027project/ngimages/\u0027;"},{"line_number":60,"context_line":"    var detailsUrl \u003d path + \"detail/\";"},{"line_number":61,"context_line":"    var detailsRoute \u003d webroot + \u0027project/ngimages/details/\u0027;"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    // Share the routes as constants so that views within the images module"},{"line_number":64,"context_line":"    // can create links to each other."}],"source_content_type":"text/javascript","patch_set":150,"id":"5a5ae5dd_8f162f4a","line":61,"in_reply_to":"5a5ae5dd_da097a85","updated":"2016-02-08 17:03:30.000000000","message":"Done","commit_id":"e75e9f008f21ead0c1bffba52048a6206a4edddb"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"4b4896e546cc90b65faa0f3bcf4cb5a4b210143c","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    // Share the routes as constants so that views within the images module"},{"line_number":65,"context_line":"    // can create links to each other."},{"line_number":66,"context_line":"    $provide.constant(\u0027horizon.app.core.images.tableRoute\u0027, projectTableRoute);"},{"line_number":67,"context_line":"    $provide.constant(\u0027horizon.app.core.images.detailsRoute\u0027, projectDetailsRoute);"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    $routeProvider"}],"source_content_type":"text/javascript","patch_set":151,"id":"5a5ae5dd_0f3a3f99","line":66,"updated":"2016-02-08 17:09:21.000000000","message":"Hey Matt, the constant name is probably as, if not more, important than the internal variable name. Maybe should rebase the admin panel on this (Maybe not) and see what really should be done here??","commit_id":"ec3b32c445f9934c3a944f728ecea57744bfc897"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"bc81eeeed45e1554eca13d3a527c6d76b0017973","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    // Share the routes as constants so that views within the images module"},{"line_number":65,"context_line":"    // can create links to each other."},{"line_number":66,"context_line":"    $provide.constant(\u0027horizon.app.core.images.tableRoute\u0027, projectTableRoute);"},{"line_number":67,"context_line":"    $provide.constant(\u0027horizon.app.core.images.detailsRoute\u0027, projectDetailsRoute);"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    $routeProvider"}],"source_content_type":"text/javascript","patch_set":151,"id":"5a5ae5dd_122ee8fa","line":66,"in_reply_to":"5a5ae5dd_0f3a3f99","updated":"2016-02-08 17:28:40.000000000","message":"I think that we need to make the project/admin distinction irrelevant to all the internal panels.  I\u0027d like to consider proposals, but on the other hand I really want to get Details in as an example of Details within the context of Project since that\u0027s the only dashboard exposure we have right now.  We can talk through the best option for now, but we also have to respect Django routing.","commit_id":"ec3b32c445f9934c3a944f728ecea57744bfc897"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"137165d68182f547a75d655de9936cc567f8fc4e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    var tableUrl \u003d path + \"table/\";"},{"line_number":61,"context_line":"    var projectTableRoute \u003d webroot + \u0027project/ngimages/\u0027;"},{"line_number":62,"context_line":"    var detailsUrl \u003d path + \"detail/\";"},{"line_number":63,"context_line":"    var projectDetailsRoute \u003d webroot + \u0027project/ngimages/details/\u0027;"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    // Share the routes as constants so that views within the images module"},{"line_number":66,"context_line":"    // can create links to each other."}],"source_content_type":"text/javascript","patch_set":152,"id":"5a5ae5dd_4bdc9974","line":63,"updated":"2016-02-08 23:35:12.000000000","message":"So, I compared URLs and behaviors between current django and this. I\u0027m not saying they have to be identical, but here are some differences we should consider.\n\nWhen a user attempts to directly access a details page for a private image in another project, current Django behavior reroutes to the index page with an error message.  This patch just displays the requested page with an error.\n\nOur URL patterns are all over the board between angular, django, project, admin. I\u0027m not sure which one angular should have.\n\n Django project: /project/images/\u003cid\u003e/\n Angular project: /project/ngimages/details/\u003cid\u003e\n\n Django admin: /admin/images/\u003cid\u003e/detail/\n Angular admin: \u003cTBD\u003e","commit_id":"a88bde2e0cca3533263dba1fbb5740bdc7e4f724"}],"openstack_dashboard/static/app/core/images/table/images-table.controller.js":[{"author":{"_account_id":17004,"name":"KBrown","email":"kbrown@thoughtworks.com","username":"kbrown"},"change_message_id":"cd4c92f656ce25e24852ca297ce4a0e6d5f986b2","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    // this handles the click on the accordion"},{"line_number":49,"context_line":"    // and hides the spinner"},{"line_number":50,"context_line":"    angular.element(\u0027#main_content .nav_accordion a.active\u0027)"},{"line_number":51,"context_line":"      .bind(\u0027click\u0027, clickHandler);"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    ////////////////////////////////"}],"source_content_type":"text/javascript","patch_set":95,"id":"9a1a9d01_6a7b9ebe","line":50,"updated":"2015-09-30 21:55:09.000000000","message":"what does this do? we weren\u0027t able to see a difference when we commented it out","commit_id":"3b4a255f3299e926045c2ccc00e680a59d93de04"},{"author":{"_account_id":17327,"name":"Kyle Olivo","email":"keolivo@thoughtworks.com","username":"kyleolivo"},"change_message_id":"811ddb2a5ae9ac58b5c44fcb959fccec900c1238","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    // this handles the click on the accordion"},{"line_number":49,"context_line":"    // and hides the spinner"},{"line_number":50,"context_line":"    angular.element(\u0027#main_content .nav_accordion a.active\u0027)"},{"line_number":51,"context_line":"      .bind(\u0027click\u0027, clickHandler);"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    ////////////////////////////////"}],"source_content_type":"text/javascript","patch_set":95,"id":"9a1a9d01_4636a5b5","line":50,"in_reply_to":"9a1a9d01_6a7b9ebe","updated":"2015-10-01 21:53:25.000000000","message":"This is needed to stop the modal spinner from displaying during an angular page refresh. It looks like something has changed regarding the spinner though, so it isn\u0027t working currently. We\u0027re going to pull this code out and make a dependent patch for it since it isn\u0027t directly related to the functionality we are trying to achieve with this patch.","commit_id":"3b4a255f3299e926045c2ccc00e680a59d93de04"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"03940a6d8a4b94fa377c5fbd27b5ada4a3744281","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  function ImagesTableController(basepath, glance) {"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    var ctrl \u003d this;"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    ctrl.images \u003d [];"},{"line_number":42,"context_line":"    ctrl.imagesSrc \u003d [];"}],"source_content_type":"text/javascript","patch_set":121,"id":"ba8a016a_ce92c257","line":39,"updated":"2015-11-16 18:54:14.000000000","message":"seems like you should just leave this file alone.","commit_id":"654bc8d40a5c9b98d244310f0cef31a53925b488"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"db0033092952b55a9ddf2a76d98f5982e6c2c053","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  function ImagesTableController(basepath, glance) {"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    var ctrl \u003d this;"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    ctrl.images \u003d [];"},{"line_number":42,"context_line":"    ctrl.imagesSrc \u003d [];"}],"source_content_type":"text/javascript","patch_set":121,"id":"ba8a016a_0c75c462","line":39,"in_reply_to":"ba8a016a_ce92c257","updated":"2015-11-18 14:36:11.000000000","message":"I can clean up the diffs here, thanks!","commit_id":"654bc8d40a5c9b98d244310f0cef31a53925b488"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"376cdba92af3e6f4a3943d3bdfe7dd0a4935d7ba","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    $scope.$on(\u0027$destroy\u0027, destroy);"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    ctrl.path \u003d basePath + \u0027table/\u0027;"},{"line_number":69,"context_line":"    ctrl.baseUrl \u003d baseUrl;"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    init();"}],"source_content_type":"text/javascript","patch_set":143,"id":"fa69d971_5c74e89a","line":68,"range":{"start_line":68,"start_character":28,"end_line":68,"end_character":33},"updated":"2016-01-08 22:15:04.000000000","message":"nit: this is better than the view having hardcoded knowledge about routes...but still a little problematic because the actual route is configured in a different file. Consider instead getting this route from a constant provided by images.module.js since it establishes the routes.\n\nThat way, if the module needs to shuffle routes around, it has the flexibility to do so.","commit_id":"3a106014e2b8e2cb797ec959eb33dd8a3a172c26"}],"openstack_dashboard/static/app/core/images/table/images-table.html":[{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"1ef6e6b7b611cab509dd59f42788ba407f51017e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\u0027page-header\u0027\u003e"},{"line_number":2,"context_line":"  \u003ch1\u003e{$ \u0027Images\u0027 | translate $}\u003c/h1\u003e"},{"line_number":3,"context_line":"\u003c/div\u003e"},{"line_number":4,"context_line":"\u003ctable ng-controller\u003d\"imagesTableController as table\""},{"line_number":5,"context_line":"       hz-table ng-cloak"}],"source_content_type":"text/html","patch_set":107,"id":"3a29b11f_f83e0927","line":2,"updated":"2015-10-21 00:23:55.000000000","message":"page header should not be in main block.","commit_id":"1c36ac4cbe5cae59cfd9e47db8e68938059a6b4a"},{"author":{"_account_id":17002,"name":"Coleman Beasley","email":"cbeasley@thoughtworks.com","username":"cbeasley"},"change_message_id":"54e38b6d80174bde20853a870983584608ab62cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv class\u003d\u0027page-header\u0027\u003e"},{"line_number":2,"context_line":"  \u003ch1\u003e{$ \u0027Images\u0027 | translate $}\u003c/h1\u003e"},{"line_number":3,"context_line":"\u003c/div\u003e"},{"line_number":4,"context_line":"\u003ctable ng-controller\u003d\"imagesTableController as table\""},{"line_number":5,"context_line":"       hz-table ng-cloak"}],"source_content_type":"text/html","patch_set":107,"id":"3a29b11f_f0b1d9e0","line":2,"in_reply_to":"3a29b11f_f83e0927","updated":"2015-10-23 00:30:48.000000000","message":"Done","commit_id":"1c36ac4cbe5cae59cfd9e47db8e68938059a6b4a"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"9c8e34525243cdcec7c62f773ac4616df6a23c0c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                 hz-select\u003d\"image\"\u003e"},{"line_number":65,"context_line":"        \u003c/td\u003e"},{"line_number":66,"context_line":"        \u003ctd class\u003d\"expander\"\u003e"},{"line_number":67,"context_line":"          \u003ci class\u003d\"fa fa-chevron-right\""},{"line_number":68,"context_line":"             hz-expand-detail"},{"line_number":69,"context_line":"             duration\u003d\"200\"\u003e"},{"line_number":70,"context_line":"          \u003c/i\u003e"}],"source_content_type":"text/html","patch_set":108,"id":"3a29b11f_9c0f5e36","line":67,"updated":"2015-10-23 04:45:55.000000000","message":"\u003cspan\u003e in lieu of \u003ci\u003e please","commit_id":"ad8263b1ef3814b60c08b66a0f2e31835ccf08e0"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"ea37286f6918508a2784d184f12575fcdc30027a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv\u003e"},{"line_number":2,"context_line":"  \u003cdiv class\u003d\u0027page-header\u0027\u003e"},{"line_number":3,"context_line":"    \u003ch1\u003e{$ \u0027Images\u0027 | translate $}\u003c/h1\u003e"},{"line_number":4,"context_line":"  \u003c/div\u003e"},{"line_number":5,"context_line":"  \u003ctable ng-controller\u003d\"imagesTableController as table\""}],"source_content_type":"text/html","patch_set":110,"id":"3a29b11f_ea64454a","line":2,"updated":"2015-10-26 14:01:43.000000000","message":"shouldn\u0027t the hz-page-header directive being used?","commit_id":"693ab09e1ccd25a82b37b8c9878f0274830d0725"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"5a9731ec83b1d712283836757df74a5f0251dd6b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv\u003e"},{"line_number":2,"context_line":"  \u003cdiv class\u003d\u0027page-header\u0027\u003e"},{"line_number":3,"context_line":"    \u003ch1\u003e{$ \u0027Images\u0027 | translate $}\u003c/h1\u003e"},{"line_number":4,"context_line":"  \u003c/div\u003e"},{"line_number":5,"context_line":"  \u003ctable ng-controller\u003d\"imagesTableController as table\""}],"source_content_type":"text/html","patch_set":110,"id":"fa80f949_6196c794","line":2,"in_reply_to":"3a29b11f_64514462","updated":"2015-11-06 14:21:22.000000000","message":"is the header text easily changed? i thought it was supposed to be a static label only","commit_id":"693ab09e1ccd25a82b37b8c9878f0274830d0725"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"0cac7af3c7e8010746c91f0cc28c52ae2045c618","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv\u003e"},{"line_number":2,"context_line":"  \u003cdiv class\u003d\u0027page-header\u0027\u003e"},{"line_number":3,"context_line":"    \u003ch1\u003e{$ \u0027Images\u0027 | translate $}\u003c/h1\u003e"},{"line_number":4,"context_line":"  \u003c/div\u003e"},{"line_number":5,"context_line":"  \u003ctable ng-controller\u003d\"imagesTableController as table\""}],"source_content_type":"text/html","patch_set":110,"id":"3a29b11f_64514462","line":2,"in_reply_to":"3a29b11f_ea64454a","updated":"2015-10-26 17:39:55.000000000","message":"I tried using the directive but it failed to update when the header changes.","commit_id":"693ab09e1ccd25a82b37b8c9878f0274830d0725"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"ea37286f6918508a2784d184f12575fcdc30027a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv\u003e"},{"line_number":2,"context_line":"  \u003cdiv class\u003d\u0027page-header\u0027\u003e"},{"line_number":3,"context_line":"    \u003ch1\u003e{$ \u0027Images\u0027 | translate $}\u003c/h1\u003e"},{"line_number":4,"context_line":"  \u003c/div\u003e"},{"line_number":5,"context_line":"  \u003ctable ng-controller\u003d\"imagesTableController as table\""},{"line_number":6,"context_line":"         hz-table ng-cloak"}],"source_content_type":"text/html","patch_set":110,"id":"3a29b11f_ca7869fb","line":3,"updated":"2015-10-26 14:01:43.000000000","message":"nit: can use translate as attribute and remove the extra expression","commit_id":"693ab09e1ccd25a82b37b8c9878f0274830d0725"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"0cac7af3c7e8010746c91f0cc28c52ae2045c618","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv\u003e"},{"line_number":2,"context_line":"  \u003cdiv class\u003d\u0027page-header\u0027\u003e"},{"line_number":3,"context_line":"    \u003ch1\u003e{$ \u0027Images\u0027 | translate $}\u003c/h1\u003e"},{"line_number":4,"context_line":"  \u003c/div\u003e"},{"line_number":5,"context_line":"  \u003ctable ng-controller\u003d\"imagesTableController as table\""},{"line_number":6,"context_line":"         hz-table ng-cloak"}],"source_content_type":"text/html","patch_set":110,"id":"3a29b11f_24f90c4e","line":3,"in_reply_to":"3a29b11f_ca7869fb","updated":"2015-10-26 17:39:55.000000000","message":"Done","commit_id":"693ab09e1ccd25a82b37b8c9878f0274830d0725"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"c2126c3b90349c87c36fb09d18dfca3c3043ac0a","unresolved":false,"context_lines":[{"line_number":100,"context_line":"              \u003c/dl\u003e"},{"line_number":101,"context_line":"              \u003cdl class\u003d\"col-sm-2\"\u003e"},{"line_number":102,"context_line":"                \u003cdt translate\u003eFormat\u003c/dt\u003e"},{"line_number":103,"context_line":"                \u003cdd\u003e{$ image.disk_format | noValue $}\u003c/dd\u003e"},{"line_number":104,"context_line":"              \u003c/dl\u003e"},{"line_number":105,"context_line":"              \u003cdl class\u003d\"col-sm-2\"\u003e"},{"line_number":106,"context_line":"                \u003cdt translate\u003eSize\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":121,"id":"ba8a016a_02c88f54","line":103,"updated":"2015-11-17 00:04:56.000000000","message":"I see that in the table this value also has the | uppercase filter - I assume it\u0027s omitted here accidentally.","commit_id":"654bc8d40a5c9b98d244310f0cef31a53925b488"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"db0033092952b55a9ddf2a76d98f5982e6c2c053","unresolved":false,"context_lines":[{"line_number":100,"context_line":"              \u003c/dl\u003e"},{"line_number":101,"context_line":"              \u003cdl class\u003d\"col-sm-2\"\u003e"},{"line_number":102,"context_line":"                \u003cdt translate\u003eFormat\u003c/dt\u003e"},{"line_number":103,"context_line":"                \u003cdd\u003e{$ image.disk_format | noValue $}\u003c/dd\u003e"},{"line_number":104,"context_line":"              \u003c/dl\u003e"},{"line_number":105,"context_line":"              \u003cdl class\u003d\"col-sm-2\"\u003e"},{"line_number":106,"context_line":"                \u003cdt translate\u003eSize\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":121,"id":"ba8a016a_ecfe40ad","line":103,"in_reply_to":"ba8a016a_02c88f54","updated":"2015-11-18 14:36:11.000000000","message":"You are correct, lemme put that filter in.","commit_id":"654bc8d40a5c9b98d244310f0cef31a53925b488"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"1b5c28f45122cab9d24ff1c761722b3a546b77ca","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    --\u003e"},{"line_number":132,"context_line":"    \u003ctfoot hz-table-footer items\u003d\"table.images\"\u003e\u003c/tfoot\u003e"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  \u003c/table\u003e"},{"line_number":135,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":121,"id":"ba8a016a_56373db0","line":134,"updated":"2015-11-16 22:19:56.000000000","message":"The markup looks mismatched to me - I see an opening \u003ctable\u003e tag at line 3, but no opening \u003cdiv\u003e to match line 135","commit_id":"654bc8d40a5c9b98d244310f0cef31a53925b488"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"db0033092952b55a9ddf2a76d98f5982e6c2c053","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    --\u003e"},{"line_number":132,"context_line":"    \u003ctfoot hz-table-footer items\u003d\"table.images\"\u003e\u003c/tfoot\u003e"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  \u003c/table\u003e"},{"line_number":135,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":121,"id":"ba8a016a_0c238457","line":134,"in_reply_to":"ba8a016a_56373db0","updated":"2015-11-18 14:36:11.000000000","message":"I agree, lemme fix that up.","commit_id":"654bc8d40a5c9b98d244310f0cef31a53925b488"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"376cdba92af3e6f4a3943d3bdfe7dd0a4935d7ba","unresolved":false,"context_lines":[{"line_number":67,"context_line":"           duration\u003d\"200\"\u003e"},{"line_number":68,"context_line":"        \u003c/span\u003e"},{"line_number":69,"context_line":"      \u003c/td\u003e"},{"line_number":70,"context_line":"      \u003ctd class\u003d\"rsp-p1\"\u003e\u003ca ng-href\u003d\"{$ table.baseUrl $}details/{$ image.id $}\"\u003e{$ image.name $}\u003c/a\u003e\u003c/td\u003e"},{"line_number":71,"context_line":"      \u003ctd class\u003d\"rsp-p1\"\u003e{$ image | imageType $}\u003c/td\u003e"},{"line_number":72,"context_line":"      \u003ctd class\u003d\"rsp-p1\"\u003e{$ image.status | imageStatus $}\u003c/td\u003e"},{"line_number":73,"context_line":"      \u003ctd class\u003d\"rsp-p2\"\u003e{$ image.is_public | yesno $}\u003c/td\u003e"}],"source_content_type":"text/html","patch_set":143,"id":"fa69d971_9906f21e","line":70,"range":{"start_line":70,"start_character":56,"end_line":70,"end_character":63},"updated":"2016-01-08 22:15:04.000000000","message":"nit: ideally this view would not know the route to the details page, but instead get this value from its controller. Having this hard coded route here makes the page difficult to maintain.","commit_id":"3a106014e2b8e2cb797ec959eb33dd8a3a172c26"}],"openstack_dashboard/static/dashboard/image/image-detail.html":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e42cc836f14beb55e13eb5456b5b66d5a03df98a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      \u003cstatus label\u003d\"ctrl.label.status\""},{"line_number":8,"context_line":"              value\u003d\"ctrl.image.status  | decode:ctrl.imageStatus\"\u003e\u003c/status\u003e"},{"line_number":9,"context_line":"      \u003cstatus label\u003d\"ctrl.label.base_os\" value\u003d\" \u0027--\u0027 \"\u003e\u003c/status\u003e"},{"line_number":10,"context_line":"      \u003cstatus label\u003d\"ctrl.label.version\" value\u003d\" \u0027--\u0027 \"\u003e\u003c/status\u003e"},{"line_number":11,"context_line":"    \u003c/status-group\u003e"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    \u003caction-list dropdown\u003e"}],"source_content_type":"text/html","patch_set":15,"id":"5aa745d1_b64a1a82","line":10,"updated":"2015-04-16 16:10:18.000000000","message":"Images don\u0027t have a version.  And the fields are different than in mocks.  Looks like some of the mocks were updated and others weren\u0027t.  See this one:\n\nhttps://openstack.invisionapp.com/d/main#/console/2509582/56014870/preview","commit_id":"bd02f0d575699764292584cf2257f85369ecec93"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"4180331c5fe64c236756fad1feb798fb36de5fbc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      \u003cstatus label\u003d\"ctrl.label.status\""},{"line_number":8,"context_line":"              value\u003d\"ctrl.image.status  | decode:ctrl.imageStatus\"\u003e\u003c/status\u003e"},{"line_number":9,"context_line":"      \u003cstatus label\u003d\"ctrl.label.base_os\" value\u003d\" \u0027--\u0027 \"\u003e\u003c/status\u003e"},{"line_number":10,"context_line":"      \u003cstatus label\u003d\"ctrl.label.version\" value\u003d\" \u0027--\u0027 \"\u003e\u003c/status\u003e"},{"line_number":11,"context_line":"    \u003c/status-group\u003e"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    \u003caction-list dropdown\u003e"}],"source_content_type":"text/html","patch_set":15,"id":"5aa745d1_ad55241e","line":10,"in_reply_to":"5aa745d1_b64a1a82","updated":"2015-04-16 16:38:31.000000000","message":"Will remove","commit_id":"bd02f0d575699764292584cf2257f85369ecec93"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e42cc836f14beb55e13eb5456b5b66d5a03df98a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"          \u003clabel-value label\u003d\"ctrl.label.id\" value\u003d\"ctrl.image.id\"\u003e\u003c/label-value\u003e"},{"line_number":62,"context_line":"        \u003c/label-value-group\u003e"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        \u003clabel-value-group label\u003d\"ctrl.label.custom_properties\" ng-if\u003d\"ctrl.hasCustomProperties()\"\u003e"},{"line_number":65,"context_line":"          \u003clabel-value ng-if\u003d\"ctrl.image.properties.kernel_id\""},{"line_number":66,"context_line":"                       label\u003d\"ctrl.label.kernel_id\""},{"line_number":67,"context_line":"                       value\u003d\"ctrl.image.properties.kernel_id\"\u003e\u003c/label-value\u003e"}],"source_content_type":"text/html","patch_set":15,"id":"5aa745d1_aa9cea69","line":64,"updated":"2015-04-16 16:10:18.000000000","message":"The properties shown here are correct to have a label, but the actual label needs to come from a setting that allows customization (use the settingsService): IMAGE_CUSTOM_PROPERTY_TITLES\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L276\n\nYou\u0027ll need to add this to the list of settings that are provided to the REST API: REST_API_REQUIRED_SETTINGS\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L631\n\nBasically, this should be looking at the above setting and if the property name is in the custom dictionary, use the custom labels.\n\nIf it isn\u0027t, then you need to still show all the raw property names and values.\n\nThe intent of this section of the UI is to give direct visibility of all property names and values and initially use the raw name unless customized as above.  Seeing the raw names and values is very useful to experienced users who know what they are doing.\n\nThe Metadata tab (not implemented yet) in the mocks should be based on the metadata widget and provide nicer view of the metadata.\n\nThat said, there will need to be care taken to ensure that protected properties are not shown though.  This comes from the IMAGE_RESERVED_CUSTOM_PROPERTIES setting (use settingsService).\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/local/local_settings.py.example#L287","commit_id":"bd02f0d575699764292584cf2257f85369ecec93"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"4180331c5fe64c236756fad1feb798fb36de5fbc","unresolved":false,"context_lines":[{"line_number":61,"context_line":"          \u003clabel-value label\u003d\"ctrl.label.id\" value\u003d\"ctrl.image.id\"\u003e\u003c/label-value\u003e"},{"line_number":62,"context_line":"        \u003c/label-value-group\u003e"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        \u003clabel-value-group label\u003d\"ctrl.label.custom_properties\" ng-if\u003d\"ctrl.hasCustomProperties()\"\u003e"},{"line_number":65,"context_line":"          \u003clabel-value ng-if\u003d\"ctrl.image.properties.kernel_id\""},{"line_number":66,"context_line":"                       label\u003d\"ctrl.label.kernel_id\""},{"line_number":67,"context_line":"                       value\u003d\"ctrl.image.properties.kernel_id\"\u003e\u003c/label-value\u003e"}],"source_content_type":"text/html","patch_set":15,"id":"5aa745d1_2d49148c","line":64,"in_reply_to":"5aa745d1_aa9cea69","updated":"2015-04-16 16:38:31.000000000","message":"Interesting!  I\u0027ll have to review this in more depth.","commit_id":"bd02f0d575699764292584cf2257f85369ecec93"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"18babf60a83d14b3d3166b95b8cb23c50474399b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    \u003cstatus-group\u003e"},{"line_number":6,"context_line":"      \u003cstatus label\u003d\"::ctrl.label.owner\" value\u003d\"ctrl.project.name\"\u003e\u003c/status\u003e"},{"line_number":7,"context_line":"      \u003cstatus label\u003d\"::ctrl.label.status\""},{"line_number":8,"context_line":"              value\u003d\"::ctrl.image.status  | decode:ctrl.imageStatus\"\u003e\u003c/status\u003e"},{"line_number":9,"context_line":"      \u003cstatus label\u003d\"::ctrl.label.base_os\" value\u003d\" \u0027--\u0027 \"\u003e\u003c/status\u003e"},{"line_number":10,"context_line":"      \u003cstatus label\u003d\"::ctrl.label.version\" value\u003d\" \u0027--\u0027 \"\u003e\u003c/status\u003e"},{"line_number":11,"context_line":"    \u003c/status-group\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"5aa745d1_ed51ec63","line":8,"updated":"2015-04-16 16:33:47.000000000","message":"Note to self: remove one-time binding","commit_id":"d25e52376176b60e597d6358795c541857acff80"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"b9a99409dd19c8a04543b039bcb2ca7c07246cfa","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  \u003cdetail-header title\u003d\"ctrl.image.name\" description\u003d\"ctrl.image.properties.description\"\u003e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"    \u003cproperty-group\u003e"},{"line_number":6,"context_line":"      \u003cproperty label\u003d\"::ctrl.label.owner\" value\u003d\"ctrl.project.name\"\u003e\u003c/property\u003e"},{"line_number":7,"context_line":"      \u003cproperty label\u003d\"::ctrl.label.status\""},{"line_number":8,"context_line":"                value\u003d\"ctrl.image.status  | decode:ctrl.imageStatus\"\u003e\u003c/property\u003e"}],"source_content_type":"text/html","patch_set":22,"id":"3ab451fb_afbac1df","line":5,"updated":"2015-04-17 16:34:07.000000000","message":"First assuming the \"layout\" attribute stays as is and all of my comments below are already addressed. Maybe layout attr should always be required.  It causes less thinking.  layout\u003d\"inline\" tells me what I\u0027d expect. That said...\n\nI really like \u003cproperty\u003e and \u003cproperty-group\u003e.  Initially when I saw layout, I thought it was great, but then I had the question of whether or not it is still coupling too much between style and we\u0027ve lost some semantics. So imagine this:\n\nI\u0027m a deployer and I want to change how these top properties in the page are laid out without changing the base HTML (don\u0027t want merge conflicts). Maybe I want to go from inline (6 across one next to each other) to having them stacked 2 high (3 across).  However, I don\u0027t want to affect the properties that are within the tab.  I also just want to make this change to files that won\u0027t have merge conflicts when I get updates for horizon.\n\nWhat is the best mechanism for me to do that kind of \"theming\"? Is it by\n\n1) By simply changing a scss variable?\n2) Adding a class at the root of my app with my own custom scss?\n3) Providing my own custom HTML template for that type of layout?\n4) All of the above or some variation?\n\nWhat are your thoughts here? It if is just selectors (e.g. \"detail-header property-group\"), then everything below can be ignored because it seems less clean.\n\nHowever, its not jumping out to me how I\u0027d do this with the layout attribute if it actually maps to different HTML templates.  Just in initial thoughts, I\u0027m wondering if it might be some combination of the above.\n\nI mean somehow it seems like you want to be able to semantically map the property-group with the template html / styles.\n\nIf not selectors, does the property group need a \"role\" attribute and then the default layout for that role is used (assuming ng-class isn\u0027t right).","commit_id":"d9e4bd1d3c9e3859d0c7a059c2d708209c9e9b12"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"b9a99409dd19c8a04543b039bcb2ca7c07246cfa","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        \u003cproperty-group label\u003d\"::ctrl.label.custom_properties\" layout\u003d\"block\""},{"line_number":64,"context_line":"                        ng-if\u003d\"ctrl.hasCustomProperties()\"\u003e"},{"line_number":65,"context_line":"          \u003cproperty ng-if\u003d\"ctrl.image.properties.kernel_id\""},{"line_number":66,"context_line":"                    label\u003d\"::ctrl.label.kernel_id\""},{"line_number":67,"context_line":"                    value\u003d\"ctrl.image.properties.kernel_id\"\u003e\u003c/property\u003e"},{"line_number":68,"context_line":"          \u003cproperty ng-if\u003d\"ctrl.image.properties.ramdisk_id\""}],"source_content_type":"text/html","patch_set":22,"id":"3ab451fb_4f9e9d57","line":65,"updated":"2015-04-17 16:34:07.000000000","message":"Can\u0027t help but think this could be an ng-repeat and the controller could just have a dictionary of the properties to show.","commit_id":"d9e4bd1d3c9e3859d0c7a059c2d708209c9e9b12"}],"openstack_dashboard/static/dashboard/image/image-detail.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e42cc836f14beb55e13eb5456b5b66d5a03df98a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        \"owner\": gettext(\"Owner\"),"},{"line_number":29,"context_line":"        \"status\": gettext(\"Status\"),"},{"line_number":30,"context_line":"        \"base_os\": gettext(\"Base OS\"),"},{"line_number":31,"context_line":"        \"version\": gettext(\"Version\"),"},{"line_number":32,"context_line":"        \"size\": gettext(\"Size\"),"},{"line_number":33,"context_line":"        \"min_disk\": gettext(\"Min. Disk\"),"},{"line_number":34,"context_line":"        \"min_ram\": gettext(\"Min. RAM\"),"}],"source_content_type":"text/javascript","patch_set":15,"id":"5aa745d1_d673664c","line":31,"updated":"2015-04-16 16:10:18.000000000","message":"Images don\u0027t have a version.  And the fields are different than in mocks.  Looks like some of the mocks were updated and others weren\u0027t.  See this one:\n\nhttps://openstack.invisionapp.com/d/main#/console/2509582/56014870/preview","commit_id":"bd02f0d575699764292584cf2257f85369ecec93"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e42cc836f14beb55e13eb5456b5b66d5a03df98a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        \"version\": gettext(\"Version\"),"},{"line_number":32,"context_line":"        \"size\": gettext(\"Size\"),"},{"line_number":33,"context_line":"        \"min_disk\": gettext(\"Min. Disk\"),"},{"line_number":34,"context_line":"        \"min_ram\": gettext(\"Min. RAM\"),"},{"line_number":35,"context_line":"        \"disk_format\": gettext(\"Disk Format\"),"},{"line_number":36,"context_line":"        \"container_format\": gettext(\"Container Format\"),"},{"line_number":37,"context_line":"        \"public\": gettext(\"Public\"),"}],"source_content_type":"text/javascript","patch_set":15,"id":"5aa745d1_7620129c","line":34,"updated":"2015-04-16 16:10:18.000000000","message":"The period in Min. actually looks odd to me.  We should ask our doc people about this.","commit_id":"bd02f0d575699764292584cf2257f85369ecec93"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e42cc836f14beb55e13eb5456b5b66d5a03df98a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \"custom_properties\": gettext(\"Custom Properties\"),"},{"line_number":47,"context_line":"        \"kernel_id\": gettext(\"Kernel ID\"),"},{"line_number":48,"context_line":"        \"ramdisk_id\": gettext(\"Ramdisk ID\"),"},{"line_number":49,"context_line":"        \"architecture\": gettext(\"Architecture\"),"},{"line_number":50,"context_line":"        \"record_data\": gettext(\"Record Data\"),"},{"line_number":51,"context_line":"      };"},{"line_number":52,"context_line":""}],"source_content_type":"text/javascript","patch_set":15,"id":"5aa745d1_8a8fee22","line":49,"updated":"2015-04-16 16:10:18.000000000","message":"See my comments in HTML about these labels.","commit_id":"bd02f0d575699764292584cf2257f85369ecec93"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e42cc836f14beb55e13eb5456b5b66d5a03df98a","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"      // Fetch the Instance ID from the URL."},{"line_number":63,"context_line":"      var pattern \u003d /(.*\\/images\\/)([0-9a-f-]*)\\/(detail\\/)?/;"},{"line_number":64,"context_line":"      var imageId \u003d $location.absUrl().match(pattern)[2];"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"      // Load the elements that are used in the overview."},{"line_number":67,"context_line":"      glanceAPI.getImage(imageId).success(function(image) {"}],"source_content_type":"text/javascript","patch_set":15,"id":"5aa745d1_9b6867f7","line":64,"updated":"2015-04-16 16:10:18.000000000","message":"Even though tiny, this probably could be a utility method in a service.","commit_id":"bd02f0d575699764292584cf2257f85369ecec93"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e42cc836f14beb55e13eb5456b5b66d5a03df98a","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        }"},{"line_number":80,"context_line":"        var props \u003d ctrl.image.properties;"},{"line_number":81,"context_line":"        return (props \u0026\u0026 (props.kernel_id || props.ramdisk_id ||"},{"line_number":82,"context_line":"          props.architecture ));"},{"line_number":83,"context_line":"      };"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  }])"}],"source_content_type":"text/javascript","patch_set":15,"id":"5aa745d1_5b177f51","line":82,"updated":"2015-04-16 16:10:18.000000000","message":"This function is a little oddly named.  it sounds very generic, but appears to only check for 3 specific properties. images can have lots of custom properties besides the three listed here.  It is not the intent that we only show the 3 listed here. I think the mocks only showed a couple of them, because Chris didn\u0027t know the others. See my comments in HTML.\n\nNow, besides this, I think we could consider creating an image service (like I\u0027ve done with service catalog, settings service, nova extensions) which wraps using glance API directly and provides helper functions / data directly on it.  So that it can be injected in various spots and reused.","commit_id":"bd02f0d575699764292584cf2257f85369ecec93"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"fd240f9f578171a52de351952ffca2a109d98f1c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"   * @description"},{"line_number":8,"context_line":"   * Module containing functionality for Images."},{"line_number":9,"context_line":"   */"},{"line_number":10,"context_line":"  angular.module(\u0027hz.image\u0027, [\u0027horizon.framework.widgets.detail\u0027])"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    /**"},{"line_number":13,"context_line":"     * @ngdoc controller"}],"source_content_type":"text/javascript","patch_set":30,"id":"fa32b979_d79db70a","line":10,"updated":"2015-06-18 20:23:56.000000000","message":"Let\u0027s follow JP style here.\n\nThis file should be split in 2 and named accordingly as per https://github.com/johnpapa/angular-styleguide#style-y001","commit_id":"e5abe185c3e03593530927ddd349bcf601716fd9"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8556929c8289f2e6288f68bdc14ddcb56b47863e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"   * @description"},{"line_number":8,"context_line":"   * Module containing functionality for Images."},{"line_number":9,"context_line":"   */"},{"line_number":10,"context_line":"  angular.module(\u0027hz.image\u0027, [\u0027horizon.framework.widgets.detail\u0027])"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    /**"},{"line_number":13,"context_line":"     * @ngdoc controller"}],"source_content_type":"text/javascript","patch_set":30,"id":"ba3cc151_035893f9","line":10,"in_reply_to":"fa32b979_d79db70a","updated":"2015-06-29 15:54:22.000000000","message":"Will do.","commit_id":"e5abe185c3e03593530927ddd349bcf601716fd9"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"fd240f9f578171a52de351952ffca2a109d98f1c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"     * Controller for the Image Detail feature."},{"line_number":17,"context_line":"     */"},{"line_number":18,"context_line":"    .controller(\u0027ImageDetailCtrl\u0027, [\u0027$location\u0027, \u0027hz.api.glance\u0027, \u0027hz.api.keystone\u0027,"},{"line_number":19,"context_line":"                                    function($location, glanceAPI, keystoneAPI) {"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"      var ctrl \u003d this;"},{"line_number":22,"context_line":"      ctrl.label \u003d {"}],"source_content_type":"text/javascript","patch_set":30,"id":"fa32b979_1766bf29","line":19,"updated":"2015-06-18 20:23:56.000000000","message":"This should be a named function https://github.com/johnpapa/angular-styleguide#style-y024","commit_id":"e5abe185c3e03593530927ddd349bcf601716fd9"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8556929c8289f2e6288f68bdc14ddcb56b47863e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"     * Controller for the Image Detail feature."},{"line_number":17,"context_line":"     */"},{"line_number":18,"context_line":"    .controller(\u0027ImageDetailCtrl\u0027, [\u0027$location\u0027, \u0027hz.api.glance\u0027, \u0027hz.api.keystone\u0027,"},{"line_number":19,"context_line":"                                    function($location, glanceAPI, keystoneAPI) {"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"      var ctrl \u003d this;"},{"line_number":22,"context_line":"      ctrl.label \u003d {"}],"source_content_type":"text/javascript","patch_set":30,"id":"ba3cc151_836ca39d","line":19,"in_reply_to":"fa32b979_1766bf29","updated":"2015-06-29 15:54:22.000000000","message":"Yup yup","commit_id":"e5abe185c3e03593530927ddd349bcf601716fd9"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"fd240f9f578171a52de351952ffca2a109d98f1c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        });"},{"line_number":73,"context_line":"      });"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"      ctrl.hasCustomProperties \u003d function () {"},{"line_number":76,"context_line":"        if (!ctrl.image) {"},{"line_number":77,"context_line":"          return false;"},{"line_number":78,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":30,"id":"fa32b979_b75cb34b","line":75,"updated":"2015-06-18 20:23:56.000000000","message":"This should be up top and not anonymous:\n\nhttps://github.com/johnpapa/angular-styleguide#style-y033","commit_id":"e5abe185c3e03593530927ddd349bcf601716fd9"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8556929c8289f2e6288f68bdc14ddcb56b47863e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        });"},{"line_number":73,"context_line":"      });"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"      ctrl.hasCustomProperties \u003d function () {"},{"line_number":76,"context_line":"        if (!ctrl.image) {"},{"line_number":77,"context_line":"          return false;"},{"line_number":78,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":30,"id":"ba3cc151_e31d6f10","line":75,"in_reply_to":"fa32b979_b75cb34b","updated":"2015-06-29 15:54:22.000000000","message":"moving up slightly, but what do you mean by \"not anonymous?\"  I\u0027m binding the function to ctrl.hasCustomProperties and it\u0027s just like the example...","commit_id":"e5abe185c3e03593530927ddd349bcf601716fd9"}],"openstack_dashboard/static/dashboard/image/image-detail.spec.js":[{"author":{"_account_id":16999,"name":"Nathan Zeplowitz","email":"nzeplowi@thoughtworks.com","username":"nzeplowi"},"change_message_id":"d559fa8ce3026b1f401811b91c79510b1e59c297","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        expect(ctrl.imageStatus).toBeDefined();"},{"line_number":33,"context_line":"      });"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"      it(\u0027defines hasCustomProperties on the scope\u0027, function() {"},{"line_number":36,"context_line":"        expect(ctrl.hasCustomProperties).toBeDefined();"},{"line_number":37,"context_line":"      });"},{"line_number":38,"context_line":""}],"source_content_type":"text/javascript","patch_set":39,"id":"ba3cc151_3e067bce","line":35,"updated":"2015-07-08 18:39:35.000000000","message":"There should be some tests around the logic in hasCustomProperties.","commit_id":"389d03c5d15403833d706328ca7b3ba23dce4cf3"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"0a9407b0a7c862f54da662ffb8d7c3fabe1b9675","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        expect(ctrl.imageStatus).toBeDefined();"},{"line_number":33,"context_line":"      });"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"      it(\u0027defines hasCustomProperties on the scope\u0027, function() {"},{"line_number":36,"context_line":"        expect(ctrl.hasCustomProperties).toBeDefined();"},{"line_number":37,"context_line":"      });"},{"line_number":38,"context_line":""}],"source_content_type":"text/javascript","patch_set":39,"id":"ba3cc151_a18a6e62","line":35,"in_reply_to":"ba3cc151_3e067bce","updated":"2015-07-08 18:57:10.000000000","message":"Yep, good call","commit_id":"389d03c5d15403833d706328ca7b3ba23dce4cf3"}],"openstack_dashboard/static/dashboard/image/imageDetailCtrl.controller.js":[{"author":{"_account_id":16999,"name":"Nathan Zeplowitz","email":"nzeplowi@thoughtworks.com","username":"nzeplowi"},"change_message_id":"d559fa8ce3026b1f401811b91c79510b1e59c297","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  function imageDetailCtrl($location, glanceAPI, keystoneAPI) {"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    var ctrl \u003d this;"},{"line_number":14,"context_line":"    ctrl.label \u003d {"},{"line_number":15,"context_line":"      \"launch\": gettext(\"Launch\"),"},{"line_number":16,"context_line":"      \"create_volume\": gettext(\"Create Volume\"),"}],"source_content_type":"text/javascript","patch_set":39,"id":"ba3cc151_7e48835c","line":13,"updated":"2015-07-08 18:39:35.000000000","message":"The eslint suggests using \u0027vm\u0027 instead of \u0027ctrl\u0027. Be sure to run elint before checking in code.","commit_id":"389d03c5d15403833d706328ca7b3ba23dce4cf3"},{"author":{"_account_id":17002,"name":"Coleman Beasley","email":"cbeasley@thoughtworks.com","username":"cbeasley"},"change_message_id":"8735d68a20e8eadd0fc4a2c6ea25ff327c06f4d5","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  function imageDetailCtrl($location, glanceAPI, keystoneAPI) {"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    var ctrl \u003d this;"},{"line_number":14,"context_line":"    ctrl.label \u003d {"},{"line_number":15,"context_line":"      \"launch\": gettext(\"Launch\"),"},{"line_number":16,"context_line":"      \"create_volume\": gettext(\"Create Volume\"),"}],"source_content_type":"text/javascript","patch_set":39,"id":"ba3cc151_c16e922e","line":13,"in_reply_to":"ba3cc151_613226a9","updated":"2015-07-08 19:05:30.000000000","message":"eslint suggests that, but I feel that rule needs to be removed. It\u0027s a strict rule implemented based on a suggestion (\" Choose a consistent variable name such as vm, which stands for ViewModel.\").","commit_id":"389d03c5d15403833d706328ca7b3ba23dce4cf3"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"0a9407b0a7c862f54da662ffb8d7c3fabe1b9675","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  function imageDetailCtrl($location, glanceAPI, keystoneAPI) {"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    var ctrl \u003d this;"},{"line_number":14,"context_line":"    ctrl.label \u003d {"},{"line_number":15,"context_line":"      \"launch\": gettext(\"Launch\"),"},{"line_number":16,"context_line":"      \"create_volume\": gettext(\"Create Volume\"),"}],"source_content_type":"text/javascript","patch_set":39,"id":"ba3cc151_613226a9","line":13,"in_reply_to":"ba3cc151_7e48835c","updated":"2015-07-08 18:57:10.000000000","message":"hm, I thought we avoided that term due to domain overlap (we have lots of vms in OpenStack). :)\n\nWill do if that\u0027s what everyone else is doing.","commit_id":"389d03c5d15403833d706328ca7b3ba23dce4cf3"}],"openstack_dashboard/static/dashboard/scss/_variables.scss":[{"author":{"_account_id":13785,"name":"Kelly Domico","email":"kelly.domico@hp.com","username":"kdomico"},"change_message_id":"f2c7c604a9afe15237d11a22cddda764b1081482","unresolved":false,"context_lines":[{"line_number":202,"context_line":"$detail-group-color: silver !default;"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"/* Detail Pages */"},{"line_number":205,"context_line":"$detail-title-color: #428bca !default;"},{"line_number":206,"context_line":"$detail-group-color: silver !default;"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"/* Metadata Display */"}],"source_content_type":"text/x-scss","patch_set":25,"id":"7a016987_be8d3f33","line":205,"updated":"2015-05-15 01:49:12.000000000","message":"Duplicate of above","commit_id":"3dce273be5071177adc9d8e88543298148c1ae7e"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"00b78cb0f80cd9422c953a622fbe8f3c915f2c63","unresolved":false,"context_lines":[{"line_number":198,"context_line":"/* Detail Pages */"},{"line_number":199,"context_line":"$detail-title-color: #428bca !default;"},{"line_number":200,"context_line":"$detail-group-color: silver !default;"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"/* Metadata Display */"},{"line_number":203,"context_line":"$metadata-display-selector-color: $link-color !default;"},{"line_number":204,"context_line":"$metadata-display-selector-hover-color: $link-hover-color !default;"}],"source_content_type":"text/x-scss","patch_set":30,"id":"fa32b979_7551b235","line":201,"updated":"2015-06-16 21:37:40.000000000","message":"Is this duplicated from above?","commit_id":"e5abe185c3e03593530927ddd349bcf601716fd9"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"9c8e34525243cdcec7c62f773ac4616df6a23c0c","unresolved":false,"context_lines":[{"line_number":177,"context_line":"$chart-title-weight: 600 !default;"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"/* Detail Pages */"},{"line_number":180,"context_line":"$detail-title-color: #428bca !default;"},{"line_number":181,"context_line":"$detail-group-color: silver !default;"},{"line_number":182,"context_line":"$detail-separator-color: silver !default;"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-scss","patch_set":108,"id":"3a29b11f_a211d453","line":180,"updated":"2015-10-23 04:45:55.000000000","message":"Why add a brand new color here.  Can we inherit from a color in our theme?  Or even a percentage variant of a color that already exists?","commit_id":"ad8263b1ef3814b60c08b66a0f2e31835ccf08e0"},{"author":{"_account_id":17002,"name":"Coleman Beasley","email":"cbeasley@thoughtworks.com","username":"cbeasley"},"change_message_id":"93ff611968d577c350c8a1f3b3e273005850294d","unresolved":false,"context_lines":[{"line_number":177,"context_line":"$chart-title-weight: 600 !default;"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"/* Detail Pages */"},{"line_number":180,"context_line":"$detail-title-color: #428bca !default;"},{"line_number":181,"context_line":"$detail-group-color: silver !default;"},{"line_number":182,"context_line":"$detail-separator-color: silver !default;"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-scss","patch_set":108,"id":"3a29b11f_65196979","line":180,"in_reply_to":"3a29b11f_a211d453","updated":"2015-10-23 20:50:15.000000000","message":"Done","commit_id":"ad8263b1ef3814b60c08b66a0f2e31835ccf08e0"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"9c8e34525243cdcec7c62f773ac4616df6a23c0c","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"/* Detail Pages */"},{"line_number":180,"context_line":"$detail-title-color: #428bca !default;"},{"line_number":181,"context_line":"$detail-group-color: silver !default;"},{"line_number":182,"context_line":"$detail-separator-color: silver !default;"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"/* Metadata Display */"}],"source_content_type":"text/x-scss","patch_set":108,"id":"3a29b11f_421c8069","line":181,"updated":"2015-10-23 04:45:55.000000000","message":"Can we inherit from a color in our theme?  Or even a percentage variant of a color that already exists?","commit_id":"ad8263b1ef3814b60c08b66a0f2e31835ccf08e0"},{"author":{"_account_id":17002,"name":"Coleman Beasley","email":"cbeasley@thoughtworks.com","username":"cbeasley"},"change_message_id":"93ff611968d577c350c8a1f3b3e273005850294d","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"/* Detail Pages */"},{"line_number":180,"context_line":"$detail-title-color: #428bca !default;"},{"line_number":181,"context_line":"$detail-group-color: silver !default;"},{"line_number":182,"context_line":"$detail-separator-color: silver !default;"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"/* Metadata Display */"}],"source_content_type":"text/x-scss","patch_set":108,"id":"3a29b11f_252a917f","line":181,"in_reply_to":"3a29b11f_421c8069","updated":"2015-10-23 20:50:15.000000000","message":"Done","commit_id":"ad8263b1ef3814b60c08b66a0f2e31835ccf08e0"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"9c8e34525243cdcec7c62f773ac4616df6a23c0c","unresolved":false,"context_lines":[{"line_number":179,"context_line":"/* Detail Pages */"},{"line_number":180,"context_line":"$detail-title-color: #428bca !default;"},{"line_number":181,"context_line":"$detail-group-color: silver !default;"},{"line_number":182,"context_line":"$detail-separator-color: silver !default;"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"/* Metadata Display */"},{"line_number":185,"context_line":"$metadata-display-selector-color: $link-color !default;"}],"source_content_type":"text/x-scss","patch_set":108,"id":"3a29b11f_62173c45","line":182,"updated":"2015-10-23 04:45:55.000000000","message":"Can we inherit from a color in our theme?  Or even a percentage variant of a color that already exists?","commit_id":"ad8263b1ef3814b60c08b66a0f2e31835ccf08e0"},{"author":{"_account_id":17002,"name":"Coleman Beasley","email":"cbeasley@thoughtworks.com","username":"cbeasley"},"change_message_id":"93ff611968d577c350c8a1f3b3e273005850294d","unresolved":false,"context_lines":[{"line_number":179,"context_line":"/* Detail Pages */"},{"line_number":180,"context_line":"$detail-title-color: #428bca !default;"},{"line_number":181,"context_line":"$detail-group-color: silver !default;"},{"line_number":182,"context_line":"$detail-separator-color: silver !default;"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"/* Metadata Display */"},{"line_number":185,"context_line":"$metadata-display-selector-color: $link-color !default;"}],"source_content_type":"text/x-scss","patch_set":108,"id":"3a29b11f_853925db","line":182,"in_reply_to":"3a29b11f_62173c45","updated":"2015-10-23 20:50:15.000000000","message":"Done","commit_id":"ad8263b1ef3814b60c08b66a0f2e31835ccf08e0"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"1ee26d21ec9ec9f359b2cd4bc65bc600d8166a78","unresolved":false,"context_lines":[{"line_number":179,"context_line":"/* Detail Pages */"},{"line_number":180,"context_line":"$detail-title-color: $brand-primary;"},{"line_number":181,"context_line":"$detail-group-color: $gray-light;"},{"line_number":182,"context_line":"$detail-separator-color: $gray-light;"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"/* Metadata Display */"},{"line_number":185,"context_line":"$metadata-display-selector-color: $link-color !default;"}],"source_content_type":"text/x-scss","patch_set":115,"id":"da85f559_b9a28897","line":182,"updated":"2015-11-11 20:40:43.000000000","message":"These should go away.","commit_id":"5bdac8f63b2ac589eb7bb453993188d92e6e1407"}]}
