)]}'
{"horizon/static/framework/widgets/table/hz-no-items.directive.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"279aa05dcc4baef6a8181075d4fdbd3d058081af","unresolved":false,"context_lines":[{"line_number":33,"context_line":"   *"},{"line_number":34,"context_line":"   * @example"},{"line_number":35,"context_line":"   * ```"},{"line_number":36,"context_line":"   * \u003chz-no-items-message"},{"line_number":37,"context_line":"   *   items\u003d\"table.iusers\""},{"line_number":38,"context_line":"   *   message\u003d\"table.noUsersText\"\u003e"},{"line_number":39,"context_line":"   * \u003c/hz-no-items-message\u003e"}],"source_content_type":"text/javascript","patch_set":12,"id":"1a4dcd0f_c499a2c5","line":36,"updated":"2015-08-27 17:10:58.000000000","message":"Hi Aaron, it\u0027s an attribute.\n\n\u003ctr hz-no-items... \u003e\u003c/hz-no-items\u003e","commit_id":"1632d6a8c449c7c23ef637ad65fe744463d6e60f"}],"horizon/static/framework/widgets/table/hz-no-items.directive.spec.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"b5ed3f5c40947e3f1ff9c220aa2934d298ccbbe6","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"      $scope.fakeData \u003d [];"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"      var markup \u003d"},{"line_number":40,"context_line":"        \u0027\u003ctable st-table\u003d\"fakeData\" st-safe-src\u003d\"safeFakeData\" hz-table\u003e\u0027 +"},{"line_number":41,"context_line":"        \u0027\u003cthead\u003e\u0027 +"},{"line_number":42,"context_line":"          \u0027\u003ctr\u003e\u0027 +"}],"source_content_type":"text/javascript","patch_set":12,"id":"fa1b9901_9da3b19e","line":39,"updated":"2015-08-17 18:41:57.000000000","message":"Take a look at https://review.openstack.org/#/c/213367/ for removing inline markup.","commit_id":"1632d6a8c449c7c23ef637ad65fe744463d6e60f"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"b5ed3f5c40947e3f1ff9c220aa2934d298ccbbe6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"          \u0027\u003ctr class\u003d\"detail-row\" ng-repeat-end\u003e\u0027 +"},{"line_number":56,"context_line":"            \u0027\u003ctd class\u003d\"detail\" colspan\u003d\"3\"\u003e\u003c/td\u003e\u0027 +"},{"line_number":57,"context_line":"          \u0027\u003c/tr\u003e\u0027 +"},{"line_number":58,"context_line":"          \u0027\u003ctr hz-no-items items\u003d\"fakeData\"\u003e\u003c/tr\u003e\u0027 +"},{"line_number":59,"context_line":"        \u0027\u003c/tbody\u003e\u0027 +"},{"line_number":60,"context_line":"        \u0027\u003c/table\u003e\u0027;"},{"line_number":61,"context_line":""}],"source_content_type":"text/javascript","patch_set":12,"id":"fa1b9901_1d600135","line":58,"updated":"2015-08-17 18:41:57.000000000","message":"what about test for custom message?","commit_id":"1632d6a8c449c7c23ef637ad65fe744463d6e60f"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"b5ed3f5c40947e3f1ff9c220aa2934d298ccbbe6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      $scope.$apply();"},{"line_number":65,"context_line":"    }));"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    it(\u0027has no message when there are users in the table\u0027, function() {"},{"line_number":68,"context_line":"      expect($element.find(\u0027tbody td.no-rows-help\u0027).length).toBe(0);"},{"line_number":69,"context_line":"    });"},{"line_number":70,"context_line":""}],"source_content_type":"text/javascript","patch_set":12,"id":"fa1b9901_fd398d42","line":67,"updated":"2015-08-17 18:41:57.000000000","message":"confusing to look at at first. maybe show that you are seeing 3 rows, and 0 no-message row would clarify it a bit more. I also prefer to see attribute/element lookup as oppose to class lookup.","commit_id":"1632d6a8c449c7c23ef637ad65fe744463d6e60f"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"b5ed3f5c40947e3f1ff9c220aa2934d298ccbbe6","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      $scope.fakeData \u003d [];"},{"line_number":74,"context_line":"      $scope.$apply();"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"      expect($element.find(\u0027tbody td.no-rows-help\u0027).length).toBe(1);"},{"line_number":77,"context_line":"    });"},{"line_number":78,"context_line":"  });"},{"line_number":79,"context_line":"}());"}],"source_content_type":"text/javascript","patch_set":12,"id":"fa1b9901_bdd8f5f0","line":76,"updated":"2015-08-17 18:41:57.000000000","message":"should look for the default message \"No items to display\" instead of length.","commit_id":"1632d6a8c449c7c23ef637ad65fe744463d6e60f"}],"horizon/static/framework/widgets/table/hz-no-items.html":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"b5ed3f5c40947e3f1ff9c220aa2934d298ccbbe6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  No-items-found-message:"},{"line_number":3,"context_line":"  Display message if no items match current filter"},{"line_number":4,"context_line":"--\u003e"},{"line_number":5,"context_line":"\u003ctd colspan\u003d\"100\" class\u003d\"no-rows-help\" ng-if\u003d\"items.length \u003d\u003d\u003d 0\"\u003e"},{"line_number":6,"context_line":"  \u003ctranslate\u003e{$message || \u0027No items to display.\u0027$}\u003c/translate\u003e"},{"line_number":7,"context_line":"\u003c/td\u003e"}],"source_content_type":"text/html","patch_set":12,"id":"fa1b9901_5d775902","line":5,"updated":"2015-08-17 18:41:57.000000000","message":"add attribute here for easy lookup?","commit_id":"1632d6a8c449c7c23ef637ad65fe744463d6e60f"}],"openstack_dashboard/dashboards/identity/static/dashboard/identity/users/table/table.spec.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"da8552f03ce8b90c71af213d2e35a3f780a1a305","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      $scope.fakeData \u003d [];"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"      var markup \u003d"},{"line_number":23,"context_line":"        \u0027\u003ctable st-table\u003d\"fakeData\" st-safe-src\u003d\"safeFakeData\" hz-table\u003e\u0027 +"},{"line_number":24,"context_line":"       \u0027\u003cthead\u003e\u0027 +"},{"line_number":25,"context_line":"          \u0027\u003ctr\u003e\u0027 +"},{"line_number":26,"context_line":"            \u0027\u003cth\u003e\u003cinput type\u003d\"checkbox\" hz-select-all\u003d\"fakeData\"/\u003e\u003c/th\u003e\u0027 +"}],"source_content_type":"text/javascript","patch_set":6,"id":"3a50d1a3_2798cabf","line":23,"updated":"2015-07-28 06:41:43.000000000","message":"indentation off.","commit_id":"2182def3e9fffbfb99cc8e7b8a691627ade786c4"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"da8552f03ce8b90c71af213d2e35a3f780a1a305","unresolved":false,"context_lines":[{"line_number":49,"context_line":"      $element \u003d angular.element(markup);"},{"line_number":50,"context_line":"      $compile($element)($scope);"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"      $scope.$digest();"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"      it(\u0027no user message not added when there are users\u0027, function() {"},{"line_number":55,"context_line":"        expect($element.find(\u0027tbody tr.no-rows-help\u0027).length).toBe(0);"}],"source_content_type":"text/javascript","patch_set":6,"id":"3a50d1a3_e78d027d","line":52,"updated":"2015-07-28 06:41:43.000000000","message":"can $apply be use here instead?","commit_id":"2182def3e9fffbfb99cc8e7b8a691627ade786c4"}],"openstack_dashboard/dashboards/identity/users/templates/users/table.html":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"e484caea9b3b5939c9e4250c303366414c6b30bf","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    \u003c/tr\u003e"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    \u003c!--"},{"line_number":185,"context_line":"      Display message if no items matching current filter."},{"line_number":186,"context_line":"    --\u003e"},{"line_number":187,"context_line":"    \u003ctr class\u003d\"no-rows-help\" ng-if\u003d\"iusers.length \u003d\u003d\u003d 0\"\u003e"},{"line_number":188,"context_line":"      \u003ctd colspan\u003d\"100\"\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"dac4157f_58e887e2","line":185,"updated":"2015-04-21 00:13:23.000000000","message":"match*\n\nAlso add a comment header like Thai has done, e.g.\n\nNo-items-found-message:","commit_id":"f4b2ef5e88b6a8d8500916c5b34a515ad0759ff2"},{"author":{"_account_id":11881,"name":"Aaron Sahlin","email":"asahlin@us.ibm.com","username":"asahlin"},"change_message_id":"a147378cd2ea9704c6d1a0b644d0c77c282f9baa","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    \u003c/tr\u003e"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    \u003c!--"},{"line_number":185,"context_line":"      Display message if no items matching current filter."},{"line_number":186,"context_line":"    --\u003e"},{"line_number":187,"context_line":"    \u003ctr class\u003d\"no-rows-help\" ng-if\u003d\"iusers.length \u003d\u003d\u003d 0\"\u003e"},{"line_number":188,"context_line":"      \u003ctd colspan\u003d\"100\"\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"dac4157f_034ba488","line":185,"in_reply_to":"dac4157f_58e887e2","updated":"2015-04-21 20:48:31.000000000","message":"Done","commit_id":"f4b2ef5e88b6a8d8500916c5b34a515ad0759ff2"}],"openstack_dashboard/static/dashboard/identity/users/table.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"e484caea9b3b5939c9e4250c303366414c6b30bf","unresolved":false,"context_lines":[{"line_number":53,"context_line":"          deleted: gettext(\u0027Delete\u0027)"},{"line_number":54,"context_line":"        },"},{"line_number":55,"context_line":"        table: {"},{"line_number":56,"context_line":"          noRows: gettext(\u0027No users to display.\u0027),"},{"line_number":57,"context_line":"        },"},{"line_number":58,"context_line":"        error: {"},{"line_number":59,"context_line":"          api: gettext(\u0027Unable to retrieve users\u0027),"}],"source_content_type":"text/javascript","patch_set":1,"id":"dac4157f_d8eed78a","line":56,"updated":"2015-04-21 00:13:23.000000000","message":"noItemsLabel","commit_id":"f4b2ef5e88b6a8d8500916c5b34a515ad0759ff2"},{"author":{"_account_id":11881,"name":"Aaron Sahlin","email":"asahlin@us.ibm.com","username":"asahlin"},"change_message_id":"a147378cd2ea9704c6d1a0b644d0c77c282f9baa","unresolved":false,"context_lines":[{"line_number":53,"context_line":"          deleted: gettext(\u0027Delete\u0027)"},{"line_number":54,"context_line":"        },"},{"line_number":55,"context_line":"        table: {"},{"line_number":56,"context_line":"          noRows: gettext(\u0027No users to display.\u0027),"},{"line_number":57,"context_line":"        },"},{"line_number":58,"context_line":"        error: {"},{"line_number":59,"context_line":"          api: gettext(\u0027Unable to retrieve users\u0027),"}],"source_content_type":"text/javascript","patch_set":1,"id":"dac4157f_5e0f332e","line":56,"in_reply_to":"dac4157f_d8eed78a","updated":"2015-04-21 20:48:31.000000000","message":"Done","commit_id":"f4b2ef5e88b6a8d8500916c5b34a515ad0759ff2"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"e484caea9b3b5939c9e4250c303366414c6b30bf","unresolved":false,"context_lines":[{"line_number":79,"context_line":"          rules: ["},{"line_number":80,"context_line":"            [\u0027identity\u0027, \u0027identity:list_users\u0027]"},{"line_number":81,"context_line":"          ]"},{"line_number":82,"context_line":"        })"},{"line_number":83,"context_line":"          .success(function(response) {"},{"line_number":84,"context_line":"            if (response.allowed) {"},{"line_number":85,"context_line":"              keystoneAPI.getUsers()"}],"source_content_type":"text/javascript","patch_set":1,"id":"dac4157f_b8656346","line":82,"updated":"2015-04-21 00:13:23.000000000","message":"would suggest to leave comment in parent patch instead of addressing here.","commit_id":"f4b2ef5e88b6a8d8500916c5b34a515ad0759ff2"},{"author":{"_account_id":11881,"name":"Aaron Sahlin","email":"asahlin@us.ibm.com","username":"asahlin"},"change_message_id":"a147378cd2ea9704c6d1a0b644d0c77c282f9baa","unresolved":false,"context_lines":[{"line_number":79,"context_line":"          rules: ["},{"line_number":80,"context_line":"            [\u0027identity\u0027, \u0027identity:list_users\u0027]"},{"line_number":81,"context_line":"          ]"},{"line_number":82,"context_line":"        })"},{"line_number":83,"context_line":"          .success(function(response) {"},{"line_number":84,"context_line":"            if (response.allowed) {"},{"line_number":85,"context_line":"              keystoneAPI.getUsers()"}],"source_content_type":"text/javascript","patch_set":1,"id":"dac4157f_be99af70","line":82,"in_reply_to":"dac4157f_b8656346","updated":"2015-04-21 20:48:31.000000000","message":"this was my auto formatter at work.  I will remove and and make comment to parent patch.","commit_id":"f4b2ef5e88b6a8d8500916c5b34a515ad0759ff2"}]}
