)]}'
{"openstack_dashboard/api/nova.py":[{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"e4a60002210919e6dbe743d4374a0395b73a34c7","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                  ephemeral\u003d0, metadata\u003dNone):"},{"line_number":200,"context_line":"    flavor \u003d novaclient(request).flavors.create(name, memory, vcpu,"},{"line_number":201,"context_line":"                                                disk, ephemeral\u003dephemeral)"},{"line_number":202,"context_line":"    if (metadata is not None):"},{"line_number":203,"context_line":"        flavor_extra_set(request, flavor.id, metadata)"},{"line_number":204,"context_line":"    return flavor"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMX%2F%2F9Bc%3D","line":202,"updated":"2012-12-05 08:19:05.000000000","message":"Just\n\n    if (metadata):\n\nwould be fine too. If metadata is {}, it will enter flavor_extra_set just to return back from the first check.","commit_id":"0e5e2cb89e885a7931fb480b59c0be989b405b1e"},{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"e4a60002210919e6dbe743d4374a0395b73a34c7","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def flavor_extra_set(request, flavor_id, metadata):"},{"line_number":238,"context_line":"    \"\"\"Set the flavor extra spec keys.\"\"\""},{"line_number":239,"context_line":"    if (metadata \u003d\u003d {}):  # not a way to delete keys"},{"line_number":240,"context_line":"        return None"},{"line_number":241,"context_line":"    flavor \u003d novaclient(request).flavors.get(flavor_id)"},{"line_number":242,"context_line":"    return flavor.set_keys(metadata)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMX%2F%2F9BY%3D","line":239,"updated":"2012-12-05 08:19:05.000000000","message":"Just\n\n    if (metadata):\n\nwould be fine here. We don\u0027t want to pass None values too.","commit_id":"0e5e2cb89e885a7931fb480b59c0be989b405b1e"}],"openstack_dashboard/dashboards/admin/flavors/forms.py":[{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"e4a60002210919e6dbe743d4374a0395b73a34c7","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                                            data[\u0027vcpus\u0027],"},{"line_number":100,"context_line":"                                            data[\u0027disk_gb\u0027],"},{"line_number":101,"context_line":"                                            ephemeral\u003ddata[\u0027eph_gb\u0027])"},{"line_number":102,"context_line":"            api.nova.flavor_extra_set(request, str(flavor.id), extras_dict)"},{"line_number":103,"context_line":"            msg \u003d _(\u0027Updated flavor \"%s\".\u0027) % data[\u0027name\u0027]"},{"line_number":104,"context_line":"            messages.success(request, msg)"},{"line_number":105,"context_line":"            return flavor"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMX%2F%2F9Ak%3D","line":102,"updated":"2012-12-05 08:19:05.000000000","message":"I\u0027m wondering why the \u0027if ()\u0027 is removed here? If there are no extras, we simply don\u0027t need to go further. I see the check is added in the flavor_extra_set method, but anyway we can just skip one more unnecessary call here too.","commit_id":"0e5e2cb89e885a7931fb480b59c0be989b405b1e"},{"author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"change_message_id":"1e6918519346e6dcd7572b5ccf8b9c5e70f7e08a","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                                            data[\u0027disk_gb\u0027],"},{"line_number":101,"context_line":"                                            ephemeral\u003ddata[\u0027eph_gb\u0027])"},{"line_number":102,"context_line":"            if (extras_dict):"},{"line_number":103,"context_line":"                api.nova.flavor_extra_set(request, str(flavor.id), extras_dict)"},{"line_number":104,"context_line":"            msg \u003d _(\u0027Updated flavor \"%s\".\u0027) % data[\u0027name\u0027]"},{"line_number":105,"context_line":"            messages.success(request, msg)"},{"line_number":106,"context_line":"            return flavor"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAMX%2F%2F5co%3D","line":103,"updated":"2012-12-09 21:24:01.000000000","message":"Why force this to a string? Does novaclient not handle the id type of the flavor it creates correctly?","commit_id":"011abbce1f5bbecc6061afaa149d1ce862846465"}],"openstack_dashboard/dashboards/admin/flavors/tests.py":[{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"e4a60002210919e6dbe743d4374a0395b73a34c7","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                                     \u0027OS-FLV-EXT-DATA:ephemeral\u0027: eph,"},{"line_number":57,"context_line":"                                     \u0027extra_specs\u0027: extra_specs})"},{"line_number":58,"context_line":"        # mocking the following"},{"line_number":59,"context_line":"        self.mox.StubOutWithMock(api.nova, \u0027flavor_list\u0027)"},{"line_number":60,"context_line":"        self.mox.StubOutWithMock(api.nova, \u0027flavor_get_extras\u0027)"},{"line_number":61,"context_line":"        self.mox.StubOutWithMock(api.nova, \u0027flavor_get\u0027)"},{"line_number":62,"context_line":"        self.mox.StubOutWithMock(api.nova, \u0027flavor_delete\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMX%2F%2F9Bk%3D","line":59,"updated":"2012-12-05 08:19:05.000000000","message":"Please use \n\n    @test.create_stubs()\n\nfor better readability.","commit_id":"0e5e2cb89e885a7931fb480b59c0be989b405b1e"},{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"e4a60002210919e6dbe743d4374a0395b73a34c7","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                                    \u0027OS-FLV-EXT-DATA:ephemeral\u0027: eph,"},{"line_number":113,"context_line":"                                    \u0027extra_specs\u0027: extra_specs})"},{"line_number":114,"context_line":"        #mocking the following"},{"line_number":115,"context_line":"        self.mox.StubOutWithMock(api.nova, \u0027flavor_list\u0027)"},{"line_number":116,"context_line":"        self.mox.StubOutWithMock(api.nova, \u0027flavor_get_extras\u0027)"},{"line_number":117,"context_line":"        self.mox.StubOutWithMock(api.nova, \u0027flavor_get\u0027)"},{"line_number":118,"context_line":"        self.mox.StubOutWithMock(api.nova, \u0027flavor_delete\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAMX%2F%2F9Bg%3D","line":115,"updated":"2012-12-05 08:19:05.000000000","message":"@test.create_stubs","commit_id":"0e5e2cb89e885a7931fb480b59c0be989b405b1e"}]}
