)]}'
{"openstack_dashboard/dashboards/admin/volumes/volumes/forms.py":[{"author":{"_account_id":8533,"name":"Marcos Fermín Lobo","email":"lobo@lukos.org","username":"mlobo"},"change_message_id":"faaf6e1f21fc269d8d6c68d731029fe1b3352a2c","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        cleaned_name \u003d self.cleaned_data[\u0027name\u0027]"},{"line_number":173,"context_line":"        if len(cleaned_name.strip()) \u003d\u003d 0:"},{"line_number":174,"context_line":"            error_message \u003d _(\"Volume type name can not be empty.\")"},{"line_number":175,"context_line":"            raise ValidationError(error_message)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        return cleaned_name"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1aca2d91_8b0d7c92","line":175,"updated":"2015-05-08 06:48:44.000000000","message":"I would prefer something like:\n\n- error_message \u003d _(\"Volume type name can not be empty.\")\n+ raise ValidationError(_(\"Volume type name can not be empty.\"))\n\nI think is the usual way to raise errors, check line 176 for example, there we are not using an extra var to get the exception message, we just put it in the exception.","commit_id":"a736dfe913ca04c2497ddcd698b3c4fe39308a44"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"71f611c95093ea3d00128d91958677e19271dbca","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    def clean_name(self):"},{"line_number":172,"context_line":"        cleaned_name \u003d self.cleaned_data[\u0027name\u0027]"},{"line_number":173,"context_line":"        if len(cleaned_name.strip()) \u003d\u003d 0:"},{"line_number":174,"context_line":"            raise ValidationError(\"Volume type name can not be empty.\")"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        return cleaned_name"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9af37de9_f5c9bead","line":174,"updated":"2015-05-11 10:25:18.000000000","message":"Doesn\u0027t this need translating?","commit_id":"b3a974cae82ed4eff1b7000e34164c40cef6dfc1"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"3a7298dbdf6babf48bbcb0496606f91ad557452b","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    def clean_name(self):"},{"line_number":172,"context_line":"        cleaned_name \u003d self.cleaned_data[\u0027name\u0027]"},{"line_number":173,"context_line":"        if len(cleaned_name.strip()) \u003d\u003d 0:"},{"line_number":174,"context_line":"            raise ValidationError(\"Volume type name can not be empty.\")"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        return cleaned_name"},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9af37de9_30dd1415","line":174,"in_reply_to":"9af37de9_f5c9bead","updated":"2015-05-11 11:12:42.000000000","message":"sorry, miss that, will address in the coming patch set :)","commit_id":"b3a974cae82ed4eff1b7000e34164c40cef6dfc1"}]}
