)]}'
{"openstack_dashboard/dashboards/project/access_and_security/api_access/tables.py":[{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"7ecec87dbd771e87e5b6f18e5533471d28840acf","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class DownloadOpenRC(tables.LinkAction):"},{"line_number":46,"context_line":"    name \u003d \"download_openrc\""},{"line_number":47,"context_line":"    verbose_name \u003d _(\"Download OpenStack RC File\")"},{"line_number":48,"context_line":"    verbose_name_plural \u003d _(\"Download OpenStack RC File\")"},{"line_number":49,"context_line":"    icon \u003d \"download\""},{"line_number":50,"context_line":"    url \u003d \"horizon:project:access_and_security:api_access:openrc\""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_f06425e6","line":47,"updated":"2015-06-16 00:01:28.000000000","message":"Shouldn\u0027t you name this v3? for consistensy reasons and so as not to confuse users.\n\nI feel that a user might thing that openrc v2 is greater the just openrc. I might be overthinking here, but I like UI to be consistent and fool-proof.","commit_id":"7ba443b0231448e1d79a86d7cc09298f97f4e039"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"2366e4dab77d817ec5b640cebde4fcc034934ce4","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class DownloadOpenRC(tables.LinkAction):"},{"line_number":46,"context_line":"    name \u003d \"download_openrc\""},{"line_number":47,"context_line":"    verbose_name \u003d _(\"Download OpenStack RC File\")"},{"line_number":48,"context_line":"    verbose_name_plural \u003d _(\"Download OpenStack RC File\")"},{"line_number":49,"context_line":"    icon \u003d \"download\""},{"line_number":50,"context_line":"    url \u003d \"horizon:project:access_and_security:api_access:openrc\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_ff490061","line":47,"in_reply_to":"fa32b979_f06425e6","updated":"2015-08-05 22:57:02.000000000","message":"Agreed, or change v2 to be \"old\" or \"legacy\" or something similar.","commit_id":"7ba443b0231448e1d79a86d7cc09298f97f4e039"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9421c01127ea48faebeecb0a2ea1a06d5d915526","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    verbose_name \u003d _(\"Download OpenStack RC File v2.0\")"},{"line_number":59,"context_line":"    verbose_name_plural \u003d _(\"Download OpenStack RC File v2.0\")"},{"line_number":60,"context_line":"    icon \u003d \"download\""},{"line_number":61,"context_line":"    url \u003d \"horizon:project:access_and_security:api_access:openrcv2\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class ViewCredentials(tables.LinkAction):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_0e76ab06","line":61,"updated":"2015-12-09 11:18:16.000000000","message":"Is there no way to disable openrc v2? It can be done later of course.","commit_id":"46a739531f9c2eb55c65000eca6b5737b16145ab"}],"openstack_dashboard/dashboards/project/access_and_security/templates/access_and_security/api_access/_credentials.html":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"65a705fb4c7b29c53ec85b6fac22216fb2e3aa21","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      \u003clabel class\u003d\"control-label\"\u003e{% trans \"Domain Name\" %}\u003c/label\u003e"},{"line_number":28,"context_line":"      \u003cinput type\u003d\"text\" class\u003d\"form-control\" readonly value\u003d\"{{ openrc_creds.user_domain_name }}\"\u003e"},{"line_number":29,"context_line":"    \u003c/div\u003e"},{"line_number":30,"context_line":"    {% endif %}"},{"line_number":31,"context_line":"    \u003cdiv class\u003d\"form-group\"\u003e"},{"line_number":32,"context_line":"      \u003clabel class\u003d\"control-label\"\u003e{% trans \"Authentication URL\" %}\u003c/label\u003e"},{"line_number":33,"context_line":"      \u003cinput type\u003d\"text\" class\u003d\"form-control\" readonly value\u003d\"{{ openrc_creds.auth_url }}\"\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"fa32b979_4273bc15","line":30,"updated":"2015-06-16 06:42:21.000000000","message":"this probably looks better moving up, next to user name.\n\nHow about the project domain name, that should be displayed as well","commit_id":"7ba443b0231448e1d79a86d7cc09298f97f4e039"}],"openstack_dashboard/dashboards/project/access_and_security/templates/access_and_security/api_access/openrc.sh.template":[{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"7ecec87dbd771e87e5b6f18e5533471d28840acf","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# as the entity that owns the resources."},{"line_number":19,"context_line":"export OS_PROJECT_ID\u003d{{ tenant_id }}"},{"line_number":20,"context_line":"export OS_PROJECT_NAME\u003d\"{{ tenant_name|shellfilter }}\""},{"line_number":21,"context_line":"export OS_USER_DOMAIN_NAME\u003d\"{{ user_domain_name|shellfilter }}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# In addition to the owning entity (tenant), OpenStack stores the entity"},{"line_number":24,"context_line":"# performing the action as the **user**."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa32b979_3045ad16","line":21,"updated":"2015-06-16 00:01:28.000000000","message":"From the helpers and the docs I got the feeling, that this is optional, and can be empty. If so — in the spirit of the script — shouldn\u0027t we remove the variable with unset, like it\u0027s done for OS_REGION_NAME or check for emptiness before setting?","commit_id":"7ba443b0231448e1d79a86d7cc09298f97f4e039"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"2366e4dab77d817ec5b640cebde4fcc034934ce4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"export OS_PROJECT_ID\u003d{{ tenant_id }}"},{"line_number":20,"context_line":"export OS_PROJECT_NAME\u003d\"{{ tenant_name|shellfilter }}\""},{"line_number":21,"context_line":"export OS_USER_DOMAIN_NAME\u003d\"{{ user_domain_name|shellfilter }}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# In addition to the owning entity (tenant), OpenStack stores the entity"},{"line_number":24,"context_line":"# performing the action as the **user**."},{"line_number":25,"context_line":"export OS_USERNAME\u003d\"{{ user.username|shellfilter }}\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a4dcd0f_1c02ba0b","line":22,"updated":"2015-08-05 22:57:02.000000000","message":"unset OS_TENANT_ID\n\nunset OS_TENANT_NAME\n\nThat way, if a user goes from \"source v2.rc\" to \"source v3.rc\" weirdness doesn\u0027t happen.","commit_id":"7ba443b0231448e1d79a86d7cc09298f97f4e039"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"56dff5d98e7f87652b02afff6e0e29b3524244ad","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# as the entity that owns the resources."},{"line_number":18,"context_line":"export OS_PROJECT_ID\u003d{{ tenant_id }}"},{"line_number":19,"context_line":"export OS_PROJECT_NAME\u003d\"{{ tenant_name|shellfilter }}\""},{"line_number":20,"context_line":"export OS_USER_DOMAIN_NAME\u003d\"{{ user_domain_name|shellfilter }}\""},{"line_number":21,"context_line":"if [ -z \"$OS_USER_DOMAIN_NAME\" ]; then unset OS_USER_DOMAIN_NAME; fi"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# unset v2.0 items in case set"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"da20952f_711d170e","line":20,"updated":"2015-09-11 19:03:51.000000000","message":"you can also set OS_PROJECT_DOMAIN_NAME\n\nnote that if PROJECT_ID is given, then PROJECT_NAME is not necessary","commit_id":"961df65cb3b0f5c4659b285add0379afac2aa02d"}],"openstack_dashboard/dashboards/project/access_and_security/templates/access_and_security/api_access/openrc_v2.sh.template":[{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"2366e4dab77d817ec5b640cebde4fcc034934ce4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"export OS_TENANT_ID\u003d{{ tenant_id }}"},{"line_number":20,"context_line":"export OS_TENANT_NAME\u003d\"{{ tenant_name|shellfilter }}\""},{"line_number":21,"context_line":"export OS_PROJECT_NAME\u003d\"{{ tenant_name|shellfilter }}\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# In addition to the owning entity (tenant), OpenStack stores the entity"},{"line_number":24,"context_line":"# performing the action as the **user**."},{"line_number":25,"context_line":"export OS_USERNAME\u003d\"{{ user.username|shellfilter }}\""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1a4dcd0f_9f231ca7","line":22,"updated":"2015-08-05 22:57:02.000000000","message":"unset OS_PROJECT_ID\n\nunset OS_PROJECT_NAME\n\nunset OS_USER_DOMAIN_NAME\n\nunset OS_PROJECT_DOMAIN_NAME\n\nThat way, if a user goes from \"source v3.rc\" to \"source v2.rc\" weirdness doesn\u0027t happen.","commit_id":"7ba443b0231448e1d79a86d7cc09298f97f4e039"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"7ecec87dbd771e87e5b6f18e5533471d28840acf","unresolved":false,"context_lines":[{"line_number":33,"context_line":"# OS_REGION_NAME is optional and only valid in certain environments."},{"line_number":34,"context_line":"export OS_REGION_NAME\u003d\"{{ region|shellfilter }}\""},{"line_number":35,"context_line":"# Don\u0027t leave a blank variable, unset it if it was empty"},{"line_number":36,"context_line":"if [ -z \"$OS_REGION_NAME\" ]; then unset OS_REGION_NAME; fi"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fa32b979_305ccdec","line":36,"updated":"2015-06-16 00:01:28.000000000","message":"I know this is unrelated, but can\u0027t we check (here and other template) if region is empty and not set it at all instead of unsetting it in bash? Feels like double work.","commit_id":"7ba443b0231448e1d79a86d7cc09298f97f4e039"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"adae9589fae3ddcec9cc4185cef56199d9deaf2d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% load shellfilter %}"},{"line_number":2,"context_line":"#!/bin/bash"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# To use an OpenStack cloud you need to authenticate against the Identity"},{"line_number":5,"context_line":"# service named keystone, which returns a **Token** and **Service Catalog**."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"da20952f_3de1602a","line":2,"updated":"2015-09-01 12:28:09.000000000","message":"just for the sake of being consistent let\u0027s move this to the line above.\n\nsee https://review.openstack.org/#/c/186846/3/openstack_dashboard/dashboards/project/access_and_security/templates/access_and_security/api_access/openrc.sh.template","commit_id":"d0e0d7f27047d16debe4aa92176a4792ae0bba84"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"e8c48ad1d50bd4c383f816f30a8913e20dbae060","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% load shellfilter %}"},{"line_number":2,"context_line":"#!/bin/bash"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# To use an OpenStack cloud you need to authenticate against the Identity"},{"line_number":5,"context_line":"# service named keystone, which returns a **Token** and **Service Catalog**."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"da20952f_90650eb0","line":2,"in_reply_to":"da20952f_3de1602a","updated":"2015-09-07 10:57:45.000000000","message":"Also please change #!/bin/bash to #!/usr/bin/env bash (see https://review.openstack.org/#/c/218594/ for a proposed change for the openrc.sh template).","commit_id":"d0e0d7f27047d16debe4aa92176a4792ae0bba84"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"f93076744fe713ee2d844f10cfd4c9c476d1844c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% load shellfilter %}"},{"line_number":2,"context_line":"#!/bin/bash"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# To use an OpenStack cloud you need to authenticate against the Identity"},{"line_number":5,"context_line":"# service named keystone, which returns a **Token** and **Service Catalog**."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"da20952f_6ed1b7fa","line":2,"in_reply_to":"da20952f_3de1602a","updated":"2015-09-11 16:04:12.000000000","message":"Done","commit_id":"d0e0d7f27047d16debe4aa92176a4792ae0bba84"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"f93076744fe713ee2d844f10cfd4c9c476d1844c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% load shellfilter %}"},{"line_number":2,"context_line":"#!/bin/bash"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# To use an OpenStack cloud you need to authenticate against the Identity"},{"line_number":5,"context_line":"# service named keystone, which returns a **Token** and **Service Catalog**."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"da20952f_8ece8b58","line":2,"in_reply_to":"da20952f_90650eb0","updated":"2015-09-11 16:04:12.000000000","message":"Done","commit_id":"d0e0d7f27047d16debe4aa92176a4792ae0bba84"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"adae9589fae3ddcec9cc4185cef56199d9deaf2d","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# If your configuration has multiple regions, we set that information here."},{"line_number":37,"context_line":"# OS_REGION_NAME is optional and only valid in certain environments."},{"line_number":38,"context_line":"export OS_REGION_NAME\u003d\"{{ region|shellfilter }}\""},{"line_number":39,"context_line":"# Don\u0027t leave a blank variable, unset it if it was empty"},{"line_number":40,"context_line":"if [ -z \"$OS_REGION_NAME\" ]; then unset OS_REGION_NAME; fi"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"da20952f_5dd1b421","line":38,"updated":"2015-09-01 12:28:09.000000000","message":"is it a good idea to test against the variable in a template here?\n\nyou could do something like \n\n {% if region|shellfilter %}\n   export OS_REGION_NAME\u003d\"{{ region|shellfilter }}\"\n {% endif %}\n\n\nsee https://docs.djangoproject.com/en/1.8/ref/templates/builtins/#filters\nthis would eliminate the need to test for -z on bash side.\n\nWhat do you think","commit_id":"d0e0d7f27047d16debe4aa92176a4792ae0bba84"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"a362343dfcca92f5599e8aa0de24405422e829c6","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# If your configuration has multiple regions, we set that information here."},{"line_number":37,"context_line":"# OS_REGION_NAME is optional and only valid in certain environments."},{"line_number":38,"context_line":"export OS_REGION_NAME\u003d\"{{ region|shellfilter }}\""},{"line_number":39,"context_line":"# Don\u0027t leave a blank variable, unset it if it was empty"},{"line_number":40,"context_line":"if [ -z \"$OS_REGION_NAME\" ]; then unset OS_REGION_NAME; fi"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"da20952f_f14fe78f","line":38,"in_reply_to":"da20952f_5dd1b421","updated":"2015-09-04 16:16:10.000000000","message":"honestly, this is just content from the existing file. Whether changing it or not is a good idea, is a valid question. I\u0027m just not entirely sure that\u0027s the subject of this patch.","commit_id":"d0e0d7f27047d16debe4aa92176a4792ae0bba84"},{"author":{"_account_id":9237,"name":"Kevin Fox","email":"kevin@efox.cc","username":"kfox1111"},"change_message_id":"4f5aa0262eca99b9b0ad8ab1bcbefe962cd78097","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# If your configuration has multiple regions, we set that information here."},{"line_number":37,"context_line":"# OS_REGION_NAME is optional and only valid in certain environments."},{"line_number":38,"context_line":"export OS_REGION_NAME\u003d\"{{ region|shellfilter }}\""},{"line_number":39,"context_line":"# Don\u0027t leave a blank variable, unset it if it was empty"},{"line_number":40,"context_line":"if [ -z \"$OS_REGION_NAME\" ]; then unset OS_REGION_NAME; fi"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"da20952f_8431875b","line":38,"in_reply_to":"da20952f_f14fe78f","updated":"2015-09-04 16:30:17.000000000","message":"Yeah. We have a bad habit of changing to the \"new way\" of doing things in a feature patch and not going back and fixing all the existing code to match. I\u0027d rather see things done as two patches, 1, a feature addition patch that looks like the existing code. 2, a patch to change all the occurrences to the \"new way\" of doing things.\n\nKirill: I do like your suggestion for skipping the shell conditional entirely. But it also introduces a bug. it needs an else condition to force unset OS_REGION_NAME. Hence, it would be nice to have it as a separate patch so eyes can be put just on that one thing.","commit_id":"d0e0d7f27047d16debe4aa92176a4792ae0bba84"}]}
