)]}'
{"openstack_dashboard/dashboards/admin/instances/tables.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"cbf3e71d66f6d6aa1432dcb7d2df241ff13e19db","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        row_class \u003d AdminUpdateRow"},{"line_number":98,"context_line":"        row_actions \u003d (EditInstance, ConsoleLink, LogLink, CreateSnapshot,"},{"line_number":99,"context_line":"                       TogglePause, ToggleSuspend, RebootInstance,"},{"line_number":100,"context_line":"                       TerminateInstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FwNE%3D","side":"PARENT","line":100,"updated":"2013-01-07 16:41:15.000000000","message":"Nitpick: should the resize- and migrate-related actions be grouped together in this list?","commit_id":"869eaf82f755c5bcf0f89eacc235f0fb12f7f166"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"01431422a9cdef02fa2c8b7be0c42cc53d5f682c","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        row_class \u003d AdminUpdateRow"},{"line_number":98,"context_line":"        row_actions \u003d (EditInstance, ConsoleLink, LogLink, CreateSnapshot,"},{"line_number":99,"context_line":"                       TogglePause, ToggleSuspend, RebootInstance,"},{"line_number":100,"context_line":"                       TerminateInstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fu7s%3D","side":"PARENT","line":100,"in_reply_to":"AAAAM3%2F%2FwNE%3D","updated":"2013-01-08 10:21:34.000000000","message":"This list actually determines the order in which actions appear in the UI when they\u0027re allowed -- so it makes sense to have Confirm and Revert first when they\u0027re needed, while Migrate doesn\u0027t need to be so high up the list.","commit_id":"869eaf82f755c5bcf0f89eacc235f0fb12f7f166"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"cbf3e71d66f6d6aa1432dcb7d2df241ff13e19db","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        TerminateInstance, EditInstance, ConsoleLink, LogLink, CreateSnapshot,"},{"line_number":29,"context_line":"        TogglePause, ToggleSuspend, RebootInstance, ConfirmResize,"},{"line_number":30,"context_line":"        RevertResize, get_size, UpdateRow, get_ips, get_power_state,"},{"line_number":31,"context_line":"        _is_deleting, ACTIVE_STATES, STATUS_DISPLAY_CHOICES,"},{"line_number":32,"context_line":"        TASK_DISPLAY_CHOICES)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FwNM%3D","line":31,"updated":"2013-01-07 16:41:15.000000000","message":"Seems unconventional to import a function named with a leading underscore (which if I understand the python convention correctly usually connotes a \"private\" method).\n\nMaybe just rename _is_deleting and/or move to a more convenient utils module?","commit_id":"9ad0c69c509a0bba59b3fbdb620a25b5d08805dd"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"01431422a9cdef02fa2c8b7be0c42cc53d5f682c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        TerminateInstance, EditInstance, ConsoleLink, LogLink, CreateSnapshot,"},{"line_number":29,"context_line":"        TogglePause, ToggleSuspend, RebootInstance, ConfirmResize,"},{"line_number":30,"context_line":"        RevertResize, get_size, UpdateRow, get_ips, get_power_state,"},{"line_number":31,"context_line":"        _is_deleting, ACTIVE_STATES, STATUS_DISPLAY_CHOICES,"},{"line_number":32,"context_line":"        TASK_DISPLAY_CHOICES)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fu68%3D","line":31,"in_reply_to":"AAAAM3%2F%2FwNM%3D","updated":"2013-01-08 10:21:34.000000000","message":"That\u0027s correct, I\u0027ll see what to do about that.\n\nTables.py in admin/instances is basically the same as tables.py in project/instances except with more rights. I\u0027m not sure _is_deleting would be needed or should be used anywhere else than those two places, so I\u0027d be wary of moving it to a utility class. I\u0027ll see what I can do.","commit_id":"9ad0c69c509a0bba59b3fbdb620a25b5d08805dd"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"cbf3e71d66f6d6aa1432dcb7d2df241ff13e19db","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def allowed(self, request, instance):"},{"line_number":46,"context_line":"        return ((instance.status in ACTIVE_STATES"},{"line_number":47,"context_line":"                 or instance.status \u003d\u003d \u0027SHUTOFF\u0027)"},{"line_number":48,"context_line":"                and not _is_deleting(instance))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def action(self, request, obj_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FwNs%3D","line":47,"updated":"2013-01-07 16:41:15.000000000","message":"Nitpick: the inner parens are not required as boolean or has higher precedence than and.","commit_id":"9ad0c69c509a0bba59b3fbdb620a25b5d08805dd"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"01431422a9cdef02fa2c8b7be0c42cc53d5f682c","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def allowed(self, request, instance):"},{"line_number":46,"context_line":"        return ((instance.status in ACTIVE_STATES"},{"line_number":47,"context_line":"                 or instance.status \u003d\u003d \u0027SHUTOFF\u0027)"},{"line_number":48,"context_line":"                and not _is_deleting(instance))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def action(self, request, obj_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Fu7Q%3D","line":47,"in_reply_to":"AAAAM3%2F%2FwNs%3D","updated":"2013-01-08 10:21:34.000000000","message":"I\u0027m tempted to leave them in, to keep it clear also for people who huh might need a refresh on their precedence rules from time to time...","commit_id":"9ad0c69c509a0bba59b3fbdb620a25b5d08805dd"}]}