)]}'
{"openstack_dashboard/api/lbaas.py":[{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"5eb63d6018ad1bb901cc2403e011571bf4f0d043","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        pool[\u0027subnet\u0027] \u003d neutron.subnet_get(request, pool[\u0027subnet_id\u0027])"},{"line_number":186,"context_line":"        pool[\u0027vip\u0027] \u003d _get_vip(request, pool, vip_dict\u003dNone,"},{"line_number":187,"context_line":"                               expand_name_only\u003dFalse)"},{"line_number":188,"context_line":"        try:"},{"line_number":189,"context_line":"            pool[\u0027members\u0027] \u003d _member_list(request, expand_pool\u003dFalse,"},{"line_number":190,"context_line":"                                           pool_id\u003dpool_id)"},{"line_number":191,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_6061b6a8","line":188,"updated":"2015-06-10 20:52:05.000000000","message":"I\u0027m confused about where these lines came from. Have multiple patches been included in this cherry-pick? That isn\u0027t reflected in the commit message.","commit_id":"0bfe4d1103e7e0cbde73577b2764c5044995c418"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"519e52516156a70c510ef31c43b9085ca698b855","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        pool[\u0027subnet\u0027] \u003d neutron.subnet_get(request, pool[\u0027subnet_id\u0027])"},{"line_number":186,"context_line":"        pool[\u0027vip\u0027] \u003d _get_vip(request, pool, vip_dict\u003dNone,"},{"line_number":187,"context_line":"                               expand_name_only\u003dFalse)"},{"line_number":188,"context_line":"        try:"},{"line_number":189,"context_line":"            pool[\u0027members\u0027] \u003d _member_list(request, expand_pool\u003dFalse,"},{"line_number":190,"context_line":"                                           pool_id\u003dpool_id)"},{"line_number":191,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_a31fb8b5","line":188,"in_reply_to":"3afb71cf_6061b6a8","updated":"2015-06-10 21:28:34.000000000","message":"These lines were just added to a try / except block.   The lines below are now needed because the api call pool_health_monitor_list() no longer works the same way (or if it ever worked correctly is my suspicion from the original bug)","commit_id":"0bfe4d1103e7e0cbde73577b2764c5044995c418"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"4564e0ff8da42cade2775ea3f30c08d228aa0b48","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            pool[\u0027members\u0027] \u003d _member_list(request, expand_pool\u003dFalse,"},{"line_number":190,"context_line":"                                           pool_id\u003dpool_id)"},{"line_number":191,"context_line":"        except Exception:"},{"line_number":192,"context_line":"            messages.warning(request, _(\"Unable to get members for pool \""},{"line_number":193,"context_line":"                                        \"%(pool)s.\") % {\"pool\": pool_id})"},{"line_number":194,"context_line":"        monitors \u003d []"},{"line_number":195,"context_line":"        for monitor_id in pool[\u0027health_monitors\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_ee6b5e83","line":192,"updated":"2015-06-10 19:03:02.000000000","message":"missing import messages","commit_id":"0bfe4d1103e7e0cbde73577b2764c5044995c418"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"519e52516156a70c510ef31c43b9085ca698b855","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            pool[\u0027members\u0027] \u003d _member_list(request, expand_pool\u003dFalse,"},{"line_number":190,"context_line":"                                           pool_id\u003dpool_id)"},{"line_number":191,"context_line":"        except Exception:"},{"line_number":192,"context_line":"            messages.warning(request, _(\"Unable to get members for pool \""},{"line_number":193,"context_line":"                                        \"%(pool)s.\") % {\"pool\": pool_id})"},{"line_number":194,"context_line":"        monitors \u003d []"},{"line_number":195,"context_line":"        for monitor_id in pool[\u0027health_monitors\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_c37514cb","line":192,"in_reply_to":"3afb71cf_ee6b5e83","updated":"2015-06-10 21:28:34.000000000","message":"Done","commit_id":"0bfe4d1103e7e0cbde73577b2764c5044995c418"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"4564e0ff8da42cade2775ea3f30c08d228aa0b48","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                                 _(\"Unable to get health monitor \""},{"line_number":202,"context_line":"                                   \"%(monitor_id)s for pool %(pool)s.\")"},{"line_number":203,"context_line":"                                 % {\"pool\": pool_id,"},{"line_number":204,"context_line":"                                    \"monitor_id\": monitor_id})"},{"line_number":205,"context_line":"        pool[\u0027health_monitors\u0027] \u003d monitors"},{"line_number":206,"context_line":"    return Pool(pool)"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_ee023eb3","line":204,"updated":"2015-06-10 19:03:02.000000000","message":"would it be better to aggregate all monitor_ids that have problem and render only one warning msg","commit_id":"0bfe4d1103e7e0cbde73577b2764c5044995c418"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"519e52516156a70c510ef31c43b9085ca698b855","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                                 _(\"Unable to get health monitor \""},{"line_number":202,"context_line":"                                   \"%(monitor_id)s for pool %(pool)s.\")"},{"line_number":203,"context_line":"                                 % {\"pool\": pool_id,"},{"line_number":204,"context_line":"                                    \"monitor_id\": monitor_id})"},{"line_number":205,"context_line":"        pool[\u0027health_monitors\u0027] \u003d monitors"},{"line_number":206,"context_line":"    return Pool(pool)"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_a34d78c5","line":204,"in_reply_to":"3afb71cf_400b5ad6","updated":"2015-06-10 21:28:34.000000000","message":"This is the part that was / is broken for juno.  If you don\u0027t include it, lbaas is pretty useless in horizon.","commit_id":"0bfe4d1103e7e0cbde73577b2764c5044995c418"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"5eb63d6018ad1bb901cc2403e011571bf4f0d043","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                                 _(\"Unable to get health monitor \""},{"line_number":202,"context_line":"                                   \"%(monitor_id)s for pool %(pool)s.\")"},{"line_number":203,"context_line":"                                 % {\"pool\": pool_id,"},{"line_number":204,"context_line":"                                    \"monitor_id\": monitor_id})"},{"line_number":205,"context_line":"        pool[\u0027health_monitors\u0027] \u003d monitors"},{"line_number":206,"context_line":"    return Pool(pool)"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_400b5ad6","line":204,"in_reply_to":"3afb71cf_ee023eb3","updated":"2015-06-10 20:52:05.000000000","message":"This is straight from the cherry-pick. While I agree with your comment I don\u0027t think it belongs on this change set.","commit_id":"0bfe4d1103e7e0cbde73577b2764c5044995c418"}]}
