)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"50f15d91c80a8e36deed17f1a012cf1eebc9bbfa","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Implemented basic CRD for router"},{"line_number":11,"context_line":"Add/remove interface support"},{"line_number":12,"context_line":"Support set gateway and clear gateway"},{"line_number":13,"context_line":"External network parameter support"},{"line_number":14,"context_line":"External gateway option for admin"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ie4cac962eb8fadc021c80cf05e2aa63caab3c00a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAM3%2F%2Fvl0%3D","line":13,"updated":"2013-01-07 23:06:41.000000000","message":"Please remove it.","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"50f15d91c80a8e36deed17f1a012cf1eebc9bbfa","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Add/remove interface support"},{"line_number":12,"context_line":"Support set gateway and clear gateway"},{"line_number":13,"context_line":"External network parameter support"},{"line_number":14,"context_line":"External gateway option for admin"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ie4cac962eb8fadc021c80cf05e2aa63caab3c00a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAM3%2F%2Fvlw%3D","line":14,"updated":"2013-01-07 23:06:41.000000000","message":"What does it mean? I can\u0027t understand what is \"external gateway\" in this context.","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"}],"horizon/templatetags/horizon.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9fe6c050e0a15392c38da9621b13bd2cc06764","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    \"\"\" Generates sub-navigation entries for the current dashboard. \"\"\""},{"line_number":66,"context_line":"    if \u0027request\u0027 not in context:"},{"line_number":67,"context_line":"        return {}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    dashboard \u003d context[\u0027request\u0027].horizon[\u0027dashboard\u0027]"},{"line_number":70,"context_line":"    panel_groups \u003d dashboard.get_panel_groups()"},{"line_number":71,"context_line":"    non_empty_groups \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fxjw%3D","line":68,"updated":"2013-01-06 02:03:30.000000000","message":"This is not a part of this patch.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    \"\"\" Generates sub-navigation entries for the current dashboard. \"\"\""},{"line_number":66,"context_line":"    if \u0027request\u0027 not in context:"},{"line_number":67,"context_line":"        return {}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    dashboard \u003d context[\u0027request\u0027].horizon[\u0027dashboard\u0027]"},{"line_number":70,"context_line":"    panel_groups \u003d dashboard.get_panel_groups()"},{"line_number":71,"context_line":"    non_empty_groups \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv%2Fg%3D","line":68,"in_reply_to":"AAAAM3%2F%2Fxjw%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"}],"openstack_dashboard/api/quantum.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9fe6c050e0a15392c38da9621b13bd2cc06764","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class Router(QuantumAPIDictWrapper):"},{"line_number":85,"context_line":"    \"\"\"Wrapper for quantum ports\"\"\""},{"line_number":86,"context_line":"    _attrs \u003d [\u0027name\u0027, \u0027id\u0027, \u0027tenant_id\u0027,"},{"line_number":87,"context_line":"              \u0027admin_state_up\u0027]"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fxkc%3D","line":85,"updated":"2013-01-06 02:03:30.000000000","message":"ports -\u003e routers","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class Router(QuantumAPIDictWrapper):"},{"line_number":85,"context_line":"    \"\"\"Wrapper for quantum ports\"\"\""},{"line_number":86,"context_line":"    _attrs \u003d [\u0027name\u0027, \u0027id\u0027, \u0027tenant_id\u0027,"},{"line_number":87,"context_line":"              \u0027admin_state_up\u0027]"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv%2FQ%3D","line":85,"in_reply_to":"AAAAM3%2F%2Fxkc%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9fe6c050e0a15392c38da9621b13bd2cc06764","unresolved":false,"context_lines":[{"line_number":84,"context_line":"class Router(QuantumAPIDictWrapper):"},{"line_number":85,"context_line":"    \"\"\"Wrapper for quantum ports\"\"\""},{"line_number":86,"context_line":"    _attrs \u003d [\u0027name\u0027, \u0027id\u0027, \u0027tenant_id\u0027,"},{"line_number":87,"context_line":"              \u0027admin_state_up\u0027]"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def __init__(self, apiresource):"},{"line_number":90,"context_line":"        #apiresource[\u0027admin_state\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxkU%3D","line":87,"updated":"2013-01-06 02:03:30.000000000","message":"When we use QuantumAPIDictWrapper, _attrs is not required.\nMy patch https://review.openstack.org/19037 removes _attrs in Network/Subnet/Port.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"class Router(QuantumAPIDictWrapper):"},{"line_number":85,"context_line":"    \"\"\"Wrapper for quantum ports\"\"\""},{"line_number":86,"context_line":"    _attrs \u003d [\u0027name\u0027, \u0027id\u0027, \u0027tenant_id\u0027,"},{"line_number":87,"context_line":"              \u0027admin_state_up\u0027]"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def __init__(self, apiresource):"},{"line_number":90,"context_line":"        #apiresource[\u0027admin_state\u0027] \u003d \\"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv%2FM%3D","line":87,"in_reply_to":"AAAAM3%2F%2FxkU%3D","updated":"2013-01-07 20:24:57.000000000","message":"Thanks! removed","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9fe6c050e0a15392c38da9621b13bd2cc06764","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    return Port(port)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"TEST_ROUTER \u003d {\u0027id\u0027: \u0027test\u0027, \u0027name\u0027: \u0027hoge\u0027, \u0027status\u0027: \u0027UP\u0027}"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"def router_create(request, name, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxkY%3D","line":275,"updated":"2013-01-06 02:03:30.000000000","message":"Is it for unittests? If so it is better to remove it.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":272,"context_line":"    return Port(port)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"TEST_ROUTER \u003d {\u0027id\u0027: \u0027test\u0027, \u0027name\u0027: \u0027hoge\u0027, \u0027status\u0027: \u0027UP\u0027}"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"def router_create(request, name, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv%2FI%3D","line":275,"in_reply_to":"AAAAM3%2F%2FxkY%3D","updated":"2013-01-07 20:24:57.000000000","message":"my bad.. removed","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56da603837a73b45416fb3d29398b4ba692ca6db","unresolved":false,"context_lines":[{"line_number":275,"context_line":"TEST_ROUTER \u003d {\u0027id\u0027: \u0027test\u0027, \u0027name\u0027: \u0027hoge\u0027, \u0027status\u0027: \u0027UP\u0027}"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"def router_create(request, name, **kwargs):"},{"line_number":279,"context_line":"    LOG.debug(\"router_create(): name\u003d%s, kwargs\u003d%s\" % (name, kwargs))"},{"line_number":280,"context_line":"    body \u003d {\u0027router\u0027: {\u0027name\u0027: name}}"},{"line_number":281,"context_line":"    body[\u0027router\u0027].update(kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxQc%3D","line":278,"updated":"2013-01-06 17:39:07.000000000","message":"I prefer to passing \u0027name\u0027 in kwargs rather than passing name explicitly since since \u0027name\u0027 is not required. Other *_create do not take \u0027name\u0027 argument explicitly.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":275,"context_line":"TEST_ROUTER \u003d {\u0027id\u0027: \u0027test\u0027, \u0027name\u0027: \u0027hoge\u0027, \u0027status\u0027: \u0027UP\u0027}"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"def router_create(request, name, **kwargs):"},{"line_number":279,"context_line":"    LOG.debug(\"router_create(): name\u003d%s, kwargs\u003d%s\" % (name, kwargs))"},{"line_number":280,"context_line":"    body \u003d {\u0027router\u0027: {\u0027name\u0027: name}}"},{"line_number":281,"context_line":"    body[\u0027router\u0027].update(kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv%2FE%3D","line":278,"in_reply_to":"AAAAM3%2F%2FxQc%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56da603837a73b45416fb3d29398b4ba692ca6db","unresolved":false,"context_lines":[{"line_number":298,"context_line":"    quantumclient(request).delete_router(router_id)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"def add_interface_router(request, router_id, subnet_id):"},{"line_number":302,"context_line":"    body \u003d {\u0027subnet_id\u0027: subnet_id}"},{"line_number":303,"context_line":"    quantumclient(request).add_interface_router(router_id, body)"},{"line_number":304,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxPs%3D","line":301,"updated":"2013-01-06 17:39:07.000000000","message":"I prefer router_add_interface(). API methods in  openstack_dashboards/api/*.py have method names of \u003ctarget\u003e_\u003caction\u003e form.\n\nPlease consider accepting  both subnet_id and port_id in add_interface_router(). In the API layer either subnet_id or port_id can be passed. port_id is used to create an router interface with a specified IP address.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":298,"context_line":"    quantumclient(request).delete_router(router_id)"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"def add_interface_router(request, router_id, subnet_id):"},{"line_number":302,"context_line":"    body \u003d {\u0027subnet_id\u0027: subnet_id}"},{"line_number":303,"context_line":"    quantumclient(request).add_interface_router(router_id, body)"},{"line_number":304,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv%2FA%3D","line":301,"in_reply_to":"AAAAM3%2F%2FxPs%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56da603837a73b45416fb3d29398b4ba692ca6db","unresolved":false,"context_lines":[{"line_number":303,"context_line":"    quantumclient(request).add_interface_router(router_id, body)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"def remove_interface_router(request, router_id, port_id):"},{"line_number":307,"context_line":"    body \u003d {\u0027port_id\u0027: port_id}"},{"line_number":308,"context_line":"    quantumclient(request).remove_interface_router(router_id, body)"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxPo%3D","line":306,"updated":"2013-01-06 17:39:07.000000000","message":"router_remove_interface is my preference as commented in the previous comment.\n\nPlease consider taking both subnet_id and port_id as arguments.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":303,"context_line":"    quantumclient(request).add_interface_router(router_id, body)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"def remove_interface_router(request, router_id, port_id):"},{"line_number":307,"context_line":"    body \u003d {\u0027port_id\u0027: port_id}"},{"line_number":308,"context_line":"    quantumclient(request).remove_interface_router(router_id, body)"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv%2B8%3D","line":306,"in_reply_to":"AAAAM3%2F%2FxPo%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56da603837a73b45416fb3d29398b4ba692ca6db","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    quantumclient(request).remove_interface_router(router_id, body)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"def add_gateway_router(request, router_id, network_id):"},{"line_number":312,"context_line":"    body \u003d {\u0027network_id\u0027: network_id}"},{"line_number":313,"context_line":"    quantumclient(request).add_gateway_router(router_id, body)"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxPk%3D","line":311,"updated":"2013-01-06 17:39:07.000000000","message":"Ditto (regarding the method name)","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    quantumclient(request).remove_interface_router(router_id, body)"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"def add_gateway_router(request, router_id, network_id):"},{"line_number":312,"context_line":"    body \u003d {\u0027network_id\u0027: network_id}"},{"line_number":313,"context_line":"    quantumclient(request).add_gateway_router(router_id, body)"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv%2B4%3D","line":311,"in_reply_to":"AAAAM3%2F%2FxPk%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56da603837a73b45416fb3d29398b4ba692ca6db","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    quantumclient(request).add_gateway_router(router_id, body)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"def remove_gateway_router(request, router_id):"},{"line_number":317,"context_line":"    quantumclient(request).remove_gateway_router(router_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxPg%3D","line":316,"updated":"2013-01-06 17:39:07.000000000","message":"Ditto.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    quantumclient(request).add_gateway_router(router_id, body)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"def remove_gateway_router(request, router_id):"},{"line_number":317,"context_line":"    quantumclient(request).remove_gateway_router(router_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv%2B0%3D","line":316,"in_reply_to":"AAAAM3%2F%2FxPg%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"58c7037cced6142ca25b04a8f73b6bbe3fd88d7d","unresolved":false,"context_lines":[{"line_number":293,"context_line":"    quantumclient(request).delete_router(router_id)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"def router_add_interface(request, router_id, **kwargs):"},{"line_number":297,"context_line":"    body \u003d {}"},{"line_number":298,"context_line":"    body.update(kwargs)"},{"line_number":299,"context_line":"    quantumclient(request).add_interface_router(router_id, body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FvsY%3D","line":296,"updated":"2013-01-07 22:56:36.000000000","message":"router_add_interface() only takes subnet_id or port_id, so\nI prefer to change **kwargs to \"subnet_id\u003dNone, port_id\u003dNone\".","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0d761df86405e7284725a675564c46e9f9e890cf","unresolved":false,"context_lines":[{"line_number":293,"context_line":"    quantumclient(request).delete_router(router_id)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"def router_add_interface(request, router_id, **kwargs):"},{"line_number":297,"context_line":"    body \u003d {}"},{"line_number":298,"context_line":"    body.update(kwargs)"},{"line_number":299,"context_line":"    quantumclient(request).add_interface_router(router_id, body)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Fvlo%3D","line":296,"in_reply_to":"AAAAM3%2F%2FvsY%3D","updated":"2013-01-07 23:31:06.000000000","message":"Done","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"58c7037cced6142ca25b04a8f73b6bbe3fd88d7d","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    quantumclient(request).add_interface_router(router_id, body)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"def router_remove_interface(request, router_id, port_id):"},{"line_number":303,"context_line":"    body \u003d {\u0027port_id\u0027: port_id}"},{"line_number":304,"context_line":"    quantumclient(request).remove_interface_router(router_id, body)"},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Fvr4%3D","line":302,"updated":"2013-01-07 22:56:36.000000000","message":"Please consider changing \"port_id\" to \"subnet_id\u003dNone, port_id\u003dNone\" since router_remove_interface() can take either or both of them.","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0d761df86405e7284725a675564c46e9f9e890cf","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    quantumclient(request).add_interface_router(router_id, body)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"def router_remove_interface(request, router_id, port_id):"},{"line_number":303,"context_line":"    body \u003d {\u0027port_id\u0027: port_id}"},{"line_number":304,"context_line":"    quantumclient(request).remove_interface_router(router_id, body)"},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Fvlk%3D","line":302,"in_reply_to":"AAAAM3%2F%2Fvr4%3D","updated":"2013-01-07 23:31:06.000000000","message":"Done","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"}],"openstack_dashboard/dashboards/admin/networks/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56da603837a73b45416fb3d29398b4ba692ca6db","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                           required\u003dFalse)"},{"line_number":36,"context_line":"    tenant_id \u003d forms.ChoiceField(label\u003d_(\"Project\"))"},{"line_number":37,"context_line":"    external_network \u003d forms.BooleanField(required\u003dFalse,"},{"line_number":38,"context_line":"                                          label\u003d_(\"Is Gateway Network\"))"},{"line_number":39,"context_line":"    shared \u003d forms.BooleanField(label\u003d_(\"Shared\"),"},{"line_number":40,"context_line":"                                initial\u003dFalse, required\u003dFalse)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxQk%3D","line":38,"updated":"2013-01-06 17:39:07.000000000","message":"My patch also adds external_network support to CreateNetwork. Let\u0027s discuss which of us will add external_network support.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                           required\u003dFalse)"},{"line_number":36,"context_line":"    tenant_id \u003d forms.ChoiceField(label\u003d_(\"Project\"))"},{"line_number":37,"context_line":"    external_network \u003d forms.BooleanField(required\u003dFalse,"},{"line_number":38,"context_line":"                                          label\u003d_(\"Is Gateway Network\"))"},{"line_number":39,"context_line":"    shared \u003d forms.BooleanField(label\u003d_(\"Shared\"),"},{"line_number":40,"context_line":"                                initial\u003dFalse, required\u003dFalse)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv%2Bs%3D","line":38,"in_reply_to":"AAAAM3%2F%2FxQk%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"}],"openstack_dashboard/dashboards/admin/routers/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56da603837a73b45416fb3d29398b4ba692ca6db","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class CreateForm(forms.SelfHandlingForm):"},{"line_number":34,"context_line":"    name \u003d forms.CharField(max_length\u003d\"255\", label\u003d_(\"Router Name\"))"},{"line_number":35,"context_line":"    tenant_id \u003d forms.ChoiceField(label\u003d_(\"Project\"))"},{"line_number":36,"context_line":"    failure_url \u003d \u0027horizon:admin:routers:index\u0027"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxQg%3D","line":34,"updated":"2013-01-06 17:39:07.000000000","message":"It would be better to add required\u003dFalse since name is not a mandatory field.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class CreateForm(forms.SelfHandlingForm):"},{"line_number":34,"context_line":"    name \u003d forms.CharField(max_length\u003d\"255\", label\u003d_(\"Router Name\"))"},{"line_number":35,"context_line":"    tenant_id \u003d forms.ChoiceField(label\u003d_(\"Project\"))"},{"line_number":36,"context_line":"    failure_url \u003d \u0027horizon:admin:routers:index\u0027"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv%2BU%3D","line":34,"in_reply_to":"AAAAM3%2F%2FxQg%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"change_message_id":"eca356164b983c970e6c070649c8cd95e7cc5ca6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":39,"context_line":"        super(CreateForm, self).__init__(request, *args, **kwargs)"},{"line_number":40,"context_line":"        tenant_choices \u003d [(\u0027\u0027, _(\"Select a project\"))]"},{"line_number":41,"context_line":"        for tenant in api.keystone.tenant_list(request, admin\u003dTrue):"},{"line_number":42,"context_line":"            if tenant.enabled:"},{"line_number":43,"context_line":"                tenant_choices.append((tenant.id, tenant.name))"},{"line_number":44,"context_line":"        self.fields[\u0027tenant_id\u0027].choices \u003d tenant_choices"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxHU%3D","line":41,"updated":"2013-01-06 21:24:15.000000000","message":"The API call here should be wrapped in a try/except block with exceptions.handle.\n\nThat comment holds true for every API call (except table actions where the try/except block is in the Action class code).","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":39,"context_line":"        super(CreateForm, self).__init__(request, *args, **kwargs)"},{"line_number":40,"context_line":"        tenant_choices \u003d [(\u0027\u0027, _(\"Select a project\"))]"},{"line_number":41,"context_line":"        for tenant in api.keystone.tenant_list(request, admin\u003dTrue):"},{"line_number":42,"context_line":"            if tenant.enabled:"},{"line_number":43,"context_line":"                tenant_choices.append((tenant.id, tenant.name))"},{"line_number":44,"context_line":"        self.fields[\u0027tenant_id\u0027].choices \u003d tenant_choices"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv98%3D","line":41,"in_reply_to":"AAAAM3%2F%2FxHU%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"}],"openstack_dashboard/dashboards/admin/routers/ports/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56da603837a73b45416fb3d29398b4ba692ca6db","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import logging"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from openstack_dashboard.dashboards.project.routers.ports import forms"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxQY%3D","line":19,"updated":"2013-01-06 17:39:07.000000000","message":"\u0027forms\u0027 usually refers to horizon.forms. How about adding \u0027as project_forms\u0027 or something?","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import logging"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from openstack_dashboard.dashboards.project.routers.ports import forms"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv9o%3D","line":19,"in_reply_to":"AAAAM3%2F%2FxQY%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"}],"openstack_dashboard/dashboards/admin/routers/tabs.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56da603837a73b45416fb3d29398b4ba692ca6db","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class OverviewTab(r_tabs.OverviewTab):"},{"line_number":27,"context_line":"    template_name \u003d (\"admin/routers/\""},{"line_number":28,"context_line":"                     \"_detail_overview.html\")"},{"line_number":29,"context_line":"    redirect_url \u003d \u0027horizon:admin:routers:index\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxPI%3D","line":28,"updated":"2013-01-06 17:39:07.000000000","message":"Do we need to wrap this line?","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class OverviewTab(r_tabs.OverviewTab):"},{"line_number":27,"context_line":"    template_name \u003d (\"admin/routers/\""},{"line_number":28,"context_line":"                     \"_detail_overview.html\")"},{"line_number":29,"context_line":"    redirect_url \u003d \u0027horizon:admin:routers:index\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv9c%3D","line":28,"in_reply_to":"AAAAM3%2F%2FxPI%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"}],"openstack_dashboard/dashboards/project/networks/tables.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56da603837a73b45416fb3d29398b4ba692ca6db","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    admin_state \u003d tables.Column(\"admin_state\","},{"line_number":101,"context_line":"                                verbose_name\u003d_(\"Admin State\"))"},{"line_number":102,"context_line":"    external \u003d tables.Column(\"router:external\","},{"line_number":103,"context_line":"                             verbose_name\u003d_(\"Gateway Network\"))"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    class Meta:"},{"line_number":106,"context_line":"        name \u003d \"networks\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxQQ%3D","line":103,"updated":"2013-01-06 17:39:07.000000000","message":"In the default policy of Quantum router:external is only set by admin, so it is not needed to add router:external in project network table.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    admin_state \u003d tables.Column(\"admin_state\","},{"line_number":101,"context_line":"                                verbose_name\u003d_(\"Admin State\"))"},{"line_number":102,"context_line":"    external \u003d tables.Column(\"router:external\","},{"line_number":103,"context_line":"                             verbose_name\u003d_(\"Gateway Network\"))"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    class Meta:"},{"line_number":106,"context_line":"        name \u003d \"networks\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv9E%3D","line":103,"in_reply_to":"AAAAM3%2F%2FxQQ%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"}],"openstack_dashboard/dashboards/project/networks/workflows.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56da603837a73b45416fb3d29398b4ba692ca6db","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class CreateNetworkInfo(workflows.Step):"},{"line_number":48,"context_line":"    action_class \u003d CreateNetworkInfoAction"},{"line_number":49,"context_line":"    contributes \u003d (\"net_name\", )"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class CreateSubnetInfoAction(workflows.Action):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxQM%3D","line":49,"updated":"2013-01-06 17:39:07.000000000","message":"I think it is a unintended change.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class CreateNetworkInfo(workflows.Step):"},{"line_number":48,"context_line":"    action_class \u003d CreateNetworkInfoAction"},{"line_number":49,"context_line":"    contributes \u003d (\"net_name\", )"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class CreateSubnetInfoAction(workflows.Action):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv80%3D","line":49,"in_reply_to":"AAAAM3%2F%2FxQM%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56da603837a73b45416fb3d29398b4ba692ca6db","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    def handle(self, request, data):"},{"line_number":124,"context_line":"        # create the network"},{"line_number":125,"context_line":"        try:"},{"line_number":126,"context_line":"            kwargs \u003d {\u0027name\u0027: data[\u0027net_name\u0027]}"},{"line_number":127,"context_line":"            network \u003d api.quantum.network_create(request,"},{"line_number":128,"context_line":"                                                 name\u003ddata[\u0027net_name\u0027])"},{"line_number":129,"context_line":"            network.set_id_as_name_if_empty()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxQI%3D","line":126,"updated":"2013-01-06 17:39:07.000000000","message":"I don\u0027t think it is not needed. kwargs is not referred to anywhere.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    def handle(self, request, data):"},{"line_number":124,"context_line":"        # create the network"},{"line_number":125,"context_line":"        try:"},{"line_number":126,"context_line":"            kwargs \u003d {\u0027name\u0027: data[\u0027net_name\u0027]}"},{"line_number":127,"context_line":"            network \u003d api.quantum.network_create(request,"},{"line_number":128,"context_line":"                                                 name\u003ddata[\u0027net_name\u0027])"},{"line_number":129,"context_line":"            network.set_id_as_name_if_empty()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv8w%3D","line":126,"in_reply_to":"AAAAM3%2F%2FxQI%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"}],"openstack_dashboard/dashboards/project/routers/forms.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56da603837a73b45416fb3d29398b4ba692ca6db","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def handle(self, request, data):"},{"line_number":36,"context_line":"        try:"},{"line_number":37,"context_line":"            router \u003d api.quantum.router_create(request,"},{"line_number":38,"context_line":"                                               data[\u0027name\u0027])"},{"line_number":39,"context_line":"            message \u003d \u0027Creating router \"%s\"\u0027 % data[\u0027name\u0027]"},{"line_number":40,"context_line":"            messages.info(request, message)"},{"line_number":41,"context_line":"            return router"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxQA%3D","line":38,"updated":"2013-01-06 17:39:07.000000000","message":"As I commented in api/quantum.py, I prefer name\u003ddata[\u0027name\u0027]","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def handle(self, request, data):"},{"line_number":36,"context_line":"        try:"},{"line_number":37,"context_line":"            router \u003d api.quantum.router_create(request,"},{"line_number":38,"context_line":"                                               data[\u0027name\u0027])"},{"line_number":39,"context_line":"            message \u003d \u0027Creating router \"%s\"\u0027 % data[\u0027name\u0027]"},{"line_number":40,"context_line":"            messages.info(request, message)"},{"line_number":41,"context_line":"            return router"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv8s%3D","line":38,"in_reply_to":"AAAAM3%2F%2FxQA%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56da603837a73b45416fb3d29398b4ba692ca6db","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            router \u003d api.quantum.router_create(request,"},{"line_number":38,"context_line":"                                               data[\u0027name\u0027])"},{"line_number":39,"context_line":"            message \u003d \u0027Creating router \"%s\"\u0027 % data[\u0027name\u0027]"},{"line_number":40,"context_line":"            messages.info(request, message)"},{"line_number":41,"context_line":"            return router"},{"line_number":42,"context_line":"        except:"},{"line_number":43,"context_line":"            msg \u003d _(\u0027Failed to create router \"%s\".\u0027) % data[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxP8%3D","line":40,"updated":"2013-01-06 17:39:07.000000000","message":"message.success() is better.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            router \u003d api.quantum.router_create(request,"},{"line_number":38,"context_line":"                                               data[\u0027name\u0027])"},{"line_number":39,"context_line":"            message \u003d \u0027Creating router \"%s\"\u0027 % data[\u0027name\u0027]"},{"line_number":40,"context_line":"            messages.info(request, message)"},{"line_number":41,"context_line":"            return router"},{"line_number":42,"context_line":"        except:"},{"line_number":43,"context_line":"            msg \u003d _(\u0027Failed to create router \"%s\".\u0027) % data[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv8U%3D","line":40,"in_reply_to":"AAAAM3%2F%2FxHM%3D","updated":"2013-01-07 20:24:57.000000000","message":"This is synchronous call, so it should be success as Akihiro mentioned.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"change_message_id":"eca356164b983c970e6c070649c8cd95e7cc5ca6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            router \u003d api.quantum.router_create(request,"},{"line_number":38,"context_line":"                                               data[\u0027name\u0027])"},{"line_number":39,"context_line":"            message \u003d \u0027Creating router \"%s\"\u0027 % data[\u0027name\u0027]"},{"line_number":40,"context_line":"            messages.info(request, message)"},{"line_number":41,"context_line":"            return router"},{"line_number":42,"context_line":"        except:"},{"line_number":43,"context_line":"            msg \u003d _(\u0027Failed to create router \"%s\".\u0027) % data[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxHM%3D","line":40,"in_reply_to":"AAAAM3%2F%2FxP8%3D","updated":"2013-01-06 21:24:15.000000000","message":"Is this a synchronous or asynchronous API call? messages.info is good for async (where it hasn\u0027t actually succeeded yet) vs. messages.success for sync (where we know it actually succeeded).","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"}],"openstack_dashboard/dashboards/project/routers/ports/forms.py":[{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"9d9166dd15ba0875692cd29b2b8571c34a865af6","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            api.quantum.add_interface_router(request,"},{"line_number":56,"context_line":"                                             data[\u0027router_id\u0027],"},{"line_number":57,"context_line":"                                             data[\u0027subnet_id\u0027])"},{"line_number":58,"context_line":"            msg \u003d \u0027Interface added\u0027"},{"line_number":59,"context_line":"            LOG.debug(msg)"},{"line_number":60,"context_line":"            messages.success(request, msg)"},{"line_number":61,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fx5A%3D","line":58,"updated":"2013-01-05 07:58:13.000000000","message":"Translation missing here.","commit_id":"6a360e009f0dbf910698ad0980c725fcad943108"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"7ebd41af339af124b1259d9c5e22af4e10048d3e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            api.quantum.add_interface_router(request,"},{"line_number":56,"context_line":"                                             data[\u0027router_id\u0027],"},{"line_number":57,"context_line":"                                             data[\u0027subnet_id\u0027])"},{"line_number":58,"context_line":"            msg \u003d \u0027Interface added\u0027"},{"line_number":59,"context_line":"            LOG.debug(msg)"},{"line_number":60,"context_line":"            messages.success(request, msg)"},{"line_number":61,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fxyw%3D","line":58,"in_reply_to":"AAAAM3%2F%2Fx5A%3D","updated":"2013-01-05 16:52:36.000000000","message":"Done","commit_id":"6a360e009f0dbf910698ad0980c725fcad943108"},{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"9d9166dd15ba0875692cd29b2b8571c34a865af6","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            api.quantum.add_gateway_router(request,"},{"line_number":97,"context_line":"                                           data[\u0027router_id\u0027],"},{"line_number":98,"context_line":"                                           data[\u0027network_id\u0027])"},{"line_number":99,"context_line":"            msg \u003d \u0027Gateway interface is added\u0027"},{"line_number":100,"context_line":"            LOG.debug(msg)"},{"line_number":101,"context_line":"            messages.success(request, msg)"},{"line_number":102,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fx48%3D","line":99,"updated":"2013-01-05 07:58:13.000000000","message":"Translation.","commit_id":"6a360e009f0dbf910698ad0980c725fcad943108"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"7ebd41af339af124b1259d9c5e22af4e10048d3e","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            api.quantum.add_gateway_router(request,"},{"line_number":97,"context_line":"                                           data[\u0027router_id\u0027],"},{"line_number":98,"context_line":"                                           data[\u0027network_id\u0027])"},{"line_number":99,"context_line":"            msg \u003d \u0027Gateway interface is added\u0027"},{"line_number":100,"context_line":"            LOG.debug(msg)"},{"line_number":101,"context_line":"            messages.success(request, msg)"},{"line_number":102,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fxys%3D","line":99,"in_reply_to":"AAAAM3%2F%2Fx48%3D","updated":"2013-01-05 16:52:36.000000000","message":"Done","commit_id":"6a360e009f0dbf910698ad0980c725fcad943108"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56da603837a73b45416fb3d29398b4ba692ca6db","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    subnet_id \u003d forms.ChoiceField(label\u003d_(\"Subnet ID\"), required\u003dFalse)"},{"line_number":32,"context_line":"    router_id \u003d forms.CharField(label\u003d_(\"Router ID\"),"},{"line_number":33,"context_line":"                                widget\u003dforms.TextInput("},{"line_number":34,"context_line":"                                    attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027}))"},{"line_number":35,"context_line":"    failure_url \u003d \u0027horizon:project:routers:detail\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __init__(self, request, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxP4%3D","line":34,"updated":"2013-01-06 17:39:07.000000000","message":"Adjust the indentation level","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    subnet_id \u003d forms.ChoiceField(label\u003d_(\"Subnet ID\"), required\u003dFalse)"},{"line_number":32,"context_line":"    router_id \u003d forms.CharField(label\u003d_(\"Router ID\"),"},{"line_number":33,"context_line":"                                widget\u003dforms.TextInput("},{"line_number":34,"context_line":"                                    attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027}))"},{"line_number":35,"context_line":"    failure_url \u003d \u0027horizon:project:routers:detail\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __init__(self, request, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv8Q%3D","line":34,"in_reply_to":"AAAAM3%2F%2FxP4%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9fe6c050e0a15392c38da9621b13bd2cc06764","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def populate_subnet_id_choices(self, request):"},{"line_number":43,"context_line":"        subnets \u003d api.quantum.subnet_list(request)"},{"line_number":44,"context_line":"        choices \u003d [(subnet.id, subnet.name or subnet.id)"},{"line_number":45,"context_line":"                   for subnet in subnets]"},{"line_number":46,"context_line":"        if choices:"},{"line_number":47,"context_line":"            choices.insert(0, (\"\", _(\"Select Subnet\")))"},{"line_number":48,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fxik%3D","line":45,"updated":"2013-01-06 02:03:30.000000000","message":"It is difficult to select an appropriate subnet from subnet ID list.\nHow about \"\u003cnetwork_name\u003e: \u003cCIDR\u003e (\u003csubnet_name_or_id\u003e)\"?\nThe following code generates this format of choices.\n\nIn addition, we need to narrow subnets or networks by tenant_id since when admin user is using project panel all subnets or networks are listed.\n\n       tenant_id \u003d self.request.user.tenant_id\n       networks \u003d api.quantum.network_list_for_tenant(request, tenant_id)\n       choices \u003d []\n       for n in networks:\n           net_name \u003d n.name + \u0027: \u0027 if n.name else \u0027\u0027\n           choices +\u003d [(subnet.id,\n                        \u0027%s%s (%s)\u0027 % (net_name, subnet.cidr,\n                                       subnet.name or subnet.id))\n                       for subnet in n[\u0027subnets\u0027]]","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def populate_subnet_id_choices(self, request):"},{"line_number":43,"context_line":"        subnets \u003d api.quantum.subnet_list(request)"},{"line_number":44,"context_line":"        choices \u003d [(subnet.id, subnet.name or subnet.id)"},{"line_number":45,"context_line":"                   for subnet in subnets]"},{"line_number":46,"context_line":"        if choices:"},{"line_number":47,"context_line":"            choices.insert(0, (\"\", _(\"Select Subnet\")))"},{"line_number":48,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv7I%3D","line":45,"in_reply_to":"AAAAM3%2F%2Fxik%3D","updated":"2013-01-07 20:24:57.000000000","message":"Thanks for your code.\nUpdated here","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"change_message_id":"eca356164b983c970e6c070649c8cd95e7cc5ca6","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def handle(self, request, data):"},{"line_number":53,"context_line":"        try:"},{"line_number":54,"context_line":"            LOG.debug(\u0027params \u003d %s\u0027 % data)"},{"line_number":55,"context_line":"            api.quantum.add_interface_router(request,"},{"line_number":56,"context_line":"                                             data[\u0027router_id\u0027],"},{"line_number":57,"context_line":"                                             data[\u0027subnet_id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxHI%3D","line":54,"updated":"2013-01-06 21:24:15.000000000","message":"I don\u0027t object to debug logging being left in, but these log messages won\u0027t have any context. They should either be removed or rewritten so that someone who\u0027s just reading through log files will understand what they mean.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def handle(self, request, data):"},{"line_number":53,"context_line":"        try:"},{"line_number":54,"context_line":"            LOG.debug(\u0027params \u003d %s\u0027 % data)"},{"line_number":55,"context_line":"            api.quantum.add_interface_router(request,"},{"line_number":56,"context_line":"                                             data[\u0027router_id\u0027],"},{"line_number":57,"context_line":"                                             data[\u0027subnet_id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv7E%3D","line":54,"in_reply_to":"AAAAM3%2F%2FxHI%3D","updated":"2013-01-07 20:24:57.000000000","message":"My bad. i just remove it","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56da603837a73b45416fb3d29398b4ba692ca6db","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class SetGatewayForm(forms.SelfHandlingForm):"},{"line_number":71,"context_line":"    network_id \u003d forms.ChoiceField(label\u003d_(\"Network ID\"), required\u003dFalse)"},{"line_number":72,"context_line":"    router_id \u003d forms.CharField(label\u003d_(\"Router ID\"),"},{"line_number":73,"context_line":"                                widget\u003dforms.TextInput("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxPw%3D","line":70,"updated":"2013-01-06 17:39:07.000000000","message":"It is a difficult issue where we should support router-gateway-set in the Project View or not since only admin users are allowed to sett router:external for the network.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            exceptions.handle(request, msg, redirect\u003dredirect)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class SetGatewayForm(forms.SelfHandlingForm):"},{"line_number":71,"context_line":"    network_id \u003d forms.ChoiceField(label\u003d_(\"Network ID\"), required\u003dFalse)"},{"line_number":72,"context_line":"    router_id \u003d forms.CharField(label\u003d_(\"Router ID\"),"},{"line_number":73,"context_line":"                                widget\u003dforms.TextInput("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv7A%3D","line":70,"in_reply_to":"AAAAM3%2F%2FxPw%3D","updated":"2013-01-07 20:24:57.000000000","message":"discussed in comment.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56da603837a73b45416fb3d29398b4ba692ca6db","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    network_id \u003d forms.ChoiceField(label\u003d_(\"Network ID\"), required\u003dFalse)"},{"line_number":72,"context_line":"    router_id \u003d forms.CharField(label\u003d_(\"Router ID\"),"},{"line_number":73,"context_line":"                                widget\u003dforms.TextInput("},{"line_number":74,"context_line":"                                    attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027}))"},{"line_number":75,"context_line":"    failure_url \u003d \u0027horizon:project:routers:detail\u0027"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def __init__(self, request, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxP0%3D","line":74,"updated":"2013-01-06 17:39:07.000000000","message":"Need to adjust the indentation level.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    network_id \u003d forms.ChoiceField(label\u003d_(\"Network ID\"), required\u003dFalse)"},{"line_number":72,"context_line":"    router_id \u003d forms.CharField(label\u003d_(\"Router ID\"),"},{"line_number":73,"context_line":"                                widget\u003dforms.TextInput("},{"line_number":74,"context_line":"                                    attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027}))"},{"line_number":75,"context_line":"    failure_url \u003d \u0027horizon:project:routers:detail\u0027"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def __init__(self, request, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv68%3D","line":74,"in_reply_to":"AAAAM3%2F%2FxP0%3D","updated":"2013-01-07 20:24:57.000000000","message":"wired. indent is collect in my editor and pep8 didn\u0027t angry.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"}],"openstack_dashboard/dashboards/project/routers/ports/tables.py":[{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"9d9166dd15ba0875692cd29b2b8571c34a865af6","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    if port[\u0027device_owner\u0027] \u003d\u003d \u0027network:router_gateway\u0027:"},{"line_number":36,"context_line":"        return _(\u0027Gateway\u0027)"},{"line_number":37,"context_line":"    else:"},{"line_number":38,"context_line":"        return _(\u0027 \u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class SetGateway(tables.LinkAction):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fx44%3D","line":38,"updated":"2013-01-05 07:58:13.000000000","message":"Does space need translation?","commit_id":"6a360e009f0dbf910698ad0980c725fcad943108"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"7ebd41af339af124b1259d9c5e22af4e10048d3e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    if port[\u0027device_owner\u0027] \u003d\u003d \u0027network:router_gateway\u0027:"},{"line_number":36,"context_line":"        return _(\u0027Gateway\u0027)"},{"line_number":37,"context_line":"    else:"},{"line_number":38,"context_line":"        return _(\u0027 \u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class SetGateway(tables.LinkAction):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Fxyo%3D","line":38,"in_reply_to":"AAAAM3%2F%2Fx44%3D","updated":"2013-01-05 16:52:36.000000000","message":"Done","commit_id":"6a360e009f0dbf910698ad0980c725fcad943108"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"58c7037cced6142ca25b04a8f73b6bbe3fd88d7d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            if port[\u0027device_owner\u0027] \u003d\u003d \u0027network:router_gateway\u0027:"},{"line_number":70,"context_line":"                api.quantum.router_remove_gateway(request, router_id)"},{"line_number":71,"context_line":"            else:"},{"line_number":72,"context_line":"                api.quantum.router_remove_interface(request, router_id, obj_id)"},{"line_number":73,"context_line":"        except:"},{"line_number":74,"context_line":"            msg \u003d _(\u0027Failed to delete interface %s\u0027) % obj_id"},{"line_number":75,"context_line":"            LOG.info(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FvqE%3D","line":72,"updated":"2013-01-07 22:56:36.000000000","message":"According to my comment on api/quantum.py, you need to change obj_id to port_id\u003dobj_id.","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0d761df86405e7284725a675564c46e9f9e890cf","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            if port[\u0027device_owner\u0027] \u003d\u003d \u0027network:router_gateway\u0027:"},{"line_number":70,"context_line":"                api.quantum.router_remove_gateway(request, router_id)"},{"line_number":71,"context_line":"            else:"},{"line_number":72,"context_line":"                api.quantum.router_remove_interface(request, router_id, obj_id)"},{"line_number":73,"context_line":"        except:"},{"line_number":74,"context_line":"            msg \u003d _(\u0027Failed to delete interface %s\u0027) % obj_id"},{"line_number":75,"context_line":"            LOG.info(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Fvl4%3D","line":72,"in_reply_to":"AAAAM3%2F%2FvqE%3D","updated":"2013-01-07 23:31:06.000000000","message":"Done","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"}],"openstack_dashboard/dashboards/project/routers/ports/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9fe6c050e0a15392c38da9621b13bd2cc06764","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class AddInterfaceView(forms.ModalFormView):"},{"line_number":33,"context_line":"    form_class \u003d AddInterface"},{"line_number":34,"context_line":"    template_name \u003d \u0027project/routers/ports/create.html\u0027"},{"line_number":35,"context_line":"    success_url \u003d \u0027horizon:project:routers:detail\u0027"},{"line_number":36,"context_line":"    failure_url \u003d \u0027horizon:project:routers:detail\u0027"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxjA%3D","line":34,"updated":"2013-01-06 02:03:30.000000000","message":"The template project/routers/ports/create.html seems not to exist.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class AddInterfaceView(forms.ModalFormView):"},{"line_number":33,"context_line":"    form_class \u003d AddInterface"},{"line_number":34,"context_line":"    template_name \u003d \u0027project/routers/ports/create.html\u0027"},{"line_number":35,"context_line":"    success_url \u003d \u0027horizon:project:routers:detail\u0027"},{"line_number":36,"context_line":"    failure_url \u003d \u0027horizon:project:routers:detail\u0027"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fvzc%3D","line":34,"in_reply_to":"AAAAM3%2F%2FxjA%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9fe6c050e0a15392c38da9621b13bd2cc06764","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"class SetGatewayView(forms.ModalFormView):"},{"line_number":66,"context_line":"    form_class \u003d SetGatewayForm"},{"line_number":67,"context_line":"    template_name \u003d \u0027project/routers/ports/setgateway.html\u0027"},{"line_number":68,"context_line":"    success_url \u003d \u0027horizon:project:routers:detail\u0027"},{"line_number":69,"context_line":"    failure_url \u003d \u0027horizon:project:routers:detail\u0027"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fxi8%3D","line":67,"updated":"2013-01-06 02:03:30.000000000","message":"Same as the above.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"class SetGatewayView(forms.ModalFormView):"},{"line_number":66,"context_line":"    form_class \u003d SetGatewayForm"},{"line_number":67,"context_line":"    template_name \u003d \u0027project/routers/ports/setgateway.html\u0027"},{"line_number":68,"context_line":"    success_url \u003d \u0027horizon:project:routers:detail\u0027"},{"line_number":69,"context_line":"    failure_url \u003d \u0027horizon:project:routers:detail\u0027"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FvzY%3D","line":67,"in_reply_to":"AAAAM3%2F%2Fxi8%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"}],"openstack_dashboard/dashboards/project/routers/tabs.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"56da603837a73b45416fb3d29398b4ba692ca6db","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    name \u003d _(\"Overview\")"},{"line_number":27,"context_line":"    slug \u003d \"overview\""},{"line_number":28,"context_line":"    template_name \u003d (\"project/routers/\""},{"line_number":29,"context_line":"                     \"_detail_overview.html\")"},{"line_number":30,"context_line":"    redirect_url \u003d \u0027horizon:project:routers:index\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_context_data(self, request):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2FxPc%3D","line":29,"updated":"2013-01-06 17:39:07.000000000","message":"Do we need to wrap a line?","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    name \u003d _(\"Overview\")"},{"line_number":27,"context_line":"    slug \u003d \"overview\""},{"line_number":28,"context_line":"    template_name \u003d (\"project/routers/\""},{"line_number":29,"context_line":"                     \"_detail_overview.html\")"},{"line_number":30,"context_line":"    redirect_url \u003d \u0027horizon:project:routers:index\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_context_data(self, request):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv6k%3D","line":29,"in_reply_to":"AAAAM3%2F%2FxPc%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"}],"openstack_dashboard/dashboards/project/routers/templates/routers/_detail_overview.html":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9fe6c050e0a15392c38da9621b13bd2cc06764","unresolved":false,"context_lines":[{"line_number":5,"context_line":"\u003cdiv class\u003d\"info detail\"\u003e"},{"line_number":6,"context_line":"  \u003cdl\u003e"},{"line_number":7,"context_line":"    \u003cdt\u003e{% trans \"Name\" %}\u003c/dt\u003e"},{"line_number":8,"context_line":"    \u003cdd\u003e{{ router.display_name }}\u003c/dd\u003e"},{"line_number":9,"context_line":"    \u003cdt\u003e{% trans \"ID\" %}\u003c/dt\u003e"},{"line_number":10,"context_line":"    \u003cdd\u003e{{ router.id }}\u003c/dd\u003e"},{"line_number":11,"context_line":"    \u003cdt\u003e{% trans \"Status\" %}\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":4,"id":"AAAAM3%2F%2FxjQ%3D","line":8,"updated":"2013-01-06 02:03:30.000000000","message":"router.display -\u003e router.name?\n\n\u0027router.name|default:\"None\"\u0027 is better.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9fe6c050e0a15392c38da9621b13bd2cc06764","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \u003cdt\u003e{% trans \"Name\" %}\u003c/dt\u003e"},{"line_number":8,"context_line":"    \u003cdd\u003e{{ router.display_name }}\u003c/dd\u003e"},{"line_number":9,"context_line":"    \u003cdt\u003e{% trans \"ID\" %}\u003c/dt\u003e"},{"line_number":10,"context_line":"    \u003cdd\u003e{{ router.id }}\u003c/dd\u003e"},{"line_number":11,"context_line":"    \u003cdt\u003e{% trans \"Status\" %}\u003c/dt\u003e"},{"line_number":12,"context_line":"    \u003cdd\u003e{{ router.status|capfirst }}\u003c/dd\u003e"},{"line_number":13,"context_line":"  \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":4,"id":"AAAAM3%2F%2FxjI%3D","line":10,"updated":"2013-01-06 02:03:30.000000000","message":"router.id|default:\"None\"\n\nIt is just for consistency with other templates.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \u003cdt\u003e{% trans \"Name\" %}\u003c/dt\u003e"},{"line_number":8,"context_line":"    \u003cdd\u003e{{ router.display_name }}\u003c/dd\u003e"},{"line_number":9,"context_line":"    \u003cdt\u003e{% trans \"ID\" %}\u003c/dt\u003e"},{"line_number":10,"context_line":"    \u003cdd\u003e{{ router.id }}\u003c/dd\u003e"},{"line_number":11,"context_line":"    \u003cdt\u003e{% trans \"Status\" %}\u003c/dt\u003e"},{"line_number":12,"context_line":"    \u003cdd\u003e{{ router.status|capfirst }}\u003c/dd\u003e"},{"line_number":13,"context_line":"  \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":4,"id":"AAAAM3%2F%2Fv6g%3D","line":10,"in_reply_to":"AAAAM3%2F%2FxjI%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9fe6c050e0a15392c38da9621b13bd2cc06764","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    \u003cdt\u003e{% trans \"ID\" %}\u003c/dt\u003e"},{"line_number":10,"context_line":"    \u003cdd\u003e{{ router.id }}\u003c/dd\u003e"},{"line_number":11,"context_line":"    \u003cdt\u003e{% trans \"Status\" %}\u003c/dt\u003e"},{"line_number":12,"context_line":"    \u003cdd\u003e{{ router.status|capfirst }}\u003c/dd\u003e"},{"line_number":13,"context_line":"  \u003c/dl\u003e"},{"line_number":14,"context_line":"\u003c/div\u003e"},{"line_number":15,"context_line":""}],"source_content_type":"text/html","patch_set":4,"id":"AAAAM3%2F%2FxjM%3D","line":12,"updated":"2013-01-06 02:03:30.000000000","message":"capfirst is required?\n\nI prefer to adding |default:\"Unknown\".","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    \u003cdt\u003e{% trans \"ID\" %}\u003c/dt\u003e"},{"line_number":10,"context_line":"    \u003cdd\u003e{{ router.id }}\u003c/dd\u003e"},{"line_number":11,"context_line":"    \u003cdt\u003e{% trans \"Status\" %}\u003c/dt\u003e"},{"line_number":12,"context_line":"    \u003cdd\u003e{{ router.status|capfirst }}\u003c/dd\u003e"},{"line_number":13,"context_line":"  \u003c/dl\u003e"},{"line_number":14,"context_line":"\u003c/div\u003e"},{"line_number":15,"context_line":""}],"source_content_type":"text/html","patch_set":4,"id":"AAAAM3%2F%2Fv6c%3D","line":12,"in_reply_to":"AAAAM3%2F%2FxjM%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"58c7037cced6142ca25b04a8f73b6bbe3fd88d7d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% load i18n sizeformat parse_date %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\u003ch3\u003e{% trans \"Router Overview\" %}: {{router.display_name }}\u003c/h3\u003e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"\u003cdiv class\u003d\"info detail\"\u003e"},{"line_number":6,"context_line":"  \u003cdl\u003e"}],"source_content_type":"text/html","patch_set":5,"id":"AAAAM3%2F%2Fvqc%3D","line":3,"updated":"2013-01-07 22:56:36.000000000","message":"router.display_name -\u003e router.name?","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0d761df86405e7284725a675564c46e9f9e890cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% load i18n sizeformat parse_date %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"\u003ch3\u003e{% trans \"Router Overview\" %}: {{router.display_name }}\u003c/h3\u003e"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"\u003cdiv class\u003d\"info detail\"\u003e"},{"line_number":6,"context_line":"  \u003cdl\u003e"}],"source_content_type":"text/html","patch_set":5,"id":"AAAAM3%2F%2FvlY%3D","line":3,"in_reply_to":"AAAAM3%2F%2Fvqc%3D","updated":"2013-01-07 23:31:06.000000000","message":"Done","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"}],"openstack_dashboard/dashboards/project/routers/templates/routers/ports/_setgateway.html":[{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"9d9166dd15ba0875692cd29b2b8571c34a865af6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003c/div\u003e"},{"line_number":16,"context_line":"\u003cdiv class\u003d\"right\"\u003e"},{"line_number":17,"context_line":"    \u003ch3\u003e{% trans \"Description\" %}:\u003c/h3\u003e"},{"line_number":18,"context_line":"    \u003cp\u003e{% trans \"You can add inteface for Gateway. In this interface, NAT rule of floating ip will be set.\" %}\u003c/p\u003e"},{"line_number":19,"context_line":"\u003c/div\u003e"},{"line_number":20,"context_line":"{% endblock %}"},{"line_number":21,"context_line":""}],"source_content_type":"text/html","patch_set":3,"id":"AAAAM3%2F%2Fx4s%3D","line":18,"updated":"2013-01-05 07:58:13.000000000","message":"Maybe \"ip\" should be \"IP\" ?","commit_id":"6a360e009f0dbf910698ad0980c725fcad943108"}],"openstack_dashboard/dashboards/project/routers/templates/routers/ports/create.html":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"58c7037cced6142ca25b04a8f73b6bbe3fd88d7d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Setup Gateway\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Setup Gateway\") %}"}],"source_content_type":"text/html","patch_set":5,"id":"AAAAM3%2F%2Fvqg%3D","line":3,"updated":"2013-01-07 22:56:36.000000000","message":"\"Add Interface\"?\n\nPerhaps the file names should be swapped.","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0d761df86405e7284725a675564c46e9f9e890cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Setup Gateway\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Setup Gateway\") %}"}],"source_content_type":"text/html","patch_set":5,"id":"AAAAM3%2F%2FvlU%3D","line":3,"in_reply_to":"AAAAM3%2F%2Fvqg%3D","updated":"2013-01-07 23:31:06.000000000","message":"Done","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"809537d42b6e65d8db41441f1ba60f05d06be4cf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"},{"line_number":10,"context_line":"  {% include \"project/routers/ports/_setgateway.html\" %}"},{"line_number":11,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":7,"id":"AAAAM3%2F%2FvUA%3D","line":10,"updated":"2013-01-08 03:41:50.000000000","message":"_create.html","commit_id":"49999247d965a6d694a98b36910946245aadf0ca"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"2414762f3c429195fd000b7e948d6093f49f67f9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"},{"line_number":10,"context_line":"  {% include \"project/routers/ports/_setgateway.html\" %}"},{"line_number":11,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":7,"id":"AAAAM3%2F%2FvTY%3D","line":10,"in_reply_to":"AAAAM3%2F%2FvUA%3D","updated":"2013-01-08 03:49:15.000000000","message":"Done","commit_id":"49999247d965a6d694a98b36910946245aadf0ca"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"bcd4d866e5ab4ce2004840706f606c24376cceef","unresolved":false,"context_lines":[{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"},{"line_number":10,"context_line":"  {% include \"project/routers/ports/create.html\" %}"},{"line_number":11,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":9,"id":"AAAAM3%2F%2FvSY%3D","line":10,"updated":"2013-01-08 04:16:10.000000000","message":"_create.html","commit_id":"6ff367a627bdf6f658a141a6ad19a23ec5ad7ca6"}],"openstack_dashboard/dashboards/project/routers/templates/routers/ports/setgateway.html":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"58c7037cced6142ca25b04a8f73b6bbe3fd88d7d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Add Interface\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Add Interface\") %}"}],"source_content_type":"text/html","patch_set":5,"id":"AAAAM3%2F%2Fvqo%3D","line":3,"updated":"2013-01-07 22:56:36.000000000","message":"\"Set Gateway\"?","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0d761df86405e7284725a675564c46e9f9e890cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Add Interface\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Add Interface\") %}"}],"source_content_type":"text/html","patch_set":5,"id":"AAAAM3%2F%2FvlQ%3D","line":3,"in_reply_to":"AAAAM3%2F%2Fvqo%3D","updated":"2013-01-07 23:31:06.000000000","message":"Done","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"58c7037cced6142ca25b04a8f73b6bbe3fd88d7d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Add Interface\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Add Interface\") %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":5,"id":"AAAAM3%2F%2Fvqk%3D","line":6,"updated":"2013-01-07 22:56:36.000000000","message":"Ditto","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0d761df86405e7284725a675564c46e9f9e890cf","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Add Interface\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Add Interface\") %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":5,"id":"AAAAM3%2F%2FvlM%3D","line":6,"in_reply_to":"AAAAM3%2F%2Fvqk%3D","updated":"2013-01-07 23:31:06.000000000","message":"Done","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"809537d42b6e65d8db41441f1ba60f05d06be4cf","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Set Gateway\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Add Interface\") %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":7,"id":"AAAAM3%2F%2FvUI%3D","line":6,"updated":"2013-01-08 03:41:50.000000000","message":"\"Set Gateway\"","commit_id":"49999247d965a6d694a98b36910946245aadf0ca"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"2414762f3c429195fd000b7e948d6093f49f67f9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Set Gateway\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Add Interface\") %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":7,"id":"AAAAM3%2F%2FvTk%3D","line":6,"in_reply_to":"AAAAM3%2F%2FvUI%3D","updated":"2013-01-08 03:49:15.000000000","message":"Done","commit_id":"49999247d965a6d694a98b36910946245aadf0ca"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"809537d42b6e65d8db41441f1ba60f05d06be4cf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"},{"line_number":10,"context_line":"  {% include \"project/routers/ports/_create.html\" %}"},{"line_number":11,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":7,"id":"AAAAM3%2F%2FvUE%3D","line":10,"updated":"2013-01-08 03:41:50.000000000","message":"_setgateway.html","commit_id":"49999247d965a6d694a98b36910946245aadf0ca"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"2414762f3c429195fd000b7e948d6093f49f67f9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"},{"line_number":10,"context_line":"  {% include \"project/routers/ports/_create.html\" %}"},{"line_number":11,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":7,"id":"AAAAM3%2F%2FvTg%3D","line":10,"in_reply_to":"AAAAM3%2F%2FvUE%3D","updated":"2013-01-08 03:49:15.000000000","message":"Done","commit_id":"49999247d965a6d694a98b36910946245aadf0ca"}],"openstack_dashboard/test/api_tests/quantum_tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"58c7037cced6142ca25b04a8f73b6bbe3fd88d7d","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        self.mox.ReplayAll()"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        api.quantum.router_remove_interface("},{"line_number":272,"context_line":"            self.request, router_id, fake_port)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Fvqs%3D","line":272,"updated":"2013-01-07 22:56:36.000000000","message":"fake_port -\u003e port_id\u003dfake_port if you changes the arguments.","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0d761df86405e7284725a675564c46e9f9e890cf","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        self.mox.ReplayAll()"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"        api.quantum.router_remove_interface("},{"line_number":272,"context_line":"            self.request, router_id, fake_port)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FvlI%3D","line":272,"in_reply_to":"AAAAM3%2F%2Fvqs%3D","updated":"2013-01-07 23:31:06.000000000","message":"Done","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"}],"openstack_dashboard/test/test_data/quantum_data.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9fe6c050e0a15392c38da9621b13bd2cc06764","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                   \u0027tenant_id\u0027: network_dict[\u0027tenant_id\u0027]}"},{"line_number":54,"context_line":"    port_dict \u003d {\u0027admin_state_up\u0027: True,"},{"line_number":55,"context_line":"                 \u0027device_id\u0027: \u0027af75c8e5-a1cc-4567-8d04-44fcd6922890\u0027,"},{"line_number":56,"context_line":"                 \u0027device_owner\u0027: \u0027network:router_gateway\u0027,"},{"line_number":57,"context_line":"                 \u0027fixed_ips\u0027: [{\u0027ip_address\u0027: \u002710.0.0.3\u0027,"},{"line_number":58,"context_line":"                                \u0027subnet_id\u0027: subnet_dict[\u0027id\u0027]}],"},{"line_number":59,"context_line":"                 \u0027id\u0027: \u00273ec7f3db-cb2f-4a34-ab6b-69a64d3f008c\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fxj8%3D","line":56,"updated":"2013-01-06 02:03:30.000000000","message":"I prefer to creating other ports for router interfaces and gateways rather than using existing ports.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                   \u0027tenant_id\u0027: network_dict[\u0027tenant_id\u0027]}"},{"line_number":54,"context_line":"    port_dict \u003d {\u0027admin_state_up\u0027: True,"},{"line_number":55,"context_line":"                 \u0027device_id\u0027: \u0027af75c8e5-a1cc-4567-8d04-44fcd6922890\u0027,"},{"line_number":56,"context_line":"                 \u0027device_owner\u0027: \u0027network:router_gateway\u0027,"},{"line_number":57,"context_line":"                 \u0027fixed_ips\u0027: [{\u0027ip_address\u0027: \u002710.0.0.3\u0027,"},{"line_number":58,"context_line":"                                \u0027subnet_id\u0027: subnet_dict[\u0027id\u0027]}],"},{"line_number":59,"context_line":"                 \u0027id\u0027: \u00273ec7f3db-cb2f-4a34-ab6b-69a64d3f008c\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv6U%3D","line":56,"in_reply_to":"AAAAM3%2F%2Fxj8%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b9fe6c050e0a15392c38da9621b13bd2cc06764","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                 \u0027tenant_id\u0027: network_dict[\u0027tenant_id\u0027]}"},{"line_number":65,"context_line":"    router_dict \u003d {\u0027id\u0027: \u0027279989f7-54bb-41d9-ba42-0d61f12fda61\u0027,"},{"line_number":66,"context_line":"                   \u0027name\u0027: \u0027router1\u0027,"},{"line_number":67,"context_line":"                   \u0027tenant_id\u0027: network_dict[\u0027tenant_id\u0027]}"},{"line_number":68,"context_line":"    TEST.api_networks.add(network_dict)"},{"line_number":69,"context_line":"    TEST.api_subnets.add(subnet_dict)"},{"line_number":70,"context_line":"    TEST.api_ports.add(port_dict)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fxj0%3D","line":67,"updated":"2013-01-06 02:03:30.000000000","message":"router data is not directly related with other resources (networks, subnets and ports), so I prefer to moving router related part to the end of the file.","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"17e49c35a5acd873e72f75b3675d134a50554e6c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                 \u0027tenant_id\u0027: network_dict[\u0027tenant_id\u0027]}"},{"line_number":65,"context_line":"    router_dict \u003d {\u0027id\u0027: \u0027279989f7-54bb-41d9-ba42-0d61f12fda61\u0027,"},{"line_number":66,"context_line":"                   \u0027name\u0027: \u0027router1\u0027,"},{"line_number":67,"context_line":"                   \u0027tenant_id\u0027: network_dict[\u0027tenant_id\u0027]}"},{"line_number":68,"context_line":"    TEST.api_networks.add(network_dict)"},{"line_number":69,"context_line":"    TEST.api_subnets.add(subnet_dict)"},{"line_number":70,"context_line":"    TEST.api_ports.add(port_dict)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2Fv6Q%3D","line":67,"in_reply_to":"AAAAM3%2F%2Fxj0%3D","updated":"2013-01-07 20:24:57.000000000","message":"Done","commit_id":"5732676ab0661d9ed7e54d889acf17073dd1a172"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"58c7037cced6142ca25b04a8f73b6bbe3fd88d7d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                    \u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":40,"context_line":"                    \u0027subnets\u0027: [\u0027e8abc972-eb0c-41f1-9edd-4bc6e3bcd8c9\u0027],"},{"line_number":41,"context_line":"                    \u0027tenant_id\u0027: \u00271\u0027,"},{"line_number":42,"context_line":"                    \u0027router:external\u0027: True,"},{"line_number":43,"context_line":"                    \u0027shared\u0027: False}"},{"line_number":44,"context_line":"    subnet_dict \u003d {\u0027allocation_pools\u0027: [{\u0027end\u0027: \u002710.0.0.254\u0027,"},{"line_number":45,"context_line":"                                         \u0027start\u0027: \u002710.0.0.2\u0027}],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Fvn4%3D","line":42,"updated":"2013-01-07 22:56:36.000000000","message":"Could you remove it? It conflicts with my patch.\n\nI understand it needs to run unit tests. Please consider your patch depends on my patch. This file is the only conflict when I merge your patch on top of my patch.","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0d761df86405e7284725a675564c46e9f9e890cf","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                    \u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":40,"context_line":"                    \u0027subnets\u0027: [\u0027e8abc972-eb0c-41f1-9edd-4bc6e3bcd8c9\u0027],"},{"line_number":41,"context_line":"                    \u0027tenant_id\u0027: \u00271\u0027,"},{"line_number":42,"context_line":"                    \u0027router:external\u0027: True,"},{"line_number":43,"context_line":"                    \u0027shared\u0027: False}"},{"line_number":44,"context_line":"    subnet_dict \u003d {\u0027allocation_pools\u0027: [{\u0027end\u0027: \u002710.0.0.254\u0027,"},{"line_number":45,"context_line":"                                         \u0027start\u0027: \u002710.0.0.2\u0027}],"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FvlE%3D","line":42,"in_reply_to":"AAAAM3%2F%2Fvn4%3D","updated":"2013-01-07 23:31:06.000000000","message":"Ok let\u0027s set dependency here","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"58c7037cced6142ca25b04a8f73b6bbe3fd88d7d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                   \u0027tenant_id\u0027: network_dict[\u0027tenant_id\u0027]}"},{"line_number":54,"context_line":"    port_dict \u003d {\u0027admin_state_up\u0027: True,"},{"line_number":55,"context_line":"                 \u0027device_id\u0027: \u0027af75c8e5-a1cc-4567-8d04-44fcd6922890\u0027,"},{"line_number":56,"context_line":"                 \u0027device_owner\u0027: \u0027compute:nova\u0027,"},{"line_number":57,"context_line":"                 \u0027fixed_ips\u0027: [{\u0027ip_address\u0027: \u002710.0.0.3\u0027,"},{"line_number":58,"context_line":"                                \u0027subnet_id\u0027: subnet_dict[\u0027id\u0027]}],"},{"line_number":59,"context_line":"                 \u0027id\u0027: \u00273ec7f3db-cb2f-4a34-ab6b-69a64d3f008c\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2Fvnc%3D","line":56,"updated":"2013-01-07 22:56:36.000000000","message":"Same as the above.\n\nYou can choose set the value of device_owner as you want. My patch does not expect any specific value.","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"58c7037cced6142ca25b04a8f73b6bbe3fd88d7d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                   \u0027tenant_id\u0027: network_dict[\u0027tenant_id\u0027]}"},{"line_number":94,"context_line":"    port_dict \u003d {\u0027admin_state_up\u0027: True,"},{"line_number":95,"context_line":"                 \u0027device_id\u0027: \u002740e536b1-b9fd-4eb7-82d6-84db5d65a2ac\u0027,"},{"line_number":96,"context_line":"                 \u0027device_owner\u0027: \u0027network:router\u0027,"},{"line_number":97,"context_line":"                 \u0027fixed_ips\u0027: [{\u0027ip_address\u0027: \u0027172.16.88.3\u0027,"},{"line_number":98,"context_line":"                                \u0027subnet_id\u0027: subnet_dict[\u0027id\u0027]}],"},{"line_number":99,"context_line":"                 \u0027id\u0027: \u00277e6ce62c-7ea2-44f8-b6b4-769af90a8406\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2FvnY%3D","line":96,"updated":"2013-01-07 22:56:36.000000000","message":"Ditto.","commit_id":"eef042cebbfc5176bdac404127a49fba30bdea7a"}]}
