)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"bc7a9a58808e846f8c96b0d96eb9eef1069bfc41","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adding Angular Identity Dashboard"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch creates a blank Identity dashboard."},{"line_number":10,"context_line":"Later on, we will populate this dashboard with Users Panel."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I909a7b8781934e68c29b5058f89a2cc03a88103d"},{"line_number":13,"context_line":"Partially-Implements: blueprint angularize-identity-tables"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa32b979_b7c5378f","line":10,"updated":"2015-06-15 22:33:47.000000000","message":"This commit message took me a minute to figure out what was meant. This patch doesn\u0027t create a blank identity dashboard. Rather it starts adding the base javascript files needed to angularize the identity panel to the existing dashboard.  What is the bigger picture plan here?  Will we be to optionally enable the new angular identity panels as a feature toggle?","commit_id":"fb55c271ebf4a63d4bb5e1da74239379cc6bec06"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"b17a34f3be609abccdaa101861ee917ea021e28d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adding Angular Identity Dashboard"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch creates a blank Identity dashboard."},{"line_number":10,"context_line":"Later on, we will populate this dashboard with Users Panel."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I909a7b8781934e68c29b5058f89a2cc03a88103d"},{"line_number":13,"context_line":"Partially-Implements: blueprint angularize-identity-tables"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa32b979_7a823696","line":10,"in_reply_to":"fa32b979_b7c5378f","updated":"2015-06-15 23:17:54.000000000","message":"so basically, this patch will put the code into the repo but will not be initially accessible. the feature toggle will be a subsequent patch will that follows and will then allow users to enable via settings.","commit_id":"fb55c271ebf4a63d4bb5e1da74239379cc6bec06"}],"openstack_dashboard/enabled/_25_identity.py":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"293b2227e14131830b9966fb0d2f8988611da2d4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# The slug of the dashboard to be added to HORIZON[\u0027dashboards\u0027]. Required."},{"line_number":2,"context_line":"DASHBOARD \u003d \u0027identity\u0027"},{"line_number":3,"context_line":"# If set to True, this dashboard will be set as the default dashboard."},{"line_number":4,"context_line":"DEFAULT \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af86dd1_7cc119e4","line":1,"updated":"2015-06-12 18:13:36.000000000","message":"need license header.","commit_id":"125a69b9bcb35b23425f1fec69f1b51e72d9cd40"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"293b2227e14131830b9966fb0d2f8988611da2d4","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"ADD_JS_SPEC_FILES \u003d ["},{"line_number":17,"context_line":"    \u0027dashboard/identity/identity.module.spec.js\u0027"},{"line_number":18,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af86dd1_9c63b51a","line":18,"updated":"2015-06-12 18:13:36.000000000","message":"need new line","commit_id":"125a69b9bcb35b23425f1fec69f1b51e72d9cd40"},{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"34272e603658c7a95f428f781edba353f902fd49","unresolved":false,"context_lines":[{"line_number":20,"context_line":"ADD_INSTALLED_APPS \u003d [\u0027openstack_dashboard.dashboards.identity\u0027]"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"ADD_ANGULAR_MODULES \u003d ["},{"line_number":23,"context_line":"    \u0027hz.dashboard\u0027,"},{"line_number":24,"context_line":"    \u0027hz.dashboard.identity\u0027,"},{"line_number":25,"context_line":"]"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_1eb27706","line":23,"updated":"2015-06-24 21:57:38.000000000","message":"Do you need to add \u0027hz.dashboard\u0027?","commit_id":"e763cc81bf5b31b9fbd6d3187e99f0de5b159219"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"72079ec43fc3c2239ec60de2b11c6764785ad9e7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"ADD_INSTALLED_APPS \u003d [\u0027openstack_dashboard.dashboards.identity\u0027]"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"ADD_ANGULAR_MODULES \u003d ["},{"line_number":23,"context_line":"    \u0027hz.dashboard\u0027,"},{"line_number":24,"context_line":"    \u0027hz.dashboard.identity\u0027,"},{"line_number":25,"context_line":"]"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa32b979_1efcb770","line":23,"in_reply_to":"fa32b979_1eb27706","updated":"2015-06-24 22:01:11.000000000","message":"for now i think we do. hz.dashboard contains launch-instance, tech-debt, and workflow. until it gets moved out into core, we still need it.","commit_id":"e763cc81bf5b31b9fbd6d3187e99f0de5b159219"}],"openstack_dashboard/static/dashboard/dashboard.module.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"293b2227e14131830b9966fb0d2f8988611da2d4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"(function () {"},{"line_number":2,"context_line":"  \u0027use strict\u0027;"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"  angular.module(\u0027hz.dashboard\u0027, ["}],"source_content_type":"text/javascript","patch_set":1,"id":"1af86dd1_dc812d91","line":1,"updated":"2015-06-12 18:13:36.000000000","message":"need license header","commit_id":"125a69b9bcb35b23425f1fec69f1b51e72d9cd40"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"724e058e14be1178fdbbccf762f8c4e0b340d71a","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"(function () {"},{"line_number":16,"context_line":"  \u0027use strict\u0027;"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  angular.module(\u0027hz.dashboard\u0027, ["},{"line_number":19,"context_line":"    \u0027hz.dashboard.launch-instance\u0027,"},{"line_number":20,"context_line":"    \u0027hz.dashboard.tech-debt\u0027,"}],"source_content_type":"text/javascript","patch_set":3,"id":"fa32b979_40b2914d","line":17,"updated":"2015-06-17 11:47:52.000000000","message":"Shouldn\u0027t there be a @ngdoc here?","commit_id":"190155a7a64932f72c01a2ab3ff10d96497bfcf9"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"724e058e14be1178fdbbccf762f8c4e0b340d71a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"(function () {"},{"line_number":16,"context_line":"  \u0027use strict\u0027;"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  angular.module(\u0027hz.dashboard\u0027, ["},{"line_number":19,"context_line":"    \u0027hz.dashboard.launch-instance\u0027,"},{"line_number":20,"context_line":"    \u0027hz.dashboard.tech-debt\u0027,"},{"line_number":21,"context_line":"    \u0027hz.dashboard.workflow\u0027,"}],"source_content_type":"text/javascript","patch_set":3,"id":"fa32b979_4044d148","line":18,"updated":"2015-06-17 11:47:52.000000000","message":"This can be split in 2 lines, to keep code style consistent across modules.","commit_id":"190155a7a64932f72c01a2ab3ff10d96497bfcf9"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"9677b528bb97f5194ca5c9f44d2e5d836fd6e1fb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    \u0027hz.dashboard.launch-instance\u0027,"},{"line_number":20,"context_line":"    \u0027hz.dashboard.tech-debt\u0027,"},{"line_number":21,"context_line":"    \u0027hz.dashboard.workflow\u0027,"},{"line_number":22,"context_line":"    \u0027hz.dashboard.identity\u0027"},{"line_number":23,"context_line":"  ])"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  .constant(\u0027dashboardBasePath\u0027, \u0027/static/dashboard/\u0027);"}],"source_content_type":"text/javascript","patch_set":3,"id":"fa32b979_7e0a7c27","line":22,"updated":"2015-06-19 03:04:01.000000000","message":"This is being added here as a dependency of the dashboard module, but the javascript defining \u0027hz.dashboard.identity\u0027 will only be included if \u0027dashboard/identity/identity.module.js\u0027 is loaded, ie. the \"identity\" dashboard is enabled. I note that the other dependencies here present a similar problem, as they are included in the \"project\" dashboard enabled file.","commit_id":"190155a7a64932f72c01a2ab3ff10d96497bfcf9"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"92c32d33c852c844865325429345947f8dcf0a59","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    \u0027hz.dashboard.launch-instance\u0027,"},{"line_number":20,"context_line":"    \u0027hz.dashboard.tech-debt\u0027,"},{"line_number":21,"context_line":"    \u0027hz.dashboard.workflow\u0027,"},{"line_number":22,"context_line":"    \u0027hz.dashboard.identity\u0027"},{"line_number":23,"context_line":"  ])"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  .constant(\u0027dashboardBasePath\u0027, \u0027/static/dashboard/\u0027);"}],"source_content_type":"text/javascript","patch_set":3,"id":"fa32b979_14bd4f01","line":22,"in_reply_to":"fa32b979_7e0a7c27","updated":"2015-06-19 03:58:53.000000000","message":"Yep, I see your point here.  Thanks, Richard.","commit_id":"190155a7a64932f72c01a2ab3ff10d96497bfcf9"}],"openstack_dashboard/static/dashboard/identity/identity.module.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"293b2227e14131830b9966fb0d2f8988611da2d4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"   * Dashboard module to host various identity panels."},{"line_number":26,"context_line":"   */"},{"line_number":27,"context_line":"  angular.module(\u0027hz.dashboard.identity\u0027, ["},{"line_number":28,"context_line":"    \u0027hz.dashboard.identity.users\u0027"},{"line_number":29,"context_line":"  ]);"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":1,"id":"1af86dd1_5ce89d7c","line":28,"updated":"2015-06-12 18:13:36.000000000","message":"should not be there yet!","commit_id":"125a69b9bcb35b23425f1fec69f1b51e72d9cd40"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"724e058e14be1178fdbbccf762f8c4e0b340d71a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"   * @description"},{"line_number":25,"context_line":"   * Dashboard module to host various identity panels."},{"line_number":26,"context_line":"   */"},{"line_number":27,"context_line":"  angular.module(\u0027hz.dashboard.identity\u0027, []);"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":3,"id":"fa32b979_e02de595","line":27,"updated":"2015-06-17 11:47:52.000000000","message":"this can be split in 2 lines, to keep the code style consistent across modules.","commit_id":"190155a7a64932f72c01a2ab3ff10d96497bfcf9"}]}
