)]}'
{"horizon/static/framework/util/tech-debt/helper-functions.js":[{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"348d0bdbdf5563732af6e4dbc4c901bd8649ff86","unresolved":false,"context_lines":[{"line_number":26,"context_line":"          .call($window.HTMLElement)"},{"line_number":27,"context_line":"          .indexOf(\u0027Constructor\u0027) \u003e 0;"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        if (isSafari) {"},{"line_number":30,"context_line":"          return number.toString().replace(/\\B(?\u003d(\\d{3})+(?!\\d))/g, \",\");"},{"line_number":31,"context_line":"        } else {"},{"line_number":32,"context_line":"          return number.toString().replace(/\\d+(\\.\\d+)?/g, function (match) {"}],"source_content_type":"text/javascript","patch_set":2,"id":"1a4dcd0f_2d064686","line":29,"updated":"2015-08-06 13:23:52.000000000","message":"It would be better for this to be detected by feature detection rather than looking for a specific browser - that way we don\u0027t crash older versions of other browsers (which won\u0027t support Intl.NumberFormat) AND when Safari does support it, this code will automatically work with it.","commit_id":"a6610a5d2c5a6ba7799798d1f1ee021e6de37074"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"348d0bdbdf5563732af6e4dbc4c901bd8649ff86","unresolved":false,"context_lines":[{"line_number":27,"context_line":"          .indexOf(\u0027Constructor\u0027) \u003e 0;"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        if (isSafari) {"},{"line_number":30,"context_line":"          return number.toString().replace(/\\B(?\u003d(\\d{3})+(?!\\d))/g, \",\");"},{"line_number":31,"context_line":"        } else {"},{"line_number":32,"context_line":"          return number.toString().replace(/\\d+(\\.\\d+)?/g, function (match) {"},{"line_number":33,"context_line":"            var lang \u003d navigator.userLanguage || navigator.language;"}],"source_content_type":"text/javascript","patch_set":2,"id":"1a4dcd0f_ade9f6e7","line":30,"updated":"2015-08-06 13:23:52.000000000","message":"This keeps consistency with current behavior, but I\u0027d prefer that this return just the number if we can\u0027t properly format. (I think 1000 is better than 1,000)","commit_id":"a6610a5d2c5a6ba7799798d1f1ee021e6de37074"}],"horizon/static/framework/util/tech-debt/helper-functions.service.js":[{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"08aa25f15b137dc643d1160ab0c9f66961fde45a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"     */"},{"line_number":46,"context_line":"    function humanizeNumbers(number) {"},{"line_number":47,"context_line":"      return number.toString().replace(/\\d+(\\.\\d+)?/g, function (match) {"},{"line_number":48,"context_line":"        var lang \u003d navigator.userLanguage || navigator.language;"},{"line_number":49,"context_line":"        try {"},{"line_number":50,"context_line":"          return new Intl.NumberFormat(lang).format(match);"},{"line_number":51,"context_line":"        } catch (e) {"}],"source_content_type":"text/javascript","patch_set":4,"id":"fa1b9901_6504ff14","line":48,"updated":"2015-08-17 19:44:13.000000000","message":"With regard to testability, I think you need to take the language from our Horizon/Django setting - by default this is in the horizon_language cookie value (no value implies english). \n\nThe exact name of the cookie value if from the Django settings file https://github.com/openstack/horizon/blob/master/openstack_dashboard/settings.py#L216\n\nThis should result in more consisent behavior with the rest of Horizon -- that is selecting [user]-\u003eSettings-\u003eUser Settings and chosing a language will also change the number format.\n\nAlso by adding this parameter which can be edited it will enable reasonable unit testing.","commit_id":"a9693f55d80998913a961f38d46dbb9b9b94c906"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"be689c5a94fef81428acada539e405c3122a84b2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"     */"},{"line_number":46,"context_line":"    function humanizeNumbers(number) {"},{"line_number":47,"context_line":"      return number.toString().replace(/\\d+(\\.\\d+)?/g, function (match) {"},{"line_number":48,"context_line":"        var lang \u003d navigator.userLanguage || navigator.language;"},{"line_number":49,"context_line":"        try {"},{"line_number":50,"context_line":"          return new Intl.NumberFormat(lang).format(match);"},{"line_number":51,"context_line":"        } catch (e) {"}],"source_content_type":"text/javascript","patch_set":4,"id":"fa1b9901_88204af9","line":48,"in_reply_to":"fa1b9901_6504ff14","updated":"2015-08-17 20:22:00.000000000","message":"agree with Doug here, you\u0027ll want to use this from the django setting.","commit_id":"a9693f55d80998913a961f38d46dbb9b9b94c906"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"08aa25f15b137dc643d1160ab0c9f66961fde45a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    function humanizeNumbers(number) {"},{"line_number":47,"context_line":"      return number.toString().replace(/\\d+(\\.\\d+)?/g, function (match) {"},{"line_number":48,"context_line":"        var lang \u003d navigator.userLanguage || navigator.language;"},{"line_number":49,"context_line":"        try {"},{"line_number":50,"context_line":"          return new Intl.NumberFormat(lang).format(match);"},{"line_number":51,"context_line":"        } catch (e) {"},{"line_number":52,"context_line":"          return match;"}],"source_content_type":"text/javascript","patch_set":4,"id":"fa1b9901_af69988d","line":49,"updated":"2015-08-17 19:44:13.000000000","message":"Not what I expected, but I do think this solves the problem.","commit_id":"a9693f55d80998913a961f38d46dbb9b9b94c906"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"be689c5a94fef81428acada539e405c3122a84b2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      return number.toString().replace(/\\d+(\\.\\d+)?/g, function (match) {"},{"line_number":48,"context_line":"        var lang \u003d navigator.userLanguage || navigator.language;"},{"line_number":49,"context_line":"        try {"},{"line_number":50,"context_line":"          return new Intl.NumberFormat(lang).format(match);"},{"line_number":51,"context_line":"        } catch (e) {"},{"line_number":52,"context_line":"          return match;"},{"line_number":53,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":4,"id":"fa1b9901_a8742efd","line":50,"updated":"2015-08-17 20:22:00.000000000","message":"very cool, learned something new today :)","commit_id":"a9693f55d80998913a961f38d46dbb9b9b94c906"}],"horizon/static/horizon/js/horizon.quota.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"f31b57d52b6f128bb60ebd9683c999824ab45af7","unresolved":false,"context_lines":[{"line_number":264,"context_line":"  },"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"  /*"},{"line_number":267,"context_line":"   * Adds commas to any integer or numbers within a string for human display."},{"line_number":268,"context_line":"   *"},{"line_number":269,"context_line":"   * Example:"},{"line_number":270,"context_line":"   *  horizon.Quota.humanizeNumbers(1234); -\u003e \"1,234\""}],"source_content_type":"text/javascript","patch_set":8,"id":"9a629dbe_fb23e253","line":267,"updated":"2016-11-10 23:09:24.000000000","message":"comment need to be updated now that it handles i18n","commit_id":"ec7adea0f54ac4700078ac37663021ff5cf9efec"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"ca796f35263d8eb2cd7b8b4ae4bf21b505a14797","unresolved":false,"context_lines":[{"line_number":271,"context_line":"   *  horizon.Quota.humanizeNumbers(\"My Total: 1234\"); -\u003e \"My Total: 1,234\""},{"line_number":272,"context_line":"   *"},{"line_number":273,"context_line":"   * The number formatting depends on what language you choose in Horizon sett-"},{"line_number":274,"context_line":"   * ings."},{"line_number":275,"context_line":"   *"},{"line_number":276,"context_line":"   * Example:"},{"line_number":277,"context_line":"   *  If you change language to \"Deutsch (de)\":"}],"source_content_type":"text/javascript","patch_set":9,"id":"7a77a97e_dac65799","line":274,"updated":"2016-11-17 10:11:05.000000000","message":"Let\u0027s not break the word halfway, just put settings on a new line :)","commit_id":"3dd27f475c9db669cef77af5bbd11a5e5cd6cd86"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"8f87926f8fb60681073c44c68d59d5a639c4ed87","unresolved":false,"context_lines":[{"line_number":264,"context_line":"  },"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"  /*"},{"line_number":267,"context_line":"   * Adds commas to any integer or numbers within a string for human display."},{"line_number":268,"context_line":"   *"},{"line_number":269,"context_line":"   * Example:"},{"line_number":270,"context_line":"   *  horizon.Quota.humanizeNumbers(1234); -\u003e \"1,234\""},{"line_number":271,"context_line":"   *  horizon.Quota.humanizeNumbers(\"My Total: 1234\"); -\u003e \"My Total: 1,234\""},{"line_number":272,"context_line":"   *"},{"line_number":273,"context_line":"   * The number formatting depends on what language you choose in Horizon"},{"line_number":274,"context_line":"   * settings."}],"source_content_type":"text/javascript","patch_set":11,"id":"7a77a97e_19e6af16","line":271,"range":{"start_line":267,"start_character":1,"end_line":271,"end_character":75},"updated":"2016-11-21 05:27:45.000000000","message":"The original doc also should be modified together.","commit_id":"43cb2618335cc31ea635480383d0ee9f20cf849b"}],"horizon/static/horizon/tests/jasmine/quota.legacy-spec.js":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"ca796f35263d8eb2cd7b8b4ae4bf21b505a14797","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    afterEach(function() {"},{"line_number":11,"context_line":"      horizon.cookies.remove(\"horizon_language\");"},{"line_number":12,"context_line":"    });"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    it(\u0027should add a comma every three number\u0027, function () {"},{"line_number":15,"context_line":"      expect(horizon.Quota.humanizeNumbers(\u00271234\u0027)).toEqual(\u00271.234\u0027);"}],"source_content_type":"text/javascript","patch_set":9,"id":"7a77a97e_fa4a3325","line":12,"updated":"2016-11-17 10:11:05.000000000","message":"Could we also test a different locale, to prove that its alternating depending on the cookie? This is only testing a single locale atm.","commit_id":"3dd27f475c9db669cef77af5bbd11a5e5cd6cd86"}],"horizon/templates/horizon/jasmine/jasmine_legacy.html":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"a6b85b62a315c2574db63d0d90597d77073ceab3","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"{% block spec %}"},{"line_number":32,"context_line":"  \u003c!-- test files --\u003e"},{"line_number":33,"context_line":"  \u003cscript type\u003d\"text/javascript\" src\u003d\"{{ STATIC_URL }}app/app.module.spec.js\"\u003e\u003c/script\u003e"},{"line_number":34,"context_line":"  \u003cscript type\u003d\"text/javascript\" src\u003d\"{{ STATIC_URL }}horizon/tests/jasmine/modals.legacy-spec.js\"\u003e\u003c/script\u003e"},{"line_number":35,"context_line":"  \u003cscript type\u003d\"text/javascript\" src\u003d\"{{ STATIC_URL }}horizon/tests/jasmine/templates.legacy-spec.js\"\u003e\u003c/script\u003e"},{"line_number":36,"context_line":"  \u003cscript type\u003d\"text/javascript\" src\u003d\"{{ STATIC_URL }}horizon/tests/jasmine/tables.legacy-spec.js\"\u003e\u003c/script\u003e"}],"source_content_type":"text/html","patch_set":7,"id":"da6895a0_87e7a53f","line":33,"updated":"2016-10-21 03:56:50.000000000","message":"It\u0027s not clear to me why this is added. app/app.module.spec.js is a part of openstack_dashboard, which should not be involved in horizon/ directory testing at all.","commit_id":"b7e577d54a0adbb419d5c477a0ed5eb10e4866cd"}]}
