)]}'
{"doc/source/topics/settings.rst":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"8e0f4fc279ceea2a03654e26863fbfc4572e9c8e","unresolved":false,"context_lines":[{"line_number":1077,"context_line":""},{"line_number":1078,"context_line":""},{"line_number":1079,"context_line":"``OPENSTACK_NOVA_EXTENSIONS_BLACKLIST``"},{"line_number":1080,"context_line":"-------------------------"},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":".. versionadded:: 8.0.0(Liberty)"},{"line_number":1083,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"9a41bdd9_6df4375a","line":1080,"updated":"2015-07-15 20:02:06.000000000","message":"add more --- to align","commit_id":"a5879a0dc8d624d16ffde11adce861ff45354f7c"}],"openstack_dashboard/usage/views.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"b22d9b6b12523c0e65021c79b5b950e4fe9016da","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        simple_tenant_usage_enabled \u003d getattr("},{"line_number":67,"context_line":"            settings, \u0027OPENSTACK_SIMPLE_TENANT_USAGE_ENABLED\u0027, None)"},{"line_number":68,"context_line":"        if simple_tenant_usage_enabled is None:"},{"line_number":69,"context_line":"            try:"},{"line_number":70,"context_line":"                simple_tenant_usage_enabled \u003d api.nova.extension_supported("},{"line_number":71,"context_line":"                    \u0027SimpleTenantUsage\u0027, self.request)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_eff44488","line":68,"updated":"2015-07-13 15:50:00.000000000","message":"shouldn\u0027t we be checking if this is True as well in case the extension is disabled on the nova side?","commit_id":"721be51c9d70c458a27943fcf82bfbab1ba5c78d"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"3b3d7d8a933a084fb1be30acc04bf1043709bfb4","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        simple_tenant_usage_enabled \u003d getattr("},{"line_number":67,"context_line":"            settings, \u0027OPENSTACK_SIMPLE_TENANT_USAGE_ENABLED\u0027, None)"},{"line_number":68,"context_line":"        if simple_tenant_usage_enabled is None:"},{"line_number":69,"context_line":"            try:"},{"line_number":70,"context_line":"                simple_tenant_usage_enabled \u003d api.nova.extension_supported("},{"line_number":71,"context_line":"                    \u0027SimpleTenantUsage\u0027, self.request)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_aa2b8a93","line":68,"in_reply_to":"9a41bdd9_eff44488","updated":"2015-07-13 16:06:21.000000000","message":"My intention was to add two additional possibilities, so that three total options are available:\n\n* by default, when the setting is not set, or is set to None, there is no change in behavior and the simple tenant usage is enabled iff it\u0027s supported\n* if you set it to False, it\u0027s always disabled, there is no check,\n* if you set it to True, it\u0027s always enabled, there is no check\n\nThe idea is that if you know that it\u0027s enabled in your Nova, you can force it in your configuration and have one API call less. Of course I did that only because there was an opportunity to do it in the code, and I am not actually sure how useful this option is.\n\nI can change it to only have True/False and to always do that API call to Nova to check for support, if you think that is better.","commit_id":"721be51c9d70c458a27943fcf82bfbab1ba5c78d"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"1014a20b0c46155575718c707b48241a4744c1e1","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        \"\"\"Check whether to display the simple tenant usage stats.\"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        if not getattr("},{"line_number":63,"context_line":"                settings, \u0027OPENSTACK_SIMPLE_TENANT_USAGE_ENABLED\u0027, True):"},{"line_number":64,"context_line":"            return False"},{"line_number":65,"context_line":"        try:"},{"line_number":66,"context_line":"            return api.nova.extension_supported("}],"source_content_type":"text/x-python","patch_set":3,"id":"9a41bdd9_74043249","line":63,"updated":"2015-07-15 02:27:23.000000000","message":"I wonder if it be better to add this logic inside api.nova.extension_supported() for consistency across all code","commit_id":"f105f01158bc9a4fbbf8b97d64dd9f0d3173fb7c"}]}