)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"9814233c63d71870881f426dca230826e5065ef6","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Since some of the xstatic packages were installed into special"},{"line_number":24,"context_line":"snowflakes directories (not following a pattern) the references to"},{"line_number":25,"context_line":"those (bootstrap_scss and font_awesome) have been fixed."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: Ia5be0e96fff1a4ddd6058d6b030ddf96da4b46e7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"bacf61ea_d0201e9e","line":25,"range":{"start_line":25,"start_character":26,"end_line":25,"end_character":38},"updated":"2016-07-28 12:12:47.000000000","message":"Some plugins may use the old names and this will certainly break them. For example, see https://murano-ci.mirantis.com/jenkins/job/heartbeat-murano-dashboard-ubuntu/1465/artifact/artifacts/devstack/stack.sh.log timestamp \u00272016-07-28 11:12:37.045\u0027.\n\nI don\u0027t think we need to find some workarounds for this, but might be we need to communicate somehow the upcoming change to plugins\u0027 stakeholders?","commit_id":"a1c0f33f555652ad2d9fa02ad5e85c8d6f14cc7e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"023bb358ce99c50c23407840535c84d8131d5022","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Since some of the xstatic packages were installed into special"},{"line_number":24,"context_line":"snowflakes directories (not following a pattern) the references to"},{"line_number":25,"context_line":"those (bootstrap_scss and font_awesome) have been fixed."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: Ia5be0e96fff1a4ddd6058d6b030ddf96da4b46e7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"bacf61ea_78babb6f","line":25,"range":{"start_line":25,"start_character":26,"end_line":25,"end_character":38},"in_reply_to":"bacf61ea_d0201e9e","updated":"2016-07-29 12:41:36.000000000","message":"The specific question about murano-dashboard is no longer actual - they have prepared for this change, https://review.openstack.org/#/c/348855/2","commit_id":"a1c0f33f555652ad2d9fa02ad5e85c8d6f14cc7e"}],"openstack_dashboard/settings.py":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"480012c1a7121ee8614d35254b5f01f6869a393e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from django.utils.translation import ugettext_lazy as _"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from openstack_dashboard import exceptions"},{"line_number":28,"context_line":"from openstack_dashboard.utils import settings"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"warnings.formatwarning \u003d lambda message, category, *args, **kwargs: \\"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa1b9901_e916f34a","line":28,"updated":"2015-08-20 22:29:04.000000000","message":"would this create something that looks like settings.settings for those trying to read the settings elsewhere???  Might want to alias this name to something else.","commit_id":"08fa8f8bef498bf2d3b25883faff124233ab92e5"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"480012c1a7121ee8614d35254b5f01f6869a393e","unresolved":false,"context_lines":[{"line_number":264,"context_line":"DEFAULT_THEME_PATH \u003d \u0027themes/default\u0027"},{"line_number":265,"context_line":"CUSTOM_THEME_PATH \u003d DEFAULT_THEME_PATH"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"XSTATIC_MODULES \u003d settings.BASE_XSTATIC_MODULES"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"try:"},{"line_number":270,"context_line":"    from local.local_settings import *  # noqa"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa1b9901_892c179a","line":267,"updated":"2015-08-20 22:29:04.000000000","message":"this confused me, as we are already in what I think of as \"settings\"","commit_id":"08fa8f8bef498bf2d3b25883faff124233ab92e5"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"9814233c63d71870881f426dca230826e5065ef6","unresolved":false,"context_lines":[{"line_number":302,"context_line":"COMPRESS_OFFLINE_CONTEXT \u003d \u0027horizon.themes.offline_context\u0027"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"# Notice all customizable configurations should be above this line"},{"line_number":305,"context_line":"XSTATIC_MODULES \u003d settings_utils.BASE_XSTATIC_MODULES"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"try:"},{"line_number":308,"context_line":"    from local.local_settings import *  # noqa"}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_cb351347","line":305,"range":{"start_line":305,"start_character":0,"end_line":305,"end_character":15},"updated":"2016-07-28 12:12:47.000000000","message":"What\u0027s about advertising the new XSTATIC_MODULES setting in a releasenote, that it can be enhanced in local_settings/plugins to add new 3rd-party libraries?","commit_id":"a1c0f33f555652ad2d9fa02ad5e85c8d6f14cc7e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f4eb98c0dc09c1eab07c75bbc5079e7047b21b35","unresolved":false,"context_lines":[{"line_number":302,"context_line":"COMPRESS_OFFLINE_CONTEXT \u003d \u0027horizon.themes.offline_context\u0027"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"# Notice all customizable configurations should be above this line"},{"line_number":305,"context_line":"XSTATIC_MODULES \u003d settings_utils.BASE_XSTATIC_MODULES"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"try:"},{"line_number":308,"context_line":"    from local.local_settings import *  # noqa"}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_865d5849","line":305,"in_reply_to":"bacf61ea_cb351347","updated":"2016-08-01 03:37:04.000000000","message":"Hmm. I\u0027m not sure how extending XSTATIC_MODULES should be handled (at the moment it\u0027s not really handled at all, I just realised that).\n\nPerhaps we should allow local_settings to provide ADD_XSTATIC_MODULES?","commit_id":"a1c0f33f555652ad2d9fa02ad5e85c8d6f14cc7e"}],"openstack_dashboard/static/dashboard/scss/_variables.scss":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"721c5fc8a9dcc192827a943a92ebda51bac68037","unresolved":false,"context_lines":[{"line_number":58,"context_line":"// Note: the content-wrapper background colors are determined by"},{"line_number":59,"context_line":"//       .table-striped-datatable styles."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"// Font-awesome path to the icon fonts"},{"line_number":62,"context_line":"$fa-font-path: $webroot + \"/static/horizon/lib/font_awesome/fonts\";"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"/* Charts */"}],"source_content_type":"text/x-scss","patch_set":10,"id":"da20952f_472851e2","line":61,"updated":"2015-08-30 21:45:36.000000000","message":"Pretty sure this needs to be $static_url now ... But hopefully you\u0027ll probably hit that in the merge conflict.","commit_id":"08fa8f8bef498bf2d3b25883faff124233ab92e5"}],"openstack_dashboard/test/settings.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"4fc36d648ea623bf559d72e117f6c76e5c7fd05d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"STATICFILES_DIRS \u003d get_staticfiles_dirs(HORIZON_CONFIG)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Load the pluggable dashboard settings"},{"line_number":72,"context_line":"import openstack_dashboard.enabled"},{"line_number":73,"context_line":"import openstack_dashboard.local.enabled"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa1b9901_1f2b9695","line":70,"updated":"2015-08-19 23:59:51.000000000","message":"should be probably settings.get_xstatic_dirs(XSTATIC_MODULES, HORIZON_CONFIG)","commit_id":"9727c12421a58f7d10fb0e6d25917f80a080d4de"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"a351617c142c540b60c2b4a90d55b1107e360302","unresolved":false,"context_lines":[{"line_number":67,"context_line":"}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"STATICFILES_DIRS \u003d get_staticfiles_dirs(HORIZON_CONFIG)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Load the pluggable dashboard settings"},{"line_number":72,"context_line":"import openstack_dashboard.enabled"},{"line_number":73,"context_line":"import openstack_dashboard.local.enabled"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa1b9901_5f0cae40","line":70,"in_reply_to":"fa1b9901_1f2b9695","updated":"2015-08-20 00:03:05.000000000","message":"ah, sorry, please ignore it","commit_id":"9727c12421a58f7d10fb0e6d25917f80a080d4de"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"5a085263ddf51cec58341a6e494c91d60330de84","unresolved":false,"context_lines":[{"line_number":67,"context_line":"}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"STATICFILES_DIRS \u003d get_staticfiles_dirs(HORIZON_CONFIG)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"# Load the pluggable dashboard settings"},{"line_number":72,"context_line":"import openstack_dashboard.enabled"},{"line_number":73,"context_line":"import openstack_dashboard.local.enabled"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa1b9901_3599d9c4","line":70,"in_reply_to":"fa1b9901_5f0cae40","updated":"2015-08-20 00:38:47.000000000","message":"Actually, this is a real problem that needs to be solved. I am working on a revision to this patch to address it, but I\u0027m not sure you\u0027re going to like it - to reduce duplication I\u0027m moving the base XSTATIC_MODULES definition back into utils/settings.py but bringing it through Django settings.py to allow customisation. It\u0027s not ideal, but I really don\u0027t want to have to have multiple copies of XSTATIC_MODULES :/","commit_id":"9727c12421a58f7d10fb0e6d25917f80a080d4de"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"480012c1a7121ee8614d35254b5f01f6869a393e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from horizon.test.settings import *  # noqa"},{"line_number":16,"context_line":"from horizon.utils import secret_key"},{"line_number":17,"context_line":"from openstack_dashboard import exceptions"},{"line_number":18,"context_line":"from openstack_dashboard.utils import settings"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"TEST_DIR \u003d os.path.dirname(os.path.abspath(__file__))"},{"line_number":21,"context_line":"ROOT_PATH \u003d os.path.abspath(os.path.join(TEST_DIR, \"..\"))"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa1b9901_c92e8f8b","line":18,"updated":"2015-08-20 22:29:04.000000000","message":"same comment as elsewhere","commit_id":"08fa8f8bef498bf2d3b25883faff124233ab92e5"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"9814233c63d71870881f426dca230826e5065ef6","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# Load the pluggable dashboard settings"},{"line_number":104,"context_line":"import openstack_dashboard.enabled"},{"line_number":105,"context_line":"import openstack_dashboard.local.enabled"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"INSTALLED_APPS \u003d list(INSTALLED_APPS)  # Make sure it\u0027s mutable"},{"line_number":108,"context_line":"settings_utils.update_dashboards("}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_8a04b97e","line":105,"range":{"start_line":105,"start_character":0,"end_line":105,"end_character":40},"updated":"2016-07-28 12:12:47.000000000","message":"Why do we need to import it here if it is not being used inside settings_utils.update_dashboards(), line 110?","commit_id":"a1c0f33f555652ad2d9fa02ad5e85c8d6f14cc7e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f4eb98c0dc09c1eab07c75bbc5079e7047b21b35","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# Load the pluggable dashboard settings"},{"line_number":104,"context_line":"import openstack_dashboard.enabled"},{"line_number":105,"context_line":"import openstack_dashboard.local.enabled"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"INSTALLED_APPS \u003d list(INSTALLED_APPS)  # Make sure it\u0027s mutable"},{"line_number":108,"context_line":"settings_utils.update_dashboards("}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_06bde8b6","line":105,"in_reply_to":"bacf61ea_8a04b97e","updated":"2016-08-01 03:37:04.000000000","message":"Well spotted, fixed!","commit_id":"a1c0f33f555652ad2d9fa02ad5e85c8d6f14cc7e"}],"openstack_dashboard/utils/settings.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"4fc36d648ea623bf559d72e117f6c76e5c7fd05d","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            files \u003d module.MAIN"},{"line_number":200,"context_line":"            if not isinstance(files, list):"},{"line_number":201,"context_line":"                files \u003d [files]"},{"line_number":202,"context_line":"        for file in files:"},{"line_number":203,"context_line":"            file \u003d \u0027horizon/lib/\u0027 + module.NAME + \u0027/\u0027 + file"},{"line_number":204,"context_line":"            HORIZON_CONFIG[\u0027xstatic_lib_files\u0027].append(file)"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa1b9901_1fa63653","line":202,"updated":"2015-08-19 23:59:51.000000000","message":"nitpick: try to avoid using buildin names as variable names, because you are shadowing them and that can lead to unpleasant surprises","commit_id":"9727c12421a58f7d10fb0e6d25917f80a080d4de"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"4fc36d648ea623bf559d72e117f6c76e5c7fd05d","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            if not isinstance(files, list):"},{"line_number":201,"context_line":"                files \u003d [files]"},{"line_number":202,"context_line":"        for file in files:"},{"line_number":203,"context_line":"            file \u003d \u0027horizon/lib/\u0027 + module.NAME + \u0027/\u0027 + file"},{"line_number":204,"context_line":"            HORIZON_CONFIG[\u0027xstatic_lib_files\u0027].append(file)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    return STATICFILES_DIRS"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa1b9901_7f6bb2f1","line":203,"updated":"2015-08-19 23:59:51.000000000","message":"nitpick: use string formatting?","commit_id":"9727c12421a58f7d10fb0e6d25917f80a080d4de"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"7762ca321ee01a87d52be47be55900ceb80b1ed5","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    (\u0027xstatic.pkg.qunit\u0027, []),"},{"line_number":208,"context_line":"    (\u0027xstatic.pkg.termjs\u0027, []),"},{"line_number":209,"context_line":"]"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"def get_xstatic_dirs(XSTATIC_MODULES, HORIZON_CONFIG):"},{"line_number":213,"context_line":"    \"\"\"Discover static file configuration of the xstatic modules."}],"source_content_type":"text/x-python","patch_set":10,"id":"fa1b9901_d2488cce","line":210,"updated":"2015-08-20 15:49:59.000000000","message":"Would it make sense to bring back static_settings.py just for this variable?","commit_id":"08fa8f8bef498bf2d3b25883faff124233ab92e5"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"5d6fde236b0466ab9137d44c726732392e7c9e2b","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    (\u0027xstatic.pkg.qunit\u0027, []),"},{"line_number":208,"context_line":"    (\u0027xstatic.pkg.termjs\u0027, []),"},{"line_number":209,"context_line":"]"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"def get_xstatic_dirs(XSTATIC_MODULES, HORIZON_CONFIG):"},{"line_number":213,"context_line":"    \"\"\"Discover static file configuration of the xstatic modules."}],"source_content_type":"text/x-python","patch_set":10,"id":"fa1b9901_4359fe33","line":210,"in_reply_to":"fa1b9901_d2488cce","updated":"2015-08-20 21:29:54.000000000","message":"Yes, I think that makes sense.","commit_id":"08fa8f8bef498bf2d3b25883faff124233ab92e5"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"90ea41fecd9bd465561ecaf44361ef4292402434","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    (\u0027xstatic.pkg.jquery_ui\u0027, [\u0027jquery-ui.js\u0027]),"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    # this is a vendored package we insert into the load"},{"line_number":200,"context_line":"    (None, \u0027horizon/lib/jquery/jquery.bootstrap.wizard.js\u0027),"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    (\u0027xstatic.pkg.bootstrap_scss\u0027, [\u0027js/bootstrap.js\u0027]),"},{"line_number":203,"context_line":"    (\u0027xstatic.pkg.bootstrap_datepicker\u0027, [\u0027bootstrap-datepicker.js\u0027]),"}],"source_content_type":"text/x-python","patch_set":14,"id":"1aa78d24_cd8092fa","line":200,"updated":"2016-07-14 16:35:24.000000000","message":"Should this just be hardcoded in the HTML?","commit_id":"2b379a13e85749e29219b85dc6263a5fb2299e13"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"a6876afca65ab6d86c9369fdc1f5e11e03df94e0","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        STATICFILES_DIRS.append("},{"line_number":248,"context_line":"            (\u0027horizon/lib/\u0027 + module.NAME, module.BASE_DIR)"},{"line_number":249,"context_line":"        )"},{"line_number":250,"context_line":"        if files is None:"},{"line_number":251,"context_line":"            files \u003d module.MAIN"},{"line_number":252,"context_line":"            if not isinstance(files, list):"},{"line_number":253,"context_line":"                files \u003d [files]"},{"line_number":254,"context_line":"        for file in files:"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_f781004f","line":251,"range":{"start_line":250,"start_character":10,"end_line":251,"end_character":31},"updated":"2016-05-18 11:02:20.000000000","message":"On the one hand, it\u0027s good to have a control in Horizon over what entry points are used.\n\nOn the other hand, it\u0027s possible that in a new XStatic-* package release entry points structure is changed and MAIN variable appears. In that case we would have to accompany the version bump for the XStatic-* package with a Horizon update to keep things working. Wouldn\u0027t it be easier from a maintenance POV to change the above logic in the following way: first check for module.MAIN presense, then, if it\u0027s absent fallback to files?","commit_id":"2b379a13e85749e29219b85dc6263a5fb2299e13"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"9814233c63d71870881f426dca230826e5065ef6","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    STATICFILES_DIRS \u003d []"},{"line_number":235,"context_line":"    HORIZON_CONFIG[\u0027xstatic_lib_files\u0027] \u003d []"},{"line_number":236,"context_line":"    for module_name, files in XSTATIC_MODULES:"},{"line_number":237,"context_line":"        if module_name is None:"},{"line_number":238,"context_line":"            # this is the jquery.bootstrap.wizard.js hack"},{"line_number":239,"context_line":"                HORIZON_CONFIG[\u0027xstatic_lib_files\u0027].append(files)"},{"line_number":240,"context_line":"                continue"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        module \u003d import_module(module_name)"},{"line_number":243,"context_line":"        if module_name \u003d\u003d \u0027xstatic.pkg.jquery_ui\u0027:"}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_10dc76e3","line":240,"range":{"start_line":237,"start_character":8,"end_line":240,"end_character":24},"updated":"2016-07-28 12:12:47.000000000","message":"I don\u0027t see it in BASE_XSTATIC_MODULES, where does it come from?","commit_id":"a1c0f33f555652ad2d9fa02ad5e85c8d6f14cc7e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f4eb98c0dc09c1eab07c75bbc5079e7047b21b35","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        if module_name is None:"},{"line_number":238,"context_line":"            # this is the jquery.bootstrap.wizard.js hack"},{"line_number":239,"context_line":"                HORIZON_CONFIG[\u0027xstatic_lib_files\u0027].append(files)"},{"line_number":240,"context_line":"                continue"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        module \u003d import_module(module_name)"},{"line_number":243,"context_line":"        if module_name \u003d\u003d \u0027xstatic.pkg.jquery_ui\u0027:"}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_a6fa1c73","line":240,"in_reply_to":"bacf61ea_10dc76e3","updated":"2016-08-01 03:37:04.000000000","message":"Yup, looks like this legacy code is legacy legacy. Removed.","commit_id":"a1c0f33f555652ad2d9fa02ad5e85c8d6f14cc7e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"87aecb980c5f77fe23dcfc020fb0f5d6e01a1302","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        if module_name is None:"},{"line_number":238,"context_line":"            # this is the jquery.bootstrap.wizard.js hack"},{"line_number":239,"context_line":"                HORIZON_CONFIG[\u0027xstatic_lib_files\u0027].append(files)"},{"line_number":240,"context_line":"                continue"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        module \u003d import_module(module_name)"},{"line_number":243,"context_line":"        if module_name \u003d\u003d \u0027xstatic.pkg.jquery_ui\u0027:"}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_5a804ff7","line":240,"in_reply_to":"bacf61ea_a6fa1c73","updated":"2016-08-01 06:53:09.000000000","message":"Well, https://github.com/openstack/horizon/blob/master/horizon/static/horizon/lib/jquery/jquery.bootstrap.wizard.js is still there. I didn\u0027t mean initially that we should have removed it, but if we really should (it is no longer used, right?), this file should be removed as well.","commit_id":"a1c0f33f555652ad2d9fa02ad5e85c8d6f14cc7e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"9814233c63d71870881f426dca230826e5065ef6","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                HORIZON_CONFIG[\u0027xstatic_lib_files\u0027].append(files)"},{"line_number":240,"context_line":"                continue"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        module \u003d import_module(module_name)"},{"line_number":243,"context_line":"        if module_name \u003d\u003d \u0027xstatic.pkg.jquery_ui\u0027:"},{"line_number":244,"context_line":"            # determine the correct path for jquery-ui which packagers moved"},{"line_number":245,"context_line":"            if module.VERSION.startswith(\u00271.10.\u0027):"}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_abb9bfeb","line":242,"range":{"start_line":242,"start_character":8,"end_line":242,"end_character":43},"updated":"2016-07-28 12:12:47.000000000","message":"What is our strategy for handling non-existent modules possibly coming from other plugins (not sure it\u0027s supported right now, but it seems quite a reasonable option to have a list of additional xstatic modules in some plugin)? Should the whole function fail or should be try this exception and continue to the next xstatic module?\n\nI would prefer keeping some crappy plugin from breaking the whole horizon.","commit_id":"a1c0f33f555652ad2d9fa02ad5e85c8d6f14cc7e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f4eb98c0dc09c1eab07c75bbc5079e7047b21b35","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                HORIZON_CONFIG[\u0027xstatic_lib_files\u0027].append(files)"},{"line_number":240,"context_line":"                continue"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"        module \u003d import_module(module_name)"},{"line_number":243,"context_line":"        if module_name \u003d\u003d \u0027xstatic.pkg.jquery_ui\u0027:"},{"line_number":244,"context_line":"            # determine the correct path for jquery-ui which packagers moved"},{"line_number":245,"context_line":"            if module.VERSION.startswith(\u00271.10.\u0027):"}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_660ae47a","line":242,"in_reply_to":"bacf61ea_abb9bfeb","updated":"2016-08-01 03:37:04.000000000","message":"Well, it\u0027s gonna barf anyway, so I\u0027m not sure there\u0027s much we can do here. It indicates a broken installation which needs to be fixed for Horizon to work...","commit_id":"a1c0f33f555652ad2d9fa02ad5e85c8d6f14cc7e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"9814233c63d71870881f426dca230826e5065ef6","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    return STATICFILES_DIRS"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"def find_static_files("},{"line_number":272,"context_line":"        HORIZON_CONFIG,"},{"line_number":273,"context_line":"        AVAILABLE_THEMES,"},{"line_number":274,"context_line":"        THEME_COLLECTION_DIR,"}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_6b9a2716","line":271,"range":{"start_line":271,"start_character":4,"end_line":271,"end_character":21},"updated":"2016-07-28 12:12:47.000000000","message":"This is just the same function as in removed static_settings.py, right?","commit_id":"a1c0f33f555652ad2d9fa02ad5e85c8d6f14cc7e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f4eb98c0dc09c1eab07c75bbc5079e7047b21b35","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    return STATICFILES_DIRS"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"def find_static_files("},{"line_number":272,"context_line":"        HORIZON_CONFIG,"},{"line_number":273,"context_line":"        AVAILABLE_THEMES,"},{"line_number":274,"context_line":"        THEME_COLLECTION_DIR,"}],"source_content_type":"text/x-python","patch_set":17,"id":"bacf61ea_c61bd0c8","line":271,"in_reply_to":"bacf61ea_6b9a2716","updated":"2016-08-01 03:37:04.000000000","message":"Yes.","commit_id":"a1c0f33f555652ad2d9fa02ad5e85c8d6f14cc7e"}]}
