)]}'
{"openstack_dashboard/dashboards/project/networks/workflows.py":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"b777c9ca6812336507a0f4ed4a37c48c2572ba2f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":106,"context_line":"        if cidr:"},{"line_number":107,"context_line":"            subnet \u003d netaddr.IPNetwork(cidr)"},{"line_number":108,"context_line":"            if subnet.version !\u003d ip_version:"},{"line_number":109,"context_line":"                msg \u003d _(\u0027Network Address and IP version are inconsistent.\u0027)"},{"line_number":110,"context_line":"                raise forms.ValidationError(msg)"},{"line_number":111,"context_line":"            if (ip_version \u003d\u003d 4 and subnet.prefixlen \u003d\u003d 32) or \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FT4o%3D","line":108,"updated":"2013-01-29 15:06:50.000000000","message":"Any reason, why you did use !\u003d (instead of is not)?","commit_id":"05207f58c2182a396bb360e64b7e2b66270a6323"},{"author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"change_message_id":"425faccdd4f0bf398a79dc5ef56a3e4d1cff35bf","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":106,"context_line":"        if cidr:"},{"line_number":107,"context_line":"            subnet \u003d netaddr.IPNetwork(cidr)"},{"line_number":108,"context_line":"            if subnet.version !\u003d ip_version:"},{"line_number":109,"context_line":"                msg \u003d _(\u0027Network Address and IP version are inconsistent.\u0027)"},{"line_number":110,"context_line":"                raise forms.ValidationError(msg)"},{"line_number":111,"context_line":"            if (ip_version \u003d\u003d 4 and subnet.prefixlen \u003d\u003d 32) or \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FTX0%3D","line":108,"in_reply_to":"AAAAM3%2F%2FT1c%3D","updated":"2013-01-29 18:51:35.000000000","message":"This seems fine to me. Using an identity operator (is) vs an equality operator (\u003d) here doesn\u0027t seem necessary.","commit_id":"05207f58c2182a396bb360e64b7e2b66270a6323"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"0fd06c960e5ebaf6d6edcb226daaac8fbfde695c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":106,"context_line":"        if cidr:"},{"line_number":107,"context_line":"            subnet \u003d netaddr.IPNetwork(cidr)"},{"line_number":108,"context_line":"            if subnet.version !\u003d ip_version:"},{"line_number":109,"context_line":"                msg \u003d _(\u0027Network Address and IP version are inconsistent.\u0027)"},{"line_number":110,"context_line":"                raise forms.ValidationError(msg)"},{"line_number":111,"context_line":"            if (ip_version \u003d\u003d 4 and subnet.prefixlen \u003d\u003d 32) or \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FT1c%3D","line":108,"in_reply_to":"AAAAM3%2F%2FT4o%3D","updated":"2013-01-29 16:00:01.000000000","message":"We\u0027re comparing the integers 4 and/or 6, which to me calls for the equality operator since we\u0027re comparing values, rather than object identity (http://docs.python.org/2.7/library/stdtypes.html#comparisons).","commit_id":"05207f58c2182a396bb360e64b7e2b66270a6323"}]}
