)]}'
{"openstack_dashboard/dashboards/admin/dashboard.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"34178b038421ebb8d6429aa73afb2d9637f512fb","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    panels \u003d (\u0027overview\u0027, \u0027metering\u0027, \u0027hypervisors\u0027, \u0027aggregates\u0027,"},{"line_number":24,"context_line":"              \u0027instances\u0027, \u0027volumes\u0027, \u0027flavors\u0027, \u0027images\u0027,"},{"line_number":25,"context_line":"              \u0027networks\u0027, \u0027routers\u0027, \u0027defaults\u0027, \u0027metadata_defs\u0027, \u0027info\u0027,"},{"line_number":26,"context_line":"              \u0027ngdefaults\u0027)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class Admin(horizon.Dashboard):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a50d1a3_cc87a6b3","line":26,"updated":"2015-07-28 18:44:28.000000000","message":"unnecessary and should not be added here.","commit_id":"c499446269270253bb4bf4a36e1a8a8b0ab157a8"}],"openstack_dashboard/dashboards/admin/ngdefaults/panel.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"34178b038421ebb8d6429aa73afb2d9637f512fb","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    slug \u003d \"ngdefaults\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"dashboard.Admin.register(NgDefaults)"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a50d1a3_6ca77250","line":23,"updated":"2015-07-28 18:44:28.000000000","message":"this is not necessary and should be removed happens as part of the enabled file.","commit_id":"c499446269270253bb4bf4a36e1a8a8b0ab157a8"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"67c51d0b741408d7b678fa854e0cfe0aaf52fe43","unresolved":false,"context_lines":[{"line_number":14,"context_line":"import horizon"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class NgDefaults(horizon.Panel):"},{"line_number":18,"context_line":"    name \u003d _(\"Default Quotas\")"},{"line_number":19,"context_line":"    slug \u003d \"ngdefaults\""}],"source_content_type":"text/x-python","patch_set":83,"id":"5a2ca52d_fd548dfe","line":17,"updated":"2015-10-16 13:51:05.000000000","message":"nit: NGDefaults","commit_id":"da27ef291b39babe68699aa120c2112c7a0cc5d9"},{"author":{"_account_id":17004,"name":"KBrown","email":"kbrown@thoughtworks.com","username":"kbrown"},"change_message_id":"9a3dfa9b301f706e56155b85400769e25feee30f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"import horizon"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class NgDefaults(horizon.Panel):"},{"line_number":18,"context_line":"    name \u003d _(\"Default Quotas\")"},{"line_number":19,"context_line":"    slug \u003d \"ngdefaults\""}],"source_content_type":"text/x-python","patch_set":83,"id":"5a2ca52d_d005ea13","line":17,"in_reply_to":"5a2ca52d_fd548dfe","updated":"2015-10-16 19:49:46.000000000","message":"Done","commit_id":"da27ef291b39babe68699aa120c2112c7a0cc5d9"}],"openstack_dashboard/dashboards/admin/ngdefaults/templates/ngdefaults/index.html":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"d48edcd9d7800ae414cc2e0059049109c3f20872","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Defaults\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Defaults\") %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":6,"id":"3a50d1a3_41d1a2fa","line":6,"updated":"2015-07-24 17:58:19.000000000","message":"ok for now, but we\u0027re moving away from this. see https://review.openstack.org/#/c/200385/35/openstack_dashboard/dashboards/project/ngimages/templates/ngimages/index.html","commit_id":"52366a0a66ce4debfc9aa217c6f6bd4bed6baa91"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3c5a0250f52a258d9c89eb4e4e853e4ca986bd6c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Defaults\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  \u003chz-page-header header\u003d\"\u0027Defaults\u0027 | translate\"\u003e\u003c/hz-page-header\u003e"}],"source_content_type":"text/html","patch_set":51,"id":"1a4dcd0f_fbf2146e","line":3,"updated":"2015-08-13 15:09:20.000000000","message":"This can go away.","commit_id":"798f1e8e7fc5a06cfb6e270e2d7b01d04486fa03"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"d62dc2edafb634994dc08b9715d34db4c3448090","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Defaults\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  \u003chz-page-header header\u003d\"\u0027Defaults\u0027 | translate\"\u003e\u003c/hz-page-header\u003e"}],"source_content_type":"text/html","patch_set":51,"id":"1a4dcd0f_4a8b2b69","line":3,"in_reply_to":"1a4dcd0f_fbf2146e","updated":"2015-08-13 17:52:29.000000000","message":"This takes out the page title in the browser.","commit_id":"798f1e8e7fc5a06cfb6e270e2d7b01d04486fa03"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3c5a0250f52a258d9c89eb4e4e853e4ca986bd6c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Defaults\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  \u003chz-page-header header\u003d\"\u0027Defaults\u0027 | translate\"\u003e\u003c/hz-page-header\u003e"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":51,"id":"1a4dcd0f_1be340a5","line":6,"updated":"2015-08-13 15:09:20.000000000","message":"For consistency, we should probably move the hz-page-header inside the actual defaults-table.html so it can be modified by the controller if necessary; this is due to using each panel as its own SPA in which case each screen may have a different name; we can\u0027t do that if the header is here.\n\nTo make this work, you need to put something like an empty div here: \u003cdiv\u003e\u003c/div\u003e and place this header inside the controller scope in defaults-table.html","commit_id":"798f1e8e7fc5a06cfb6e270e2d7b01d04486fa03"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"d62dc2edafb634994dc08b9715d34db4c3448090","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Defaults\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  \u003chz-page-header header\u003d\"\u0027Defaults\u0027 | translate\"\u003e\u003c/hz-page-header\u003e"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":51,"id":"1a4dcd0f_6aadc7e9","line":6,"in_reply_to":"1a4dcd0f_1be340a5","updated":"2015-08-13 17:52:29.000000000","message":"Done","commit_id":"798f1e8e7fc5a06cfb6e270e2d7b01d04486fa03"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"ccd4b5b9e16ca38e65a4ab7eeb35608c4adad2d3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Default Quotas\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  \u003chz-page-header header\u003d\"\u0027{% trans \"Default Quotas\" %}\u0027\"\u003e\u003c/hz-page-header\u003e"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":110,"id":"9a68dd71_d8526b13","line":6,"range":{"start_line":6,"start_character":26,"end_line":6,"end_character":27},"updated":"2016-01-21 04:33:24.000000000","message":"is there any specific reason to display a header in single quote?","commit_id":"66c390d06e90b2789401ae7d8ffcf902a773686e"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"6e0f803231dbb05a3de805c78fbd731fab0e4058","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Default Quotas\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  \u003chz-page-header header\u003d\"\u0027{% trans \"Default Quotas\" %}\u0027\"\u003e\u003c/hz-page-header\u003e"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":110,"id":"7a5de9d1_cdee41ec","line":6,"range":{"start_line":6,"start_character":26,"end_line":6,"end_character":27},"in_reply_to":"9a68dd71_d8526b13","updated":"2016-01-27 19:24:05.000000000","message":"Done","commit_id":"66c390d06e90b2789401ae7d8ffcf902a773686e"}],"openstack_dashboard/dashboards/admin/ngdefaults/tests.py":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"d48edcd9d7800ae414cc2e0059049109c3f20872","unresolved":false,"context_lines":[{"line_number":16,"context_line":"INDEX_URL \u003d reverse(\u0027horizon:admin:ngdefaults:index\u0027)"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class NgDefaultsTests(test.TestCase):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_template(self):"},{"line_number":22,"context_line":"        res \u003d self.client.get(INDEX_URL)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_e108ee93","line":19,"updated":"2015-07-24 17:58:19.000000000","message":"nice!","commit_id":"52366a0a66ce4debfc9aa217c6f6bd4bed6baa91"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"c233e301d8472cf7be35c3a22f3839fecdf108af","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class NgDefaultsTests(test.BaseAdminViewTests):"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    @unittest.skip(\"bug 1479018\")"},{"line_number":21,"context_line":"    def test_template(self):"},{"line_number":22,"context_line":"        res \u003d self.client.get(reverse(\u0027horizon:admin:ngdefaults:index\u0027))"},{"line_number":23,"context_line":"        self.assertTemplateUsed(res, \u0027admin/ngdefaults/index.html\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a50d1a3_fdd89c81","line":20,"updated":"2015-07-30 16:56:50.000000000","message":"remove this. tests for the panel don\u0027t run without it being enabled.","commit_id":"5a94abadb4861f7a64f4b75594f3e75c4a652ebe"}],"openstack_dashboard/dashboards/admin/ngdefaults/views.py":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"d48edcd9d7800ae414cc2e0059049109c3f20872","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    # A very simple class-based view..."},{"line_number":17,"context_line":"    template_name \u003d \u0027admin/ngdefaults/index.html\u0027"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    def get_data(self, request, context, *args, **kwargs):"},{"line_number":20,"context_line":"        # Add data to the context here..."},{"line_number":21,"context_line":"        return context"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_c12a92e7","line":19,"updated":"2015-07-24 17:58:19.000000000","message":"not needed if you\u0027re not doing anything with context?","commit_id":"52366a0a66ce4debfc9aa217c6f6bd4bed6baa91"}],"openstack_dashboard/dashboards/admin/static/dashboard/admin/admin.module.js":[{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"a7b8debb7c939b457e8d38a55d7103aa872f6282","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  \u0027use strict\u0027;"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  /**"},{"line_number":21,"context_line":"   * @ngdoc horizon.dashboard.identity"},{"line_number":22,"context_line":"   * @ngModule"},{"line_number":23,"context_line":"   *"},{"line_number":24,"context_line":"   * @description"}],"source_content_type":"text/javascript","patch_set":55,"id":"fa1b9901_82c4825f","line":21,"updated":"2015-08-18 13:33:16.000000000","message":"documentation needs to be updated","commit_id":"c5ebe47d66a86960402d546f34c9b5ae7f445478"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"9a8c0bc4ebb3d371bb5a623fd9602980035bbef7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  \u0027use strict\u0027;"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  /**"},{"line_number":21,"context_line":"   * @ngdoc horizon.dashboard.identity"},{"line_number":22,"context_line":"   * @ngModule"},{"line_number":23,"context_line":"   *"},{"line_number":24,"context_line":"   * @description"}],"source_content_type":"text/javascript","patch_set":55,"id":"fa1b9901_1efc0d71","line":21,"in_reply_to":"fa1b9901_82c4825f","updated":"2015-08-19 17:13:34.000000000","message":"Done","commit_id":"c5ebe47d66a86960402d546f34c9b5ae7f445478"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"a7b8debb7c939b457e8d38a55d7103aa872f6282","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    ])"},{"line_number":31,"context_line":"    .config(config);"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  config.$inject \u003d [\u0027$provide\u0027, \u0027$windowProvider\u0027];"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  function config($provide, $windowProvider) {"},{"line_number":36,"context_line":"    var path \u003d $windowProvider.$get().STATIC_URL + \u0027dashboard/admin/\u0027;"}],"source_content_type":"text/javascript","patch_set":55,"id":"fa1b9901_e2b45ef3","line":33,"updated":"2015-08-18 13:33:16.000000000","message":"nit: apparently you\u0027re supposed to put each injected service in a different line for consistency. please refer to Thai\u0027s comment here https://review.openstack.org/#/c/206773/16/openstack_dashboard/static/app/core/openstack-service-api/heat.service.js","commit_id":"c5ebe47d66a86960402d546f34c9b5ae7f445478"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"9a8c0bc4ebb3d371bb5a623fd9602980035bbef7","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    ])"},{"line_number":31,"context_line":"    .config(config);"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  config.$inject \u003d [\u0027$provide\u0027, \u0027$windowProvider\u0027];"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  function config($provide, $windowProvider) {"},{"line_number":36,"context_line":"    var path \u003d $windowProvider.$get().STATIC_URL + \u0027dashboard/admin/\u0027;"}],"source_content_type":"text/javascript","patch_set":55,"id":"fa1b9901_defa1575","line":33,"in_reply_to":"fa1b9901_e2b45ef3","updated":"2015-08-19 17:13:34.000000000","message":"Done","commit_id":"c5ebe47d66a86960402d546f34c9b5ae7f445478"}],"openstack_dashboard/dashboards/admin/static/dashboard/admin/admin.module.spec.js":[{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"a7b8debb7c939b457e8d38a55d7103aa872f6282","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    it(\u0027should exist\u0027, function() {"},{"line_number":21,"context_line":"      expect(angular.module(\u0027horizon.dashboard.admin\u0027)).toBeDefined();"},{"line_number":22,"context_line":"    });"},{"line_number":23,"context_line":"  });"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":55,"id":"fa1b9901_6277ee3a","line":23,"updated":"2015-08-18 13:33:16.000000000","message":"please add tests to cover the base path constant definition for the module","commit_id":"c5ebe47d66a86960402d546f34c9b5ae7f445478"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"9a8c0bc4ebb3d371bb5a623fd9602980035bbef7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    it(\u0027should exist\u0027, function() {"},{"line_number":21,"context_line":"      expect(angular.module(\u0027horizon.dashboard.admin\u0027)).toBeDefined();"},{"line_number":22,"context_line":"    });"},{"line_number":23,"context_line":"  });"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":55,"id":"fa1b9901_797be38c","line":23,"in_reply_to":"fa1b9901_6277ee3a","updated":"2015-08-19 17:13:34.000000000","message":"Done","commit_id":"c5ebe47d66a86960402d546f34c9b5ae7f445478"}],"openstack_dashboard/dashboards/admin/static/dashboard/admin/defaults/actions/defaults-actions-update.controller.js":[{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"a7b8debb7c939b457e8d38a55d7103aa872f6282","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  ];"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  /**"},{"line_number":33,"context_line":"   * @ngdoc defaultsActionsUpdateController"},{"line_number":34,"context_line":"   * @ngController"},{"line_number":35,"context_line":"   *"},{"line_number":36,"context_line":"   * @description"}],"source_content_type":"text/javascript","patch_set":55,"id":"fa1b9901_22b7b6d9","line":33,"updated":"2015-08-18 13:33:16.000000000","message":"nit: capital D","commit_id":"c5ebe47d66a86960402d546f34c9b5ae7f445478"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"9a8c0bc4ebb3d371bb5a623fd9602980035bbef7","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  ];"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  /**"},{"line_number":33,"context_line":"   * @ngdoc defaultsActionsUpdateController"},{"line_number":34,"context_line":"   * @ngController"},{"line_number":35,"context_line":"   *"},{"line_number":36,"context_line":"   * @description"}],"source_content_type":"text/javascript","patch_set":55,"id":"fa1b9901_9e049d18","line":33,"in_reply_to":"fa1b9901_22b7b6d9","updated":"2015-08-19 17:13:34.000000000","message":"Done","commit_id":"c5ebe47d66a86960402d546f34c9b5ae7f445478"}],"openstack_dashboard/dashboards/admin/static/dashboard/admin/defaults/actions/defaults-actions-update.controller.spec.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3c5a0250f52a258d9c89eb4e4e853e4ca986bd6c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      beforeEach(module(\u0027horizon.app.core.openstack-service-api\u0027));"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"      beforeEach(module(\u0027horizon.dashboard.admin\u0027, function($provide) {"},{"line_number":29,"context_line":"        $provide.constant(\u0027horizon.dashboard.admin.basePath\u0027, \u0027/a/sample/path/\u0027);"},{"line_number":30,"context_line":"      }));"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"      beforeEach(module(\u0027horizon.dashboard.admin.defaults\u0027));"}],"source_content_type":"text/javascript","patch_set":51,"id":"1a4dcd0f_9606471a","line":29,"updated":"2015-08-13 15:09:20.000000000","message":"I like it, this is a good way to exercise the code.","commit_id":"798f1e8e7fc5a06cfb6e270e2d7b01d04486fa03"}],"openstack_dashboard/dashboards/admin/static/dashboard/admin/defaults/actions/defaults-update.html":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3c5a0250f52a258d9c89eb4e4e853e4ca986bd6c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    \u003c/tabset\u003e"},{"line_number":67,"context_line":"  \u003c/div\u003e"},{"line_number":68,"context_line":"  \u003cdiv class\u003d\"modal-footer\"\u003e"},{"line_number":69,"context_line":"    \u003ca class\u003d\"btn btn-primary pull-right\" ng-disabled\u003d\"updateDefaultsForm.$invalid\" ng-click\u003d\"ctrl.ok()\"\u003eUpdate Defaults\u003c/a\u003e"},{"line_number":70,"context_line":"    \u003ca class\u003d\"btn btn-default secondary cancel close\" ng-click\u003d\"ctrl.cancel()\"\u003eCancel\u003c/a\u003e"},{"line_number":71,"context_line":"  \u003c/div\u003e"},{"line_number":72,"context_line":"\u003c/form\u003e"}],"source_content_type":"text/html","patch_set":51,"id":"1a4dcd0f_f651cb0e","line":69,"updated":"2015-08-13 15:09:20.000000000","message":"Needs translation.","commit_id":"798f1e8e7fc5a06cfb6e270e2d7b01d04486fa03"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"d62dc2edafb634994dc08b9715d34db4c3448090","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    \u003c/tabset\u003e"},{"line_number":67,"context_line":"  \u003c/div\u003e"},{"line_number":68,"context_line":"  \u003cdiv class\u003d\"modal-footer\"\u003e"},{"line_number":69,"context_line":"    \u003ca class\u003d\"btn btn-primary pull-right\" ng-disabled\u003d\"updateDefaultsForm.$invalid\" ng-click\u003d\"ctrl.ok()\"\u003eUpdate Defaults\u003c/a\u003e"},{"line_number":70,"context_line":"    \u003ca class\u003d\"btn btn-default secondary cancel close\" ng-click\u003d\"ctrl.cancel()\"\u003eCancel\u003c/a\u003e"},{"line_number":71,"context_line":"  \u003c/div\u003e"},{"line_number":72,"context_line":"\u003c/form\u003e"}],"source_content_type":"text/html","patch_set":51,"id":"1a4dcd0f_8abff3fb","line":69,"in_reply_to":"1a4dcd0f_f651cb0e","updated":"2015-08-13 17:52:29.000000000","message":"Done","commit_id":"798f1e8e7fc5a06cfb6e270e2d7b01d04486fa03"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3c5a0250f52a258d9c89eb4e4e853e4ca986bd6c","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  \u003c/div\u003e"},{"line_number":68,"context_line":"  \u003cdiv class\u003d\"modal-footer\"\u003e"},{"line_number":69,"context_line":"    \u003ca class\u003d\"btn btn-primary pull-right\" ng-disabled\u003d\"updateDefaultsForm.$invalid\" ng-click\u003d\"ctrl.ok()\"\u003eUpdate Defaults\u003c/a\u003e"},{"line_number":70,"context_line":"    \u003ca class\u003d\"btn btn-default secondary cancel close\" ng-click\u003d\"ctrl.cancel()\"\u003eCancel\u003c/a\u003e"},{"line_number":71,"context_line":"  \u003c/div\u003e"},{"line_number":72,"context_line":"\u003c/form\u003e"}],"source_content_type":"text/html","patch_set":51,"id":"1a4dcd0f_763e1bb9","line":70,"updated":"2015-08-13 15:09:20.000000000","message":"Needs translation.","commit_id":"798f1e8e7fc5a06cfb6e270e2d7b01d04486fa03"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"d62dc2edafb634994dc08b9715d34db4c3448090","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  \u003c/div\u003e"},{"line_number":68,"context_line":"  \u003cdiv class\u003d\"modal-footer\"\u003e"},{"line_number":69,"context_line":"    \u003ca class\u003d\"btn btn-primary pull-right\" ng-disabled\u003d\"updateDefaultsForm.$invalid\" ng-click\u003d\"ctrl.ok()\"\u003eUpdate Defaults\u003c/a\u003e"},{"line_number":70,"context_line":"    \u003ca class\u003d\"btn btn-default secondary cancel close\" ng-click\u003d\"ctrl.cancel()\"\u003eCancel\u003c/a\u003e"},{"line_number":71,"context_line":"  \u003c/div\u003e"},{"line_number":72,"context_line":"\u003c/form\u003e"}],"source_content_type":"text/html","patch_set":51,"id":"1a4dcd0f_2abc9f05","line":70,"in_reply_to":"1a4dcd0f_763e1bb9","updated":"2015-08-13 17:52:29.000000000","message":"Done","commit_id":"798f1e8e7fc5a06cfb6e270e2d7b01d04486fa03"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"a7b8debb7c939b457e8d38a55d7103aa872f6282","unresolved":false,"context_lines":[{"line_number":9,"context_line":"          \u003cfieldset\u003e"},{"line_number":10,"context_line":"            \u003cdiv class\u003d\"row\"\u003e"},{"line_number":11,"context_line":"              \u003cdiv class\u003d\"col-sm-6\"\u003e"},{"line_number":12,"context_line":"                \u003cdiv class\u003d\"form-group required\" ng-class\u003d\"{ \u0027has-warning\u0027: updateDefaultsForm[\u0027injected_file_content_bytes\u0027].$invalid }\"\u003e"},{"line_number":13,"context_line":"                  \u003clabel class\u003d\"control-label required\" for\u003d\"id_injected_file_content_bytes\"\u003e\u003ctranslate\u003eInjected File Content Bytes\u003c/translate\u003e\u003c/label\u003e"},{"line_number":14,"context_line":"                  \u003cinput class\u003d\"form-control\" id\u003d\"id_injected_file_content_bytes\" min\u003d\"-1\" name\u003d\"injected_file_content_bytes\" type\u003d\"number\" ng-required\u003d\"true\" ng-pattern\u003d\"/^[0-9]+$/\" ng-model\u003d\"ctrl.defaults.injected_file_content_bytes\"\u003e"},{"line_number":15,"context_line":"                \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":55,"id":"fa1b9901_02d5d2b7","line":12,"updated":"2015-08-18 13:33:16.000000000","message":"please consider breaking the tag attributes in different lines. it\u0027s getting pretty hard to read \u003d\\","commit_id":"c5ebe47d66a86960402d546f34c9b5ae7f445478"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"9a8c0bc4ebb3d371bb5a623fd9602980035bbef7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"          \u003cfieldset\u003e"},{"line_number":10,"context_line":"            \u003cdiv class\u003d\"row\"\u003e"},{"line_number":11,"context_line":"              \u003cdiv class\u003d\"col-sm-6\"\u003e"},{"line_number":12,"context_line":"                \u003cdiv class\u003d\"form-group required\" ng-class\u003d\"{ \u0027has-warning\u0027: updateDefaultsForm[\u0027injected_file_content_bytes\u0027].$invalid }\"\u003e"},{"line_number":13,"context_line":"                  \u003clabel class\u003d\"control-label required\" for\u003d\"id_injected_file_content_bytes\"\u003e\u003ctranslate\u003eInjected File Content Bytes\u003c/translate\u003e\u003c/label\u003e"},{"line_number":14,"context_line":"                  \u003cinput class\u003d\"form-control\" id\u003d\"id_injected_file_content_bytes\" min\u003d\"-1\" name\u003d\"injected_file_content_bytes\" type\u003d\"number\" ng-required\u003d\"true\" ng-pattern\u003d\"/^[0-9]+$/\" ng-model\u003d\"ctrl.defaults.injected_file_content_bytes\"\u003e"},{"line_number":15,"context_line":"                \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":55,"id":"fa1b9901_fe0b5928","line":12,"in_reply_to":"fa1b9901_02d5d2b7","updated":"2015-08-19 17:13:34.000000000","message":"I\u0027ll be replacing these with dynamically generated forms fields. Work in progress.","commit_id":"c5ebe47d66a86960402d546f34c9b5ae7f445478"}],"openstack_dashboard/dashboards/admin/static/dashboard/admin/defaults/defaults.module.js":[{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"67c51d0b741408d7b678fa854e0cfe0aaf52fe43","unresolved":false,"context_lines":[{"line_number":26,"context_line":"   */"},{"line_number":27,"context_line":"  angular"},{"line_number":28,"context_line":"    .module(\u0027horizon.dashboard.admin.defaults\u0027, [])"},{"line_number":29,"context_line":"    .value(\u0027horizon.dashboard.admin.defaults.events\u0027, events())"},{"line_number":30,"context_line":"    .config(config);"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  function events() {"}],"source_content_type":"text/javascript","patch_set":83,"id":"5a2ca52d_5df021fe","line":29,"updated":"2015-10-16 13:51:05.000000000","message":"maybe it would be cleaner to provide this constant using the config function too. not a blocker though ;-)","commit_id":"da27ef291b39babe68699aa120c2112c7a0cc5d9"},{"author":{"_account_id":17004,"name":"KBrown","email":"kbrown@thoughtworks.com","username":"kbrown"},"change_message_id":"9a3dfa9b301f706e56155b85400769e25feee30f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"   */"},{"line_number":27,"context_line":"  angular"},{"line_number":28,"context_line":"    .module(\u0027horizon.dashboard.admin.defaults\u0027, [])"},{"line_number":29,"context_line":"    .value(\u0027horizon.dashboard.admin.defaults.events\u0027, events())"},{"line_number":30,"context_line":"    .config(config);"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  function events() {"}],"source_content_type":"text/javascript","patch_set":83,"id":"5a2ca52d_53256459","line":29,"in_reply_to":"5a2ca52d_5df021fe","updated":"2015-10-16 19:49:46.000000000","message":"Actually we don\u0027t need events in this patch since this is for only the table, so I\u0027ll do this in the child subflow patch :)","commit_id":"da27ef291b39babe68699aa120c2112c7a0cc5d9"}],"openstack_dashboard/dashboards/admin/static/dashboard/admin/defaults/defaults.module.spec.js":[{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"84b38b41c29196cab534af1953636b92c239b574","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    it(\u0027should exist\u0027, function () {"},{"line_number":20,"context_line":"      expect(angular.module(\u0027horizon.dashboard.admin.defaults\u0027)).toBeDefined();"},{"line_number":21,"context_line":"    });"},{"line_number":22,"context_line":"  });"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":87,"id":"3a29b11f_6806b2cf","line":22,"updated":"2015-10-20 20:32:22.000000000","message":"because you defined a basePath constant, can we have a test for it as well?","commit_id":"1477f13c23c2754296a98ed3700bcd43c8e4b68c"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"b4d870c73a1390c5eed267375c69b8de89db186f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    it(\u0027should exist\u0027, function () {"},{"line_number":20,"context_line":"      expect(angular.module(\u0027horizon.dashboard.admin.defaults\u0027)).toBeDefined();"},{"line_number":21,"context_line":"    });"},{"line_number":22,"context_line":"  });"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":87,"id":"3a29b11f_430dd735","line":22,"in_reply_to":"3a29b11f_6806b2cf","updated":"2015-10-20 20:45:45.000000000","message":"Done","commit_id":"1477f13c23c2754296a98ed3700bcd43c8e4b68c"}],"openstack_dashboard/dashboards/admin/static/dashboard/admin/defaults/defaults.scss":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3c5a0250f52a258d9c89eb4e4e853e4ca986bd6c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"table[ng-controller\u003d\"defaultsTableController as table\"] {"},{"line_number":2,"context_line":"}"}],"source_content_type":"text/x-scss","patch_set":51,"id":"1a4dcd0f_3689736f","line":1,"updated":"2015-08-13 15:09:20.000000000","message":"Do we need this?  Are you anticipating something?  Otherwise seems superfluous.","commit_id":"798f1e8e7fc5a06cfb6e270e2d7b01d04486fa03"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"d62dc2edafb634994dc08b9715d34db4c3448090","unresolved":false,"context_lines":[{"line_number":1,"context_line":"table[ng-controller\u003d\"defaultsTableController as table\"] {"},{"line_number":2,"context_line":"}"}],"source_content_type":"text/x-scss","patch_set":51,"id":"1a4dcd0f_ea5b17f8","line":1,"in_reply_to":"1a4dcd0f_3689736f","updated":"2015-08-13 17:52:29.000000000","message":"Done","commit_id":"798f1e8e7fc5a06cfb6e270e2d7b01d04486fa03"}],"openstack_dashboard/dashboards/admin/static/dashboard/admin/defaults/table/defaults-table-batch-actions.html":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3c5a0250f52a258d9c89eb4e4e853e4ca986bd6c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  Table-batch-actions:"},{"line_number":3,"context_line":"  This is where batch actions like searching and updating."},{"line_number":4,"context_line":"--\u003e"},{"line_number":5,"context_line":"\u003cth colspan\u003d\"100\" class\u003d\"search-header\"\u003e"},{"line_number":6,"context_line":"  \u003chz-search-bar group-classes\u003d\"input-group-sm\" icon-classes\u003d\"fa-search\"\u003e"},{"line_number":7,"context_line":"  \u003c/hz-search-bar\u003e"},{"line_number":8,"context_line":"  \u003cbutton type\u003d\"button\" class\u003d\"btn btn-sm btn-default pull-right\" ng-click\u003d\"table.editDefaults()\"\u003e"}],"source_content_type":"text/html","patch_set":51,"id":"1a4dcd0f_7bce045b","line":5,"updated":"2015-08-13 15:09:20.000000000","message":"colspan 0 should be appropriate here, not arbitrary 100.","commit_id":"798f1e8e7fc5a06cfb6e270e2d7b01d04486fa03"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"d62dc2edafb634994dc08b9715d34db4c3448090","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  Table-batch-actions:"},{"line_number":3,"context_line":"  This is where batch actions like searching and updating."},{"line_number":4,"context_line":"--\u003e"},{"line_number":5,"context_line":"\u003cth colspan\u003d\"100\" class\u003d\"search-header\"\u003e"},{"line_number":6,"context_line":"  \u003chz-search-bar group-classes\u003d\"input-group-sm\" icon-classes\u003d\"fa-search\"\u003e"},{"line_number":7,"context_line":"  \u003c/hz-search-bar\u003e"},{"line_number":8,"context_line":"  \u003cbutton type\u003d\"button\" class\u003d\"btn btn-sm btn-default pull-right\" ng-click\u003d\"table.editDefaults()\"\u003e"}],"source_content_type":"text/html","patch_set":51,"id":"1a4dcd0f_2aefbfea","line":5,"in_reply_to":"1a4dcd0f_7bce045b","updated":"2015-08-13 17:52:29.000000000","message":"Done","commit_id":"798f1e8e7fc5a06cfb6e270e2d7b01d04486fa03"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3c5a0250f52a258d9c89eb4e4e853e4ca986bd6c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  \u003chz-search-bar group-classes\u003d\"input-group-sm\" icon-classes\u003d\"fa-search\"\u003e"},{"line_number":7,"context_line":"  \u003c/hz-search-bar\u003e"},{"line_number":8,"context_line":"  \u003cbutton type\u003d\"button\" class\u003d\"btn btn-sm btn-default pull-right\" ng-click\u003d\"table.editDefaults()\"\u003e"},{"line_number":9,"context_line":"    Update Defaults"},{"line_number":10,"context_line":"  \u003c/button\u003e"},{"line_number":11,"context_line":"\u003c/th\u003e"}],"source_content_type":"text/html","patch_set":51,"id":"1a4dcd0f_1bf02090","line":9,"updated":"2015-08-13 15:09:20.000000000","message":"Are we not keeping the icon?  This may come up in design review as well.\n\nWe also need this to be translated.","commit_id":"798f1e8e7fc5a06cfb6e270e2d7b01d04486fa03"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"d62dc2edafb634994dc08b9715d34db4c3448090","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  \u003chz-search-bar group-classes\u003d\"input-group-sm\" icon-classes\u003d\"fa-search\"\u003e"},{"line_number":7,"context_line":"  \u003c/hz-search-bar\u003e"},{"line_number":8,"context_line":"  \u003cbutton type\u003d\"button\" class\u003d\"btn btn-sm btn-default pull-right\" ng-click\u003d\"table.editDefaults()\"\u003e"},{"line_number":9,"context_line":"    Update Defaults"},{"line_number":10,"context_line":"  \u003c/button\u003e"},{"line_number":11,"context_line":"\u003c/th\u003e"}],"source_content_type":"text/html","patch_set":51,"id":"1a4dcd0f_4aec8bf3","line":9,"in_reply_to":"1a4dcd0f_1bf02090","updated":"2015-08-13 17:52:29.000000000","message":"Done","commit_id":"798f1e8e7fc5a06cfb6e270e2d7b01d04486fa03"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"a7b8debb7c939b457e8d38a55d7103aa872f6282","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  \u003c/hz-search-bar\u003e"},{"line_number":8,"context_line":"\u003c/th\u003e"},{"line_number":9,"context_line":"\u003cth colspan\u003d\"0\"\u003e"},{"line_number":10,"context_line":"  \u003cbutton type\u003d\"button\" class\u003d\"btn btn-sm btn-default pull-right\" ng-click\u003d\"table.editDefaults()\"\u003e"},{"line_number":11,"context_line":"    \u003cspan class\u003d\"fa fa-pencil\"\u003e\u003c/span\u003e"},{"line_number":12,"context_line":"    \u003ctranslate\u003eUpdate Defaults\u003c/translate\u003e"},{"line_number":13,"context_line":"  \u003c/button\u003e"}],"source_content_type":"text/html","patch_set":55,"id":"fa1b9901_c2859aad","line":10,"updated":"2015-08-18 13:33:16.000000000","message":"I don\u0027t have a problem with using button, but why not using the action directive? seems consistent with the other angular panels.","commit_id":"c5ebe47d66a86960402d546f34c9b5ae7f445478"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"9a8c0bc4ebb3d371bb5a623fd9602980035bbef7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  \u003c/hz-search-bar\u003e"},{"line_number":8,"context_line":"\u003c/th\u003e"},{"line_number":9,"context_line":"\u003cth colspan\u003d\"0\"\u003e"},{"line_number":10,"context_line":"  \u003cbutton type\u003d\"button\" class\u003d\"btn btn-sm btn-default pull-right\" ng-click\u003d\"table.editDefaults()\"\u003e"},{"line_number":11,"context_line":"    \u003cspan class\u003d\"fa fa-pencil\"\u003e\u003c/span\u003e"},{"line_number":12,"context_line":"    \u003ctranslate\u003eUpdate Defaults\u003c/translate\u003e"},{"line_number":13,"context_line":"  \u003c/button\u003e"}],"source_content_type":"text/html","patch_set":55,"id":"fa1b9901_bf9abb6c","line":10,"in_reply_to":"fa1b9901_c2859aad","updated":"2015-08-19 17:13:34.000000000","message":"Done","commit_id":"c5ebe47d66a86960402d546f34c9b5ae7f445478"}],"openstack_dashboard/dashboards/admin/static/dashboard/admin/defaults/table/defaults-table-footer.html":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3c5a0250f52a258d9c89eb4e4e853e4ca986bd6c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  This is where we display number of items and pagination controls."},{"line_number":4,"context_line":"  Ensure colspan is greater or equal to number of column-headers."},{"line_number":5,"context_line":"--\u003e"},{"line_number":6,"context_line":"\u003ctd colspan\u003d\"100\"\u003e"},{"line_number":7,"context_line":"  \u003cspan class\u003d\"display\"\u003e{$ table.defaults.length | itemCount $}\u003c/span\u003e"},{"line_number":8,"context_line":"  \u003cdiv st-pagination\u003d\"\" st-items-by-page\u003d\"20\" st-displayed-pages\u003d\"10\"\u003e\u003c/div\u003e"},{"line_number":9,"context_line":"\u003c/td\u003e"}],"source_content_type":"text/html","patch_set":51,"id":"1a4dcd0f_56c67f9a","line":6,"updated":"2015-08-13 15:09:20.000000000","message":"colspan 0","commit_id":"798f1e8e7fc5a06cfb6e270e2d7b01d04486fa03"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"d62dc2edafb634994dc08b9715d34db4c3448090","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  This is where we display number of items and pagination controls."},{"line_number":4,"context_line":"  Ensure colspan is greater or equal to number of column-headers."},{"line_number":5,"context_line":"--\u003e"},{"line_number":6,"context_line":"\u003ctd colspan\u003d\"100\"\u003e"},{"line_number":7,"context_line":"  \u003cspan class\u003d\"display\"\u003e{$ table.defaults.length | itemCount $}\u003c/span\u003e"},{"line_number":8,"context_line":"  \u003cdiv st-pagination\u003d\"\" st-items-by-page\u003d\"20\" st-displayed-pages\u003d\"10\"\u003e\u003c/div\u003e"},{"line_number":9,"context_line":"\u003c/td\u003e"}],"source_content_type":"text/html","patch_set":51,"id":"1a4dcd0f_ca9bbb65","line":6,"in_reply_to":"1a4dcd0f_56c67f9a","updated":"2015-08-13 17:52:29.000000000","message":"Done","commit_id":"798f1e8e7fc5a06cfb6e270e2d7b01d04486fa03"}],"openstack_dashboard/dashboards/admin/static/dashboard/admin/defaults/table/defaults-table-header.html":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"3c5a0250f52a258d9c89eb4e4e853e4ca986bd6c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  Include expander if you want to inline details."},{"line_number":6,"context_line":"  Include action-col if you want to perform actions."},{"line_number":7,"context_line":"--\u003e"},{"line_number":8,"context_line":"\u003cth class\u003d\"rsp-p1\" st-sort\u003d\"name\" st-sort-default\u003d\"name\"\u003e"},{"line_number":9,"context_line":"  \u003ctranslate\u003eQuota Name\u003c/translate\u003e"},{"line_number":10,"context_line":"\u003c/th\u003e"},{"line_number":11,"context_line":""}],"source_content_type":"text/html","patch_set":51,"id":"1a4dcd0f_fb6214ac","line":8,"updated":"2015-08-13 15:09:20.000000000","message":"This doesn\u0027t seem to sort on the display name, which is confusing.","commit_id":"798f1e8e7fc5a06cfb6e270e2d7b01d04486fa03"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"d62dc2edafb634994dc08b9715d34db4c3448090","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  Include expander if you want to inline details."},{"line_number":6,"context_line":"  Include action-col if you want to perform actions."},{"line_number":7,"context_line":"--\u003e"},{"line_number":8,"context_line":"\u003cth class\u003d\"rsp-p1\" st-sort\u003d\"name\" st-sort-default\u003d\"name\"\u003e"},{"line_number":9,"context_line":"  \u003ctranslate\u003eQuota Name\u003c/translate\u003e"},{"line_number":10,"context_line":"\u003c/th\u003e"},{"line_number":11,"context_line":""}],"source_content_type":"text/html","patch_set":51,"id":"1a4dcd0f_6ac86757","line":8,"in_reply_to":"1a4dcd0f_fb6214ac","updated":"2015-08-13 17:52:29.000000000","message":"Done","commit_id":"798f1e8e7fc5a06cfb6e270e2d7b01d04486fa03"}],"openstack_dashboard/dashboards/admin/static/dashboard/admin/defaults/table/defaults-table.controller.js":[{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"a7b8debb7c939b457e8d38a55d7103aa872f6282","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        templateUrl: basePath + \u0027defaults/actions/defaults-update.html\u0027,"},{"line_number":70,"context_line":"        controller: \u0027DefaultsActionsUpdateController as ctrl\u0027,"},{"line_number":71,"context_line":"        resolve: {"},{"line_number":72,"context_line":"          defaults: function () {"},{"line_number":73,"context_line":"            return ctrl.defaultsSrc;"},{"line_number":74,"context_line":"          }"},{"line_number":75,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":55,"id":"fa1b9901_027152e0","line":72,"updated":"2015-08-18 13:33:16.000000000","message":"anonymous function","commit_id":"c5ebe47d66a86960402d546f34c9b5ae7f445478"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"9a8c0bc4ebb3d371bb5a623fd9602980035bbef7","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        templateUrl: basePath + \u0027defaults/actions/defaults-update.html\u0027,"},{"line_number":70,"context_line":"        controller: \u0027DefaultsActionsUpdateController as ctrl\u0027,"},{"line_number":71,"context_line":"        resolve: {"},{"line_number":72,"context_line":"          defaults: function () {"},{"line_number":73,"context_line":"            return ctrl.defaultsSrc;"},{"line_number":74,"context_line":"          }"},{"line_number":75,"context_line":"        }"}],"source_content_type":"text/javascript","patch_set":55,"id":"fa1b9901_313fbf88","line":72,"in_reply_to":"fa1b9901_027152e0","updated":"2015-08-19 17:13:34.000000000","message":"Done","commit_id":"c5ebe47d66a86960402d546f34c9b5ae7f445478"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"a7b8debb7c939b457e8d38a55d7103aa872f6282","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    }"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    function reloadPage() {"},{"line_number":82,"context_line":"      $window.location.reload();"},{"line_number":83,"context_line":"    }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":55,"id":"fa1b9901_a5b0b044","line":82,"updated":"2015-08-18 13:33:16.000000000","message":"shouldn\u0027t the table be responsive enough to reflect the changes without having to update the entire page?","commit_id":"c5ebe47d66a86960402d546f34c9b5ae7f445478"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"9a8c0bc4ebb3d371bb5a623fd9602980035bbef7","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    }"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    function reloadPage() {"},{"line_number":82,"context_line":"      $window.location.reload();"},{"line_number":83,"context_line":"    }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":55,"id":"fa1b9901_913ecb8a","line":82,"in_reply_to":"fa1b9901_a5b0b044","updated":"2015-08-19 17:13:34.000000000","message":"Done","commit_id":"c5ebe47d66a86960402d546f34c9b5ae7f445478"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"67c51d0b741408d7b678fa854e0cfe0aaf52fe43","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    function onGetQuotas(response) {"},{"line_number":56,"context_line":"      response.cinderQuotas.data.items.forEach(function(item) {"},{"line_number":57,"context_line":"        var defaultQuota \u003d angular.copy(item);"},{"line_number":58,"context_line":"        defaultQuota.service \u003d \u0027Volume\u0027;"},{"line_number":59,"context_line":"        ctrl.defaultsSrc.push(defaultQuota);"}],"source_content_type":"text/javascript","patch_set":83,"id":"5a2ca52d_5dd7c14a","line":56,"updated":"2015-10-16 13:51:05.000000000","message":"nit: anonymous function","commit_id":"da27ef291b39babe68699aa120c2112c7a0cc5d9"},{"author":{"_account_id":17004,"name":"KBrown","email":"kbrown@thoughtworks.com","username":"kbrown"},"change_message_id":"9a3dfa9b301f706e56155b85400769e25feee30f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    function onGetQuotas(response) {"},{"line_number":56,"context_line":"      response.cinderQuotas.data.items.forEach(function(item) {"},{"line_number":57,"context_line":"        var defaultQuota \u003d angular.copy(item);"},{"line_number":58,"context_line":"        defaultQuota.service \u003d \u0027Volume\u0027;"},{"line_number":59,"context_line":"        ctrl.defaultsSrc.push(defaultQuota);"}],"source_content_type":"text/javascript","patch_set":83,"id":"5a2ca52d_b632a6a5","line":56,"in_reply_to":"5a2ca52d_5dd7c14a","updated":"2015-10-16 19:49:46.000000000","message":"Done","commit_id":"da27ef291b39babe68699aa120c2112c7a0cc5d9"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"67c51d0b741408d7b678fa854e0cfe0aaf52fe43","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    function onGetQuotas(response) {"},{"line_number":56,"context_line":"      response.cinderQuotas.data.items.forEach(function(item) {"},{"line_number":57,"context_line":"        var defaultQuota \u003d angular.copy(item);"},{"line_number":58,"context_line":"        defaultQuota.service \u003d \u0027Volume\u0027;"},{"line_number":59,"context_line":"        ctrl.defaultsSrc.push(defaultQuota);"},{"line_number":60,"context_line":"      });"},{"line_number":61,"context_line":""}],"source_content_type":"text/javascript","patch_set":83,"id":"5a2ca52d_ddc9915a","line":58,"updated":"2015-10-16 13:51:05.000000000","message":"since there\u0027s already presentation-helper properties included in the api code, shouldn\u0027t this service property be included there too?","commit_id":"da27ef291b39babe68699aa120c2112c7a0cc5d9"},{"author":{"_account_id":17004,"name":"KBrown","email":"kbrown@thoughtworks.com","username":"kbrown"},"change_message_id":"9a3dfa9b301f706e56155b85400769e25feee30f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    function onGetQuotas(response) {"},{"line_number":56,"context_line":"      response.cinderQuotas.data.items.forEach(function(item) {"},{"line_number":57,"context_line":"        var defaultQuota \u003d angular.copy(item);"},{"line_number":58,"context_line":"        defaultQuota.service \u003d \u0027Volume\u0027;"},{"line_number":59,"context_line":"        ctrl.defaultsSrc.push(defaultQuota);"},{"line_number":60,"context_line":"      });"},{"line_number":61,"context_line":""}],"source_content_type":"text/javascript","patch_set":83,"id":"5a2ca52d_962f6a3e","line":58,"in_reply_to":"5a2ca52d_ddc9915a","updated":"2015-10-16 19:49:46.000000000","message":"Done, implemented in parent API patch","commit_id":"da27ef291b39babe68699aa120c2112c7a0cc5d9"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"67c51d0b741408d7b678fa854e0cfe0aaf52fe43","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        ctrl.defaultsSrc.push(defaultQuota);"},{"line_number":60,"context_line":"      });"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"      response.novaQuotas.data.items.forEach(function(item) {"},{"line_number":63,"context_line":"        var defaultQuota \u003d angular.copy(item);"},{"line_number":64,"context_line":"        defaultQuota.service \u003d \u0027Compute\u0027;"},{"line_number":65,"context_line":"        ctrl.defaultsSrc.push(defaultQuota);"}],"source_content_type":"text/javascript","patch_set":83,"id":"5a2ca52d_3d39a5a4","line":62,"updated":"2015-10-16 13:51:05.000000000","message":"ditto","commit_id":"da27ef291b39babe68699aa120c2112c7a0cc5d9"},{"author":{"_account_id":17004,"name":"KBrown","email":"kbrown@thoughtworks.com","username":"kbrown"},"change_message_id":"9a3dfa9b301f706e56155b85400769e25feee30f","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        ctrl.defaultsSrc.push(defaultQuota);"},{"line_number":60,"context_line":"      });"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"      response.novaQuotas.data.items.forEach(function(item) {"},{"line_number":63,"context_line":"        var defaultQuota \u003d angular.copy(item);"},{"line_number":64,"context_line":"        defaultQuota.service \u003d \u0027Compute\u0027;"},{"line_number":65,"context_line":"        ctrl.defaultsSrc.push(defaultQuota);"}],"source_content_type":"text/javascript","patch_set":83,"id":"5a2ca52d_56255259","line":62,"in_reply_to":"5a2ca52d_3d39a5a4","updated":"2015-10-16 19:49:46.000000000","message":"Done","commit_id":"da27ef291b39babe68699aa120c2112c7a0cc5d9"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"67c51d0b741408d7b678fa854e0cfe0aaf52fe43","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"      response.novaQuotas.data.items.forEach(function(item) {"},{"line_number":63,"context_line":"        var defaultQuota \u003d angular.copy(item);"},{"line_number":64,"context_line":"        defaultQuota.service \u003d \u0027Compute\u0027;"},{"line_number":65,"context_line":"        ctrl.defaultsSrc.push(defaultQuota);"},{"line_number":66,"context_line":"      });"},{"line_number":67,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":83,"id":"5a2ca52d_9dbf99a9","line":64,"updated":"2015-10-16 13:51:05.000000000","message":"ditto","commit_id":"da27ef291b39babe68699aa120c2112c7a0cc5d9"},{"author":{"_account_id":17004,"name":"KBrown","email":"kbrown@thoughtworks.com","username":"kbrown"},"change_message_id":"9a3dfa9b301f706e56155b85400769e25feee30f","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"      response.novaQuotas.data.items.forEach(function(item) {"},{"line_number":63,"context_line":"        var defaultQuota \u003d angular.copy(item);"},{"line_number":64,"context_line":"        defaultQuota.service \u003d \u0027Compute\u0027;"},{"line_number":65,"context_line":"        ctrl.defaultsSrc.push(defaultQuota);"},{"line_number":66,"context_line":"      });"},{"line_number":67,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":83,"id":"5a2ca52d_76288e33","line":64,"in_reply_to":"5a2ca52d_9dbf99a9","updated":"2015-10-16 19:49:46.000000000","message":"Done","commit_id":"da27ef291b39babe68699aa120c2112c7a0cc5d9"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"9dd29d82836a0e0415e75fde4d9195bb67921df6","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      $q.all(apis).then(onGetQuotas);"},{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    function getDefaults(item) {"},{"line_number":56,"context_line":"      var defaultQuota \u003d angular.copy(item);"},{"line_number":57,"context_line":"      ctrl.defaultsSrc.push(defaultQuota);"},{"line_number":58,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":86,"id":"3a29b11f_4d96b34d","line":55,"updated":"2015-10-19 15:05:19.000000000","message":"is this looping through the array elements really necessary?","commit_id":"c0143d5aafb51d8ba54ec1b3afe4a3b497f64233"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"e00ab92ac4290f1309f90c4d02a03e446f4e465e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      $q.all(apis).then(onGetQuotas);"},{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    function getDefaults(item) {"},{"line_number":56,"context_line":"      var defaultQuota \u003d angular.copy(item);"},{"line_number":57,"context_line":"      ctrl.defaultsSrc.push(defaultQuota);"},{"line_number":58,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":86,"id":"3a29b11f_676e23cb","line":55,"in_reply_to":"3a29b11f_4d96b34d","updated":"2015-10-19 17:13:15.000000000","message":"Done. Thanks for the feedback. It sort of slipped through when refactoring parts of the implementation.","commit_id":"c0143d5aafb51d8ba54ec1b3afe4a3b497f64233"},{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"f0fa0de15d4579eab8e5bd14e435f9b6b55c4ed0","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    function quotaGetPromise(quotaService) {"},{"line_number":74,"context_line":"      var deferred \u003d $q.defer();"},{"line_number":75,"context_line":"      serviceCatalog.ifTypeEnabled(quotaService.serviceName).then(onEnabled, onDisabled);"},{"line_number":76,"context_line":"      return deferred.promise;"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"      function onEnabled() {"}],"source_content_type":"text/javascript","patch_set":92,"id":"3a29b11f_47858ecc","line":75,"updated":"2015-10-22 13:32:42.000000000","message":"it seems that with the new error codes being raised at the api level, this verification causes unnecessary overhead.","commit_id":"7804ae891e719672a48a36e0f7ede52329ab011a"}],"openstack_dashboard/dashboards/admin/static/dashboard/admin/defaults/table/defaults-table.html":[{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"ebb2f9f6251d880c025e2123229512b8922fdb1e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      \u003c/th\u003e"},{"line_number":14,"context_line":"    \u003c/tr\u003e"},{"line_number":15,"context_line":"    \u003ctr\u003e"},{"line_number":16,"context_line":"      \u003cth class\u003d\"rsp-p1\" st-sort\u003d\"display_name\" st-sort-default\u003d\"display_name\"\u003e"},{"line_number":17,"context_line":"        \u003ctranslate\u003eQuota Name\u003c/translate\u003e"},{"line_number":18,"context_line":"      \u003c/th\u003e"},{"line_number":19,"context_line":"      \u003cth class\u003d\"rsp-p1\" st-sort\u003d\"service\"\u003e"}],"source_content_type":"text/html","patch_set":87,"id":"3a29b11f_d505327a","line":16,"updated":"2015-10-20 13:31:56.000000000","message":"nit: I think you could put translate as an attribute here and get rid of the extra tags, but not a blocker ;-)","commit_id":"1477f13c23c2754296a98ed3700bcd43c8e4b68c"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"b4d870c73a1390c5eed267375c69b8de89db186f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      \u003c/th\u003e"},{"line_number":14,"context_line":"    \u003c/tr\u003e"},{"line_number":15,"context_line":"    \u003ctr\u003e"},{"line_number":16,"context_line":"      \u003cth class\u003d\"rsp-p1\" st-sort\u003d\"display_name\" st-sort-default\u003d\"display_name\"\u003e"},{"line_number":17,"context_line":"        \u003ctranslate\u003eQuota Name\u003c/translate\u003e"},{"line_number":18,"context_line":"      \u003c/th\u003e"},{"line_number":19,"context_line":"      \u003cth class\u003d\"rsp-p1\" st-sort\u003d\"service\"\u003e"}],"source_content_type":"text/html","patch_set":87,"id":"3a29b11f_a8784af3","line":16,"in_reply_to":"3a29b11f_d505327a","updated":"2015-10-20 20:45:45.000000000","message":"Done","commit_id":"1477f13c23c2754296a98ed3700bcd43c8e4b68c"}],"openstack_dashboard/enabled/_2121_admin_defaults_panel.py":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"46cf67cd46b425c494a4df05a729392743c38895","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":96,"id":"da85f559_1cdb1d7e","updated":"2015-11-09 08:47:28.000000000","message":"You\u0027re not with HP, aren\u0027t you?\n\nBut you added an HP copyright header here....","commit_id":"4ac20fb6720e9952e0126b924a33e80881542402"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"856f719f68fb0aeadac023b6aa0e267100272e9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":96,"id":"ba8a016a_fdcec52b","in_reply_to":"da85f559_1cdb1d7e","updated":"2015-11-19 07:01:13.000000000","message":"Done","commit_id":"4ac20fb6720e9952e0126b924a33e80881542402"}]}