)]}'
{"horizon/tables/actions.py":[{"author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"change_message_id":"9babd2921ffe041f2e2eb07378d71be27ee63c34","unresolved":false,"context_lines":[{"line_number":433,"context_line":"                   ``filter_string``."},{"line_number":434,"context_line":"        \"\"\""},{"line_number":435,"context_line":"        raise NotImplementedError(\"The filter _fixed_buttons method has \""},{"line_number":436,"context_line":"                                  \"not been implemented by %s.\""},{"line_number":437,"context_line":"                                  \"\" % self.__class__)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    def _categorize(self, table, images):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B944%3D","line":436,"updated":"2013-02-12 23:15:12.000000000","message":"Indentation looks a bit out of line on these.","commit_id":"04da302cc814cef0a8a66a3c3989951cd31545f9"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"a32552d803eff47cd9dc2b1a3c29b529742ed3eb","unresolved":false,"context_lines":[{"line_number":433,"context_line":"                   ``filter_string``."},{"line_number":434,"context_line":"        \"\"\""},{"line_number":435,"context_line":"        raise NotImplementedError(\"The filter _fixed_buttons method has \""},{"line_number":436,"context_line":"                                  \"not been implemented by %s.\""},{"line_number":437,"context_line":"                                  \"\" % self.__class__)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    def _categorize(self, table, images):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B7aU%3D","line":436,"in_reply_to":"AAAAM3%2F%2B944%3D","updated":"2013-02-14 03:27:49.000000000","message":"I can\u0027t spot the issue. Could you elaborate?","commit_id":"04da302cc814cef0a8a66a3c3989951cd31545f9"}],"openstack_dashboard/dashboards/project/images_and_snapshots/images/tables.py":[{"author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"change_message_id":"9babd2921ffe041f2e2eb07378d71be27ee63c34","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"class OwnerFilter(tables.FixedFilterAction):"},{"line_number":94,"context_line":"    def _fixed_buttons(self):"},{"line_number":95,"context_line":"        def make_dict(text, tenant, icon):"},{"line_number":96,"context_line":"            return dict(text\u003dtext, value\u003dtenant, icon\u003dicon)"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B95I%3D","line":94,"updated":"2013-02-12 23:15:12.000000000","message":"I\u0027m slightly concerned that in your reference implementation here you had to override two \"internal\" methods (prefixed with underscores).\n\nThat seems to indicate that they should either not be \"internal\" or that the implementation needs some tweaking.","commit_id":"04da302cc814cef0a8a66a3c3989951cd31545f9"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"a32552d803eff47cd9dc2b1a3c29b529742ed3eb","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"class OwnerFilter(tables.FixedFilterAction):"},{"line_number":94,"context_line":"    def _fixed_buttons(self):"},{"line_number":95,"context_line":"        def make_dict(text, tenant, icon):"},{"line_number":96,"context_line":"            return dict(text\u003dtext, value\u003dtenant, icon\u003dicon)"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B7vU%3D","line":94,"in_reply_to":"AAAAM3%2F%2B95I%3D","updated":"2013-02-14 03:27:49.000000000","message":"I take an underscore prefix to mean non-public (i.e., protected) rather than private. But it makes sense to be consistent with the rest of Horizon, so I\u0027ll change it.","commit_id":"04da302cc814cef0a8a66a3c3989951cd31545f9"},{"author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"change_message_id":"9babd2921ffe041f2e2eb07378d71be27ee63c34","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        category \u003d \u0027project\u0027"},{"line_number":120,"context_line":"    elif im.owner in filter_tenant_ids():"},{"line_number":121,"context_line":"        category \u003d im.owner"},{"line_number":122,"context_line":"    elif not im.is_public:"},{"line_number":123,"context_line":"        category \u003d \u0027shared\u0027"},{"line_number":124,"context_line":"    return category"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B948%3D","line":122,"updated":"2013-02-12 23:15:12.000000000","message":"This is not exclusive with the \"project\" ownership. The image can in fact be both, and in running this code I was confused that my \"public\" list was empty because my project owned all the images...","commit_id":"04da302cc814cef0a8a66a3c3989951cd31545f9"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"a32552d803eff47cd9dc2b1a3c29b529742ed3eb","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        category \u003d \u0027project\u0027"},{"line_number":120,"context_line":"    elif im.owner in filter_tenant_ids():"},{"line_number":121,"context_line":"        category \u003d im.owner"},{"line_number":122,"context_line":"    elif not im.is_public:"},{"line_number":123,"context_line":"        category \u003d \u0027shared\u0027"},{"line_number":124,"context_line":"    return category"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B7aw%3D","line":122,"in_reply_to":"AAAAM3%2F%2B948%3D","updated":"2013-02-14 03:27:49.000000000","message":"So you want to put images in the public category regardless of tenant ownership? It\u0027s possible with some tweaking.","commit_id":"04da302cc814cef0a8a66a3c3989951cd31545f9"}]}
