)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"5319f930af563e22c17a694ecd3cc38da766c375","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Masco Kaliyamoorthy \u003cmasco.kaliyamoorthy@enovance.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-21 14:39:11 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding informative message when deleting a using volume type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently when you try to delete a volume type (which is in use) Horizon"},{"line_number":10,"context_line":"returns a generic message."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3a7e1126_be53486a","line":7,"updated":"2016-01-04 08:35:10.000000000","message":"\u0027a used volume type\u0027","commit_id":"5f12c7d0f9911582faa8a6d7d684df41e5534c5c"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"d3bb3ffac59acc9f9c52fdda5646049dba174167","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Masco Kaliyamoorthy \u003cmasco.kaliyamoorthy@enovance.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-21 14:39:11 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding informative message when deleting a using volume type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently when you try to delete a volume type (which is in use) Horizon"},{"line_number":10,"context_line":"returns a generic message."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa69d971_51a62d54","line":7,"in_reply_to":"3a7e1126_be53486a","updated":"2016-01-04 09:02:24.000000000","message":"Done","commit_id":"5f12c7d0f9911582faa8a6d7d684df41e5534c5c"}],"openstack_dashboard/api/cinder.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"5e9ac95f85b0df13915b487461532f36633e2312","unresolved":false,"context_lines":[{"line_number":465,"context_line":"    try:"},{"line_number":466,"context_line":"        return cinderclient(request).volume_types.delete(volume_type_id)"},{"line_number":467,"context_line":"    except cinder_exception.BadRequest as e:"},{"line_number":468,"context_line":"        raise exceptions.Conflict(e.message)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"def volume_type_get(request, volume_type_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_f1757163","line":468,"updated":"2015-08-21 04:55:18.000000000","message":"Should we just add a new Horizon BadRequest exception instead of re-using Conflict?","commit_id":"5682b52e49b3d4773273bfe5c4d8f565e0463d45"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"5899966e525f0e60467d33cb0e5af6860fd46cf8","unresolved":false,"context_lines":[{"line_number":465,"context_line":"    try:"},{"line_number":466,"context_line":"        return cinderclient(request).volume_types.delete(volume_type_id)"},{"line_number":467,"context_line":"    except cinder_exception.BadRequest as e:"},{"line_number":468,"context_line":"        raise exceptions.Conflict(e.message)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"def volume_type_get(request, volume_type_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_ba58068c","line":468,"in_reply_to":"fa1b9901_f1757163","updated":"2015-08-21 20:12:47.000000000","message":"conflict does not seem quite right here.","commit_id":"5682b52e49b3d4773273bfe5c4d8f565e0463d45"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"c657a72cd61aea215ad520d8ebd566714514f6bf","unresolved":false,"context_lines":[{"line_number":464,"context_line":"def volume_type_delete(request, volume_type_id):"},{"line_number":465,"context_line":"    try:"},{"line_number":466,"context_line":"        return cinderclient(request).volume_types.delete(volume_type_id)"},{"line_number":467,"context_line":"    except cinder_exception.BadRequest as e:"},{"line_number":468,"context_line":"        raise exceptions.BadRequest(e.message)"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_1b71bba8","line":467,"updated":"2015-09-02 16:59:34.000000000","message":"what are examples of cinder exception messages? \n\nI would prefer to see a localizable string here (instead of e.message), or a combination of a localizable string with e.message within that string.","commit_id":"6527e7c24c627e4ab028d2c4a8d70248fed231bb"}],"openstack_dashboard/dashboards/admin/volumes/volume_types/tables.py":[{"author":{"_account_id":8984,"name":"George Peristerakis","email":"gperiste@redhat.com","username":"peristeri"},"change_message_id":"2ff2bd44c214d0f179a2a9fd6553247273ff4e96","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def delete(self, request, obj_id):"},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            cinder.volume_type_delete(request, obj_id)"},{"line_number":71,"context_line":"        except Exception as e:"},{"line_number":72,"context_line":"            if e.code \u003d\u003d 400 and \"in use\" in e.message:"},{"line_number":73,"context_line":"                redirect_url \u003d reverse(\"horizon:admin:volumes:index\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_37c88f74","line":70,"updated":"2015-08-17 14:21:31.000000000","message":"I believe there\u0027s a specific exception that cinder throws. (class BadRequest)\n\nIt would be safer than to depend on the message, since the message content can change.","commit_id":"79ec635536ab3584d8c0551c164922537b7b8a8a"},{"author":{"_account_id":16249,"name":"Canh Truong","email":"canh.v.truong@dektech.com.au","username":"Canht"},"change_message_id":"983447c067a4a88ae07377bd1f5716d1ac665ac4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        except exceptions.Conflict as e:"},{"line_number":72,"context_line":"            redirect_url \u003d reverse(\"horizon:admin:volumes:index\")"},{"line_number":73,"context_line":"            exceptions.handle(request, e, redirect\u003dredirect_url)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class CreateVolumeTypeEncryption(tables.LinkAction):"},{"line_number":77,"context_line":"    name \u003d \"create_encryption\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_6144d373","line":74,"updated":"2015-08-18 11:31:13.000000000","message":"I\u0027m not sure if there are another case of exceptions.Conflict. Do you think that adding more Exception as general for these cases?","commit_id":"5682b52e49b3d4773273bfe5c4d8f565e0463d45"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"5aa63687015f9aee0eeedb4bcec1e17a736c2ec2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        except exceptions.Conflict as e:"},{"line_number":72,"context_line":"            redirect_url \u003d reverse(\"horizon:admin:volumes:index\")"},{"line_number":73,"context_line":"            exceptions.handle(request, e, redirect\u003dredirect_url)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class CreateVolumeTypeEncryption(tables.LinkAction):"},{"line_number":77,"context_line":"    name \u003d \"create_encryption\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_bf652646","line":74,"in_reply_to":"fa1b9901_24b10990","updated":"2015-08-18 12:17:29.000000000","message":"they are catched at https://github.com/openstack/horizon/blob/master/horizon/tables/actions.py#L827","commit_id":"5682b52e49b3d4773273bfe5c4d8f565e0463d45"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"0fecb266bee3a85dce8f23329278cd9e7fa9b1e1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        except exceptions.Conflict as e:"},{"line_number":72,"context_line":"            redirect_url \u003d reverse(\"horizon:admin:volumes:index\")"},{"line_number":73,"context_line":"            exceptions.handle(request, e, redirect\u003dredirect_url)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class CreateVolumeTypeEncryption(tables.LinkAction):"},{"line_number":77,"context_line":"    name \u003d \"create_encryption\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_62a04ea0","line":74,"in_reply_to":"fa1b9901_6144d373","updated":"2015-08-18 14:42:34.000000000","message":"Canh, ideally one would add a different error message, when a different exception occurs.","commit_id":"5682b52e49b3d4773273bfe5c4d8f565e0463d45"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"7cf13ea7ad041fc033170e0c9d3e356088a5a0d6","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        except exceptions.Conflict as e:"},{"line_number":72,"context_line":"            redirect_url \u003d reverse(\"horizon:admin:volumes:index\")"},{"line_number":73,"context_line":"            exceptions.handle(request, e, redirect\u003dredirect_url)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class CreateVolumeTypeEncryption(tables.LinkAction):"},{"line_number":77,"context_line":"    name \u003d \"create_encryption\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_64e701e5","line":74,"in_reply_to":"fa1b9901_6144d373","updated":"2015-08-18 11:49:03.000000000","message":"there is no more conflict type exceptions from cinder client. for more info please refer https://github.com/openstack/python-cinderclient/blob/master/cinderclient/exceptions.py","commit_id":"5682b52e49b3d4773273bfe5c4d8f565e0463d45"},{"author":{"_account_id":16249,"name":"Canh Truong","email":"canh.v.truong@dektech.com.au","username":"Canht"},"change_message_id":"21614667d80abdf698727b58e032807f5ebc6106","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        except exceptions.Conflict as e:"},{"line_number":72,"context_line":"            redirect_url \u003d reverse(\"horizon:admin:volumes:index\")"},{"line_number":73,"context_line":"            exceptions.handle(request, e, redirect\u003dredirect_url)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class CreateVolumeTypeEncryption(tables.LinkAction):"},{"line_number":77,"context_line":"    name \u003d \"create_encryption\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_5910784e","line":74,"in_reply_to":"fa1b9901_62a04ea0","updated":"2015-08-19 08:45:29.000000000","message":"ok.","commit_id":"5682b52e49b3d4773273bfe5c4d8f565e0463d45"},{"author":{"_account_id":16249,"name":"Canh Truong","email":"canh.v.truong@dektech.com.au","username":"Canht"},"change_message_id":"b5d49ce67c7284204b13d3b4a0cbed60540fc178","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        except exceptions.Conflict as e:"},{"line_number":72,"context_line":"            redirect_url \u003d reverse(\"horizon:admin:volumes:index\")"},{"line_number":73,"context_line":"            exceptions.handle(request, e, redirect\u003dredirect_url)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class CreateVolumeTypeEncryption(tables.LinkAction):"},{"line_number":77,"context_line":"    name \u003d \"create_encryption\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa1b9901_24b10990","line":74,"in_reply_to":"fa1b9901_64e701e5","updated":"2015-08-18 11:56:49.000000000","message":"how about exception code : 401, 403, 404, .... (in the link)?","commit_id":"5682b52e49b3d4773273bfe5c4d8f565e0463d45"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"e36b161fef4358ff2f66c84642b2a8384aad1dd4","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            cinder.volume_type_delete(request, obj_id)"},{"line_number":83,"context_line":"        except exceptions.BadRequest as e:"},{"line_number":84,"context_line":"            redirect_url \u003d reverse(\"horizon:admin:volumes:index\")"},{"line_number":85,"context_line":"            exceptions.handle(request, e, redirect\u003dredirect_url)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_6b79b8c7","line":84,"range":{"start_line":84,"start_character":36,"end_line":84,"end_character":43},"updated":"2015-12-29 06:38:07.000000000","message":"Is it better to redirect to \"horizon:admin:volumes:volume_types_tab\"?","commit_id":"5f12c7d0f9911582faa8a6d7d684df41e5534c5c"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"d3bb3ffac59acc9f9c52fdda5646049dba174167","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            cinder.volume_type_delete(request, obj_id)"},{"line_number":83,"context_line":"        except exceptions.BadRequest as e:"},{"line_number":84,"context_line":"            redirect_url \u003d reverse(\"horizon:admin:volumes:index\")"},{"line_number":85,"context_line":"            exceptions.handle(request, e, redirect\u003dredirect_url)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_f1bc016e","line":84,"range":{"start_line":84,"start_character":36,"end_line":84,"end_character":43},"in_reply_to":"1a7b0d38_6b79b8c7","updated":"2016-01-04 09:02:24.000000000","message":"by default it will go to the last visited tab.","commit_id":"5f12c7d0f9911582faa8a6d7d684df41e5534c5c"}],"openstack_dashboard/dashboards/admin/volumes/volume_types/tests.py":[{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"e36b161fef4358ff2f66c84642b2a8384aad1dd4","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        self.mox.ReplayAll()"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        res \u003d self.client.post("},{"line_number":124,"context_line":"            reverse(\u0027horizon:admin:volumes:volumes_tab\u0027),"},{"line_number":125,"context_line":"            formData)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        redirect \u003d reverse(\u0027horizon:admin:volumes:volumes_tab\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_4b7cfcb4","line":124,"range":{"start_line":124,"start_character":42,"end_line":124,"end_character":43},"updated":"2015-12-29 06:38:07.000000000","message":"Is it better to redirect to \"horizon:admin:volumes:volume_types_tab\"?","commit_id":"5f12c7d0f9911582faa8a6d7d684df41e5534c5c"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"e36b161fef4358ff2f66c84642b2a8384aad1dd4","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            reverse(\u0027horizon:admin:volumes:volumes_tab\u0027),"},{"line_number":125,"context_line":"            formData)"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        redirect \u003d reverse(\u0027horizon:admin:volumes:volumes_tab\u0027)"},{"line_number":128,"context_line":"        self.assertNoFormErrors(res)"},{"line_number":129,"context_line":"        self.assertRedirectsNoFollow(res, redirect)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a7b0d38_eb4b6885","line":127,"range":{"start_line":127,"start_character":28,"end_line":127,"end_character":35},"updated":"2015-12-29 06:38:07.000000000","message":"ditto","commit_id":"5f12c7d0f9911582faa8a6d7d684df41e5534c5c"}]}
