)]}'
{"doc/source/topics/settings.rst":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"1223911a2ef476fd522daba6c470e571dc776eef","unresolved":false,"context_lines":[{"line_number":579,"context_line":"Setting ``can_set_password`` to ``True`` will enable the option to set"},{"line_number":580,"context_line":"an administrator password when launching or rebuilding an instance."},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"Setting ``enable_quotas`` to ``False`` will make Horizon to treat all Nova"},{"line_number":583,"context_line":"quotas as disabled, thus it won\u0027t try to modify them. By default quotas are"},{"line_number":584,"context_line":"enabled."},{"line_number":585,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_a9905496","line":582,"updated":"2015-08-25 12:06:34.000000000","message":"\"will make Horizon treat\" or \"will cause Horizon to treat\"","commit_id":"cdbe73d6ae3986da4713bd1bc666d821afed923b"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"020fb0e6e0cd0d513e1998df78d1c78583882bc5","unresolved":false,"context_lines":[{"line_number":579,"context_line":"Setting ``can_set_password`` to ``True`` will enable the option to set"},{"line_number":580,"context_line":"an administrator password when launching or rebuilding an instance."},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"Setting ``enable_quotas`` to ``False`` will make Horizon to treat all Nova"},{"line_number":583,"context_line":"quotas as disabled, thus it won\u0027t try to modify them. By default quotas are"},{"line_number":584,"context_line":"enabled."},{"line_number":585,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa1b9901_b043d0ae","line":582,"in_reply_to":"fa1b9901_a9905496","updated":"2015-08-25 16:04:16.000000000","message":"Done","commit_id":"cdbe73d6ae3986da4713bd1bc666d821afed923b"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"bde0fd61dc3be2c890f11dc84cb8018b71b6774f","unresolved":false,"context_lines":[{"line_number":580,"context_line":"an administrator password when launching or rebuilding an instance."},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"Setting ``enable_quotas`` to ``False`` will make Horizon treat all Nova"},{"line_number":583,"context_line":"quotas as disabled, thus it won\u0027t try to modify them. By default quotas are"},{"line_number":584,"context_line":"enabled."},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"``OPENSTACK_IMAGE_BACKEND``"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da20952f_af06f283","line":583,"updated":"2015-08-29 18:51:08.000000000","message":"Ultra nit picky here, so sorry ... but it should have a comma, like so:\n\nBy default, quotas are enabled.","commit_id":"61c58bca527ba9f781b44127f43326701a5f1aef"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8d435e661d848fdd3a4e63f87f3abbfa24a8c019","unresolved":false,"context_lines":[{"line_number":580,"context_line":"an administrator password when launching or rebuilding an instance."},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"Setting ``enable_quotas`` to ``False`` will make Horizon treat all Nova"},{"line_number":583,"context_line":"quotas as disabled, thus it won\u0027t try to modify them. By default quotas are"},{"line_number":584,"context_line":"enabled."},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"``OPENSTACK_IMAGE_BACKEND``"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da20952f_0bd2525c","line":583,"in_reply_to":"da20952f_af06f283","updated":"2015-08-31 11:00:25.000000000","message":"Done","commit_id":"61c58bca527ba9f781b44127f43326701a5f1aef"}],"openstack_dashboard/api/nova.py":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c5ef361cd9c21887881226ec2651c5444c3a31da","unresolved":false,"context_lines":[{"line_number":810,"context_line":""},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"def tenant_quota_update(request, tenant_id, **kwargs):"},{"line_number":813,"context_line":"    if kwargs:"},{"line_number":814,"context_line":"        novaclient(request).quotas.update(tenant_id, **kwargs)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"1aa78d24_868dc4d5","line":813,"updated":"2016-07-14 19:38:24.000000000","message":"This looks a little weird with no explanatory comment. Why would a caller invoke this function at all with no kwargs if that won\u0027t do anything?","commit_id":"ad735db4cdf9258c4a3ad368e395a6a9ece916a3"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"40ceeb591ba6295fe43f07690c73a7e347f1f869","unresolved":false,"context_lines":[{"line_number":810,"context_line":""},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"def tenant_quota_update(request, tenant_id, **kwargs):"},{"line_number":813,"context_line":"    if kwargs:"},{"line_number":814,"context_line":"        novaclient(request).quotas.update(tenant_id, **kwargs)"},{"line_number":815,"context_line":""},{"line_number":816,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"1aa78d24_29b5c17d","line":813,"in_reply_to":"1aa78d24_868dc4d5","updated":"2016-07-14 19:59:57.000000000","message":"Given that kwargs are filtered in the caller to not contain disabled quotas, that perfectly makes sense - if kwargs is an empty dictionary (which is False in `if` context), do not call nova.","commit_id":"ad735db4cdf9258c4a3ad368e395a6a9ece916a3"}],"openstack_dashboard/dashboards/identity/projects/workflows.py":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c5ef361cd9c21887881226ec2651c5444c3a31da","unresolved":false,"context_lines":[{"line_number":387,"context_line":"    def _update_project_quota(self, request, data, project_id):"},{"line_number":388,"context_line":"        disabled_quotas \u003d quotas.get_disabled_quotas(request)"},{"line_number":389,"context_line":"        nova_data \u003d {key: data[key] for key"},{"line_number":390,"context_line":"                     in set(quotas.NOVA_QUOTA_FIELDS) - disabled_quotas}"},{"line_number":391,"context_line":"        nova.tenant_quota_update(request, project_id, **nova_data)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        if cinder.is_volume_service_enabled(request):"}],"source_content_type":"text/x-python","patch_set":32,"id":"1aa78d24_0614344b","line":390,"updated":"2016-07-14 19:38:24.000000000","message":"This reads weirdly to me, I\u0027m afraid. Perhaps:\n\n   nova_data \u003d {key: data[key]\n                for key in set(quotas.NOVA_QUOTA_FIELDS) - disabled_quotas}","commit_id":"ad735db4cdf9258c4a3ad368e395a6a9ece916a3"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"40ceeb591ba6295fe43f07690c73a7e347f1f869","unresolved":false,"context_lines":[{"line_number":387,"context_line":"    def _update_project_quota(self, request, data, project_id):"},{"line_number":388,"context_line":"        disabled_quotas \u003d quotas.get_disabled_quotas(request)"},{"line_number":389,"context_line":"        nova_data \u003d {key: data[key] for key"},{"line_number":390,"context_line":"                     in set(quotas.NOVA_QUOTA_FIELDS) - disabled_quotas}"},{"line_number":391,"context_line":"        nova.tenant_quota_update(request, project_id, **nova_data)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        if cinder.is_volume_service_enabled(request):"}],"source_content_type":"text/x-python","patch_set":32,"id":"1aa78d24_89a4b54b","line":390,"in_reply_to":"1aa78d24_0614344b","updated":"2016-07-14 19:59:57.000000000","message":"Done","commit_id":"ad735db4cdf9258c4a3ad368e395a6a9ece916a3"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"cc2547bae05b576ce041b486eb58320ebfcd646f","unresolved":false,"context_lines":[{"line_number":386,"context_line":"class CommonQuotaWorkflow(workflows.Workflow):"},{"line_number":387,"context_line":"    def _update_project_quota(self, request, data, project_id):"},{"line_number":388,"context_line":"        disabled_quotas \u003d quotas.get_disabled_quotas(request)"},{"line_number":389,"context_line":"        nova_data \u003d {key: data[key] for key in"},{"line_number":390,"context_line":"                     set(quotas.NOVA_QUOTA_FIELDS) - disabled_quotas}"},{"line_number":391,"context_line":"        nova.tenant_quota_update(request, project_id, **nova_data)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        if cinder.is_volume_service_enabled(request):"}],"source_content_type":"text/x-python","patch_set":34,"id":"1aa78d24_7d0bff2b","line":390,"range":{"start_line":389,"start_character":20,"end_line":390,"end_character":69},"updated":"2016-07-14 21:31:35.000000000","message":"Sorry, Richard, pep8 check doesn\u0027t agree with the line wrapping you suggested.","commit_id":"c8e512755a89fc57215f8f525636cfc14860cd8b"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"717abd66ac365453bea4a95a84b2f070baf94b37","unresolved":false,"context_lines":[{"line_number":387,"context_line":"    def _update_project_quota(self, request, data, project_id):"},{"line_number":388,"context_line":"        disabled_quotas \u003d quotas.get_disabled_quotas(request)"},{"line_number":389,"context_line":"        nova_data \u003d {key: data[key] for key in"},{"line_number":390,"context_line":"                     set(quotas.NOVA_QUOTA_FIELDS) - disabled_quotas}"},{"line_number":391,"context_line":"        nova.tenant_quota_update(request, project_id, **nova_data)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        if cinder.is_volume_service_enabled(request):"}],"source_content_type":"text/x-python","patch_set":34,"id":"dada55a8_523aa5ce","line":390,"in_reply_to":"1aa78d24_7d0bff2b","updated":"2016-07-18 01:48:18.000000000","message":"Ugh, stupid pep8 ;-)","commit_id":"c8e512755a89fc57215f8f525636cfc14860cd8b"}],"openstack_dashboard/local/local_settings.py.example":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c5ef361cd9c21887881226ec2651c5444c3a31da","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    \u0027can_set_mount_point\u0027: False,"},{"line_number":251,"context_line":"    \u0027can_set_password\u0027: False,"},{"line_number":252,"context_line":"    \u0027requires_keypair\u0027: False,"},{"line_number":253,"context_line":"    \u0027enable_quotas\u0027: True"},{"line_number":254,"context_line":"}"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"# The OPENSTACK_CINDER_FEATURES settings can be used to enable optional"}],"source_content_type":"application/octet-stream","patch_set":32,"id":"1aa78d24_6912295a","line":253,"updated":"2016-07-14 19:38:24.000000000","message":"\"enable_quotas\" won\u0027t affect anything except nova, correct? I think this should be named \"enable_nova_quotas\".","commit_id":"ad735db4cdf9258c4a3ad368e395a6a9ece916a3"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"40ceeb591ba6295fe43f07690c73a7e347f1f869","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    \u0027can_set_mount_point\u0027: False,"},{"line_number":251,"context_line":"    \u0027can_set_password\u0027: False,"},{"line_number":252,"context_line":"    \u0027requires_keypair\u0027: False,"},{"line_number":253,"context_line":"    \u0027enable_quotas\u0027: True"},{"line_number":254,"context_line":"}"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"# The OPENSTACK_CINDER_FEATURES settings can be used to enable optional"}],"source_content_type":"application/octet-stream","patch_set":32,"id":"1aa78d24_c9323d0f","line":253,"in_reply_to":"1aa78d24_6912295a","updated":"2016-07-14 19:59:57.000000000","message":"I think that there is a tacit knowledge that all HYPERVISOR features map to Nova features.","commit_id":"ad735db4cdf9258c4a3ad368e395a6a9ece916a3"}],"openstack_dashboard/usage/quotas.py":[{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"d41b1ac9c3b14bb58f8ab9a9b29c621469059bb5","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    # Nova"},{"line_number":229,"context_line":"    if not nova.can_set_quotas():"},{"line_number":230,"context_line":"        disabled_quotas |\u003d set(NOVA_QUOTA_FIELDS)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    # Cinder"},{"line_number":233,"context_line":"    if not base.is_service_enabled(request, \u0027volume\u0027):"}],"source_content_type":"text/x-python","patch_set":9,"id":"da20952f_f4f51583","line":230,"updated":"2015-08-27 09:50:47.000000000","message":"+1 for using set for disabled_quotas.\n\nBut I\u0027d rather use \n disabled_quotas.update(NOVA_QUOTA_FIELDS)\n\nthroughout the file. It feels more pythonic (your code looks more like it\u0027s js \u003d)) and would eliminate the need to explicitly convert NOVA_QUOTA_FIELDS to set.\nOtherwise usage of sets feels forced to me.\nWhat do you think?","commit_id":"44606c512016093292dffea84d59c78df8c38c40"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"661bd381afa35a2ad5d953f12048696ba200f1e0","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    # Nova"},{"line_number":229,"context_line":"    if not nova.can_set_quotas():"},{"line_number":230,"context_line":"        disabled_quotas |\u003d set(NOVA_QUOTA_FIELDS)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    # Cinder"},{"line_number":233,"context_line":"    if not base.is_service_enabled(request, \u0027volume\u0027):"}],"source_content_type":"text/x-python","patch_set":9,"id":"da20952f_6bcebbb5","line":230,"in_reply_to":"da20952f_f4f51583","updated":"2015-08-28 11:51:52.000000000","message":"Done","commit_id":"44606c512016093292dffea84d59c78df8c38c40"}]}
