)]}'
{"horizon/tables/views.py":[{"author":{"_account_id":9647,"name":"Justin Pomeroy","email":"jpomero@linux.vnet.ibm.com","username":"jpomero"},"change_message_id":"cba91681b6d57aee33278585ca86b538d9eb2df6","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        return handled"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"class TableFilterMixin(object):"},{"line_number":130,"context_line":"    \"\"\"A generic mixin which provides methods for filtering in a DataTable.\"\"\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def get_server_filter_info(self, request, table):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_1e6c1207","line":129,"updated":"2015-09-10 20:53:06.000000000","message":"Both the DataTableView and TabbedTableView inherit from MultiTableMixin so why not just add these filtering methods to the MultiTableMixin?","commit_id":"af51f8d06a40706808aa4051fbe3eac4c312abb5"},{"author":{"_account_id":7187,"name":"Janet Yu","email":"jwy@cs.stanford.edu","username":"jwy"},"change_message_id":"e2501975bd4f13063d4d61b49e794b2f32646200","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        return handled"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"class TableFilterMixin(object):"},{"line_number":130,"context_line":"    \"\"\"A generic mixin which provides methods for filtering in a DataTable.\"\"\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def get_server_filter_info(self, request, table):"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_32e4a1a6","line":129,"in_reply_to":"da20952f_1e6c1207","updated":"2015-09-11 03:34:52.000000000","message":"I kept it separate in case other classes wanted to use the filtering mixin, but yeah, that would work.","commit_id":"af51f8d06a40706808aa4051fbe3eac4c312abb5"},{"author":{"_account_id":9647,"name":"Justin Pomeroy","email":"jpomero@linux.vnet.ibm.com","username":"jpomero"},"change_message_id":"cba91681b6d57aee33278585ca86b538d9eb2df6","unresolved":false,"context_lines":[{"line_number":129,"context_line":"class TableFilterMixin(object):"},{"line_number":130,"context_line":"    \"\"\"A generic mixin which provides methods for filtering in a DataTable.\"\"\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def get_server_filter_info(self, request, table):"},{"line_number":133,"context_line":"        filter_action \u003d table._meta._filter_action"},{"line_number":134,"context_line":"        if filter_action is None or filter_action.filter_type !\u003d \u0027server\u0027:"},{"line_number":135,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_390b3026","line":132,"updated":"2015-09-10 20:53:06.000000000","message":"It might be nice to have the table argument be optional and default to None, and then you can check if it\u0027s None first thing in the method and set it to self.get_table() if it is.  That way all the existing callers of these methods wouldn\u0027t need to change.","commit_id":"af51f8d06a40706808aa4051fbe3eac4c312abb5"},{"author":{"_account_id":7187,"name":"Janet Yu","email":"jwy@cs.stanford.edu","username":"jwy"},"change_message_id":"e2501975bd4f13063d4d61b49e794b2f32646200","unresolved":false,"context_lines":[{"line_number":129,"context_line":"class TableFilterMixin(object):"},{"line_number":130,"context_line":"    \"\"\"A generic mixin which provides methods for filtering in a DataTable.\"\"\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def get_server_filter_info(self, request, table):"},{"line_number":133,"context_line":"        filter_action \u003d table._meta._filter_action"},{"line_number":134,"context_line":"        if filter_action is None or filter_action.filter_type !\u003d \u0027server\u0027:"},{"line_number":135,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_b2f8b14b","line":132,"in_reply_to":"da20952f_390b3026","updated":"2015-09-11 03:34:52.000000000","message":"Good idea.","commit_id":"af51f8d06a40706808aa4051fbe3eac4c312abb5"},{"author":{"_account_id":9647,"name":"Justin Pomeroy","email":"jpomero@linux.vnet.ibm.com","username":"jpomero"},"change_message_id":"cba91681b6d57aee33278585ca86b538d9eb2df6","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        }"},{"line_number":156,"context_line":"        return filter_info"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def handle_server_filter(self, request, table):"},{"line_number":159,"context_line":"        \"\"\"Update the table server filter information in the session and"},{"line_number":160,"context_line":"        determine if the filter has been changed."},{"line_number":161,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_b92e608a","line":158,"updated":"2015-09-10 20:53:06.000000000","message":"same here","commit_id":"af51f8d06a40706808aa4051fbe3eac4c312abb5"},{"author":{"_account_id":9647,"name":"Justin Pomeroy","email":"jpomero@linux.vnet.ibm.com","username":"jpomero"},"change_message_id":"cba91681b6d57aee33278585ca86b538d9eb2df6","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            request.session[filter_info[\u0027field_param\u0027]] \u003d filter_info[\u0027field\u0027]"},{"line_number":168,"context_line":"        return filter_info[\u0027changed\u0027]"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def update_server_filter_action(self, request, table):"},{"line_number":171,"context_line":"        \"\"\"Update the table server side filter action based on the current"},{"line_number":172,"context_line":"        filter. The filter info may be stored in the session and this will"},{"line_number":173,"context_line":"        restore it."}],"source_content_type":"text/x-python","patch_set":4,"id":"da20952f_594ce475","line":170,"updated":"2015-09-10 20:53:06.000000000","message":"same here","commit_id":"af51f8d06a40706808aa4051fbe3eac4c312abb5"}]}
