)]}'
{"openstack_dashboard/api/nova.py":[{"author":{"_account_id":14649,"name":"Jingjing Ren","email":"jingjing_ren@symantec.com","username":"jingjing_ren"},"change_message_id":"7c596c797634ce6cb81846a4666ff42814cb749c","unresolved":false,"context_lines":[{"line_number":868,"context_line":"    return novaclient(request).availability_zones.list(detailed\u003ddetailed)"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"def server_group_list(request, all_projects\u003dFalse):"},{"line_number":872,"context_line":"    return novaclient(request).server_groups.list()"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_ad2664b8","line":871,"updated":"2015-09-14 22:34:50.000000000","message":"Why are we passing all_projects parameter if it is not used in the function?","commit_id":"d0070b031771e732b97c07a496b123e589987e5f"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"41d8b9ed0e860e1f64288da84a5876025f859a69","unresolved":false,"context_lines":[{"line_number":868,"context_line":"    return novaclient(request).availability_zones.list(detailed\u003ddetailed)"},{"line_number":869,"context_line":""},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"def server_group_list(request, all_projects\u003dFalse):"},{"line_number":872,"context_line":"    return novaclient(request).server_groups.list()"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_500abb27","line":871,"in_reply_to":"ba15a1d1_ad2664b8","updated":"2015-09-14 23:39:45.000000000","message":"Good point, it\u0027s not needed here.  I\u0027ll remove it in the next PS.","commit_id":"d0070b031771e732b97c07a496b123e589987e5f"}],"openstack_dashboard/dashboards/project/instances/utils.py":[{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"be7c48b1390dc5542be59ceb8011624a790bb0f2","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    (id, name) tuples."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    :param request: django http request object"},{"line_number":177,"context_line":"    :param include_empty_option: flag to include a empty tuple in the front of"},{"line_number":178,"context_line":"    the list"},{"line_number":179,"context_line":"    :return: list of (id, name) tuples"},{"line_number":180,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_7124dd0b","line":177,"updated":"2015-10-11 09:39:23.000000000","message":"i don\u0027t think that we need the param, [(\"\", _(\"Select Server Group\"))] is fine for me","commit_id":"b10f75c71d2bdfc200aef25561c1781b9d93b4ec"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"5a39c6cdc3b9f961abb53c54f3ccff2e9f943144","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    (id, name) tuples."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    :param request: django http request object"},{"line_number":177,"context_line":"    :param include_empty_option: flag to include a empty tuple in the front of"},{"line_number":178,"context_line":"    the list"},{"line_number":179,"context_line":"    :return: list of (id, name) tuples"},{"line_number":180,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_9c2fd4f5","line":177,"in_reply_to":"7a2fa921_7124dd0b","updated":"2015-10-20 18:52:59.000000000","message":"Done","commit_id":"b10f75c71d2bdfc200aef25561c1781b9d93b4ec"}],"openstack_dashboard/dashboards/project/instances/workflows/create_instance.py":[{"author":{"_account_id":14649,"name":"Jingjing Ren","email":"jingjing_ren@symantec.com","username":"jingjing_ren"},"change_message_id":"7c596c797634ce6cb81846a4666ff42814cb749c","unresolved":false,"context_lines":[{"line_number":925,"context_line":"        avail_zone \u003d context.get(\u0027availability_zone\u0027, None)"},{"line_number":926,"context_line":""},{"line_number":927,"context_line":"        scheduler_hints \u003d {}"},{"line_number":928,"context_line":"        server_group \u003d context.get(\u0027server_group\u0027, \u0027\u0027)"},{"line_number":929,"context_line":"        if server_group:"},{"line_number":930,"context_line":"            scheduler_hints[\u0027group\u0027] \u003d server_group"},{"line_number":931,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_cd52b813","line":928,"updated":"2015-09-14 22:34:50.000000000","message":"Should we use None instead of \u0027\u0027? Just to be consistent with the two variables above.","commit_id":"d0070b031771e732b97c07a496b123e589987e5f"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"41d8b9ed0e860e1f64288da84a5876025f859a69","unresolved":false,"context_lines":[{"line_number":925,"context_line":"        avail_zone \u003d context.get(\u0027availability_zone\u0027, None)"},{"line_number":926,"context_line":""},{"line_number":927,"context_line":"        scheduler_hints \u003d {}"},{"line_number":928,"context_line":"        server_group \u003d context.get(\u0027server_group\u0027, \u0027\u0027)"},{"line_number":929,"context_line":"        if server_group:"},{"line_number":930,"context_line":"            scheduler_hints[\u0027group\u0027] \u003d server_group"},{"line_number":931,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_50239bbd","line":928,"in_reply_to":"ba15a1d1_cd52b813","updated":"2015-09-14 23:39:45.000000000","message":"Done","commit_id":"d0070b031771e732b97c07a496b123e589987e5f"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"225c37aa9455f1b592b61ab83c67970663598595","unresolved":false,"context_lines":[{"line_number":857,"context_line":""},{"line_number":858,"context_line":"    def populate_server_group_choices(self, request, context):"},{"line_number":859,"context_line":"        if api.nova.extension_supported(\"ServerGroups\", request):"},{"line_number":860,"context_line":"            return instance_utils.server_group_field_data(request)"},{"line_number":861,"context_line":"        return []"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_c30fd086","line":860,"range":{"start_line":860,"start_character":19,"end_line":860,"end_character":66},"updated":"2016-05-03 09:49:56.000000000","message":"how about moving this to __init__ method above to be more clean and avoid duplicate check ServerGroups extension_supported, like:\n\n  if not api.nova.extension_supported(\"ServerGroups\", request):\n    del self.fields[\u0027server_group\u0027]\n  else:\n    self.fields[\u0027server_group\u0027].choices \u003d instance_utils.server_group_field_data(request)","commit_id":"0dfeccc3893475e55cc35d1ed64d3e03ba1e3429"},{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"3a41c398788fd8494d379c7ed60c0a1fee70c845","unresolved":false,"context_lines":[{"line_number":857,"context_line":""},{"line_number":858,"context_line":"    def populate_server_group_choices(self, request, context):"},{"line_number":859,"context_line":"        if api.nova.extension_supported(\"ServerGroups\", request):"},{"line_number":860,"context_line":"            return instance_utils.server_group_field_data(request)"},{"line_number":861,"context_line":"        return []"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_93922af5","line":860,"range":{"start_line":860,"start_character":19,"end_line":860,"end_character":66},"in_reply_to":"1a122d0e_c30fd086","updated":"2016-05-03 22:59:58.000000000","message":"Good idea for simplification. Done.","commit_id":"0dfeccc3893475e55cc35d1ed64d3e03ba1e3429"}]}
