)]}'
{"openstack_dashboard/static/app/core/images/actions/launch-instance.service.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"fab0df57fff8b9c5fb533ae726f1851e5d5405f2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    launchInstanceModal,"},{"line_number":41,"context_line":"    $qExtensions"},{"line_number":42,"context_line":"  ) {"},{"line_number":43,"context_line":"    var NON_BOOTABLE_IMAGE_TYPES \u003d [\u0027aki\u0027, \u0027ari\u0027];"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    var service \u003d {"},{"line_number":46,"context_line":"      perform: perform,"}],"source_content_type":"text/javascript","patch_set":55,"id":"da6ed579_70f82fe6","line":43,"range":{"start_line":43,"start_character":47,"end_line":43,"end_character":50},"updated":"2016-01-12 23:16:11.000000000","message":"can we add as a constant? https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance.module.js#L33","commit_id":"0a648774a1731c8fba937193edd8c841a288de9d"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"05ff54f94071c4fbe7e56d8effd612ac75604fd1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    launchInstanceModal,"},{"line_number":41,"context_line":"    $qExtensions"},{"line_number":42,"context_line":"  ) {"},{"line_number":43,"context_line":"    var NON_BOOTABLE_IMAGE_TYPES \u003d [\u0027aki\u0027, \u0027ari\u0027];"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    var service \u003d {"},{"line_number":46,"context_line":"      perform: perform,"}],"source_content_type":"text/javascript","patch_set":55,"id":"da6ed579_00f718f6","line":43,"range":{"start_line":43,"start_character":47,"end_line":43,"end_character":50},"in_reply_to":"da6ed579_70f82fe6","updated":"2016-01-13 00:24:18.000000000","message":"Done","commit_id":"0a648774a1731c8fba937193edd8c841a288de9d"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"7c37c967c9fe946750c5f1b7dd683911dd9467ee","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      launchInstanceModal.open({"},{"line_number":56,"context_line":"        successUrl: \u0027/project/instances\u0027,"},{"line_number":57,"context_line":"        \u0027imageId\u0027: image.id"},{"line_number":58,"context_line":"      });"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":"    function allowed(image) {"},{"line_number":61,"context_line":"      return $q.all([isBootable(image), isActive(image)]);"}],"source_content_type":"text/javascript","patch_set":64,"id":"5a5ae5dd_7ab96614","line":58,"updated":"2016-02-06 15:22:24.000000000","message":"nit: add whitespace between functions.","commit_id":"bf6be3e08bd61cba4b6d70d93ec6e228162a2b1f"}],"openstack_dashboard/static/app/core/images/actions/update-metadata.action.service.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e8c93e1c89612bff5ebbf91d2e20fe553a3639fa","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    function open(image) {"},{"line_number":59,"context_line":"      metadataModal.open(\u0027image\u0027, image.id)"},{"line_number":60,"context_line":"        .result"},{"line_number":61,"context_line":"        .then(function success() {"},{"line_number":62,"context_line":"          scope.$emit(events.updateMetadataSuccess, [image.id]);"},{"line_number":63,"context_line":"        });"},{"line_number":64,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":3,"id":"da20952f_6732faa8","line":61,"updated":"2015-09-01 04:02:58.000000000","message":"Please extract out named function to meet style guide.\n\nhttps://github.com/johnpapa/angular-styleguide#style-y024","commit_id":"28b93566587c600eeb5639c9faeab6921e8913f6"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"fb8b7a7e253907957810ad280a3a07574910d412","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    function open(image) {"},{"line_number":59,"context_line":"      metadataModal.open(\u0027image\u0027, image.id)"},{"line_number":60,"context_line":"        .result"},{"line_number":61,"context_line":"        .then(function success() {"},{"line_number":62,"context_line":"          scope.$emit(events.updateMetadataSuccess, [image.id]);"},{"line_number":63,"context_line":"        });"},{"line_number":64,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":3,"id":"da20952f_6f008c02","line":61,"in_reply_to":"da20952f_6732faa8","updated":"2015-09-01 06:53:22.000000000","message":"Done","commit_id":"28b93566587c600eeb5639c9faeab6921e8913f6"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"fab0df57fff8b9c5fb533ae726f1851e5d5405f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/**"},{"line_number":2,"context_line":" *"},{"line_number":3,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":" * not use self file except in compliance with the License. You may obtain"}],"source_content_type":"text/javascript","patch_set":55,"id":"da6ed579_70e26f05","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":3},"updated":"2016-01-12 23:16:11.000000000","message":"is action needed in the file name?\n\nupdate-metadata.service.js","commit_id":"0a648774a1731c8fba937193edd8c841a288de9d"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"05ff54f94071c4fbe7e56d8effd612ac75604fd1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/**"},{"line_number":2,"context_line":" *"},{"line_number":3,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":" * not use self file except in compliance with the License. You may obtain"}],"source_content_type":"text/javascript","patch_set":55,"id":"da6ed579_a0c5ec8e","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":3},"in_reply_to":"da6ed579_70e26f05","updated":"2016-01-13 00:24:18.000000000","message":"Naming is sort of under discussion at https://review.openstack.org/#/c/264942/","commit_id":"0a648774a1731c8fba937193edd8c841a288de9d"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"fab0df57fff8b9c5fb533ae726f1851e5d5405f2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  function updateMetadataService("},{"line_number":41,"context_line":"    $q,"},{"line_number":42,"context_line":"    events,"},{"line_number":43,"context_line":"    metadataModal,"},{"line_number":44,"context_line":"    keystone,"},{"line_number":45,"context_line":"    $qExtensions"},{"line_number":46,"context_line":"  ) {"}],"source_content_type":"text/javascript","patch_set":55,"id":"da6ed579_9005a3c3","line":43,"range":{"start_line":43,"start_character":17,"end_line":43,"end_character":18},"updated":"2016-01-12 23:16:11.000000000","message":"nit: metadataModalService\n\nlike:\n\n\u0027launchInstanceService\u0027,\n\u0027updateMetadataService\u0027,","commit_id":"0a648774a1731c8fba937193edd8c841a288de9d"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"05ff54f94071c4fbe7e56d8effd612ac75604fd1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  function updateMetadataService("},{"line_number":41,"context_line":"    $q,"},{"line_number":42,"context_line":"    events,"},{"line_number":43,"context_line":"    metadataModal,"},{"line_number":44,"context_line":"    keystone,"},{"line_number":45,"context_line":"    $qExtensions"},{"line_number":46,"context_line":"  ) {"}],"source_content_type":"text/javascript","patch_set":55,"id":"da6ed579_80ba2809","line":43,"range":{"start_line":43,"start_character":17,"end_line":43,"end_character":18},"in_reply_to":"da6ed579_9005a3c3","updated":"2016-01-13 00:24:18.000000000","message":"Done","commit_id":"0a648774a1731c8fba937193edd8c841a288de9d"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"7c37c967c9fe946750c5f1b7dd683911dd9467ee","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        .then(onSuccess);"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"      function onSuccess() {"},{"line_number":70,"context_line":"        scope.$emit(events.UPDATE_METADATA_SUCCESS, [image.id]);"},{"line_number":71,"context_line":"      }"},{"line_number":72,"context_line":"    }"},{"line_number":73,"context_line":""}],"source_content_type":"text/javascript","patch_set":64,"id":"5a5ae5dd_fa70f6a5","line":70,"updated":"2016-02-06 15:22:24.000000000","message":"Either here or in a follow on patch, perhaps this would be better to be on metadataModalServiceI itself for reusability in other panels.","commit_id":"bf6be3e08bd61cba4b6d70d93ec6e228162a2b1f"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"7c37c967c9fe946750c5f1b7dd683911dd9467ee","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    function createUserSessionPromise() {"},{"line_number":99,"context_line":"      var deferred \u003d $q.defer();"},{"line_number":100,"context_line":"      keystone.getCurrentUserSession().success(onUserSessionGet);"},{"line_number":101,"context_line":"      return deferred.promise;"},{"line_number":102,"context_line":""}],"source_content_type":"text/javascript","patch_set":64,"id":"5a5ae5dd_5ae58a35","line":99,"updated":"2016-02-06 15:22:24.000000000","message":"This should use the usesession service.  It caches the user session, meaning if you click update metadata more than once it won\u0027t require another API hit. In addition, since the image visibility filter uses the user session, clicking this won\u0027t mean another API hit.\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/table/images-table.controller.js#L78\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/openstack-service-api/user-session.service.js","commit_id":"bf6be3e08bd61cba4b6d70d93ec6e228162a2b1f"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"4c015d169c3316d9d76ca820784918fb34f6232d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"      userSessionPromise.then(onUserSessionGet);"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"      return deferred.promise;"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"      function onUserSessionGet(userSession) {"},{"line_number":90,"context_line":"        if (userSession.project_id \u003d\u003d\u003d image.owner) {"},{"line_number":91,"context_line":"          deferred.resolve();"}],"source_content_type":"text/javascript","patch_set":69,"id":"3a57f1b5_33c86f22","line":88,"updated":"2016-02-10 20:28:57.000000000","message":"Future patch: add ifOwner to UserSession service that takes a tenant / project id.  Like the ifEnabled on servicecatalog service. Would get rid of this boilerplate.","commit_id":"876fede86d54262d85bc6db8c09b4b8596a41e70"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"17b5402a671704db3846a75370a3f060e5916a92","unresolved":false,"context_lines":[{"line_number":85,"context_line":"      userSessionPromise.then(onUserSessionGet);"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"      return deferred.promise;"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"      function onUserSessionGet(userSession) {"},{"line_number":90,"context_line":"        if (userSession.project_id \u003d\u003d\u003d image.owner) {"},{"line_number":91,"context_line":"          deferred.resolve();"}],"source_content_type":"text/javascript","patch_set":69,"id":"3a57f1b5_78c55e3a","line":88,"in_reply_to":"3a57f1b5_33c86f22","updated":"2016-02-10 22:24:16.000000000","message":"Agree, this is definitely useful in other places as well.","commit_id":"876fede86d54262d85bc6db8c09b4b8596a41e70"}],"openstack_dashboard/static/app/core/images/actions/update-metadata.action.service.spec.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"fab0df57fff8b9c5fb533ae726f1851e5d5405f2","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  describe(\u0027horizon.app.core.images.actions.updateMetadataService\u0027, function() {"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    var keyStoneAPI \u003d {"},{"line_number":22,"context_line":"      getCurrentUserSession: function() {"},{"line_number":23,"context_line":"        return {"},{"line_number":24,"context_line":"          success: function(callback) {"}],"source_content_type":"text/javascript","patch_set":55,"id":"da6ed579_90ba83e0","line":21,"range":{"start_line":21,"start_character":22,"end_line":21,"end_character":23},"updated":"2016-01-12 23:16:11.000000000","message":"keystoneAPI*","commit_id":"0a648774a1731c8fba937193edd8c841a288de9d"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"05ff54f94071c4fbe7e56d8effd612ac75604fd1","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  describe(\u0027horizon.app.core.images.actions.updateMetadataService\u0027, function() {"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    var keyStoneAPI \u003d {"},{"line_number":22,"context_line":"      getCurrentUserSession: function() {"},{"line_number":23,"context_line":"        return {"},{"line_number":24,"context_line":"          success: function(callback) {"}],"source_content_type":"text/javascript","patch_set":55,"id":"da6ed579_205fbce6","line":21,"range":{"start_line":21,"start_character":22,"end_line":21,"end_character":23},"in_reply_to":"da6ed579_90ba83e0","updated":"2016-01-13 00:24:18.000000000","message":"Done","commit_id":"0a648774a1731c8fba937193edd8c841a288de9d"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"7c37c967c9fe946750c5f1b7dd683911dd9467ee","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  describe(\u0027horizon.app.core.images.actions.updateMetadataService\u0027, function() {"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    var keystoneAPI \u003d {"},{"line_number":22,"context_line":"      getCurrentUserSession: function() {"},{"line_number":23,"context_line":"        return {"},{"line_number":24,"context_line":"          success: function(callback) {"}],"source_content_type":"text/javascript","patch_set":64,"id":"5a5ae5dd_bac35e88","line":21,"updated":"2016-02-06 15:22:24.000000000","message":"Here\u0027s a simple mock for usersession:\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/table/images-table.controller.spec.js#L35","commit_id":"bf6be3e08bd61cba4b6d70d93ec6e228162a2b1f"}],"openstack_dashboard/static/app/core/images/images.module.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"cdbaedb144fd7018be3bdbeb34f25517cd70f7da","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  function events() {"},{"line_number":44,"context_line":"    return {"},{"line_number":45,"context_line":"      deleteSuccess: \u0027images.deleteSuccess\u0027,"},{"line_number":46,"context_line":"      editSuccess: \u0027images.editSuccess\u0027"},{"line_number":47,"context_line":"    };"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"da20952f_c306decd","line":46,"updated":"2015-08-28 06:49:31.000000000","message":"I think this should be fully qualified. \n\nhorizon.app.core.images.events.editSuccess.  You reference it via variable everywhere, so why shorten it in the string?","commit_id":"29b41d71e881e0ca3671e72f5fcbf01f4488871b"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"6dd3f081bd6190042843e8ccaf738c0da46c5770","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  function events() {"},{"line_number":44,"context_line":"    return {"},{"line_number":45,"context_line":"      deleteSuccess: \u0027images.deleteSuccess\u0027,"},{"line_number":46,"context_line":"      editSuccess: \u0027images.editSuccess\u0027"},{"line_number":47,"context_line":"    };"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"da20952f_75f0c367","line":46,"in_reply_to":"da20952f_23c55a5a","updated":"2015-08-28 20:29:53.000000000","message":"Done","commit_id":"29b41d71e881e0ca3671e72f5fcbf01f4488871b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"5147869f404db2c20aa3ba9c1493f7bcfa345226","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  function events() {"},{"line_number":44,"context_line":"    return {"},{"line_number":45,"context_line":"      deleteSuccess: \u0027images.deleteSuccess\u0027,"},{"line_number":46,"context_line":"      editSuccess: \u0027images.editSuccess\u0027"},{"line_number":47,"context_line":"    };"},{"line_number":48,"context_line":"  }"},{"line_number":49,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"da20952f_23c55a5a","line":46,"in_reply_to":"da20952f_c306decd","updated":"2015-08-28 06:50:55.000000000","message":"actually, this should be horizon.app.core.images.events.updateMetadataSuccess","commit_id":"29b41d71e881e0ca3671e72f5fcbf01f4488871b"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"17b5402a671704db3846a75370a3f060e5916a92","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  angular"},{"line_number":29,"context_line":"    .module(\u0027horizon.app.core.images\u0027, [])"},{"line_number":30,"context_line":"    .constant(\u0027horizon.app.core.images.events\u0027, events())"},{"line_number":31,"context_line":"    .constant(\u0027horizon.app.core.images.non_bootable_image_types\u0027, [\u0027aki\u0027, \u0027ari\u0027])"},{"line_number":32,"context_line":"    .config(config);"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  config.$inject \u003d ["}],"source_content_type":"text/javascript","patch_set":69,"id":"3a57f1b5_b8a436a6","line":31,"updated":"2016-02-10 22:24:16.000000000","message":"I think we should stick with camelCase for names. nonBootableImageTypes or just nonBootableTypes since its already under image.","commit_id":"876fede86d54262d85bc6db8c09b4b8596a41e70"}],"openstack_dashboard/static/app/core/images/images.scss":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"64ab2942eb7c03a058388e3d859e87c8956fe4b9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  }"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  \u0026.table-rsp .action-col {"},{"line_number":9,"context_line":"    min-width: 15em;"},{"line_number":10,"context_line":"  }"},{"line_number":11,"context_line":"}"}],"source_content_type":"text/x-scss","patch_set":57,"id":"da6ed579_f97aec76","line":9,"updated":"2016-01-16 17:47:38.000000000","message":"Why is this hardcoded?  Can we use variables or css to make this dynamic?","commit_id":"68a21faf3690558e818f3e49e00d179b492c1f62"}],"openstack_dashboard/static/app/core/images/table/images-table.html":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"9a1358a2db3aa62bb742b1d79d4d70393f9ac324","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                    action-classes\u003d\"\u0027text-danger\u0027\""},{"line_number":107,"context_line":"                    callback\u003d\"table.rowActions.deleted.open\""},{"line_number":108,"context_line":"                    item\u003d\"image\"\u003e"},{"line_number":109,"context_line":"              \u003ci class\u003d\"fa fa-trash-o\"\u003e\u003c/i\u003e"},{"line_number":110,"context_line":"              \u003ctranslate\u003eDelete Image\u003c/translate\u003e"},{"line_number":111,"context_line":"            \u003c/action\u003e"},{"line_number":112,"context_line":"          \u003c/menu\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"da20952f_0fa91e7b","line":109,"updated":"2015-08-29 18:41:52.000000000","message":"\u003cspan\u003e instead of \u003ci\u003e","commit_id":"05b500ff91f7739b8e110611bd8a91a16de7acba"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e8c93e1c89612bff5ebbf91d2e20fe553a3639fa","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        Actions taken here applies to a single item/row."},{"line_number":91,"context_line":"        --\u003e"},{"line_number":92,"context_line":"        \u003caction-list dropdown\u003e"},{"line_number":93,"context_line":"          \u003caction button-type\u003d\"split-button\""},{"line_number":94,"context_line":"                  action-classes\u003d\"\u0027btn btn-default\u0027\""},{"line_number":95,"context_line":"                  callback\u003d\"table.rowActions.edit.open\""},{"line_number":96,"context_line":"                  item\u003d\"image\"\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"da20952f_47e016cd","line":93,"updated":"2015-09-01 04:02:58.000000000","message":"This patch is also adding Edit?  That isn\u0027t in the patch commit message.  I think this is not supposed to be here?","commit_id":"28b93566587c600eeb5639c9faeab6921e8913f6"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"fb8b7a7e253907957810ad280a3a07574910d412","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        Actions taken here applies to a single item/row."},{"line_number":91,"context_line":"        --\u003e"},{"line_number":92,"context_line":"        \u003caction-list dropdown\u003e"},{"line_number":93,"context_line":"          \u003caction button-type\u003d\"split-button\""},{"line_number":94,"context_line":"                  action-classes\u003d\"\u0027btn btn-default\u0027\""},{"line_number":95,"context_line":"                  callback\u003d\"table.rowActions.edit.open\""},{"line_number":96,"context_line":"                  item\u003d\"image\"\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"da20952f_8f616007","line":93,"in_reply_to":"da20952f_47e016cd","updated":"2015-09-01 06:53:22.000000000","message":"Needed a container button for the actions. \"Edit\" is a good candidate. I\u0027ve changed the commit message to WIP and add the fact about the edit button.","commit_id":"28b93566587c600eeb5639c9faeab6921e8913f6"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e8c93e1c89612bff5ebbf91d2e20fe553a3639fa","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            \u003ctranslate\u003eEdit Image\u003c/translate\u003e"},{"line_number":98,"context_line":"          \u003c/action\u003e"},{"line_number":99,"context_line":"          \u003cmenu\u003e"},{"line_number":100,"context_line":"            \u003caction button-type\u003d\"menu-item\""},{"line_number":101,"context_line":"                    callback\u003d\"table.rowActions.updateMetadata.open\""},{"line_number":102,"context_line":"                    item\u003d\"image\"\u003e"},{"line_number":103,"context_line":"              \u003ctranslate\u003eUpdate Metadata\u003c/translate\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"da20952f_070bfe7d","line":100,"updated":"2015-09-01 04:02:58.000000000","message":"This actually has some checks that have to happen to determine whether or not to show it.\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/images/images/tables.py#L182\n\nUnfortunately, looks like we need to add the active glance version as a REST API.","commit_id":"28b93566587c600eeb5639c9faeab6921e8913f6"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"fb8b7a7e253907957810ad280a3a07574910d412","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            \u003ctranslate\u003eEdit Image\u003c/translate\u003e"},{"line_number":98,"context_line":"          \u003c/action\u003e"},{"line_number":99,"context_line":"          \u003cmenu\u003e"},{"line_number":100,"context_line":"            \u003caction button-type\u003d\"menu-item\""},{"line_number":101,"context_line":"                    callback\u003d\"table.rowActions.updateMetadata.open\""},{"line_number":102,"context_line":"                    item\u003d\"image\"\u003e"},{"line_number":103,"context_line":"              \u003ctranslate\u003eUpdate Metadata\u003c/translate\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"da20952f_0f3470f9","line":100,"in_reply_to":"da20952f_070bfe7d","updated":"2015-09-01 06:53:22.000000000","message":"I\u0027ve updated the commit to be WIP while I address it.","commit_id":"28b93566587c600eeb5639c9faeab6921e8913f6"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"e8c93e1c89612bff5ebbf91d2e20fe553a3639fa","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                    item\u003d\"image\"\u003e"},{"line_number":103,"context_line":"              \u003ctranslate\u003eUpdate Metadata\u003c/translate\u003e"},{"line_number":104,"context_line":"            \u003c/action\u003e"},{"line_number":105,"context_line":"            \u003caction ng-if\u003d\"table.imageDeletePermitted(image)\" action-classes\u003d\"\u0027btn btn-default btn-sm btn-danger pull-right\u0027\""},{"line_number":106,"context_line":"                    callback\u003d\"table.rowActions.deleted.open\""},{"line_number":107,"context_line":"                    item\u003d\"image\"\u003e"},{"line_number":108,"context_line":"              \u003cspan class\u003d\"fa fa-trash-o\"\u003e\u003c/span\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"da20952f_4707b681","line":105,"updated":"2015-09-01 04:02:58.000000000","message":"please put action-classes on next line for readability.","commit_id":"28b93566587c600eeb5639c9faeab6921e8913f6"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"fb8b7a7e253907957810ad280a3a07574910d412","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                    item\u003d\"image\"\u003e"},{"line_number":103,"context_line":"              \u003ctranslate\u003eUpdate Metadata\u003c/translate\u003e"},{"line_number":104,"context_line":"            \u003c/action\u003e"},{"line_number":105,"context_line":"            \u003caction ng-if\u003d\"table.imageDeletePermitted(image)\" action-classes\u003d\"\u0027btn btn-default btn-sm btn-danger pull-right\u0027\""},{"line_number":106,"context_line":"                    callback\u003d\"table.rowActions.deleted.open\""},{"line_number":107,"context_line":"                    item\u003d\"image\"\u003e"},{"line_number":108,"context_line":"              \u003cspan class\u003d\"fa fa-trash-o\"\u003e\u003c/span\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"da20952f_ef133c63","line":105,"in_reply_to":"da20952f_4707b681","updated":"2015-09-01 06:53:22.000000000","message":"Done","commit_id":"28b93566587c600eeb5639c9faeab6921e8913f6"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"639392724c1e4b5f4019d546a1e3e8c3af75130b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        \u003cactions allowed\u003d\"table.rowActions.actions\" type\u003d\"row\" item\u003d\"image\"\u003e"},{"line_number":85,"context_line":"        \u003c/actions\u003e"},{"line_number":86,"context_line":"      \u003c/td\u003e"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    \u003c/tr\u003e"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    \u003ctr ng-repeat-end class\u003d\"detail-row\"\u003e"}],"source_content_type":"text/html","patch_set":55,"id":"da6ed579_353f09b6","line":87,"updated":"2016-01-12 19:43:07.000000000","message":"We probably can axe this extra line.","commit_id":"0a648774a1731c8fba937193edd8c841a288de9d"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"05ff54f94071c4fbe7e56d8effd612ac75604fd1","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        \u003cactions allowed\u003d\"table.rowActions.actions\" type\u003d\"row\" item\u003d\"image\"\u003e"},{"line_number":85,"context_line":"        \u003c/actions\u003e"},{"line_number":86,"context_line":"      \u003c/td\u003e"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    \u003c/tr\u003e"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    \u003ctr ng-repeat-end class\u003d\"detail-row\"\u003e"}],"source_content_type":"text/html","patch_set":55,"id":"da6ed579_8068e888","line":87,"in_reply_to":"da6ed579_353f09b6","updated":"2016-01-13 00:24:18.000000000","message":"Done","commit_id":"0a648774a1731c8fba937193edd8c841a288de9d"}],"openstack_dashboard/static/app/core/images/table/row-actions.service.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"fab0df57fff8b9c5fb533ae726f1851e5d5405f2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        service: launchInstanceService,"},{"line_number":65,"context_line":"        template: {"},{"line_number":66,"context_line":"          text: gettext(\u0027Launch Instance\u0027)"},{"line_number":67,"context_line":"        }"},{"line_number":68,"context_line":"      }, {"},{"line_number":69,"context_line":"        service: updateMetadataService,"},{"line_number":70,"context_line":"        template: {"}],"source_content_type":"text/javascript","patch_set":55,"id":"da6ed579_b0bb07c4","line":67,"updated":"2016-01-12 23:16:11.000000000","message":"why r there two?","commit_id":"0a648774a1731c8fba937193edd8c841a288de9d"},{"author":{"_account_id":17013,"name":"Rajat Vig","email":"rajatv@thoughtworks.com","username":"rajatvig"},"change_message_id":"05ff54f94071c4fbe7e56d8effd612ac75604fd1","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        service: launchInstanceService,"},{"line_number":65,"context_line":"        template: {"},{"line_number":66,"context_line":"          text: gettext(\u0027Launch Instance\u0027)"},{"line_number":67,"context_line":"        }"},{"line_number":68,"context_line":"      }, {"},{"line_number":69,"context_line":"        service: updateMetadataService,"},{"line_number":70,"context_line":"        template: {"}],"source_content_type":"text/javascript","patch_set":55,"id":"da6ed579_6004d4bf","line":67,"in_reply_to":"da6ed579_b0bb07c4","updated":"2016-01-13 00:24:18.000000000","message":"There are two in the Django Panel. I replicated. I can remove the second if it\u0027s not required.","commit_id":"0a648774a1731c8fba937193edd8c841a288de9d"}]}
