)]}'
{"horizon/static/framework/util/config/config.service.js":[{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"dfac93ec6859f3b23be2eaaccfb14ce171ae78a3","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  angular"},{"line_number":21,"context_line":"    .module(\u0027horizon.framework.util\u0027)"},{"line_number":22,"context_line":"    .service(\u0027horizon.framework.util.config-service\u0027, ConfigService);"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  /**"},{"line_number":25,"context_line":"    * @ngdoc service"}],"source_content_type":"text/javascript","patch_set":5,"id":"da20952f_822545c3","line":22,"updated":"2015-09-03 05:06:12.000000000","message":"ConfigService is not a constructor function, therefore we should use\n\n.factory(...)\n\nhere.","commit_id":"d7672d75c5312f62809d5b270b1f5049bca9fc92"},{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"dfac93ec6859f3b23be2eaaccfb14ce171ae78a3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    * (\u0027horizon.app.core.openstack-service-api.settings\u0027)."},{"line_number":33,"context_line":"    * If a setting is not provided, framework will uses the default listed here."},{"line_number":34,"context_line":"    */"},{"line_number":35,"context_line":"  function ConfigService() {"},{"line_number":36,"context_line":"    var config \u003d {"},{"line_number":37,"context_line":"      pageSize: 20"},{"line_number":38,"context_line":"    };"}],"source_content_type":"text/javascript","patch_set":5,"id":"da20952f_a259695d","line":35,"updated":"2015-09-03 05:06:12.000000000","message":"This is not a constructor function, should be named as:\n\nconfigService","commit_id":"d7672d75c5312f62809d5b270b1f5049bca9fc92"},{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"dfac93ec6859f3b23be2eaaccfb14ce171ae78a3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      return config[key];"},{"line_number":49,"context_line":"    }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    function set(key, value) {"},{"line_number":52,"context_line":"      config[key] \u003d value;"},{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":5,"id":"da20952f_7d969495","line":51,"updated":"2015-09-03 05:06:12.000000000","message":"I wonder if we want to change `config` value...","commit_id":"d7672d75c5312f62809d5b270b1f5049bca9fc92"}],"horizon/static/framework/widgets/table/hz-dynamic-table.html":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b88caf848b6f3f7499a766a683e3600c02c0d7fa","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        the header."},{"line_number":27,"context_line":"      --\u003e"},{"line_number":28,"context_line":"        \u003ctr\u003e"},{"line_number":29,"context_line":"          \u003ctd hz-table-footer colspan\u003d\"100\" items\u003d\"items\"\u003e\u003c/td\u003e"},{"line_number":30,"context_line":"        \u003c/tr\u003e"},{"line_number":31,"context_line":"        \u003c!--"},{"line_number":32,"context_line":"          Table-column-headers:"}],"source_content_type":"text/html","patch_set":31,"id":"1f485f77_bdad58ea","line":29,"updated":"2017-11-16 08:52:21.000000000","message":"nit: this change is not related to the patch","commit_id":"8a073d3ab1983f7b197679fe5a2373e304cec0e9"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"a3a76bf1c089b992687eb1d35a0829bd83600189","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        the header."},{"line_number":27,"context_line":"      --\u003e"},{"line_number":28,"context_line":"        \u003ctr\u003e"},{"line_number":29,"context_line":"          \u003ctd hz-table-footer colspan\u003d\"100\" items\u003d\"items\"\u003e\u003c/td\u003e"},{"line_number":30,"context_line":"        \u003c/tr\u003e"},{"line_number":31,"context_line":"        \u003c!--"},{"line_number":32,"context_line":"          Table-column-headers:"}],"source_content_type":"text/html","patch_set":31,"id":"df7087c5_dfec382b","line":29,"in_reply_to":"1f485f77_bdad58ea","updated":"2018-03-19 12:54:51.000000000","message":"Done","commit_id":"8a073d3ab1983f7b197679fe5a2373e304cec0e9"}],"horizon/static/framework/widgets/table/hz-table-footer.controller.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"39ffac206aaa2b3c1e280d32fcfb28cff8da52e4","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  function HzTableFooterController(tableOptions) {"},{"line_number":30,"context_line":"    var ctrl \u003d this;"},{"line_number":31,"context_line":"    ctrl.pageSize \u003d horizon.cookies.getRaw(\u0027horizon_pagesize\u0027) || tableOptions.pageSize;"},{"line_number":32,"context_line":"  }"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":20,"id":"bacf61ea_2fb05bdd","line":31,"updated":"2016-07-27 23:04:46.000000000","message":"this is a nice idea, except that this variable only gets populated when the user goes to Settings Panel and changes the page size. Otherwise it is undefined. Can we store the page_size in horizon.conf like what we do for auto_fade_alerts, etc. These client-side settings are safe to put on client-side. Then we can use it.\n\nBehavior is inconsistent, e.g.\n1. Login\n2. Visit NG Flavors, page size at 20 (using value from L22)\n3. Go to Settings, change page size to 4\n4. Visit NG Flavors, page size is 4","commit_id":"9f1e9a822d2d002a7ad4c8771fbe159aeb662bce"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"7cf2222ce1e313181a3d707bdfff47257713aa4d","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  function HzTableFooterController(tableOptions) {"},{"line_number":30,"context_line":"    var ctrl \u003d this;"},{"line_number":31,"context_line":"    ctrl.pageSize \u003d horizon.cookies.getRaw(\u0027horizon_pagesize\u0027) || tableOptions.pageSize;"},{"line_number":32,"context_line":"  }"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":20,"id":"bacf61ea_350f6c89","line":31,"in_reply_to":"bacf61ea_2fb05bdd","updated":"2016-08-01 08:04:51.000000000","message":"HI Cindy, sorry for later reply:-) the steps seem reasonable for me, the logical is that we use the pageSize of Line 22 if we haven\u0027t change page size of user settings，otherwise we should use  page size of user settings. and django has the same way to handle pageSize.","commit_id":"9f1e9a822d2d002a7ad4c8771fbe159aeb662bce"}],"horizon/static/framework/widgets/table/hz-table-footer.directive.js":[{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"dfac93ec6859f3b23be2eaaccfb14ce171ae78a3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    */"},{"line_number":37,"context_line":"  function hzTableFooter(basePath) {"},{"line_number":38,"context_line":"    var directive \u003d {"},{"line_number":39,"context_line":"      controller: \"HzTableFooterController as ctrl\","},{"line_number":40,"context_line":"      restrict: \u0027A\u0027,"},{"line_number":41,"context_line":"      scope: {"},{"line_number":42,"context_line":"        items: \u0027\u003d\u0027"}],"source_content_type":"text/javascript","patch_set":5,"id":"da20952f_7d13f45c","line":39,"updated":"2015-09-03 05:06:12.000000000","message":"consider keeping consistent with single quote in this file.","commit_id":"d7672d75c5312f62809d5b270b1f5049bca9fc92"},{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"1e91062161cf0cd64937e2d78e1b3dc60fcc3d55","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    */"},{"line_number":37,"context_line":"  function hzTableFooter(basePath) {"},{"line_number":38,"context_line":"    var directive \u003d {"},{"line_number":39,"context_line":"      controller: \"HzTableFooterController as ctrl\","},{"line_number":40,"context_line":"      restrict: \u0027A\u0027,"},{"line_number":41,"context_line":"      scope: {"},{"line_number":42,"context_line":"        items: \u0027\u003d\u0027"}],"source_content_type":"text/javascript","patch_set":6,"id":"ba15a1d1_32fb59c3","line":39,"updated":"2015-09-15 21:51:44.000000000","message":"Please be consistent with single quote in this file.","commit_id":"a3163f18d0665945fb453f30a3c237eb67918af8"}],"horizon/static/framework/widgets/table/hz-table-footer.html":[{"author":{"_account_id":13805,"name":"Shaoquan Chen","email":"sean.chen2@hp.com","username":"SeanChen"},"change_message_id":"7033b37d0a978f46fcec71bedd7f96f77a6251cc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"\u003ctr\u003e"},{"line_number":6,"context_line":"  \u003ctd colspan\u003d\"100\"\u003e"},{"line_number":7,"context_line":"    \u003cspan class\u003d\"display\"\u003e{$ items.length|itemCount $}\u003c/span\u003e"},{"line_number":8,"context_line":"    \u003cdiv st-pagination\u003d\"\" st-items-by-page\u003d\"ctrl.pageSize\" st-displayed-pages\u003d\"ctrl.pageSize\"\u003e\u003c/div\u003e"},{"line_number":9,"context_line":"    \u003cng-transclude\u003e\u003c/ng-transclude\u003e"},{"line_number":10,"context_line":"  \u003c/td\u003e"},{"line_number":11,"context_line":"\u003c/tr\u003e"}],"source_content_type":"text/html","patch_set":9,"id":"5a2ca52d_a0572601","line":8,"updated":"2015-10-14 20:41:34.000000000","message":"st-displayed-pages\u003d\"ctrl.pageSize\" seams incorrect to me, can you double check?","commit_id":"4d3e772faf43db8e6d181cd77299c3cf319d3929"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"66441d3fd3dc0beb2999e67f7709b5f234aad3dc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"\u003ctr\u003e"},{"line_number":6,"context_line":"  \u003ctd colspan\u003d\"100\"\u003e"},{"line_number":7,"context_line":"    \u003cspan class\u003d\"display\"\u003e{$ items.length|itemCount $}\u003c/span\u003e"},{"line_number":8,"context_line":"    \u003cdiv st-pagination\u003d\"\" st-items-by-page\u003d\"ctrl.pageSize\" st-displayed-pages\u003d\"ctrl.pageSize\"\u003e\u003c/div\u003e"},{"line_number":9,"context_line":"    \u003cng-transclude\u003e\u003c/ng-transclude\u003e"},{"line_number":10,"context_line":"  \u003c/td\u003e"},{"line_number":11,"context_line":"\u003c/tr\u003e"}],"source_content_type":"text/html","patch_set":9,"id":"1a122d0e_c575ef97","line":8,"in_reply_to":"5a2ca52d_a0572601","updated":"2016-05-04 07:56:33.000000000","message":"the same to me, seems we could not get the value of pageSize..","commit_id":"4d3e772faf43db8e6d181cd77299c3cf319d3929"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"9c8f17e7c81f211ca284d48fa8c06e48f82aca8b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"\u003ctr\u003e"},{"line_number":7,"context_line":"  \u003ctd colspan\u003d\"100\"\u003e"},{"line_number":8,"context_line":"    \u003cspan class\u003d\"display\"\u003e{$ items.length|itemCount $}\u003c/span\u003e"},{"line_number":9,"context_line":"    \u003cdiv st-pagination\u003d\"\" st-items-by-page\u003d\"ctrl.pageSize\" st-displayed-pages\u003d\"5\"\u003e\u003c/div\u003e"},{"line_number":10,"context_line":"    \u003cng-transclude\u003e\u003c/ng-transclude\u003e"},{"line_number":11,"context_line":"  \u003c/td\u003e"},{"line_number":12,"context_line":"\u003c/tr\u003e"}],"source_content_type":"text/html","patch_set":16,"id":"fad55976_3e57f303","line":9,"range":{"start_line":9,"start_character":59,"end_line":9,"end_character":81},"updated":"2016-07-15 20:58:21.000000000","message":"What about making this configurable too? default to 5","commit_id":"03b6b7407656e3d61f6a40c12404aa0b64904f75"}],"horizon/static/framework/widgets/table/pagination.html":[{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"fb0f22c8654888bc8a62d031f2abd62cbd30dabf","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      \u003c/a\u003e"},{"line_number":10,"context_line":"    \u003c/li\u003e"},{"line_number":11,"context_line":"    \u003cli\u003e"},{"line_number":12,"context_line":"      \u003ca\u003e{{ currentPage }} / {{numPages}}\u003c/a\u003e"},{"line_number":13,"context_line":"    \u003c/li\u003e"},{"line_number":14,"context_line":"    \u003cli ng-class\u003d\"{disabled: currentPage \u003d\u003d\u003d numPages}\"\u003e"},{"line_number":15,"context_line":"      \u003ca ng-click\u003d\"selectPage(currentPage + 1)\"\u003e"}],"source_content_type":"text/html","patch_set":27,"id":"ff346bd7_d6fe3b04","line":12,"updated":"2017-07-24 02:38:13.000000000","message":"this is not a link","commit_id":"c1e3bc7d9b05596fd79282e551a9fa0ca79fe54c"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b88caf848b6f3f7499a766a683e3600c02c0d7fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cspan ng-if\u003d\"pages.length \u003e\u003d 2\"\u003e"},{"line_number":2,"context_line":"  \u003cspan class\u003d\"spacer\"\u003e|\u003c/span\u003e"},{"line_number":3,"context_line":"  \u003cspan ng-hide\u003d\"currentPage \u003d\u003d\u003d 1\"\u003e"},{"line_number":4,"context_line":"    \u003ca ng-click\u003d\"selectPage(currentPage - 1)\" translate\u003e"}],"source_content_type":"text/html","patch_set":31,"id":"1f485f77_3df048fe","line":1,"updated":"2017-11-16 08:52:21.000000000","message":"nit: \"pages.length \u003e 1\" will be more readable","commit_id":"8a073d3ab1983f7b197679fe5a2373e304cec0e9"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"a3a76bf1c089b992687eb1d35a0829bd83600189","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cspan ng-if\u003d\"pages.length \u003e\u003d 2\"\u003e"},{"line_number":2,"context_line":"  \u003cspan class\u003d\"spacer\"\u003e|\u003c/span\u003e"},{"line_number":3,"context_line":"  \u003cspan ng-hide\u003d\"currentPage \u003d\u003d\u003d 1\"\u003e"},{"line_number":4,"context_line":"    \u003ca ng-click\u003d\"selectPage(currentPage - 1)\" translate\u003e"}],"source_content_type":"text/html","patch_set":31,"id":"df7087c5_1fe2b030","line":1,"in_reply_to":"1f485f77_3df048fe","updated":"2018-03-19 12:54:51.000000000","message":"Done","commit_id":"8a073d3ab1983f7b197679fe5a2373e304cec0e9"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"eed62d12ccced8d759744df18703c23569409f64","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cspan ng-if\u003d\"pages.length \u003e\u003d 2\"\u003e"},{"line_number":2,"context_line":"  \u003cspan class\u003d\"spacer\"\u003e|\u003c/span\u003e"},{"line_number":3,"context_line":"  \u003cspan ng-hide\u003d\"currentPage \u003d\u003d\u003d 1\"\u003e"},{"line_number":4,"context_line":"    \u003ca ng-click\u003d\"selectPage(currentPage - 1)\" translate\u003e"},{"line_number":5,"context_line":"      \u0026laquo;\u0026nbsp;Prev"},{"line_number":6,"context_line":"    \u003c/a\u003e"},{"line_number":7,"context_line":"  \u003c/span\u003e"}],"source_content_type":"text/html","patch_set":31,"id":"1f485f77_7816cef3","line":4,"range":{"start_line":4,"start_character":46,"end_line":4,"end_character":55},"updated":"2017-11-16 09:33:26.000000000","message":"translate attribute should not be used for symbols. could you use \u003ctranslate\u003e only for \"Prev\"?","commit_id":"8a073d3ab1983f7b197679fe5a2373e304cec0e9"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"a3a76bf1c089b992687eb1d35a0829bd83600189","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cspan ng-if\u003d\"pages.length \u003e\u003d 2\"\u003e"},{"line_number":2,"context_line":"  \u003cspan class\u003d\"spacer\"\u003e|\u003c/span\u003e"},{"line_number":3,"context_line":"  \u003cspan ng-hide\u003d\"currentPage \u003d\u003d\u003d 1\"\u003e"},{"line_number":4,"context_line":"    \u003ca ng-click\u003d\"selectPage(currentPage - 1)\" translate\u003e"},{"line_number":5,"context_line":"      \u0026laquo;\u0026nbsp;Prev"},{"line_number":6,"context_line":"    \u003c/a\u003e"},{"line_number":7,"context_line":"  \u003c/span\u003e"}],"source_content_type":"text/html","patch_set":31,"id":"df7087c5_7fdbac4e","line":4,"range":{"start_line":4,"start_character":46,"end_line":4,"end_character":55},"in_reply_to":"1f485f77_7816cef3","updated":"2018-03-19 12:54:51.000000000","message":"Done","commit_id":"8a073d3ab1983f7b197679fe5a2373e304cec0e9"},{"author":{"_account_id":16352,"name":"Shu Muto","email":"shu.mutow@gmail.com","username":"shu.mutow"},"change_message_id":"eed62d12ccced8d759744df18703c23569409f64","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    \u003c/a\u003e"},{"line_number":7,"context_line":"  \u003c/span\u003e"},{"line_number":8,"context_line":"  \u003cspan ng-hide\u003d\"currentPage \u003d\u003d\u003d numPages\"\u003e"},{"line_number":9,"context_line":"    \u003ca ng-click\u003d\"selectPage(currentPage + 1)\" translate\u003e"},{"line_number":10,"context_line":"      Next\u0026nbsp;\u0026raquo;"},{"line_number":11,"context_line":"    \u003c/a\u003e"},{"line_number":12,"context_line":"  \u003c/span\u003e"}],"source_content_type":"text/html","patch_set":31,"id":"1f485f77_58d5521b","line":9,"range":{"start_line":9,"start_character":46,"end_line":9,"end_character":55},"updated":"2017-11-16 09:33:26.000000000","message":"ditto","commit_id":"8a073d3ab1983f7b197679fe5a2373e304cec0e9"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"a3a76bf1c089b992687eb1d35a0829bd83600189","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    \u003c/a\u003e"},{"line_number":7,"context_line":"  \u003c/span\u003e"},{"line_number":8,"context_line":"  \u003cspan ng-hide\u003d\"currentPage \u003d\u003d\u003d numPages\"\u003e"},{"line_number":9,"context_line":"    \u003ca ng-click\u003d\"selectPage(currentPage + 1)\" translate\u003e"},{"line_number":10,"context_line":"      Next\u0026nbsp;\u0026raquo;"},{"line_number":11,"context_line":"    \u003c/a\u003e"},{"line_number":12,"context_line":"  \u003c/span\u003e"}],"source_content_type":"text/html","patch_set":31,"id":"df7087c5_9fe000fd","line":9,"range":{"start_line":9,"start_character":46,"end_line":9,"end_character":55},"in_reply_to":"1f485f77_58d5521b","updated":"2018-03-19 12:54:51.000000000","message":"Done","commit_id":"8a073d3ab1983f7b197679fe5a2373e304cec0e9"}],"horizon/static/framework/widgets/table/table.module.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"39ffac206aaa2b3c1e280d32fcfb28cff8da52e4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"      \u0027\u003cli ng-class\u003d\"{disabled: currentPage \u003d\u003d\u003d 1}\"\u003e\u0027 +"},{"line_number":66,"context_line":"      \u0027\u003ca ng-click\u003d\"selectPage(currentPage - 1)\"\u003e\u0027 +"},{"line_number":67,"context_line":"      \u0027\u003ci class\u003d\"fa fa-angle-double-left\"\u003e\u003c/i\u003e\u003c/a\u003e\u003c/li\u003e\u0027 +"},{"line_number":68,"context_line":"      \u0027\u003cli\u003e\u003ca\u003e{{ currentPage }} / {{numPages}}\u003c/a\u003e\u003c/li\u003e\u0027 +"},{"line_number":69,"context_line":"      \u0027\u003cli ng-class\u003d\"{disabled: currentPage \u003d\u003d\u003d numPages}\"\u003e\u0027 +"},{"line_number":70,"context_line":"      \u0027\u003ca ng-click\u003d\"selectPage(currentPage + 1)\"\u003e\u0027 +"},{"line_number":71,"context_line":"      \u0027\u003ci class\u003d\"fa fa-angle-double-right\"\u003e\u003c/i\u003e\u003c/a\u003e\u0027 +"}],"source_content_type":"text/javascript","patch_set":20,"id":"bacf61ea_214d0f73","line":68,"updated":"2016-07-27 23:04:46.000000000","message":"this doesn\u0027t need to be \u003ca\u003e","commit_id":"9f1e9a822d2d002a7ad4c8771fbe159aeb662bce"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"7cf2222ce1e313181a3d707bdfff47257713aa4d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"      \u0027\u003cli ng-class\u003d\"{disabled: currentPage \u003d\u003d\u003d 1}\"\u003e\u0027 +"},{"line_number":66,"context_line":"      \u0027\u003ca ng-click\u003d\"selectPage(currentPage - 1)\"\u003e\u0027 +"},{"line_number":67,"context_line":"      \u0027\u003ci class\u003d\"fa fa-angle-double-left\"\u003e\u003c/i\u003e\u003c/a\u003e\u003c/li\u003e\u0027 +"},{"line_number":68,"context_line":"      \u0027\u003cli\u003e\u003ca\u003e{{ currentPage }} / {{numPages}}\u003c/a\u003e\u003c/li\u003e\u0027 +"},{"line_number":69,"context_line":"      \u0027\u003cli ng-class\u003d\"{disabled: currentPage \u003d\u003d\u003d numPages}\"\u003e\u0027 +"},{"line_number":70,"context_line":"      \u0027\u003ca ng-click\u003d\"selectPage(currentPage + 1)\"\u003e\u0027 +"},{"line_number":71,"context_line":"      \u0027\u003ci class\u003d\"fa fa-angle-double-right\"\u003e\u003c/i\u003e\u003c/a\u003e\u0027 +"}],"source_content_type":"text/javascript","patch_set":20,"id":"bacf61ea_2001ec05","line":68,"in_reply_to":"bacf61ea_214d0f73","updated":"2016-08-01 08:04:51.000000000","message":"Done","commit_id":"9f1e9a822d2d002a7ad4c8771fbe159aeb662bce"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"39ffac206aaa2b3c1e280d32fcfb28cff8da52e4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      \u0027\u003ca ng-click\u003d\"selectPage(currentPage + 1)\"\u003e\u0027 +"},{"line_number":71,"context_line":"      \u0027\u003ci class\u003d\"fa fa-angle-double-right\"\u003e\u003c/i\u003e\u003c/a\u003e\u0027 +"},{"line_number":72,"context_line":"      \u0027\u003cli ng-class\u003d\"{disabled: currentPage \u003d\u003d\u003d numPages}\"\u003e\u0027 +"},{"line_number":73,"context_line":"      \u0027\u003ca ng-click\u003d\"selectPage(numPages)\" translate\u003eLast\u003c/a\u003e\u003c/li\u003e\u003c/ul\u003e\u003c/nav\u003e\u0027);"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":20,"id":"bacf61ea_410e4335","line":73,"updated":"2016-07-27 23:04:46.000000000","message":"\u003c\u003c and \u003e\u003e icon not showing up\n\nshould be using \u003cspan class\u003d\"fa fa-bug\"\u003e\u003c/span\u003e instead of \u003ci\u003e tag","commit_id":"9f1e9a822d2d002a7ad4c8771fbe159aeb662bce"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"7cf2222ce1e313181a3d707bdfff47257713aa4d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      \u0027\u003ca ng-click\u003d\"selectPage(currentPage + 1)\"\u003e\u0027 +"},{"line_number":71,"context_line":"      \u0027\u003ci class\u003d\"fa fa-angle-double-right\"\u003e\u003c/i\u003e\u003c/a\u003e\u0027 +"},{"line_number":72,"context_line":"      \u0027\u003cli ng-class\u003d\"{disabled: currentPage \u003d\u003d\u003d numPages}\"\u003e\u0027 +"},{"line_number":73,"context_line":"      \u0027\u003ca ng-click\u003d\"selectPage(numPages)\" translate\u003eLast\u003c/a\u003e\u003c/li\u003e\u003c/ul\u003e\u003c/nav\u003e\u0027);"},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":20,"id":"bacf61ea_0006681c","line":73,"in_reply_to":"bacf61ea_410e4335","updated":"2016-08-01 08:04:51.000000000","message":"Done","commit_id":"9f1e9a822d2d002a7ad4c8771fbe159aeb662bce"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"450e65e2217e14886ae25c777c0f9a14f87e5d19","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  ];"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  // TODO: Use stConfig.pagination.template to override pagination template"},{"line_number":59,"context_line":"  // after the xstatic-angular-smart-table 1.4.13 released"},{"line_number":60,"context_line":"  function run($templateCache) {"},{"line_number":61,"context_line":"    $templateCache.put(\u0027template/smart-table/pagination.html\u0027,"},{"line_number":62,"context_line":"      \u0027\u003cnav ng-if\u003d\"pages.length \u003e\u003d 2\"\u003e\u003cul class\u003d\"pagination\"\u003e\u0027 +"}],"source_content_type":"text/javascript","patch_set":21,"id":"9ad45d7e_4f465c24","line":59,"updated":"2016-08-08 22:42:02.000000000","message":"yuck, but i guess...","commit_id":"9e41c52b48dd806e39caaebc0a856f20ea1373d3"},{"author":{"_account_id":24056,"name":"wei.ying","email":"wei.ying@easystack.cn","username":"wei.ying"},"change_message_id":"e52b1d1e7d9f550d5abb42c91006db901cb37aa8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"   * module and jQuery (for table drawer slide animation in IE9) to be installed."},{"line_number":30,"context_line":"   */"},{"line_number":31,"context_line":"  angular"},{"line_number":32,"context_line":"    .module(\u0027horizon.framework.widgets.table\u0027, [\u0027smart-table\u0027])"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    /**"},{"line_number":35,"context_line":"     * @ngdoc parameters"}],"source_content_type":"text/javascript","patch_set":32,"id":"bf659307_3354f152","line":32,"range":{"start_line":32,"start_character":48,"end_line":32,"end_character":61},"updated":"2018-03-31 16:10:44.000000000","message":"It does not seem necessary to re-inject \u0027smart-table\u0027 since we have already injected in app[1]. Are there any other reasons?\n[1] https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/app.module.js#L30","commit_id":"211010be672feb4a993ed4bf819ea2394c76e187"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"7897e62f3f7701fcb266b670df61eed61def9790","unresolved":false,"context_lines":[{"line_number":29,"context_line":"   * module and jQuery (for table drawer slide animation in IE9) to be installed."},{"line_number":30,"context_line":"   */"},{"line_number":31,"context_line":"  angular"},{"line_number":32,"context_line":"    .module(\u0027horizon.framework.widgets.table\u0027, [\u0027smart-table\u0027])"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    /**"},{"line_number":35,"context_line":"     * @ngdoc parameters"}],"source_content_type":"text/javascript","patch_set":32,"id":"bf659307_fd7f98a8","line":32,"range":{"start_line":32,"start_character":48,"end_line":32,"end_character":61},"in_reply_to":"bf659307_3354f152","updated":"2018-04-09 07:35:21.000000000","message":"Done","commit_id":"211010be672feb4a993ed4bf819ea2394c76e187"},{"author":{"_account_id":8478,"name":"Vladislav Kuzmin","email":"vkuzmin@mirantis.com","username":"vkuzmin"},"change_message_id":"b4fade232bbcb3ca6a54acec089e51aacc31a6ac","unresolved":false,"context_lines":[{"line_number":29,"context_line":"   * module and jQuery (for table drawer slide animation in IE9) to be installed."},{"line_number":30,"context_line":"   */"},{"line_number":31,"context_line":"  angular"},{"line_number":32,"context_line":"    .module(\u0027horizon.framework.widgets.table\u0027, [\u0027smart-table\u0027])"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    /**"},{"line_number":35,"context_line":"     * @ngdoc parameters"}],"source_content_type":"text/javascript","patch_set":32,"id":"bf659307_bbce08b2","line":32,"range":{"start_line":32,"start_character":48,"end_line":32,"end_character":61},"in_reply_to":"bf659307_3354f152","updated":"2018-04-09 08:36:53.000000000","message":"If we don\u0027t inject it here then we get the following error:\n\n\u001b[1A\u001b[2KChromium 65.0.3325 (Ubuntu 0.0.0) horizon.framework when unauthorized should redirect to /auth/logout and add an unauthorized toast message  FAILED\nError: [$injector:modulerr] Failed to instantiate module horizon.framework due to:\nError: [$injector:modulerr] Failed to instantiate module horizon.framework.widgets due to:\nError: [$injector:modulerr] Failed to instantiate module horizon.framework.widgets.table due to:\nError: [$injector:unpr] Unknown provider: stConfig\nhttp://errors.angularjs.org/1.5.8/$injector/unpr?p0\u003dstConfig","commit_id":"211010be672feb4a993ed4bf819ea2394c76e187"}],"openstack_dashboard/static/app/app.module.js":[{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"fe961fbab9c1994416b33f6ee5d9221dfc897b75","unresolved":false,"context_lines":[{"line_number":98,"context_line":"      tableOptions.pageSize \u003d pageSize;"},{"line_number":99,"context_line":"    } else {"},{"line_number":100,"context_line":"      settingsService.getSetting(\u0027API_RESULT_PAGE_SIZE\u0027)"},{"line_number":101,"context_line":"        .then(function(data) {"},{"line_number":102,"context_line":"          tableOptions.pageSize \u003d data;"},{"line_number":103,"context_line":"        });"},{"line_number":104,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":7,"id":"ba15a1d1_d28e81cf","line":101,"updated":"2015-09-16 13:50:07.000000000","message":"nit: this function should be named","commit_id":"0b58e5bb10ad66be24d92f5af56984d82f90097c"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"55167b08b1f5b4d68ce397fa369b6826cfe57ba5","unresolved":false,"context_lines":[{"line_number":98,"context_line":"      tableOptions.pageSize \u003d pageSize;"},{"line_number":99,"context_line":"    } else {"},{"line_number":100,"context_line":"      settingsService.getSetting(\u0027API_RESULT_PAGE_SIZE\u0027)"},{"line_number":101,"context_line":"        .then(function(data) {"},{"line_number":102,"context_line":"          tableOptions.pageSize \u003d data;"},{"line_number":103,"context_line":"        });"},{"line_number":104,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":7,"id":"ba15a1d1_23f903c9","line":101,"in_reply_to":"ba15a1d1_d28e81cf","updated":"2015-09-21 18:03:51.000000000","message":"Done","commit_id":"0b58e5bb10ad66be24d92f5af56984d82f90097c"}]}