)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17130,"name":"melissaml","email":"ma.lei@99cloud.net","username":"malei"},"change_message_id":"7ab1af22ae2bde993272d6085533114c62babd42","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adding identity ng-roles panel"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a angular roles table."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"To be added in subsequent patches:"},{"line_number":12,"context_line":" - Actions"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"bacf61ea_cef8904c","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":17},"updated":"2016-08-03 03:53:22.000000000","message":"an","commit_id":"c1e5f89dc12d7c3a1977109c6d1401fb9a138da4"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"761619a24845dfe580e3a8be700c63487e633aa6","unresolved":false,"context_lines":[{"line_number":13,"context_line":" - filterFacets"},{"line_number":14,"context_line":" - Integration to Searchlight"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"To test set \u0027roles_panel\u0027 to True in settings.py"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ie0eb168774f15536c778917abeb293e79d3b34e8"},{"line_number":19,"context_line":"Co-Authored-By: Allen \u003cchen.qiaomin@99cloud.net\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":35,"id":"ba5201f7_f7a51d04","line":16,"updated":"2017-01-03 23:17:33.000000000","message":"Worthwhile to also mention that it needs Keystone V3 enabled.","commit_id":"9c6506d7521ea4245247073a798f5fc929dc7660"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"e5a3e250e5ed2928c8f07a95a9f33e52c02fe608","unresolved":false,"context_lines":[{"line_number":13,"context_line":" - filterFacets"},{"line_number":14,"context_line":" - Integration to Searchlight"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"To test set \u0027roles_panel\u0027 to True in settings.py"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ie0eb168774f15536c778917abeb293e79d3b34e8"},{"line_number":19,"context_line":"Co-Authored-By: Allen \u003cchen.qiaomin@99cloud.net\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":35,"id":"ba5201f7_4fce292f","line":16,"in_reply_to":"ba5201f7_f7a51d04","updated":"2017-01-04 20:16:53.000000000","message":"Done","commit_id":"9c6506d7521ea4245247073a798f5fc929dc7660"}],"openstack_dashboard/dashboards/identity/ngroles/panel.py":[{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"979159bd34cff68233db7700e73c50dcb1d24a8d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 IBM Corp."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_d8548222","line":1,"updated":"2016-07-20 01:56:55.000000000","message":"delete above line","commit_id":"c7ab47cd6806e37ee0c33cd777a48ba71c5c8d23"}],"openstack_dashboard/dashboards/identity/ngroles/templates/ngroles/index.html":[{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"d7d8cdb176e78902f69b6f94dbab3bcaad8c5ded","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Roles\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  {% include \"horizon/common/_domain_page_header.html\" with title\u003d_(\"Roles\") %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":2,"id":"ba15a1d1_e69b00c8","line":6,"updated":"2015-09-15 13:24:10.000000000","message":"shouldn\u0027t we be using hz-page-header directive?","commit_id":"1bd882c36080231e80064cf5ede7c3792e8b60de"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"3220ca39d8e27c4b72af4581ee48390c451d6bb0","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Roles\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  {% include \"horizon/common/_domain_page_header.html\" with title\u003d_(\"Roles\") %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":2,"id":"ba15a1d1_a5865011","line":6,"in_reply_to":"ba15a1d1_e69b00c8","updated":"2015-09-15 17:37:18.000000000","message":"Done","commit_id":"1bd882c36080231e80064cf5ede7c3792e8b60de"}],"openstack_dashboard/dashboards/identity/roles/urls.py":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"a7c862f4e0b319a608ba027ca3e1f9f25f26de25","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from openstack_dashboard.dashboards.identity.roles import views"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if settings.ANGULAR_FEATURES[\u0027roles_panel\u0027]:"},{"line_number":21,"context_line":"    # New angular panel"},{"line_number":22,"context_line":"    urlpatterns \u003d ["},{"line_number":23,"context_line":"        url(r\u0027^$\u0027, views.AngularIndexView.as_view(), name\u003d\u0027index\u0027),"}],"source_content_type":"text/x-python","patch_set":23,"id":"da6895a0_f699f920","line":20,"updated":"2016-10-21 02:09:45.000000000","message":"please use settings.ANGULAR_FEATURES.get(\u0027roles_panel\u0027, False) to ease upgrading.","commit_id":"c1659115382e938746edeed7b2a929c32f3f42b8"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"016653030426c740418ae86339cb61945a0bac08","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        url(r\u0027^$\u0027, views.AngularIndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":24,"context_line":"        url(r\u0027^(?P\u003crole_id\u003e[^/]+)/update/$\u0027,"},{"line_number":25,"context_line":"            views.UpdateView.as_view(), name\u003d\u0027update\u0027),"},{"line_number":26,"context_line":"        url(r\u0027^create/$\u0027, views.CreateView.as_view(), name\u003d\u0027create\u0027),"},{"line_number":27,"context_line":"    ]"},{"line_number":28,"context_line":"else:"},{"line_number":29,"context_line":"    urlpatterns \u003d ["}],"source_content_type":"text/x-python","patch_set":28,"id":"3a71b18c_81d979f5","line":26,"updated":"2016-12-07 03:25:32.000000000","message":"Is there any link to these other two non-angular views? I can\u0027t find any reverse url lookups on them. We shouldn\u0027t include them if they\u0027re not used in the interface.","commit_id":"0dc9dd23f4ecc55a06128dd4ed062d55dd6c9ce6"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"701fad29a7e23a5ee6d51a4ff548d041dcf2b371","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        url(r\u0027^$\u0027, views.AngularIndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":24,"context_line":"        url(r\u0027^(?P\u003crole_id\u003e[^/]+)/update/$\u0027,"},{"line_number":25,"context_line":"            views.UpdateView.as_view(), name\u003d\u0027update\u0027),"},{"line_number":26,"context_line":"        url(r\u0027^create/$\u0027, views.CreateView.as_view(), name\u003d\u0027create\u0027),"},{"line_number":27,"context_line":"    ]"},{"line_number":28,"context_line":"else:"},{"line_number":29,"context_line":"    urlpatterns \u003d ["}],"source_content_type":"text/x-python","patch_set":28,"id":"1a6eadb0_9be6a1ae","line":26,"in_reply_to":"3a71b18c_81d979f5","updated":"2016-12-15 04:09:14.000000000","message":"Done","commit_id":"0dc9dd23f4ecc55a06128dd4ed062d55dd6c9ce6"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"7b62c5c53c46d077742dc61cd0664b82456e24bb","unresolved":false,"context_lines":[{"line_number":20,"context_line":"if settings.ANGULAR_FEATURES.get(\u0027roles_panel\u0027, False):"},{"line_number":21,"context_line":"    # New angular panel"},{"line_number":22,"context_line":"    urlpatterns \u003d ["},{"line_number":23,"context_line":"        url(r\u0027^$\u0027, views.AngularIndexView.as_view(), name\u003d\u0027index\u0027),"},{"line_number":24,"context_line":"    ]"},{"line_number":25,"context_line":"else:"},{"line_number":26,"context_line":"    urlpatterns \u003d ["}],"source_content_type":"text/x-python","patch_set":31,"id":"1a6eadb0_b14995b9","line":23,"updated":"2016-12-15 20:39:51.000000000","message":"from horizon.browsers.views import AngularIndexView\n\nrather than defining in views.py","commit_id":"a9fb6e9329b3fd1804f922f48fbb7e3c5fac07d1"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"761619a24845dfe580e3a8be700c63487e633aa6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    # New angular panel"},{"line_number":24,"context_line":"    title \u003d _(\u0027Roles\u0027)"},{"line_number":25,"context_line":"    urlpatterns \u003d ["},{"line_number":26,"context_line":"        url(r\u0027^$\u0027, AngularIndexView.as_view(title\u003dtitle), name\u003d\u0027index\u0027),"},{"line_number":27,"context_line":"    ]"},{"line_number":28,"context_line":"else:"},{"line_number":29,"context_line":"    urlpatterns \u003d ["}],"source_content_type":"text/x-python","patch_set":35,"id":"ba5201f7_b7dd5516","line":26,"updated":"2017-01-03 23:17:33.000000000","message":"Currently, this returns a \"Unable to retrieve roles\" error message instead of the default \"Insufficient privilege\" info message. This tells me that policy checks are missing. I understand its well out of the scope of this patch, but its something we should look into.","commit_id":"9c6506d7521ea4245247073a798f5fc929dc7660"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"e5a3e250e5ed2928c8f07a95a9f33e52c02fe608","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    # New angular panel"},{"line_number":24,"context_line":"    title \u003d _(\u0027Roles\u0027)"},{"line_number":25,"context_line":"    urlpatterns \u003d ["},{"line_number":26,"context_line":"        url(r\u0027^$\u0027, AngularIndexView.as_view(title\u003dtitle), name\u003d\u0027index\u0027),"},{"line_number":27,"context_line":"    ]"},{"line_number":28,"context_line":"else:"},{"line_number":29,"context_line":"    urlpatterns \u003d ["}],"source_content_type":"text/x-python","patch_set":35,"id":"ba5201f7_0f4a61ac","line":26,"in_reply_to":"ba5201f7_b7dd5516","updated":"2017-01-04 20:16:53.000000000","message":"How did you get the error to show up?\n\nI believe \nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/roles/panel.py#L35 handles the policy checks right now. Both v3 and roles_panel\u003dTrue need to be set to see the Roles panel. Otherwise, nothing should be there.","commit_id":"9c6506d7521ea4245247073a798f5fc929dc7660"}],"openstack_dashboard/dashboards/identity/roles/views.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"7b62c5c53c46d077742dc61cd0664b82456e24bb","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class AngularIndexView(generic.TemplateView):"},{"line_number":36,"context_line":"    template_name \u003d \u0027angular.html\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class IndexView(tables.DataTableView):"}],"source_content_type":"text/x-python","patch_set":31,"id":"1a6eadb0_d1c8d124","line":36,"updated":"2016-12-15 20:39:51.000000000","message":"remove","commit_id":"a9fb6e9329b3fd1804f922f48fbb7e3c5fac07d1"}],"openstack_dashboard/dashboards/identity/static/dashboard/identity/identity.module.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"cc361a7a97dce33567f5da0bb8c2f4d64616c343","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    .module(\u0027horizon.dashboard.identity\u0027, ["},{"line_number":29,"context_line":"      \u0027horizon.dashboard.identity.users\u0027,"},{"line_number":30,"context_line":"      \u0027horizon.dashboard.identity.projects\u0027,"},{"line_number":31,"context_line":"      \u0027horizon.dashboard.identity.roles\u0027"},{"line_number":32,"context_line":"    ])"},{"line_number":33,"context_line":"    .config(config);"},{"line_number":34,"context_line":""}],"source_content_type":"text/javascript","patch_set":14,"id":"dada55a8_b09e0c52","line":31,"updated":"2016-07-25 22:20:25.000000000","message":"can we alphabetize?","commit_id":"c1e5f89dc12d7c3a1977109c6d1401fb9a138da4"}],"openstack_dashboard/dashboards/identity/static/dashboard/identity/identity.module.spec.js":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"a7c862f4e0b319a608ba027ca3e1f9f25f26de25","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    });"},{"line_number":23,"context_line":"  });"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  describe(\u0027horizon.dashboard.identity.basePath constant\u0027, function() {"},{"line_number":26,"context_line":"    var identityBasePath, staticUrl;"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    beforeEach(module(\u0027horizon.dashboard.identity\u0027));"}],"source_content_type":"text/javascript","patch_set":23,"id":"da6895a0_d125dfae","side":"PARENT","line":25,"updated":"2016-10-21 02:09:45.000000000","message":"I don\u0027t know why this was removed - there\u0027s no comment about it around patchset 12/14 (when the change was made), and no mention in the commit message.","commit_id":"3ef91f17c37454d2258e32fe13e25a5251ec5718"}],"openstack_dashboard/dashboards/identity/static/dashboard/identity/roles/roles.module.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"cc361a7a97dce33567f5da0bb8c2f4d64616c343","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  function run(registry, keystone, basePath, roleResourceType) {"},{"line_number":44,"context_line":"    registry.getResourceType(roleResourceType)"},{"line_number":45,"context_line":"      .setNames(gettext(\u0027Role\u0027), gettext(\u0027Roles\u0027))"},{"line_number":46,"context_line":"      .setSummaryTemplateUrl(basePath + \u0027details/drawer.html\u0027)"},{"line_number":47,"context_line":"      .setProperty(\u0027name\u0027, {"},{"line_number":48,"context_line":"        label: gettext(\u0027Name\u0027)"},{"line_number":49,"context_line":"      })"}],"source_content_type":"text/javascript","patch_set":14,"id":"dada55a8_6712170b","line":46,"updated":"2016-07-25 22:20:25.000000000","message":"as Daniel suggested, remove this since we don\u0027t have any details","commit_id":"c1e5f89dc12d7c3a1977109c6d1401fb9a138da4"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"a5528756f00bdcc102a61e4c01b524725073bdbc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  function run(registry, keystone, basePath, roleResourceType) {"},{"line_number":44,"context_line":"    registry.getResourceType(roleResourceType)"},{"line_number":45,"context_line":"      .setNames(gettext(\u0027Role\u0027), gettext(\u0027Roles\u0027))"},{"line_number":46,"context_line":"      .setSummaryTemplateUrl(basePath + \u0027details/drawer.html\u0027)"},{"line_number":47,"context_line":"      .setProperty(\u0027name\u0027, {"},{"line_number":48,"context_line":"        label: gettext(\u0027Name\u0027)"},{"line_number":49,"context_line":"      })"}],"source_content_type":"text/javascript","patch_set":14,"id":"dada55a8_229be419","line":46,"in_reply_to":"dada55a8_6712170b","updated":"2016-07-26 03:48:05.000000000","message":"don\u0027t setSummaryTemplateUrl if drawer.html is empty, we have fix it:https://review.openstack.org/#/c/344819/","commit_id":"c1e5f89dc12d7c3a1977109c6d1401fb9a138da4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"cc361a7a97dce33567f5da0bb8c2f4d64616c343","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      })"},{"line_number":56,"context_line":"      .setProperty(\u0027links\u0027, {"},{"line_number":57,"context_line":"        label: gettext(\u0027Links\u0027)"},{"line_number":58,"context_line":"      })"},{"line_number":59,"context_line":"      .setListFunction(listFunction)"},{"line_number":60,"context_line":"      .tableColumns"},{"line_number":61,"context_line":"      .append({"}],"source_content_type":"text/javascript","patch_set":14,"id":"dada55a8_a7f36f9e","line":58,"updated":"2016-07-25 22:20:25.000000000","message":"if not used, remove","commit_id":"c1e5f89dc12d7c3a1977109c6d1401fb9a138da4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"cc361a7a97dce33567f5da0bb8c2f4d64616c343","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        label: gettext(\u0027Links\u0027)"},{"line_number":58,"context_line":"      })"},{"line_number":59,"context_line":"      .setListFunction(listFunction)"},{"line_number":60,"context_line":"      .tableColumns"},{"line_number":61,"context_line":"      .append({"},{"line_number":62,"context_line":"        id: \u0027name\u0027,"},{"line_number":63,"context_line":"        priority: 1,"}],"source_content_type":"text/javascript","patch_set":14,"id":"dada55a8_c720234c","line":60,"updated":"2016-07-25 22:20:25.000000000","message":"you can also add https://github.com/openstack/horizon/blob/master/horizon/static/framework/widgets/table/hz-dynamic-table.directive.js#L60\n\nto hide it","commit_id":"c1e5f89dc12d7c3a1977109c6d1401fb9a138da4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"cc361a7a97dce33567f5da0bb8c2f4d64616c343","unresolved":false,"context_lines":[{"line_number":61,"context_line":"      .append({"},{"line_number":62,"context_line":"        id: \u0027name\u0027,"},{"line_number":63,"context_line":"        priority: 1,"},{"line_number":64,"context_line":"        sortDefault: true,"},{"line_number":65,"context_line":"      })"},{"line_number":66,"context_line":"      .append({"},{"line_number":67,"context_line":"        id: \u0027id\u0027,"}],"source_content_type":"text/javascript","patch_set":14,"id":"dada55a8_670cd73b","line":64,"updated":"2016-07-25 22:20:25.000000000","message":"unnecessary comma","commit_id":"c1e5f89dc12d7c3a1977109c6d1401fb9a138da4"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"2e817c86d227897a925abf9d759929dd6514561d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  function run(registry, keystone, basePath, roleResourceType) {"},{"line_number":44,"context_line":"    registry.getResourceType(roleResourceType)"},{"line_number":45,"context_line":"      .setNames(gettext(\u0027Role\u0027), gettext(\u0027Roles\u0027))"},{"line_number":46,"context_line":"      .setProperty(\u0027name\u0027, {"},{"line_number":47,"context_line":"        label: gettext(\u0027Name\u0027)"},{"line_number":48,"context_line":"      })"},{"line_number":49,"context_line":"      .setProperty(\u0027id\u0027, {"}],"source_content_type":"text/javascript","patch_set":19,"id":"1a95cdbc_a2d58ae5","line":46,"updated":"2016-10-10 16:53:01.000000000","message":"Use the new setProperties instead.","commit_id":"de6dc83cd2c7883caaa14e86f29df53fcb667000"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"1f00351f11445e5c39bf2dcaf9a01ac97270abcf","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \u0027horizon.dashboard.identity.roles.resourceType\u0027"},{"line_number":41,"context_line":"  ];"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  function run(registry, keystone, basePath, roleResourceType) {"},{"line_number":44,"context_line":"    registry.getResourceType(roleResourceType)"},{"line_number":45,"context_line":"      .setNames(gettext(\u0027Role\u0027), gettext(\u0027Roles\u0027))"},{"line_number":46,"context_line":"      .setProperties(roleProperties())"}],"source_content_type":"text/javascript","patch_set":20,"id":"fa6399be_17882be7","line":43,"updated":"2016-10-11 01:23:32.000000000","message":"basePath is not used.","commit_id":"0753bb94680de3df47d0c8dfa09abc8f8c8f1698"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"1f00351f11445e5c39bf2dcaf9a01ac97270abcf","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    var path \u003d $windowProvider.$get().STATIC_URL + \u0027dashboard/identity/roles/\u0027;"},{"line_number":91,"context_line":"    $provide.constant(\u0027horizon.dashboard.identity.roles.basePath\u0027, path);"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    $routeProvider.when(\u0027/identity/ngroles/\u0027, {"},{"line_number":94,"context_line":"      templateUrl: path + \u0027panel.html\u0027"},{"line_number":95,"context_line":"    });"},{"line_number":96,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":20,"id":"fa6399be_f759f78f","line":93,"updated":"2016-10-11 01:23:32.000000000","message":"/identity/ngroles/ -\u003e /identity/ngroles\n\nIn order to avoid duplicate requests.","commit_id":"0753bb94680de3df47d0c8dfa09abc8f8c8f1698"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"7029a6b17136b2d81ecf8d9e31d3e4aa376476ae","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        priority: 1"},{"line_number":56,"context_line":"      });"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    function listFunction() {"},{"line_number":59,"context_line":"      return keystone.getRoles();"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":""}],"source_content_type":"text/javascript","patch_set":23,"id":"da6895a0_0ad8f952","line":58,"updated":"2016-10-21 05:59:57.000000000","message":"Could we define this method in roles.service?","commit_id":"c1659115382e938746edeed7b2a929c32f3f42b8"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"7029a6b17136b2d81ecf8d9e31d3e4aa376476ae","unresolved":false,"context_lines":[{"line_number":65,"context_line":"     */"},{"line_number":66,"context_line":"    function roleProperties() {"},{"line_number":67,"context_line":"      return {"},{"line_number":68,"context_line":"        name: gettext(\u0027Name\u0027),"},{"line_number":69,"context_line":"        id: gettext(\u0027ID\u0027)"},{"line_number":70,"context_line":"      };"},{"line_number":71,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":23,"id":"da6895a0_2a269d68","line":68,"updated":"2016-10-21 05:59:57.000000000","message":"It should be added noName filter","commit_id":"c1659115382e938746edeed7b2a929c32f3f42b8"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"016653030426c740418ae86339cb61945a0bac08","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    /**"},{"line_number":63,"context_line":"     * @name roleProperties"},{"line_number":64,"context_line":"     * @description resource properties for role module"},{"line_number":65,"context_line":"     */"},{"line_number":66,"context_line":"    function roleProperties() {"},{"line_number":67,"context_line":"      return {"},{"line_number":68,"context_line":"        name: { label: gettext(\u0027Name\u0027), filters: [\u0027noName\u0027] },"}],"source_content_type":"text/javascript","patch_set":28,"id":"3a71b18c_a180358c","line":65,"updated":"2016-12-07 03:25:32.000000000","message":"I\u0027m not sure this comment adds anything to the code.","commit_id":"0dc9dd23f4ecc55a06128dd4ed062d55dd6c9ce6"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"701fad29a7e23a5ee6d51a4ff548d041dcf2b371","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    /**"},{"line_number":63,"context_line":"     * @name roleProperties"},{"line_number":64,"context_line":"     * @description resource properties for role module"},{"line_number":65,"context_line":"     */"},{"line_number":66,"context_line":"    function roleProperties() {"},{"line_number":67,"context_line":"      return {"},{"line_number":68,"context_line":"        name: { label: gettext(\u0027Name\u0027), filters: [\u0027noName\u0027] },"}],"source_content_type":"text/javascript","patch_set":28,"id":"1a6eadb0_db04994b","line":65,"in_reply_to":"3a71b18c_a180358c","updated":"2016-12-15 04:09:14.000000000","message":"Done","commit_id":"0dc9dd23f4ecc55a06128dd4ed062d55dd6c9ce6"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"016653030426c740418ae86339cb61945a0bac08","unresolved":false,"context_lines":[{"line_number":84,"context_line":"   * @param {Object} $routeProvider"},{"line_number":85,"context_line":"   * @description Routes used by this module."},{"line_number":86,"context_line":"   * @returns {undefined} Returns nothing"},{"line_number":87,"context_line":"   */"},{"line_number":88,"context_line":"  function config($provide, $windowProvider, $routeProvider) {"},{"line_number":89,"context_line":"    var path \u003d $windowProvider.$get().STATIC_URL + \u0027dashboard/identity/roles/\u0027;"},{"line_number":90,"context_line":"    $provide.constant(\u0027horizon.dashboard.identity.roles.basePath\u0027, path);"}],"source_content_type":"text/javascript","patch_set":28,"id":"3a71b18c_81aed92b","line":87,"updated":"2016-12-07 03:25:32.000000000","message":"I\u0027m not sure we need the above - config isn\u0027t an API callable, so we don\u0027t need to document it for developers. Having a comment that just declares its intent (\"Define the routes and basePath for this module.\") is probably enough, though given the size of the function and its existing clarity, even that is probably overkill I think :-)","commit_id":"0dc9dd23f4ecc55a06128dd4ed062d55dd6c9ce6"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"701fad29a7e23a5ee6d51a4ff548d041dcf2b371","unresolved":false,"context_lines":[{"line_number":84,"context_line":"   * @param {Object} $routeProvider"},{"line_number":85,"context_line":"   * @description Routes used by this module."},{"line_number":86,"context_line":"   * @returns {undefined} Returns nothing"},{"line_number":87,"context_line":"   */"},{"line_number":88,"context_line":"  function config($provide, $windowProvider, $routeProvider) {"},{"line_number":89,"context_line":"    var path \u003d $windowProvider.$get().STATIC_URL + \u0027dashboard/identity/roles/\u0027;"},{"line_number":90,"context_line":"    $provide.constant(\u0027horizon.dashboard.identity.roles.basePath\u0027, path);"}],"source_content_type":"text/javascript","patch_set":28,"id":"1a6eadb0_bbeb5d77","line":87,"in_reply_to":"3a71b18c_81aed92b","updated":"2016-12-15 04:09:14.000000000","message":"Done","commit_id":"0dc9dd23f4ecc55a06128dd4ed062d55dd6c9ce6"}],"openstack_dashboard/dashboards/identity/static/dashboard/identity/roles/roles.module.spec.js":[{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"979159bd34cff68233db7700e73c50dcb1d24a8d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/**"},{"line_number":2,"context_line":" * Copyright 2015 IBM Corp."},{"line_number":3,"context_line":" * Copyright 2016 99Cloud"},{"line_number":4,"context_line":" *"},{"line_number":5,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/javascript","patch_set":10,"id":"dada55a8_d87da2b2","line":2,"updated":"2016-07-20 01:56:55.000000000","message":"delete above line","commit_id":"c7ab47cd6806e37ee0c33cd777a48ba71c5c8d23"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"2e817c86d227897a925abf9d759929dd6514561d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"(function () {"},{"line_number":17,"context_line":"  \u0027use strict\u0027;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  describe(\u0027horizon.dashboard.identity.roles\u0027, function () {"},{"line_number":20,"context_line":"    it(\u0027should exist\u0027, function () {"},{"line_number":21,"context_line":"      expect(angular.module(\u0027horizon.dashboard.identity.roles\u0027)).toBeDefined();"},{"line_number":22,"context_line":"    });"}],"source_content_type":"text/javascript","patch_set":19,"id":"1a95cdbc_8276ce03","line":19,"updated":"2016-10-10 16:53:01.000000000","message":"Not sure how useful these spec files are... something to discuss at the summit. Perhaps better to just not include them?","commit_id":"de6dc83cd2c7883caaa14e86f29df53fcb667000"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"a7c862f4e0b319a608ba027ca3e1f9f25f26de25","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    it(\u0027should exist\u0027, function () {"},{"line_number":21,"context_line":"      expect(angular.module(\u0027horizon.dashboard.identity.roles\u0027)).toBeDefined();"},{"line_number":22,"context_line":"    });"},{"line_number":23,"context_line":"  });"},{"line_number":24,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":23,"id":"da6895a0_713ed3b9","line":23,"updated":"2016-10-21 02:09:45.000000000","message":"I think there should be an assertion that horizon.dashboard.identity.roles.basePath is defined here.","commit_id":"c1659115382e938746edeed7b2a929c32f3f42b8"}],"openstack_dashboard/dashboards/identity/static/dashboard/identity/roles/table/table.controller.js":[{"author":{"_account_id":15742,"name":"Paulo Ewerton Gomes Fragoso","email":"pauloewerton@lsd.ufcg.edu.br","username":"pauloewerton"},"change_message_id":"d7d8cdb176e78902f69b6f94dbab3bcaad8c5ded","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        keystone.getCurrentUserSession().success(getSessionSuccess);"},{"line_number":62,"context_line":"      }"},{"line_number":63,"context_line":"      else {"},{"line_number":64,"context_line":"        var msg \u003d gettext(\u0027Insufficient privilege level to view user information.\u0027);"},{"line_number":65,"context_line":"        toast.add(\u0027info\u0027, msg);"},{"line_number":66,"context_line":"      }"},{"line_number":67,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba15a1d1_9bacdd36","line":64,"updated":"2015-09-15 13:24:10.000000000","message":"nit: wouldn\u0027t it be \u0027role information\u0027?","commit_id":"1bd882c36080231e80064cf5ede7c3792e8b60de"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"3220ca39d8e27c4b72af4581ee48390c451d6bb0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        keystone.getCurrentUserSession().success(getSessionSuccess);"},{"line_number":62,"context_line":"      }"},{"line_number":63,"context_line":"      else {"},{"line_number":64,"context_line":"        var msg \u003d gettext(\u0027Insufficient privilege level to view user information.\u0027);"},{"line_number":65,"context_line":"        toast.add(\u0027info\u0027, msg);"},{"line_number":66,"context_line":"      }"},{"line_number":67,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba15a1d1_2573204f","line":64,"in_reply_to":"ba15a1d1_9bacdd36","updated":"2015-09-15 17:37:18.000000000","message":"Done","commit_id":"1bd882c36080231e80064cf5ede7c3792e8b60de"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"bdf7e5e4fb9289ff0c98dcb7c29c10fc14807837","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  \u0027use strict\u0027;"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  /**"},{"line_number":21,"context_line":"   * @ngdoc identityRolesTableController"},{"line_number":22,"context_line":"   * @ngController"},{"line_number":23,"context_line":"   *"},{"line_number":24,"context_line":"   * @description"}],"source_content_type":"text/javascript","patch_set":4,"id":"ba15a1d1_27104fa8","line":21,"updated":"2015-09-21 06:05:15.000000000","message":"this doc string should be moved to line #38","commit_id":"8587ac12c8332c3972ab1af45e3ab2e09be217db"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"7aa146c21bd2682c80fb128ec5411cc810ca71b0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  \u0027use strict\u0027;"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  /**"},{"line_number":21,"context_line":"   * @ngdoc identityRolesTableController"},{"line_number":22,"context_line":"   * @ngController"},{"line_number":23,"context_line":"   *"},{"line_number":24,"context_line":"   * @description"}],"source_content_type":"text/javascript","patch_set":4,"id":"ba15a1d1_0df9904d","line":21,"in_reply_to":"ba15a1d1_27104fa8","updated":"2015-09-21 17:32:31.000000000","message":"Done","commit_id":"8587ac12c8332c3972ab1af45e3ab2e09be217db"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"15690dec93df625b44b574c76a87d91ceea93be1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"   * Controller for the identity roles table."},{"line_number":37,"context_line":"   * Serve as the focal point for table actions."},{"line_number":38,"context_line":"   */"},{"line_number":39,"context_line":"  function identityRolesTableController(toast, gettext, policy, keystone) {"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    var ctrl \u003d this;"},{"line_number":42,"context_line":"    ctrl.roles \u003d [];"}],"source_content_type":"text/javascript","patch_set":8,"id":"ba8a016a_f4b085df","line":39,"updated":"2015-11-17 14:40:37.000000000","message":"controller name should start with capital letter.","commit_id":"01c77164798147b9bf9a6493af61d4447f7c0b5a"}],"openstack_dashboard/dashboards/identity/static/dashboard/identity/roles/table/table.html":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"8e383783f23a71b936cf3cddd1614aa7fe4c085f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  \u003cthead\u003e"},{"line_number":10,"context_line":"    \u003c!--"},{"line_number":11,"context_line":"      Table-batch-actions:"},{"line_number":12,"context_line":"      This is where batch actions like searching, creating, and deleting."},{"line_number":13,"context_line":"    --\u003e"},{"line_number":14,"context_line":"    \u003ctr\u003e"},{"line_number":15,"context_line":"      \u003cth colspan\u003d\"100\" class\u003d\"search-header\"\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"ba15a1d1_835f72e4","line":12,"updated":"2015-09-16 05:09:14.000000000","message":"This is not a complete.","commit_id":"0968956cc2ba930943b22a68ff0951b239bfa015"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"8e383783f23a71b936cf3cddd1614aa7fe4c085f","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    \u003c!--"},{"line_number":21,"context_line":"      Table-column-headers:"},{"line_number":22,"context_line":"      This is where we declaratively define the table column headers."},{"line_number":23,"context_line":"      Include select-col if you want to select all."},{"line_number":24,"context_line":"      Include expander if you want to inline details."},{"line_number":25,"context_line":"      Include action-col if you want to perform actions."}],"source_content_type":"text/html","patch_set":3,"id":"ba15a1d1_034da23d","line":22,"updated":"2015-09-16 05:09:14.000000000","message":"\"declaratively define\" is a tautology. Just \"define\" or \"declare\" will do, thanks.","commit_id":"0968956cc2ba930943b22a68ff0951b239bfa015"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"8e383783f23a71b936cf3cddd1614aa7fe4c085f","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  \u003ctbody\u003e"},{"line_number":36,"context_line":"    \u003c!--"},{"line_number":37,"context_line":"      Table-rows:"},{"line_number":38,"context_line":"      This is where we declaratively define the table columns."},{"line_number":39,"context_line":"      Include select-col if you want to select all."},{"line_number":40,"context_line":"      Include expander if you want to inline details."},{"line_number":41,"context_line":"      Include action-col if you want to perform actions."}],"source_content_type":"text/html","patch_set":3,"id":"ba15a1d1_63457e15","line":38,"updated":"2015-09-16 05:09:14.000000000","message":"As above.","commit_id":"0968956cc2ba930943b22a68ff0951b239bfa015"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"8e383783f23a71b936cf3cddd1614aa7fe4c085f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      This is where we declaratively define the table columns."},{"line_number":39,"context_line":"      Include select-col if you want to select all."},{"line_number":40,"context_line":"      Include expander if you want to inline details."},{"line_number":41,"context_line":"      Include action-col if you want to perform actions."},{"line_number":42,"context_line":"      rsp-p1 rsp-p2 are responsive priority as user resizes window."},{"line_number":43,"context_line":"    --\u003e"},{"line_number":44,"context_line":"    \u003ctr ng-repeat-start\u003d\"role in table.iroles track by role.id\""}],"source_content_type":"text/html","patch_set":3,"id":"ba15a1d1_23c1c680","line":41,"updated":"2015-09-16 05:09:14.000000000","message":"These three lines are obviously cut-n-paste but don\u0027t really make sense in this context. Please edit to indicate what\u0027s actually in the page.","commit_id":"0968956cc2ba930943b22a68ff0951b239bfa015"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"8e383783f23a71b936cf3cddd1614aa7fe4c085f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \u003c!--"},{"line_number":58,"context_line":"      Detail-row:"},{"line_number":59,"context_line":"      Contains detailed information on this item."},{"line_number":60,"context_line":"      Can be toggled using the chevron button."},{"line_number":61,"context_line":"      Ensure colspan is greater or equal to number of column-headers."},{"line_number":62,"context_line":"    --\u003e"},{"line_number":63,"context_line":"    \u003ctr ng-repeat-end class\u003d\"detail-row\"\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"ba15a1d1_63cedeb5","line":60,"updated":"2015-09-16 05:09:14.000000000","message":"\"using the expander above\"","commit_id":"0968956cc2ba930943b22a68ff0951b239bfa015"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"8e383783f23a71b936cf3cddd1614aa7fe4c085f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  \u003c!--"},{"line_number":79,"context_line":"    Table-footer:"},{"line_number":80,"context_line":"    This is where we display number of items and pagination controls."},{"line_number":81,"context_line":"    Ensure colspan is greater or equal to number of column-headers."},{"line_number":82,"context_line":"  --\u003e"},{"line_number":83,"context_line":"  \u003ctfoot hz-table-footer items\u003d\"table.iroles\"\u003e\u003c/tfoot\u003e"},{"line_number":84,"context_line":""}],"source_content_type":"text/html","patch_set":3,"id":"ba15a1d1_c356cad1","line":81,"updated":"2015-09-16 05:09:14.000000000","message":"There is no colspan...","commit_id":"0968956cc2ba930943b22a68ff0951b239bfa015"}],"openstack_dashboard/dashboards/identity/static/dashboard/identity/users/table/table.controller.js":[{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"15690dec93df625b44b574c76a87d91ceea93be1","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  angular"},{"line_number":21,"context_line":"    .module(\u0027horizon.dashboard.identity.users\u0027)"},{"line_number":22,"context_line":"    .controller(\u0027identityUsersTableController\u0027, identityUsersTableController);"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  identityUsersTableController.$inject \u003d ["},{"line_number":25,"context_line":"    \u0027horizon.framework.widgets.toast.service\u0027,"}],"source_content_type":"text/javascript","patch_set":8,"id":"ba8a016a_344b6d89","line":22,"updated":"2015-11-17 14:40:37.000000000","message":"dito","commit_id":"01c77164798147b9bf9a6493af61d4447f7c0b5a"}],"openstack_dashboard/dashboards/identity/static/dashboard/identity/users/table/table.controller.spec.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"2e817c86d227897a925abf9d759929dd6514561d","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    ///////////////////////"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    beforeEach(module(\u0027horizon.framework.util\u0027));"},{"line_number":46,"context_line":"    beforeEach(module(\u0027horizon.framework.conf\u0027));"},{"line_number":47,"context_line":"    beforeEach(module(\u0027horizon.framework.widgets.toast\u0027));"},{"line_number":48,"context_line":"    beforeEach(module(\u0027horizon.app.core.openstack-service-api\u0027));"}],"source_content_type":"text/javascript","patch_set":19,"id":"1a95cdbc_6224620c","line":45,"updated":"2016-10-10 16:53:01.000000000","message":"This seems unrelated...","commit_id":"de6dc83cd2c7883caaa14e86f29df53fcb667000"}],"openstack_dashboard/enabled/_3051_identity_ng_roles_panel.py":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"29194aac5c954252963186f43e9c38330a0546a7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"DISABLED \u003d True"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Python panel class of the PANEL to be added."},{"line_number":30,"context_line":"ADD_PANEL \u003d (\u0027openstack_dashboard.dashboards.identity.ngroles.panel.NGRoles\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_fdfdd86e","line":30,"updated":"2015-09-22 01:41:20.000000000","message":"I just noticed this - why is this string in brackets?","commit_id":"18e6d380d8461912105433eb45a3e9d105370b6c"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"dc7dfbc35bd1c30f54df954fbe7e0821f7710361","unresolved":false,"context_lines":[{"line_number":27,"context_line":"DISABLED \u003d True"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Python panel class of the PANEL to be added."},{"line_number":30,"context_line":"ADD_PANEL \u003d (\u0027openstack_dashboard.dashboards.identity.ngroles.panel.NGRoles\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_ae55bac6","line":30,"in_reply_to":"ba15a1d1_fdfdd86e","updated":"2015-09-22 21:30:39.000000000","message":"Thanks Richard.","commit_id":"18e6d380d8461912105433eb45a3e9d105370b6c"}],"openstack_dashboard/enabled/_3051_identity_roles_panel.py":[{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"979159bd34cff68233db7700e73c50dcb1d24a8d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"PANEL \u003d \u0027ngroless\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# If set to True, this settings file will not be added to the settings."},{"line_number":27,"context_line":"DISABLED \u003d False"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# Python panel class of the PANEL to be added."},{"line_number":30,"context_line":"ADD_PANEL \u003d \u0027openstack_dashboard.dashboards.identity.ngroles.panel.NGRoles\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"dada55a8_5871b2df","line":27,"updated":"2016-07-20 01:56:55.000000000","message":"by default it should True","commit_id":"c7ab47cd6806e37ee0c33cd777a48ba71c5c8d23"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"cc361a7a97dce33567f5da0bb8c2f4d64616c343","unresolved":false,"context_lines":[{"line_number":21,"context_line":"PANEL_GROUP \u003d \u0027default\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# The slug of the panel to be added to HORIZON_CONFIG. Required."},{"line_number":24,"context_line":"PANEL \u003d \u0027ngroless\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# If set to True, this settings file will not be added to the settings."},{"line_number":27,"context_line":"DISABLED \u003d True"}],"source_content_type":"text/x-python","patch_set":14,"id":"dada55a8_ea9a516d","line":24,"updated":"2016-07-25 22:20:25.000000000","message":"extra s","commit_id":"c1e5f89dc12d7c3a1977109c6d1401fb9a138da4"}]}
