)]}'
{"openstack_dashboard/dashboards/project/network_topology/templates/network_topology/index.html":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"896ad0df72e7a8eddf47106ca5ccc854116d0052","unresolved":false,"context_lines":[{"line_number":20,"context_line":"}"},{"line_number":21,"context_line":"\u003c/style\u003e"},{"line_number":22,"context_line":"\u003cnoscript\u003e"},{"line_number":23,"context_line":"{%trans \"This pane needs javascript support.\" %}"},{"line_number":24,"context_line":"\u003c/noscript\u003e"},{"line_number":25,"context_line":"\u003cdiv class\u003d\"launchButtons\"\u003e"},{"line_number":26,"context_line":"\u003ca href\u003d\"{% url horizon:project:instances:launch %}\" id\u003d\"instances__action_launch\" class\u003d\"btn btn-small btn-launch ajax-modal\"\u003e{%trans \"Launch Instance\" %}\u003c/a\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"AAAAM3%2F%2BkKQ%3D","line":23,"updated":"2013-02-27 07:02:50.000000000","message":"Having a space between {% and trans would make it look better. :)","commit_id":"498d24020bb838038fdaeca59198fde6c7065b75"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"57e881be0725fa80b3a2456175e1db1569edfc3a","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"\u003cdiv id\u003d\"topologyCanvas\"\u003e"},{"line_number":32,"context_line":"    \u003cdiv class\u003d\"networks\"\u003e\u003c/div\u003e"},{"line_number":33,"context_line":"    \u003cdiv class\u003d\"nodata\"\u003e{% blocktrans %}There are no networks, routers and servers to draw topology. {% endblocktrans %}\u003c/div\u003e"},{"line_number":34,"context_line":"\u003c/div\u003e"},{"line_number":35,"context_line":"\u003cspan data-networktopology\u003d\"{% url horizon:project:network_topology:json %}\" id\u003d\"networktopology\"\u003e\u003c/span\u003e"},{"line_number":36,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":2,"id":"AAAAM3%2F%2Bsw0%3D","line":33,"updated":"2013-02-21 08:06:49.000000000","message":"\"to draw topology\" may be unnecessary.","commit_id":"498d24020bb838038fdaeca59198fde6c7065b75"},{"author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"change_message_id":"e3b01b3cd3197bc47323d9c3b20a75a31cd089ef","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"\u003cdiv id\u003d\"topologyCanvas\"\u003e"},{"line_number":32,"context_line":"    \u003cdiv class\u003d\"networks\"\u003e\u003c/div\u003e"},{"line_number":33,"context_line":"    \u003cdiv class\u003d\"nodata\"\u003e{% blocktrans %}There are no networks, routers and servers to draw topology. {% endblocktrans %}\u003c/div\u003e"},{"line_number":34,"context_line":"\u003c/div\u003e"},{"line_number":35,"context_line":"\u003cspan data-networktopology\u003d\"{% url horizon:project:network_topology:json %}\" id\u003d\"networktopology\"\u003e\u003c/span\u003e"},{"line_number":36,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":2,"id":"AAAAM3%2F%2BlT4%3D","line":33,"in_reply_to":"AAAAM3%2F%2Bsw0%3D","updated":"2013-02-26 19:26:15.000000000","message":"I would suggest: \"There are no networks, routers, or connected instances to display.\"\n\n\"Instances\" is used instead of \"servers\" throughout Horizon, and it could be incorrect to say that there are no instances (at all) when really they\u0027re simply not connected in such a way that they\u0027d be displayed.","commit_id":"498d24020bb838038fdaeca59198fde6c7065b75"}],"openstack_dashboard/dashboards/project/network_topology/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"57e881be0725fa80b3a2456175e1db1569edfc3a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        tenant_id \u003d self.request.user.tenant_id"},{"line_number":37,"context_line":"        for resource in resources:"},{"line_number":38,"context_line":"            if not (resource.get(\u0027tenant_id\u0027)"},{"line_number":39,"context_line":"                    and tenant_id !\u003d resource.get(\u0027tenant_id\u0027)):"},{"line_number":40,"context_line":"                resource[\u0027url\u0027] \u003d reverse(view, None,"},{"line_number":41,"context_line":"                                         [str(resource[\u0027id\u0027])])"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2Bsx4%3D","line":39,"updated":"2013-02-21 08:06:49.000000000","message":"This reverse logic is a little hard to read.\nPlease consider the following:\n\nfor resource in resources:\n     if resource.get(\u0027tenant_id\u0027) and tenant_id !\u003d resource.get(\u0027tenant_id\u0027)):\n        continue\n    resource[\u0027url\u0027] \u003d reverse(view, None, [str(resource[\u0027id\u0027])])","commit_id":"498d24020bb838038fdaeca59198fde6c7065b75"},{"author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"change_message_id":"e3b01b3cd3197bc47323d9c3b20a75a31cd089ef","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        tenant_id \u003d self.request.user.tenant_id"},{"line_number":37,"context_line":"        for resource in resources:"},{"line_number":38,"context_line":"            if not (resource.get(\u0027tenant_id\u0027)"},{"line_number":39,"context_line":"                    and tenant_id !\u003d resource.get(\u0027tenant_id\u0027)):"},{"line_number":40,"context_line":"                resource[\u0027url\u0027] \u003d reverse(view, None,"},{"line_number":41,"context_line":"                                         [str(resource[\u0027id\u0027])])"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BlTw%3D","line":39,"in_reply_to":"AAAAM3%2F%2Bsx4%3D","updated":"2013-02-26 19:26:15.000000000","message":"or:\n\n    for resource in resources:\n        owner \u003d resource.get(\u0027tenant_id\u0027, None)\n        if owner is not None and owner \u003d\u003d tenant_id:\n            resource[\u0027url\u0027] ...\n\nThat way it\u0027s simply a positive assertion.","commit_id":"498d24020bb838038fdaeca59198fde6c7065b75"}]}