)]}'
{"openstack_dashboard/dashboards/admin/routers/templates/routers/_detail_overview.html":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"f3c50896bcbaa200d34b0b288bfd4027f94f4928","unresolved":false,"context_lines":[{"line_number":5,"context_line":"\u003cdiv class\u003d\"info detail\"\u003e"},{"line_number":6,"context_line":"  \u003cdl\u003e"},{"line_number":7,"context_line":"    \u003cdt\u003e{% trans \"Name\" %}\u003c/dt\u003e"},{"line_number":8,"context_line":"    \u003cdd\u003e{{ router.name|default:\"None\" }}\u003c/dd\u003e"},{"line_number":9,"context_line":"    \u003cdt\u003e{% trans \"ID\" %}\u003c/dt\u003e"},{"line_number":10,"context_line":"    \u003cdd\u003e{{ router.id }}\u003c/dd\u003e"},{"line_number":11,"context_line":"    \u003cdt\u003e{% trans \"Status\" %}\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":5,"id":"AAAAM3%2F%2BkH4%3D","line":8,"updated":"2013-02-27 07:28:18.000000000","message":"Does \"None\" need to be translatable?\n\nShould probably look like:\n    router.name|default:_(\"None\")","commit_id":"0e542cb0e8574a2fa7ff7028e16c7a8259586739"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"eebe8c24fef2baea1ce65454308bf2480a9f7248","unresolved":false,"context_lines":[{"line_number":5,"context_line":"\u003cdiv class\u003d\"info detail\"\u003e"},{"line_number":6,"context_line":"  \u003cdl\u003e"},{"line_number":7,"context_line":"    \u003cdt\u003e{% trans \"Name\" %}\u003c/dt\u003e"},{"line_number":8,"context_line":"    \u003cdd\u003e{{ router.name|default:\"None\" }}\u003c/dd\u003e"},{"line_number":9,"context_line":"    \u003cdt\u003e{% trans \"ID\" %}\u003c/dt\u003e"},{"line_number":10,"context_line":"    \u003cdd\u003e{{ router.id }}\u003c/dd\u003e"},{"line_number":11,"context_line":"    \u003cdt\u003e{% trans \"Status\" %}\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":5,"id":"AAAANH%2F%2F%2BsQ%3D","line":8,"in_reply_to":"AAAAM3%2F%2BkH4%3D","updated":"2013-02-28 23:07:01.000000000","message":"I grepped *.html in the code base of Horizon by \"default:\" and I found all of default value are not translatable.\nThis should be fixed with other default value in a separate patch I think.","commit_id":"0e542cb0e8574a2fa7ff7028e16c7a8259586739"}],"openstack_dashboard/dashboards/admin/routers/templates/routers/ports/_create.html":[{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"6dd79b4c4dbdf0aa9220fdfcbbd673d539969afd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003c/div\u003e"},{"line_number":16,"context_line":"\u003cdiv class\u003d\"right\"\u003e"},{"line_number":17,"context_line":"    \u003ch3\u003e{% trans \"Description\" %}:\u003c/h3\u003e"},{"line_number":18,"context_line":"    \u003cp\u003e{% trans \"You can add interface to the network with subnet_id.\" %}\u003c/p\u003e"},{"line_number":19,"context_line":"\u003c/div\u003e"},{"line_number":20,"context_line":"{% endblock %}"},{"line_number":21,"context_line":""}],"source_content_type":"text/html","patch_set":3,"id":"AAAAM3%2F%2Bqq4%3D","line":18,"updated":"2013-02-22 07:23:16.000000000","message":"Users don\u0027t want to see subnet_id :) Maybe something like:\n\nYou can add an interface to a network subnet here.","commit_id":"b47c698b7515d4febce9481f2c6636b6213dd9b2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"99484b02b4b7fb01f54eae5cb966e6c2c7fe2f2e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003c/div\u003e"},{"line_number":16,"context_line":"\u003cdiv class\u003d\"right\"\u003e"},{"line_number":17,"context_line":"    \u003ch3\u003e{% trans \"Description\" %}:\u003c/h3\u003e"},{"line_number":18,"context_line":"    \u003cp\u003e{% trans \"You can add interface to the network with subnet_id.\" %}\u003c/p\u003e"},{"line_number":19,"context_line":"\u003c/div\u003e"},{"line_number":20,"context_line":"{% endblock %}"},{"line_number":21,"context_line":""}],"source_content_type":"text/html","patch_set":3,"id":"AAAAM3%2F%2BqOs%3D","line":18,"in_reply_to":"AAAAM3%2F%2Bqq4%3D","updated":"2013-02-22 15:25:37.000000000","message":"Agree with you. This file is based on project router template. I think it is a good change to improve it.\n\n\"You can add an interface connected to the specified subnet\"","commit_id":"b47c698b7515d4febce9481f2c6636b6213dd9b2"}],"openstack_dashboard/dashboards/admin/routers/templates/routers/ports/_setgateway.html":[{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"6dd79b4c4dbdf0aa9220fdfcbbd673d539969afd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% block form_action %}{% url horizon:admin:routers:setgateway router.id %}"},{"line_number":6,"context_line":"{% endblock %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block modal-header %}{% trans \"Add Gateway Interface\" %}{% endblock %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% block modal-body %}"},{"line_number":11,"context_line":"\u003cdiv class\u003d\"left\"\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"AAAAM3%2F%2Bqpw%3D","line":8,"updated":"2013-02-22 07:23:16.000000000","message":"Change to \"Set Gateway\" for consistency with the other template?","commit_id":"b47c698b7515d4febce9481f2c6636b6213dd9b2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"99484b02b4b7fb01f54eae5cb966e6c2c7fe2f2e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% block form_action %}{% url horizon:admin:routers:setgateway router.id %}"},{"line_number":6,"context_line":"{% endblock %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block modal-header %}{% trans \"Add Gateway Interface\" %}{% endblock %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"{% block modal-body %}"},{"line_number":11,"context_line":"\u003cdiv class\u003d\"left\"\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"AAAAM3%2F%2BqMQ%3D","line":8,"in_reply_to":"AAAAM3%2F%2Bqpw%3D","updated":"2013-02-22 15:25:37.000000000","message":"Will fix","commit_id":"b47c698b7515d4febce9481f2c6636b6213dd9b2"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"6dd79b4c4dbdf0aa9220fdfcbbd673d539969afd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003c/div\u003e"},{"line_number":16,"context_line":"\u003cdiv class\u003d\"right\"\u003e"},{"line_number":17,"context_line":"    \u003ch3\u003e{% trans \"Description\" %}:\u003c/h3\u003e"},{"line_number":18,"context_line":"    \u003cp\u003e{% trans \"You can add inteface for Gateway. In this interface, NAT rule of floating IP will be set.\" %}\u003c/p\u003e"},{"line_number":19,"context_line":"\u003c/div\u003e"},{"line_number":20,"context_line":"{% endblock %}"},{"line_number":21,"context_line":""}],"source_content_type":"text/html","patch_set":3,"id":"AAAAM3%2F%2BqqA%3D","line":18,"updated":"2013-02-22 07:23:16.000000000","message":"I\u0027m still learning how quantum works so I don\u0027t understand what the second sentence means exactly. Is this taking an IP from the floating range and using it to SNAT from the network? If so, maybe change this to something like:\n\nYou can set the gateway for the router here. This will allocate an IP from the external network subnet so connected networks can access the external network.","commit_id":"b47c698b7515d4febce9481f2c6636b6213dd9b2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"99484b02b4b7fb01f54eae5cb966e6c2c7fe2f2e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"\u003c/div\u003e"},{"line_number":16,"context_line":"\u003cdiv class\u003d\"right\"\u003e"},{"line_number":17,"context_line":"    \u003ch3\u003e{% trans \"Description\" %}:\u003c/h3\u003e"},{"line_number":18,"context_line":"    \u003cp\u003e{% trans \"You can add inteface for Gateway. In this interface, NAT rule of floating IP will be set.\" %}\u003c/p\u003e"},{"line_number":19,"context_line":"\u003c/div\u003e"},{"line_number":20,"context_line":"{% endblock %}"},{"line_number":21,"context_line":""}],"source_content_type":"text/html","patch_set":3,"id":"AAAAM3%2F%2BqJk%3D","line":18,"in_reply_to":"AAAAM3%2F%2BqqA%3D","updated":"2013-02-22 15:25:37.000000000","message":"Sorry for checking the sentence well. Hmm. The original description in project panel is not appropriate. It is just copied from project router panel.\n\nRegarding quantum behavior of L3 router, the answer is yes. Thanks for the suggestion.","commit_id":"b47c698b7515d4febce9481f2c6636b6213dd9b2"}],"openstack_dashboard/dashboards/project/routers/ports/forms.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"f3c50896bcbaa200d34b0b288bfd4027f94f4928","unresolved":false,"context_lines":[{"line_number":30,"context_line":"class AddInterface(forms.SelfHandlingForm):"},{"line_number":31,"context_line":"    subnet_id \u003d forms.ChoiceField(label\u003d_(\"Subnet\"), required\u003dFalse)"},{"line_number":32,"context_line":"    router_name \u003d forms.CharField(label\u003d_(\"Router Name\"),"},{"line_number":33,"context_line":"                                  widget\u003dforms.TextInput("},{"line_number":34,"context_line":"                                      attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027}))"},{"line_number":35,"context_line":"    router_id \u003d forms.CharField(label\u003d_(\"Router ID\"),"},{"line_number":36,"context_line":"                                widget\u003dforms.TextInput("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2BkJE%3D","line":33,"updated":"2013-02-27 07:28:18.000000000","message":"indentation is not correct (does not match pep8 style)","commit_id":"0e542cb0e8574a2fa7ff7028e16c7a8259586739"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"eebe8c24fef2baea1ce65454308bf2480a9f7248","unresolved":false,"context_lines":[{"line_number":30,"context_line":"class AddInterface(forms.SelfHandlingForm):"},{"line_number":31,"context_line":"    subnet_id \u003d forms.ChoiceField(label\u003d_(\"Subnet\"), required\u003dFalse)"},{"line_number":32,"context_line":"    router_name \u003d forms.CharField(label\u003d_(\"Router Name\"),"},{"line_number":33,"context_line":"                                  widget\u003dforms.TextInput("},{"line_number":34,"context_line":"                                      attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027}))"},{"line_number":35,"context_line":"    router_id \u003d forms.CharField(label\u003d_(\"Router ID\"),"},{"line_number":36,"context_line":"                                widget\u003dforms.TextInput("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAANH%2F%2F%2BtU%3D","line":33,"in_reply_to":"AAAAM3%2F%2BkJE%3D","updated":"2013-02-28 23:07:01.000000000","message":"indentation of \u0027widget\u003dforms...\u0027 is aligned to \u0027label\u0027 in the previous line. gerrit does not display indentation properly. I believe you can confirm the correct indentation If you download the file. PEP8 test is passed.","commit_id":"0e542cb0e8574a2fa7ff7028e16c7a8259586739"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"f3c50896bcbaa200d34b0b288bfd4027f94f4928","unresolved":false,"context_lines":[{"line_number":89,"context_line":"class SetGatewayForm(forms.SelfHandlingForm):"},{"line_number":90,"context_line":"    network_id \u003d forms.ChoiceField(label\u003d_(\"External Network\"), required\u003dFalse)"},{"line_number":91,"context_line":"    router_name \u003d forms.CharField(label\u003d_(\"Router Name\"),"},{"line_number":92,"context_line":"                                  widget\u003dforms.TextInput("},{"line_number":93,"context_line":"                                      attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027}))"},{"line_number":94,"context_line":"    router_id \u003d forms.CharField(label\u003d_(\"Router ID\"),"},{"line_number":95,"context_line":"                                widget\u003dforms.TextInput("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAM3%2F%2BkJA%3D","line":92,"updated":"2013-02-27 07:28:18.000000000","message":"indentation is not correct (does not match pep8 style)","commit_id":"0e542cb0e8574a2fa7ff7028e16c7a8259586739"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"eebe8c24fef2baea1ce65454308bf2480a9f7248","unresolved":false,"context_lines":[{"line_number":89,"context_line":"class SetGatewayForm(forms.SelfHandlingForm):"},{"line_number":90,"context_line":"    network_id \u003d forms.ChoiceField(label\u003d_(\"External Network\"), required\u003dFalse)"},{"line_number":91,"context_line":"    router_name \u003d forms.CharField(label\u003d_(\"Router Name\"),"},{"line_number":92,"context_line":"                                  widget\u003dforms.TextInput("},{"line_number":93,"context_line":"                                      attrs\u003d{\u0027readonly\u0027: \u0027readonly\u0027}))"},{"line_number":94,"context_line":"    router_id \u003d forms.CharField(label\u003d_(\"Router ID\"),"},{"line_number":95,"context_line":"                                widget\u003dforms.TextInput("}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAANH%2F%2F%2BtE%3D","line":92,"in_reply_to":"AAAAM3%2F%2BkJA%3D","updated":"2013-02-28 23:07:01.000000000","message":"Ditto","commit_id":"0e542cb0e8574a2fa7ff7028e16c7a8259586739"}]}