)]}'
{"openstack_dashboard/dashboards/admin/volumes/templates/volumes/volume_types/_update_volume_type.html":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"0f8817116033d7c52d7cf68321f9ea7213a720bb","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  \u003c/div\u003e"},{"line_number":16,"context_line":"  \u003cdiv class\u003d\"right\"\u003e"},{"line_number":17,"context_line":"    \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":18,"context_line":"    \u003cp\u003e{% trans \"Modify volume type name, description and public status.\" %}\u003c/p\u003e"},{"line_number":19,"context_line":"  \u003c/div\u003e"},{"line_number":20,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":5,"id":"7a5de9d1_89754b99","line":18,"updated":"2016-01-29 05:21:10.000000000","message":"Tiny nitpick. There should be a comma after description.","commit_id":"bdc8be8d6c1f01773c7d757ce0618083a6c40465"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"38349aeece8bbc01f46433d43fe3176dcfb39603","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  \u003c/div\u003e"},{"line_number":16,"context_line":"  \u003cdiv class\u003d\"right\"\u003e"},{"line_number":17,"context_line":"    \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":18,"context_line":"    \u003cp\u003e{% trans \"Modify volume type name, description and public status.\" %}\u003c/p\u003e"},{"line_number":19,"context_line":"  \u003c/div\u003e"},{"line_number":20,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":5,"id":"7a5de9d1_349a6e64","line":18,"in_reply_to":"7a5de9d1_89754b99","updated":"2016-01-29 06:24:59.000000000","message":"Done","commit_id":"bdc8be8d6c1f01773c7d757ce0618083a6c40465"}],"openstack_dashboard/dashboards/admin/volumes/volume_types/forms.py":[{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"5e75d38b997b7b1e8aa600bb4e424420ab56d5cb","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        widget\u003dforms.Textarea(attrs\u003d{\u0027rows\u0027: 4}),"},{"line_number":29,"context_line":"        label\u003d_(\"Description\"),"},{"line_number":30,"context_line":"        required\u003dFalse)"},{"line_number":31,"context_line":"    is_public \u003d forms.BooleanField(label\u003d_(\"Public\"), required\u003dFalse)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def clean_name(self):"},{"line_number":34,"context_line":"        cleaned_name \u003d self.cleaned_data[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_26a26baf","line":31,"updated":"2015-11-25 13:25:03.000000000","message":"Shouldn\u0027t we default to setting the is_public flag to True? \n\nThat is the default on cinder if nothing is set, so it makes sense to set it to True by default.","commit_id":"86c21ef73fce7f641fcad1ad8f20ee6639d9ab78"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"8bf2c3a85578284bb4059a188baa8e8be7806708","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        widget\u003dforms.Textarea(attrs\u003d{\u0027rows\u0027: 4}),"},{"line_number":29,"context_line":"        label\u003d_(\"Description\"),"},{"line_number":30,"context_line":"        required\u003dFalse)"},{"line_number":31,"context_line":"    is_public \u003d forms.BooleanField(label\u003d_(\"Public\"), required\u003dFalse)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def clean_name(self):"},{"line_number":34,"context_line":"        cleaned_name \u003d self.cleaned_data[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_91a24bad","line":31,"in_reply_to":"9a8ffd7b_26a26baf","updated":"2015-11-26 01:43:52.000000000","message":"Done","commit_id":"86c21ef73fce7f641fcad1ad8f20ee6639d9ab78"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"5e75d38b997b7b1e8aa600bb4e424420ab56d5cb","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                                      volume_type_id,"},{"line_number":258,"context_line":"                                      data[\u0027name\u0027],"},{"line_number":259,"context_line":"                                      data[\u0027description\u0027],"},{"line_number":260,"context_line":"                                      data[\u0027is_public\u0027])"},{"line_number":261,"context_line":"            message \u003d _(\u0027Successfully updated volume type.\u0027)"},{"line_number":262,"context_line":"            messages.success(request, message)"},{"line_number":263,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_e6dd4343","line":260,"updated":"2015-11-25 13:25:03.000000000","message":"Updating a volume type does not admit the is_public flag on the cinder api:\nhttp://developer.openstack.org/api-ref-blockstorage-v2.html#updateVolumeType","commit_id":"86c21ef73fce7f641fcad1ad8f20ee6639d9ab78"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"8bf2c3a85578284bb4059a188baa8e8be7806708","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                                      volume_type_id,"},{"line_number":258,"context_line":"                                      data[\u0027name\u0027],"},{"line_number":259,"context_line":"                                      data[\u0027description\u0027],"},{"line_number":260,"context_line":"                                      data[\u0027is_public\u0027])"},{"line_number":261,"context_line":"            message \u003d _(\u0027Successfully updated volume type.\u0027)"},{"line_number":262,"context_line":"            messages.success(request, message)"},{"line_number":263,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_117e5b19","line":260,"in_reply_to":"9a8ffd7b_e6dd4343","updated":"2015-11-26 01:43:52.000000000","message":"the doc is not up to date, https://github.com/openstack/cinder/blob/master/cinder/api/contrib/types_manage.py#L115, https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v2/volume_types.py#L131","commit_id":"86c21ef73fce7f641fcad1ad8f20ee6639d9ab78"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1da5ff9422f19f15b6ec377b91820e92ba77301a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        widget\u003dforms.Textarea(attrs\u003d{\u0027rows\u0027: 4}),"},{"line_number":29,"context_line":"        label\u003d_(\"Description\"),"},{"line_number":30,"context_line":"        required\u003dFalse)"},{"line_number":31,"context_line":"    is_public \u003d forms.BooleanField(label\u003d_(\"Public\"),"},{"line_number":32,"context_line":"                                   initial\u003dTrue,"},{"line_number":33,"context_line":"                                   required\u003dFalse,"},{"line_number":34,"context_line":"                                   help_text\u003d_("}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_9e0a9324","line":31,"updated":"2016-05-23 07:01:02.000000000","message":"Could you consider wrapping lines just after the opening parenthesis?\nYou can have more characters per line and it improves the readability.\n\n  is_public \u003d forms.BooleanField(\n      label\u003d_(\"Public\"),\n      ....","commit_id":"16b17f30e9d4e8970f574c05b92edbb6c19a74d2"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"2c6e141d881ec44655a42821f40082adfb6e353b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        widget\u003dforms.Textarea(attrs\u003d{\u0027rows\u0027: 4}),"},{"line_number":29,"context_line":"        label\u003d_(\"Description\"),"},{"line_number":30,"context_line":"        required\u003dFalse)"},{"line_number":31,"context_line":"    is_public \u003d forms.BooleanField(label\u003d_(\"Public\"),"},{"line_number":32,"context_line":"                                   initial\u003dTrue,"},{"line_number":33,"context_line":"                                   required\u003dFalse,"},{"line_number":34,"context_line":"                                   help_text\u003d_("}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_ea8dc431","line":31,"in_reply_to":"bab6814e_9e0a9324","updated":"2016-05-23 14:31:24.000000000","message":"Done","commit_id":"16b17f30e9d4e8970f574c05b92edbb6c19a74d2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1da5ff9422f19f15b6ec377b91820e92ba77301a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                                   required\u003dFalse,"},{"line_number":34,"context_line":"                                   help_text\u003d_("},{"line_number":35,"context_line":"                                       \"By default, volume type is created \""},{"line_number":36,"context_line":"                                       \"public. To create a private volume \""},{"line_number":37,"context_line":"                                       \"type, uncheck this field.\"))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def clean_name(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_590b2524","line":36,"range":{"start_line":36,"start_character":40,"end_line":36,"end_character":46},"updated":"2016-05-23 07:01:02.000000000","message":"-\u003e created as public?","commit_id":"16b17f30e9d4e8970f574c05b92edbb6c19a74d2"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"2c6e141d881ec44655a42821f40082adfb6e353b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                                   required\u003dFalse,"},{"line_number":34,"context_line":"                                   help_text\u003d_("},{"line_number":35,"context_line":"                                       \"By default, volume type is created \""},{"line_number":36,"context_line":"                                       \"public. To create a private volume \""},{"line_number":37,"context_line":"                                       \"type, uncheck this field.\"))"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def clean_name(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_ea2b0480","line":36,"range":{"start_line":36,"start_character":40,"end_line":36,"end_character":46},"in_reply_to":"bab6814e_590b2524","updated":"2016-05-23 14:31:24.000000000","message":"Done","commit_id":"16b17f30e9d4e8970f574c05b92edbb6c19a74d2"}],"openstack_dashboard/dashboards/admin/volumes/volume_types/tables.py":[{"author":{"_account_id":13325,"name":"Paul Karikh","email":"pkarikh@gmail.com","username":"paul.karikh"},"change_message_id":"5d45d66f8905bc746fafeeb15e9c2b3e82751639","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                                    \"type_encryption_detail\")"},{"line_number":221,"context_line":"    public \u003d tables.Column(\"is_public\","},{"line_number":222,"context_line":"                           verbose_name\u003d_(\"Public\"),"},{"line_number":223,"context_line":"                           empty_value\u003dFalse,"},{"line_number":224,"context_line":"                           filters\u003d(filters.yesno, filters.capfirst))"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    def get_object_display(self, vol_type):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_25c7fa13","line":223,"updated":"2015-11-16 14:46:41.000000000","message":"Correct me if I\u0027m wrong, but empty_value should be function or string, isn\u0027t it? https://github.com/openstack/horizon/blob/master/horizon/tables/base.py#L133","commit_id":"76850dea1fdd7b29a1e9f2d07b32782e1221a73f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1da5ff9422f19f15b6ec377b91820e92ba77301a","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            setattr(vol_type_obj, cell_name, new_cell_value)"},{"line_number":204,"context_line":"            name_value \u003d getattr(vol_type_obj, \u0027name\u0027, None)"},{"line_number":205,"context_line":"            desc_value \u003d getattr(vol_type_obj, \u0027description\u0027, None)"},{"line_number":206,"context_line":"            public_value \u003d getattr(vol_type_obj, \u0027public\u0027, None)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"            cinder.volume_type_update("},{"line_number":209,"context_line":"                request,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_592205a4","line":206,"range":{"start_line":206,"start_character":59,"end_line":206,"end_character":64},"updated":"2016-05-23 07:01:02.000000000","message":"public is a boolean value.\nWhat does \u0027None\u0027 mean?","commit_id":"16b17f30e9d4e8970f574c05b92edbb6c19a74d2"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"2c6e141d881ec44655a42821f40082adfb6e353b","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            setattr(vol_type_obj, cell_name, new_cell_value)"},{"line_number":204,"context_line":"            name_value \u003d getattr(vol_type_obj, \u0027name\u0027, None)"},{"line_number":205,"context_line":"            desc_value \u003d getattr(vol_type_obj, \u0027description\u0027, None)"},{"line_number":206,"context_line":"            public_value \u003d getattr(vol_type_obj, \u0027public\u0027, None)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"            cinder.volume_type_update("},{"line_number":209,"context_line":"                request,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_cfa9f225","line":206,"range":{"start_line":206,"start_character":59,"end_line":206,"end_character":64},"in_reply_to":"bab6814e_592205a4","updated":"2016-05-23 14:31:24.000000000","message":"The default from cinderclient is None","commit_id":"16b17f30e9d4e8970f574c05b92edbb6c19a74d2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1da5ff9422f19f15b6ec377b91820e92ba77301a","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                volume_type_id,"},{"line_number":211,"context_line":"                name\u003dname_value,"},{"line_number":212,"context_line":"                description\u003ddesc_value,"},{"line_number":213,"context_line":"                is_public\u003dpublic_value)"},{"line_number":214,"context_line":"        except Exception as ex:"},{"line_number":215,"context_line":"            if ex.code and ex.code \u003d\u003d 409:"},{"line_number":216,"context_line":"                error_message \u003d _(\u0027New name conflicts with another \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_9938edd4","line":213,"updated":"2016-05-23 07:01:02.000000000","message":"If None is passed, what does happen?\nWhat will be the updated value?\nIs the original value kept?","commit_id":"16b17f30e9d4e8970f574c05b92edbb6c19a74d2"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"2c6e141d881ec44655a42821f40082adfb6e353b","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                volume_type_id,"},{"line_number":211,"context_line":"                name\u003dname_value,"},{"line_number":212,"context_line":"                description\u003ddesc_value,"},{"line_number":213,"context_line":"                is_public\u003dpublic_value)"},{"line_number":214,"context_line":"        except Exception as ex:"},{"line_number":215,"context_line":"            if ex.code and ex.code \u003d\u003d 409:"},{"line_number":216,"context_line":"                error_message \u003d _(\u0027New name conflicts with another \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_beaca28c","line":213,"in_reply_to":"bab6814e_9938edd4","updated":"2016-05-23 14:31:24.000000000","message":"Yes, None means no value will be passed to the update API: https://github.com/openstack/python-cinderclient/blob/master/cinderclient/v3/volume_types.py#L132","commit_id":"16b17f30e9d4e8970f574c05b92edbb6c19a74d2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e907aa000cbfbccf980aae83655e1074c3926c84","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                volume_type_id,"},{"line_number":211,"context_line":"                name\u003dname_value,"},{"line_number":212,"context_line":"                description\u003ddesc_value,"},{"line_number":213,"context_line":"                is_public\u003dpublic_value)"},{"line_number":214,"context_line":"        except Exception as ex:"},{"line_number":215,"context_line":"            if ex.code and ex.code \u003d\u003d 409:"},{"line_number":216,"context_line":"                error_message \u003d _(\u0027New name conflicts with another \u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_056d4f32","line":213,"in_reply_to":"bab6814e_beaca28c","updated":"2016-05-24 16:40:36.000000000","message":"Thanks. Looks good.","commit_id":"16b17f30e9d4e8970f574c05b92edbb6c19a74d2"}],"openstack_dashboard/dashboards/admin/volumes/volume_types/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1da5ff9422f19f15b6ec377b91820e92ba77301a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.assertNoFormErrors(res)"},{"line_number":43,"context_line":"        redirect \u003d reverse(\u0027horizon:admin:volumes:volume_types_tab\u0027)"},{"line_number":44,"context_line":"        self.assertRedirectsNoFollow(res, redirect)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @test.create_stubs({cinder: (\u0027volume_type_get\u0027,"},{"line_number":47,"context_line":"                                 \u0027volume_type_update\u0027)})"},{"line_number":48,"context_line":"    def test_update_volume_type(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_397741a1","line":45,"updated":"2016-05-23 07:01:02.000000000","message":"I would like to see a test with is_public\u003dFalse.","commit_id":"16b17f30e9d4e8970f574c05b92edbb6c19a74d2"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"2c6e141d881ec44655a42821f40082adfb6e353b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        self.assertNoFormErrors(res)"},{"line_number":43,"context_line":"        redirect \u003d reverse(\u0027horizon:admin:volumes:volume_types_tab\u0027)"},{"line_number":44,"context_line":"        self.assertRedirectsNoFollow(res, redirect)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @test.create_stubs({cinder: (\u0027volume_type_get\u0027,"},{"line_number":47,"context_line":"                                 \u0027volume_type_update\u0027)})"},{"line_number":48,"context_line":"    def test_update_volume_type(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_2a006c65","line":45,"in_reply_to":"bab6814e_397741a1","updated":"2016-05-23 14:31:24.000000000","message":"Done","commit_id":"16b17f30e9d4e8970f574c05b92edbb6c19a74d2"}]}
