)]}'
{"openstack_dashboard/dashboards/project/instances/workflows/resize_instance.py":[{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"adfb7dd45da697cb86832f79dbe999d23246fc7a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            flavors \u003d instance_utils.sort_flavor_list(request, flavors)"},{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            flavor \u003d flavors[0]"},{"line_number":57,"context_line":"            flavors \u003d [(flavor.id, flavor.name)]"},{"line_number":58,"context_line":"        if flavors:"},{"line_number":59,"context_line":"            flavors.insert(0, (\"\", _(\"Select a New Flavor\")))"},{"line_number":60,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_59a383b2","line":57,"updated":"2015-10-15 16:11:42.000000000","message":"This code will error if len(flavors) \u003d\u003d 0.  This \"else\" should be an \"elif len(flavors) \u003d\u003d 1\".","commit_id":"11d77c6a0a3f74ba345c9c9b667c6d40eb1d900b"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"adfb7dd45da697cb86832f79dbe999d23246fc7a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        if flavors:"},{"line_number":59,"context_line":"            flavors.insert(0, (\"\", _(\"Select a New Flavor\")))"},{"line_number":60,"context_line":"        else:"},{"line_number":61,"context_line":"            flavors.insert(0, (\"\", _(\"No flavors available\")))"},{"line_number":62,"context_line":"        return flavors"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def get_help_text(self, extra_context\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_599dc3ba","line":61,"updated":"2015-10-15 16:11:42.000000000","message":"With the way the code is currently written, this else should never be hit.  It can be removed.\n\nIf however, my suggestion above is used, this else will need to stay.","commit_id":"11d77c6a0a3f74ba345c9c9b667c6d40eb1d900b"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"efe5fb7323f9c1e7685a22cf39484ea62f1399f9","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        if flavors:"},{"line_number":59,"context_line":"            flavors.insert(0, (\"\", _(\"Select a New Flavor\")))"},{"line_number":60,"context_line":"        else:"},{"line_number":61,"context_line":"            flavors.insert(0, (\"\", _(\"No flavors available\")))"},{"line_number":62,"context_line":"        return flavors"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def get_help_text(self, extra_context\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_767c17b5","line":61,"updated":"2015-10-16 16:14:19.000000000","message":"Looking at this code more, I feel that it can be simplified further.  Here is my suggestion:\n\n# Remove current flavor from the list of flavor choices\nif flavors:\n    if len(flavors) \u003e 1:\n        flavors \u003d instance_utils.sort_flavor_list(request, flavors)\n    else:\n        flavor \u003d flavors[0]\n        flavors \u003d [(flavor.id, flavor.name)]\n    flavors.insert(0, (\"\", _(\"Select a New Flavor\")))\nelse:\n    flavors.insert(0, (\"\", _(\"No flavors available\")))","commit_id":"b02ba9c54e13e6872854a43aaab40f027611d550"},{"author":{"_account_id":14151,"name":"ziyu032","email":"chen.qiaomin@99cloud.net","username":"ziyu032"},"change_message_id":"9c0baf9689501380cd3817499f57e8689c75d448","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        if flavors:"},{"line_number":59,"context_line":"            flavors.insert(0, (\"\", _(\"Select a New Flavor\")))"},{"line_number":60,"context_line":"        else:"},{"line_number":61,"context_line":"            flavors.insert(0, (\"\", _(\"No flavors available\")))"},{"line_number":62,"context_line":"        return flavors"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def get_help_text(self, extra_context\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_4425cec0","line":61,"in_reply_to":"5a2ca52d_767c17b5","updated":"2016-05-18 05:02:48.000000000","message":"+1","commit_id":"b02ba9c54e13e6872854a43aaab40f027611d550"}]}