)]}'
{"openstack_dashboard/test/integration_tests/basewebobject.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2bfb15f671b730e5366dbb2a201975768ee0228e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        appear in place of an old element. So a way to avoid capturing stale"},{"line_number":93,"context_line":"        element reference should be provided for this use case."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        (tsufiev): better to wrap getting image status cell in a lambda"},{"line_number":96,"context_line":"        to avoid problems with cell being replaced with totally different"},{"line_number":97,"context_line":"        element by Javascript"},{"line_number":98,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_fedba319","line":95,"updated":"2015-10-19 15:42:48.000000000","message":"You could remove my initials from docstring, I do not care about comments copyright :).","commit_id":"0603e72fcf59239f24721c7e29dbac14491dfc3e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"fb7590530990160729496053ab379db25420a361","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        appear in place of an old element. So a way to avoid capturing stale"},{"line_number":97,"context_line":"        element reference should be provided for this use case."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        Better to wrap getting image status cell in a lambda"},{"line_number":100,"context_line":"        to avoid problems with cell being replaced with totally different"},{"line_number":101,"context_line":"        element by Javascript"},{"line_number":102,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":30,"id":"9a68dd71_9c12c757","line":99,"updated":"2016-01-26 12:47:36.000000000","message":"image -\u003e entity (the comment is now not just about images, it\u0027s about any kind of entities in tables)","commit_id":"f406e346475260c4ff8477ea940dbd2820d202f6"}],"openstack_dashboard/test/integration_tests/pages/admin/system/volumes/__init__.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"7257d3255054248fc2507ed0b238ab9fe49d3919","unresolved":false,"context_lines":[{"line_number":1,"context_line":"__author__ \u003d \u0027super\u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"da6ed579_9af39573","line":1,"updated":"2016-01-12 14:27:47.000000000","message":"What is it?","commit_id":"a939e81ddf609db387deeb9c5429760a1da6d5ce"}],"openstack_dashboard/test/integration_tests/pages/admin/system/volumes/volumespage.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"7257d3255054248fc2507ed0b238ab9fe49d3919","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class VolumesTable(volumespage.VolumesTable):"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    def __init__(self, driver, conf):"},{"line_number":20,"context_line":"        super(VolumesTable, self).__init__(driver, conf)"},{"line_number":21,"context_line":"        self._page_title \u003d \"Volumes\""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"da6ed579_ba81b991","line":19,"updated":"2016-01-12 14:27:47.000000000","message":"I doubt that\u0027s necessary.","commit_id":"a939e81ddf609db387deeb9c5429760a1da6d5ce"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"7257d3255054248fc2507ed0b238ab9fe49d3919","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        self._page_title \u003d \"Volumes\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class VolumesPage(volumespage.VolumesPage):"},{"line_number":25,"context_line":"    def __init__(self, driver, conf):"},{"line_number":26,"context_line":"        super(VolumesPage, self).__init__(driver, conf)"},{"line_number":27,"context_line":"        self._page_title \u003d \"Volumes\""}],"source_content_type":"text/x-python","patch_set":17,"id":"da6ed579_9a1dd575","line":24,"updated":"2016-01-12 14:27:47.000000000","message":"Since it is the same as vanilla VolumesPage, could we start with\n\n  class VolumesPage(volumespage.VolumesPage):\n    pass\n\nand change it when it\u0027s necessary?","commit_id":"a939e81ddf609db387deeb9c5429760a1da6d5ce"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"c0e3634d42749eaa663eb4a06591801c9b9be500","unresolved":false,"context_lines":[{"line_number":21,"context_line":"        self._page_title \u003d \"Volumes\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class VolumesPage(volumespage.VolumesPage):"},{"line_number":25,"context_line":"    def __init__(self, driver, conf):"},{"line_number":26,"context_line":"        super(VolumesPage, self).__init__(driver, conf)"},{"line_number":27,"context_line":"        self._page_title \u003d \"Volumes\""}],"source_content_type":"text/x-python","patch_set":17,"id":"da6ed579_8eb91631","line":24,"in_reply_to":"da6ed579_9a1dd575","updated":"2016-01-12 14:29:34.000000000","message":"Please look at https://review.openstack.org/#/c/265955/5/openstack_dashboard/test/integration_tests/tests/test_image_create_delete.py for example","commit_id":"a939e81ddf609db387deeb9c5429760a1da6d5ce"}],"openstack_dashboard/test/integration_tests/pages/admin/system/volumespage.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"37c35aca098d3dbadc056332851023e3c109e184","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from openstack_dashboard.test.integration_tests.pages.project.compute.volumes\\"},{"line_number":14,"context_line":"    import \\"},{"line_number":15,"context_line":"    volumespage"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_2c991b6f","line":14,"updated":"2015-12-30 15:56:27.000000000","message":"indentation here seems weird to me.","commit_id":"4bfba4ca2e1fb4e16eb1407a624c2c9f5fd5844b"}],"openstack_dashboard/test/integration_tests/pages/navigation.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2bfb15f671b730e5366dbb2a201975768ee0228e","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                ("},{"line_number":77,"context_line":"                                    \"Overview\","},{"line_number":78,"context_line":"                                    \"Instances\","},{"line_number":79,"context_line":"                                    \"Volumes\","},{"line_number":80,"context_line":"                                    \"Images\","},{"line_number":81,"context_line":"                                )"},{"line_number":82,"context_line":"                        },"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_f31d1c74","line":79,"updated":"2015-10-19 15:42:48.000000000","message":"It\u0027s already here, on line 71.","commit_id":"0603e72fcf59239f24721c7e29dbac14491dfc3e"},{"author":{"_account_id":13420,"name":"Serhii Vasheka","email":"svasheka@mirantis.com","username":"svasheka"},"change_message_id":"e41f688e7adeb28fc384364481eac42b4d74c200","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                                ("},{"line_number":77,"context_line":"                                    \"Overview\","},{"line_number":78,"context_line":"                                    \"Instances\","},{"line_number":79,"context_line":"                                    \"Volumes\","},{"line_number":80,"context_line":"                                    \"Images\","},{"line_number":81,"context_line":"                                )"},{"line_number":82,"context_line":"                        },"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_314ce941","line":79,"in_reply_to":"3a29b11f_f31d1c74","updated":"2015-10-19 16:36:38.000000000","message":"Then it should\u0027ve been worked without this change.\nIt didn\u0027t though )","commit_id":"0603e72fcf59239f24721c7e29dbac14491dfc3e"}],"openstack_dashboard/test/integration_tests/pages/project/compute/volumes/volumespage.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"37c35aca098d3dbadc056332851023e3c109e184","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        confirm_delete_volumes_form \u003d self.volumes_table.delete_volume()"},{"line_number":99,"context_line":"        confirm_delete_volumes_form.submit()"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def edit_volume(self, name):"},{"line_number":102,"context_line":"        row \u003d self._get_row_with_volume_name(name)"},{"line_number":103,"context_line":"        volume_edit_form \u003d self.volumes_table.edit_volume(row)"},{"line_number":104,"context_line":"        volume_edit_form.name.text \u003d \"edited_\" + name"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_6c12b3b6","line":101,"updated":"2015-12-30 15:56:27.000000000","message":"It\u0027s better to provide every attribute being edited for a volume as a separate argument of the function.","commit_id":"4bfba4ca2e1fb4e16eb1407a624c2c9f5fd5844b"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"bc671c3bb6412e67c668dbba4e7c2cab860e002f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"class VolumesPage(basepage.BaseNavigationPage):"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    DEFAULT_VOLUME_SOURCE \u003d \"Image\""},{"line_number":52,"context_line":"    DEFAULT_SOURCE_IMAGE \u003d \"cirros-0.3.4-x86_64-uec (24.0 MB)\""},{"line_number":53,"context_line":"    DEFAULT_VOLUME_NAME \u003d None"},{"line_number":54,"context_line":"    DEFAULT_VOLUME_TYPE \u003d \"lvmdriver-1\""},{"line_number":55,"context_line":"    DEFAULT_VOLUME_SIZE \u003d \"1\""}],"source_content_type":"text/x-python","patch_set":19,"id":"da6ed579_596b14b7","line":52,"updated":"2016-01-15 19:08:53.000000000","message":"This value is very specific to underlying devstack and should be moved to horizon.conf (if it\u0027s not there yet in [image] section).","commit_id":"f28bd989f608329f8267529984b46f8f5d14942c"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"fb7590530990160729496053ab379db25420a361","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class VolumesTable(tables.TableRegion):"},{"line_number":21,"context_line":"    name \u003d \u0027volumes\u0027"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    CREATE_VOLUME_FROM_IMAGE_FORM_FIELDS \u003d ("},{"line_number":24,"context_line":"        \"name\", \"description\", \"volume_source_type\", \"image_source\","},{"line_number":25,"context_line":"        \"type\", \"size\", \"availability_zone\")"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"9a68dd71_bc3d4bbd","line":23,"updated":"2016-01-26 12:47:36.000000000","message":"Does this form allows to create volume _only_ from image? If no, the name is a bit misleading.","commit_id":"f406e346475260c4ff8477ea940dbd2820d202f6"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"fb7590530990160729496053ab379db25420a361","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        \"type\", \"size\", \"availability_zone\")"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    EDIT_VOLUME_FORM_FIELDS \u003d ("},{"line_number":28,"context_line":"        \"name\", \"description\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @tables.bind_table_action(\u0027create\u0027)"},{"line_number":31,"context_line":"    def create_volume(self, create_button):"}],"source_content_type":"text/x-python","patch_set":30,"id":"9a68dd71_fc7183a9","line":28,"updated":"2016-01-26 12:47:36.000000000","message":"Actually, no need to move it over second line.","commit_id":"f406e346475260c4ff8477ea940dbd2820d202f6"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"fb7590530990160729496053ab379db25420a361","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class VolumesPage(basepage.BaseNavigationPage):"},{"line_number":50,"context_line":"    DEFAULT_VOLUME_SOURCE \u003d \"Image\""},{"line_number":51,"context_line":"    DEFAULT_VOLUME_NAME \u003d None"},{"line_number":52,"context_line":"    DEFAULT_VOLUME_SIZE \u003d \"1\""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"9a68dd71_9c3e4728","line":50,"updated":"2016-01-26 12:47:36.000000000","message":"I think it\u0027s better to name both \u0027Image\u0027 and \u0027Volume\u0027 as VOLUME_SOURCE_TYPE and IMAGE_SOURCE_TYPE (well, you might find slightly better names) and define them at module-level, so we could reuse these constants in other tests. Then we won\u0027t need DEFAULT_VOLUME_SOURCE variable.\n\nAlso I suggest to store DEFAULT_VOLUME_SIZE at horizon.conf, because some downstream CIs may want to create volumes of bigger sized by default.","commit_id":"f406e346475260c4ff8477ea940dbd2820d202f6"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"fb7590530990160729496053ab379db25420a361","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class VolumesPage(basepage.BaseNavigationPage):"},{"line_number":50,"context_line":"    DEFAULT_VOLUME_SOURCE \u003d \"Image\""},{"line_number":51,"context_line":"    DEFAULT_VOLUME_NAME \u003d None"},{"line_number":52,"context_line":"    DEFAULT_VOLUME_SIZE \u003d \"1\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    VOLUMES_TABLE_NAME_COLUMN \u003d \u0027name\u0027"}],"source_content_type":"text/x-python","patch_set":30,"id":"9a68dd71_1ced778e","line":51,"updated":"2016-01-26 12:47:36.000000000","message":"Hmm, do we really need to give a name to None value :)?","commit_id":"f406e346475260c4ff8477ea940dbd2820d202f6"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"fb7590530990160729496053ab379db25420a361","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                                   volume_source)"},{"line_number":82,"context_line":"        volume_source_type[0].text \u003d volume_source_type[1]"},{"line_number":83,"context_line":"        volume_form.size.text \u003d volume_size"},{"line_number":84,"context_line":"        if volume_source_type !\u003d \"Volume\":"},{"line_number":85,"context_line":"            volume_form.type.value \u003d self.conf.volume.volume_type"},{"line_number":86,"context_line":"            volume_form.availability_zone.value \u003d \\"},{"line_number":87,"context_line":"                self.conf.launch_instances.available_zone"}],"source_content_type":"text/x-python","patch_set":30,"id":"9a68dd71_1c11f7af","line":84,"updated":"2016-01-26 12:47:36.000000000","message":"It\u0027s better to use here the constant I mentioned earlier.","commit_id":"f406e346475260c4ff8477ea940dbd2820d202f6"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"e2178b664299fab117066f6ee4aef19ef6e93aab","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                                   volume_source)"},{"line_number":82,"context_line":"        volume_source_type[0].text \u003d volume_source_type[1]"},{"line_number":83,"context_line":"        volume_form.size.text \u003d volume_size"},{"line_number":84,"context_line":"        if volume_source_type !\u003d \"Volume\":"},{"line_number":85,"context_line":"            volume_form.type.value \u003d self.conf.volume.volume_type"},{"line_number":86,"context_line":"            volume_form.availability_zone.value \u003d \\"},{"line_number":87,"context_line":"                self.conf.launch_instances.available_zone"}],"source_content_type":"text/x-python","patch_set":30,"id":"7a5de9d1_6d95cde2","line":84,"updated":"2016-01-27 19:37:47.000000000","message":"VOLUME_SOURCE_TYPE","commit_id":"f406e346475260c4ff8477ea940dbd2820d202f6"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"e2178b664299fab117066f6ee4aef19ef6e93aab","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _get_source_name(self, volume_form, volume_source_type, conf,"},{"line_number":129,"context_line":"                         volume_source):"},{"line_number":130,"context_line":"        if volume_source_type \u003d\u003d \u0027Image\u0027:"},{"line_number":131,"context_line":"            return volume_form.image_source, conf.image_name"},{"line_number":132,"context_line":"        if volume_source_type \u003d\u003d \u0027Volume\u0027:"},{"line_number":133,"context_line":"            return volume_form.volume_id, volume_source"}],"source_content_type":"text/x-python","patch_set":30,"id":"7a5de9d1_0d8779b6","line":130,"updated":"2016-01-27 19:37:47.000000000","message":"IMAGE_SOURCE_TYPE","commit_id":"f406e346475260c4ff8477ea940dbd2820d202f6"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"fb7590530990160729496053ab379db25420a361","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _get_source_name(self, volume_form, volume_source_type, conf,"},{"line_number":129,"context_line":"                         volume_source):"},{"line_number":130,"context_line":"        if volume_source_type \u003d\u003d \u0027Image\u0027:"},{"line_number":131,"context_line":"            return volume_form.image_source, conf.image_name"},{"line_number":132,"context_line":"        if volume_source_type \u003d\u003d \u0027Volume\u0027:"},{"line_number":133,"context_line":"            return volume_form.volume_id, volume_source"}],"source_content_type":"text/x-python","patch_set":30,"id":"9a68dd71_9c6c0738","line":130,"updated":"2016-01-26 12:47:36.000000000","message":"Same comment about constant here and below.","commit_id":"f406e346475260c4ff8477ea940dbd2820d202f6"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"10143a0ee4169e49b188e4df0189394afc5942bb","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                                   self.conf.launch_instances,"},{"line_number":82,"context_line":"                                                   volume_source)"},{"line_number":83,"context_line":"        volume_source_type[0].text \u003d volume_source_type[1]"},{"line_number":84,"context_line":"        volume_form.size.text \u003d self.conf.volume.volume_size"},{"line_number":85,"context_line":"        if volume_source_type !\u003d \"Volume\":"},{"line_number":86,"context_line":"            volume_form.type.value \u003d self.conf.volume.volume_type"},{"line_number":87,"context_line":"            volume_form.availability_zone.value \u003d \\"}],"source_content_type":"text/x-python","patch_set":31,"id":"7a5de9d1_6d314d0b","line":84,"updated":"2016-01-27 19:38:56.000000000","message":"Sorry, I may have misguided you a bit. It\u0027s valuable to pass volume_size as an argument and if it\u0027s None (default), set it to conf.volume_size. Then assign volume_size to form input.","commit_id":"71e53a71701bdf81f4bf63ac1f78cacba8530a3d"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"72760a9070187711ff769292638c708709498bb4","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                                                   self.conf.launch_instances,"},{"line_number":83,"context_line":"                                                   volume_source)"},{"line_number":84,"context_line":"        volume_source_type[0].text \u003d volume_source_type[1]"},{"line_number":85,"context_line":"        volume_form.size.value \u003d volume_size if volume_size \\"},{"line_number":86,"context_line":"            else self.conf.volume.volume_size"},{"line_number":87,"context_line":"        if volume_source_type !\u003d \"Volume\":"},{"line_number":88,"context_line":"            volume_form.type.value \u003d self.conf.volume.volume_type"}],"source_content_type":"text/x-python","patch_set":32,"id":"7a5de9d1_ce413b0d","line":85,"updated":"2016-01-28 11:32:38.000000000","message":"volume_size \u003d\u003d 0 is also False in this context, but it doesn\u0027t correspond to the \u0027unset\u0027 state of this variable. More bulletproof approach here would be:\n\n  if volume_size is None:\n    volume_size \u003d self.conf.volume.volume_size\n  ...\n  volume_form.size.value \u003d volume_size","commit_id":"31bf755e391f0f0c71cbd5fa603c77b07ab41066"}],"openstack_dashboard/test/integration_tests/pages/project/compute/volumespage.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2bfb15f671b730e5366dbb2a201975768ee0228e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    DEFAULT_VOLUME_SIZE \u003d \"1\""},{"line_number":33,"context_line":"    DEFAULT_AVAILABILITY \u003d \"nova\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    VOLUMES_TABLE_ACTIONS \u003d (\"create_volume\","},{"line_number":36,"context_line":"                             \"accept_transfer\","},{"line_number":37,"context_line":"                             \"delete_volumes\")"},{"line_number":38,"context_line":"    VOLUMES_TABLE_ROW_ACTIONS \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_9e5cef26","line":35,"updated":"2015-10-19 15:42:48.000000000","message":"Please note how table actions are defined here: https://review.openstack.org/#/c/117091/43/openstack_dashboard/test/integration_tests/pages/project/compute/instancespage.py - it\u0027s better to use button ids instead of verbose names, because in latter case clicking on the right button relies on buttons relative order.","commit_id":"0603e72fcf59239f24721c7e29dbac14491dfc3e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2bfb15f671b730e5366dbb2a201975768ee0228e","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                     volume_type\u003dDEFAULT_VOLUME_TYPE,"},{"line_number":85,"context_line":"                     volume_size\u003dDEFAULT_VOLUME_SIZE,"},{"line_number":86,"context_line":"                     volume_availability_zone\u003dDEFAULT_AVAILABILITY):"},{"line_number":87,"context_line":"        self.volumes_table.create_volume.click()"},{"line_number":88,"context_line":"        self.create_volume_form.name.text \u003d name"},{"line_number":89,"context_line":"        if description is not None:"},{"line_number":90,"context_line":"            self.create_volume_form.description.text \u003d description"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_3efa7bbe","line":87,"updated":"2015-10-19 15:42:48.000000000","message":"volumes_table.create.click()","commit_id":"0603e72fcf59239f24721c7e29dbac14491dfc3e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2bfb15f671b730e5366dbb2a201975768ee0228e","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        row.mark()"},{"line_number":104,"context_line":"        self.volumes_table.delete_volume.click()"},{"line_number":105,"context_line":"        self.confirm_delete_volumes_form.submit.click()"},{"line_number":106,"context_line":"        self._wait_till_spinner_disappears()"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def delete_volume(self, name):"},{"line_number":109,"context_line":"        row \u003d self._get_row_with_volume_name(name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_be052bc3","line":106,"updated":"2015-10-19 15:42:48.000000000","message":"no longer there, use self.wait_till_popups_disappear()","commit_id":"0603e72fcf59239f24721c7e29dbac14491dfc3e"},{"author":{"_account_id":13420,"name":"Serhii Vasheka","email":"svasheka@mirantis.com","username":"svasheka"},"change_message_id":"e41f688e7adeb28fc384364481eac42b4d74c200","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        row.mark()"},{"line_number":104,"context_line":"        self.volumes_table.delete_volume.click()"},{"line_number":105,"context_line":"        self.confirm_delete_volumes_form.submit.click()"},{"line_number":106,"context_line":"        self._wait_till_spinner_disappears()"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def delete_volume(self, name):"},{"line_number":109,"context_line":"        row \u003d self._get_row_with_volume_name(name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_31738982","line":106,"in_reply_to":"3a29b11f_be052bc3","updated":"2015-10-19 16:36:38.000000000","message":"Ok, I obviously need to do rebase and continue.","commit_id":"0603e72fcf59239f24721c7e29dbac14491dfc3e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"2bfb15f671b730e5366dbb2a201975768ee0228e","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        self.volumes_table.delete_volumes.click()"},{"line_number":112,"context_line":"        self.confirm_delete_volumes_form.submit.click()"},{"line_number":113,"context_line":"        self._wait_till_spinner_disappears()"},{"line_number":114,"context_line":"        self._wait_for_volume_to_delete(name)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def _wait_for_volume_to_delete(self, name):"},{"line_number":117,"context_line":"        while self.is_volume_present(name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_beb68bda","line":114,"updated":"2015-10-19 15:42:48.000000000","message":"self._wait_till_element_disappears(volume_row_element) should be used here.","commit_id":"0603e72fcf59239f24721c7e29dbac14491dfc3e"}],"openstack_dashboard/test/integration_tests/tests/test_volumes.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"37c35aca098d3dbadc056332851023e3c109e184","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                                                      \u0027Available\u0027))"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        volumes_page.edit_volume(self.VOLUME_NAME)"},{"line_number":48,"context_line":"        self.VOLUME_NAME \u003d \"edited_\" + self.VOLUME_NAME"},{"line_number":49,"context_line":"        self.assertTrue("},{"line_number":50,"context_line":"            volumes_page.find_message_and_dismiss(messages.INFO))"},{"line_number":51,"context_line":"        self.assertFalse("}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_4c880fe8","line":48,"updated":"2015-12-30 15:56:27.000000000","message":"See comment in previous file; we need to pass explicity important attributes being changed (like \u0027name\u0027) and other arguments (like \u0027description\u0027) could be set to the default values (w/o passing them here).","commit_id":"4bfba4ca2e1fb4e16eb1407a624c2c9f5fd5844b"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"37c35aca098d3dbadc056332851023e3c109e184","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                                                      \u0027Available\u0027))"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        volumes_page.edit_volume(self.VOLUME_NAME)"},{"line_number":96,"context_line":"        self.VOLUME_NAME \u003d \"edited_\" + self.VOLUME_NAME"},{"line_number":97,"context_line":"        self.assertTrue("},{"line_number":98,"context_line":"            volumes_page.find_message_and_dismiss(messages.INFO))"},{"line_number":99,"context_line":"        self.assertFalse("}],"source_content_type":"text/x-python","patch_set":14,"id":"fa69d971_0c6bf71f","line":96,"updated":"2015-12-30 15:56:27.000000000","message":"ditto","commit_id":"4bfba4ca2e1fb4e16eb1407a624c2c9f5fd5844b"}]}
