)]}'
{"openstack_dashboard/test/integration_tests/pages/admin/system/volumes/volumesnapshotspage.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"3d11473e62cfc0c412b382202479ba2ba9a21ed9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    import volumesnapshotspage"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class VolumesnapshotsTable(volumesnapshotspage.VolumesnapshotsTable):"},{"line_number":18,"context_line":"    pass"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a5de9d1_f068b4bc","line":17,"updated":"2016-01-28 11:58:44.000000000","message":"Not needed.","commit_id":"10255f15d3bdfe27534120d760cc33003c932cad"}],"openstack_dashboard/test/integration_tests/pages/project/compute/volumes/volumesnapshotspage.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"3d11473e62cfc0c412b382202479ba2ba9a21ed9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    SNAPSHOT_TABLE_NAME_COLUMN \u003d \u0027name\u0027"},{"line_number":51,"context_line":"    SNAPSHOT_TABLE_STATUS_COLUMN \u003d \u0027status\u0027"},{"line_number":52,"context_line":"    SNAPSHOT_TABLE_VOLUME_NAME_COLUMN \u003d \u0027volume_name\u0027"},{"line_number":53,"context_line":"    DEFAULT_VOLUME_SIZE \u003d \"1\""},{"line_number":54,"context_line":"    _volumes_tab_locator \u003d ("},{"line_number":55,"context_line":"        by.By.CSS_SELECTOR,"},{"line_number":56,"context_line":"        \u0027a[href*\u003d\"tab\u003dvolumes_and_snapshots__volumes_tab\"]\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a5de9d1_6e4a87ae","line":53,"updated":"2016-01-28 11:58:44.000000000","message":"The same comment about self.conf.volume.volume_size from parent commit applies here.","commit_id":"10255f15d3bdfe27534120d760cc33003c932cad"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"3d11473e62cfc0c412b382202479ba2ba9a21ed9","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    def delete_volume_snapshot(self, name):"},{"line_number":79,"context_line":"        row \u003d self._get_row_with_volume_snapshot_name(name)"},{"line_number":80,"context_line":"        row.mark()"},{"line_number":81,"context_line":"        confirm_delete_snapshot_form \u003d \\"},{"line_number":82,"context_line":"            self.volumesnapshots_table.delete_volume_snapshot()"},{"line_number":83,"context_line":"        confirm_delete_snapshot_form.submit()"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a5de9d1_2ec00fe0","line":81,"updated":"2016-01-28 11:58:44.000000000","message":"Just keep in mind that it\u0027s entirely up to you to make this names shorter if you\u0027d like to ;).","commit_id":"10255f15d3bdfe27534120d760cc33003c932cad"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"3d11473e62cfc0c412b382202479ba2ba9a21ed9","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        row \u003d self._get_row_with_volume_snapshot_name(name)"},{"line_number":107,"context_line":"        return row.cells[self.SNAPSHOT_TABLE_VOLUME_NAME_COLUMN].text"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def is_volume_name_correct(self, snapshot_name, volume_name):"},{"line_number":110,"context_line":"        actual_volume_name \u003d self._get_volume_name_from_row(snapshot_name)"},{"line_number":111,"context_line":"        if actual_volume_name \u003d\u003d volume_name:"},{"line_number":112,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a5de9d1_51bace24","line":109,"updated":"2016-01-28 11:58:44.000000000","message":"IMO, this method is too specific. It\u0027d be better to provide a method for extracting volume name from snapshot entity/ snapshots table given the snapshot name - and then make assertEqual(expected_volume_name, extracted_volume_name) in actual test.","commit_id":"10255f15d3bdfe27534120d760cc33003c932cad"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"3d11473e62cfc0c412b382202479ba2ba9a21ed9","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            volume_form.name.text \u003d volume_name"},{"line_number":131,"context_line":"        if description:"},{"line_number":132,"context_line":"            volume_form.description.text \u003d description"},{"line_number":133,"context_line":"        volume_form.size.text \u003d volume_size"},{"line_number":134,"context_line":"        volume_form.submit()"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a5de9d1_11ea1610","line":133,"updated":"2016-01-28 11:58:44.000000000","message":"Should it be .text or .value? In the parent commit I saw size.value in the same role.","commit_id":"10255f15d3bdfe27534120d760cc33003c932cad"}],"openstack_dashboard/test/integration_tests/pages/project/compute/volumes/volumespage.py":[{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"ed451853661572e94e4060a2624e5f8f8984d0c9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"class VolumesPage(basepage.BaseNavigationPage):"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    DEFAULT_VOLUME_SOURCE \u003d \"Image\""},{"line_number":62,"context_line":"    DEFAULT_SOURCE_IMAGE \u003d \"cirros-0.3.4-x86_64-uec (24.0 MB)\""},{"line_number":63,"context_line":"    DEFAULT_VOLUME_NAME \u003d None"},{"line_number":64,"context_line":"    DEFAULT_VOLUME_TYPE \u003d \"lvmdriver-1\""},{"line_number":65,"context_line":"    DEFAULT_VOLUME_SIZE \u003d \"1\""}],"source_content_type":"text/x-python","patch_set":9,"id":"9a68dd71_4c5c8f25","line":62,"updated":"2016-01-20 21:36:44.000000000","message":"I think some of these defaults should be configurable to reflect system configuration other than default devstack. I think DEFAULT_SOURCE_IMAGE, DEFAULT_VOLUME_TYPE, and DEFAULT_AVAILABILITY need to be configurable because they need to match the server. I care less about DEFAULT_VOLUME_SOURCE, DEFAULT_VOLUME_NAME and DEFAULT_VOLUME_SIZE because these are more about the test, rather than the system itself.","commit_id":"db0888f6ae559dea776066a6ccb3cdcfbfcdd146"}],"openstack_dashboard/test/integration_tests/tests/test_volume_snapshots.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"3d11473e62cfc0c412b382202479ba2ba9a21ed9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            volumes_snapshot_page.is_volume_snapshot_available("},{"line_number":57,"context_line":"                VOLUME_SNAPSHOT_NAME))"},{"line_number":58,"context_line":"        self.assertTrue("},{"line_number":59,"context_line":"            volumes_snapshot_page.is_volume_name_correct("},{"line_number":60,"context_line":"                VOLUME_SNAPSHOT_NAME, VOLUME_NAME))"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        new_name \u003d \"new_\" + VOLUME_SNAPSHOT_NAME"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a5de9d1_51bf2efb","line":59,"updated":"2016-01-28 11:58:44.000000000","message":"See my previous comment about method being too specific.","commit_id":"10255f15d3bdfe27534120d760cc33003c932cad"}]}
