)]}'
{"openstack_dashboard/dashboards/project/loadbalancers/workflows.py":[{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"6cc32175050961c063bba2302c137606f05de376","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        subnet_id_choices \u003d [(\u0027\u0027, _(\"Select a Subnet\"))]"},{"line_number":50,"context_line":"        try:"},{"line_number":51,"context_line":"            networks \u003d api.quantum.network_list_for_tenant(request, tenant_id)"},{"line_number":52,"context_line":"            for n in networks:"},{"line_number":53,"context_line":"                for s in n[\u0027subnets\u0027]:"},{"line_number":54,"context_line":"                    subnet_id_choices.append((s.id, s.cidr))"},{"line_number":55,"context_line":"        except:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2FzY0%3D","line":52,"updated":"2013-03-12 00:22:06.000000000","message":"This is an afterthought as the change has already been approved, but please try to keep the code in the try clause to the bare minimum. The way this is usually handled in horizon is to set the variable to an empty list in the except clause. This way internal horizon bugs don\u0027t get masked by these broad exception clauses.","commit_id":"b2b4507ecd91a36779845516becdb5e6af4b9c2a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8829e2ba7feececc3de060ac45c4dfbe97f5ba62","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        subnet_id_choices \u003d [(\u0027\u0027, _(\"Select a Subnet\"))]"},{"line_number":50,"context_line":"        try:"},{"line_number":51,"context_line":"            networks \u003d api.quantum.network_list_for_tenant(request, tenant_id)"},{"line_number":52,"context_line":"            for n in networks:"},{"line_number":53,"context_line":"                for s in n[\u0027subnets\u0027]:"},{"line_number":54,"context_line":"                    subnet_id_choices.append((s.id, s.cidr))"},{"line_number":55,"context_line":"        except:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2FzXk%3D","line":52,"in_reply_to":"AAAAN3%2F%2FzY0%3D","updated":"2013-03-12 00:37:04.000000000","message":"Thanks. I agree. It is better to keep the for loop unchange from the original and add networks \u003d [] to except clause.\n\nThe gating job failed :-) It is a good chance to fix.","commit_id":"b2b4507ecd91a36779845516becdb5e6af4b9c2a"}]}