)]}'
{"openstack_dashboard/dashboards/project/network_topology/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0eb44c9dab06ba57803f1bda6ca97189d6efafd9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                continue"},{"line_number":41,"context_line":"            resource[\u0027url\u0027] \u003d reverse(view, None, [str(resource[\u0027id\u0027])])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _select_port_by_network_id(self, ports, router_id, network_id):"},{"line_number":44,"context_line":"        for port in ports:"},{"line_number":45,"context_line":"            if (port[\u0027network_id\u0027] \u003d\u003d network_id"},{"line_number":46,"context_line":"                    and port[\u0027device_id\u0027] \u003d\u003d router_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2FzVo%3D","line":43,"updated":"2013-03-12 01:06:55.000000000","message":"I think \"select_port\" is not a good name. It checks if  there is a port for the external network of the router (including fake_port) and returns True/False. I prefer to _check_router_external_port() instead.\n\nHonestly I first cannot understand what this method does.","commit_id":"ff72e95b2cb717cd0ab646b8d20b757416bd2f48"},{"author":{"_account_id":6767,"name":"Toshiyuki Hayashi","email":"hayashi@nttmcl.com","username":"hayashi"},"change_message_id":"c169c74af3199f3187ff717ff3252e8762b43d37","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                continue"},{"line_number":41,"context_line":"            resource[\u0027url\u0027] \u003d reverse(view, None, [str(resource[\u0027id\u0027])])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _select_port_by_network_id(self, ports, router_id, network_id):"},{"line_number":44,"context_line":"        for port in ports:"},{"line_number":45,"context_line":"            if (port[\u0027network_id\u0027] \u003d\u003d network_id"},{"line_number":46,"context_line":"                    and port[\u0027device_id\u0027] \u003d\u003d router_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2FxN8%3D","line":43,"in_reply_to":"AAAAN3%2F%2FzVo%3D","updated":"2013-03-13 03:22:07.000000000","message":"fixed in patch set 2.","commit_id":"ff72e95b2cb717cd0ab646b8d20b757416bd2f48"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0eb44c9dab06ba57803f1bda6ca97189d6efafd9","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        data[\u0027ports\u0027] \u003d ports.get(\u0027ports\u0027, [])"},{"line_number":73,"context_line":"        self.add_resource_url(\u0027horizon:project:networks:ports:detail\u0027,"},{"line_number":74,"context_line":"                              data[\u0027ports\u0027])"},{"line_number":75,"context_line":"        data[\u0027routers\u0027] \u003d routers.get(\u0027routers\u0027, [])"},{"line_number":76,"context_line":"        # user can\u0027t see port on shared network. so we are"},{"line_number":77,"context_line":"        # adding fake port based on router information"},{"line_number":78,"context_line":"        for router in data[\u0027routers\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2FzVw%3D","line":75,"updated":"2013-03-12 01:06:55.000000000","message":"shared network -\u003e external network?","commit_id":"ff72e95b2cb717cd0ab646b8d20b757416bd2f48"},{"author":{"_account_id":6767,"name":"Toshiyuki Hayashi","email":"hayashi@nttmcl.com","username":"hayashi"},"change_message_id":"c169c74af3199f3187ff717ff3252e8762b43d37","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        data[\u0027ports\u0027] \u003d ports.get(\u0027ports\u0027, [])"},{"line_number":73,"context_line":"        self.add_resource_url(\u0027horizon:project:networks:ports:detail\u0027,"},{"line_number":74,"context_line":"                              data[\u0027ports\u0027])"},{"line_number":75,"context_line":"        data[\u0027routers\u0027] \u003d routers.get(\u0027routers\u0027, [])"},{"line_number":76,"context_line":"        # user can\u0027t see port on shared network. so we are"},{"line_number":77,"context_line":"        # adding fake port based on router information"},{"line_number":78,"context_line":"        for router in data[\u0027routers\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2FxN4%3D","line":75,"in_reply_to":"AAAAN3%2F%2FzVw%3D","updated":"2013-03-13 03:22:07.000000000","message":"fixed patch set2.","commit_id":"ff72e95b2cb717cd0ab646b8d20b757416bd2f48"}]}
