)]}'
{"doc/source/topics/settings.rst":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8119e576d871a2b9ccbb3e64dcb3d12a51ff12e0","unresolved":false,"context_lines":[{"line_number":750,"context_line":""},{"line_number":751,"context_line":"Set this to True to enable panels that provide the ability for users to manage"},{"line_number":752,"context_line":"Identity Providers (IdPs) and establish a set of rules to map federation protocol"},{"line_number":753,"context_line":"attributes to Identity API attributes. This extension requires v3.0+ of the Identity."},{"line_number":754,"context_line":""},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"``WEBSSO_ENABLED``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da85f559_35829353","line":753,"updated":"2015-11-14 12:02:37.000000000","message":"the end of the sentence seems a little lacking... \"of the Identity API*\"","commit_id":"0293ddf27ff3aa20eb15e87f589775ed1d968627"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a3d0cc334ce413e21abeef23931166593d0b4e03","unresolved":false,"context_lines":[{"line_number":750,"context_line":""},{"line_number":751,"context_line":"Set this to True to enable panels that provide the ability for users to manage"},{"line_number":752,"context_line":"Identity Providers (IdPs) and establish a set of rules to map federation protocol"},{"line_number":753,"context_line":"attributes to Identity API attributes. This extension requires v3.0+ of the Identity."},{"line_number":754,"context_line":""},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"``WEBSSO_ENABLED``"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da85f559_1a3453dc","line":753,"in_reply_to":"da85f559_35829353","updated":"2015-11-15 03:55:40.000000000","message":"Done","commit_id":"0293ddf27ff3aa20eb15e87f589775ed1d968627"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"4f729dad096b0fa99352e23aa9d1cdb212907924","unresolved":false,"context_lines":[{"line_number":742,"context_line":"a nonstandard URL scheme you shouldn\u0027t need to touch this setting."},{"line_number":743,"context_line":""},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"``OPENSTACK_KEYSTONE_FEDERATION_SUPPORT``"},{"line_number":746,"context_line":"------------------------------------------"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":".. versionadded:: 9.0.0(Mitaka)"}],"source_content_type":"text/x-rst","patch_set":14,"id":"9a68dd71_b4098ddf","line":745,"updated":"2016-01-22 00:09:10.000000000","message":"maybe MANAGE in the setting name somewhere? we support federation even is this is false.","commit_id":"bd7e0a6c9ab8e1991888cae15ef284b9e87e8002"}],"openstack_dashboard/api/keystone.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8119e576d871a2b9ccbb3e64dcb3d12a51ff12e0","unresolved":false,"context_lines":[{"line_number":759,"context_line":""},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"def identity_provider_create(request, idp_id, description\u003dNone,"},{"line_number":762,"context_line":"                             enabled\u003dNone, remote_ids\u003d[]):"},{"line_number":763,"context_line":"    manager \u003d keystoneclient(request, admin\u003dTrue).federation.identity_providers"},{"line_number":764,"context_line":"    return manager.create(id\u003didp_id,"},{"line_number":765,"context_line":"                          description\u003ddescription,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_35e9331b","line":762,"updated":"2015-11-14 12:02:37.000000000","message":"don\u0027t want to default things to True for convenience? I think our server side code defaults this to false: http://specs.openstack.org/openstack/keystone-specs/api/v3/identity-api-v3-os-federation-ext.html#identity-providers","commit_id":"0293ddf27ff3aa20eb15e87f589775ed1d968627"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a3d0cc334ce413e21abeef23931166593d0b4e03","unresolved":false,"context_lines":[{"line_number":759,"context_line":""},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"def identity_provider_create(request, idp_id, description\u003dNone,"},{"line_number":762,"context_line":"                             enabled\u003dNone, remote_ids\u003d[]):"},{"line_number":763,"context_line":"    manager \u003d keystoneclient(request, admin\u003dTrue).federation.identity_providers"},{"line_number":764,"context_line":"    return manager.create(id\u003didp_id,"},{"line_number":765,"context_line":"                          description\u003ddescription,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_9a560305","line":762,"in_reply_to":"da85f559_35e9331b","updated":"2015-11-15 03:55:40.000000000","message":"good catch, going to default to False to match Keystone","commit_id":"0293ddf27ff3aa20eb15e87f589775ed1d968627"},{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"1ac60ff4c52fd5b5882c1337b11d0d333442b163","unresolved":false,"context_lines":[{"line_number":768,"context_line":"                              remote_ids\u003dremote_ids)"},{"line_number":769,"context_line":"    except keystone_exceptions.Conflict:"},{"line_number":770,"context_line":"        raise exceptions.Conflict()"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"def identity_provider_get(request, idp_id):"},{"line_number":773,"context_line":"    manager \u003d keystoneclient(request, admin\u003dTrue).federation.identity_providers"},{"line_number":774,"context_line":"    return manager.get(idp_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_c75ec744","line":771,"updated":"2015-11-24 07:08:20.000000000","message":"need one more blank line here. which is causing the pep-8 failure.","commit_id":"b3c561a51826e44c108c2f1070dbf647d58a50e6"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"3f6a468778fe9a8ab48f31f65e212f0749e67a9d","unresolved":false,"context_lines":[{"line_number":767,"context_line":"                              enabled\u003denabled,"},{"line_number":768,"context_line":"                              remote_ids\u003dremote_ids)"},{"line_number":769,"context_line":"    except keystone_exceptions.Conflict:"},{"line_number":770,"context_line":"        raise exceptions.Conflict()"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"def identity_provider_get(request, idp_id):"}],"source_content_type":"text/x-python","patch_set":13,"id":"da6ed579_8e6332dc","line":770,"updated":"2016-01-13 04:22:35.000000000","message":"Do we lose any important information here by squashing the exception from the keystone client?","commit_id":"14ce8ec62f2495f6c20e0c79843b87dc8e5e48e6"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"83cefda8055efaef2e06ad9383643dd0f24f42eb","unresolved":false,"context_lines":[{"line_number":767,"context_line":"                              enabled\u003denabled,"},{"line_number":768,"context_line":"                              remote_ids\u003dremote_ids)"},{"line_number":769,"context_line":"    except keystone_exceptions.Conflict:"},{"line_number":770,"context_line":"        raise exceptions.Conflict()"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"def identity_provider_get(request, idp_id):"}],"source_content_type":"text/x-python","patch_set":13,"id":"da6ed579_64a275b0","line":770,"in_reply_to":"da6ed579_8e6332dc","updated":"2016-01-13 18:17:48.000000000","message":"Not really, we do squash all client error message as they are not translatable :(\n\nWe also do the same thing in tenant_create function and other areas. I don\u0027t think is the best, but this is what we decided to make all message translatable. \n\nWe should revisit this again, and make python-client language aware.","commit_id":"14ce8ec62f2495f6c20e0c79843b87dc8e5e48e6"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"4f729dad096b0fa99352e23aa9d1cdb212907924","unresolved":false,"context_lines":[{"line_number":754,"context_line":"    return VERSIONS.active"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":""},{"line_number":757,"context_line":"def is_federation_enabled():"},{"line_number":758,"context_line":"    return getattr(settings, \u0027OPENSTACK_KEYSTONE_FEDERATION_SUPPORT\u0027, False)"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a68dd71_942d6948","line":757,"updated":"2016-01-22 00:09:10.000000000","message":"suggestion: is_federation_management_enabled()","commit_id":"bd7e0a6c9ab8e1991888cae15ef284b9e87e8002"}],"openstack_dashboard/dashboards/identity/identity_providers/forms.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8119e576d871a2b9ccbb3e64dcb3d12a51ff12e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"da85f559_3537f3b1","updated":"2015-11-14 12:02:37.000000000","message":"there\u0027s a lot of switching between:\n\n  Identity Provider / Identity provider / identity provider / IdP\n\npick one and run with it\n\nmy vote is for:\n\n  identity provider\n\nunless it begins a sentence","commit_id":"0293ddf27ff3aa20eb15e87f589775ed1d968627"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8119e576d871a2b9ccbb3e64dcb3d12a51ff12e0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    remote_ids \u003d forms.CharField(label\u003d_(\"Remote IDs\"),"},{"line_number":30,"context_line":"                                 required\u003dFalse,"},{"line_number":31,"context_line":"                                 help_text\u003d_(\"Comma-delimited list of valid \""},{"line_number":32,"context_line":"                                             \"remote IdP entity values from \""},{"line_number":33,"context_line":"                                             \"Identity Provider.\"))"},{"line_number":34,"context_line":"    description \u003d forms.CharField(label\u003d_(\"Description\"),"},{"line_number":35,"context_line":"                                  widget\u003dforms.widgets.Textarea("}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_355e13ea","line":32,"updated":"2015-11-14 12:02:37.000000000","message":"remote IDs?","commit_id":"0293ddf27ff3aa20eb15e87f589775ed1d968627"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a3d0cc334ce413e21abeef23931166593d0b4e03","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    remote_ids \u003d forms.CharField(label\u003d_(\"Remote IDs\"),"},{"line_number":30,"context_line":"                                 required\u003dFalse,"},{"line_number":31,"context_line":"                                 help_text\u003d_(\"Comma-delimited list of valid \""},{"line_number":32,"context_line":"                                             \"remote IdP entity values from \""},{"line_number":33,"context_line":"                                             \"Identity Provider.\"))"},{"line_number":34,"context_line":"    description \u003d forms.CharField(label\u003d_(\"Description\"),"},{"line_number":35,"context_line":"                                  widget\u003dforms.widgets.Textarea("}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_9a404309","line":32,"in_reply_to":"da85f559_355e13ea","updated":"2015-11-15 03:55:40.000000000","message":"Done","commit_id":"0293ddf27ff3aa20eb15e87f589775ed1d968627"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8119e576d871a2b9ccbb3e64dcb3d12a51ff12e0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                                 required\u003dFalse,"},{"line_number":31,"context_line":"                                 help_text\u003d_(\"Comma-delimited list of valid \""},{"line_number":32,"context_line":"                                             \"remote IdP entity values from \""},{"line_number":33,"context_line":"                                             \"Identity Provider.\"))"},{"line_number":34,"context_line":"    description \u003d forms.CharField(label\u003d_(\"Description\"),"},{"line_number":35,"context_line":"                                  widget\u003dforms.widgets.Textarea("},{"line_number":36,"context_line":"                                      attrs\u003d{\u0027rows\u0027: 4}),"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_b54be32a","line":33,"updated":"2015-11-14 12:02:37.000000000","message":"identity provider","commit_id":"0293ddf27ff3aa20eb15e87f589775ed1d968627"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a3d0cc334ce413e21abeef23931166593d0b4e03","unresolved":false,"context_lines":[{"line_number":30,"context_line":"                                 required\u003dFalse,"},{"line_number":31,"context_line":"                                 help_text\u003d_(\"Comma-delimited list of valid \""},{"line_number":32,"context_line":"                                             \"remote IdP entity values from \""},{"line_number":33,"context_line":"                                             \"Identity Provider.\"))"},{"line_number":34,"context_line":"    description \u003d forms.CharField(label\u003d_(\"Description\"),"},{"line_number":35,"context_line":"                                  widget\u003dforms.widgets.Textarea("},{"line_number":36,"context_line":"                                      attrs\u003d{\u0027rows\u0027: 4}),"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_da9a4bc5","line":33,"in_reply_to":"da85f559_b54be32a","updated":"2015-11-15 03:55:40.000000000","message":"Done","commit_id":"0293ddf27ff3aa20eb15e87f589775ed1d968627"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8119e576d871a2b9ccbb3e64dcb3d12a51ff12e0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                enabled\u003ddata[\"enabled\"],"},{"line_number":51,"context_line":"                remote_ids\u003dremote_ids)"},{"line_number":52,"context_line":"            messages.success(request,"},{"line_number":53,"context_line":"                             _(\"Identity Provider registered  successfully.\"))"},{"line_number":54,"context_line":"            return new_idp"},{"line_number":55,"context_line":"        except Exception:"},{"line_number":56,"context_line":"            exceptions.handle(request,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_95e25f2e","line":53,"updated":"2015-11-14 12:02:37.000000000","message":"two spaces?\n\nIdentity provider*","commit_id":"0293ddf27ff3aa20eb15e87f589775ed1d968627"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a3d0cc334ce413e21abeef23931166593d0b4e03","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                enabled\u003ddata[\"enabled\"],"},{"line_number":51,"context_line":"                remote_ids\u003dremote_ids)"},{"line_number":52,"context_line":"            messages.success(request,"},{"line_number":53,"context_line":"                             _(\"Identity Provider registered  successfully.\"))"},{"line_number":54,"context_line":"            return new_idp"},{"line_number":55,"context_line":"        except Exception:"},{"line_number":56,"context_line":"            exceptions.handle(request,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_fa9dcfbb","line":53,"in_reply_to":"da85f559_95e25f2e","updated":"2015-11-15 03:55:40.000000000","message":"Done","commit_id":"0293ddf27ff3aa20eb15e87f589775ed1d968627"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8119e576d871a2b9ccbb3e64dcb3d12a51ff12e0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            return new_idp"},{"line_number":55,"context_line":"        except Exception:"},{"line_number":56,"context_line":"            exceptions.handle(request,"},{"line_number":57,"context_line":"                              _(\"Unable to register identity  Provider.\"))"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class UpdateIdPForm(forms.SelfHandlingForm):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_55d3975f","line":57,"updated":"2015-11-14 12:02:37.000000000","message":"two spaces?\n\nidentity provider*","commit_id":"0293ddf27ff3aa20eb15e87f589775ed1d968627"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a3d0cc334ce413e21abeef23931166593d0b4e03","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            return new_idp"},{"line_number":55,"context_line":"        except Exception:"},{"line_number":56,"context_line":"            exceptions.handle(request,"},{"line_number":57,"context_line":"                              _(\"Unable to register identity  Provider.\"))"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class UpdateIdPForm(forms.SelfHandlingForm):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_9aa4c308","line":57,"in_reply_to":"da85f559_55d3975f","updated":"2015-11-15 03:55:40.000000000","message":"Done","commit_id":"0293ddf27ff3aa20eb15e87f589775ed1d968627"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8119e576d871a2b9ccbb3e64dcb3d12a51ff12e0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    remote_ids \u003d forms.CharField(label\u003d_(\"Remote IDs\"),"},{"line_number":67,"context_line":"                                 required\u003dFalse,"},{"line_number":68,"context_line":"                                 help_text\u003d_(\"Comma-delimited list of valid \""},{"line_number":69,"context_line":"                                             \"remote IdP entity values from \""},{"line_number":70,"context_line":"                                             \"Identity Provider.\"))"},{"line_number":71,"context_line":"    description \u003d forms.CharField(label\u003d_(\"Description\"),"},{"line_number":72,"context_line":"                                  widget\u003dforms.widgets.Textarea("}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_9567bfb6","line":69,"updated":"2015-11-14 12:02:37.000000000","message":"remote IDs?","commit_id":"0293ddf27ff3aa20eb15e87f589775ed1d968627"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a3d0cc334ce413e21abeef23931166593d0b4e03","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    remote_ids \u003d forms.CharField(label\u003d_(\"Remote IDs\"),"},{"line_number":67,"context_line":"                                 required\u003dFalse,"},{"line_number":68,"context_line":"                                 help_text\u003d_(\"Comma-delimited list of valid \""},{"line_number":69,"context_line":"                                             \"remote IdP entity values from \""},{"line_number":70,"context_line":"                                             \"Identity Provider.\"))"},{"line_number":71,"context_line":"    description \u003d forms.CharField(label\u003d_(\"Description\"),"},{"line_number":72,"context_line":"                                  widget\u003dforms.widgets.Textarea("}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_7abf9ffc","line":69,"in_reply_to":"da85f559_9567bfb6","updated":"2015-11-15 03:55:40.000000000","message":"Done","commit_id":"0293ddf27ff3aa20eb15e87f589775ed1d968627"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8119e576d871a2b9ccbb3e64dcb3d12a51ff12e0","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                                 required\u003dFalse,"},{"line_number":68,"context_line":"                                 help_text\u003d_(\"Comma-delimited list of valid \""},{"line_number":69,"context_line":"                                             \"remote IdP entity values from \""},{"line_number":70,"context_line":"                                             \"Identity Provider.\"))"},{"line_number":71,"context_line":"    description \u003d forms.CharField(label\u003d_(\"Description\"),"},{"line_number":72,"context_line":"                                  widget\u003dforms.widgets.Textarea("},{"line_number":73,"context_line":"                                      attrs\u003d{\u0027rows\u0027: 4}),"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_3505b3c1","line":70,"updated":"2015-11-14 12:02:37.000000000","message":"identity provider*","commit_id":"0293ddf27ff3aa20eb15e87f589775ed1d968627"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a3d0cc334ce413e21abeef23931166593d0b4e03","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                                 required\u003dFalse,"},{"line_number":68,"context_line":"                                 help_text\u003d_(\"Comma-delimited list of valid \""},{"line_number":69,"context_line":"                                             \"remote IdP entity values from \""},{"line_number":70,"context_line":"                                             \"Identity Provider.\"))"},{"line_number":71,"context_line":"    description \u003d forms.CharField(label\u003d_(\"Description\"),"},{"line_number":72,"context_line":"                                  widget\u003dforms.widgets.Textarea("},{"line_number":73,"context_line":"                                      attrs\u003d{\u0027rows\u0027: 4}),"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_dae80b19","line":70,"in_reply_to":"da85f559_3505b3c1","updated":"2015-11-15 03:55:40.000000000","message":"Done","commit_id":"0293ddf27ff3aa20eb15e87f589775ed1d968627"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"8119e576d871a2b9ccbb3e64dcb3d12a51ff12e0","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                  required\u003dFalse)"},{"line_number":75,"context_line":"    enabled \u003d forms.BooleanField(label\u003d_(\"Enabled\"),"},{"line_number":76,"context_line":"                                 required\u003dFalse,"},{"line_number":77,"context_line":"                                 initial\u003dTrue)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def handle(self, request, data):"},{"line_number":80,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_15e0aff9","line":77,"updated":"2015-11-14 12:02:37.000000000","message":"should this value be the current value of the idp? or is it a general rule of horizon to not pre-populate the update boxes with current status of the object?","commit_id":"0293ddf27ff3aa20eb15e87f589775ed1d968627"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"a3d0cc334ce413e21abeef23931166593d0b4e03","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                  required\u003dFalse)"},{"line_number":75,"context_line":"    enabled \u003d forms.BooleanField(label\u003d_(\"Enabled\"),"},{"line_number":76,"context_line":"                                 required\u003dFalse,"},{"line_number":77,"context_line":"                                 initial\u003dTrue)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def handle(self, request, data):"},{"line_number":80,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_fa394fa4","line":77,"in_reply_to":"da85f559_15e0aff9","updated":"2015-11-15 03:55:40.000000000","message":"this should be fine, the initial is used when there is no initial value is passed to the form. \n\nwhen the update form i invoke by the view, the initial value is set accordingly from the value in the backend","commit_id":"0293ddf27ff3aa20eb15e87f589775ed1d968627"},{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"7e61ff30b7dd6a8eb750b9c05c39906d8a881430","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                                     \"the identity provider.\"))"},{"line_number":29,"context_line":"    remote_ids \u003d forms.CharField(label\u003d_(\"Remote IDs\"),"},{"line_number":30,"context_line":"                                 required\u003dFalse,"},{"line_number":31,"context_line":"                                 help_text\u003d_(\"Comma-delimited list of valid \""},{"line_number":32,"context_line":"                                             \"remote IDs from the \""},{"line_number":33,"context_line":"                                             \"identity provider.\"))"},{"line_number":34,"context_line":"    description \u003d forms.CharField(label\u003d_(\"Description\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_41498bcf","line":31,"updated":"2015-11-23 15:28:28.000000000","message":"I think it would be helpful to describe the meaning of providing an empty list either here or on the template description area -- that is, does it mean no ids are valid, or every id is valid?","commit_id":"c10d9b45473c22778c297c14ce3c07cdc039b345"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"e86388a2fe7e8b30e361544e5186b21e90c26d40","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            messages.success(request,"},{"line_number":53,"context_line":"                             _(\"Identity provider registered successfully.\"))"},{"line_number":54,"context_line":"            return new_idp"},{"line_number":55,"context_line":"        except Exception:"},{"line_number":56,"context_line":"            exceptions.handle(request,"},{"line_number":57,"context_line":"                              _(\"Unable to register identity provider.\"))"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_bc63d1dc","line":55,"updated":"2015-11-23 09:00:38.000000000","message":"as id is a user-defined unique id, it\u0027s better to add a Conflict check here. otherwise it\u0027s just show \u0027Unable to register identity provider.\u0027","commit_id":"c10d9b45473c22778c297c14ce3c07cdc039b345"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"d2d8feac4ef17862076576cb5f017b5d8aed0b42","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            messages.success(request,"},{"line_number":53,"context_line":"                             _(\"Identity provider registered successfully.\"))"},{"line_number":54,"context_line":"            return new_idp"},{"line_number":55,"context_line":"        except Exception:"},{"line_number":56,"context_line":"            exceptions.handle(request,"},{"line_number":57,"context_line":"                              _(\"Unable to register identity provider.\"))"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_0fcdfeb6","line":55,"in_reply_to":"ba8a016a_bc63d1dc","updated":"2015-11-23 10:16:23.000000000","message":"good point, will add it on the nxt patch","commit_id":"c10d9b45473c22778c297c14ce3c07cdc039b345"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"4f729dad096b0fa99352e23aa9d1cdb212907924","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class RegisterIdPForm(forms.SelfHandlingForm):"},{"line_number":25,"context_line":"    id \u003d forms.CharField("},{"line_number":26,"context_line":"        label\u003d_(\"Identity Provider ID\"),"},{"line_number":27,"context_line":"        max_length\u003d64,"},{"line_number":28,"context_line":"        help_text\u003d_(\"User-defined unique id to identify the identity \""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a68dd71_54de1140","line":25,"updated":"2016-01-22 00:09:10.000000000","message":"is this expected to be a UUID, if so, should we generate one?","commit_id":"bd7e0a6c9ab8e1991888cae15ef284b9e87e8002"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"4f729dad096b0fa99352e23aa9d1cdb212907924","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    remote_ids \u003d forms.CharField("},{"line_number":31,"context_line":"        label\u003d_(\"Remote IDs\"),"},{"line_number":32,"context_line":"        required\u003dFalse,"},{"line_number":33,"context_line":"        help_text\u003d_(\"Comma-delimited list of valid remote IDs from the \""},{"line_number":34,"context_line":"                    \"identity provider.\"))"},{"line_number":35,"context_line":"    description \u003d forms.CharField("},{"line_number":36,"context_line":"        label\u003d_(\"Description\"),"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a68dd71_b4be6dd2","line":33,"updated":"2016-01-22 00:09:10.000000000","message":"maybe an example? unclear what would be entered here","commit_id":"bd7e0a6c9ab8e1991888cae15ef284b9e87e8002"}],"openstack_dashboard/dashboards/identity/identity_providers/templates/identity_providers/_register.html":[{"author":{"_account_id":9981,"name":"Doug Fish","email":"drfish@us.ibm.com","username":"doug-fish"},"change_message_id":"7e61ff30b7dd6a8eb750b9c05c39906d8a881430","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block modal-body-right %}"},{"line_number":5,"context_line":"  \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":6,"context_line":"  \u003cp\u003e{% trans \"Register a trusted identity provider.\" %}\u003c/p\u003e"},{"line_number":7,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":7,"id":"ba8a016a_3a4b4c5b","line":6,"updated":"2015-11-23 15:28:28.000000000","message":"I assume some extra words will show up here sooner or later. :-)","commit_id":"c10d9b45473c22778c297c14ce3c07cdc039b345"}],"openstack_dashboard/dashboards/identity/identity_providers/tests.py":[{"author":{"_account_id":8978,"name":"Marek Denis","email":"marek.denis+openstack@gmail.com","username":"marek-denis"},"change_message_id":"c33464dc7f169908309a3aa76477d2317cac6571","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class IdPsViewTests(test.BaseAdminViewTests):"},{"line_number":32,"context_line":"    @test.create_stubs({api.keystone: (\u0027identity_provider_list\u0027,)})"},{"line_number":33,"context_line":"    def test_index(self):"},{"line_number":34,"context_line":"        api.keystone.identity_provider_list(IgnoreArg()). \\"},{"line_number":35,"context_line":"            AndReturn(self.identity_providers.list())"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a8ffd7b_ce809649","line":34,"updated":"2015-11-24 13:42:44.000000000","message":"why breaking line with use of \\ instead of passing arguments from a new line?","commit_id":"ca23fc7e08327db71b13422c0d2956848b079f86"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"1fa0223878505d63fd5cd9db8cb00418e6ad0a90","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class IdPsViewTests(test.BaseAdminViewTests):"},{"line_number":32,"context_line":"    @test.create_stubs({api.keystone: (\u0027identity_provider_list\u0027,)})"},{"line_number":33,"context_line":"    def test_index(self):"},{"line_number":34,"context_line":"        api.keystone.identity_provider_list(IgnoreArg()). \\"},{"line_number":35,"context_line":"            AndReturn(self.identity_providers.list())"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a8ffd7b_e2480b8a","line":34,"in_reply_to":"9a8ffd7b_ce809649","updated":"2015-11-24 14:53:37.000000000","message":"this is the pattern used in horizon to make the code more readable which are the arguments and the return value.","commit_id":"ca23fc7e08327db71b13422c0d2956848b079f86"}],"openstack_dashboard/local/local_settings.py.example":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"4f729dad096b0fa99352e23aa9d1cdb212907924","unresolved":false,"context_lines":[{"line_number":64,"context_line":"# manage Identity Providers (IdPs) and establish a set of rules to map"},{"line_number":65,"context_line":"# federation protocol attributes to Identity API attributes."},{"line_number":66,"context_line":"# This extension requires v3.0+ of the Identity API."},{"line_number":67,"context_line":"#OPENSTACK_KEYSTONE_FEDERATION_SUPPORT \u003d False"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# Set Console type:"},{"line_number":70,"context_line":"# valid options are \"AUTO\"(default), \"VNC\", \"SPICE\", \"RDP\", \"SERIAL\" or None"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"9a68dd71_941329b8","line":67,"updated":"2016-01-22 00:09:10.000000000","message":"here, if the setting name is changed","commit_id":"bd7e0a6c9ab8e1991888cae15ef284b9e87e8002"}]}
