)]}'
{"openstack_dashboard/dashboards/project/instances/workflows/create_instance.py":[{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"b164a4fcf83aa887202dd3f3a36353b6d287ec7d","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                available \u003d api.cinder.VOLUME_STATE_AVAILABLE"},{"line_number":472,"context_line":"                volumes \u003d [self._get_volume_display_name(v)"},{"line_number":473,"context_line":"                           for v in cinder.volume_list(self.request,"},{"line_number":474,"context_line":"                           search_opts\u003ddict(status\u003davailable, bootable\u003d\u0027true\u0027))]"},{"line_number":475,"context_line":"        except Exception:"},{"line_number":476,"context_line":"            exceptions.handle(self.request,"},{"line_number":477,"context_line":"                              _(\u0027Unable to retrieve list of volumes.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a7b0d38_1ae5d3da","line":474,"range":{"start_line":474,"start_character":62,"end_line":474,"end_character":70},"updated":"2015-12-29 12:46:11.000000000","message":"Does bootable\u003dTrue work? since I find that: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/volumes/volumes/tests.py#L1353","commit_id":"8f360ae3f6371aaca64ee0f49dd5333cdcc6e768"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"a84a8aabe2793a098c55256e02430572663621b1","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                available \u003d api.cinder.VOLUME_STATE_AVAILABLE"},{"line_number":472,"context_line":"                volumes \u003d [self._get_volume_display_name(v)"},{"line_number":473,"context_line":"                           for v in cinder.volume_list(self.request,"},{"line_number":474,"context_line":"                           search_opts\u003ddict(status\u003davailable, bootable\u003d\u0027true\u0027))]"},{"line_number":475,"context_line":"        except Exception:"},{"line_number":476,"context_line":"            exceptions.handle(self.request,"},{"line_number":477,"context_line":"                              _(\u0027Unable to retrieve list of volumes.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_a34ae681","line":474,"range":{"start_line":474,"start_character":51,"end_line":474,"end_character":60},"updated":"2015-12-31 09:54:01.000000000","message":"In my Mysql env, bootable\u003d\u0027true\u0027 did not get bootable volumes with following warning log:\nsqlalchemy/engine/default.py:332: Warning: Truncated incorrect DOUBLE value: \u0027true\u0027\ncursor.execute(statement, parameters)\n\nIs this common issue or being caused of my env?","commit_id":"8f360ae3f6371aaca64ee0f49dd5333cdcc6e768"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"16018551ec2e26a06c48b6cbe34535daa4795d47","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                available \u003d api.cinder.VOLUME_STATE_AVAILABLE"},{"line_number":472,"context_line":"                volumes \u003d [self._get_volume_display_name(v)"},{"line_number":473,"context_line":"                           for v in cinder.volume_list(self.request,"},{"line_number":474,"context_line":"                           search_opts\u003ddict(status\u003davailable, bootable\u003d\u0027true\u0027))]"},{"line_number":475,"context_line":"        except Exception:"},{"line_number":476,"context_line":"            exceptions.handle(self.request,"},{"line_number":477,"context_line":"                              _(\u0027Unable to retrieve list of volumes.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_b302513d","line":474,"range":{"start_line":474,"start_character":62,"end_line":474,"end_character":70},"in_reply_to":"1a7b0d38_1ae5d3da","updated":"2015-12-30 13:13:15.000000000","message":"I am guessing both works, perhaps it used the oslo utils bool_from_string()..","commit_id":"8f360ae3f6371aaca64ee0f49dd5333cdcc6e768"},{"author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"change_message_id":"144e8e3bbb3be4b300cda26a29ec03bc086625ba","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                available \u003d api.cinder.VOLUME_STATE_AVAILABLE"},{"line_number":472,"context_line":"                volumes \u003d [self._get_volume_display_name(v)"},{"line_number":473,"context_line":"                           for v in cinder.volume_list(self.request,"},{"line_number":474,"context_line":"                           search_opts\u003ddict(status\u003davailable, bootable\u003d\u0027true\u0027))]"},{"line_number":475,"context_line":"        except Exception:"},{"line_number":476,"context_line":"            exceptions.handle(self.request,"},{"line_number":477,"context_line":"                              _(\u0027Unable to retrieve list of volumes.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_02a5b0a0","line":474,"range":{"start_line":474,"start_character":51,"end_line":474,"end_character":60},"in_reply_to":"fa69d971_a34ae681","updated":"2016-01-04 16:38:32.000000000","message":"Just an FYI that I made this change locally (running MySQL backend) and was still able to launch an instance with boot from volume selected (my bootable volume was detected and available in the drop-down).","commit_id":"8f360ae3f6371aaca64ee0f49dd5333cdcc6e768"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"297388123e2fe5dd61ba357969524ed789050d6a","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                available \u003d api.cinder.VOLUME_STATE_AVAILABLE"},{"line_number":472,"context_line":"                volumes \u003d [self._get_volume_display_name(v)"},{"line_number":473,"context_line":"                           for v in cinder.volume_list(self.request,"},{"line_number":474,"context_line":"                           search_opts\u003ddict(status\u003davailable, bootable\u003d\u0027true\u0027))]"},{"line_number":475,"context_line":"        except Exception:"},{"line_number":476,"context_line":"            exceptions.handle(self.request,"},{"line_number":477,"context_line":"                              _(\u0027Unable to retrieve list of volumes.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_f68a9ebe","line":474,"range":{"start_line":474,"start_character":51,"end_line":474,"end_character":60},"in_reply_to":"fa69d971_a34ae681","updated":"2016-01-04 18:09:29.000000000","message":"This seems strange because this bug is specific to condition when bootable\u003d1 is passed.\nIf passing bootable\u003d1 works in your environment then this bug should marked invalid.\n\n\u003eCaught error: (ProgrammingError) operator does not exist: boolean \u003d integer\n\u003eLINE 3: ...volumes.status \u003d \u0027available\u0027 AND volumes.bootable \u003d 1 AND vo...\n\nAs per my knowledge, both 1 as well as True should work for tinyint because tinyint is compatible with both 1 as well as True.\n\nThough I cant confirm but problem seems due to some environment issue.\nCould you please check again?","commit_id":"8f360ae3f6371aaca64ee0f49dd5333cdcc6e768"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"f8c8ab96df82297da37e4ac4b821654f96602de5","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                available \u003d api.cinder.VOLUME_STATE_AVAILABLE"},{"line_number":472,"context_line":"                volumes \u003d [self._get_volume_display_name(v)"},{"line_number":473,"context_line":"                           for v in cinder.volume_list(self.request,"},{"line_number":474,"context_line":"                           search_opts\u003ddict(status\u003davailable, bootable\u003d\u0027true\u0027))]"},{"line_number":475,"context_line":"        except Exception:"},{"line_number":476,"context_line":"            exceptions.handle(self.request,"},{"line_number":477,"context_line":"                              _(\u0027Unable to retrieve list of volumes.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_f4209ef9","line":474,"range":{"start_line":474,"start_character":62,"end_line":474,"end_character":70},"in_reply_to":"fa69d971_b302513d","updated":"2015-12-31 06:00:03.000000000","message":"Test it in my local Mysql env:\n\nuse cinder;\ndesc volumes;\n | bootable            | tinyint(1)   |\n\n\nonly \" bootable\u003d1 \" worked, both \" bootable\u003d\u0027true\u0027 \" and \" bootable\u003dTrue \" failed","commit_id":"8f360ae3f6371aaca64ee0f49dd5333cdcc6e768"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"f4129080cdcdb03bafb374478c866e840f051442","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                available \u003d api.cinder.VOLUME_STATE_AVAILABLE"},{"line_number":472,"context_line":"                volumes \u003d [self._get_volume_display_name(v)"},{"line_number":473,"context_line":"                           for v in cinder.volume_list(self.request,"},{"line_number":474,"context_line":"                           search_opts\u003ddict(status\u003davailable, bootable\u003d\u0027true\u0027))]"},{"line_number":475,"context_line":"        except Exception:"},{"line_number":476,"context_line":"            exceptions.handle(self.request,"},{"line_number":477,"context_line":"                              _(\u0027Unable to retrieve list of volumes.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_745a6e85","line":474,"range":{"start_line":474,"start_character":62,"end_line":474,"end_character":70},"in_reply_to":"fa69d971_f4209ef9","updated":"2015-12-31 06:01:45.000000000","message":"failed means could not get bootable volumes","commit_id":"8f360ae3f6371aaca64ee0f49dd5333cdcc6e768"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"9f76269f188bca94c65a80666a9e6056b774d8db","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                available \u003d api.cinder.VOLUME_STATE_AVAILABLE"},{"line_number":472,"context_line":"                volumes \u003d [self._get_volume_display_name(v)"},{"line_number":473,"context_line":"                           for v in cinder.volume_list(self.request,"},{"line_number":474,"context_line":"                           search_opts\u003ddict(status\u003davailable, bootable\u003d\u0027true\u0027))]"},{"line_number":475,"context_line":"        except Exception:"},{"line_number":476,"context_line":"            exceptions.handle(self.request,"},{"line_number":477,"context_line":"                              _(\u0027Unable to retrieve list of volumes.\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_d1b52431","line":474,"range":{"start_line":474,"start_character":51,"end_line":474,"end_character":60},"in_reply_to":"fa69d971_f68a9ebe","updated":"2016-01-04 18:15:21.000000000","message":"just minor update,\n\nThis bug is raised for PostgreSQL(PostgreSQL has issues in implicit casting in boolean and integer, so raising issue when using bootable\u003d1).\n\nBut your environment is MySQL, that is why you are not getting error in bootable\u003d1 as mysql does not require explicit conversion among boolean and integer.","commit_id":"8f360ae3f6371aaca64ee0f49dd5333cdcc6e768"},{"author":{"_account_id":16308,"name":"Sheel Rana","email":"ranasheel2000@gmail.com","username":"sheel.rana"},"change_message_id":"b5974a3e83a2714f8389b0748181adc2be5b7d73","unresolved":false,"context_lines":[{"line_number":471,"context_line":"                available \u003d api.cinder.VOLUME_STATE_AVAILABLE"},{"line_number":472,"context_line":"                volumes \u003d [self._get_volume_display_name(v)"},{"line_number":473,"context_line":"                           for v in cinder.volume_list(self.request,"},{"line_number":474,"context_line":"                           search_opts\u003ddict(status\u003davailable, bootable\u003d\u0027true\u0027))]"},{"line_number":475,"context_line":"        except Exception:"},{"line_number":476,"context_line":"            exceptions.handle(self.request,"},{"line_number":477,"context_line":"                              _(\u0027Unable to retrieve list of volumes.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa69d971_e21b9871","line":474,"updated":"2016-01-05 10:40:55.000000000","message":"For gate-horizon-pep8:\nwrap this line within permissible character limits.","commit_id":"2a36cadfdec94d6906e3a64c52630db0ff8248c8"}]}
