)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"6773a1fb60d95b6e08ef37035842d6c19efcadd9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\"Update default quota\" execute two apis"},{"line_number":10,"context_line":"(nova.default_quota_update and cinder.default_quota_update)."},{"line_number":11,"context_line":"At the moment, method of \"handle\" always retuen True,"},{"line_number":12,"context_line":"even if both of their apis failed. Then success message is"},{"line_number":13,"context_line":"displayed in spite of failure. I modifyed it. If both API"},{"line_number":14,"context_line":"was an error, it returns False. And in this case, Horizon"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_c9d3ee5e","line":11,"updated":"2015-11-19 17:49:34.000000000","message":"spelling: \"retuen\" --\u003e \"returns\"","commit_id":"09d2a21affc9b0b9722b64b3392d0dfc22b2cbd0"}],"openstack_dashboard/dashboards/admin/defaults/workflows.py":[{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"f2695740ae3aeeb1b440d58c74ed8ae350a1379b","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            self.success_message \u003d _(\u0027Default quotas updated for Nova.\u0027)"},{"line_number":123,"context_line":"            exceptions.handle(request,"},{"line_number":124,"context_line":"                              _(\u0027Unable to update default quotas for Cinder.\u0027))"},{"line_number":125,"context_line":"        elif is_error_nova and is_error_cinder:"},{"line_number":126,"context_line":"            return False"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_813fcfb2","line":125,"updated":"2015-11-20 08:44:06.000000000","message":"exceptions.handle(request,\n                              _(\u0027Unable to update default quotas .\u0027))\nnice to see the exception here.","commit_id":"1af003a4833ff022f24b099a9892c80a34f325e3"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"93fc8a78fd5d94a1d95c3e8574902bd8a69f8024","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            self.success_message \u003d _(\u0027Default quotas updated for Nova.\u0027)"},{"line_number":123,"context_line":"            exceptions.handle(request,"},{"line_number":124,"context_line":"                              _(\u0027Unable to update default quotas for Cinder.\u0027))"},{"line_number":125,"context_line":"        elif is_error_nova and is_error_cinder:"},{"line_number":126,"context_line":"            return False"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_c13cf7e2","line":125,"in_reply_to":"ba8a016a_813fcfb2","updated":"2015-11-20 09:03:43.000000000","message":"In this case, this method return False. \nThen failure_message is displayed.\n\nSo I thought it doesn\u0027t need to write below code.\n\n \"exceptions.handle(request,_(\u0027Unable to update default quotas .\u0027))\nnice to see the exception here.\"","commit_id":"1af003a4833ff022f24b099a9892c80a34f325e3"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"f6fa55eefbbe35925c7ac9948432e9bdacb6130b","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                                    quotas.CINDER_QUOTA_FIELDS])"},{"line_number":108,"context_line":"                cinder.default_quota_update(request, **cinder_data)"},{"line_number":109,"context_line":"            else:"},{"line_number":110,"context_line":"                messages.warning(request,"},{"line_number":111,"context_line":"                                 _(\u0027Unable to update Cinder default quotas\u0027"},{"line_number":112,"context_line":"                                   \u0027 because the Cinder volume service is\u0027"},{"line_number":113,"context_line":"                                   \u0027 disabled.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_5247f476","line":110,"updated":"2015-12-07 13:19:43.000000000","message":"I don\u0027t think this should log as warning.  \n\nIf the operator don\u0027t use cinder, they\u0027ll keep on seeing this warning message.","commit_id":"04544a597fda9a8133d362781368b3ff2825391b"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"3588c01d463cc73a825ef5bafd6b6aebe2ee96ed","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                                    quotas.CINDER_QUOTA_FIELDS])"},{"line_number":108,"context_line":"                cinder.default_quota_update(request, **cinder_data)"},{"line_number":109,"context_line":"            else:"},{"line_number":110,"context_line":"                messages.warning(request,"},{"line_number":111,"context_line":"                                 _(\u0027Unable to update Cinder default quotas\u0027"},{"line_number":112,"context_line":"                                   \u0027 because the Cinder volume service is\u0027"},{"line_number":113,"context_line":"                                   \u0027 disabled.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_f9401936","line":110,"in_reply_to":"7a740942_4d7f5566","updated":"2015-12-08 07:24:32.000000000","message":"I changed it to output log as debug level.","commit_id":"04544a597fda9a8133d362781368b3ff2825391b"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"8d2a0013df9aa06d41580d8915a50506209f0922","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                                    quotas.CINDER_QUOTA_FIELDS])"},{"line_number":108,"context_line":"                cinder.default_quota_update(request, **cinder_data)"},{"line_number":109,"context_line":"            else:"},{"line_number":110,"context_line":"                messages.warning(request,"},{"line_number":111,"context_line":"                                 _(\u0027Unable to update Cinder default quotas\u0027"},{"line_number":112,"context_line":"                                   \u0027 because the Cinder volume service is\u0027"},{"line_number":113,"context_line":"                                   \u0027 disabled.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_4d7f5566","line":110,"in_reply_to":"7a740942_5247f476","updated":"2015-12-07 13:22:46.000000000","message":"Good catch by Lin. I actually did a patch to remove something like this because an operator opened a bug claiming that he keep getting the logs spammed with warnings like this one.\n\nShould probably be moved to a debug instead?","commit_id":"04544a597fda9a8133d362781368b3ff2825391b"}]}
