)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"0a1362d0ef498b7df7b0c47224db083deea07512","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I0b6c0a8faff5ae32339c41ec95258b5ac3da5148"},{"line_number":14,"context_line":"Closes-Bug: 1481425"},{"line_number":15,"context_line":"Signed-off-by: Itxaka \u003ciserrano@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba8a016a_06e3f5d9","line":15,"updated":"2015-11-20 08:32:51.000000000","message":"do we need this line?","commit_id":"f4aa1ce74ba5e22f1e486d6e409770f3266f65ab"}],"openstack_dashboard/dashboards/admin/flavors/tables.py":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"a4108525a7a0748efbce4dc9ee6d1ad36af5c84c","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    swap \u003d tables.Column(get_swap_size,"},{"line_number":152,"context_line":"                         verbose_name\u003d_(\u0027Swap Disk\u0027),"},{"line_number":153,"context_line":"                         attrs\u003d{\u0027data-type\u0027: \u0027size\u0027})"},{"line_number":154,"context_line":"    rxtx_factor \u003d tables.Column(\u0027rxtx_factor\u0027, verbose_name\u003d\"RX/TX factor\")"},{"line_number":155,"context_line":"    flavor_id \u003d tables.Column(\u0027id\u0027, verbose_name\u003d_(\u0027ID\u0027))"},{"line_number":156,"context_line":"    public \u003d tables.Column(\"is_public\","},{"line_number":157,"context_line":"                           verbose_name\u003d_(\"Public\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_ed2ed441","line":154,"updated":"2015-11-20 06:48:31.000000000","message":"Nit: verbose_name should be translatable.","commit_id":"97c2abb4db08e45aa66f63312c6095563ce9c3a5"}],"openstack_dashboard/dashboards/admin/flavors/tests.py":[{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"0a1362d0ef498b7df7b0c47224db083deea07512","unresolved":false,"context_lines":[{"line_number":810,"context_line":""},{"line_number":811,"context_line":"    def test_update_flavor_invalid_rxtx_factor_fails(self):"},{"line_number":812,"context_line":"        error \u003d \u0027Ensure this value is greater than or equal to 1.\u0027"},{"line_number":813,"context_line":"        data \u003d {\u0027rxtx_factor\u0027: -1}"},{"line_number":814,"context_line":"        self.generic_update_flavor_invalid_data_form_fails(override_data\u003ddata,"},{"line_number":815,"context_line":"                                                           error_msg\u003derror)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_46433daf","line":813,"updated":"2015-11-20 08:32:51.000000000","message":"See error message, i thought data should be \"{\u0027rxtx_factor\u0027: 0}\"","commit_id":"f4aa1ce74ba5e22f1e486d6e409770f3266f65ab"}],"openstack_dashboard/dashboards/admin/flavors/workflows.py":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"a4108525a7a0748efbce4dc9ee6d1ad36af5c84c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                                 required\u003dFalse,"},{"line_number":58,"context_line":"                                 initial\u003d0,"},{"line_number":59,"context_line":"                                 min_value\u003d0)"},{"line_number":60,"context_line":"    rxtx_factor \u003d forms.FloatField(label\u003d\"RX/TX Factor\","},{"line_number":61,"context_line":"                                   required\u003dFalse,"},{"line_number":62,"context_line":"                                   initial\u003d1,"},{"line_number":63,"context_line":"                                   min_value\u003d1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_6deae4dc","line":60,"updated":"2015-11-20 06:48:31.000000000","message":"Nit: label should be translatable.","commit_id":"97c2abb4db08e45aa66f63312c6095563ce9c3a5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6964d8c7a84df9acd653231734747cb9f79dceb6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                                 min_value\u003d0)"},{"line_number":60,"context_line":"    rxtx_factor \u003d forms.FloatField(label\u003d_(\"RX/TX Factor\"),"},{"line_number":61,"context_line":"                                   required\u003dFalse,"},{"line_number":62,"context_line":"                                   initial\u003d1.0,"},{"line_number":63,"context_line":"                                   min_value\u003d1)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    class Meta(object):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a57f1b5_fb11da04","line":62,"range":{"start_line":62,"start_character":43,"end_line":62,"end_character":46},"updated":"2016-02-12 17:03:18.000000000","message":"what is the difference between 1.0 and 1 in this case?\nIn other places, we use \u00271\u0027. If there is no specific reason it is better to use \u00271\u0027 instead of \u00271.0\u0027.","commit_id":"a867fb66189a2e595c09aca794c7c4274861d44b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"00efc945b20bbd36ce1253092bdea6e7b093df4e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                                 min_value\u003d0)"},{"line_number":60,"context_line":"    rxtx_factor \u003d forms.FloatField(label\u003d_(\"RX/TX Factor\"),"},{"line_number":61,"context_line":"                                   required\u003dFalse,"},{"line_number":62,"context_line":"                                   initial\u003d1.0,"},{"line_number":63,"context_line":"                                   min_value\u003d1)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    class Meta(object):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a57f1b5_62dc5a46","line":62,"in_reply_to":"3a57f1b5_dbe5fea3","updated":"2016-02-12 18:14:28.000000000","message":"When other developers or reviewers touch this code later, do you think they can easily know they should use 1.0 or 1? I think unnecessary inconsistency will raise unnecessary question.\n\nOn the other hand, I agree that this can be fixed later. In rx/tx factor, it is natural to use float. Do you agree that I will send a follow-up patch to replace related \"1\" with \"1.0\"?","commit_id":"a867fb66189a2e595c09aca794c7c4274861d44b"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"9eaa677108c3f367c52d08eb7dacc43fbe0a3ae1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                                 min_value\u003d0)"},{"line_number":60,"context_line":"    rxtx_factor \u003d forms.FloatField(label\u003d_(\"RX/TX Factor\"),"},{"line_number":61,"context_line":"                                   required\u003dFalse,"},{"line_number":62,"context_line":"                                   initial\u003d1.0,"},{"line_number":63,"context_line":"                                   min_value\u003d1)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    class Meta(object):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a57f1b5_dbe5fea3","line":62,"in_reply_to":"3a57f1b5_fb11da04","updated":"2016-02-12 17:11:55.000000000","message":"Because its a float and having 1.0 makes it very clear that its a float field?\n\nI dont care either way but 1.0 \u003d\u003d 1 so not sure why would one be better than the other except that 1.0 makes a note of the type?\n\nI can change it, but I dont really see how this can be a nit :)","commit_id":"a867fb66189a2e595c09aca794c7c4274861d44b"}]}