)]}'
{"openstack_dashboard/dashboards/project/access_and_security/keypairs/views.py":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"0fd0bbb09f601546c9e076aba3fcc7d5f3172efd","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class GenerateView(View):"},{"line_number":109,"context_line":"    # TODO(Itxaka): Remove cache_control in django \u003e\u003d 1.9"},{"line_number":110,"context_line":"    # https://code.djangoproject.com/ticket/13008"},{"line_number":111,"context_line":"    @method_decorator(cache_control(max_age\u003d0, no_cache\u003dTrue,"},{"line_number":112,"context_line":"                                    no_store\u003dTrue, must_revalidate\u003dTrue))"},{"line_number":113,"context_line":"    @method_decorator(never_cache)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_5f6f1392","line":110,"updated":"2016-02-11 09:26:43.000000000","message":"since we\u0027re moving to django-1.9 quickly, you shouldn\u0027t probably propose already outdated code.","commit_id":"2db307e956bc668175ad225fabbdb1356a738ab6"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"cb9e9ba3ffdc24353321eb9f61e4263d13a02835","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class GenerateView(View):"},{"line_number":109,"context_line":"    # TODO(Itxaka): Remove cache_control in django \u003e\u003d 1.9"},{"line_number":110,"context_line":"    # https://code.djangoproject.com/ticket/13008"},{"line_number":111,"context_line":"    @method_decorator(cache_control(max_age\u003d0, no_cache\u003dTrue,"},{"line_number":112,"context_line":"                                    no_store\u003dTrue, must_revalidate\u003dTrue))"},{"line_number":113,"context_line":"    @method_decorator(never_cache)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_7f276f64","line":110,"in_reply_to":"3a57f1b5_5f6f1392","updated":"2016-02-11 09:31:07.000000000","message":"Until we move to it, this needs to be there or else this view is useless because the never_cache does not work.\n\nIt doesnt hurt on 1.9 and its a must on 1.8, so until I we move to django\u003e\u003d1.9 this has to be here.","commit_id":"2db307e956bc668175ad225fabbdb1356a738ab6"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/network/network.controller.js":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"a1be4747eac9bd5b037c2f2230396e882582e62e","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    ctrl.tooltipModel \u003d tooltipService;"},{"line_number":64,"context_line":"  }"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":2,"id":"7a740942_977ca3b6","line":65,"updated":"2015-12-10 14:48:37.000000000","message":"It\u0027s unrelated","commit_id":"29c19be68324266428f001176c40f309e649e8ea"}],"openstack_dashboard/dashboards/project/volumes/templates/volumes/volumes/_show_transfer.html":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"7d3ba241c610671ebec87e50311cccb0ecdc13ba","unresolved":false,"context_lines":[{"line_number":9,"context_line":"{% block modal-footer %}"},{"line_number":10,"context_line":"    \u003ca href\u003d\"{{ download_url }}\""},{"line_number":11,"context_line":"        class\u003d\"btn btn-default\"\u003e"},{"line_number":12,"context_line":"    \u003cspan class\u003d\"fa fa-download\"\u003e\u003c/span\u003e"},{"line_number":13,"context_line":"        {{ download_label }}"},{"line_number":14,"context_line":"    \u003c/a\u003e"},{"line_number":15,"context_line":"    \u003ca href\u003d\"{% block cancel_url %}{{ cancel_url }}{% endblock %}\""}],"source_content_type":"text/html","patch_set":8,"id":"3a57f1b5_98948943","line":12,"updated":"2016-02-12 08:17:08.000000000","message":"very nit: some spaces is needed before span tag.\n\n    \u003ca href\u003d\"{{ download_url }}\"\n        class\u003d\"btn btn-default\"\u003e\n      \u003cspan class\u003d\"fa fa-download\"\u003e\u003c/span\u003e\n        {{ download_label }}\n    \u003c/a\u003e","commit_id":"2db307e956bc668175ad225fabbdb1356a738ab6"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"e2322d99770b798f22bb8ddbbacc3ea451e5c4d3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"{% block modal-footer %}"},{"line_number":10,"context_line":"    \u003ca href\u003d\"{{ download_url }}\""},{"line_number":11,"context_line":"        class\u003d\"btn btn-default\"\u003e"},{"line_number":12,"context_line":"    \u003cspan class\u003d\"fa fa-download\"\u003e\u003c/span\u003e"},{"line_number":13,"context_line":"        {{ download_label }}"},{"line_number":14,"context_line":"    \u003c/a\u003e"},{"line_number":15,"context_line":"    \u003ca href\u003d\"{% block cancel_url %}{{ cancel_url }}{% endblock %}\""}],"source_content_type":"text/html","patch_set":8,"id":"3a57f1b5_9e53116b","line":12,"in_reply_to":"3a57f1b5_98948943","updated":"2016-02-12 09:11:47.000000000","message":"Done","commit_id":"2db307e956bc668175ad225fabbdb1356a738ab6"}],"openstack_dashboard/dashboards/project/volumes/volumes/views.py":[{"author":{"_account_id":12114,"name":"Kent Wang","email":"kent.wang@intel.com","username":"k.wang"},"change_message_id":"f46487a9de0a8b5c238c8d9abbabed7ce02fa7f6","unresolved":false,"context_lines":[{"line_number":529,"context_line":"class DownloadTransferCreds(generic.View):"},{"line_number":530,"context_line":"    @method_decorator(cache_control(max_age\u003d0, no_cache\u003dTrue,"},{"line_number":531,"context_line":"                                    no_store\u003dTrue, must_revalidate\u003dTrue))"},{"line_number":532,"context_line":"    @method_decorator(never_cache)"},{"line_number":533,"context_line":"    def get(self, request, transfer_id, auth_key):"},{"line_number":534,"context_line":"        try:"},{"line_number":535,"context_line":"            transfer \u003d cinder.transfer_get(self.request, transfer_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_0839ad41","line":532,"updated":"2015-11-20 15:46:02.000000000","message":"Is having both of these decorators needed?","commit_id":"9bdcceda986c3e6d23b9698ea44bc62f111076b0"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"e380348e225f91476d83940171c7adec947f1cd8","unresolved":false,"context_lines":[{"line_number":529,"context_line":"class DownloadTransferCreds(generic.View):"},{"line_number":530,"context_line":"    @method_decorator(cache_control(max_age\u003d0, no_cache\u003dTrue,"},{"line_number":531,"context_line":"                                    no_store\u003dTrue, must_revalidate\u003dTrue))"},{"line_number":532,"context_line":"    @method_decorator(never_cache)"},{"line_number":533,"context_line":"    def get(self, request, transfer_id, auth_key):"},{"line_number":534,"context_line":"        try:"},{"line_number":535,"context_line":"            transfer \u003d cinder.transfer_get(self.request, transfer_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_4b932f50","line":532,"in_reply_to":"ba8a016a_0839ad41","updated":"2015-11-20 16:06:12.000000000","message":"Comes from here https://review.openstack.org/#/c/189904/\nSeems that until Django 1.9, never_cache does not work by itself so thats the reasoning of using both.\n\nSeems that we do the same on keypair download: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/access_and_security/keypairs/views.py#L109-L111","commit_id":"9bdcceda986c3e6d23b9698ea44bc62f111076b0"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"e3871850cdd31c02be24f369d6032377dc194ad3","unresolved":false,"context_lines":[{"line_number":529,"context_line":"class DownloadTransferCreds(generic.View):"},{"line_number":530,"context_line":"    @method_decorator(cache_control(max_age\u003d0, no_cache\u003dTrue,"},{"line_number":531,"context_line":"                                    no_store\u003dTrue, must_revalidate\u003dTrue))"},{"line_number":532,"context_line":"    @method_decorator(never_cache)"},{"line_number":533,"context_line":"    def get(self, request, transfer_id, auth_key):"},{"line_number":534,"context_line":"        try:"},{"line_number":535,"context_line":"            transfer \u003d cinder.transfer_get(self.request, transfer_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_1029a137","line":532,"in_reply_to":"ba8a016a_4b932f50","updated":"2015-12-10 13:30:12.000000000","message":"Can you leave a comment referencing the removal? Something like TODO remove in django \u003e\u003d 1.9.","commit_id":"9bdcceda986c3e6d23b9698ea44bc62f111076b0"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"0fd0bbb09f601546c9e076aba3fcc7d5f3172efd","unresolved":false,"context_lines":[{"line_number":529,"context_line":""},{"line_number":530,"context_line":"class DownloadTransferCreds(generic.View):"},{"line_number":531,"context_line":"    # TODO(Itxaka): Remove cache_control in django \u003e\u003d 1.9"},{"line_number":532,"context_line":"    # https://code.djangoproject.com/ticket/13008"},{"line_number":533,"context_line":"    @method_decorator(cache_control(max_age\u003d0, no_cache\u003dTrue,"},{"line_number":534,"context_line":"                                    no_store\u003dTrue, must_revalidate\u003dTrue))"},{"line_number":535,"context_line":"    @method_decorator(never_cache)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_3f749766","line":532,"updated":"2016-02-11 09:26:43.000000000","message":"same here. it\u0027s somehow already outdated, no?","commit_id":"2db307e956bc668175ad225fabbdb1356a738ab6"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"cb9e9ba3ffdc24353321eb9f61e4263d13a02835","unresolved":false,"context_lines":[{"line_number":529,"context_line":""},{"line_number":530,"context_line":"class DownloadTransferCreds(generic.View):"},{"line_number":531,"context_line":"    # TODO(Itxaka): Remove cache_control in django \u003e\u003d 1.9"},{"line_number":532,"context_line":"    # https://code.djangoproject.com/ticket/13008"},{"line_number":533,"context_line":"    @method_decorator(cache_control(max_age\u003d0, no_cache\u003dTrue,"},{"line_number":534,"context_line":"                                    no_store\u003dTrue, must_revalidate\u003dTrue))"},{"line_number":535,"context_line":"    @method_decorator(never_cache)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a57f1b5_5f1dd30d","line":532,"in_reply_to":"3a57f1b5_3f749766","updated":"2016-02-11 09:31:07.000000000","message":"Until we move to it, this needs to be there or else this view is useless because the never_cache does not work.\n\nIt doesnt hurt on 1.9 and its a must on 1.8, so until I we move to django\u003e\u003d1.9 this has to be here.","commit_id":"2db307e956bc668175ad225fabbdb1356a738ab6"}]}
