)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"03c116edb629db86c007e026521f1e477d0cf488","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VPN forms help text could be improved"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The help text (both tooltips, and descriptive text on the right hand side) for VPN forms (Create, Ed"},{"line_number":10,"context_line":"it etc.) is very sparse, and we should update it with more information from the VPN docs or API docs"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic8dcbf1395f8756e33970577369113bd6571d97e"},{"line_number":13,"context_line":"Closes-Bug: #1516603"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba8a016a_c46d89cd","line":10,"updated":"2015-11-23 15:01:24.000000000","message":"The 2 lines above should be \u003c 72 characters long...\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"d688942ef69ce6a714a0dff63d7df872ea6591a2"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"40c5df5b57f9f55364c6ce29090bd246a1814f0a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VPN forms help text could be improved"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The help text for VPN forms is very sparse."},{"line_number":10,"context_line":"We should update it with more information from the VPN docs"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic8dcbf1395f8756e33970577369113bd6571d97e"},{"line_number":13,"context_line":"Closes-Bug: #1516603"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba8a016a_aca84a78","line":10,"updated":"2015-11-24 06:33:43.000000000","message":"nit:fullstop at the end of statement missing","commit_id":"dd560fd4f28259ca10b42e23f35d53a102eb561e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"06c4a26b87c669a1a1089656c86c3a3ff96029c0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"VPN forms help text could be improved"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The help text for VPN forms is very sparse."},{"line_number":10,"context_line":"We should update it with more information from the VPN docs"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic8dcbf1395f8756e33970577369113bd6571d97e"},{"line_number":13,"context_line":"Closes-Bug: #1516603"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"9a8ffd7b_db8c6d81","line":10,"updated":"2015-11-26 03:25:08.000000000","message":"Nit : Full stop at the end of the Statement","commit_id":"299e370e89548173c53667890a4d4143e1de9057"}],"openstack_dashboard/dashboards/project/vpn/workflows.py":[{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"ecb294deec97db93fdcb59f60a9133bef4529429","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    admin_state_up \u003d forms.ChoiceField(choices\u003d[(True, _(\u0027UP\u0027)),"},{"line_number":32,"context_line":"                                                (False, _(\u0027DOWN\u0027))],"},{"line_number":33,"context_line":"                                       label\u003d_(\"Admin State\"),"},{"line_number":34,"context_line":"                                       help_text\u003d_(\"Administrative state of vpnservice. If DOWN, port does not forward packets.\"),"},{"line_number":35,"context_line":"                                       required\u003dFalse)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __init__(self, request, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_8fe24e2e","line":34,"updated":"2015-11-23 10:18:57.000000000","message":"Please replace \"vpnservice\" with \"VPN service\".","commit_id":"d688942ef69ce6a714a0dff63d7df872ea6591a2"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"1419115b5634bf54389953e1dcf228aff84d5e99","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    admin_state_up \u003d forms.ChoiceField(choices\u003d[(True, _(\u0027UP\u0027)),"},{"line_number":32,"context_line":"                                                (False, _(\u0027DOWN\u0027))],"},{"line_number":33,"context_line":"                                       label\u003d_(\"Admin State\"),"},{"line_number":34,"context_line":"                                       help_text\u003d_(\"Administrative state of vpnservice. If DOWN, port does not forward packets.\"),"},{"line_number":35,"context_line":"                                       required\u003dFalse)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def __init__(self, request, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_1d49add0","line":34,"in_reply_to":"ba8a016a_8fe24e2e","updated":"2015-11-23 13:11:15.000000000","message":"please see openstack hacking rules","commit_id":"d688942ef69ce6a714a0dff63d7df872ea6591a2"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"ecb294deec97db93fdcb59f60a9133bef4529429","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        name \u003d _(\"Add New VPN Service\")"},{"line_number":71,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":72,"context_line":"        help_text \u003d _(\"Create VPN Service for current project.\\n\\n\""},{"line_number":73,"context_line":"                      \"The service defines where to run the VPNaaS services.\"   73"},{"line_number":74,"context_line":"                      \"They are attached to a router and reference a single sub-network to push to the remote site.\\n\""},{"line_number":75,"context_line":"                      \"Specify a name, description, router, and subnet \""},{"line_number":76,"context_line":"                      \"for the VPN Service. \""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_6f55aac4","line":73,"updated":"2015-11-23 10:18:57.000000000","message":"Should be \"VPN services\". Please also remove line number.","commit_id":"d688942ef69ce6a714a0dff63d7df872ea6591a2"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"ecb294deec97db93fdcb59f60a9133bef4529429","unresolved":false,"context_lines":[{"line_number":435,"context_line":"                                                (False, _(\u0027DOWN\u0027))],"},{"line_number":436,"context_line":"                                       label\u003d_(\"Admin State\"),"},{"line_number":437,"context_line":"                                       required\u003dFalse,"},{"line_number":438,"context_line":"                                       help_text\u003d_(\"Administrative state of vpnservice. If DOWN, port does not forward packets.\"))"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":441,"context_line":"        super(AddIPSecSiteConnectionOptionalAction, self).__init__("}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_afc4f291","line":438,"updated":"2015-11-23 10:18:57.000000000","message":"ditto","commit_id":"d688942ef69ce6a714a0dff63d7df872ea6591a2"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"40c5df5b57f9f55364c6ce29090bd246a1814f0a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                                                (False, _(\u0027DOWN\u0027))],"},{"line_number":33,"context_line":"                                       label\u003d_(\"Admin State\"),"},{"line_number":34,"context_line":"                                       help_text\u003d_(\"Administrative state of VPN services. \""},{"line_number":35,"context_line":"                                                   \"If DOWN, port does not forward packets.\"),"},{"line_number":36,"context_line":"                                       required\u003dFalse)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self, request, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_0ce716e5","line":35,"updated":"2015-11-24 06:33:43.000000000","message":"DOWN is all CAPs here and Up is Camel-cased in Line#79.\nTry to keep them same.","commit_id":"dd560fd4f28259ca10b42e23f35d53a102eb561e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"40c5df5b57f9f55364c6ce29090bd246a1814f0a","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                      \"used in the IKE Policy.\u003c/li\u003e\""},{"line_number":182,"context_line":"                      \"\u003cli\u003eIKE version: The type of version (v1/v2) \""},{"line_number":183,"context_line":"                      \"that needs to be filtered.\u003c/li\u003e\""},{"line_number":184,"context_line":"                      \"\u003cli\u003eLifetime: String with lifetime specific parameters.\u003c/li\u003e\\n\""},{"line_number":185,"context_line":"                      \"A name and description are optional, \""},{"line_number":186,"context_line":"                      \"all others are required.\""},{"line_number":187,"context_line":"                      )"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_6c634242","line":184,"updated":"2015-11-24 06:33:43.000000000","message":"Is there a specific value/range for Lifetime ( similar to the one given in Line #131). If so, please mention the same","commit_id":"dd560fd4f28259ca10b42e23f35d53a102eb561e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"40c5df5b57f9f55364c6ce29090bd246a1814f0a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                      \"\u003cli\u003eIKE version: The type of version (v1/v2) \""},{"line_number":183,"context_line":"                      \"that needs to be filtered.\u003c/li\u003e\""},{"line_number":184,"context_line":"                      \"\u003cli\u003eLifetime: String with lifetime specific parameters.\u003c/li\u003e\\n\""},{"line_number":185,"context_line":"                      \"A name and description are optional, \""},{"line_number":186,"context_line":"                      \"all others are required.\""},{"line_number":187,"context_line":"                      )"},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_2c01ba6a","line":185,"updated":"2015-11-24 06:33:43.000000000","message":"A name -\u003e Name","commit_id":"dd560fd4f28259ca10b42e23f35d53a102eb561e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"40c5df5b57f9f55364c6ce29090bd246a1814f0a","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                      \"\u003cli\u003eIKE version: \""},{"line_number":296,"context_line":"                      \"The type of version (v1/v2) that needs to be filtered.\u003c/li\u003e\""},{"line_number":297,"context_line":"                      \"\u003cli\u003eLifetime: String with lifetime specific parameters.\u003c/li\u003e\\n\""},{"line_number":298,"context_line":"                      \"A name and description are optional, \""},{"line_number":299,"context_line":"                      \"all others are required.\""},{"line_number":300,"context_line":"                      )"},{"line_number":301,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_4c2bdeeb","line":298,"updated":"2015-11-24 06:33:43.000000000","message":"Ditto","commit_id":"dd560fd4f28259ca10b42e23f35d53a102eb561e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"40c5df5b57f9f55364c6ce29090bd246a1814f0a","unresolved":false,"context_lines":[{"line_number":458,"context_line":"                                       label\u003d_(\"Admin State\"),"},{"line_number":459,"context_line":"                                       required\u003dFalse,"},{"line_number":460,"context_line":"                                       help_text\u003d_(\"Administrative state of VPN services. \""},{"line_number":461,"context_line":"                                                   \"If DOWN, port does not forward packets.\"))"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":464,"context_line":"        super(AddIPSecSiteConnectionOptionalAction, self).__init__("}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_0c35d644","line":461,"updated":"2015-11-24 06:33:43.000000000","message":"Same as the first comment","commit_id":"dd560fd4f28259ca10b42e23f35d53a102eb561e"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"40df00532ea403b22763153414729ad7049392ca","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        name \u003d _(\"Add New VPN Service\")"},{"line_number":72,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":73,"context_line":"        help_text \u003d _(\"Create VPN Service for current project.\\n\\n\""},{"line_number":74,"context_line":"                      \"The service defines where to run the VPN service.\""},{"line_number":75,"context_line":"                      \"They are attached to a router \""},{"line_number":76,"context_line":"                      \"and reference a single sub-network to push to the remote site.\\n\""},{"line_number":77,"context_line":"                      \"Specify a name, description, router, and subnet \""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba8a016a_890bf1d5","line":74,"updated":"2015-11-24 09:00:16.000000000","message":"Whitespace at the end of this line is missing.","commit_id":"66012d0959aa0a756f119959819f6ed22c830eb8"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"45e15e908c6a32700acdd6d4ee848dc0872c0851","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        max_length\u003d80, label\u003d_(\"Description\"))"},{"line_number":29,"context_line":"    router_id \u003d forms.ChoiceField(label\u003d_(\"Router\"))"},{"line_number":30,"context_line":"    subnet_id \u003d forms.ChoiceField(label\u003d_(\"Subnet\"))"},{"line_number":31,"context_line":"    admin_state_up \u003d forms.ChoiceField(choices\u003d[(True, _(\u0027UP\u0027)),"},{"line_number":32,"context_line":"                                                (False, _(\u0027DOWN\u0027))],"},{"line_number":33,"context_line":"                                       label\u003d_(\"Admin State\"),"},{"line_number":34,"context_line":"                                       help_text\u003d_(\"Administrative state \""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba8a016a_6f19ed87","line":31,"updated":"2015-11-24 09:56:44.000000000","message":"You can use the following alignment to make this more readable:\n\nadmin_state_up \u003d forms.ChoiceField(\n    choices\u003d[(True, _(\u0027UP\u0027)), (False, _(\u0027DOWN\u0027))],\n    label\u003d_(\"Admin State\"),\n...","commit_id":"b5e0518d11769b0d6951f718224a1ed2954708cf"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"45e15e908c6a32700acdd6d4ee848dc0872c0851","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        name \u003d _(\"Add New VPN Service\")"},{"line_number":74,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":75,"context_line":"        help_text \u003d _(\"Create VPN Service for current project.\\n\\n\""},{"line_number":76,"context_line":"                      \"The service defines where to run the VPN service.\""},{"line_number":77,"context_line":"                      \"They are attached to a router \""},{"line_number":78,"context_line":"                      \"and reference a single sub-network \""},{"line_number":79,"context_line":"                      \"to push to the remote site.\\n\""}],"source_content_type":"text/x-python","patch_set":10,"id":"ba8a016a_4f46697c","line":76,"updated":"2015-11-24 09:56:44.000000000","message":"Still no whitespace at the end of this line.","commit_id":"b5e0518d11769b0d6951f718224a1ed2954708cf"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"45e15e908c6a32700acdd6d4ee848dc0872c0851","unresolved":false,"context_lines":[{"line_number":464,"context_line":"        required\u003dFalse,"},{"line_number":465,"context_line":"        help_text\u003d_(\"Valid integer greater than the DPD interval\"))"},{"line_number":466,"context_line":"    initiator \u003d forms.ChoiceField(label\u003d_(\"Initiator state\"), required\u003dFalse)"},{"line_number":467,"context_line":"    admin_state_up \u003d forms.ChoiceField(choices\u003d[(True, _(\u0027UP\u0027)),"},{"line_number":468,"context_line":"                                                (False, _(\u0027DOWN\u0027))],"},{"line_number":469,"context_line":"                                       label\u003d_(\"Admin State\"),"},{"line_number":470,"context_line":"                                       required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba8a016a_0f0b812b","line":467,"updated":"2015-11-24 09:56:44.000000000","message":"ditto","commit_id":"b5e0518d11769b0d6951f718224a1ed2954708cf"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"dc7aa873874a50c794753edf7577b191aea298fa","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                      \"to push to the remote site.\\n\""},{"line_number":81,"context_line":"                      \"Specify a name, description, router, and subnet \""},{"line_number":82,"context_line":"                      \"for the VPN Service. \""},{"line_number":83,"context_line":"                      \"Admin State is UP (checked) by default.\\n\\n\""},{"line_number":84,"context_line":"                      \"The router, subnet and admin state are required, \""},{"line_number":85,"context_line":"                      \"all others are optional.\""},{"line_number":86,"context_line":"                      )"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a8ffd7b_e757b8c8","line":83,"updated":"2015-11-24 16:46:35.000000000","message":"Instead of checked here, maybe you should say \"True\" to stay consistent with the \"False\" on line 36 above.","commit_id":"c93829e4e9cb20bda42c9fb85fc140b4de1a909f"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"dc7aa873874a50c794753edf7577b191aea298fa","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                      \"for the VPN Service. \""},{"line_number":83,"context_line":"                      \"Admin State is UP (checked) by default.\\n\\n\""},{"line_number":84,"context_line":"                      \"The router, subnet and admin state are required, \""},{"line_number":85,"context_line":"                      \"all others are optional.\""},{"line_number":86,"context_line":"                      )"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a8ffd7b_2704e07c","line":85,"updated":"2015-11-24 16:46:35.000000000","message":"Suggestion: Add the word \"fields\" after \"admin state\".","commit_id":"c93829e4e9cb20bda42c9fb85fc140b4de1a909f"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"dc7aa873874a50c794753edf7577b191aea298fa","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        name \u003d _(\"Add New IKE Policy\")"},{"line_number":180,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":181,"context_line":"        help_text \u003d _(\"Create IKE Policy for current project.\\n\\n\""},{"line_number":182,"context_line":"                      \"The IKE policy is an association \""},{"line_number":183,"context_line":"                      \"of the following attributes:\\n\\n\""},{"line_number":184,"context_line":"                      \"\u003cli\u003eEncryption algorithm: \""},{"line_number":185,"context_line":"                      \"Type of algorithm (3des, aes-128, aes-192, aes-256) \""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a8ffd7b_d0c908ae","line":182,"updated":"2015-11-24 16:46:35.000000000","message":"Suggestion: Change \"The\" to \"An\" to start the sentence.","commit_id":"c93829e4e9cb20bda42c9fb85fc140b4de1a909f"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"dc7aa873874a50c794753edf7577b191aea298fa","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                      \"The IKE policy is an association \""},{"line_number":183,"context_line":"                      \"of the following attributes:\\n\\n\""},{"line_number":184,"context_line":"                      \"\u003cli\u003eEncryption algorithm: \""},{"line_number":185,"context_line":"                      \"Type of algorithm (3des, aes-128, aes-192, aes-256) \""},{"line_number":186,"context_line":"                      \"used in the IKE Policy.\u003c/li\u003e\""},{"line_number":187,"context_line":"                      \"\u003cli\u003eIKE version: The type of version (v1/v2) \""},{"line_number":188,"context_line":"                      \"that needs to be filtered.\u003c/li\u003e\""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a8ffd7b_10823053","line":185,"updated":"2015-11-24 16:46:35.000000000","message":"Suggestion: Change the above to: \"The type of encryption algorithm...\"","commit_id":"c93829e4e9cb20bda42c9fb85fc140b4de1a909f"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"dc7aa873874a50c794753edf7577b191aea298fa","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                      \"\u003cli\u003eLifetime: String with lifetime \""},{"line_number":190,"context_line":"                      \"specific parameters. \""},{"line_number":191,"context_line":"                      \"Units in \u0027seconds\u0027 \""},{"line_number":192,"context_line":"                      \"and value equal to 3600(by default)\u003c/li\u003e\\n\""},{"line_number":193,"context_line":"                      \"Name and description are optional, \""},{"line_number":194,"context_line":"                      \"all others are required.\""},{"line_number":195,"context_line":"                      )"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a8ffd7b_958932cd","line":192,"updated":"2015-11-24 16:46:35.000000000","message":"Missing space between \u00273600\u0027 and \u0027(by default)\u0027.\n\nAlso missing period at the end.","commit_id":"c93829e4e9cb20bda42c9fb85fc140b4de1a909f"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"dc7aa873874a50c794753edf7577b191aea298fa","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                      \"Units in \u0027seconds\u0027 \""},{"line_number":192,"context_line":"                      \"and value equal to 3600(by default)\u003c/li\u003e\\n\""},{"line_number":193,"context_line":"                      \"Name and description are optional, \""},{"line_number":194,"context_line":"                      \"all others are required.\""},{"line_number":195,"context_line":"                      )"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a8ffd7b_f548be89","line":194,"updated":"2015-11-24 16:46:35.000000000","message":"Suggestion: Change the above to: \"The name and description fields are optional, all others are required.\"","commit_id":"c93829e4e9cb20bda42c9fb85fc140b4de1a909f"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"dc7aa873874a50c794753edf7577b191aea298fa","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        name \u003d _(\"Add New IPSec Policy\")"},{"line_number":295,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":296,"context_line":"        help_text \u003d _(\"Create IPSec Policy for current project.\\n\\n\""},{"line_number":297,"context_line":"                      \"The IPSec policy is an association \""},{"line_number":298,"context_line":"                      \"of the following attributes:\\n\\n\""},{"line_number":299,"context_line":"                      \"\u003cli\u003eEncapsulation mode: \""},{"line_number":300,"context_line":"                      \"Type of IPsec tunnel (tunnel/transport) \""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a8ffd7b_b0e4840d","line":297,"updated":"2015-11-24 16:46:35.000000000","message":"Suggestion: Change \"The\" to \"An\" to start the sentence.","commit_id":"c93829e4e9cb20bda42c9fb85fc140b4de1a909f"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"dc7aa873874a50c794753edf7577b191aea298fa","unresolved":false,"context_lines":[{"line_number":300,"context_line":"                      \"Type of IPsec tunnel (tunnel/transport) \""},{"line_number":301,"context_line":"                      \"that needs to be checked.\u003c/li\u003e\""},{"line_number":302,"context_line":"                      \"\u003cli\u003eEncryption algorithm: \""},{"line_number":303,"context_line":"                      \"Type of algorithm (3des, aes-128, aes-192, aes-256) \""},{"line_number":304,"context_line":"                      \"used in the IPSec Policy.\u003c/li\u003e\""},{"line_number":305,"context_line":"                      \"\u003cli\u003eIKE version: \""},{"line_number":306,"context_line":"                      \"The type of version (v1/v2) \""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a8ffd7b_30bbb4c6","line":303,"updated":"2015-11-24 16:46:35.000000000","message":"Suggestion: Change the above to: \"The type of encryption algorithm...\"","commit_id":"c93829e4e9cb20bda42c9fb85fc140b4de1a909f"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"dc7aa873874a50c794753edf7577b191aea298fa","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                      \"\u003cli\u003eLifetime: String with lifetime \""},{"line_number":309,"context_line":"                      \"specific parameters.\u003c/li\u003e\\n\""},{"line_number":310,"context_line":"                      \"Name and description are optional, \""},{"line_number":311,"context_line":"                      \"all others are required.\""},{"line_number":312,"context_line":"                      )"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a8ffd7b_474fa492","line":311,"updated":"2015-11-24 16:46:35.000000000","message":"Suggestion: Change the above to: \"The name and description fields are optional, all others are required.\"","commit_id":"c93829e4e9cb20bda42c9fb85fc140b4de1a909f"},{"author":{"_account_id":16769,"name":"Lucas Palm","email":"lapalm@us.ibm.com","username":"lucaspalm"},"change_message_id":"dc7aa873874a50c794753edf7577b191aea298fa","unresolved":false,"context_lines":[{"line_number":470,"context_line":"                                       label\u003d_(\"Admin State\"),"},{"line_number":471,"context_line":"                                       required\u003dFalse,"},{"line_number":472,"context_line":"                                       help_text\u003d_(\"The state of \""},{"line_number":473,"context_line":"                                                   \"VPN services. \""},{"line_number":474,"context_line":"                                                   \"If DOWN (False), \""},{"line_number":475,"context_line":"                                                   \"port does \""},{"line_number":476,"context_line":"                                                   \"not forward packets.\"))"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a8ffd7b_164d4872","line":473,"updated":"2015-11-24 16:46:35.000000000","message":"This line is missing \"to start in\" as seen up above on line 35.","commit_id":"c93829e4e9cb20bda42c9fb85fc140b4de1a909f"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"c7bda62aaef818ffc388c053560f2674c6fca27b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                      \"for the VPN Service. \""},{"line_number":83,"context_line":"                      \"Admin State is UP (True) by default.\\n\\n\""},{"line_number":84,"context_line":"                      \"The router, subnet and admin state \""},{"line_number":85,"context_line":"                      \"fileds are required, \""},{"line_number":86,"context_line":"                      \"all others are optional.\""},{"line_number":87,"context_line":"                      )"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_a0173a50","line":85,"updated":"2015-11-25 04:13:54.000000000","message":"fileds -\u003e fields","commit_id":"efeed46df94de255b9d8c0c3d315516c416d1593"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"c7bda62aaef818ffc388c053560f2674c6fca27b","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                      \"specific parameters. \""},{"line_number":193,"context_line":"                      \"Units in \u0027seconds\u0027 \""},{"line_number":194,"context_line":"                      \"and value equal to 3600 (by default).\u003c/li\u003e\\n\""},{"line_number":195,"context_line":"                      \"The name and description fileds are optional, \""},{"line_number":196,"context_line":"                      \"all others are required.\""},{"line_number":197,"context_line":"                      )"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_0007261d","line":195,"updated":"2015-11-25 04:13:54.000000000","message":"fileds -\u003e fields","commit_id":"efeed46df94de255b9d8c0c3d315516c416d1593"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"c7bda62aaef818ffc388c053560f2674c6fca27b","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                      \"that needs to be filtered.\u003c/li\u003e\""},{"line_number":311,"context_line":"                      \"\u003cli\u003eLifetime: String with lifetime \""},{"line_number":312,"context_line":"                      \"specific parameters.\u003c/li\u003e\\n\""},{"line_number":313,"context_line":"                      \"The name and description fileds are optional, \""},{"line_number":314,"context_line":"                      \"all others are required.\""},{"line_number":315,"context_line":"                      )"},{"line_number":316,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a8ffd7b_a30e6432","line":313,"updated":"2015-11-25 04:13:54.000000000","message":"fileds -\u003e fields","commit_id":"efeed46df94de255b9d8c0c3d315516c416d1593"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"0bda723a6bba778b0e1673104728d461e84995f0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        max_length\u003d80, label\u003d_(\"Description\"))"},{"line_number":29,"context_line":"    router_id \u003d forms.ChoiceField(label\u003d_(\"Router\"))"},{"line_number":30,"context_line":"    subnet_id \u003d forms.ChoiceField(label\u003d_(\"Subnet\"))"},{"line_number":31,"context_line":"    admin_state_up \u003d forms.ChoiceField(choices\u003d[(True, _(\u0027UP\u0027)),"},{"line_number":32,"context_line":"                                                (False, _(\u0027DOWN\u0027))],"},{"line_number":33,"context_line":"                                       label\u003d_(\"Admin State\"),"},{"line_number":34,"context_line":"                                       help_text\u003d_(\"The state of \""}],"source_content_type":"text/x-python","patch_set":16,"id":"9a8ffd7b_ffb062df","line":31,"updated":"2015-11-25 14:11:20.000000000","message":"Please consider the following alignment to make this more readable:\n\nadmin_state_up \u003d forms.ChoiceField(\n    choices\u003d[(True, _(\u0027UP\u0027)), (False, _(\u0027DOWN\u0027))],\n    label\u003d_(\"Admin State\"),\n...","commit_id":"e70ec235d10e01e8d45cdac84a7eaae28c9c3943"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"0bda723a6bba778b0e1673104728d461e84995f0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":76,"context_line":"        help_text \u003d _(\"Create VPN Service for current project.\\n\\n\""},{"line_number":77,"context_line":"                      \"The service defines where to run the VPN service. \""},{"line_number":78,"context_line":"                      \"They are attached to a router \""},{"line_number":79,"context_line":"                      \"and reference a single sub-network \""},{"line_number":80,"context_line":"                      \"to push to the remote site.\\n\""},{"line_number":81,"context_line":"                      \"Specify a name, description, router, and subnet \""}],"source_content_type":"text/x-python","patch_set":16,"id":"9a8ffd7b_9a47e44a","line":78,"updated":"2015-11-25 14:11:20.000000000","message":"Could you please rephrase this? It\u0027s quite confusing for a user who are \"they\" if we don\u0027t use plural before.","commit_id":"e70ec235d10e01e8d45cdac84a7eaae28c9c3943"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"0bda723a6bba778b0e1673104728d461e84995f0","unresolved":false,"context_lines":[{"line_number":468,"context_line":"        required\u003dFalse,"},{"line_number":469,"context_line":"        help_text\u003d_(\"Valid integer greater than the DPD interval\"))"},{"line_number":470,"context_line":"    initiator \u003d forms.ChoiceField(label\u003d_(\"Initiator state\"), required\u003dFalse)"},{"line_number":471,"context_line":"    admin_state_up \u003d forms.ChoiceField(choices\u003d[(True, _(\u0027UP\u0027)),"},{"line_number":472,"context_line":"                                                (False, _(\u0027DOWN\u0027))],"},{"line_number":473,"context_line":"                                       label\u003d_(\"Admin State\"),"},{"line_number":474,"context_line":"                                       required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a8ffd7b_1fb446cf","line":471,"updated":"2015-11-25 14:11:20.000000000","message":"ditto","commit_id":"e70ec235d10e01e8d45cdac84a7eaae28c9c3943"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"545bb303f5cccf3110036c8258c2adfb08799a21","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        max_length\u003d80, label\u003d_(\"Description\"))"},{"line_number":29,"context_line":"    router_id \u003d forms.ChoiceField(label\u003d_(\"Router\"))"},{"line_number":30,"context_line":"    subnet_id \u003d forms.ChoiceField(label\u003d_(\"Subnet\"))"},{"line_number":31,"context_line":"    admin_state_up \u003d forms.ChoiceField(choices\u003d[(True, _(\u0027UP\u0027)),"},{"line_number":32,"context_line":"                                                (False, _(\u0027DOWN\u0027))],"},{"line_number":33,"context_line":"                                       label\u003d_(\"Admin State\"),"},{"line_number":34,"context_line":"                                       help_text\u003d_(\"The state of \""}],"source_content_type":"text/x-python","patch_set":17,"id":"9a8ffd7b_a8c26f32","line":31,"updated":"2015-11-26 10:41:51.000000000","message":"Please consider:\n\n    admin_state_up \u003d forms.ChoiceField(\n        choices\u003d[(True, _(\u0027UP\u0027)), (False, _(\u0027DOWN\u0027))],\n        label\u003d_(\"Admin State\"),\n        help_text\u003d_(\"The state of VPN services to start in. \"\n                    \"If DOWN (False), port does not forward packets.\"),\n        required\u003dFalse)\n\nInstead of five short lines of help text we get only two. It\u0027s much more readable and let us care less about whitespaces at the end of lines :)","commit_id":"299e370e89548173c53667890a4d4143e1de9057"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"06c4a26b87c669a1a1089656c86c3a3ff96029c0","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                      \"specific parameters. \""},{"line_number":192,"context_line":"                      \"Units in \u0027seconds\u0027 \""},{"line_number":193,"context_line":"                      \"and value equal to 3600 (by default).\u003c/li\u003e\\n\""},{"line_number":194,"context_line":"                      \"The name and description fields are optional, \""},{"line_number":195,"context_line":"                      \"all others are required.\""},{"line_number":196,"context_line":"                      )"},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9a8ffd7b_9b3b459c","line":194,"updated":"2015-11-26 03:25:08.000000000","message":"If the Lifetime has a default value, then why is it not optional ???\n\nEdit:On the hindsight, I think we need to verify what are the actual values which are optional. Please see the standard output of the help file of neutron vpn-ikepolicy-create:\n\n\nusage: neutron vpn-ikepolicy-create [-h]\n                                    [--description DESCRIPTION]\n\n                                    [--encryption-algorithm ENCRYPTION_ALGORITHM]\n\n                                    [--phase1-negotiation-mode {main}]\n\n                                    [--ike-version {v1,v2}]\n\n                                    [--lifetime units\u003dUNITS,value\u003dVALUE]\n                                    NAME\n\nSeems Name is Required, others are optional.","commit_id":"299e370e89548173c53667890a4d4143e1de9057"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"06c4a26b87c669a1a1089656c86c3a3ff96029c0","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                      \"The type of version (v1/v2) \""},{"line_number":309,"context_line":"                      \"that needs to be filtered.\u003c/li\u003e\""},{"line_number":310,"context_line":"                      \"\u003cli\u003eLifetime: String with lifetime \""},{"line_number":311,"context_line":"                      \"specific parameters.\u003c/li\u003e\\n\""},{"line_number":312,"context_line":"                      \"The name and description fields are optional, \""},{"line_number":313,"context_line":"                      \"all others are required.\""},{"line_number":314,"context_line":"                      )"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a8ffd7b_9b6265ac","line":311,"updated":"2015-11-26 03:25:08.000000000","message":"Can you verify if the Lifetime attribute for IPSecPolicy also has a default value?\nIf yes, then maybe it is also optional??","commit_id":"299e370e89548173c53667890a4d4143e1de9057"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"545bb303f5cccf3110036c8258c2adfb08799a21","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        required\u003dFalse,"},{"line_number":471,"context_line":"        help_text\u003d_(\"Valid integer greater than the DPD interval\"))"},{"line_number":472,"context_line":"    initiator \u003d forms.ChoiceField(label\u003d_(\"Initiator state\"), required\u003dFalse)"},{"line_number":473,"context_line":"    admin_state_up \u003d forms.ChoiceField(choices\u003d[(True, _(\u0027UP\u0027)),"},{"line_number":474,"context_line":"                                                (False, _(\u0027DOWN\u0027))],"},{"line_number":475,"context_line":"                                       label\u003d_(\"Admin State\"),"},{"line_number":476,"context_line":"                                       required\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a8ffd7b_e82877e4","line":473,"updated":"2015-11-26 10:41:51.000000000","message":"Here we could do the same.","commit_id":"299e370e89548173c53667890a4d4143e1de9057"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"8effee044ae9c0535be6a3431aa1be9a19c101a7","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                      \"The type of version (v1/v2) \""},{"line_number":305,"context_line":"                      \"that needs to be filtered.\u003c/li\u003e\""},{"line_number":306,"context_line":"                      \"\u003cli\u003eLifetime: String with lifetime \""},{"line_number":307,"context_line":"                      \"specific parameters.\u003c/li\u003e\\n\""},{"line_number":308,"context_line":"                      \"The name and description fields are optional, \""},{"line_number":309,"context_line":"                      \"all others are required.\""},{"line_number":310,"context_line":"                      )"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_86b3734c","line":307,"updated":"2015-11-30 06:17:46.000000000","message":"Can you verify if the Lifetime attribute for IPSecPolicy also has a default value? If yes, then maybe it is also optional??","commit_id":"0ef69394fa6327a5b0638c2fa77bbb3f0605b99f"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"7c4e739627cb4c112e9f3c624cc90fbda2d98831","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        max_length\u003d80,"},{"line_number":383,"context_line":"        label\u003d_(\"Pre-Shared Key (PSK) string\"),"},{"line_number":384,"context_line":"        help_text\u003d_(\"The password \""},{"line_number":385,"context_line":"                    \"between the two ends of the VPN connection\"))"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def populate_ikepolicy_id_choices(self, request, context):"},{"line_number":388,"context_line":"        ikepolicy_id_choices \u003d [(\u0027\u0027, _(\"Select IKE Policy\"))]"}],"source_content_type":"text/x-python","patch_set":19,"id":"9a8ffd7b_8699337b","line":385,"updated":"2015-11-30 06:38:22.000000000","message":"There is no period.","commit_id":"0ef69394fa6327a5b0638c2fa77bbb3f0605b99f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a17aca7870438ec1e95d07d53790a56983371c4","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":73,"context_line":"        help_text \u003d _(\"Create VPN Service for current project.\\n\\n\""},{"line_number":74,"context_line":"                      \"The VPN service is attached to a router \""},{"line_number":75,"context_line":"                      \"and reference a single sub-network \""},{"line_number":76,"context_line":"                      \"to push to the remote site.\\n\""},{"line_number":77,"context_line":"                      \"Specify a name, description, router, and subnet \""},{"line_number":78,"context_line":"                      \"for the VPN Service. \""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a740942_d15cc6f2","line":75,"updated":"2015-12-09 11:33:34.000000000","message":"What is the subject of \u0027reference\u0027? If it is \u0027the VPN service\u0027, it should be \u0027references to\u0027.","commit_id":"58dbf62d1e8ad54b08d0b38804fbd9c89e15562b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a17aca7870438ec1e95d07d53790a56983371c4","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        help_text \u003d _(\"Create VPN Service for current project.\\n\\n\""},{"line_number":74,"context_line":"                      \"The VPN service is attached to a router \""},{"line_number":75,"context_line":"                      \"and reference a single sub-network \""},{"line_number":76,"context_line":"                      \"to push to the remote site.\\n\""},{"line_number":77,"context_line":"                      \"Specify a name, description, router, and subnet \""},{"line_number":78,"context_line":"                      \"for the VPN Service. \""},{"line_number":79,"context_line":"                      \"Admin State is UP (True) by default.\\n\\n\""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a740942_b15b3af6","line":76,"updated":"2015-12-09 11:33:34.000000000","message":"the remote site -\u003e a remote site?","commit_id":"58dbf62d1e8ad54b08d0b38804fbd9c89e15562b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a17aca7870438ec1e95d07d53790a56983371c4","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                      \"An IKE policy is an association \""},{"line_number":180,"context_line":"                      \"of the following attributes:\\n\\n\""},{"line_number":181,"context_line":"                      \"\u003cli\u003eAuthorization algorithm: \""},{"line_number":182,"context_line":"                      \"Auth_algorithm limited to SHA1 only.\u003c/li\u003e\""},{"line_number":183,"context_line":"                      \"\u003cli\u003eEncryption algorithm: \""},{"line_number":184,"context_line":"                      \"The type of algorithm \""},{"line_number":185,"context_line":"                      \"(3des, aes-128, aes-192, aes-256) \""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a740942_f1d3025e","line":182,"updated":"2015-12-09 11:33:34.000000000","message":"An underscore is unnecessary in the help message. This is not a parameter.  \"Auth algorithm\u0027","commit_id":"58dbf62d1e8ad54b08d0b38804fbd9c89e15562b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a17aca7870438ec1e95d07d53790a56983371c4","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                      \"used in the IKE Policy.\u003c/li\u003e\""},{"line_number":187,"context_line":"                      \"\u003cli\u003eIKE version: The type of version (v1/v2) \""},{"line_number":188,"context_line":"                      \"that needs to be filtered.\u003c/li\u003e\""},{"line_number":189,"context_line":"                      \"\u003cli\u003eLifetime: String with lifetime \""},{"line_number":190,"context_line":"                      \"specific parameters. \""},{"line_number":191,"context_line":"                      \"Units in \u0027seconds\u0027 \""},{"line_number":192,"context_line":"                      \"and value equal to 3600 (by default).\u003c/li\u003e\""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a740942_d12a862f","line":189,"range":{"start_line":189,"start_character":37,"end_line":189,"end_character":44},"updated":"2015-12-09 11:33:34.000000000","message":"Why \u0027String\u0027? lifetime consists of value and units. It looks odd.","commit_id":"58dbf62d1e8ad54b08d0b38804fbd9c89e15562b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a17aca7870438ec1e95d07d53790a56983371c4","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                      \"\u003cli\u003eLifetime: String with lifetime \""},{"line_number":190,"context_line":"                      \"specific parameters. \""},{"line_number":191,"context_line":"                      \"Units in \u0027seconds\u0027 \""},{"line_number":192,"context_line":"                      \"and value equal to 3600 (by default).\u003c/li\u003e\""},{"line_number":193,"context_line":"                      \"\u003cli\u003ePerfect Forward Secrecy: \""},{"line_number":194,"context_line":"                      \"PFS limited to using Diffie-Hellman \""},{"line_number":195,"context_line":"                      \"groups 2,5(default), and 14.\u003c/li\u003e\""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a740942_9124fe60","line":192,"updated":"2015-12-09 11:33:34.000000000","message":"the default value is 3600.","commit_id":"58dbf62d1e8ad54b08d0b38804fbd9c89e15562b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a17aca7870438ec1e95d07d53790a56983371c4","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                      \"and value equal to 3600 (by default).\u003c/li\u003e\""},{"line_number":193,"context_line":"                      \"\u003cli\u003ePerfect Forward Secrecy: \""},{"line_number":194,"context_line":"                      \"PFS limited to using Diffie-Hellman \""},{"line_number":195,"context_line":"                      \"groups 2,5(default), and 14.\u003c/li\u003e\""},{"line_number":196,"context_line":"                      \"\u003cli\u003eIKE Phase 1 negotiation mode: \""},{"line_number":197,"context_line":"                      \"Limited to \u0027main\u0027 mode only.\u003c/li\u003e\\n\""},{"line_number":198,"context_line":"                      \"All fields are optional.\""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a740942_d1d12631","line":195,"updated":"2015-12-09 11:33:34.000000000","message":"Needs a space before 5.","commit_id":"58dbf62d1e8ad54b08d0b38804fbd9c89e15562b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a17aca7870438ec1e95d07d53790a56983371c4","unresolved":false,"context_lines":[{"line_number":303,"context_line":"                      \"\u003cli\u003eAuthorization algorithm: \""},{"line_number":304,"context_line":"                      \"Auth_algorithm limited to SHA1 only.\u003c/li\u003e\""},{"line_number":305,"context_line":"                      \"\u003cli\u003eEncapsulation mode: \""},{"line_number":306,"context_line":"                      \"The type of IPsec tunnel (tunnel/transport) \""},{"line_number":307,"context_line":"                      \"that needs to be checked.\u003c/li\u003e\""},{"line_number":308,"context_line":"                      \"\u003cli\u003eEncryption algorithm: \""},{"line_number":309,"context_line":"                      \"The type of algorithm \""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a740942_71915252","line":306,"updated":"2015-12-09 11:33:34.000000000","message":"IPsec -\u003e IPSec\n\nIn this form, \u0027IPSec\u0027 is used.\n\nI think \u0027IPsec\u0027 is more widely used but it is not a scope of this patch.","commit_id":"58dbf62d1e8ad54b08d0b38804fbd9c89e15562b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a17aca7870438ec1e95d07d53790a56983371c4","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                      \"Auth_algorithm limited to SHA1 only.\u003c/li\u003e\""},{"line_number":305,"context_line":"                      \"\u003cli\u003eEncapsulation mode: \""},{"line_number":306,"context_line":"                      \"The type of IPsec tunnel (tunnel/transport) \""},{"line_number":307,"context_line":"                      \"that needs to be checked.\u003c/li\u003e\""},{"line_number":308,"context_line":"                      \"\u003cli\u003eEncryption algorithm: \""},{"line_number":309,"context_line":"                      \"The type of algorithm \""},{"line_number":310,"context_line":"                      \"(3des, aes-128, aes-192, aes-256) \""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a740942_d1b846eb","line":307,"updated":"2015-12-09 11:33:34.000000000","message":"Why \u0027checked\u0027?\n\n  The type of IPsec tunnel to be used.","commit_id":"58dbf62d1e8ad54b08d0b38804fbd9c89e15562b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a17aca7870438ec1e95d07d53790a56983371c4","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                      \"(3des, aes-128, aes-192, aes-256) \""},{"line_number":311,"context_line":"                      \"used in the IPSec Policy.\u003c/li\u003e\""},{"line_number":312,"context_line":"                      \"\u003cli\u003eLifetime: String with lifetime \""},{"line_number":313,"context_line":"                      \"specific parameters.\u003c/li\u003e\""},{"line_number":314,"context_line":"                      \"\u003cli\u003ePerfect Forward Secrecy: \""},{"line_number":315,"context_line":"                      \"PFS limited to using Diffie-Hellman \""},{"line_number":316,"context_line":"                      \"groups 2,5(default), and 14.\u003c/li\u003e\""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a740942_d1860616","line":313,"updated":"2015-12-09 11:33:34.000000000","message":"same comment as for IKE policy.","commit_id":"58dbf62d1e8ad54b08d0b38804fbd9c89e15562b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a17aca7870438ec1e95d07d53790a56983371c4","unresolved":false,"context_lines":[{"line_number":313,"context_line":"                      \"specific parameters.\u003c/li\u003e\""},{"line_number":314,"context_line":"                      \"\u003cli\u003ePerfect Forward Secrecy: \""},{"line_number":315,"context_line":"                      \"PFS limited to using Diffie-Hellman \""},{"line_number":316,"context_line":"                      \"groups 2,5(default), and 14.\u003c/li\u003e\""},{"line_number":317,"context_line":"                      \"\u003cli\u003eTransform Protocol: \""},{"line_number":318,"context_line":"                      \"The type of protocol \""},{"line_number":319,"context_line":"                      \"(esp, ah, ah-esp) that needs to be specified.\u003c/li\u003e\\n\""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a740942_f18b021d","line":316,"updated":"2015-12-09 11:33:34.000000000","message":"A space before 5","commit_id":"58dbf62d1e8ad54b08d0b38804fbd9c89e15562b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a17aca7870438ec1e95d07d53790a56983371c4","unresolved":false,"context_lines":[{"line_number":316,"context_line":"                      \"groups 2,5(default), and 14.\u003c/li\u003e\""},{"line_number":317,"context_line":"                      \"\u003cli\u003eTransform Protocol: \""},{"line_number":318,"context_line":"                      \"The type of protocol \""},{"line_number":319,"context_line":"                      \"(esp, ah, ah-esp) that needs to be specified.\u003c/li\u003e\\n\""},{"line_number":320,"context_line":"                      \"All fields are optional.\""},{"line_number":321,"context_line":"                      )"},{"line_number":322,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"7a740942_719f1251","line":319,"updated":"2015-12-09 11:33:34.000000000","message":"I think \u0027needs to be specified\u0027 looks odd because we are specify a parameter in the form. Please consider rewording.","commit_id":"58dbf62d1e8ad54b08d0b38804fbd9c89e15562b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a17aca7870438ec1e95d07d53790a56983371c4","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        max_length\u003d80,"},{"line_number":394,"context_line":"        label\u003d_(\"Pre-Shared Key (PSK) string\"),"},{"line_number":395,"context_line":"        help_text\u003d_(\"The password \""},{"line_number":396,"context_line":"                    \"between the two ends of the VPN connection\"))"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    def populate_ikepolicy_id_choices(self, request, context):"},{"line_number":399,"context_line":"        ikepolicy_id_choices \u003d [(\u0027\u0027, _(\"Select IKE Policy\"))]"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a740942_11ac8e8b","line":396,"updated":"2015-12-09 11:33:34.000000000","message":"ends -\u003e peers","commit_id":"58dbf62d1e8ad54b08d0b38804fbd9c89e15562b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a17aca7870438ec1e95d07d53790a56983371c4","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        choices\u003d[(True, _(\u0027UP\u0027)), (False, _(\u0027DOWN\u0027))],"},{"line_number":482,"context_line":"        label\u003d_(\"Admin State\"),"},{"line_number":483,"context_line":"        required\u003dFalse,"},{"line_number":484,"context_line":"        help_text\u003d_(\"The state of VPN services to start in \""},{"line_number":485,"context_line":"                    \"If DOWN (False), port does not forward packets.\"))"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def __init__(self, request, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":22,"id":"7a740942_b1b33ae9","line":484,"updated":"2015-12-09 11:33:34.000000000","message":"A period is required after \u0027start in\u0027.","commit_id":"58dbf62d1e8ad54b08d0b38804fbd9c89e15562b"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"936ac6d361e4cf08fc41f8e25051b86ee425c714","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        choices\u003d[(True, _(\u0027UP\u0027)), (False, _(\u0027DOWN\u0027))],"},{"line_number":33,"context_line":"        label\u003d_(\"Admin State\"),"},{"line_number":34,"context_line":"        help_text\u003d_(\"The state of VPN services to start in. \""},{"line_number":35,"context_line":"                    \"If DOWN (False) port does not forward packets.\"),"},{"line_number":36,"context_line":"        required\u003dFalse)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def __init__(self, request, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":24,"id":"7a740942_20eee4ec","line":35,"updated":"2015-12-10 05:17:03.000000000","message":"IMO, change \"port\" to \"VPN Service\" would be better.","commit_id":"576e467eb88a2bc02dcf711b13a2e5b329181538"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"936ac6d361e4cf08fc41f8e25051b86ee425c714","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":73,"context_line":"        help_text \u003d _(\"Create VPN Service for current project.\\n\\n\""},{"line_number":74,"context_line":"                      \"The VPN service is attached to a router \""},{"line_number":75,"context_line":"                      \"and references to a single sub-network \""},{"line_number":76,"context_line":"                      \"to push to a remote site.\\n\""},{"line_number":77,"context_line":"                      \"Specify a name, description, router, and subnet \""},{"line_number":78,"context_line":"                      \"for the VPN Service. \""}],"source_content_type":"text/x-python","patch_set":24,"id":"7a740942_a0b894e6","line":75,"updated":"2015-12-10 05:17:03.000000000","message":"sub-network --\u003e subnet\n\nNotice:\n\nNow VPNaaS support multiple subnets.","commit_id":"576e467eb88a2bc02dcf711b13a2e5b329181538"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"936ac6d361e4cf08fc41f8e25051b86ee425c714","unresolved":false,"context_lines":[{"line_number":392,"context_line":"    psk \u003d forms.CharField("},{"line_number":393,"context_line":"        max_length\u003d80,"},{"line_number":394,"context_line":"        label\u003d_(\"Pre-Shared Key (PSK) string\"),"},{"line_number":395,"context_line":"        help_text\u003d_(\"The password \""},{"line_number":396,"context_line":"                    \"between the two peers of the VPN connection\"))"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    def populate_ikepolicy_id_choices(self, request, context):"}],"source_content_type":"text/x-python","patch_set":24,"id":"7a740942_c08e0027","line":395,"updated":"2015-12-10 05:17:03.000000000","message":"password --\u003e pre-defined key string","commit_id":"576e467eb88a2bc02dcf711b13a2e5b329181538"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"936ac6d361e4cf08fc41f8e25051b86ee425c714","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        choices\u003d[(True, _(\u0027UP\u0027)), (False, _(\u0027DOWN\u0027))],"},{"line_number":482,"context_line":"        label\u003d_(\"Admin State\"),"},{"line_number":483,"context_line":"        required\u003dFalse,"},{"line_number":484,"context_line":"        help_text\u003d_(\"The state of VPN services to start in. \""},{"line_number":485,"context_line":"                    \"If DOWN (False), port does not forward packets.\"))"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def __init__(self, request, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":24,"id":"7a740942_00c4083e","line":484,"updated":"2015-12-10 05:17:03.000000000","message":"VPN services -\u003e IPSecSiteConnection ?","commit_id":"576e467eb88a2bc02dcf711b13a2e5b329181538"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"936ac6d361e4cf08fc41f8e25051b86ee425c714","unresolved":false,"context_lines":[{"line_number":482,"context_line":"        label\u003d_(\"Admin State\"),"},{"line_number":483,"context_line":"        required\u003dFalse,"},{"line_number":484,"context_line":"        help_text\u003d_(\"The state of VPN services to start in. \""},{"line_number":485,"context_line":"                    \"If DOWN (False), port does not forward packets.\"))"},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":488,"context_line":"        super(AddIPSecSiteConnectionOptionalAction, self).__init__("}],"source_content_type":"text/x-python","patch_set":24,"id":"7a740942_8098f86b","line":485,"updated":"2015-12-10 05:17:03.000000000","message":"port -\u003e IPSec site connection","commit_id":"576e467eb88a2bc02dcf711b13a2e5b329181538"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"b66e711cb39191ab858467b40410ca0ac1afc7aa","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":73,"context_line":"        help_text \u003d _(\"Create VPN Service for current project.\\n\\n\""},{"line_number":74,"context_line":"                      \"The VPN service is attached to a router \""},{"line_number":75,"context_line":"                      \"and references to a single subnet \""},{"line_number":76,"context_line":"                      \"to push to a remote site.\\n\""},{"line_number":77,"context_line":"                      \"Specify a name, description, router, and subnet \""},{"line_number":78,"context_line":"                      \"for the VPN Service. \""}],"source_content_type":"text/x-python","patch_set":25,"id":"7a740942_f5f098cb","line":75,"updated":"2015-12-10 11:43:51.000000000","message":"\"to a single subnet or multiple subnets\"","commit_id":"66dcd8438670cb70c066cc9ae807d12a4bc2f0b6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"659c1527778c7c4a4f5a1ec5567d820f14ae939b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":73,"context_line":"        help_text \u003d _(\"Create VPN Service for current project.\\n\\n\""},{"line_number":74,"context_line":"                      \"The VPN service is attached to a router \""},{"line_number":75,"context_line":"                      \"and references to a single subnet \""},{"line_number":76,"context_line":"                      \"to push to a remote site.\\n\""},{"line_number":77,"context_line":"                      \"Specify a name, description, router, and subnet \""},{"line_number":78,"context_line":"                      \"for the VPN Service. \""}],"source_content_type":"text/x-python","patch_set":25,"id":"7a740942_1a1225b5","line":75,"in_reply_to":"7a740942_f5f098cb","updated":"2015-12-10 12:12:32.000000000","message":"At this moment, \"a single subnet\" is correct. No need to change.\n\nHorizon does not support multiple subnets yet. I know rob plans to support multiple subnets in VPNaaS.","commit_id":"66dcd8438670cb70c066cc9ae807d12a4bc2f0b6"}]}
